mirror of
https://github.com/OrcaSlicer/OrcaSlicer.git
synced 2026-10-13 10:51:12 +00:00
Compare commits
49
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
af29e4d553 | ||
|
|
df392508b7 | ||
|
|
11493a2236 | ||
|
|
df4c8cd531 | ||
|
|
bf5a378479 | ||
|
|
01499e536e | ||
|
|
f33a9bf999 | ||
|
|
869e450981 | ||
|
|
b920116fbd | ||
|
|
237586675f | ||
|
|
6d35ff6b9a | ||
|
|
075b03975f | ||
|
|
a379ec4a67 | ||
|
|
6700d4c5df | ||
|
|
a28c9c3a82 | ||
|
|
3dd547c8be | ||
|
|
f0e9cdc470 | ||
|
|
58a71331d0 | ||
|
|
f127b758ed | ||
|
|
1494de66de | ||
|
|
3ca182a98e | ||
|
|
5e19fc0e6c | ||
|
|
3f4709aaa7 | ||
|
|
c63bd5d474 | ||
|
|
6263502697 | ||
|
|
1a9201690d | ||
|
|
c6a338f35f | ||
|
|
4f2d2ae11a | ||
|
|
c57b5dc6c5 | ||
|
|
7149728219 | ||
|
|
f49d49b5a6 | ||
|
|
08f2037cbd | ||
|
|
1abd6649c7 | ||
|
|
d8cae3268a | ||
|
|
7d4ec3494c | ||
|
|
cccf53850e | ||
|
|
5095733323 | ||
|
|
0cec10748e | ||
|
|
3f78959a0c | ||
|
|
30e48183e3 | ||
|
|
56b559d36a | ||
|
|
ed1f3e52c9 | ||
|
|
8ecfee6a21 | ||
|
|
fbf4652e12 | ||
|
|
be9ff50130 | ||
|
|
dee1f1715f | ||
|
|
fcb1f62bd9 | ||
|
|
bea412fddf | ||
|
|
391c53a8da |
@@ -341,12 +341,12 @@ jobs:
|
|||||||
|
|
||||||
# Notarize main DMG
|
# Notarize main DMG
|
||||||
xcrun notarytool submit "OrcaSlicer_Mac_universal_${{ env.ver }}.dmg" --apple-id "${{ secrets.APPLE_DEV_ACCOUNT }}" --team-id "${{ secrets.TEAM_ID }}" --password "${{ secrets.APP_PWD }}" --wait
|
xcrun notarytool submit "OrcaSlicer_Mac_universal_${{ env.ver }}.dmg" --apple-id "${{ secrets.APPLE_DEV_ACCOUNT }}" --team-id "${{ secrets.TEAM_ID }}" --password "${{ secrets.APP_PWD }}" --wait
|
||||||
xcrun stapler staple OrcaSlicer_Mac_universal_${{ env.ver }}.dmg
|
retry xcrun stapler staple OrcaSlicer_Mac_universal_${{ env.ver }}.dmg
|
||||||
|
|
||||||
# Notarize profile validator DMG if it exists
|
# Notarize profile validator DMG if it exists
|
||||||
if [ -f "OrcaSlicer_profile_validator_Mac_universal_${{ env.ver }}.dmg" ]; then
|
if [ -f "OrcaSlicer_profile_validator_Mac_universal_${{ env.ver }}.dmg" ]; then
|
||||||
xcrun notarytool submit "OrcaSlicer_profile_validator_Mac_universal_${{ env.ver }}.dmg" --apple-id "${{ secrets.APPLE_DEV_ACCOUNT }}" --team-id "${{ secrets.TEAM_ID }}" --password "${{ secrets.APP_PWD }}" --wait
|
xcrun notarytool submit "OrcaSlicer_profile_validator_Mac_universal_${{ env.ver }}.dmg" --apple-id "${{ secrets.APPLE_DEV_ACCOUNT }}" --team-id "${{ secrets.TEAM_ID }}" --password "${{ secrets.APP_PWD }}" --wait
|
||||||
xcrun stapler staple OrcaSlicer_profile_validator_Mac_universal_${{ env.ver }}.dmg
|
retry xcrun stapler staple OrcaSlicer_profile_validator_Mac_universal_${{ env.ver }}.dmg
|
||||||
fi
|
fi
|
||||||
|
|
||||||
- name: Create DMG without notary
|
- name: Create DMG without notary
|
||||||
@@ -460,10 +460,6 @@ jobs:
|
|||||||
- name: Build slicer Win
|
- name: Build slicer Win
|
||||||
if: runner.os == 'Windows'
|
if: runner.os == 'Windows'
|
||||||
working-directory: ${{ github.workspace }}
|
working-directory: ${{ github.workspace }}
|
||||||
# Orca: Removed Netfabb STL fixing service support in favor of CGAL.
|
|
||||||
# env:
|
|
||||||
# WindowsSdkDir: 'C:\Program Files (x86)\Windows Kits\10\'
|
|
||||||
# WindowsSDKVersion: '10.0.26100.0\'
|
|
||||||
# --tests builds the unit tests too; the unit_tests_windows_* jobs run them.
|
# --tests builds the unit tests too; the unit_tests_windows_* jobs run them.
|
||||||
run: |
|
run: |
|
||||||
# cache-path is the install directory inside the deps build directory.
|
# cache-path is the install directory inside the deps build directory.
|
||||||
|
|||||||
@@ -16,6 +16,15 @@ on:
|
|||||||
|
|
||||||
permissions:
|
permissions:
|
||||||
contents: read
|
contents: read
|
||||||
|
# Listing caches and builds while waiting for a deps cache.
|
||||||
|
actions: read
|
||||||
|
|
||||||
|
# Read by scripts/ci_deps_cache.sh.
|
||||||
|
env:
|
||||||
|
REPO: ${{ github.repository }}
|
||||||
|
WORKFLOW: build_all.yml
|
||||||
|
BASE_REF: ${{ github.base_ref }}
|
||||||
|
JOB: build_linux (${{ vars.SELF_HOSTED && 'orca-lnx-server' || 'ubuntu-24.04' }})
|
||||||
|
|
||||||
concurrency:
|
concurrency:
|
||||||
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
|
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
|
||||||
@@ -35,7 +44,7 @@ jobs:
|
|||||||
# The PR merge commit plus its first parent, the base it is diffed against.
|
# The PR merge commit plus its first parent, the base it is diffed against.
|
||||||
fetch-depth: 2
|
fetch-depth: 2
|
||||||
|
|
||||||
- name: Look for changed C++ files
|
- name: Look for changed files
|
||||||
id: changes
|
id: changes
|
||||||
run: |
|
run: |
|
||||||
if git -c core.quotePath=false diff --name-only HEAD^1 -- src tests | grep -qE '\.(cpp|cc|cxx|hpp|h|hxx)$'; then
|
if git -c core.quotePath=false diff --name-only HEAD^1 -- src tests | grep -qE '\.(cpp|cc|cxx|hpp|h|hxx)$'; then
|
||||||
@@ -43,18 +52,75 @@ jobs:
|
|||||||
else
|
else
|
||||||
echo "No C++ changes under src/ or tests/."
|
echo "No C++ changes under src/ or tests/."
|
||||||
fi
|
fi
|
||||||
|
if ! git diff --quiet HEAD^1 -- deps; then
|
||||||
|
echo "deps=true" >> "$GITHUB_OUTPUT"
|
||||||
|
fi
|
||||||
|
echo "deps-key=linux-clang-cache-orcaslicer_deps-build-${{ hashFiles('deps/**') }}" >> "$GITHUB_OUTPUT"
|
||||||
|
|
||||||
# Parsing needs the dependency headers, not a build of this PR's deps/, so
|
# Parsing needs the dependency headers, not a build of this PR's deps/.
|
||||||
# a PR that changes deps/ falls back to the newest cache main has.
|
# Without an exact match the job waits for the build that saves it: this
|
||||||
|
# PR's own when it changes deps/, otherwise a running push build of the
|
||||||
|
# base branch with the same deps. With neither, a PR that keeps deps/
|
||||||
|
# falls back to the newest cache.
|
||||||
- name: Restore cached deps
|
- name: Restore cached deps
|
||||||
|
id: deps_cache
|
||||||
if: steps.changes.outputs.cpp == 'true'
|
if: steps.changes.outputs.cpp == 'true'
|
||||||
uses: actions/cache/restore@v6
|
uses: actions/cache/restore@v6
|
||||||
with:
|
with:
|
||||||
path: ${{ github.workspace }}/deps/build/OrcaSlicer_dep
|
path: ${{ github.workspace }}/deps/build/OrcaSlicer_dep
|
||||||
key: linux-clang-cache-orcaslicer_deps-build-${{ hashFiles('deps/**') }}
|
key: ${{ steps.changes.outputs.deps-key }}
|
||||||
|
|
||||||
|
- name: Look for a build to wait for
|
||||||
|
id: wait_check
|
||||||
|
if: steps.changes.outputs.cpp == 'true' && steps.deps_cache.outputs.cache-hit != 'true'
|
||||||
|
env:
|
||||||
|
GH_TOKEN: ${{ github.token }}
|
||||||
|
HEAD_SHA: ${{ github.event.pull_request.head.sha }}
|
||||||
|
run: bash scripts/ci_deps_cache.sh ${{ steps.changes.outputs.deps == 'true' && 'own' || 'check' }}
|
||||||
|
|
||||||
|
# Linux Build Deps takes about 35 minutes on GitHub-hosted runners. The
|
||||||
|
# wait ends early when the deps job fails.
|
||||||
|
- name: Wait for the deps cache
|
||||||
|
if: steps.wait_check.outputs.wait-for != ''
|
||||||
|
timeout-minutes: 100
|
||||||
|
env:
|
||||||
|
GH_TOKEN: ${{ github.token }}
|
||||||
|
KEY: ${{ steps.changes.outputs.deps-key }}
|
||||||
|
CACHE_REF: ${{ steps.changes.outputs.deps == 'true' && github.ref || format('refs/heads/{0}', github.base_ref) }}
|
||||||
|
KEY_INPUTS: ${{ steps.wait_check.outputs.key-inputs }}
|
||||||
|
WAIT_FOR: ${{ steps.wait_check.outputs.wait-for }}
|
||||||
|
WAIT_SINCE: ${{ steps.wait_check.outputs.wait-since }}
|
||||||
|
WAIT_MINUTES: 90
|
||||||
|
run: bash scripts/ci_deps_cache.sh wait
|
||||||
|
|
||||||
|
- name: Restore the deps cache after waiting
|
||||||
|
id: waited_cache
|
||||||
|
if: steps.wait_check.outputs.wait-for != ''
|
||||||
|
uses: actions/cache/restore@v6
|
||||||
|
with:
|
||||||
|
path: ${{ github.workspace }}/deps/build/OrcaSlicer_dep
|
||||||
|
key: ${{ steps.changes.outputs.deps-key }}
|
||||||
|
|
||||||
|
- name: Fail without this PR's deps cache
|
||||||
|
if: steps.changes.outputs.deps == 'true' && steps.wait_check.outcome == 'success' && steps.waited_cache.outputs.cache-hit != 'true'
|
||||||
|
run: |
|
||||||
|
echo "::error::No deps cache ${{ steps.changes.outputs.deps-key }}. Check this PR's Linux Build Deps job, then rerun clang-tidy."
|
||||||
|
exit 1
|
||||||
|
|
||||||
|
- name: Restore the newest cached deps
|
||||||
|
id: newest_cache
|
||||||
|
if: steps.changes.outputs.deps != 'true' && steps.wait_check.outcome == 'success' && steps.waited_cache.outputs.cache-hit != 'true'
|
||||||
|
uses: actions/cache/restore@v6
|
||||||
|
with:
|
||||||
|
path: ${{ github.workspace }}/deps/build/OrcaSlicer_dep
|
||||||
|
key: ${{ steps.changes.outputs.deps-key }}
|
||||||
restore-keys: linux-clang-cache-orcaslicer_deps-build-
|
restore-keys: linux-clang-cache-orcaslicer_deps-build-
|
||||||
fail-on-cache-miss: true
|
fail-on-cache-miss: true
|
||||||
|
|
||||||
|
- name: Warn about older deps
|
||||||
|
if: steps.newest_cache.outcome == 'success' && steps.newest_cache.outputs.cache-hit != 'true'
|
||||||
|
run: echo "::warning title=Older deps::No cache matches this PR's deps/, so clang-tidy parsed against ${{ steps.newest_cache.outputs.cache-matched-key }}. If it reports errors in code that uses a dependency, rerun clang-tidy once the base branch's Build all has saved the new deps."
|
||||||
|
|
||||||
- name: Apt-Install Dependencies
|
- name: Apt-Install Dependencies
|
||||||
if: steps.changes.outputs.cpp == 'true' && !vars.SELF_HOSTED
|
if: steps.changes.outputs.cpp == 'true' && !vars.SELF_HOSTED
|
||||||
uses: ./.github/actions/apt-install-deps
|
uses: ./.github/actions/apt-install-deps
|
||||||
|
|||||||
@@ -1,65 +0,0 @@
|
|||||||
name: clang-tidy fix
|
|
||||||
|
|
||||||
# Makes the missing-include fix that /bot fix-tidy (pr-tidy-bot.yml) posts on a
|
|
||||||
# pull request: scripts/run_clang_tidy.sh --fix on the merge commit the
|
|
||||||
# clang-tidy check runs on, uploaded as the clang-tidy-fix artifact.
|
|
||||||
#
|
|
||||||
# Every push to a PR starts this workflow, and its job skips on that first
|
|
||||||
# attempt. The bot re-runs it on request. A re-run keeps the pull_request
|
|
||||||
# context, so the PR's code runs with a read-only token, no secrets and the
|
|
||||||
# PR's own cache, never main's, whoever asked for it.
|
|
||||||
on:
|
|
||||||
pull_request:
|
|
||||||
branches:
|
|
||||||
- main
|
|
||||||
- release/*
|
|
||||||
|
|
||||||
permissions:
|
|
||||||
contents: read
|
|
||||||
|
|
||||||
jobs:
|
|
||||||
fix:
|
|
||||||
if: github.run_attempt > 1
|
|
||||||
# A hosted runner, so nothing the PR's code leaves behind outlives the job.
|
|
||||||
runs-on: ubuntu-24.04
|
|
||||||
timeout-minutes: 60
|
|
||||||
steps:
|
|
||||||
- name: Checkout
|
|
||||||
uses: actions/checkout@v7
|
|
||||||
with:
|
|
||||||
lfs: 'false'
|
|
||||||
# The PR merge commit plus its first parent, the base it is diffed against.
|
|
||||||
fetch-depth: 2
|
|
||||||
persist-credentials: false
|
|
||||||
|
|
||||||
# Parsing needs the dependency headers, not a build of this PR's deps/, so
|
|
||||||
# a PR that changes deps/ falls back to the newest cache main has.
|
|
||||||
- name: Restore cached deps
|
|
||||||
uses: actions/cache/restore@v6
|
|
||||||
with:
|
|
||||||
path: ${{ github.workspace }}/deps/build/OrcaSlicer_dep
|
|
||||||
key: linux-clang-cache-orcaslicer_deps-build-${{ hashFiles('deps/**') }}
|
|
||||||
restore-keys: linux-clang-cache-orcaslicer_deps-build-
|
|
||||||
fail-on-cache-miss: true
|
|
||||||
|
|
||||||
- name: Apt-Install Dependencies
|
|
||||||
uses: ./.github/actions/apt-install-deps
|
|
||||||
|
|
||||||
# The status says whether findings remain that --fix cannot fix.
|
|
||||||
- name: Fix the changed lines
|
|
||||||
run: |
|
|
||||||
mkdir -p "$RUNNER_TEMP/clang-tidy-fix"
|
|
||||||
status=0
|
|
||||||
scripts/run_clang_tidy.sh --base HEAD^1 --yes --fix || status=$?
|
|
||||||
echo "$status" > "$RUNNER_TEMP/clang-tidy-fix/status"
|
|
||||||
git -c core.quotePath=false diff --no-color --no-ext-diff --src-prefix=a/ --dst-prefix=b/ \
|
|
||||||
> "$RUNNER_TEMP/clang-tidy-fix/fix.patch"
|
|
||||||
|
|
||||||
- name: Upload the fix
|
|
||||||
uses: actions/upload-artifact@v7
|
|
||||||
with:
|
|
||||||
name: clang-tidy-fix
|
|
||||||
path: ${{ runner.temp }}/clang-tidy-fix/
|
|
||||||
retention-days: 7
|
|
||||||
# A later re-run of the same run replaces the earlier fix.
|
|
||||||
overwrite: true
|
|
||||||
@@ -1,476 +0,0 @@
|
|||||||
name: PR clang-tidy Bot
|
|
||||||
|
|
||||||
# Helps a pull request past the clang-tidy check.
|
|
||||||
#
|
|
||||||
# When the check fails on a PR's changes, a comment asks the author to fix it,
|
|
||||||
# either with scripts/run_clang_tidy.sh --fix or by commenting:
|
|
||||||
# /bot fix-tidy
|
|
||||||
#
|
|
||||||
# That command, from the PR's author or an account with write access, re-runs
|
|
||||||
# the PR's clang-tidy fix run (clang_tidy_fix.yml), which makes the fix in the
|
|
||||||
# PR's own context. When it finishes, the fix is posted as one review: each
|
|
||||||
# include whose place falls on a line the PR's diff shows is a suggestion GitHub
|
|
||||||
# can commit in one click, and the review's body holds the whole patch with a
|
|
||||||
# git apply command. Findings --fix cannot fix, such as a using in a header,
|
|
||||||
# are left for the check to report.
|
|
||||||
#
|
|
||||||
# No code from the PR runs here. Nothing is pushed, and the patch is only
|
|
||||||
# posted when every line it adds is an #include in a C++ file the PR changes.
|
|
||||||
#
|
|
||||||
# workflow_run matches the workflows by their name: keep "clang-tidy" and
|
|
||||||
# "clang-tidy fix" in step with clang_tidy.yml and clang_tidy_fix.yml, and
|
|
||||||
# TIDY_STEP below with the clang-tidy step's name in clang_tidy.yml.
|
|
||||||
|
|
||||||
on:
|
|
||||||
issue_comment:
|
|
||||||
types:
|
|
||||||
- created
|
|
||||||
workflow_run:
|
|
||||||
workflows:
|
|
||||||
- clang-tidy
|
|
||||||
- clang-tidy fix
|
|
||||||
types:
|
|
||||||
- completed
|
|
||||||
|
|
||||||
permissions: {}
|
|
||||||
|
|
||||||
jobs:
|
|
||||||
request:
|
|
||||||
# Skips the job unless a PR comment mentions the command.
|
|
||||||
if: >-
|
|
||||||
github.repository == 'OrcaSlicer/OrcaSlicer'
|
|
||||||
&& github.event_name == 'issue_comment'
|
|
||||||
&& github.event.issue.pull_request != null
|
|
||||||
&& contains(github.event.comment.body, '/bot fix-tidy')
|
|
||||||
permissions:
|
|
||||||
actions: write # re-run the fix run
|
|
||||||
pull-requests: write # react to and answer the comment, which is the PR's
|
|
||||||
issues: write # feedback comment + reactions
|
|
||||||
runs-on: ubuntu-latest
|
|
||||||
timeout-minutes: 5
|
|
||||||
steps:
|
|
||||||
- name: Re-run the PR's clang-tidy fix
|
|
||||||
uses: actions/github-script@v9
|
|
||||||
with:
|
|
||||||
script: |
|
|
||||||
const MARKER = '<!-- pr-tidy-bot -->';
|
|
||||||
const FIX_WORKFLOW = 'clang_tidy_fix.yml';
|
|
||||||
|
|
||||||
const { owner, repo } = context.repo;
|
|
||||||
const issue = context.payload.issue;
|
|
||||||
const comment = context.payload.comment;
|
|
||||||
|
|
||||||
// Ignores a comment whose sender is not its author.
|
|
||||||
if (context.payload.sender.login !== comment.user.login || comment.user.type !== 'User') {
|
|
||||||
core.info('Ignoring a comment not written by its sender, or by a bot.');
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
const commandLine = (comment.body || '')
|
|
||||||
.split('\n')
|
|
||||||
.map((line) => line.trim())
|
|
||||||
.find((line) => /^\/bot\s+fix-tidy\b/i.test(line));
|
|
||||||
if (!commandLine) {
|
|
||||||
core.info('No /bot fix-tidy command found.');
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
const commenter = comment.user.login;
|
|
||||||
// Answers only the PR's author and maintainers, so the command cannot be used to spam.
|
|
||||||
if (commenter !== issue.user.login) {
|
|
||||||
const { data: access } = await github.rest.repos.getCollaboratorPermissionLevel({ owner, repo, username: commenter });
|
|
||||||
if (!['admin', 'write'].includes(access.permission)) {
|
|
||||||
core.info(`Ignoring /bot fix-tidy from @${commenter}: not the PR's author and no write access.`);
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
const react = (content) =>
|
|
||||||
github.rest.reactions.createForIssueComment({ owner, repo, comment_id: comment.id, content });
|
|
||||||
async function refuse(reason) {
|
|
||||||
await react('-1');
|
|
||||||
await github.rest.issues.createComment({ owner, repo, issue_number: issue.number, body: `${MARKER}\n@${commenter} ${reason}` });
|
|
||||||
}
|
|
||||||
|
|
||||||
await react('eyes');
|
|
||||||
|
|
||||||
if (!/^\/bot\s+fix-tidy$/i.test(commandLine)) {
|
|
||||||
return refuse('`/bot fix-tidy` takes no arguments.');
|
|
||||||
}
|
|
||||||
|
|
||||||
const { data: pr } = await github.rest.pulls.get({ owner, repo, pull_number: issue.number });
|
|
||||||
if (pr.state !== 'open') {
|
|
||||||
return refuse('the PR is not open.');
|
|
||||||
}
|
|
||||||
|
|
||||||
const sha = pr.head.sha.slice(0, 10);
|
|
||||||
const { data: { workflow_runs: runs } } = await github.rest.actions.listWorkflowRuns({
|
|
||||||
owner, repo, workflow_id: FIX_WORKFLOW, event: 'pull_request', head_sha: pr.head.sha, per_page: 1
|
|
||||||
});
|
|
||||||
const run = runs[0];
|
|
||||||
// A PR last pushed before clang_tidy_fix.yml existed has no run to re-run.
|
|
||||||
if (!run) {
|
|
||||||
return refuse(`there is no clang-tidy fix run for ${sha}, the PR's latest commit. If you just pushed it, ` +
|
|
||||||
'try again in a minute. Otherwise, push a commit or merge the base branch to start one, then comment `/bot fix-tidy` again.');
|
|
||||||
}
|
|
||||||
if (run.status !== 'completed') {
|
|
||||||
// The first attempt is the one every push starts, and it makes no fix.
|
|
||||||
return refuse(run.run_attempt > 1
|
|
||||||
? `a clang-tidy fix for ${sha} is already [running](${run.html_url}). I'll post it when it finishes.`
|
|
||||||
: `the PR's checks on ${sha} are still starting. Comment \`/bot fix-tidy\` again in a minute.`);
|
|
||||||
}
|
|
||||||
// GitHub refuses to re-run a run created over 30 days ago.
|
|
||||||
try {
|
|
||||||
await github.rest.actions.reRunWorkflow({ owner, repo, run_id: run.id });
|
|
||||||
} catch (error) {
|
|
||||||
core.warning(`Re-running ${run.html_url} failed: ${error.message}`);
|
|
||||||
return refuse(`GitHub won't re-run the [clang-tidy fix run](${run.html_url}) for ${sha} (${error.message}). ` +
|
|
||||||
'Push a commit or merge the base branch to start a new one, then comment `/bot fix-tidy` again.');
|
|
||||||
}
|
|
||||||
core.info(`Re-ran ${run.html_url}`);
|
|
||||||
|
|
||||||
suggest:
|
|
||||||
# The fix run's re-runs only. Its first attempt makes no fix.
|
|
||||||
if: >-
|
|
||||||
github.repository == 'OrcaSlicer/OrcaSlicer'
|
|
||||||
&& github.event_name == 'workflow_run'
|
|
||||||
&& github.event.workflow_run.name == 'clang-tidy fix'
|
|
||||||
&& github.event.workflow_run.event == 'pull_request'
|
|
||||||
&& github.event.workflow_run.run_attempt > 1
|
|
||||||
concurrency:
|
|
||||||
group: ${{ github.workflow }}-suggest-${{ github.event.workflow_run.head_repository.full_name }}-${{ github.event.workflow_run.head_branch }}
|
|
||||||
cancel-in-progress: false
|
|
||||||
permissions:
|
|
||||||
actions: read # download the fix
|
|
||||||
contents: read # check out the PR head
|
|
||||||
pull-requests: write # the review
|
|
||||||
issues: write # feedback comment + reactions
|
|
||||||
runs-on: ubuntu-latest
|
|
||||||
timeout-minutes: 10
|
|
||||||
steps:
|
|
||||||
- name: Find the PR and who asked
|
|
||||||
id: find
|
|
||||||
uses: actions/github-script@v9
|
|
||||||
with:
|
|
||||||
script: |
|
|
||||||
const MARKER = '<!-- pr-tidy-bot -->';
|
|
||||||
const CPP = /^(src|tests)\/.+\.(cpp|cc|cxx|hpp|h|hxx)$/;
|
|
||||||
|
|
||||||
const { owner, repo } = context.repo;
|
|
||||||
const run = context.payload.workflow_run;
|
|
||||||
|
|
||||||
// workflow_run lists no PR for a fork's branch, so the PR is found by its branch.
|
|
||||||
const { data: prs } = await github.rest.pulls.list({
|
|
||||||
owner, repo, state: 'open', head: `${run.head_repository.owner.login}:${run.head_branch}`
|
|
||||||
});
|
|
||||||
const pr = prs[0];
|
|
||||||
if (!pr) {
|
|
||||||
core.info('No open PR for this run.');
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
// The latest /bot fix-tidy comment is the one this run answers.
|
|
||||||
const comments = await github.paginate(github.rest.issues.listComments, { owner, repo, issue_number: pr.number, per_page: 100 });
|
|
||||||
const request = comments.reverse().find((c) => c.user.type === 'User' && /^\s*\/bot\s+fix-tidy\s*$/im.test(c.body || ''));
|
|
||||||
const mention = request ? `@${request.user.login} ` : '';
|
|
||||||
async function refuse(reason) {
|
|
||||||
if (request) {
|
|
||||||
await github.rest.reactions.createForIssueComment({ owner, repo, comment_id: request.id, content: '-1' });
|
|
||||||
}
|
|
||||||
await github.rest.issues.createComment({ owner, repo, issue_number: pr.number, body: `${MARKER}\n${mention}${reason}` });
|
|
||||||
}
|
|
||||||
|
|
||||||
if (pr.head.sha !== run.head_sha) {
|
|
||||||
return refuse('the PR changed while I was making its clang-tidy fix. Comment `/bot fix-tidy` again.');
|
|
||||||
}
|
|
||||||
if (run.conclusion !== 'success') {
|
|
||||||
return refuse(`I couldn't make the clang-tidy fix. See the [run log](${run.html_url}).`);
|
|
||||||
}
|
|
||||||
|
|
||||||
// The right-side lines of each changed C++ file's diff: the lines a
|
|
||||||
// review comment can be placed on. A file too large for GitHub to
|
|
||||||
// show its diff has none, and gets no suggestions.
|
|
||||||
const files = await github.paginate(github.rest.pulls.listFiles, { owner, repo, pull_number: pr.number, per_page: 100 });
|
|
||||||
const ranges = {};
|
|
||||||
for (const file of files) {
|
|
||||||
if (file.status === 'removed' || !CPP.test(file.filename)) {
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
ranges[file.filename] = [...(file.patch || '').matchAll(/^@@ -\d+(?:,\d+)? \+(\d+)(?:,(\d+))? @@/gm)]
|
|
||||||
.map((m) => [Number(m[1]), Number(m[1]) + Number(m[2] ?? 1) - 1])
|
|
||||||
.filter(([first, last]) => last >= first);
|
|
||||||
}
|
|
||||||
|
|
||||||
core.setOutput('pr', pr.number);
|
|
||||||
core.setOutput('head-sha', pr.head.sha);
|
|
||||||
core.setOutput('head-repo', run.head_repository.full_name);
|
|
||||||
core.setOutput('ranges', JSON.stringify(ranges));
|
|
||||||
core.setOutput('mention', mention);
|
|
||||||
core.setOutput('request-id', request ? request.id : '');
|
|
||||||
|
|
||||||
- name: Download the fix
|
|
||||||
if: steps.find.outputs.pr != ''
|
|
||||||
uses: actions/download-artifact@v8
|
|
||||||
with:
|
|
||||||
name: clang-tidy-fix
|
|
||||||
run-id: ${{ github.event.workflow_run.id }}
|
|
||||||
github-token: ${{ github.token }}
|
|
||||||
path: ${{ runner.temp }}/clang-tidy-fix
|
|
||||||
|
|
||||||
# The PR's own files, only to apply the patch to. Nothing in them is run.
|
|
||||||
- name: Checkout the PR head
|
|
||||||
if: steps.find.outputs.pr != ''
|
|
||||||
uses: actions/checkout@v7
|
|
||||||
with:
|
|
||||||
repository: ${{ steps.find.outputs.head-repo }}
|
|
||||||
ref: ${{ steps.find.outputs.head-sha }}
|
|
||||||
path: head
|
|
||||||
fetch-depth: 1
|
|
||||||
lfs: 'false'
|
|
||||||
persist-credentials: false
|
|
||||||
sparse-checkout: |
|
|
||||||
src
|
|
||||||
tests
|
|
||||||
|
|
||||||
# The fix was made on the PR's merge commit, so it is applied to the head
|
|
||||||
# and diffed again, giving line numbers in the PR's own files.
|
|
||||||
- name: Check the fix and place its suggestions
|
|
||||||
id: place
|
|
||||||
if: steps.find.outputs.pr != ''
|
|
||||||
env:
|
|
||||||
RANGES: ${{ steps.find.outputs.ranges }}
|
|
||||||
run: |
|
|
||||||
python3 -I - "$RUNNER_TEMP/clang-tidy-fix/fix.patch" head "$RUNNER_TEMP" <<'EOF'
|
|
||||||
import json, os, re, subprocess, sys
|
|
||||||
|
|
||||||
patch_path, head, out = sys.argv[1:]
|
|
||||||
ranges = json.loads(os.environ["RANGES"])
|
|
||||||
|
|
||||||
def output(**values):
|
|
||||||
with open(os.environ["GITHUB_OUTPUT"], "a", encoding="utf-8") as f:
|
|
||||||
for key, value in values.items():
|
|
||||||
f.write(f"{key}={value}\n")
|
|
||||||
|
|
||||||
patch = open(patch_path, encoding="utf-8").read()
|
|
||||||
if not patch.strip():
|
|
||||||
output(result="empty")
|
|
||||||
sys.exit()
|
|
||||||
|
|
||||||
# Every line the patch adds must be an #include or blank, in a C++ file the
|
|
||||||
# PR changes, and it may not remove, create, rename or change the mode of
|
|
||||||
# anything.
|
|
||||||
include = re.compile(r'\s*#\s*include\s*(<[\w./+-]+>|"[\w./+-]+")\s*')
|
|
||||||
header = re.compile(r"(index [0-9a-f]+\.\.[0-9a-f]+( \d+)?|@@ -\d+(,\d+)? \+\d+(,\d+)? @@.*)")
|
|
||||||
problems = []
|
|
||||||
path = None
|
|
||||||
for line in patch.splitlines():
|
|
||||||
if line.startswith("diff --git "):
|
|
||||||
match = re.fullmatch(r"diff --git a/(.+) b/\1", line)
|
|
||||||
path = match.group(1) if match else None
|
|
||||||
if path not in ranges:
|
|
||||||
problems.append(f"{line}: not a C++ file the PR changes")
|
|
||||||
# git appends a tab to the --- and +++ lines of a path that contains a space.
|
|
||||||
elif line.removesuffix("\t") in (f"--- a/{path}", f"+++ b/{path}") or header.fullmatch(line):
|
|
||||||
pass
|
|
||||||
elif line.startswith(" ") or line == "\\ No newline at end of file":
|
|
||||||
pass
|
|
||||||
elif line.startswith("+") and (include.fullmatch(line[1:]) or not line[1:].strip()):
|
|
||||||
pass
|
|
||||||
else:
|
|
||||||
problems.append(f"{path}: {line}")
|
|
||||||
if problems:
|
|
||||||
for problem in problems:
|
|
||||||
print(f"::error::Refused patch line {problem}")
|
|
||||||
output(result="rejected")
|
|
||||||
sys.exit()
|
|
||||||
|
|
||||||
if subprocess.run(["git", "-C", head, "apply", "--index", os.path.abspath(patch_path)]).returncode != 0:
|
|
||||||
output(result="apply-failed")
|
|
||||||
sys.exit()
|
|
||||||
|
|
||||||
git = ["git", "-C", head, "-c", "core.quotePath=false", "diff", "--cached", "--no-color", "--no-ext-diff",
|
|
||||||
"--src-prefix=a/", "--dst-prefix=b/"]
|
|
||||||
with open(os.path.join(out, "head.patch"), "w", encoding="utf-8") as f:
|
|
||||||
f.write(subprocess.run(git, check=True, capture_output=True, encoding="utf-8").stdout)
|
|
||||||
|
|
||||||
# Each run of added lines becomes one suggestion on the line it goes after
|
|
||||||
# (before, at the top of a file): that line, replaced by itself and the
|
|
||||||
# includes. It can only sit on a line the PR's diff shows.
|
|
||||||
hunks = []
|
|
||||||
path = None
|
|
||||||
for line in subprocess.run(git + ["-U0"], check=True, capture_output=True, encoding="utf-8").stdout.splitlines():
|
|
||||||
if line.startswith("diff --git "):
|
|
||||||
path = re.fullmatch(r"diff --git a/(.+) b/\1", line).group(1)
|
|
||||||
elif line.startswith("@@ "):
|
|
||||||
hunks.append((path, int(re.match(r"@@ -(\d+)", line).group(1)), []))
|
|
||||||
elif hunks and line.startswith("+") and not line.startswith("+++ "):
|
|
||||||
hunks[-1][2].append(line[1:])
|
|
||||||
|
|
||||||
suggestions = []
|
|
||||||
total = suggested = 0
|
|
||||||
for path, after, added in hunks:
|
|
||||||
count = sum(bool(include.fullmatch(line)) for line in added)
|
|
||||||
total += count
|
|
||||||
original = subprocess.run(["git", "-C", head, "show", f"HEAD:{path}"], check=True, capture_output=True,
|
|
||||||
encoding="utf-8").stdout.splitlines()
|
|
||||||
line = max(after, 1)
|
|
||||||
if line > len(original) or not any(first <= line <= last for first, last in ranges[path]):
|
|
||||||
continue
|
|
||||||
body = "\n".join([original[line - 1], *added] if after else [*added, original[0]])
|
|
||||||
# A fence longer than any run of backticks in the line it repeats.
|
|
||||||
fence = "`" * max([3] + [len(run) + 1 for run in re.findall(r"`+", body)])
|
|
||||||
suggestions.append({"path": path, "line": line, "side": "RIGHT",
|
|
||||||
"body": f"{fence}suggestion\n{body}\n{fence}"})
|
|
||||||
suggested += count
|
|
||||||
with open(os.path.join(out, "suggestions.json"), "w", encoding="utf-8") as f:
|
|
||||||
json.dump(suggestions, f)
|
|
||||||
output(result="ok", includes=total, suggested=suggested)
|
|
||||||
EOF
|
|
||||||
|
|
||||||
- name: Post the fix
|
|
||||||
if: always() && steps.find.outputs.pr != ''
|
|
||||||
uses: actions/github-script@v9
|
|
||||||
env:
|
|
||||||
PR: ${{ steps.find.outputs.pr }}
|
|
||||||
MENTION: ${{ steps.find.outputs.mention }}
|
|
||||||
REQUEST_ID: ${{ steps.find.outputs.request-id }}
|
|
||||||
HEAD_SHA: ${{ steps.find.outputs.head-sha }}
|
|
||||||
RESULT: ${{ steps.place.outputs.result }}
|
|
||||||
INCLUDES: ${{ steps.place.outputs.includes }}
|
|
||||||
SUGGESTED: ${{ steps.place.outputs.suggested }}
|
|
||||||
with:
|
|
||||||
script: |
|
|
||||||
const fs = require('fs');
|
|
||||||
const path = require('path');
|
|
||||||
const MARKER = '<!-- pr-tidy-bot -->';
|
|
||||||
// GitHub's limit on a review body is 65536 characters.
|
|
||||||
const MAX_PATCH = 60000;
|
|
||||||
|
|
||||||
const { owner, repo } = context.repo;
|
|
||||||
const { PR, MENTION, REQUEST_ID, HEAD_SHA, RESULT, INCLUDES, SUGGESTED, RUNNER_TEMP } = process.env;
|
|
||||||
const issue_number = Number(PR);
|
|
||||||
const sha = HEAD_SHA.slice(0, 10);
|
|
||||||
const fixUrl = context.payload.workflow_run.html_url;
|
|
||||||
const runUrl = `${context.serverUrl}/${owner}/${repo}/actions/runs/${context.runId}`;
|
|
||||||
|
|
||||||
const react = (content) => REQUEST_ID
|
|
||||||
? github.rest.reactions.createForIssueComment({ owner, repo, comment_id: Number(REQUEST_ID), content })
|
|
||||||
: Promise.resolve();
|
|
||||||
async function reply(body, content) {
|
|
||||||
await react(content);
|
|
||||||
await github.rest.issues.createComment({ owner, repo, issue_number, body: `${MARKER}\n${MENTION}${body}` });
|
|
||||||
}
|
|
||||||
|
|
||||||
const read = (...parts) => fs.readFileSync(path.join(RUNNER_TEMP, ...parts), 'utf8');
|
|
||||||
const passes = RESULT && read('clang-tidy-fix', 'status').trim() === '0';
|
|
||||||
|
|
||||||
if (RESULT === 'empty') {
|
|
||||||
return passes
|
|
||||||
? reply(`clang-tidy passes on ${sha}. There is nothing to fix.`, '+1')
|
|
||||||
: reply(`clang-tidy has no automatic fix for what it reports on ${sha}. The findings, in the [fix run's log](${fixUrl}), need a manual edit.`, '-1');
|
|
||||||
}
|
|
||||||
if (RESULT === 'rejected') {
|
|
||||||
return reply(`the clang-tidy fix changes more than includes, so I didn't post it. See the [run log](${runUrl}).`, '-1');
|
|
||||||
}
|
|
||||||
if (RESULT === 'apply-failed') {
|
|
||||||
return reply(`the clang-tidy fix doesn't apply to ${sha}. Merge the base branch into the PR, then comment \`/bot fix-tidy\` again.`, '-1');
|
|
||||||
}
|
|
||||||
if (RESULT !== 'ok') {
|
|
||||||
return reply(`something went wrong. See the [run log](${runUrl}).`, '-1');
|
|
||||||
}
|
|
||||||
|
|
||||||
const patch = read('head.patch');
|
|
||||||
const suggestions = JSON.parse(read('suggestions.json'));
|
|
||||||
|
|
||||||
const one = INCLUDES === '1';
|
|
||||||
const includes = one ? '1 missing include' : `${INCLUDES} missing includes`;
|
|
||||||
const inline = SUGGESTED === '0'
|
|
||||||
? (one ? 'It goes on a line this PR does not change, so I can\'t suggest it inline.'
|
|
||||||
: 'They go on lines this PR does not change, so I can\'t suggest them inline.')
|
|
||||||
: SUGGESTED === INCLUDES
|
|
||||||
? (one ? 'It is suggested inline below.' : 'Each is suggested inline below.')
|
|
||||||
: `${SUGGESTED} of them are suggested inline below; the rest go on lines this PR does not change.`;
|
|
||||||
const remaining = passes
|
|
||||||
? `With ${one ? 'it' : 'them'}, clang-tidy passes.`
|
|
||||||
: `Some findings remain that need a manual edit; see the [fix run's log](${fixUrl}).`;
|
|
||||||
// A fence longer than any run of backticks in the patch's context lines.
|
|
||||||
const fence = '`'.repeat(Math.max(3, ...[...patch.matchAll(/`+/g)].map((m) => m[0].length + 1)));
|
|
||||||
const apply = patch.length > MAX_PATCH
|
|
||||||
? `The full patch is too large to show here. Download \`fix.patch\` from the [fix run](${fixUrl}) and run \`git apply fix.patch\`.`
|
|
||||||
: `To apply ${one ? 'it' : 'all of them'}, run this in your checkout of the PR branch:\n\n${fence}sh\ngit apply <<'EOF'\n${patch}EOF\n${fence}`;
|
|
||||||
const body = (withSuggestions) => `${MARKER}\n${MENTION}clang-tidy's fix for ${sha} adds ${includes}. ` +
|
|
||||||
`${withSuggestions ? `${inline} ` : ''}${remaining}\n\n${apply}`;
|
|
||||||
|
|
||||||
const review = { owner, repo, pull_number: issue_number, commit_id: HEAD_SHA, event: 'COMMENT' };
|
|
||||||
try {
|
|
||||||
await github.rest.pulls.createReview({ ...review, body: body(true), comments: suggestions });
|
|
||||||
} catch (error) {
|
|
||||||
// A suggestion GitHub will not place still leaves the patch.
|
|
||||||
core.warning(`Posting the suggestions failed (${error.message}); posting the patch alone.`);
|
|
||||||
await github.rest.pulls.createReview({ ...review, body: body(false) });
|
|
||||||
}
|
|
||||||
await react('+1');
|
|
||||||
|
|
||||||
nudge:
|
|
||||||
if: >-
|
|
||||||
github.repository == 'OrcaSlicer/OrcaSlicer'
|
|
||||||
&& github.event_name == 'workflow_run'
|
|
||||||
&& github.event.workflow_run.name == 'clang-tidy'
|
|
||||||
&& github.event.workflow_run.event == 'pull_request'
|
|
||||||
concurrency:
|
|
||||||
group: ${{ github.workflow }}-nudge-${{ github.event.workflow_run.head_repository.full_name }}-${{ github.event.workflow_run.head_branch }}
|
|
||||||
cancel-in-progress: false
|
|
||||||
permissions:
|
|
||||||
actions: read # the check's steps
|
|
||||||
pull-requests: write # comment on the PR
|
|
||||||
issues: write # the comment
|
|
||||||
runs-on: ubuntu-latest
|
|
||||||
timeout-minutes: 5
|
|
||||||
steps:
|
|
||||||
- name: Ask for a fix when the check fails
|
|
||||||
uses: actions/github-script@v9
|
|
||||||
with:
|
|
||||||
script: |
|
|
||||||
const MARKER = '<!-- pr-tidy-bot-nudge -->';
|
|
||||||
// The clang-tidy step's name in clang_tidy.yml. A failure in any other
|
|
||||||
// step is the CI's, not the PR's.
|
|
||||||
const TIDY_STEP = 'Run clang-tidy on the changed lines';
|
|
||||||
|
|
||||||
const { owner, repo } = context.repo;
|
|
||||||
const run = context.payload.workflow_run;
|
|
||||||
|
|
||||||
// workflow_run lists no PR for a fork's branch, so the PR is found by its branch.
|
|
||||||
const { data: prs } = await github.rest.pulls.list({
|
|
||||||
owner, repo, state: 'open', head: `${run.head_repository.owner.login}:${run.head_branch}`
|
|
||||||
});
|
|
||||||
const pr = prs.find((p) => p.head.sha === run.head_sha);
|
|
||||||
if (!pr) {
|
|
||||||
core.info('No open PR at this run\'s commit; a newer run will answer.');
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
const { data: { jobs } } = await github.rest.actions.listJobsForWorkflowRun({ owner, repo, run_id: run.id });
|
|
||||||
const failed = jobs.some((job) => (job.steps || []).some((step) => step.name === TIDY_STEP && step.conclusion === 'failure'));
|
|
||||||
|
|
||||||
const comments = await github.paginate(github.rest.issues.listComments, { owner, repo, issue_number: pr.number, per_page: 100 });
|
|
||||||
const previous = comments.find((c) => c.user.type === 'Bot' && (c.body || '').startsWith(MARKER));
|
|
||||||
|
|
||||||
if (!failed) {
|
|
||||||
// Removes the request once the check passes.
|
|
||||||
if (previous && run.conclusion === 'success') {
|
|
||||||
await github.rest.issues.deleteComment({ owner, repo, comment_id: previous.id });
|
|
||||||
}
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
const body = `${MARKER}\n@${pr.user.login} the clang-tidy check found problems in this PR's changes ` +
|
|
||||||
`at ${run.head_sha.slice(0, 10)} ([log](${run.html_url})). Missing includes can be fixed either way:\n\n` +
|
|
||||||
'- run `scripts/run_clang_tidy.sh --fix` (`scripts\\run_clang_tidy.ps1 -Fix` on Windows) and push the result, or\n' +
|
|
||||||
'- comment `/bot fix-tidy`, and I\'ll suggest the fix here for you to apply.\n\n' +
|
|
||||||
'Other findings, such as a `using` in a header, need a manual edit.';
|
|
||||||
// Edits the earlier request instead of posting another, so each push does not notify again.
|
|
||||||
if (previous) {
|
|
||||||
await github.rest.issues.updateComment({ owner, repo, comment_id: previous.id, body });
|
|
||||||
} else {
|
|
||||||
await github.rest.issues.createComment({ owner, repo, issue_number: pr.number, body });
|
|
||||||
}
|
|
||||||
@@ -497,47 +497,6 @@ endif()
|
|||||||
# Once we get rid of Perl and libslic3r is linked statically, we can get rid of -fPIC
|
# Once we get rid of Perl and libslic3r is linked statically, we can get rid of -fPIC
|
||||||
set(CMAKE_POSITION_INDEPENDENT_CODE ON)
|
set(CMAKE_POSITION_INDEPENDENT_CODE ON)
|
||||||
|
|
||||||
# WIN10SDK_PATH is used to point CMake to the WIN10 SDK installation directory.
|
|
||||||
# We pick it from environment if it is not defined in another way
|
|
||||||
# ORCA: Removed Netfabb STL fixing service support in favor of CGAL.
|
|
||||||
# if(WIN32)
|
|
||||||
# if(NOT DEFINED WIN10SDK_PATH)
|
|
||||||
# if(DEFINED ENV{WIN10SDK_PATH})
|
|
||||||
# set(WIN10SDK_PATH "$ENV{WIN10SDK_PATH}")
|
|
||||||
# endif()
|
|
||||||
# endif()
|
|
||||||
# if(DEFINED WIN10SDK_PATH)
|
|
||||||
# #BBS: modify win10sdk_path
|
|
||||||
# if (EXISTS "${WIN10SDK_PATH}/winrt/windows.graphics.printing3d.h")
|
|
||||||
# set(WIN10SDK_INCLUDE_PATH "${WIN10SDK_PATH}")
|
|
||||||
# else()
|
|
||||||
# message("WIN10SDK_PATH is invalid: ${WIN10SDK_PATH}")
|
|
||||||
# message("${WIN10SDK_PATH}/winrt/windows.graphics.printing3d.h was not found")
|
|
||||||
# message("STL fixing by the Netfabb service will not be compiled")
|
|
||||||
# unset(WIN10SDK_PATH)
|
|
||||||
# endif()
|
|
||||||
# else()
|
|
||||||
# # Try to use the default Windows 10 SDK path.
|
|
||||||
# if (DEFINED ENV{WindowsSdkDir} AND DEFINED ENV{WindowsSDKVersion})
|
|
||||||
# set(WIN10SDK_INCLUDE_PATH "$ENV{WindowsSdkDir}/Include/$ENV{WindowsSDKVersion}")
|
|
||||||
# else ()
|
|
||||||
# set(WIN10SDK_INCLUDE_PATH "C:/Program Files (x86)/Windows Kits/10/Include/10.0.26100.0")
|
|
||||||
# endif ()
|
|
||||||
# if (NOT EXISTS "${WIN10SDK_INCLUDE_PATH}/winrt/windows.graphics.printing3d.h")
|
|
||||||
# message("${WIN10SDK_INCLUDE_PATH}/winrt/windows.graphics.printing3d.h was not found")
|
|
||||||
# message("STL fixing by the Netfabb service will not be compiled")
|
|
||||||
# unset(WIN10SDK_INCLUDE_PATH)
|
|
||||||
# endif()
|
|
||||||
# endif()
|
|
||||||
# if(WIN10SDK_INCLUDE_PATH)
|
|
||||||
# message("Building with Win10 Netfabb STL fixing service support")
|
|
||||||
# add_definitions(-DHAS_WIN10SDK)
|
|
||||||
# include_directories(SYSTEM "${WIN10SDK_INCLUDE_PATH}")
|
|
||||||
# else()
|
|
||||||
# message("Building without Win10 Netfabb STL fixing service support")
|
|
||||||
# endif()
|
|
||||||
# endif()
|
|
||||||
|
|
||||||
if (APPLE)
|
if (APPLE)
|
||||||
message("OS X SDK Path: ${CMAKE_OSX_SYSROOT}")
|
message("OS X SDK Path: ${CMAKE_OSX_SYSROOT}")
|
||||||
if (CMAKE_OSX_DEPLOYMENT_TARGET)
|
if (CMAKE_OSX_DEPLOYMENT_TARGET)
|
||||||
|
|||||||
@@ -1,10 +1,18 @@
|
|||||||
# ccache does not parse the -clang: arguments CMake uses for clang-cl's gcc-style
|
# ccache does not parse the -clang: arguments CMake uses for clang-cl's gcc-style
|
||||||
# depfile, so a cache hit writes the object and no depfile, and Ninja then records
|
# depfile, so a cache hit writes the object and no depfile, and Ninja then records
|
||||||
# no headers for that object. ccache reproduces /showIncludes output on a hit.
|
# no headers for that object. ccache reproduces /showIncludes output on a hit.
|
||||||
|
#
|
||||||
|
# Clang also records the modification time of every input in a precompiled header
|
||||||
|
# and rejects the header once one differs. ccache caches the compile that creates
|
||||||
|
# the header, so a tree that regenerates cmake_pch.cxx gets back a header stamped
|
||||||
|
# with the old file's time, and every compile that uses it fails. The build system
|
||||||
|
# already rebuilds the header when an input changes. This covers the dependencies,
|
||||||
|
# such as wxWidgets; PrecompiledHeader.cmake does the same for OrcaSlicer's targets.
|
||||||
foreach (_lang C CXX)
|
foreach (_lang C CXX)
|
||||||
if (CMAKE_${_lang}_COMPILER_ID STREQUAL "Clang" AND
|
if (CMAKE_${_lang}_COMPILER_ID STREQUAL "Clang" AND
|
||||||
CMAKE_${_lang}_COMPILER_FRONTEND_VARIANT STREQUAL "MSVC")
|
CMAKE_${_lang}_COMPILER_FRONTEND_VARIANT STREQUAL "MSVC")
|
||||||
set(CMAKE_DEPFILE_FLAGS_${_lang} "/showIncludes")
|
set(CMAKE_DEPFILE_FLAGS_${_lang} "/showIncludes")
|
||||||
set(CMAKE_${_lang}_DEPFILE_FORMAT msvc)
|
set(CMAKE_${_lang}_DEPFILE_FORMAT msvc)
|
||||||
|
list(APPEND CMAKE_${_lang}_COMPILE_OPTIONS_CREATE_PCH -Xclang -fno-pch-timestamp)
|
||||||
endif ()
|
endif ()
|
||||||
endforeach ()
|
endforeach ()
|
||||||
|
|||||||
@@ -0,0 +1,135 @@
|
|||||||
|
# Mesh repair — High Level Design
|
||||||
|
|
||||||
|
## Purpose and scope
|
||||||
|
|
||||||
|
Mesh repair turns a broken triangle mesh into closed, outward oriented shells that bound a solid, so that the
|
||||||
|
mesh slices predictably and the other mesh tools (booleans, cut, painting) get valid input. It runs on demand:
|
||||||
|
the *Fix Model* command of the context menu of an object or part and of the warning icon in the object list, *Fix
|
||||||
|
All* and *Fix All Plates* in the context menu of a plate, the prompt the Cut tool shows when a cut leaves open edges,
|
||||||
|
the *Repair and import* choice of texture import, and the `--repair` option of the command line. It is built on CGAL
|
||||||
|
and is the only repair the application has, on every platform.
|
||||||
|
|
||||||
|
`repair_mesh()` in `src/libslic3r/MeshRepair.cpp` does the work on one `TriangleMesh`, and `ModelVolume::repair()`
|
||||||
|
applies it to a part: it replaces the mesh only when the repair changed it, and remaps or drops the painting of a
|
||||||
|
replaced mesh. The GUI side, `fix_model_with_cgal_gui()` in `src/slic3r/Utils/FixModelByCgal.cpp`, runs it on a
|
||||||
|
worker thread for each volume of an object, or for one volume, behind a progress dialog. `repair_mesh()` reports its
|
||||||
|
progress between stages through a callback, which cancels the repair by throwing.
|
||||||
|
|
||||||
|
## What the repaired mesh is
|
||||||
|
|
||||||
|
The repair keeps what the slicer would print from the input. The slicer fills a layer where the winding number of
|
||||||
|
the input surface is not zero (`MeshSlicingParams::SlicingMode::Regular` uses Clipper's nonzero fill rule), so:
|
||||||
|
|
||||||
|
- Shells crossing each other print as their union. The repair keeps them as separate shells, as the parts of an
|
||||||
|
object are kept, and makes each of them an outward oriented solid.
|
||||||
|
- A shell inside a solid that is oriented like it adds nothing, and the repair removes it.
|
||||||
|
- A shell inside a solid that is oriented inward is a cavity, and stays one.
|
||||||
|
- A whole mesh turned inside out prints as a solid, and the repair turns it outward.
|
||||||
|
|
||||||
|
On top of that, it closes holes and cracks, gives inconsistently oriented triangles the orientation of their
|
||||||
|
neighbours, drops degenerate, duplicate and stray flat geometry, and removes small self-intersections inside a shell,
|
||||||
|
such as slivers and folds. Where none of this applies, it reports the mesh as unmodified and the caller keeps the
|
||||||
|
original mesh, its painting and its object id.
|
||||||
|
|
||||||
|
A volume is repaired in place and is never split into several parts: splitting by connectivity would turn a cavity
|
||||||
|
into a separate solid part and fill it. Each solid of the result is a shell of its own, so *Split to parts* still
|
||||||
|
separates them. Open pieces of the input whose borders meet exactly, which are pieces of one surface rather than
|
||||||
|
solids, come out as the one shell they form.
|
||||||
|
|
||||||
|
## Pipeline
|
||||||
|
|
||||||
|
The input is treated as a triangle soup. Every stage after the first only runs on what the previous ones could
|
||||||
|
not settle, so a valid mesh passes through quickly.
|
||||||
|
|
||||||
|
### Valid parts first
|
||||||
|
|
||||||
|
Parts of the input that are connected by vertex indices and are already closed, consistently oriented 2-manifolds
|
||||||
|
skip the soup stages and go straight to the shell stages. Merging their points with coincident points of other
|
||||||
|
parts would only make non-manifold junctions out of solids that touch, for example parts of an assembly exported
|
||||||
|
together or voxels written as separate cubes.
|
||||||
|
|
||||||
|
### Soup clean-up
|
||||||
|
|
||||||
|
The rest of the soup has its coincident points merged. Triangles with repeated corners are dropped. Coincident
|
||||||
|
triangles of opposite orientation are a wall between two solids touching face to face, so they cancel in pairs;
|
||||||
|
of the remaining copies of a triangle one is kept. A connected region that would vanish entirely through
|
||||||
|
cancelling is a two-sided export instead (every face written in both orientations), and keeps one copy of each
|
||||||
|
triangle.
|
||||||
|
|
||||||
|
Open edges then get their vertices welded within a tolerance of 1e-4 of the bounding box diagonal, which closes the
|
||||||
|
cracks some exporters leave between triangles that should share corners. A vertex is never welded further than a
|
||||||
|
quarter of its shortest edge, so welding cannot collapse fine detail. A soup that stays mostly open after welding has
|
||||||
|
cracks wider than that tolerance, and is welded again with ten and then a hundred times the tolerance.
|
||||||
|
|
||||||
|
### Work units
|
||||||
|
|
||||||
|
The soup is cut into units repaired independently and in parallel: its connected parts, except that open parts whose
|
||||||
|
bounding boxes touch share a unit, so that cracks and T-junctions between separately exported patches still close.
|
||||||
|
|
||||||
|
### Building the mesh
|
||||||
|
|
||||||
|
A unit whose edges are each shared by at most two triangles, running in opposite directions, and whose vertices each
|
||||||
|
have a single fan of triangles, becomes a `Surface_mesh` directly. Any other unit is oriented first. Triangles are
|
||||||
|
flipped so that neighbours across an edge shared by two of them agree, each part keeping the orientation the
|
||||||
|
majority of its area had, which keeps inward oriented cavities inward. Edges where that is impossible or that more
|
||||||
|
than two triangles share are cut, and each fan of triangles around a vertex gets its own copy of the vertex. If that
|
||||||
|
still leaves an invalid mesh, CGAL's `orient_polygon_soup()` orients the unit instead, and the parts it flipped
|
||||||
|
against their majority are reversed back. The linear pass exists because `orient_polygon_soup()` is several times
|
||||||
|
slower on large soups that need only a few fixes.
|
||||||
|
|
||||||
|
### Closing
|
||||||
|
|
||||||
|
Compatible borders are stitched, parts that can be stitched once reversed are merged, and borders still open are
|
||||||
|
snapped onto each other within the weld tolerance, which closes T-junctions. Exactly degenerate faces are removed.
|
||||||
|
|
||||||
|
Holes are filled last. Planar border loops that face each other in one plane, one inside the other, bound a single
|
||||||
|
region, such as a missing annulus at the end of a tube or a cap with features standing on it. Such a group is
|
||||||
|
triangulated at once with a 2D constrained Delaunay triangulation that fills only the faces at odd nesting depth,
|
||||||
|
so the openings inside the region stay open. The patch is used only if it closes every loop with the orientation
|
||||||
|
of the triangles around it. Every other loop is filled on its own with `triangulate_hole()`, which uses a 2D
|
||||||
|
constrained Delaunay triangulation when the loop is planar. Otherwise it searches the best triangulation among all
|
||||||
|
triangles over the loop for loops of up to 100 edges, and among the triangles of a 3D Delaunay triangulation for
|
||||||
|
longer ones, as the full search is cubic in the length of the loop. Beyond 200 edges the full search is not even
|
||||||
|
used as a fallback, and a fan around the loop's centroid closes a loop nothing else could.
|
||||||
|
|
||||||
|
The closed unit is split into its shells. The largest stays in place and the others are copied out, as converting
|
||||||
|
the whole mesh again costs seconds on large models.
|
||||||
|
|
||||||
|
### Shells
|
||||||
|
|
||||||
|
The shells of all units, together with the valid parts set aside at the start, are handled independently and in
|
||||||
|
parallel. Shells enclosing no volume, which hole filling makes out of stray flat patches, are dropped.
|
||||||
|
|
||||||
|
Self-intersections inside a shell are removed locally with `experimental::remove_self_intersections()`, which
|
||||||
|
remeshes the region around them. It is used only for local defects: a shell whose intersections involve more than
|
||||||
|
5 % of its faces is left as it is, and a result that changes the enclosed volume by more than 0.1 % is undone. On
|
||||||
|
heavily overlapping ornamental models the remeshing otherwise cuts parts down to slivers, while on genuine defects
|
||||||
|
it changes the volume by thousandths of a percent. Overlaps left in place slice correctly. Remeshing can cut
|
||||||
|
small pieces off a shell, so a shell it changed is split again and its pieces enclosing no volume are dropped.
|
||||||
|
|
||||||
|
Shells crossing others are found through their bounding boxes and an AABB tree per shell, and are made outward
|
||||||
|
oriented solids. For every other shell the winding number just outside it is summed from the orientation of the
|
||||||
|
shells containing it, tested from a point on its largest face. The shell bounds the solid only if the winding
|
||||||
|
number is zero on exactly one of its sides; it is then oriented so that the solid is inside, or dropped otherwise.
|
||||||
|
|
||||||
|
Crossing shells are not united. Slicing unites them anyway, uniting them exactly costs tens of seconds on models
|
||||||
|
made of many overlapping pieces, and it would fuse parts that *Split to parts* should keep apart.
|
||||||
|
|
||||||
|
## Robustness
|
||||||
|
|
||||||
|
The repair avoids `experimental::autorefine_and_remove_self_intersections()` and corefinement, which can crash on
|
||||||
|
messy input, and uses only steps whose failures it can detect. A step that fails keeps its input. CGAL precondition
|
||||||
|
failures surface as `repair_mesh()` returning false with the message as the error. The output is written in float,
|
||||||
|
as every mesh in the application is.
|
||||||
|
|
||||||
|
The result does not depend on thread scheduling. `libslic3r_cgal` is built with `CGAL_LINKED_WITH_TBB`. Units and
|
||||||
|
shells are processed in parallel, but each on its own data, and their results are gathered in a fixed order;
|
||||||
|
sorts compare complete keys, and the detected self-intersections are put in order before they are used. Snapping
|
||||||
|
stays sequential, as its parallel version gives different results from run to run. Holes are filled with the full
|
||||||
|
search wherever it is affordable, because the search among Delaunay triangles can choose between equally good fills
|
||||||
|
differently from run to run, so only non-planar holes of more than 100 edges may still vary. On some inputs
|
||||||
|
`experimental::remove_self_intersections()` itself places a few vertices differently from run to run.
|
||||||
|
|
||||||
|
## Verification
|
||||||
|
|
||||||
|
`tests/libslic3r/test_mesh_repair.cpp` covers each kind of defect above on small meshes with known volumes.
|
||||||
File diff suppressed because it is too large
Load Diff
@@ -1,7 +1,7 @@
|
|||||||
{
|
{
|
||||||
"name": "Bambulab",
|
"name": "Bambulab",
|
||||||
"url": "http://www.bambulab.com/Parameters/vendor/BBL.json",
|
"url": "http://www.bambulab.com/Parameters/vendor/BBL.json",
|
||||||
"version": "02.08.00.14",
|
"version": "02.08.00.15",
|
||||||
"force_update": "0",
|
"force_update": "0",
|
||||||
"description": "the initial version of BBL configurations",
|
"description": "the initial version of BBL configurations",
|
||||||
"machine_model_list": [
|
"machine_model_list": [
|
||||||
|
|||||||
+1
-1
File diff suppressed because one or more lines are too long
@@ -72,17 +72,21 @@ varying float weight;
|
|||||||
varying float island_active;
|
varying float island_active;
|
||||||
varying vec2 vertex_uv;
|
varying vec2 vertex_uv;
|
||||||
|
|
||||||
// The cylinder's own frame, built exactly as libslic3r's project_cylindrical() builds it - including
|
// The cylinder's own frame, built exactly as libslic3r's project_cylindrical() builds it - right
|
||||||
// the handedness, which comes out left-handed for an axis of +Z. Copied rather than "corrected", so
|
// handed, so the angle taken from it grows anticlockwise about the axis, which seen from outside the
|
||||||
// the preview wraps the texture the same way round as the bake.
|
// cylinder is to the viewer's right rather than mirrored.
|
||||||
void cylinder_frame(out vec3 up, out vec3 right, out vec3 fwd)
|
void cylinder_frame(out vec3 up, out vec3 right, out vec3 fwd)
|
||||||
{
|
{
|
||||||
up = (length(patch_axis) > 1e-8) ? normalize(patch_axis) : vec3(0.0, 0.0, 1.0);
|
up = (length(patch_axis) > 1e-8) ? normalize(patch_axis) : vec3(0.0, 0.0, 1.0);
|
||||||
vec3 arbitrary = (abs(up.z) < 0.9) ? vec3(0.0, 0.0, 1.0) : vec3(1.0, 0.0, 0.0);
|
vec3 arbitrary = (abs(up.z) < 0.9) ? vec3(0.0, 0.0, 1.0) : vec3(1.0, 0.0, 0.0);
|
||||||
right = normalize(cross(up, arbitrary));
|
right = normalize(cross(up, arbitrary));
|
||||||
fwd = normalize(cross(right, up));
|
fwd = normalize(cross(up, right));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Which side of a world plane a face is on, with zero counting as the positive side. Not GLSL's own
|
||||||
|
// sign(), which returns 0 there and would collapse the coordinate onto a line.
|
||||||
|
float box_face_sign(float n) { return n >= 0.0 ? 1.0 : -1.0; }
|
||||||
|
|
||||||
// The raw, millimetre-valued projection of `p` (a position in the texture frame), before the layer's
|
// The raw, millimetre-valued projection of `p` (a position in the texture frame), before the layer's
|
||||||
// tiling/rotation/aspect/offset - a term-for-term transcription of libslic3r's project_planar(),
|
// tiling/rotation/aspect/offset - a term-for-term transcription of libslic3r's project_planar(),
|
||||||
// project_cylindrical() and project_spherical(). `n` is read by the planar mode only.
|
// project_cylindrical() and project_spherical(). `n` is read by the planar mode only.
|
||||||
@@ -94,7 +98,7 @@ vec2 projection_raw(vec3 p, vec3 n)
|
|||||||
vec3 rel = p - patch_center;
|
vec3 rel = p - patch_center;
|
||||||
float x = dot(rel, right);
|
float x = dot(rel, right);
|
||||||
float y = dot(rel, fwd);
|
float y = dot(rel, fwd);
|
||||||
return vec2(atan(y, x) * sqrt(x * x + y * y), dot(rel, up));
|
return vec2(atan(y, x) * sqrt(x * x + y * y), -dot(rel, up));
|
||||||
}
|
}
|
||||||
if (projection_mode == 2) { // Spherical: (longitude, latitude) * radius
|
if (projection_mode == 2) { // Spherical: (longitude, latitude) * radius
|
||||||
vec3 rel = p - patch_center;
|
vec3 rel = p - patch_center;
|
||||||
@@ -102,10 +106,18 @@ vec2 projection_raw(vec3 p, vec3 n)
|
|||||||
if (radius < 1e-8)
|
if (radius < 1e-8)
|
||||||
return vec2(0.0);
|
return vec2(0.0);
|
||||||
vec3 dir = rel / radius;
|
vec3 dir = rel / radius;
|
||||||
return vec2(atan(dir.y, dir.x), asin(clamp(dir.z, -1.0, 1.0))) * radius;
|
return vec2(atan(dir.y, dir.x), -asin(clamp(dir.z, -1.0, 1.0))) * radius;
|
||||||
}
|
}
|
||||||
vec3 an = abs(n); // Triplanar: drop the dominant normal axis
|
// Triplanar: drop the dominant normal axis. v is negated so the image's first pixel row (v = 0)
|
||||||
return (an.x >= an.y && an.x >= an.z) ? p.yz : ((an.y >= an.x && an.y >= an.z) ? p.xz : p.xy);
|
// sits at the top of the model instead of upside down, and u is flipped on the far side of each
|
||||||
|
// plane so the two faces sharing it are not mirror images. libslic3r's box_plane_yz() and its two
|
||||||
|
// siblings, term for term.
|
||||||
|
vec3 an = abs(n);
|
||||||
|
if (an.x >= an.y && an.x >= an.z)
|
||||||
|
return vec2(box_face_sign(n.x) * p.y, -p.z);
|
||||||
|
if (an.y >= an.x && an.y >= an.z)
|
||||||
|
return vec2(-box_face_sign(n.y) * p.x, -p.z);
|
||||||
|
return vec2(box_face_sign(n.z) * p.x, -p.y);
|
||||||
}
|
}
|
||||||
|
|
||||||
// The two surface directions projection_raw()'s u and v run along at `p`, plus how many raw units one
|
// The two surface directions projection_raw()'s u and v run along at `p`, plus how many raw units one
|
||||||
@@ -124,7 +136,7 @@ void projection_axes(vec3 p, vec3 n, out vec3 t, out vec3 b, out vec2 units_per_
|
|||||||
vec2 xy = vec2(dot(rel, right), dot(rel, fwd));
|
vec2 xy = vec2(dot(rel, right), dot(rel, fwd));
|
||||||
float r = length(xy);
|
float r = length(xy);
|
||||||
t = (r > 1e-6) ? (fwd * xy.x - right * xy.y) / r : right; // circumferential: u runs along it
|
t = (r > 1e-6) ? (fwd * xy.x - right * xy.y) / r : right; // circumferential: u runs along it
|
||||||
b = up; // v is the distance along the axis
|
b = -up; // v is the distance *against* the axis
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
if (projection_mode == 2) {
|
if (projection_mode == 2) {
|
||||||
@@ -133,20 +145,20 @@ void projection_axes(vec3 p, vec3 n, out vec3 t, out vec3 b, out vec2 units_per_
|
|||||||
vec3 dir = (r > 1e-8) ? rel / r : vec3(0.0, 0.0, 1.0);
|
vec3 dir = (r > 1e-8) ? rel / r : vec3(0.0, 0.0, 1.0);
|
||||||
float c = length(dir.xy); // cos(latitude)
|
float c = length(dir.xy); // cos(latitude)
|
||||||
t = (c > 1e-6) ? vec3(-dir.y, dir.x, 0.0) / c : vec3(1.0, 0.0, 0.0);
|
t = (c > 1e-6) ? vec3(-dir.y, dir.x, 0.0) / c : vec3(1.0, 0.0, 0.0);
|
||||||
b = cross(dir, t); // increasing latitude, unit length
|
b = -cross(dir, t); // v grows away from the pole, unit length
|
||||||
units_per_mm = vec2(1.0 / max(c, 1e-3), 1.0);
|
units_per_mm = vec2(1.0 / max(c, 1e-3), 1.0);
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
vec3 an = abs(n);
|
vec3 an = abs(n); // the same signed basis projection_raw() uses
|
||||||
if (an.x >= an.y && an.x >= an.z) { // planar = p.yz
|
if (an.x >= an.y && an.x >= an.z) { // planar = (+-y, -z)
|
||||||
t = vec3(0.0, 1.0, 0.0);
|
t = vec3(0.0, box_face_sign(n.x), 0.0);
|
||||||
b = vec3(0.0, 0.0, 1.0);
|
b = vec3(0.0, 0.0, -1.0);
|
||||||
} else if (an.y >= an.x && an.y >= an.z) { // planar = p.xz
|
} else if (an.y >= an.x && an.y >= an.z) { // planar = (+-x, -z)
|
||||||
t = vec3(1.0, 0.0, 0.0);
|
t = vec3(-box_face_sign(n.y), 0.0, 0.0);
|
||||||
b = vec3(0.0, 0.0, 1.0);
|
b = vec3(0.0, 0.0, -1.0);
|
||||||
} else { // planar = p.xy
|
} else { // planar = (+-x, -y)
|
||||||
t = vec3(1.0, 0.0, 0.0);
|
t = vec3(box_face_sign(n.z), 0.0, 0.0);
|
||||||
b = vec3(0.0, 1.0, 0.0);
|
b = vec3(0.0, -1.0, 0.0);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -36,14 +36,20 @@ varying vec4 world_pos;
|
|||||||
varying float distortion;
|
varying float distortion;
|
||||||
varying vec2 vertex_uv;
|
varying vec2 vertex_uv;
|
||||||
|
|
||||||
|
// Right handed (up x right), like libslic3r's project_cylindrical(), so the angle taken from it grows
|
||||||
|
// anticlockwise about the axis - to the viewer's right when seen from outside the cylinder.
|
||||||
void cylinder_frame(out vec3 up, out vec3 right, out vec3 fwd)
|
void cylinder_frame(out vec3 up, out vec3 right, out vec3 fwd)
|
||||||
{
|
{
|
||||||
up = (length(patch_axis) > 1e-8) ? normalize(patch_axis) : vec3(0.0, 0.0, 1.0);
|
up = (length(patch_axis) > 1e-8) ? normalize(patch_axis) : vec3(0.0, 0.0, 1.0);
|
||||||
vec3 arbitrary = (abs(up.z) < 0.9) ? vec3(0.0, 0.0, 1.0) : vec3(1.0, 0.0, 0.0);
|
vec3 arbitrary = (abs(up.z) < 0.9) ? vec3(0.0, 0.0, 1.0) : vec3(1.0, 0.0, 0.0);
|
||||||
right = normalize(cross(up, arbitrary));
|
right = normalize(cross(up, arbitrary));
|
||||||
fwd = normalize(cross(right, up));
|
fwd = normalize(cross(up, right));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Which side of a world plane a face is on, with zero counting as the positive side. Not GLSL's own
|
||||||
|
// sign(), which returns 0 there and would collapse the coordinate onto a line.
|
||||||
|
float box_face_sign(float n) { return n >= 0.0 ? 1.0 : -1.0; }
|
||||||
|
|
||||||
// Term for term libslic3r's project_planar() / project_cylindrical() / project_spherical(), in mm.
|
// Term for term libslic3r's project_planar() / project_cylindrical() / project_spherical(), in mm.
|
||||||
vec2 projection_raw(vec3 p, vec3 n)
|
vec2 projection_raw(vec3 p, vec3 n)
|
||||||
{
|
{
|
||||||
@@ -53,7 +59,7 @@ vec2 projection_raw(vec3 p, vec3 n)
|
|||||||
vec3 rel = p - patch_center;
|
vec3 rel = p - patch_center;
|
||||||
float x = dot(rel, right);
|
float x = dot(rel, right);
|
||||||
float y = dot(rel, fwd);
|
float y = dot(rel, fwd);
|
||||||
return vec2(atan(y, x) * sqrt(x * x + y * y), dot(rel, up));
|
return vec2(atan(y, x) * sqrt(x * x + y * y), -dot(rel, up));
|
||||||
}
|
}
|
||||||
if (projection_mode == 2) {
|
if (projection_mode == 2) {
|
||||||
vec3 rel = p - patch_center;
|
vec3 rel = p - patch_center;
|
||||||
@@ -61,10 +67,16 @@ vec2 projection_raw(vec3 p, vec3 n)
|
|||||||
if (radius < 1e-8)
|
if (radius < 1e-8)
|
||||||
return vec2(0.0);
|
return vec2(0.0);
|
||||||
vec3 dir = rel / radius;
|
vec3 dir = rel / radius;
|
||||||
return vec2(atan(dir.y, dir.x), asin(clamp(dir.z, -1.0, 1.0))) * radius;
|
return vec2(atan(dir.y, dir.x), -asin(clamp(dir.z, -1.0, 1.0))) * radius;
|
||||||
}
|
}
|
||||||
|
// v negated so the image's first pixel row sits at the top of the model, u flipped on the far side
|
||||||
|
// of each plane so the two faces sharing it are not mirror images - see libslic3r's box_plane_yz().
|
||||||
vec3 an = abs(n);
|
vec3 an = abs(n);
|
||||||
return (an.x >= an.y && an.x >= an.z) ? p.yz : ((an.y >= an.x && an.y >= an.z) ? p.xz : p.xy);
|
if (an.x >= an.y && an.x >= an.z)
|
||||||
|
return vec2(box_face_sign(n.x) * p.y, -p.z);
|
||||||
|
if (an.y >= an.x && an.y >= an.z)
|
||||||
|
return vec2(-box_face_sign(n.y) * p.x, -p.z);
|
||||||
|
return vec2(box_face_sign(n.z) * p.x, -p.y);
|
||||||
}
|
}
|
||||||
|
|
||||||
vec2 project_uv(vec3 p, vec3 n)
|
vec2 project_uv(vec3 p, vec3 n)
|
||||||
|
|||||||
@@ -138,17 +138,21 @@ in vec2 vertex_uv;
|
|||||||
|
|
||||||
out vec4 out_color;
|
out vec4 out_color;
|
||||||
|
|
||||||
// The cylinder's own frame, built exactly as libslic3r's project_cylindrical() builds it - including
|
// The cylinder's own frame, built exactly as libslic3r's project_cylindrical() builds it - right
|
||||||
// the handedness, which comes out left-handed for an axis of +Z. Copied rather than "corrected", so
|
// handed, so the angle taken from it grows anticlockwise about the axis, which seen from outside the
|
||||||
// the preview wraps the texture the same way round as the bake.
|
// cylinder is to the viewer's right rather than mirrored.
|
||||||
void cylinder_frame(out vec3 up, out vec3 right, out vec3 fwd)
|
void cylinder_frame(out vec3 up, out vec3 right, out vec3 fwd)
|
||||||
{
|
{
|
||||||
up = (length(patch_axis) > 1e-8) ? normalize(patch_axis) : vec3(0.0, 0.0, 1.0);
|
up = (length(patch_axis) > 1e-8) ? normalize(patch_axis) : vec3(0.0, 0.0, 1.0);
|
||||||
vec3 arbitrary = (abs(up.z) < 0.9) ? vec3(0.0, 0.0, 1.0) : vec3(1.0, 0.0, 0.0);
|
vec3 arbitrary = (abs(up.z) < 0.9) ? vec3(0.0, 0.0, 1.0) : vec3(1.0, 0.0, 0.0);
|
||||||
right = normalize(cross(up, arbitrary));
|
right = normalize(cross(up, arbitrary));
|
||||||
fwd = normalize(cross(right, up));
|
fwd = normalize(cross(up, right));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Which side of a world plane a face is on, with zero counting as the positive side. Not GLSL's own
|
||||||
|
// sign(), which returns 0 there and would collapse the coordinate onto a line.
|
||||||
|
float box_face_sign(float n) { return n >= 0.0 ? 1.0 : -1.0; }
|
||||||
|
|
||||||
// The raw, millimetre-valued projection of `p` (a position in the texture frame), before the layer's
|
// The raw, millimetre-valued projection of `p` (a position in the texture frame), before the layer's
|
||||||
// tiling/rotation/aspect/offset - a term-for-term transcription of libslic3r's project_planar(),
|
// tiling/rotation/aspect/offset - a term-for-term transcription of libslic3r's project_planar(),
|
||||||
// project_cylindrical() and project_spherical(). `n` is read by the planar mode only.
|
// project_cylindrical() and project_spherical(). `n` is read by the planar mode only.
|
||||||
@@ -160,7 +164,7 @@ vec2 projection_raw(vec3 p, vec3 n)
|
|||||||
vec3 rel = p - patch_center;
|
vec3 rel = p - patch_center;
|
||||||
float x = dot(rel, right);
|
float x = dot(rel, right);
|
||||||
float y = dot(rel, fwd);
|
float y = dot(rel, fwd);
|
||||||
return vec2(atan(y, x) * sqrt(x * x + y * y), dot(rel, up));
|
return vec2(atan(y, x) * sqrt(x * x + y * y), -dot(rel, up));
|
||||||
}
|
}
|
||||||
if (projection_mode == 2) { // Spherical: (longitude, latitude) * radius
|
if (projection_mode == 2) { // Spherical: (longitude, latitude) * radius
|
||||||
vec3 rel = p - patch_center;
|
vec3 rel = p - patch_center;
|
||||||
@@ -168,10 +172,18 @@ vec2 projection_raw(vec3 p, vec3 n)
|
|||||||
if (radius < 1e-8)
|
if (radius < 1e-8)
|
||||||
return vec2(0.0);
|
return vec2(0.0);
|
||||||
vec3 dir = rel / radius;
|
vec3 dir = rel / radius;
|
||||||
return vec2(atan(dir.y, dir.x), asin(clamp(dir.z, -1.0, 1.0))) * radius;
|
return vec2(atan(dir.y, dir.x), -asin(clamp(dir.z, -1.0, 1.0))) * radius;
|
||||||
}
|
}
|
||||||
vec3 an = abs(n); // Triplanar: drop the dominant normal axis
|
// Triplanar: drop the dominant normal axis. v is negated so the image's first pixel row (v = 0)
|
||||||
return (an.x >= an.y && an.x >= an.z) ? p.yz : ((an.y >= an.x && an.y >= an.z) ? p.xz : p.xy);
|
// sits at the top of the model instead of upside down, and u is flipped on the far side of each
|
||||||
|
// plane so the two faces sharing it are not mirror images. libslic3r's box_plane_yz() and its two
|
||||||
|
// siblings, term for term.
|
||||||
|
vec3 an = abs(n);
|
||||||
|
if (an.x >= an.y && an.x >= an.z)
|
||||||
|
return vec2(box_face_sign(n.x) * p.y, -p.z);
|
||||||
|
if (an.y >= an.x && an.y >= an.z)
|
||||||
|
return vec2(-box_face_sign(n.y) * p.x, -p.z);
|
||||||
|
return vec2(box_face_sign(n.z) * p.x, -p.y);
|
||||||
}
|
}
|
||||||
|
|
||||||
// The two surface directions projection_raw()'s u and v run along at `p`, plus how many raw units one
|
// The two surface directions projection_raw()'s u and v run along at `p`, plus how many raw units one
|
||||||
@@ -190,7 +202,7 @@ void projection_axes(vec3 p, vec3 n, out vec3 t, out vec3 b, out vec2 units_per_
|
|||||||
vec2 xy = vec2(dot(rel, right), dot(rel, fwd));
|
vec2 xy = vec2(dot(rel, right), dot(rel, fwd));
|
||||||
float r = length(xy);
|
float r = length(xy);
|
||||||
t = (r > 1e-6) ? (fwd * xy.x - right * xy.y) / r : right; // circumferential: u runs along it
|
t = (r > 1e-6) ? (fwd * xy.x - right * xy.y) / r : right; // circumferential: u runs along it
|
||||||
b = up; // v is the distance along the axis
|
b = -up; // v is the distance *against* the axis
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
if (projection_mode == 2) {
|
if (projection_mode == 2) {
|
||||||
@@ -199,20 +211,20 @@ void projection_axes(vec3 p, vec3 n, out vec3 t, out vec3 b, out vec2 units_per_
|
|||||||
vec3 dir = (r > 1e-8) ? rel / r : vec3(0.0, 0.0, 1.0);
|
vec3 dir = (r > 1e-8) ? rel / r : vec3(0.0, 0.0, 1.0);
|
||||||
float c = length(dir.xy); // cos(latitude)
|
float c = length(dir.xy); // cos(latitude)
|
||||||
t = (c > 1e-6) ? vec3(-dir.y, dir.x, 0.0) / c : vec3(1.0, 0.0, 0.0);
|
t = (c > 1e-6) ? vec3(-dir.y, dir.x, 0.0) / c : vec3(1.0, 0.0, 0.0);
|
||||||
b = cross(dir, t); // increasing latitude, unit length
|
b = -cross(dir, t); // v grows away from the pole, unit length
|
||||||
units_per_mm = vec2(1.0 / max(c, 1e-3), 1.0);
|
units_per_mm = vec2(1.0 / max(c, 1e-3), 1.0);
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
vec3 an = abs(n);
|
vec3 an = abs(n); // the same signed basis projection_raw() uses
|
||||||
if (an.x >= an.y && an.x >= an.z) { // planar = p.yz
|
if (an.x >= an.y && an.x >= an.z) { // planar = (+-y, -z)
|
||||||
t = vec3(0.0, 1.0, 0.0);
|
t = vec3(0.0, box_face_sign(n.x), 0.0);
|
||||||
b = vec3(0.0, 0.0, 1.0);
|
b = vec3(0.0, 0.0, -1.0);
|
||||||
} else if (an.y >= an.x && an.y >= an.z) { // planar = p.xz
|
} else if (an.y >= an.x && an.y >= an.z) { // planar = (+-x, -z)
|
||||||
t = vec3(1.0, 0.0, 0.0);
|
t = vec3(-box_face_sign(n.y), 0.0, 0.0);
|
||||||
b = vec3(0.0, 0.0, 1.0);
|
b = vec3(0.0, 0.0, -1.0);
|
||||||
} else { // planar = p.xy
|
} else { // planar = (+-x, -y)
|
||||||
t = vec3(1.0, 0.0, 0.0);
|
t = vec3(box_face_sign(n.z), 0.0, 0.0);
|
||||||
b = vec3(0.0, 1.0, 0.0);
|
b = vec3(0.0, -1.0, 0.0);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -47,14 +47,20 @@ in vec2 vertex_uv;
|
|||||||
|
|
||||||
out vec4 out_color;
|
out vec4 out_color;
|
||||||
|
|
||||||
|
// Right handed (up x right), like libslic3r's project_cylindrical(), so the angle taken from it grows
|
||||||
|
// anticlockwise about the axis - to the viewer's right when seen from outside the cylinder.
|
||||||
void cylinder_frame(out vec3 up, out vec3 right, out vec3 fwd)
|
void cylinder_frame(out vec3 up, out vec3 right, out vec3 fwd)
|
||||||
{
|
{
|
||||||
up = (length(patch_axis) > 1e-8) ? normalize(patch_axis) : vec3(0.0, 0.0, 1.0);
|
up = (length(patch_axis) > 1e-8) ? normalize(patch_axis) : vec3(0.0, 0.0, 1.0);
|
||||||
vec3 arbitrary = (abs(up.z) < 0.9) ? vec3(0.0, 0.0, 1.0) : vec3(1.0, 0.0, 0.0);
|
vec3 arbitrary = (abs(up.z) < 0.9) ? vec3(0.0, 0.0, 1.0) : vec3(1.0, 0.0, 0.0);
|
||||||
right = normalize(cross(up, arbitrary));
|
right = normalize(cross(up, arbitrary));
|
||||||
fwd = normalize(cross(right, up));
|
fwd = normalize(cross(up, right));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Which side of a world plane a face is on, with zero counting as the positive side. Not GLSL's own
|
||||||
|
// sign(), which returns 0 there and would collapse the coordinate onto a line.
|
||||||
|
float box_face_sign(float n) { return n >= 0.0 ? 1.0 : -1.0; }
|
||||||
|
|
||||||
// Term for term libslic3r's project_planar() / project_cylindrical() / project_spherical(), in mm.
|
// Term for term libslic3r's project_planar() / project_cylindrical() / project_spherical(), in mm.
|
||||||
vec2 projection_raw(vec3 p, vec3 n)
|
vec2 projection_raw(vec3 p, vec3 n)
|
||||||
{
|
{
|
||||||
@@ -64,7 +70,7 @@ vec2 projection_raw(vec3 p, vec3 n)
|
|||||||
vec3 rel = p - patch_center;
|
vec3 rel = p - patch_center;
|
||||||
float x = dot(rel, right);
|
float x = dot(rel, right);
|
||||||
float y = dot(rel, fwd);
|
float y = dot(rel, fwd);
|
||||||
return vec2(atan(y, x) * sqrt(x * x + y * y), dot(rel, up));
|
return vec2(atan(y, x) * sqrt(x * x + y * y), -dot(rel, up));
|
||||||
}
|
}
|
||||||
if (projection_mode == 2) {
|
if (projection_mode == 2) {
|
||||||
vec3 rel = p - patch_center;
|
vec3 rel = p - patch_center;
|
||||||
@@ -72,10 +78,16 @@ vec2 projection_raw(vec3 p, vec3 n)
|
|||||||
if (radius < 1e-8)
|
if (radius < 1e-8)
|
||||||
return vec2(0.0);
|
return vec2(0.0);
|
||||||
vec3 dir = rel / radius;
|
vec3 dir = rel / radius;
|
||||||
return vec2(atan(dir.y, dir.x), asin(clamp(dir.z, -1.0, 1.0))) * radius;
|
return vec2(atan(dir.y, dir.x), -asin(clamp(dir.z, -1.0, 1.0))) * radius;
|
||||||
}
|
}
|
||||||
|
// v negated so the image's first pixel row sits at the top of the model, u flipped on the far side
|
||||||
|
// of each plane so the two faces sharing it are not mirror images - see libslic3r's box_plane_yz().
|
||||||
vec3 an = abs(n);
|
vec3 an = abs(n);
|
||||||
return (an.x >= an.y && an.x >= an.z) ? p.yz : ((an.y >= an.x && an.y >= an.z) ? p.xz : p.xy);
|
if (an.x >= an.y && an.x >= an.z)
|
||||||
|
return vec2(box_face_sign(n.x) * p.y, -p.z);
|
||||||
|
if (an.y >= an.x && an.y >= an.z)
|
||||||
|
return vec2(-box_face_sign(n.y) * p.x, -p.z);
|
||||||
|
return vec2(box_face_sign(n.z) * p.x, -p.y);
|
||||||
}
|
}
|
||||||
|
|
||||||
vec2 project_uv(vec3 p, vec3 n)
|
vec2 project_uv(vec3 p, vec3 n)
|
||||||
|
|||||||
+43
-17
@@ -1,21 +1,27 @@
|
|||||||
#!/usr/bin/env bash
|
#!/usr/bin/env bash
|
||||||
# Lets a pull request's macOS deps build wait for a push build of the base
|
# Lets a pull request's macOS deps build, or its clang-tidy job, wait for a
|
||||||
# branch that builds the same deps, from a Linux job. `check` runs after a cache
|
# build that saves the deps cache it needs, from a Linux job. `check` runs after
|
||||||
# miss and names a queued or running base build with the same deps/ and .github/
|
# a cache miss and names a queued or running push build of the base branch with
|
||||||
# to wait for, unless the pull request changes either. `wait` waits until that
|
# the same deps/ and .github/ to wait for, unless the pull request changes either.
|
||||||
# build saves KEY. actions/cache then confirms the entry can be restored.
|
# `own` names the pull request's own build instead, for clang-tidy when the pull
|
||||||
|
# request changes deps/. `wait` waits until that build saves KEY under CACHE_REF,
|
||||||
|
# or its deps job fails. actions/cache then confirms the entry can be restored.
|
||||||
#
|
#
|
||||||
# Environment: GH_TOKEN, REPO, WORKFLOW_REF and BASE_REF, plus KEY_INPUTS,
|
# Environment: GH_TOKEN, REPO, WORKFLOW_REF (or WORKFLOW, the build workflow's
|
||||||
# WAIT_FOR, WAIT_SINCE, WAIT_MINUTES, KEY and ARCH for `wait`.
|
# file name) and BASE_REF, plus HEAD_SHA for `own`, and KEY_INPUTS, WAIT_FOR,
|
||||||
|
# WAIT_SINCE, WAIT_MINUTES, KEY, CACHE_REF (default the base branch) and ARCH
|
||||||
|
# (or JOB, the matrix job's name) for `wait`.
|
||||||
# Writes key-inputs, wait-for and wait-since to $GITHUB_OUTPUT.
|
# Writes key-inputs, wait-for and wait-since to $GITHUB_OUTPUT.
|
||||||
set -uo pipefail
|
set -uo pipefail
|
||||||
|
|
||||||
workflow=${WORKFLOW_REF%%@*}
|
workflow=${WORKFLOW_REF:-}
|
||||||
workflow=${workflow##*/}
|
workflow=${workflow%%@*}
|
||||||
|
workflow=${WORKFLOW:-${workflow##*/}}
|
||||||
|
|
||||||
# Must match the job names in build_all.yml, build_check_cache.yml and build_deps.yml.
|
# Must match the job names in build_all.yml, build_check_cache.yml and build_deps.yml.
|
||||||
check_job_name="build_macos_arch (${ARCH:-}) / Check Cache"
|
job=${JOB:-build_macos_arch (${ARCH:-})}
|
||||||
deps_job_name="build_macos_arch (${ARCH:-}) / Build Deps / Build Deps"
|
check_job_name="$job / Check Cache"
|
||||||
|
deps_job_name="$job / Build Deps / Build Deps"
|
||||||
|
|
||||||
out() { echo "$1" >> "${GITHUB_OUTPUT:-/dev/stdout}"; }
|
out() { echo "$1" >> "${GITHUB_OUTPUT:-/dev/stdout}"; }
|
||||||
|
|
||||||
@@ -63,8 +69,27 @@ check() {
|
|||||||
fi
|
fi
|
||||||
}
|
}
|
||||||
|
|
||||||
|
own() {
|
||||||
|
out "key-inputs=$(local_key_inputs HEAD)"
|
||||||
|
local id
|
||||||
|
# The build can be created a moment after this job.
|
||||||
|
for _ in 1 2 3 4 5; do
|
||||||
|
id=$(gh api -X GET "repos/$REPO/actions/workflows/$workflow/runs" \
|
||||||
|
-f head_sha="$HEAD_SHA" -f event=pull_request -f per_page=1 --jq '.workflow_runs[0].id // empty' < /dev/null)
|
||||||
|
[ -n "$id" ] && break
|
||||||
|
sleep 30
|
||||||
|
done
|
||||||
|
if [ -n "$id" ]; then
|
||||||
|
echo "Waiting for the deps cache of build $id of this pull request."
|
||||||
|
out "wait-for=$id"
|
||||||
|
out "wait-since=$(date +%s)"
|
||||||
|
else
|
||||||
|
echo "No build of this pull request is building its deps."
|
||||||
|
fi
|
||||||
|
}
|
||||||
|
|
||||||
key_saved() {
|
key_saved() {
|
||||||
gh cache list -R "$REPO" --ref "refs/heads/$BASE_REF" --key "$KEY" --json key < /dev/null \
|
gh cache list -R "$REPO" --ref "${CACHE_REF:-refs/heads/$BASE_REF}" --key "$KEY" --json key < /dev/null \
|
||||||
| jq -e --arg key "$KEY" 'any(.[]; .key == $key)' > /dev/null
|
| jq -e --arg key "$KEY" 'any(.[]; .key == $key)' > /dev/null
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -87,11 +112,11 @@ wait_for() {
|
|||||||
key_saved && { echo "Found $KEY."; return; }
|
key_saved && { echo "Found $KEY."; return; }
|
||||||
sleep 20
|
sleep 20
|
||||||
done
|
done
|
||||||
echo "Build $id of $BASE_REF finished its deps without saving $KEY."
|
echo "Build $id finished its deps without saving $KEY."
|
||||||
return ;;
|
return ;;
|
||||||
"completed cancelled") ;;
|
"completed cancelled") ;;
|
||||||
completed*)
|
completed*)
|
||||||
echo "The deps job of build $id of $BASE_REF did not succeed."
|
echo "The deps job of build $id did not succeed."
|
||||||
return ;;
|
return ;;
|
||||||
# The deps job exists only once the build's cache check has succeeded.
|
# The deps job exists only once the build's cache check has succeeded.
|
||||||
"")
|
"")
|
||||||
@@ -100,7 +125,7 @@ wait_for() {
|
|||||||
completed*)
|
completed*)
|
||||||
check=$(jq -r --arg name "$check_job_name" 'first(.jobs[] | select(.name == $name) | .conclusion) // ""' <<< "$jobs")
|
check=$(jq -r --arg name "$check_job_name" 'first(.jobs[] | select(.name == $name) | .conclusion) // ""' <<< "$jobs")
|
||||||
if [ -z "$warned" ] && { [ -z "$check" ] || [ "$check" = success ]; }; then
|
if [ -z "$warned" ] && { [ -z "$check" ] || [ "$check" = success ]; }; then
|
||||||
echo "::warning title=Deps wait::Build $id of $BASE_REF has no job named \"$deps_job_name\". If the build jobs were renamed, update scripts/ci_deps_cache.sh. This does not affect this pull request."
|
echo "::warning title=Deps wait::Build $id has no job named \"$deps_job_name\". If the build jobs were renamed, update scripts/ci_deps_cache.sh. This does not affect this pull request."
|
||||||
warned=1
|
warned=1
|
||||||
fi ;;
|
fi ;;
|
||||||
*)
|
*)
|
||||||
@@ -118,11 +143,12 @@ wait_for() {
|
|||||||
seen="$seen $id"
|
seen="$seen $id"
|
||||||
echo "Following build $id of $BASE_REF."
|
echo "Following build $id of $BASE_REF."
|
||||||
done
|
done
|
||||||
echo "No build of $BASE_REF saved $KEY."
|
echo "No build saved $KEY."
|
||||||
}
|
}
|
||||||
|
|
||||||
case "${1:-}" in
|
case "${1:-}" in
|
||||||
check) check ;;
|
check) check ;;
|
||||||
|
own) own ;;
|
||||||
wait) wait_for ;;
|
wait) wait_for ;;
|
||||||
*) echo "usage: $0 check|wait" >&2; exit 2 ;;
|
*) echo "usage: $0 check|own|wait" >&2; exit 2 ;;
|
||||||
esac
|
esac
|
||||||
|
|||||||
+28
-6
@@ -99,6 +99,7 @@
|
|||||||
#include "libslic3r/Preset.hpp"
|
#include "libslic3r/Preset.hpp"
|
||||||
#include "libslic3r/Geometry.hpp"
|
#include "libslic3r/Geometry.hpp"
|
||||||
#include "libslic3r/GCode.hpp"
|
#include "libslic3r/GCode.hpp"
|
||||||
|
#include "libslic3r/MeshRepair.hpp"
|
||||||
#include "libslic3r/Model.hpp"
|
#include "libslic3r/Model.hpp"
|
||||||
#include "libslic3r/ModelArrange.hpp"
|
#include "libslic3r/ModelArrange.hpp"
|
||||||
#include "libslic3r/Platform.hpp"
|
#include "libslic3r/Platform.hpp"
|
||||||
@@ -206,7 +207,7 @@ std::map<int, std::string> cli_errors = {
|
|||||||
{CLI_OBJECT_ORIENT_FAILED, "An error occurred when auto-orienting object(s)."},
|
{CLI_OBJECT_ORIENT_FAILED, "An error occurred when auto-orienting object(s)."},
|
||||||
{CLI_MODIFIED_PARAMS_TO_PRINTER, "Found modified parameter in printer preset in the 3mf file, which should not be changed."},
|
{CLI_MODIFIED_PARAMS_TO_PRINTER, "Found modified parameter in printer preset in the 3mf file, which should not be changed."},
|
||||||
{CLI_FILE_VERSION_NOT_SUPPORTED, "Unsupported 3MF version. Please make sure the 3MF file was created with the official version of Bambu Studio, not a beta version."},
|
{CLI_FILE_VERSION_NOT_SUPPORTED, "Unsupported 3MF version. Please make sure the 3MF file was created with the official version of Bambu Studio, not a beta version."},
|
||||||
{CLI_NO_SUITABLE_OBJECTS, "One of the plate is empty or has no object fully inside it. Please check that the 3mf contains no empty plate in Orca Slicer before uploading."},
|
{CLI_NO_SUITABLE_OBJECTS, "The plate has nothing to slice: it is empty, or no object on it is both printable and fully inside the print volume."},
|
||||||
{CLI_VALIDATE_ERROR, "There are some incorrect slicing parameters in the 3mf. Please verify the slicing of all plates in Orca Slicer before uploading."},
|
{CLI_VALIDATE_ERROR, "There are some incorrect slicing parameters in the 3mf. Please verify the slicing of all plates in Orca Slicer before uploading."},
|
||||||
{CLI_OBJECTS_PARTLY_INSIDE, "Some objects are located over the boundary of the heated bed."},
|
{CLI_OBJECTS_PARTLY_INSIDE, "Some objects are located over the boundary of the heated bed."},
|
||||||
{CLI_EXPORT_CACHE_DIRECTORY_CREATE_FAILED, "Failed creating directory when exporting cache data."},
|
{CLI_EXPORT_CACHE_DIRECTORY_CREATE_FAILED, "Failed creating directory when exporting cache data."},
|
||||||
@@ -1463,7 +1464,7 @@ int CLI::run(int argc, char **argv)
|
|||||||
//int arrange_option;
|
//int arrange_option;
|
||||||
int plate_to_slice = 0, filament_count = 0, duplicate_count = 0, real_duplicate_count = 0, current_extruder_count = 1, new_extruder_count = 1, current_printer_variant_count = 1, current_print_variant_count = 1, new_printer_variant_count = 1;
|
int plate_to_slice = 0, filament_count = 0, duplicate_count = 0, real_duplicate_count = 0, current_extruder_count = 1, new_extruder_count = 1, current_printer_variant_count = 1, current_print_variant_count = 1, new_printer_variant_count = 1;
|
||||||
bool first_file = true, is_bbl_3mf = false, need_arrange = true, has_thumbnails = false, up_config_to_date = false, normative_check = true, duplicate_single_object = false, use_first_fila_as_default = false, minimum_save = false, enable_timelapse = false;
|
bool first_file = true, is_bbl_3mf = false, need_arrange = true, has_thumbnails = false, up_config_to_date = false, normative_check = true, duplicate_single_object = false, use_first_fila_as_default = false, minimum_save = false, enable_timelapse = false;
|
||||||
bool allow_rotations = true, skip_modified_gcodes = false, avoid_extrusion_cali_region = false, skip_useless_pick = false, allow_newer_file = false, current_is_multi_extruder = false, new_is_multi_extruder = false, allow_mix_temp = false, enable_wrapping_detect = false;
|
bool allow_rotations = false, skip_modified_gcodes = false, avoid_extrusion_cali_region = false, skip_useless_pick = false, allow_newer_file = false, current_is_multi_extruder = false, new_is_multi_extruder = false, allow_mix_temp = false, enable_wrapping_detect = false;
|
||||||
Semver file_version;
|
Semver file_version;
|
||||||
std::map<size_t, bool> orients_requirement;
|
std::map<size_t, bool> orients_requirement;
|
||||||
std::vector<Preset*> project_presets;
|
std::vector<Preset*> project_presets;
|
||||||
@@ -5130,9 +5131,19 @@ int CLI::run(int argc, char **argv)
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
} else if (opt_key == "repair") {
|
} else if (opt_key == "repair") {
|
||||||
// Models are repaired by default.
|
if (m_config.opt_bool(opt_key))
|
||||||
//for (auto &model : m_models)
|
for (Model &model : m_models)
|
||||||
// model.repair();
|
for (ModelObject *object : model.objects) {
|
||||||
|
for (ModelVolume *volume : object->volumes) {
|
||||||
|
MeshRepairStats stats;
|
||||||
|
std::string error;
|
||||||
|
if (!volume->repair(true, &stats, &error))
|
||||||
|
BOOST_LOG_TRIVIAL(warning) << "repair of " << object->name << " / " << volume->name << " failed: " << error;
|
||||||
|
else if (stats.modified)
|
||||||
|
BOOST_LOG_TRIVIAL(info) << "repaired " << object->name << " / " << volume->name;
|
||||||
|
}
|
||||||
|
object->invalidate_bounding_box();
|
||||||
|
}
|
||||||
} else {
|
} else {
|
||||||
boost::nowide::cerr << "error: option not implemented yet: " << opt_key << std::endl;
|
boost::nowide::cerr << "error: option not implemented yet: " << opt_key << std::endl;
|
||||||
record_exit_reson(outfile_dir, CLI_UNSUPPORTED_OPERATION, 0, cli_errors[CLI_UNSUPPORTED_OPERATION], sliced_info);
|
record_exit_reson(outfile_dir, CLI_UNSUPPORTED_OPERATION, 0, cli_errors[CLI_UNSUPPORTED_OPERATION], sliced_info);
|
||||||
@@ -5142,6 +5153,7 @@ int CLI::run(int argc, char **argv)
|
|||||||
|
|
||||||
BOOST_LOG_TRIVIAL(info) << "finished model pre-process commands\n";
|
BOOST_LOG_TRIVIAL(info) << "finished model pre-process commands\n";
|
||||||
bool oriented_or_arranged = false;
|
bool oriented_or_arranged = false;
|
||||||
|
bool arranged_without_rotations = false;
|
||||||
//BBS: add orient and arrange logic here
|
//BBS: add orient and arrange logic here
|
||||||
for (auto& model : m_models)
|
for (auto& model : m_models)
|
||||||
{
|
{
|
||||||
@@ -5409,6 +5421,7 @@ int CLI::run(int argc, char **argv)
|
|||||||
BOOST_LOG_TRIVIAL(info) << boost::format("start plate %1%'s arranging...") % (i + 1);
|
BOOST_LOG_TRIVIAL(info) << boost::format("start plate %1%'s arranging...") % (i + 1);
|
||||||
arrangement::arrange(selected, unselected, beds, arrange_cfg);
|
arrangement::arrange(selected, unselected, beds, arrange_cfg);
|
||||||
//arrangement::arrange(unprintable, {}, beds, arrange_cfg);
|
//arrangement::arrange(unprintable, {}, beds, arrange_cfg);
|
||||||
|
arranged_without_rotations |= !arrange_cfg.allow_rotations;
|
||||||
BOOST_LOG_TRIVIAL(info) << boost::format("finished plate %1%'s arranging") % (i + 1);
|
BOOST_LOG_TRIVIAL(info) << boost::format("finished plate %1%'s arranging") % (i + 1);
|
||||||
|
|
||||||
//step-4: postprocess the bed index and result
|
//step-4: postprocess the bed index and result
|
||||||
@@ -5881,6 +5894,7 @@ int CLI::run(int argc, char **argv)
|
|||||||
BOOST_LOG_TRIVIAL(info) << boost::format("start %1% th arranging...")%arrange_count;
|
BOOST_LOG_TRIVIAL(info) << boost::format("start %1% th arranging...")%arrange_count;
|
||||||
arrangement::arrange(selected, unselected, beds, arrange_cfg);
|
arrangement::arrange(selected, unselected, beds, arrange_cfg);
|
||||||
arrangement::arrange(unprintable, {}, beds, arrange_cfg);
|
arrangement::arrange(unprintable, {}, beds, arrange_cfg);
|
||||||
|
arranged_without_rotations |= !arrange_cfg.allow_rotations;
|
||||||
BOOST_LOG_TRIVIAL(info) << boost::format("finished %1% th arranging...")%arrange_count;
|
BOOST_LOG_TRIVIAL(info) << boost::format("finished %1% th arranging...")%arrange_count;
|
||||||
|
|
||||||
//Step-4:postprocess by partplate list&&apply the result
|
//Step-4:postprocess by partplate list&&apply the result
|
||||||
@@ -6425,7 +6439,15 @@ int CLI::run(int argc, char **argv)
|
|||||||
|
|
||||||
if (count == 0) {
|
if (count == 0) {
|
||||||
BOOST_LOG_TRIVIAL(error) << "plate "<< index+1<< ": Nothing to be sliced, Either the print is empty or no object is fully inside the print volume before apply." << std::endl;
|
BOOST_LOG_TRIVIAL(error) << "plate "<< index+1<< ": Nothing to be sliced, Either the print is empty or no object is fully inside the print volume before apply." << std::endl;
|
||||||
record_exit_reson(outfile_dir, CLI_NO_SUITABLE_OBJECTS, index+1, cli_errors[CLI_NO_SUITABLE_OBJECTS], sliced_info);
|
std::string no_objects_reason = cli_errors[CLI_NO_SUITABLE_OBJECTS];
|
||||||
|
if (arranged_without_rotations) {
|
||||||
|
//ORCA: result.json is only written on Linux, so also print the reason to stderr.
|
||||||
|
no_objects_reason = "No object is fully inside the print volume. Arrange ran without rotations."
|
||||||
|
" If an object only fits the bed when rotated, pass --allow-rotations."
|
||||||
|
" Otherwise the plate is empty or an object is larger than the printable area or height.";
|
||||||
|
boost::nowide::cerr << "plate " << index+1 << ": " << no_objects_reason << std::endl;
|
||||||
|
}
|
||||||
|
record_exit_reson(outfile_dir, CLI_NO_SUITABLE_OBJECTS, index+1, no_objects_reason, sliced_info);
|
||||||
flush_and_exit(CLI_NO_SUITABLE_OBJECTS);
|
flush_and_exit(CLI_NO_SUITABLE_OBJECTS);
|
||||||
}
|
}
|
||||||
else if ((plate_to_slice != 0) || pre_check) {
|
else if ((plate_to_slice != 0) || pre_check) {
|
||||||
|
|||||||
@@ -625,6 +625,7 @@ add_library(libslic3r_cgal STATIC
|
|||||||
CutSurface.hpp CutSurface.cpp
|
CutSurface.hpp CutSurface.cpp
|
||||||
IntersectionPoints.hpp IntersectionPoints.cpp
|
IntersectionPoints.hpp IntersectionPoints.cpp
|
||||||
MeshBoolean.hpp MeshBoolean.cpp
|
MeshBoolean.hpp MeshBoolean.cpp
|
||||||
|
MeshRepair.hpp MeshRepair.cpp
|
||||||
TryCatchSignal.hpp TryCatchSignal.cpp
|
TryCatchSignal.hpp TryCatchSignal.cpp
|
||||||
Triangulation.hpp Triangulation.cpp
|
Triangulation.hpp Triangulation.cpp
|
||||||
)
|
)
|
||||||
@@ -652,7 +653,9 @@ if (IS_CLANG_CL)
|
|||||||
target_compile_options(libslic3r_cgal PRIVATE -Wno-overriding-option)
|
target_compile_options(libslic3r_cgal PRIVATE -Wno-overriding-option)
|
||||||
endif ()
|
endif ()
|
||||||
|
|
||||||
target_link_libraries(libslic3r_cgal PRIVATE ${_cgal_tgt} admesh libigl mcut boost_libs)
|
# Lets CGAL algorithms given CGAL::Parallel_if_available_tag run on TBB.
|
||||||
|
target_compile_definitions(libslic3r_cgal PRIVATE CGAL_LINKED_WITH_TBB)
|
||||||
|
target_link_libraries(libslic3r_cgal PRIVATE ${_cgal_tgt} admesh libigl mcut boost_libs TBB::tbb)
|
||||||
|
|
||||||
if (MSVC AND "${CMAKE_SIZEOF_VOID_P}" STREQUAL "4") # 32 bit MSVC workaround
|
if (MSVC AND "${CMAKE_SIZEOF_VOID_P}" STREQUAL "4") # 32 bit MSVC workaround
|
||||||
target_compile_definitions(libslic3r_cgal PRIVATE CGAL_DO_NOT_USE_MPZF)
|
target_compile_definitions(libslic3r_cgal PRIVATE CGAL_DO_NOT_USE_MPZF)
|
||||||
|
|||||||
@@ -236,19 +236,29 @@ static void getNamedSolids(const TopLoc_Location& location,
|
|||||||
int i = 0;
|
int i = 0;
|
||||||
switch (shape_type) {
|
switch (shape_type) {
|
||||||
case TopAbs_COMPOUND:
|
case TopAbs_COMPOUND:
|
||||||
if (!isSplitCompound) {
|
|
||||||
namedSolids.emplace_back(TopoDS::Compound(transform.Shape()), fullName);
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
case TopAbs_COMPSOLID:
|
case TopAbs_COMPSOLID:
|
||||||
if (!isSplitCompound) {
|
if (!isSplitCompound) {
|
||||||
namedSolids.emplace_back(TopoDS::CompSolid(transform.Shape()), fullName);
|
namedSolids.emplace_back(transform.Shape(), fullName);
|
||||||
} else {
|
} else {
|
||||||
for (explorer.Init(transform.Shape(), TopAbs_SOLID); explorer.More(); explorer.Next()) {
|
for (explorer.Init(transform.Shape(), TopAbs_SOLID); explorer.More(); explorer.Next()) {
|
||||||
i++;
|
i++;
|
||||||
const TopoDS_Shape& currentShape = explorer.Current();
|
const TopoDS_Shape& currentShape = explorer.Current();
|
||||||
namedSolids.emplace_back(TopoDS::Solid(currentShape), fullName + "-SOLID-" + std::to_string(i));
|
namedSolids.emplace_back(TopoDS::Solid(currentShape), fullName + "-SOLID-" + std::to_string(i));
|
||||||
}
|
}
|
||||||
|
// Surface models have no solids: each shell outside a solid is a part, and loose faces stay together.
|
||||||
|
i = 0;
|
||||||
|
for (explorer.Init(transform.Shape(), TopAbs_SHELL, TopAbs_SOLID); explorer.More(); explorer.Next())
|
||||||
|
namedSolids.emplace_back(explorer.Current(), fullName + "-SHELL-" + std::to_string(++i));
|
||||||
|
TopoDS_Compound loose_faces;
|
||||||
|
TopoDS_Builder builder;
|
||||||
|
builder.MakeCompound(loose_faces);
|
||||||
|
bool has_loose_faces = false;
|
||||||
|
for (explorer.Init(transform.Shape(), TopAbs_FACE, TopAbs_SHELL); explorer.More(); explorer.Next()) {
|
||||||
|
builder.Add(loose_faces, explorer.Current());
|
||||||
|
has_loose_faces = true;
|
||||||
|
}
|
||||||
|
if (has_loose_faces)
|
||||||
|
namedSolids.emplace_back(loose_faces, fullName);
|
||||||
}
|
}
|
||||||
break;
|
break;
|
||||||
case TopAbs_SOLID:
|
case TopAbs_SOLID:
|
||||||
|
|||||||
@@ -22,6 +22,7 @@
|
|||||||
#include "libslic3r/BrimEarsPoint.hpp"
|
#include "libslic3r/BrimEarsPoint.hpp"
|
||||||
#include "libslic3r/Config.hpp"
|
#include "libslic3r/Config.hpp"
|
||||||
#include "libslic3r/CustomGCode.hpp"
|
#include "libslic3r/CustomGCode.hpp"
|
||||||
|
#include "libslic3r/TextureDisplacement.hpp"
|
||||||
#include "libslic3r_version.h"
|
#include "libslic3r_version.h"
|
||||||
|
|
||||||
#include "bbs_3mf.hpp"
|
#include "bbs_3mf.hpp"
|
||||||
@@ -354,6 +355,13 @@ static constexpr const char* CUSTOM_SUPPORTS_ATTR = "paint_supports";
|
|||||||
static constexpr const char* CUSTOM_FUZZY_SKIN_ATTR = "paint_fuzzy_skin";
|
static constexpr const char* CUSTOM_FUZZY_SKIN_ATTR = "paint_fuzzy_skin";
|
||||||
static constexpr const char* CUSTOM_SEAM_ATTR = "paint_seam";
|
static constexpr const char* CUSTOM_SEAM_ATTR = "paint_seam";
|
||||||
static constexpr const char* MMU_SEGMENTATION_ATTR = "paint_color";
|
static constexpr const char* MMU_SEGMENTATION_ATTR = "paint_color";
|
||||||
|
// Texture displacement. One paint mask per layer slot, mirroring paint_color; the layer stack itself is
|
||||||
|
// a JSON file in the archive, named by the volume metadata key below (see add_texture_displacement()).
|
||||||
|
static constexpr const char* TEXTURE_DISPLACEMENT_ATTRS[Slic3r::TEXTURE_DISPLACEMENT_MAX_LAYERS] = {
|
||||||
|
"paint_texture_0", "paint_texture_1", "paint_texture_2", "paint_texture_3",
|
||||||
|
"paint_texture_4", "paint_texture_5", "paint_texture_6", "paint_texture_7" };
|
||||||
|
static constexpr const char* TEXTURE_DISPLACEMENT_KEY = "texture_displacement";
|
||||||
|
static constexpr const char* TEXTURE_DISPLACEMENT_DIR = "Metadata/texture_displacement/";
|
||||||
// BBS
|
// BBS
|
||||||
static constexpr const char* FACE_PROPERTY_ATTR = "face_property";
|
static constexpr const char* FACE_PROPERTY_ATTR = "face_property";
|
||||||
|
|
||||||
@@ -847,6 +855,9 @@ void PlateData::parse_filament_info(GCodeProcessorResult *result)
|
|||||||
std::vector<std::string> custom_seam;
|
std::vector<std::string> custom_seam;
|
||||||
std::vector<std::string> mmu_segmentation;
|
std::vector<std::string> mmu_segmentation;
|
||||||
std::vector<std::string> fuzzy_skin;
|
std::vector<std::string> fuzzy_skin;
|
||||||
|
// One per texture displacement layer slot, indexed like `triangles` but stored only as far as the
|
||||||
|
// slot's last painted triangle: empty when the slot has no paint, which is nearly every file.
|
||||||
|
std::vector<std::string> texture_displacement[TEXTURE_DISPLACEMENT_MAX_LAYERS];
|
||||||
// BBS
|
// BBS
|
||||||
std::vector<std::string> face_properties;
|
std::vector<std::string> face_properties;
|
||||||
|
|
||||||
@@ -867,6 +878,8 @@ void PlateData::parse_filament_info(GCodeProcessorResult *result)
|
|||||||
custom_seam.clear();
|
custom_seam.clear();
|
||||||
mmu_segmentation.clear();
|
mmu_segmentation.clear();
|
||||||
fuzzy_skin.clear();
|
fuzzy_skin.clear();
|
||||||
|
for (std::vector<std::string> &slot : texture_displacement)
|
||||||
|
slot.clear();
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -1200,6 +1213,11 @@ void PlateData::parse_filament_info(GCodeProcessorResult *result)
|
|||||||
/*IdToSlaSupportPointsMap m_sla_support_points;
|
/*IdToSlaSupportPointsMap m_sla_support_points;
|
||||||
IdToSlaDrainHolesMap m_sla_drain_holes;*/
|
IdToSlaDrainHolesMap m_sla_drain_holes;*/
|
||||||
PathToEmbossShapeFileMap m_path_to_emboss_shape_files;
|
PathToEmbossShapeFileMap m_path_to_emboss_shape_files;
|
||||||
|
// Texture displacement: every file under Metadata/texture_displacement/, by archive path. Volumes
|
||||||
|
// are built only after the whole archive has been walked, so by the time a volume names its JSON
|
||||||
|
// every file it could refer to is already in here, whatever order the archive happened to be in.
|
||||||
|
std::map<std::string, std::string> m_texture_displacement_files;
|
||||||
|
void _apply_texture_displacement(ModelVolume &volume, const std::string &json_path);
|
||||||
std::string m_curr_metadata_name;
|
std::string m_curr_metadata_name;
|
||||||
std::string m_curr_characters;
|
std::string m_curr_characters;
|
||||||
std::string m_name;
|
std::string m_name;
|
||||||
@@ -2073,6 +2091,13 @@ void PlateData::parse_filament_info(GCodeProcessorResult *result)
|
|||||||
else if (_is_svg_shape_file(name)) {
|
else if (_is_svg_shape_file(name)) {
|
||||||
_extract_embossed_svg_shape_file(name, archive, stat);
|
_extract_embossed_svg_shape_file(name, archive, stat);
|
||||||
}
|
}
|
||||||
|
else if (boost::algorithm::istarts_with(name, TEXTURE_DISPLACEMENT_DIR)) {
|
||||||
|
std::string contents(stat.m_uncomp_size, '\0');
|
||||||
|
if (mz_zip_reader_extract_to_mem(&archive, stat.m_file_index, contents.data(), stat.m_uncomp_size, 0))
|
||||||
|
m_texture_displacement_files.emplace(name, std::move(contents));
|
||||||
|
else
|
||||||
|
add_error("Error while reading texture displacement data");
|
||||||
|
}
|
||||||
else if (!dont_load_config && boost::algorithm::iequals(name, SLICE_INFO_CONFIG_FILE)) {
|
else if (!dont_load_config && boost::algorithm::iequals(name, SLICE_INFO_CONFIG_FILE)) {
|
||||||
m_parsing_slice_info = true;
|
m_parsing_slice_info = true;
|
||||||
//extract slice info from archive
|
//extract slice info from archive
|
||||||
@@ -3310,6 +3335,45 @@ void PlateData::parse_filament_info(GCodeProcessorResult *result)
|
|||||||
}
|
}
|
||||||
}*/
|
}*/
|
||||||
|
|
||||||
|
// Restores one volume's texture displacement stack from the JSON it named. Called while the volume is
|
||||||
|
// being built, which is after the whole archive has been walked - so every file it can refer to is
|
||||||
|
// already extracted, and no deferral is needed.
|
||||||
|
//
|
||||||
|
// A missing or malformed JSON leaves the volume with no layers but keeps the paint mask it already
|
||||||
|
// loaded, which is the same state as a project saved by a build without the feature: recoverable by
|
||||||
|
// picking the texture again rather than a hard failure.
|
||||||
|
void _BBS_3MF_Importer::_apply_texture_displacement(ModelVolume &volume, const std::string &json_path)
|
||||||
|
{
|
||||||
|
const auto json = m_texture_displacement_files.find(json_path);
|
||||||
|
if (json == m_texture_displacement_files.end()) {
|
||||||
|
add_error("Missing texture displacement data: " + json_path);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
std::vector<TextureDisplacementLayer> layers;
|
||||||
|
TextureDisplacementOptions options;
|
||||||
|
if (!texture_displacement_layers_from_json(json->second, layers, options)) {
|
||||||
|
add_error("Malformed texture displacement data: " + json_path);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
// The archive is the only source of a layer's pixels. `path` comes from the project file, so loading
|
||||||
|
// the project must never read the file it names: that would let whoever made the project pick any
|
||||||
|
// local (or, on Windows, network) file to read, and the next save would embed it in the archive.
|
||||||
|
// `path` stays a label of where the texture came from; a layer the archive carries no image for
|
||||||
|
// loads without one, its settings intact, until the user picks a texture again.
|
||||||
|
for (TextureDisplacementLayer &layer : layers) {
|
||||||
|
if (layer.path_in_3mf.empty())
|
||||||
|
continue;
|
||||||
|
const auto image = m_texture_displacement_files.find(layer.path_in_3mf);
|
||||||
|
if (image == m_texture_displacement_files.end()) {
|
||||||
|
add_error("Missing texture displacement image: " + layer.path_in_3mf);
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
layer.image_data = std::make_shared<std::vector<unsigned char>>(image->second.begin(), image->second.end());
|
||||||
|
}
|
||||||
|
volume.texture_displacement_layers = std::move(layers);
|
||||||
|
volume.texture_displacement_options = options;
|
||||||
|
}
|
||||||
|
|
||||||
void _BBS_3MF_Importer::_extract_embossed_svg_shape_file(const std::string &filename, mz_zip_archive &archive, const mz_zip_archive_file_stat &stat){
|
void _BBS_3MF_Importer::_extract_embossed_svg_shape_file(const std::string &filename, mz_zip_archive &archive, const mz_zip_archive_file_stat &stat){
|
||||||
assert(m_path_to_emboss_shape_files.find(filename) == m_path_to_emboss_shape_files.end());
|
assert(m_path_to_emboss_shape_files.find(filename) == m_path_to_emboss_shape_files.end());
|
||||||
auto file = std::make_unique<std::string>(stat.m_uncomp_size, '\0');
|
auto file = std::make_unique<std::string>(stat.m_uncomp_size, '\0');
|
||||||
@@ -3966,6 +4030,12 @@ void PlateData::parse_filament_info(GCodeProcessorResult *result)
|
|||||||
m_curr_object->geometry.custom_seam.push_back(bbs_get_attribute_value_string(attributes, num_attributes, CUSTOM_SEAM_ATTR));
|
m_curr_object->geometry.custom_seam.push_back(bbs_get_attribute_value_string(attributes, num_attributes, CUSTOM_SEAM_ATTR));
|
||||||
m_curr_object->geometry.mmu_segmentation.push_back(bbs_get_attribute_value_string(attributes, num_attributes, MMU_SEGMENTATION_ATTR));
|
m_curr_object->geometry.mmu_segmentation.push_back(bbs_get_attribute_value_string(attributes, num_attributes, MMU_SEGMENTATION_ATTR));
|
||||||
m_curr_object->geometry.fuzzy_skin.push_back(bbs_get_attribute_value_string(attributes, num_attributes, CUSTOM_FUZZY_SKIN_ATTR));
|
m_curr_object->geometry.fuzzy_skin.push_back(bbs_get_attribute_value_string(attributes, num_attributes, CUSTOM_FUZZY_SKIN_ATTR));
|
||||||
|
for (int slot = 0; slot < int(TEXTURE_DISPLACEMENT_MAX_LAYERS); ++slot)
|
||||||
|
if (const char *paint = bbs_get_attribute_value_charptr(attributes, num_attributes, TEXTURE_DISPLACEMENT_ATTRS[slot])) {
|
||||||
|
std::vector<std::string> &mask = m_curr_object->geometry.texture_displacement[slot];
|
||||||
|
mask.resize(m_curr_object->geometry.triangles.size());
|
||||||
|
mask.back() = paint;
|
||||||
|
}
|
||||||
// BBS
|
// BBS
|
||||||
m_curr_object->geometry.face_properties.push_back(bbs_get_attribute_value_string(attributes, num_attributes, FACE_PROPERTY_ATTR));
|
m_curr_object->geometry.face_properties.push_back(bbs_get_attribute_value_string(attributes, num_attributes, FACE_PROPERTY_ATTR));
|
||||||
}
|
}
|
||||||
@@ -5317,6 +5387,18 @@ void PlateData::parse_filament_info(GCodeProcessorResult *result)
|
|||||||
volume->mmu_segmentation_facets.touch();
|
volume->mmu_segmentation_facets.touch();
|
||||||
volume->fuzzy_skin_facets.shrink_to_fit();
|
volume->fuzzy_skin_facets.shrink_to_fit();
|
||||||
volume->fuzzy_skin_facets.touch();
|
volume->fuzzy_skin_facets.touch();
|
||||||
|
for (int slot = 0; slot < int(TEXTURE_DISPLACEMENT_MAX_LAYERS); ++slot) {
|
||||||
|
const std::vector<std::string> &mask = sub_object->geometry.texture_displacement[slot];
|
||||||
|
if (mask.empty())
|
||||||
|
continue; // no triangle painted on this slot
|
||||||
|
FacetsAnnotation &facets = volume->texture_displacement_facet(slot);
|
||||||
|
facets.reserve(triangles_count);
|
||||||
|
for (size_t i = 0; i < triangles_count && i < mask.size(); ++i)
|
||||||
|
if (!mask[i].empty())
|
||||||
|
facets.set_triangle_from_string(i, mask[i]);
|
||||||
|
facets.shrink_to_fit();
|
||||||
|
facets.touch();
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
volume->set_type(volume_data->part_type);
|
volume->set_type(volume_data->part_type);
|
||||||
@@ -5332,6 +5414,8 @@ void PlateData::parse_filament_info(GCodeProcessorResult *result)
|
|||||||
for (const Metadata& metadata : volume_data->metadata) {
|
for (const Metadata& metadata : volume_data->metadata) {
|
||||||
if (metadata.key == NAME_KEY)
|
if (metadata.key == NAME_KEY)
|
||||||
volume->name = metadata.value;
|
volume->name = metadata.value;
|
||||||
|
else if (metadata.key == TEXTURE_DISPLACEMENT_KEY)
|
||||||
|
_apply_texture_displacement(*volume, metadata.value);
|
||||||
//else if ((metadata.key == MODIFIER_KEY) && (metadata.value == "1"))
|
//else if ((metadata.key == MODIFIER_KEY) && (metadata.value == "1"))
|
||||||
// volume->set_type(ModelVolumeType::PARAMETER_MODIFIER);
|
// volume->set_type(ModelVolumeType::PARAMETER_MODIFIER);
|
||||||
//for old format
|
//for old format
|
||||||
@@ -5496,12 +5580,28 @@ void PlateData::parse_filament_info(GCodeProcessorResult *result)
|
|||||||
volume->seam_facets.shrink_to_fit();
|
volume->seam_facets.shrink_to_fit();
|
||||||
volume->mmu_segmentation_facets.shrink_to_fit();
|
volume->mmu_segmentation_facets.shrink_to_fit();
|
||||||
|
|
||||||
|
for (int slot = 0; slot < int(TEXTURE_DISPLACEMENT_MAX_LAYERS); ++slot) {
|
||||||
|
const std::vector<std::string> &mask = geometry.texture_displacement[slot];
|
||||||
|
if (mask.empty())
|
||||||
|
continue; // written by a build without the feature
|
||||||
|
FacetsAnnotation &facets = volume->texture_displacement_facet(slot);
|
||||||
|
facets.reserve(triangles_count);
|
||||||
|
for (size_t i = 0; i < triangles_count; ++i) {
|
||||||
|
const size_t index = volume_data.first_triangle_id + i;
|
||||||
|
if (index < mask.size() && !mask[index].empty())
|
||||||
|
facets.set_triangle_from_string(i, mask[index]);
|
||||||
|
}
|
||||||
|
facets.shrink_to_fit();
|
||||||
|
facets.touch();
|
||||||
|
}
|
||||||
volume->set_type(volume_data.part_type);
|
volume->set_type(volume_data.part_type);
|
||||||
|
|
||||||
// apply the remaining volume's metadata
|
// apply the remaining volume's metadata
|
||||||
for (const Metadata& metadata : volume_data.metadata) {
|
for (const Metadata& metadata : volume_data.metadata) {
|
||||||
if (metadata.key == NAME_KEY)
|
if (metadata.key == NAME_KEY)
|
||||||
volume->name = metadata.value;
|
volume->name = metadata.value;
|
||||||
|
else if (metadata.key == TEXTURE_DISPLACEMENT_KEY)
|
||||||
|
_apply_texture_displacement(*volume, metadata.value);
|
||||||
//else if ((metadata.key == MODIFIER_KEY) && (metadata.value == "1"))
|
//else if ((metadata.key == MODIFIER_KEY) && (metadata.value == "1"))
|
||||||
// volume->set_type(ModelVolumeType::PARAMETER_MODIFIER);
|
// volume->set_type(ModelVolumeType::PARAMETER_MODIFIER);
|
||||||
//for old format
|
//for old format
|
||||||
@@ -5805,6 +5905,12 @@ void PlateData::parse_filament_info(GCodeProcessorResult *result)
|
|||||||
current_object->geometry.custom_seam.push_back(bbs_get_attribute_value_string(attributes, num_attributes, CUSTOM_SEAM_ATTR));
|
current_object->geometry.custom_seam.push_back(bbs_get_attribute_value_string(attributes, num_attributes, CUSTOM_SEAM_ATTR));
|
||||||
current_object->geometry.mmu_segmentation.push_back(bbs_get_attribute_value_string(attributes, num_attributes, MMU_SEGMENTATION_ATTR));
|
current_object->geometry.mmu_segmentation.push_back(bbs_get_attribute_value_string(attributes, num_attributes, MMU_SEGMENTATION_ATTR));
|
||||||
current_object->geometry.fuzzy_skin.push_back(bbs_get_attribute_value_string(attributes, num_attributes, CUSTOM_FUZZY_SKIN_ATTR));
|
current_object->geometry.fuzzy_skin.push_back(bbs_get_attribute_value_string(attributes, num_attributes, CUSTOM_FUZZY_SKIN_ATTR));
|
||||||
|
for (int slot = 0; slot < int(TEXTURE_DISPLACEMENT_MAX_LAYERS); ++slot)
|
||||||
|
if (const char *paint = bbs_get_attribute_value_charptr(attributes, num_attributes, TEXTURE_DISPLACEMENT_ATTRS[slot])) {
|
||||||
|
std::vector<std::string> &mask = current_object->geometry.texture_displacement[slot];
|
||||||
|
mask.resize(current_object->geometry.triangles.size());
|
||||||
|
mask.back() = paint;
|
||||||
|
}
|
||||||
// BBS
|
// BBS
|
||||||
current_object->geometry.face_properties.push_back(bbs_get_attribute_value_string(attributes, num_attributes, FACE_PROPERTY_ATTR));
|
current_object->geometry.face_properties.push_back(bbs_get_attribute_value_string(attributes, num_attributes, FACE_PROPERTY_ATTR));
|
||||||
}
|
}
|
||||||
@@ -6808,6 +6914,9 @@ void PlateData::parse_filament_info(GCodeProcessorResult *result)
|
|||||||
stream << " <Default Extension=\"rels\" ContentType=\"application/vnd.openxmlformats-package.relationships+xml\"/>\n";
|
stream << " <Default Extension=\"rels\" ContentType=\"application/vnd.openxmlformats-package.relationships+xml\"/>\n";
|
||||||
stream << " <Default Extension=\"model\" ContentType=\"application/vnd.ms-package.3dmanufacturing-3dmodel+xml\"/>\n";
|
stream << " <Default Extension=\"model\" ContentType=\"application/vnd.ms-package.3dmanufacturing-3dmodel+xml\"/>\n";
|
||||||
stream << " <Default Extension=\"png\" ContentType=\"image/png\"/>\n";
|
stream << " <Default Extension=\"png\" ContentType=\"image/png\"/>\n";
|
||||||
|
stream << " <Default Extension=\"jpg\" ContentType=\"image/jpeg\"/>\n";
|
||||||
|
stream << " <Default Extension=\"jpeg\" ContentType=\"image/jpeg\"/>\n";
|
||||||
|
stream << " <Default Extension=\"json\" ContentType=\"application/json\"/>\n";
|
||||||
stream << " <Default Extension=\"gcode\" ContentType=\"text/x.gcode\"/>\n";
|
stream << " <Default Extension=\"gcode\" ContentType=\"text/x.gcode\"/>\n";
|
||||||
stream << "</Types>";
|
stream << "</Types>";
|
||||||
|
|
||||||
@@ -7232,10 +7341,14 @@ void PlateData::parse_filament_info(GCodeProcessorResult *result)
|
|||||||
if (iter != m_shared_meshes.end())
|
if (iter != m_shared_meshes.end())
|
||||||
{
|
{
|
||||||
const ModelVolume* shared_volume = iter->second.second;
|
const ModelVolume* shared_volume = iter->second.second;
|
||||||
|
bool same_texture_paint = true;
|
||||||
|
for (int slot = 0; slot < int(TEXTURE_DISPLACEMENT_MAX_LAYERS) && same_texture_paint; ++slot)
|
||||||
|
same_texture_paint = shared_volume->texture_displacement_facet(slot).equals(volume->texture_displacement_facet(slot));
|
||||||
if ((shared_volume->supported_facets.equals(volume->supported_facets))
|
if ((shared_volume->supported_facets.equals(volume->supported_facets))
|
||||||
&& (shared_volume->seam_facets.equals(volume->seam_facets))
|
&& (shared_volume->seam_facets.equals(volume->seam_facets))
|
||||||
&& (shared_volume->mmu_segmentation_facets.equals(volume->mmu_segmentation_facets))
|
&& (shared_volume->mmu_segmentation_facets.equals(volume->mmu_segmentation_facets))
|
||||||
&& (shared_volume->fuzzy_skin_facets.equals(volume->fuzzy_skin_facets)))
|
&& (shared_volume->fuzzy_skin_facets.equals(volume->fuzzy_skin_facets))
|
||||||
|
&& same_texture_paint)
|
||||||
{
|
{
|
||||||
auto data = iter->second.first;
|
auto data = iter->second.first;
|
||||||
const_cast<_BBS_3MF_Exporter *>(this)->m_volume_paths.insert({volume, {data->sub_path, data->volumes_objectID.find(iter->second.second)->second}});
|
const_cast<_BBS_3MF_Exporter *>(this)->m_volume_paths.insert({volume, {data->sub_path, data->volumes_objectID.find(iter->second.second)->second}});
|
||||||
@@ -7651,6 +7764,20 @@ void PlateData::parse_filament_info(GCodeProcessorResult *result)
|
|||||||
output_buffer += "\"";
|
output_buffer += "\"";
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// One attribute per texture displacement layer slot. Older readers ignore attributes they do
|
||||||
|
// not know, so a project written here still opens in a build without the feature - it just
|
||||||
|
// loses the paint, which is also all it could have done with it.
|
||||||
|
for (int slot = 0; slot < TEXTURE_DISPLACEMENT_MAX_LAYERS; ++slot) {
|
||||||
|
const std::string texture_paint = volume->texture_displacement_facet(slot).get_triangle_as_string(i);
|
||||||
|
if (texture_paint.empty())
|
||||||
|
continue;
|
||||||
|
output_buffer += " ";
|
||||||
|
output_buffer += TEXTURE_DISPLACEMENT_ATTRS[slot];
|
||||||
|
output_buffer += "=\"";
|
||||||
|
output_buffer += texture_paint;
|
||||||
|
output_buffer += "\"";
|
||||||
|
}
|
||||||
|
|
||||||
// BBS
|
// BBS
|
||||||
if (i < its.properties.size()) {
|
if (i < its.properties.size()) {
|
||||||
std::string prop_str = its.properties[i].to_string();
|
std::string prop_str = its.properties[i].to_string();
|
||||||
@@ -8100,7 +8227,42 @@ void PlateData::parse_filament_info(GCodeProcessorResult *result)
|
|||||||
return file_path;
|
return file_path;
|
||||||
}
|
}
|
||||||
|
|
||||||
bool _BBS_3MF_Exporter::_add_model_config_file_to_archive(mz_zip_archive& archive, const Model& model, PlateDataPtrs& plate_data_list, const ObjectToObjectDataMap &objects_data, const DynamicPrintConfig& config, int export_plate_idx, bool save_gcode, bool use_loaded_id)
|
// Writes a volume's texture displacement stack into the archive and points the volume's metadata at it.
|
||||||
|
// The layer settings go in as JSON and each layer's texture as the image file it was loaded from, both
|
||||||
|
// referenced by path - the same split EmbossShape makes for its SVG. The image deliberately stays out of
|
||||||
|
// the XML: it is binary and routinely megabytes, and base64 in an attribute would bloat the one file
|
||||||
|
// every reader has to parse just to list the objects.
|
||||||
|
static void add_texture_displacement(std::stringstream &stream, const ModelVolume &volume, mz_zip_archive &archive,
|
||||||
|
const std::string &id)
|
||||||
|
{
|
||||||
|
if (volume.texture_displacement_layers.empty())
|
||||||
|
return;
|
||||||
|
|
||||||
|
// A copy, because path_in_3mf is only meaningful inside the archive being written and the volume
|
||||||
|
// being exported is const (and may be saved again, elsewhere, with different paths).
|
||||||
|
std::vector<TextureDisplacementLayer> layers = volume.texture_displacement_layers;
|
||||||
|
for (TextureDisplacementLayer &layer : layers) {
|
||||||
|
layer.path_in_3mf.clear();
|
||||||
|
if (!layer.image_data || layer.image_data->empty())
|
||||||
|
continue;
|
||||||
|
// Always .png: the importer converts whatever the user picked (jpg, bmp, ...) to an 8-bit
|
||||||
|
// greyscale PNG, so image_data is PNG whatever layer.path happens to be named.
|
||||||
|
const std::string path = std::string(TEXTURE_DISPLACEMENT_DIR) + id + "_" + std::to_string(layer.slot) + ".png";
|
||||||
|
// No deflate: a PNG is already compressed, so a second pass only costs time.
|
||||||
|
if (mz_zip_writer_add_mem(&archive, path.c_str(), layer.image_data->data(), layer.image_data->size(),
|
||||||
|
MZ_NO_COMPRESSION))
|
||||||
|
layer.path_in_3mf = path;
|
||||||
|
}
|
||||||
|
|
||||||
|
const std::string json = texture_displacement_layers_to_json(layers, volume.texture_displacement_options);
|
||||||
|
const std::string json_path = std::string(TEXTURE_DISPLACEMENT_DIR) + id + ".json";
|
||||||
|
if (!mz_zip_writer_add_mem(&archive, json_path.c_str(), json.data(), json.size(), MZ_DEFAULT_COMPRESSION))
|
||||||
|
return;
|
||||||
|
stream << " <" << METADATA_TAG << " " << KEY_ATTR << "=\"" << TEXTURE_DISPLACEMENT_KEY << "\" "
|
||||||
|
<< VALUE_ATTR << "=\"" << xml_escape(json_path) << "\"/>\n";
|
||||||
|
}
|
||||||
|
|
||||||
|
bool _BBS_3MF_Exporter::_add_model_config_file_to_archive(mz_zip_archive& archive, const Model& model, PlateDataPtrs& plate_data_list, const ObjectToObjectDataMap &objects_data, const DynamicPrintConfig& config, int export_plate_idx, bool save_gcode, bool use_loaded_id)
|
||||||
{
|
{
|
||||||
std::stringstream stream;
|
std::stringstream stream;
|
||||||
// Store mesh transformation in full precision, as the volumes are stored transformed and they need to be transformed back
|
// Store mesh transformation in full precision, as the volumes are stored transformed and they need to be transformed back
|
||||||
@@ -8211,6 +8373,8 @@ void PlateData::parse_filament_info(GCodeProcessorResult *result)
|
|||||||
if (const std::optional<EmbossShape> &es = volume->emboss_shape; es.has_value()) {
|
if (const std::optional<EmbossShape> &es = volume->emboss_shape; es.has_value()) {
|
||||||
to_xml(stream, *es, *volume, archive, m_fullpath_sources);
|
to_xml(stream, *es, *volume, archive, m_fullpath_sources);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
add_texture_displacement(stream, *volume, archive, std::to_string(volume->id().id));
|
||||||
|
|
||||||
if (const std::optional<TextConfiguration> &tc = volume->text_configuration;
|
if (const std::optional<TextConfiguration> &tc = volume->text_configuration;
|
||||||
tc.has_value())
|
tc.has_value())
|
||||||
|
|||||||
+15
-2
@@ -1033,6 +1033,15 @@ static std::vector<Vec2d> get_path_of_change_filament(const Print& print)
|
|||||||
return buf;
|
return buf;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// FanMover consumes these markers (and drops them) to avoid splitting a G1 inside custom gcode.
|
||||||
|
// Only written when FanMover runs, the same gate as its construction in GCode::process_layers.
|
||||||
|
static std::string wrap_custom_gcode_for_fan_mover(const FullPrintConfig &config, const std::string &gcode)
|
||||||
|
{
|
||||||
|
if (config.fan_speedup_time.value == 0 && config.fan_kickstart.value <= 0)
|
||||||
|
return gcode;
|
||||||
|
return ";_FAN_MOVER_SKIP_START\n" + gcode + ";_FAN_MOVER_SKIP_END\n";
|
||||||
|
}
|
||||||
|
|
||||||
std::string WipeTowerIntegration::append_tcr(GCode& gcodegen, const WipeTower::ToolChangeResult& tcr, int new_filament_id, double z) const
|
std::string WipeTowerIntegration::append_tcr(GCode& gcodegen, const WipeTower::ToolChangeResult& tcr, int new_filament_id, double z) const
|
||||||
{
|
{
|
||||||
if (new_filament_id != -1 && new_filament_id != tcr.new_tool)
|
if (new_filament_id != -1 && new_filament_id != tcr.new_tool)
|
||||||
@@ -1384,6 +1393,9 @@ static std::vector<Vec2d> get_path_of_change_filament(const Print& print)
|
|||||||
toolchange_gcode_str = gcodegen.placeholder_parser_process("change_filament_gcode", change_filament_gcode, new_filament_id, &config);
|
toolchange_gcode_str = gcodegen.placeholder_parser_process("change_filament_gcode", change_filament_gcode, new_filament_id, &config);
|
||||||
|
|
||||||
check_add_eol(toolchange_gcode_str);
|
check_add_eol(toolchange_gcode_str);
|
||||||
|
// Type1 wipe tower path (every BBL printer): bracket the same way set_extruder() does,
|
||||||
|
// so FanMover doesn't split a G1 inside this custom gcode either.
|
||||||
|
toolchange_gcode_str = wrap_custom_gcode_for_fan_mover(gcodegen.config(), toolchange_gcode_str);
|
||||||
|
|
||||||
//BBS
|
//BBS
|
||||||
{
|
{
|
||||||
@@ -4250,7 +4262,7 @@ void GCode::_do_export(Print& print, GCodeOutputStream &file, ThumbnailsGenerato
|
|||||||
config.set_key_value("nozzle_diameter_at_nozzle_id", new ConfigOptionFloats(get_nozzle_diameters_by_nozzle_id(group_result.get())));
|
config.set_key_value("nozzle_diameter_at_nozzle_id", new ConfigOptionFloats(get_nozzle_diameters_by_nozzle_id(group_result.get())));
|
||||||
config.set_key_value("nozzle_volume_types", new ConfigOptionStrings(get_nozzle_volume_types_by_nozzle_id(group_result.get())));
|
config.set_key_value("nozzle_volume_types", new ConfigOptionStrings(get_nozzle_volume_types_by_nozzle_id(group_result.get())));
|
||||||
config.set_key_value("layer_num", new ConfigOptionInt(m_layer_index));
|
config.set_key_value("layer_num", new ConfigOptionInt(m_layer_index));
|
||||||
std::string filament_start_gcode = this->placeholder_parser_process("filament_start_gcode", print.config().filament_start_gcode.values.at(initial_non_support_extruder_id), initial_non_support_extruder_id,&config);
|
std::string filament_start_gcode = this->placeholder_parser_process("filament_start_gcode", print.config().filament_start_gcode.get_at(initial_non_support_extruder_id), initial_non_support_extruder_id,&config);
|
||||||
file.writeln(filament_start_gcode);
|
file.writeln(filament_start_gcode);
|
||||||
// Mark the first filament used in print. Multi-nozzle printers (H2C) get ";VT%d H%d" where
|
// Mark the first filament used in print. Multi-nozzle printers (H2C) get ";VT%d H%d" where
|
||||||
// H = dynamic ? nozzle_id : -1; existing single-nozzle printers keep the bare ";VT%d" so their
|
// H = dynamic ? nozzle_id : -1; existing single-nozzle printers keep the bare ";VT%d" so their
|
||||||
@@ -10895,7 +10907,8 @@ std::string GCode::set_extruder(unsigned int new_filament_id, double print_z, bo
|
|||||||
|
|
||||||
toolchange_gcode_parsed = placeholder_parser_process("change_filament_gcode", change_filament_gcode, new_filament_id, &dyn_config);
|
toolchange_gcode_parsed = placeholder_parser_process("change_filament_gcode", change_filament_gcode, new_filament_id, &dyn_config);
|
||||||
check_add_eol(toolchange_gcode_parsed);
|
check_add_eol(toolchange_gcode_parsed);
|
||||||
gcode += toolchange_gcode_parsed;
|
// toolchange_gcode_parsed is still read below (get_last_z_from_gcode, custom_gcode_changes_tool).
|
||||||
|
gcode += wrap_custom_gcode_for_fan_mover(m_config, toolchange_gcode_parsed);
|
||||||
|
|
||||||
//BBS
|
//BBS
|
||||||
{
|
{
|
||||||
|
|||||||
@@ -445,6 +445,11 @@ void FanMover::_process_gcode_line(GCodeReader& reader, const GCodeReader::GCode
|
|||||||
std::string extrusion_string = line.raw().substr(6, line.raw().size() - 6);
|
std::string extrusion_string = line.raw().substr(6, line.raw().size() - 6);
|
||||||
current_role = ExtrusionEntity::string_to_role(extrusion_string);
|
current_role = ExtrusionEntity::string_to_role(extrusion_string);
|
||||||
}
|
}
|
||||||
|
if (line.raw().rfind(";_FAN_MOVER_SKIP_", 0) == 0) {
|
||||||
|
// Internal markers: read here, then dropped from the output.
|
||||||
|
m_is_custom_gcode = line.raw().rfind(";_FAN_MOVER_SKIP_START", 0) == 0;
|
||||||
|
time = -1;
|
||||||
|
}
|
||||||
if (line.raw().size() > 16) {
|
if (line.raw().size() > 16) {
|
||||||
if (line.raw().rfind("; custom gcode", 0) != std::string::npos) {
|
if (line.raw().rfind("; custom gcode", 0) != std::string::npos) {
|
||||||
if (line.raw().rfind("; custom gcode end", 0) != std::string::npos)
|
if (line.raw().rfind("; custom gcode end", 0) != std::string::npos)
|
||||||
|
|||||||
@@ -2602,12 +2602,13 @@ void GCodeProcessorResult::reset() {
|
|||||||
//BBS: add mutex for protection of gcode result
|
//BBS: add mutex for protection of gcode result
|
||||||
lock();
|
lock();
|
||||||
|
|
||||||
moves.clear();
|
// moves and lines_ends grow with the print: free them, as no reset result reuses the capacity.
|
||||||
|
clear_and_shrink(moves);
|
||||||
plate_mass = {};
|
plate_mass = {};
|
||||||
object_masses.clear();
|
object_masses.clear();
|
||||||
body_masses.clear();
|
body_masses.clear();
|
||||||
support_masses.clear();
|
support_masses.clear();
|
||||||
lines_ends.clear();
|
clear_and_shrink(lines_ends);
|
||||||
printable_area = Pointfs();
|
printable_area = Pointfs();
|
||||||
//BBS: add bed exclude area
|
//BBS: add bed exclude area
|
||||||
bed_exclude_area = Pointfs();
|
bed_exclude_area = Pointfs();
|
||||||
@@ -3598,6 +3599,10 @@ void GCodeProcessor::apply_config(const DynamicPrintConfig& config)
|
|||||||
if (has_scarf_joint_seam != nullptr)
|
if (has_scarf_joint_seam != nullptr)
|
||||||
m_detect_layer_based_on_tag = m_detect_layer_based_on_tag || has_scarf_joint_seam->value;
|
m_detect_layer_based_on_tag = m_detect_layer_based_on_tag || has_scarf_joint_seam->value;
|
||||||
|
|
||||||
|
const ConfigOptionBool* manual_filament_change = config.option<ConfigOptionBool>("manual_filament_change");
|
||||||
|
if (manual_filament_change != nullptr)
|
||||||
|
m_manual_filament_change = manual_filament_change->value;
|
||||||
|
|
||||||
const ConfigOptionEnumGeneric *bed_type = config.option<ConfigOptionEnumGeneric>("curr_bed_type");
|
const ConfigOptionEnumGeneric *bed_type = config.option<ConfigOptionEnumGeneric>("curr_bed_type");
|
||||||
if (bed_type != nullptr)
|
if (bed_type != nullptr)
|
||||||
m_result.bed_type = (BedType)bed_type->value;
|
m_result.bed_type = (BedType)bed_type->value;
|
||||||
|
|||||||
@@ -1228,7 +1228,7 @@ inline constexpr float DEFAULT_FILAMENT_DENSITY = 1.245f;
|
|||||||
// m_result.nozzle_group_result, which is handed over only after the stream for the
|
// m_result.nozzle_group_result, which is handed over only after the stream for the
|
||||||
// pre-heat injector's second pass and gates the richer change-time model.
|
// pre-heat injector's second pass and gates the richer change-time model.
|
||||||
std::shared_ptr<MultiNozzleUtils::NozzleGroupResultBase> m_nozzle_group_result;
|
std::shared_ptr<MultiNozzleUtils::NozzleGroupResultBase> m_nozzle_group_result;
|
||||||
bool m_manual_filament_change;
|
bool m_manual_filament_change{ false };
|
||||||
|
|
||||||
//BBS: x, y offset for gcode generated
|
//BBS: x, y offset for gcode generated
|
||||||
double m_x_offset{ 0 };
|
double m_x_offset{ 0 };
|
||||||
|
|||||||
@@ -1,349 +0,0 @@
|
|||||||
#include "JumpPointSearch.hpp"
|
|
||||||
#include "BoundingBox.hpp"
|
|
||||||
#include "ExPolygon.hpp"
|
|
||||||
#include "Point.hpp"
|
|
||||||
#include "libslic3r/AStar.hpp"
|
|
||||||
#include "libslic3r/KDTreeIndirect.hpp"
|
|
||||||
#include "libslic3r/Polygon.hpp"
|
|
||||||
#include "libslic3r/Polyline.hpp"
|
|
||||||
#include "libslic3r/libslic3r.h"
|
|
||||||
#include <algorithm>
|
|
||||||
#include <cmath>
|
|
||||||
#include <cstddef>
|
|
||||||
#include <cstdint>
|
|
||||||
#include <cstdlib>
|
|
||||||
#include <iterator>
|
|
||||||
#include <limits>
|
|
||||||
#include <optional>
|
|
||||||
#include <string>
|
|
||||||
#include <unordered_map>
|
|
||||||
#include <vector>
|
|
||||||
|
|
||||||
#include <oneapi/tbb/scalable_allocator.h>
|
|
||||||
|
|
||||||
//#define DEBUG_FILES
|
|
||||||
#ifdef DEBUG_FILES
|
|
||||||
#include "libslic3r/SVG.hpp"
|
|
||||||
#endif
|
|
||||||
|
|
||||||
namespace Slic3r {
|
|
||||||
|
|
||||||
// execute fn for each pixel on the line. If fn returns false, terminate the iteration
|
|
||||||
template<typename PointFn> void dda(coord_t x0, coord_t y0, coord_t x1, coord_t y1, const PointFn &fn)
|
|
||||||
{
|
|
||||||
coord_t dx = abs(x1 - x0);
|
|
||||||
coord_t dy = abs(y1 - y0);
|
|
||||||
coord_t x = x0;
|
|
||||||
coord_t y = y0;
|
|
||||||
coord_t n = 1 + dx + dy;
|
|
||||||
coord_t x_inc = (x1 > x0) ? 1 : -1;
|
|
||||||
coord_t y_inc = (y1 > y0) ? 1 : -1;
|
|
||||||
coord_t error = dx - dy;
|
|
||||||
dx *= 2;
|
|
||||||
dy *= 2;
|
|
||||||
|
|
||||||
for (; n > 0; --n) {
|
|
||||||
if (!fn(x, y)) return;
|
|
||||||
|
|
||||||
if (error > 0) {
|
|
||||||
x += x_inc;
|
|
||||||
error -= dy;
|
|
||||||
} else {
|
|
||||||
y += y_inc;
|
|
||||||
error += dx;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// will draw the line twice, second time with and offset of 1 in the direction of normal
|
|
||||||
// may call the fn on the same coordiantes multiple times!
|
|
||||||
template<typename PointFn> void double_dda_with_offset(coord_t x0, coord_t y0, coord_t x1, coord_t y1, const PointFn &fn)
|
|
||||||
{
|
|
||||||
Vec2d normal = Point{y1 - y0, x1 - x0}.cast<double>().normalized();
|
|
||||||
normal.x() = ceil(normal.x());
|
|
||||||
normal.y() = ceil(normal.y());
|
|
||||||
Point start_offset = Point(x0, y0) + (normal).cast<coord_t>();
|
|
||||||
Point end_offset = Point(x1, y1) + (normal).cast<coord_t>();
|
|
||||||
|
|
||||||
dda(x0, y0, x1, y1, fn);
|
|
||||||
dda(start_offset.x(), start_offset.y(), end_offset.x(), end_offset.y(), fn);
|
|
||||||
}
|
|
||||||
|
|
||||||
template<typename CellPositionType, typename CellQueryFn> class JPSTracer
|
|
||||||
{
|
|
||||||
public:
|
|
||||||
// Use incoming_dir [0,0] for starting points, so that all directions are checked from that point
|
|
||||||
struct Node
|
|
||||||
{
|
|
||||||
CellPositionType position;
|
|
||||||
CellPositionType incoming_dir;
|
|
||||||
};
|
|
||||||
|
|
||||||
JPSTracer(CellPositionType target, CellQueryFn is_passable) : target(target), is_passable(is_passable) {}
|
|
||||||
|
|
||||||
private:
|
|
||||||
CellPositionType target;
|
|
||||||
CellQueryFn is_passable; // should return boolean whether the cell is passable or not
|
|
||||||
|
|
||||||
CellPositionType find_jump_point(CellPositionType start, CellPositionType forward_dir) const
|
|
||||||
{
|
|
||||||
CellPositionType next = start + forward_dir;
|
|
||||||
while (next != target && is_passable(next) && !(is_jump_point(next, forward_dir))) { next = next + forward_dir; }
|
|
||||||
|
|
||||||
if (is_passable(next)) {
|
|
||||||
return next;
|
|
||||||
} else {
|
|
||||||
return start;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
bool is_jump_point(CellPositionType pos, CellPositionType forward_dir) const
|
|
||||||
{
|
|
||||||
if (abs(forward_dir.x()) + abs(forward_dir.y()) == 2) {
|
|
||||||
// diagonal
|
|
||||||
CellPositionType horizontal_check_dir = CellPositionType{forward_dir.x(), 0};
|
|
||||||
CellPositionType vertical_check_dir = CellPositionType{0, forward_dir.y()};
|
|
||||||
|
|
||||||
if (!is_passable(pos - horizontal_check_dir) && is_passable(pos + forward_dir - 2 * horizontal_check_dir)) { return true; }
|
|
||||||
|
|
||||||
if (!is_passable(pos - vertical_check_dir) && is_passable(pos + forward_dir - 2 * vertical_check_dir)) { return true; }
|
|
||||||
|
|
||||||
if (find_jump_point(pos, horizontal_check_dir) != pos) { return true; }
|
|
||||||
|
|
||||||
if (find_jump_point(pos, vertical_check_dir) != pos) { return true; }
|
|
||||||
|
|
||||||
return false;
|
|
||||||
} else { // horizontal or vertical
|
|
||||||
CellPositionType side_dir = CellPositionType(forward_dir.y(), forward_dir.x());
|
|
||||||
|
|
||||||
if (!is_passable(pos + side_dir) && is_passable(pos + forward_dir + side_dir)) { return true; }
|
|
||||||
|
|
||||||
if (!is_passable(pos - side_dir) && is_passable(pos + forward_dir - side_dir)) { return true; }
|
|
||||||
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
public:
|
|
||||||
template<class Fn> void foreach_reachable(const Node &from, Fn &&fn) const
|
|
||||||
{
|
|
||||||
const CellPositionType & pos = from.position;
|
|
||||||
const CellPositionType & forward_dir = from.incoming_dir;
|
|
||||||
std::vector<CellPositionType> dirs_to_check{};
|
|
||||||
|
|
||||||
if (abs(forward_dir.x()) + abs(forward_dir.y()) == 0) { // special case for starting point
|
|
||||||
dirs_to_check = all_directions;
|
|
||||||
} else if (abs(forward_dir.x()) + abs(forward_dir.y()) == 2) {
|
|
||||||
// diagonal
|
|
||||||
CellPositionType horizontal_check_dir = CellPositionType{forward_dir.x(), 0};
|
|
||||||
CellPositionType vertical_check_dir = CellPositionType{0, forward_dir.y()};
|
|
||||||
|
|
||||||
if (!is_passable(pos - horizontal_check_dir) && is_passable(pos + forward_dir - 2 * horizontal_check_dir)) {
|
|
||||||
dirs_to_check.push_back(forward_dir - 2 * horizontal_check_dir);
|
|
||||||
}
|
|
||||||
|
|
||||||
if (!is_passable(pos - vertical_check_dir) && is_passable(pos + forward_dir - 2 * vertical_check_dir)) {
|
|
||||||
dirs_to_check.push_back(forward_dir - 2 * vertical_check_dir);
|
|
||||||
}
|
|
||||||
|
|
||||||
dirs_to_check.push_back(horizontal_check_dir);
|
|
||||||
dirs_to_check.push_back(vertical_check_dir);
|
|
||||||
dirs_to_check.push_back(forward_dir);
|
|
||||||
|
|
||||||
} else { // horizontal or vertical
|
|
||||||
CellPositionType side_dir = CellPositionType(forward_dir.y(), forward_dir.x());
|
|
||||||
|
|
||||||
if (!is_passable(pos + side_dir) && is_passable(pos + forward_dir + side_dir)) { dirs_to_check.push_back(forward_dir + side_dir); }
|
|
||||||
|
|
||||||
if (!is_passable(pos - side_dir) && is_passable(pos + forward_dir - side_dir)) { dirs_to_check.push_back(forward_dir - side_dir); }
|
|
||||||
dirs_to_check.push_back(forward_dir);
|
|
||||||
}
|
|
||||||
|
|
||||||
for (const CellPositionType &dir : dirs_to_check) {
|
|
||||||
CellPositionType jp = find_jump_point(pos, dir);
|
|
||||||
if (jp != pos) fn(Node{jp, dir});
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
float distance(Node a, Node b) const { return (a.position - b.position).template cast<double>().norm(); }
|
|
||||||
|
|
||||||
float goal_heuristic(Node n) const { return n.position == target ? -1.f : (target - n.position).template cast<double>().norm(); }
|
|
||||||
|
|
||||||
size_t unique_id(Node n) const { return (static_cast<size_t>(uint16_t(n.position.x())) << 16) + static_cast<size_t>(uint16_t(n.position.y())); }
|
|
||||||
|
|
||||||
const std::vector<CellPositionType> all_directions{{1, 0}, {1, 1}, {0, 1}, {-1, 1}, {-1, 0}, {-1, -1}, {0, -1}, {1, -1}};
|
|
||||||
};
|
|
||||||
|
|
||||||
void JPSPathFinder::clear()
|
|
||||||
{
|
|
||||||
inpassable.clear();
|
|
||||||
max_search_box.max = Pixel(std::numeric_limits<coord_t>::min(), std::numeric_limits<coord_t>::min());
|
|
||||||
max_search_box.min = Pixel(std::numeric_limits<coord_t>::max(), std::numeric_limits<coord_t>::max());
|
|
||||||
add_obstacles(bed_shape);
|
|
||||||
}
|
|
||||||
|
|
||||||
void JPSPathFinder::add_obstacles(const Lines &obstacles)
|
|
||||||
{
|
|
||||||
auto store_obstacle = [&](coord_t x, coord_t y) {
|
|
||||||
max_search_box.max.x() = std::max(max_search_box.max.x(), x);
|
|
||||||
max_search_box.max.y() = std::max(max_search_box.max.y(), y);
|
|
||||||
max_search_box.min.x() = std::min(max_search_box.min.x(), x);
|
|
||||||
max_search_box.min.y() = std::min(max_search_box.min.y(), y);
|
|
||||||
inpassable.insert(Pixel{x, y});
|
|
||||||
return true;
|
|
||||||
};
|
|
||||||
|
|
||||||
for (const Line &l : obstacles) {
|
|
||||||
Pixel start = pixelize(l.a);
|
|
||||||
Pixel end = pixelize(l.b);
|
|
||||||
double_dda_with_offset(start.x(), start.y(), end.x(), end.y(), store_obstacle);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
Polyline JPSPathFinder::find_path(const Point &p0, const Point &p1)
|
|
||||||
{
|
|
||||||
Pixel start = pixelize(p0);
|
|
||||||
Pixel end = pixelize(p1);
|
|
||||||
if (inpassable.empty() || (start - end).cast<float>().norm() < 3.0) { return Polyline{p0, p1}; }
|
|
||||||
|
|
||||||
if (inpassable.find(start) != inpassable.end()) {
|
|
||||||
dda(start.x(), start.y(), end.x(), end.y(), [&](coord_t x, coord_t y) {
|
|
||||||
if (inpassable.find(Pixel(x, y)) == inpassable.end() || start == end) { // new start not found yet, and xy passable
|
|
||||||
start = Pixel(x, y);
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
return true;
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
if (inpassable.find(end) != inpassable.end()) {
|
|
||||||
dda(end.x(), end.y(), start.x(), start.y(), [&](coord_t x, coord_t y) {
|
|
||||||
if (inpassable.find(Pixel(x, y)) == inpassable.end() || start == end) { // new start not found yet, and xy passable
|
|
||||||
end = Pixel(x, y);
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
return true;
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
BoundingBox search_box = max_search_box;
|
|
||||||
search_box.max -= Pixel(1, 1);
|
|
||||||
search_box.min += Pixel(1, 1);
|
|
||||||
|
|
||||||
BoundingBox bounding_square(Points{start, end});
|
|
||||||
bounding_square.max += Pixel(5, 5);
|
|
||||||
bounding_square.min -= Pixel(5, 5);
|
|
||||||
coord_t bounding_square_size = 2 * std::max(bounding_square.size().x(), bounding_square.size().y());
|
|
||||||
bounding_square.max.x() += (bounding_square_size - bounding_square.size().x()) / 2;
|
|
||||||
bounding_square.min.x() -= (bounding_square_size - bounding_square.size().x()) / 2;
|
|
||||||
bounding_square.max.y() += (bounding_square_size - bounding_square.size().y()) / 2;
|
|
||||||
bounding_square.min.y() -= (bounding_square_size - bounding_square.size().y()) / 2;
|
|
||||||
|
|
||||||
// Intersection - limit the search box to a square area around the start and end, to fasten the path searching
|
|
||||||
search_box.max = search_box.max.cwiseMin(bounding_square.max);
|
|
||||||
search_box.min = search_box.min.cwiseMax(bounding_square.min);
|
|
||||||
|
|
||||||
auto cell_query = [&](Pixel pixel) { return search_box.contains(pixel) && (pixel == start || pixel == end || inpassable.find(pixel) == inpassable.end()); };
|
|
||||||
|
|
||||||
JPSTracer<Pixel, decltype(cell_query)> tracer(end, cell_query);
|
|
||||||
using QNode = astar::QNode<JPSTracer<Pixel, decltype(cell_query)>>;
|
|
||||||
|
|
||||||
std::unordered_map<size_t, QNode> astar_cache{};
|
|
||||||
std::vector<Pixel, PointsAllocator<Pixel>> out_path;
|
|
||||||
std::vector<decltype(tracer)::Node> out_nodes;
|
|
||||||
|
|
||||||
if (!astar::search_route(tracer, {start, {0, 0}}, std::back_inserter(out_nodes), astar_cache)) {
|
|
||||||
// path not found - just reconstruct the best path from astar cache.
|
|
||||||
// Note that astar_cache is NOT empty - at least the starting point should always be there
|
|
||||||
auto coordiante_func = [&astar_cache](size_t idx, size_t dim) { return float(astar_cache[idx].node.position[dim]); };
|
|
||||||
std::vector<size_t> keys;
|
|
||||||
keys.reserve(astar_cache.size());
|
|
||||||
for (const auto &pair : astar_cache) { keys.push_back(pair.first); }
|
|
||||||
KDTreeIndirect<2, float, decltype(coordiante_func)> kd_tree(coordiante_func, keys);
|
|
||||||
size_t closest_qnode = find_closest_point(kd_tree, end.cast<float>());
|
|
||||||
|
|
||||||
out_path.push_back(end);
|
|
||||||
while (closest_qnode != astar::Unassigned) {
|
|
||||||
out_path.push_back(astar_cache[closest_qnode].node.position);
|
|
||||||
closest_qnode = astar_cache[closest_qnode].parent;
|
|
||||||
}
|
|
||||||
} else {
|
|
||||||
for (const auto &node : out_nodes) { out_path.push_back(node.position); }
|
|
||||||
out_path.push_back(start);
|
|
||||||
}
|
|
||||||
|
|
||||||
#ifdef DEBUG_FILES
|
|
||||||
auto scaled_points = [](const Points &ps) {
|
|
||||||
Points r;
|
|
||||||
for (const Point &p : ps) { r.push_back(Point::new_scale(p.x(), p.y())); }
|
|
||||||
return r;
|
|
||||||
};
|
|
||||||
auto scaled_point = [](const Point &p) { return Point::new_scale(p.x(), p.y()); };
|
|
||||||
::Slic3r::SVG svg(debug_out_path(("path_jps" + std::to_string(print_z) + "_" + std::to_string(rand() % 1000)).c_str()).c_str(),
|
|
||||||
BoundingBox(scaled_point(search_box.min), scaled_point(search_box.max)));
|
|
||||||
for (const auto &p : inpassable) { svg.draw(scaled_point(p), "black", scale_(0.4)); }
|
|
||||||
for (const auto &qn : astar_cache) { svg.draw(scaled_point(qn.second.node.position), "blue", scale_(0.3)); }
|
|
||||||
svg.draw(Polyline(scaled_points(out_path)), "yellow", scale_(0.25));
|
|
||||||
svg.draw(scaled_point(end), "purple", scale_(0.4));
|
|
||||||
svg.draw(scaled_point(start), "green", scale_(0.4));
|
|
||||||
#endif
|
|
||||||
|
|
||||||
std::vector<Pixel, PointsAllocator<Pixel>> tmp_path;
|
|
||||||
tmp_path.reserve(out_path.size());
|
|
||||||
// Some path found, reverse and remove points that do not change direction
|
|
||||||
std::reverse(out_path.begin(), out_path.end());
|
|
||||||
{
|
|
||||||
tmp_path.push_back(out_path.front()); // first point
|
|
||||||
for (size_t i = 1; i < out_path.size() - 1; i++) {
|
|
||||||
if ((out_path[i] - out_path[i - 1]).cast<float>().normalized() != (out_path[i + 1] - out_path[i]).cast<float>().normalized()) { tmp_path.push_back(out_path[i]); }
|
|
||||||
}
|
|
||||||
tmp_path.push_back(out_path.back()); // last_point
|
|
||||||
out_path = tmp_path;
|
|
||||||
}
|
|
||||||
|
|
||||||
#ifdef DEBUG_FILES
|
|
||||||
svg.draw(Polyline(scaled_points(out_path)), "orange", scale_(0.20));
|
|
||||||
#endif
|
|
||||||
|
|
||||||
tmp_path.clear();
|
|
||||||
// remove redundant jump points - there are points that change direction but are not needed - this inefficiency arises from the
|
|
||||||
// usage of grid search The removal alg tries to find the longest Px Px+k path without obstacles. If Px Px+k+1 is blocked, it will
|
|
||||||
// insert the Px+k point to result and continue search from Px+k
|
|
||||||
{
|
|
||||||
tmp_path.push_back(out_path.front()); // first point
|
|
||||||
size_t index_of_last_stored_point = 0;
|
|
||||||
for (size_t i = 1; i < out_path.size(); i++) {
|
|
||||||
if (i - index_of_last_stored_point < 2) continue;
|
|
||||||
bool passable = true;
|
|
||||||
auto store_obstacle = [&](coord_t x, coord_t y) {
|
|
||||||
if (Pixel(x, y) != start && Pixel(x, y) != end && inpassable.find(Pixel(x, y)) != inpassable.end()) {
|
|
||||||
passable = false;
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
return true;
|
|
||||||
};
|
|
||||||
dda(tmp_path.back().x(), tmp_path.back().y(), out_path[i].x(), out_path[i].y(), store_obstacle);
|
|
||||||
if (!passable) {
|
|
||||||
tmp_path.push_back(out_path[i - 1]);
|
|
||||||
index_of_last_stored_point = i - 1;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
tmp_path.push_back(out_path.back()); // last_point
|
|
||||||
out_path = tmp_path;
|
|
||||||
}
|
|
||||||
|
|
||||||
#ifdef DEBUG_FILES
|
|
||||||
svg.draw(Polyline(scaled_points(out_path)), "red", scale_(0.15));
|
|
||||||
svg.Close();
|
|
||||||
#endif
|
|
||||||
|
|
||||||
// before returing the path, transform it from pixels back to points.
|
|
||||||
// Also replace the first and last pixel by input points so that result path patches input params exactly.
|
|
||||||
for (Pixel &p : out_path) { p = unpixelize(p); }
|
|
||||||
out_path.front() = p0;
|
|
||||||
out_path.back() = p1;
|
|
||||||
|
|
||||||
return Polyline(out_path);
|
|
||||||
}
|
|
||||||
|
|
||||||
} // namespace Slic3r
|
|
||||||
@@ -1,39 +0,0 @@
|
|||||||
#pragma once
|
|
||||||
#include "Line.hpp"
|
|
||||||
#ifndef SRC_LIBSLIC3R_JUMPPOINTSEARCH_HPP_
|
|
||||||
#define SRC_LIBSLIC3R_JUMPPOINTSEARCH_HPP_
|
|
||||||
|
|
||||||
#include "BoundingBox.hpp"
|
|
||||||
#include "Polygon.hpp"
|
|
||||||
#include "libslic3r/Layer.hpp"
|
|
||||||
#include "libslic3r/Point.hpp"
|
|
||||||
#include "libslic3r/Polyline.hpp"
|
|
||||||
#include "libslic3r/libslic3r.h"
|
|
||||||
#include <unordered_map>
|
|
||||||
#include <unordered_set>
|
|
||||||
|
|
||||||
namespace Slic3r {
|
|
||||||
|
|
||||||
class JPSPathFinder
|
|
||||||
{
|
|
||||||
using Pixel = Point;
|
|
||||||
std::unordered_set<Pixel, PointHash> inpassable;
|
|
||||||
coordf_t print_z;
|
|
||||||
BoundingBox max_search_box;
|
|
||||||
Lines bed_shape;
|
|
||||||
|
|
||||||
const coord_t resolution = scaled(1.5);
|
|
||||||
Pixel pixelize(const Point &p) { return p / resolution; }
|
|
||||||
Point unpixelize(const Pixel &p) { return p * resolution; }
|
|
||||||
|
|
||||||
public:
|
|
||||||
JPSPathFinder() = default;
|
|
||||||
void init_bed_shape(const Points &bed_shape) { this->bed_shape = (to_lines(Polygon{bed_shape})); };
|
|
||||||
void clear();
|
|
||||||
void add_obstacles(const Lines &obstacles);
|
|
||||||
Polyline find_path(const Point &start, const Point &end);
|
|
||||||
};
|
|
||||||
|
|
||||||
} // namespace Slic3r
|
|
||||||
|
|
||||||
#endif /* SRC_LIBSLIC3R_JUMPPOINTSEARCH_HPP_ */
|
|
||||||
@@ -29,8 +29,6 @@
|
|||||||
#include <CGAL/Polygon_mesh_processing/triangulate_hole.h>
|
#include <CGAL/Polygon_mesh_processing/triangulate_hole.h>
|
||||||
#include <CGAL/Polygon_mesh_processing/stitch_borders.h>
|
#include <CGAL/Polygon_mesh_processing/stitch_borders.h>
|
||||||
#include <CGAL/Polygon_mesh_processing/polygon_soup_to_polygon_mesh.h>
|
#include <CGAL/Polygon_mesh_processing/polygon_soup_to_polygon_mesh.h>
|
||||||
#include <CGAL/Polygon_mesh_processing/repair_degeneracies.h>
|
|
||||||
#include <CGAL/Polygon_mesh_processing/manifoldness.h>
|
|
||||||
#include <cstdint>
|
#include <cstdint>
|
||||||
#include <map>
|
#include <map>
|
||||||
#include <algorithm>
|
#include <algorithm>
|
||||||
@@ -50,7 +48,6 @@
|
|||||||
#include <CGAL/Polygon_mesh_processing/orient_polygon_soup.h>
|
#include <CGAL/Polygon_mesh_processing/orient_polygon_soup.h>
|
||||||
#include <CGAL/Polygon_mesh_processing/repair.h>
|
#include <CGAL/Polygon_mesh_processing/repair.h>
|
||||||
#include <CGAL/Polygon_mesh_processing/remesh.h>
|
#include <CGAL/Polygon_mesh_processing/remesh.h>
|
||||||
#include <CGAL/Polygon_mesh_processing/repair_polygon_soup.h>
|
|
||||||
#include <CGAL/Polygon_mesh_processing/orientation.h>
|
#include <CGAL/Polygon_mesh_processing/orientation.h>
|
||||||
// BBS: for segment
|
// BBS: for segment
|
||||||
#include <CGAL/mesh_segmentation.h>
|
#include <CGAL/mesh_segmentation.h>
|
||||||
@@ -658,91 +655,6 @@ bool empty(const CGALMesh &mesh)
|
|||||||
return mesh.m.is_empty();
|
return mesh.m.is_empty();
|
||||||
}
|
}
|
||||||
|
|
||||||
bool repair(TriangleMesh& mesh, RepairedMeshErrors* repaired_errors, std::string* error)
|
|
||||||
{
|
|
||||||
namespace PMP = CGAL::Polygon_mesh_processing;
|
|
||||||
|
|
||||||
if (mesh.empty())
|
|
||||||
return true;
|
|
||||||
|
|
||||||
try {
|
|
||||||
// 1) Convert to polygon soup
|
|
||||||
std::vector<_EpicMesh::Point> points;
|
|
||||||
std::vector<std::vector<std::size_t>> polygons;
|
|
||||||
|
|
||||||
points.reserve(mesh.its.vertices.size());
|
|
||||||
polygons.reserve(mesh.its.indices.size());
|
|
||||||
|
|
||||||
for (const auto& v : mesh.its.vertices)
|
|
||||||
points.emplace_back(v.x(), v.y(), v.z());
|
|
||||||
|
|
||||||
for (const auto& f : mesh.its.indices)
|
|
||||||
polygons.push_back({size_t(f[0]), size_t(f[1]), size_t(f[2])});
|
|
||||||
|
|
||||||
// 2) Aggressive soup cleanup
|
|
||||||
PMP::repair_polygon_soup(points, polygons);
|
|
||||||
|
|
||||||
// 3) Convert soup → mesh
|
|
||||||
_EpicMesh cgal_mesh;
|
|
||||||
PMP::polygon_soup_to_polygon_mesh(points, polygons, cgal_mesh);
|
|
||||||
|
|
||||||
// 4) Remove degenerate geometry
|
|
||||||
PMP::remove_degenerate_faces(cgal_mesh);
|
|
||||||
PMP::remove_isolated_vertices(cgal_mesh);
|
|
||||||
|
|
||||||
// 5) Fix remaining non-manifold vertices
|
|
||||||
PMP::duplicate_non_manifold_vertices(cgal_mesh);
|
|
||||||
|
|
||||||
// 6) Boolean union (keeps only outer shell)
|
|
||||||
_EpicMesh tmp;
|
|
||||||
if (PMP::corefine_and_compute_union(cgal_mesh, cgal_mesh, tmp)) {
|
|
||||||
cgal_mesh = std::move(tmp);
|
|
||||||
}
|
|
||||||
// If it fails, continue anyway with previous mesh
|
|
||||||
|
|
||||||
// 7) Fill holes
|
|
||||||
if (!CGAL::is_closed(cgal_mesh)) {
|
|
||||||
using halfedge_descriptor = boost::graph_traits<_EpicMesh>::halfedge_descriptor;
|
|
||||||
|
|
||||||
std::vector<halfedge_descriptor> borders;
|
|
||||||
CGAL::extract_boundary_cycles(cgal_mesh, std::back_inserter(borders));
|
|
||||||
|
|
||||||
for (halfedge_descriptor h : borders) {
|
|
||||||
PMP::triangulate_and_refine_hole(cgal_mesh, h);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// 8) Final validity check
|
|
||||||
if (!CGAL::is_closed(cgal_mesh)) {
|
|
||||||
if (error)
|
|
||||||
*error = "Repair failed: mesh still open after hole filling.";
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
|
|
||||||
// 9) Ensure outward orientation
|
|
||||||
if (!PMP::does_bound_a_volume(cgal_mesh))
|
|
||||||
PMP::orient_to_bound_a_volume(cgal_mesh);
|
|
||||||
|
|
||||||
// 10) Convert back
|
|
||||||
indexed_triangle_set its = cgal_to_indexed_triangle_set(cgal_mesh);
|
|
||||||
|
|
||||||
RepairedMeshErrors errs{};
|
|
||||||
errs.facets_removed = 0;
|
|
||||||
errs.edges_fixed = 0;
|
|
||||||
|
|
||||||
mesh = TriangleMesh(std::move(its), errs);
|
|
||||||
|
|
||||||
if (repaired_errors)
|
|
||||||
*repaired_errors = errs;
|
|
||||||
|
|
||||||
return true;
|
|
||||||
} catch (const std::exception& e) {
|
|
||||||
if (error)
|
|
||||||
*error = e.what();
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
CGALMeshPtr clone(const CGALMesh &m)
|
CGALMeshPtr clone(const CGALMesh &m)
|
||||||
{
|
{
|
||||||
return CGALMeshPtr{new CGALMesh{m}};
|
return CGALMeshPtr{new CGALMesh{m}};
|
||||||
|
|||||||
@@ -77,9 +77,6 @@ TriangleMesh merge(std::vector<TriangleMesh> meshes);
|
|||||||
bool does_bound_a_volume(const CGALMesh &mesh);
|
bool does_bound_a_volume(const CGALMesh &mesh);
|
||||||
bool empty(const CGALMesh &mesh);
|
bool empty(const CGALMesh &mesh);
|
||||||
|
|
||||||
// Repair a mesh using CGAL. Returns true on success. Optionally returns a summary of repairs and an error string.
|
|
||||||
bool repair(TriangleMesh &mesh, RepairedMeshErrors *repaired_errors = nullptr, std::string *error = nullptr);
|
|
||||||
|
|
||||||
// Real UV unwrap of an open mesh patch via CGAL's LSCM (Least Squares Conformal Maps) surface
|
// Real UV unwrap of an open mesh patch via CGAL's LSCM (Least Squares Conformal Maps) surface
|
||||||
// parameterization. Returns one UV coordinate per input vertex (same indexing as `mesh.vertices`),
|
// parameterization. Returns one UV coordinate per input vertex (same indexing as `mesh.vertices`),
|
||||||
// or nullopt if `mesh` isn't a single topological disk -- LSCM needs exactly one connected
|
// or nullopt if `mesh` isn't a single topological disk -- LSCM needs exactly one connected
|
||||||
|
|||||||
File diff suppressed because it is too large
Load Diff
@@ -0,0 +1,28 @@
|
|||||||
|
#pragma once
|
||||||
|
|
||||||
|
#include <cstddef>
|
||||||
|
#include <functional>
|
||||||
|
#include <string>
|
||||||
|
|
||||||
|
namespace Slic3r {
|
||||||
|
|
||||||
|
class TriangleMesh;
|
||||||
|
|
||||||
|
struct MeshRepairStats
|
||||||
|
{
|
||||||
|
std::size_t welded_vertices = 0;
|
||||||
|
std::size_t removed_triangles = 0;
|
||||||
|
std::size_t reversed_shells = 0;
|
||||||
|
std::size_t filled_holes = 0;
|
||||||
|
std::size_t removed_shells = 0;
|
||||||
|
std::size_t self_intersections = 0;
|
||||||
|
// False when the input already was closed, consistently oriented and free of self-intersections.
|
||||||
|
bool modified = false;
|
||||||
|
};
|
||||||
|
|
||||||
|
// Returns false, leaving the mesh untouched, if no solid can be built. progress gets the percentage done and may
|
||||||
|
// throw to cancel. See docs/HLSD/mesh-repair.md.
|
||||||
|
bool repair_mesh(TriangleMesh &mesh, MeshRepairStats *stats = nullptr, std::string *error = nullptr,
|
||||||
|
const std::function<void(int)> &progress = {});
|
||||||
|
|
||||||
|
} // namespace Slic3r
|
||||||
+39
-22
@@ -29,6 +29,7 @@
|
|||||||
#include "TriangleMeshSlicer.hpp"
|
#include "TriangleMeshSlicer.hpp"
|
||||||
#include "TriangleSelector.hpp"
|
#include "TriangleSelector.hpp"
|
||||||
#include "MaterialType.hpp"
|
#include "MaterialType.hpp"
|
||||||
|
#include "MeshRepair.hpp"
|
||||||
|
|
||||||
#include "Format/AMF.hpp"
|
#include "Format/AMF.hpp"
|
||||||
#include "Format/svg.hpp"
|
#include "Format/svg.hpp"
|
||||||
@@ -2946,6 +2947,18 @@ size_t ModelVolume::split(unsigned int max_extruders, bool remap_paint)
|
|||||||
if (text_configuration.has_value())
|
if (text_configuration.has_value())
|
||||||
text_configuration.reset();
|
text_configuration.reset();
|
||||||
|
|
||||||
|
// Parts without a convex hull enclose no volume; drop them here, as deleting volumes later could delete this one.
|
||||||
|
std::vector<std::unique_ptr<ModelVolume>> parts;
|
||||||
|
for (TriangleMesh &mesh : meshes)
|
||||||
|
if (!mesh.empty()) {
|
||||||
|
std::unique_ptr<ModelVolume> part(new ModelVolume(object, *this, std::move(mesh)));
|
||||||
|
if (const std::shared_ptr<const TriangleMesh> &hull = part->get_convex_hull_shared_ptr();
|
||||||
|
hull != nullptr && !hull->its.vertices.empty() && !hull->its.indices.empty())
|
||||||
|
parts.emplace_back(std::move(part));
|
||||||
|
}
|
||||||
|
if (parts.empty())
|
||||||
|
return 1;
|
||||||
|
|
||||||
std::optional<TriangleSelector::SavedPainting> saved_painting = remap_paint ? save_painting() :
|
std::optional<TriangleSelector::SavedPainting> saved_painting = remap_paint ? save_painting() :
|
||||||
std::optional<TriangleSelector::SavedPainting>{};
|
std::optional<TriangleSelector::SavedPainting>{};
|
||||||
|
|
||||||
@@ -2956,26 +2969,22 @@ size_t ModelVolume::split(unsigned int max_extruders, bool remap_paint)
|
|||||||
unsigned int extruder_counter = 0;
|
unsigned int extruder_counter = 0;
|
||||||
const Vec3d offset = this->get_offset();
|
const Vec3d offset = this->get_offset();
|
||||||
|
|
||||||
for (TriangleMesh &mesh : meshes) {
|
for (std::unique_ptr<ModelVolume> &part : parts) {
|
||||||
if (mesh.empty())
|
|
||||||
// Repair may have removed unconnected triangles, thus emptying the mesh.
|
|
||||||
continue;
|
|
||||||
|
|
||||||
if (idx == 0) {
|
if (idx == 0) {
|
||||||
this->set_mesh(std::move(mesh));
|
this->set_mesh(part->m_mesh);
|
||||||
this->calculate_convex_hull();
|
m_convex_hull = part->m_convex_hull;
|
||||||
this->invalidate_convex_hull_2d();
|
this->invalidate_convex_hull_2d();
|
||||||
// Assign a new unique ID, so that a new GLVolume will be generated.
|
// Assign a new unique ID, so that a new GLVolume will be generated.
|
||||||
this->set_new_unique_id();
|
this->set_new_unique_id();
|
||||||
// reset the source to disable reload from disk
|
|
||||||
this->source = ModelVolume::Source();
|
|
||||||
|
|
||||||
// BBS: reset facet annotations
|
// BBS: reset facet annotations
|
||||||
this->reset_extra_facets();
|
this->reset_extra_facets();
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
this->object->volumes.insert(this->object->volumes.begin() + (++ivolume), new ModelVolume(object, *this, std::move(mesh)));
|
this->object->volumes.insert(this->object->volumes.begin() + (++ivolume), part.release());
|
||||||
|
|
||||||
|
// reset the source to disable reload from disk
|
||||||
|
this->object->volumes[ivolume]->source = ModelVolume::Source();
|
||||||
this->object->volumes[ivolume]->set_offset(Vec3d::Zero());
|
this->object->volumes[ivolume]->set_offset(Vec3d::Zero());
|
||||||
this->object->volumes[ivolume]->center_geometry_after_creation();
|
this->object->volumes[ivolume]->center_geometry_after_creation();
|
||||||
this->object->volumes[ivolume]->translate(offset);
|
this->object->volumes[ivolume]->translate(offset);
|
||||||
@@ -2989,21 +2998,29 @@ size_t ModelVolume::split(unsigned int max_extruders, bool remap_paint)
|
|||||||
++ idx;
|
++ idx;
|
||||||
}
|
}
|
||||||
|
|
||||||
// discard volumes for which the convex hull was not generated or is degenerate
|
|
||||||
size_t i = 0;
|
|
||||||
while (i < this->object->volumes.size()) {
|
|
||||||
const std::shared_ptr<const TriangleMesh> &hull = this->object->volumes[i]->get_convex_hull_shared_ptr();
|
|
||||||
if (hull == nullptr || hull->its.vertices.empty() || hull->its.indices.empty()) {
|
|
||||||
this->object->delete_volume(i);
|
|
||||||
--idx;
|
|
||||||
--i;
|
|
||||||
}
|
|
||||||
++i;
|
|
||||||
}
|
|
||||||
|
|
||||||
return idx;
|
return idx;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
bool ModelVolume::repair(bool keep_painting, MeshRepairStats *stats_out, std::string *error, const std::function<void(int)> &progress)
|
||||||
|
{
|
||||||
|
TriangleMesh mesh = this->mesh();
|
||||||
|
MeshRepairStats stats;
|
||||||
|
const bool ok = repair_mesh(mesh, &stats, error, progress);
|
||||||
|
if (stats_out)
|
||||||
|
*stats_out = stats;
|
||||||
|
if (!ok || !stats.modified)
|
||||||
|
return ok;
|
||||||
|
|
||||||
|
const std::optional<TriangleSelector::SavedPainting> saved_painting = keep_painting ? save_painting() : std::nullopt;
|
||||||
|
this->set_mesh(std::move(mesh));
|
||||||
|
this->calculate_convex_hull();
|
||||||
|
this->invalidate_convex_hull_2d();
|
||||||
|
// Assign a new unique ID, so that a new GLVolume will be generated.
|
||||||
|
this->set_new_unique_id();
|
||||||
|
this->restore_painting(saved_painting);
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
void ModelVolume::translate(const Vec3d& displacement)
|
void ModelVolume::translate(const Vec3d& displacement)
|
||||||
{
|
{
|
||||||
set_offset(get_offset() + displacement);
|
set_offset(get_offset() + displacement);
|
||||||
|
|||||||
+11
-7
@@ -77,6 +77,7 @@ class Preset;
|
|||||||
class BBLProject;
|
class BBLProject;
|
||||||
|
|
||||||
class KeyStore;
|
class KeyStore;
|
||||||
|
struct MeshRepairStats;
|
||||||
|
|
||||||
namespace UndoRedo {
|
namespace UndoRedo {
|
||||||
class StackImpl;
|
class StackImpl;
|
||||||
@@ -887,13 +888,13 @@ public:
|
|||||||
// The triangular model.
|
// The triangular model.
|
||||||
const TriangleMesh& mesh() const { return *m_mesh.get(); }
|
const TriangleMesh& mesh() const { return *m_mesh.get(); }
|
||||||
std::shared_ptr<const TriangleMesh> mesh_ptr() const { return m_mesh; }
|
std::shared_ptr<const TriangleMesh> mesh_ptr() const { return m_mesh; }
|
||||||
void set_mesh(const TriangleMesh &mesh) { m_mesh = std::make_shared<const TriangleMesh>(mesh); }
|
void set_mesh(const TriangleMesh &mesh) { m_mesh = std::make_shared<const TriangleMesh>(mesh); m_is_splittable = -1; }
|
||||||
void set_mesh(TriangleMesh &&mesh) { m_mesh = std::make_shared<const TriangleMesh>(std::move(mesh)); }
|
void set_mesh(TriangleMesh &&mesh) { m_mesh = std::make_shared<const TriangleMesh>(std::move(mesh)); m_is_splittable = -1; }
|
||||||
void set_mesh(const indexed_triangle_set &mesh) { m_mesh = std::make_shared<const TriangleMesh>(mesh); }
|
void set_mesh(const indexed_triangle_set &mesh) { m_mesh = std::make_shared<const TriangleMesh>(mesh); m_is_splittable = -1; }
|
||||||
void set_mesh(indexed_triangle_set &&mesh) { m_mesh = std::make_shared<const TriangleMesh>(std::move(mesh)); }
|
void set_mesh(indexed_triangle_set &&mesh) { m_mesh = std::make_shared<const TriangleMesh>(std::move(mesh)); m_is_splittable = -1; }
|
||||||
void set_mesh(std::shared_ptr<const TriangleMesh> &mesh) { m_mesh = mesh; }
|
void set_mesh(std::shared_ptr<const TriangleMesh> &mesh) { m_mesh = mesh; m_is_splittable = -1; }
|
||||||
void set_mesh(std::unique_ptr<const TriangleMesh> &&mesh) { m_mesh = std::move(mesh); }
|
void set_mesh(std::unique_ptr<const TriangleMesh> &&mesh) { m_mesh = std::move(mesh); m_is_splittable = -1; }
|
||||||
void reset_mesh() { m_mesh = std::make_shared<const TriangleMesh>(); }
|
void reset_mesh() { m_mesh = std::make_shared<const TriangleMesh>(); m_is_splittable = -1; }
|
||||||
const std::shared_ptr<const TriangleMesh>& get_mesh_shared_ptr() const { return m_mesh; }
|
const std::shared_ptr<const TriangleMesh>& get_mesh_shared_ptr() const { return m_mesh; }
|
||||||
// Configuration parameters specific to an object model geometry or a modifier volume,
|
// Configuration parameters specific to an object model geometry or a modifier volume,
|
||||||
// overriding the global Slic3r settings and the ModelObject settings.
|
// overriding the global Slic3r settings and the ModelObject settings.
|
||||||
@@ -1043,6 +1044,9 @@ public:
|
|||||||
// Return the number of volumes created from this one.
|
// Return the number of volumes created from this one.
|
||||||
// This is useful to assign different materials to different volumes of an object.
|
// This is useful to assign different materials to different volumes of an object.
|
||||||
size_t split(unsigned int max_extruders, bool remap_paint);
|
size_t split(unsigned int max_extruders, bool remap_paint);
|
||||||
|
// Replaces the mesh by its repair_mesh() result if that changed it. False if no solid can be built.
|
||||||
|
bool repair(bool keep_painting, MeshRepairStats *stats = nullptr, std::string *error = nullptr,
|
||||||
|
const std::function<void(int)> &progress = {});
|
||||||
void translate(double x, double y, double z) { translate(Vec3d(x, y, z)); }
|
void translate(double x, double y, double z) { translate(Vec3d(x, y, z)); }
|
||||||
void translate(const Vec3d& displacement);
|
void translate(const Vec3d& displacement);
|
||||||
void scale(const Vec3d& scaling_factors);
|
void scale(const Vec3d& scaling_factors);
|
||||||
|
|||||||
@@ -2164,6 +2164,16 @@ int PresetCollection::get_differed_values_to_update(Preset& preset, std::map<std
|
|||||||
DynamicPrintConfig temp_config;
|
DynamicPrintConfig temp_config;
|
||||||
std::vector<std::string> dirty_options = preset.config.diff(parent_preset->config);
|
std::vector<std::string> dirty_options = preset.config.diff(parent_preset->config);
|
||||||
|
|
||||||
|
// Send the variant layout even when it matches the parent's, as the local save does: the loader
|
||||||
|
// sizes the per-variant values by it and would otherwise keep only the first one.
|
||||||
|
std::string extruder_id_name, extruder_variant_name;
|
||||||
|
std::set<std::string> *key_set1 = nullptr, *key_set2 = nullptr;
|
||||||
|
Preset::get_extruder_names_and_keysets(m_type, extruder_id_name, extruder_variant_name, &key_set1, &key_set2);
|
||||||
|
if (!extruder_id_name.empty())
|
||||||
|
dirty_options.emplace_back(extruder_id_name);
|
||||||
|
if (!extruder_variant_name.empty())
|
||||||
|
dirty_options.emplace_back(extruder_variant_name);
|
||||||
|
|
||||||
for (auto option: dirty_options)
|
for (auto option: dirty_options)
|
||||||
{
|
{
|
||||||
ConfigOption *opt_src = preset.config.option(option);
|
ConfigOption *opt_src = preset.config.option(option);
|
||||||
@@ -2628,15 +2638,34 @@ bool PresetCollection::load_user_preset(std::string name, std::map<std::string,
|
|||||||
new_config = default_preset.config;
|
new_config = default_preset.config;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
std::string extruder_id_name, extruder_variant_name;
|
||||||
|
std::set<std::string> *key_set1 = nullptr, *key_set2 = nullptr;
|
||||||
|
Preset::get_extruder_names_and_keysets(m_type, extruder_id_name, extruder_variant_name, &key_set1, &key_set2);
|
||||||
|
|
||||||
|
// Older uploads left out a variant layout equal to the parent's but still sent one value per
|
||||||
|
// parent variant. Read those values against the parent's layout instead of cutting them to one.
|
||||||
|
if (inherit_preset && !cloud_config.has(extruder_variant_name)) {
|
||||||
|
const auto *parent_variants = inherit_preset->config.option<ConfigOptionStrings>(extruder_variant_name);
|
||||||
|
const size_t variant_count = parent_variants ? parent_variants->size() : 0;
|
||||||
|
bool values_per_variant = false;
|
||||||
|
for (const std::string &key : cloud_config.keys()) {
|
||||||
|
const size_t stride = key_set2->count(key) ? 2 : key_set1->count(key) ? 1 : 0;
|
||||||
|
const auto *values = dynamic_cast<const ConfigOptionVectorBase *>(cloud_config.option(key));
|
||||||
|
if (stride > 0 && key != extruder_id_name && values && variant_count > 1 && values->size() == variant_count * stride) {
|
||||||
|
values_per_variant = true;
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if (values_per_variant)
|
||||||
|
for (const std::string &key : {extruder_id_name, extruder_variant_name})
|
||||||
|
if (!key.empty() && !cloud_config.has(key) && inherit_preset->config.has(key))
|
||||||
|
cloud_config.set_key_value(key, inherit_preset->config.option(key)->clone());
|
||||||
|
}
|
||||||
|
|
||||||
extend_default_config_length(cloud_config, false, {});
|
extend_default_config_length(cloud_config, false, {});
|
||||||
|
|
||||||
if (inherit_preset) {
|
if (inherit_preset)
|
||||||
std::string extruder_id_name, extruder_variant_name;
|
|
||||||
std::set<std::string> *key_set1 = nullptr, *key_set2 = nullptr;
|
|
||||||
Preset::get_extruder_names_and_keysets(m_type, extruder_id_name, extruder_variant_name, &key_set1, &key_set2);
|
|
||||||
|
|
||||||
new_config.update_diff_values_to_child_config(cloud_config, extruder_id_name, extruder_variant_name, *key_set1, *key_set2);
|
new_config.update_diff_values_to_child_config(cloud_config, extruder_id_name, extruder_variant_name, *key_set1, *key_set2);
|
||||||
}
|
|
||||||
else{
|
else{
|
||||||
new_config.apply(std::move(cloud_config));
|
new_config.apply(std::move(cloud_config));
|
||||||
extend_default_config_length(new_config, true, default_preset.config);
|
extend_default_config_length(new_config, true, default_preset.config);
|
||||||
|
|||||||
@@ -2991,6 +2991,15 @@ void PrintObject::clear_shared_object()
|
|||||||
void PrintObject::copy_layers_from_shared_object()
|
void PrintObject::copy_layers_from_shared_object()
|
||||||
{
|
{
|
||||||
if (m_shared_object) {
|
if (m_shared_object) {
|
||||||
|
// Orca: Print::process() calls this once per slice for each sharing object, after clear_shared_object() has
|
||||||
|
// emptied any earlier alias, so the vectors hold only layers this object sliced itself before it started sharing
|
||||||
|
// (or nothing). Free them here, as clear_support_layers() / clear_layers() would; those skip deletion while
|
||||||
|
// m_shared_object is set. The belt-only data they also free is always empty here, because belt printers never
|
||||||
|
// share layers.
|
||||||
|
for (SupportLayer *layer : m_support_layers)
|
||||||
|
delete layer;
|
||||||
|
for (Layer *layer : m_layers)
|
||||||
|
delete layer;
|
||||||
m_layers.clear();
|
m_layers.clear();
|
||||||
m_support_layers.clear();
|
m_support_layers.clear();
|
||||||
|
|
||||||
|
|||||||
@@ -12866,10 +12866,11 @@ CLITransformConfigDef::CLITransformConfigDef()
|
|||||||
//def->cli = "orient|o";
|
//def->cli = "orient|o";
|
||||||
def->set_default_value(new ConfigOptionInt(0));
|
def->set_default_value(new ConfigOptionInt(0));
|
||||||
|
|
||||||
/*def = this->add("repair", coBool);
|
def = this->add("repair", coBool);
|
||||||
def->label = L("Repair");
|
def->label = L("Repair");
|
||||||
def->tooltip = L("Repair the model's meshes if it is non-manifold mesh.");
|
def->tooltip = L("Repair the meshes of the models as Fix Model does: close holes and cracks, orient them outward and "
|
||||||
def->set_default_value(new ConfigOptionBool(false));*/
|
"remove self-intersections.");
|
||||||
|
def->set_default_value(new ConfigOptionBool(false));
|
||||||
|
|
||||||
def = this->add("rotate", coFloat);
|
def = this->add("rotate", coFloat);
|
||||||
def->label = L("Rotate");
|
def->label = L("Rotate");
|
||||||
@@ -13085,7 +13086,7 @@ CLIMiscConfigDef::CLIMiscConfigDef()
|
|||||||
def = this->add("allow_rotations", coBool);
|
def = this->add("allow_rotations", coBool);
|
||||||
def->label = L("Allow rotation when arranging");
|
def->label = L("Allow rotation when arranging");
|
||||||
def->tooltip = L("If enabled, Arrange will allow rotation when placing objects.");
|
def->tooltip = L("If enabled, Arrange will allow rotation when placing objects.");
|
||||||
def->set_default_value(new ConfigOptionBool(true));
|
def->set_default_value(new ConfigOptionBool(false));
|
||||||
|
|
||||||
def = this->add("align_to_y_axis", coBool);
|
def = this->add("align_to_y_axis", coBool);
|
||||||
def->label = L("Align to Y axis when arranging");
|
def->label = L("Align to Y axis when arranging");
|
||||||
|
|||||||
@@ -982,6 +982,9 @@ void PrintObject::generate_support_material(bool with_belt_brim)
|
|||||||
this->_generate_support_material();
|
this->_generate_support_material();
|
||||||
m_print->throw_if_canceled();
|
m_print->throw_if_canceled();
|
||||||
}
|
}
|
||||||
|
// Orca: the tree support collision/avoidance caches and support nodes are only used while this step runs
|
||||||
|
// (detect_overhangs() rebuilds them from scratch), so don't keep them resident until the next slice.
|
||||||
|
this->clear_tree_support_preview_cache();
|
||||||
// Belt brim rides here rather than in the brim step because its apron
|
// Belt brim rides here rather than in the brim step because its apron
|
||||||
// prologue introduces print_z values below the object's first layer, and
|
// prologue introduces print_z values below the object's first layer, and
|
||||||
// those must exist before ToolOrdering is built at psWipeTower - one step
|
// those must exist before ToolOrdering is built at psWipeTower - one step
|
||||||
|
|||||||
@@ -1532,7 +1532,7 @@ void PrintObject::slice_volumes()
|
|||||||
if (min_growth < 0.f || elfoot > 0.f) {
|
if (min_growth < 0.f || elfoot > 0.f) {
|
||||||
// Apply the negative XY compensation. (the ones that is <0)
|
// Apply the negative XY compensation. (the ones that is <0)
|
||||||
ExPolygons trimming;
|
ExPolygons trimming;
|
||||||
static const float eps = float(scale_(m_config.slice_closing_radius.value) * 1.5);
|
const float eps = float(scale_(m_config.slice_closing_radius.value) * 1.5);
|
||||||
if (elfoot > 0.f) {
|
if (elfoot > 0.f) {
|
||||||
ExPolygons expolygons_to_compensate = offset_ex(layer->merged(eps), -eps);
|
ExPolygons expolygons_to_compensate = offset_ex(layer->merged(eps), -eps);
|
||||||
lslices_elfoot_uncompensated[layer_id] = expolygons_to_compensate;
|
lslices_elfoot_uncompensated[layer_id] = expolygons_to_compensate;
|
||||||
|
|||||||
@@ -1976,37 +1976,15 @@ coordf_t TreeSupport::get_radius(const SupportNode* node)
|
|||||||
return node->radius;
|
return node->radius;
|
||||||
}
|
}
|
||||||
|
|
||||||
ExPolygons TreeSupport::get_avoidance(coordf_t radius, size_t obj_layer_nr)
|
// Orca: drop_nodes() calls these several times per node per layer, so they return a reference into the
|
||||||
|
// TreeSupportData cache. The cache only ever inserts, so its entries never move while nodes drop in parallel.
|
||||||
|
const ExPolygons& TreeSupport::get_avoidance(coordf_t radius, size_t obj_layer_nr)
|
||||||
{
|
{
|
||||||
#if USE_SUPPORT_3D
|
|
||||||
if (m_model_volumes) {
|
|
||||||
bool on_build_plate = m_object_config->support_on_build_plate_only.value;
|
|
||||||
const Polygons& avoid_polys = m_model_volumes->getAvoidance(radius, obj_layer_nr, TreeSupport3D::TreeModelVolumes::AvoidanceType::FastSafe, on_build_plate, true);
|
|
||||||
ExPolygons expolys;
|
|
||||||
for (auto& poly : avoid_polys)
|
|
||||||
expolys.emplace_back(std::move(poly));
|
|
||||||
return expolys;
|
|
||||||
}
|
|
||||||
return ExPolygons();
|
|
||||||
#else
|
|
||||||
return m_ts_data->get_avoidance(radius, obj_layer_nr);
|
return m_ts_data->get_avoidance(radius, obj_layer_nr);
|
||||||
#endif
|
|
||||||
}
|
}
|
||||||
ExPolygons TreeSupport::get_collision(coordf_t radius, size_t layer_nr)
|
const ExPolygons& TreeSupport::get_collision(coordf_t radius, size_t layer_nr)
|
||||||
{
|
{
|
||||||
#if USE_SUPPORT_3D
|
|
||||||
if (m_model_volumes) {
|
|
||||||
bool on_build_plate = m_object_config->support_on_build_plate_only.value;
|
|
||||||
const Polygons& collision_polys = m_model_volumes->getCollision(radius, layer_nr, true);
|
|
||||||
ExPolygons expolys;
|
|
||||||
for (auto& poly : collision_polys)
|
|
||||||
expolys.emplace_back(std::move(poly));
|
|
||||||
return expolys;
|
|
||||||
}
|
|
||||||
#else
|
|
||||||
return m_ts_data->get_collision(radius, layer_nr);
|
return m_ts_data->get_collision(radius, layer_nr);
|
||||||
#endif
|
|
||||||
return ExPolygons();
|
|
||||||
}
|
}
|
||||||
Polygons TreeSupport::get_collision_polys(coordf_t radius, size_t layer_nr)
|
Polygons TreeSupport::get_collision_polys(coordf_t radius, size_t layer_nr)
|
||||||
{
|
{
|
||||||
@@ -2827,7 +2805,12 @@ void TreeSupport::draw_circles()
|
|||||||
#endif // SUPPORT_TREE_DEBUG_TO_SVG
|
#endif // SUPPORT_TREE_DEBUG_TO_SVG
|
||||||
|
|
||||||
SupportLayerPtrs& ts_layers = m_object->support_layers();
|
SupportLayerPtrs& ts_layers = m_object->support_layers();
|
||||||
auto iter = std::remove_if(ts_layers.begin(), ts_layers.end(), [](SupportLayer* ts_layer) { return ts_layer->height < EPSILON; });
|
// Orca: the vector owns its layers, so the dropped ones are deleted before they are erased.
|
||||||
|
// std::stable_partition (unlike std::remove_if) leaves exactly the dropped layers in the tail.
|
||||||
|
// Only heights below EPSILON are dropped; written as !(height < EPSILON), a NaN height is kept.
|
||||||
|
auto iter = std::stable_partition(ts_layers.begin(), ts_layers.end(), [](SupportLayer* ts_layer) { return !(ts_layer->height < EPSILON); });
|
||||||
|
for (auto it = iter; it != ts_layers.end(); ++it)
|
||||||
|
delete *it;
|
||||||
ts_layers.erase(iter, ts_layers.end());
|
ts_layers.erase(iter, ts_layers.end());
|
||||||
for (int layer_nr = 0; layer_nr < ts_layers.size(); layer_nr++) {
|
for (int layer_nr = 0; layer_nr < ts_layers.size(); layer_nr++) {
|
||||||
ts_layers[layer_nr]->upper_layer = layer_nr != ts_layers.size() - 1 ? ts_layers[layer_nr + 1] : nullptr;
|
ts_layers[layer_nr]->upper_layer = layer_nr != ts_layers.size() - 1 ? ts_layers[layer_nr + 1] : nullptr;
|
||||||
@@ -3071,7 +3054,7 @@ void TreeSupport::drop_nodes()
|
|||||||
//Insert a completely new node and let both original nodes fade.
|
//Insert a completely new node and let both original nodes fade.
|
||||||
Point next_position = (node.position + neighbours[0]) / 2; //Average position of the two nodes.
|
Point next_position = (node.position + neighbours[0]) / 2; //Average position of the two nodes.
|
||||||
coordf_t next_radius = calc_radius(node.dist_mm_to_top+height_next);
|
coordf_t next_radius = calc_radius(node.dist_mm_to_top+height_next);
|
||||||
auto avoid_layer = get_avoidance(next_radius, obj_layer_nr_next);
|
const ExPolygons& avoid_layer = get_avoidance(next_radius, obj_layer_nr_next);
|
||||||
if (group_index == 0)
|
if (group_index == 0)
|
||||||
{
|
{
|
||||||
//Avoid collisions.
|
//Avoid collisions.
|
||||||
@@ -3275,7 +3258,7 @@ void TreeSupport::drop_nodes()
|
|||||||
}
|
}
|
||||||
#endif
|
#endif
|
||||||
coordf_t next_radius = calc_radius(node.dist_mm_to_top + height_next);
|
coordf_t next_radius = calc_radius(node.dist_mm_to_top + height_next);
|
||||||
auto avoidance_next = get_avoidance(next_radius, obj_layer_nr_next);
|
const ExPolygons& avoidance_next = get_avoidance(next_radius, obj_layer_nr_next);
|
||||||
|
|
||||||
Point to_outside = projection_onto(avoidance_next, node.position);
|
Point to_outside = projection_onto(avoidance_next, node.position);
|
||||||
Point direction_to_outer = to_outside - node.position;
|
Point direction_to_outer = to_outside - node.position;
|
||||||
@@ -3337,7 +3320,7 @@ void TreeSupport::drop_nodes()
|
|||||||
p_node->to_buildplate = false;
|
p_node->to_buildplate = false;
|
||||||
return; // from parallel_for_each lambda
|
return; // from parallel_for_each lambda
|
||||||
}
|
}
|
||||||
auto next_collision = get_collision(0, obj_layer_nr_next);
|
const ExPolygons& next_collision = get_collision(0, obj_layer_nr_next);
|
||||||
const bool to_buildplate = !is_inside_ex(m_ts_data->m_layer_outlines[obj_layer_nr_next], next_layer_vertex);
|
const bool to_buildplate = !is_inside_ex(m_ts_data->m_layer_outlines[obj_layer_nr_next], next_layer_vertex);
|
||||||
// don't increase radius if next node will collide partially with the object (STUDIO-7883)
|
// don't increase radius if next node will collide partially with the object (STUDIO-7883)
|
||||||
to_outside = projection_onto(next_collision, next_layer_vertex);
|
to_outside = projection_onto(next_collision, next_layer_vertex);
|
||||||
|
|||||||
@@ -536,9 +536,9 @@ private:
|
|||||||
coordf_t calc_branch_radius(coordf_t base_radius, coordf_t mm_to_top, double diameter_angle_scale_factor, bool use_min_distance=true);
|
coordf_t calc_branch_radius(coordf_t base_radius, coordf_t mm_to_top, double diameter_angle_scale_factor, bool use_min_distance=true);
|
||||||
coordf_t calc_radius(coordf_t mm_to_top);
|
coordf_t calc_radius(coordf_t mm_to_top);
|
||||||
coordf_t get_radius(const SupportNode* node);
|
coordf_t get_radius(const SupportNode* node);
|
||||||
ExPolygons get_avoidance(coordf_t radius, size_t obj_layer_nr);
|
const ExPolygons& get_avoidance(coordf_t radius, size_t obj_layer_nr);
|
||||||
// layer's expolygon expanded by radius+m_xy_distance
|
// layer's expolygon expanded by radius+m_xy_distance
|
||||||
ExPolygons get_collision(coordf_t radius, size_t layer_nr);
|
const ExPolygons& get_collision(coordf_t radius, size_t layer_nr);
|
||||||
// get Polygons instead of ExPolygons
|
// get Polygons instead of ExPolygons
|
||||||
Polygons get_collision_polys(coordf_t radius, size_t layer_nr);
|
Polygons get_collision_polys(coordf_t radius, size_t layer_nr);
|
||||||
|
|
||||||
|
|||||||
@@ -19,6 +19,7 @@
|
|||||||
#include <mutex>
|
#include <mutex>
|
||||||
#include <numeric>
|
#include <numeric>
|
||||||
#include <optional>
|
#include <optional>
|
||||||
|
#include "nlohmann/json.hpp"
|
||||||
#include <queue>
|
#include <queue>
|
||||||
#include <ratio>
|
#include <ratio>
|
||||||
#include <string>
|
#include <string>
|
||||||
@@ -157,12 +158,33 @@ struct SmoothedTextureCache
|
|||||||
{
|
{
|
||||||
std::weak_ptr<const std::vector<unsigned char>> source;
|
std::weak_ptr<const std::vector<unsigned char>> source;
|
||||||
float smoothing = 0.f;
|
float smoothing = 0.f;
|
||||||
|
// Part of the key, not of the result: smoothing is applied *after* the panel's adjustments, so a
|
||||||
|
// blur computed over one set of adjustments is not the blur another set would give.
|
||||||
|
TextureAdjustments adjust;
|
||||||
DecodedHeightTexture texture;
|
DecodedHeightTexture texture;
|
||||||
};
|
};
|
||||||
std::mutex mutex;
|
std::mutex mutex;
|
||||||
std::unordered_map<const void *, Entry> entries;
|
std::unordered_map<const void *, Entry> entries;
|
||||||
};
|
};
|
||||||
SmoothedTextureCache g_smoothed_texture_cache;
|
SmoothedTextureCache g_smoothed_texture_cache;
|
||||||
|
|
||||||
|
// The adjusted copy, cached between the raw decode and the smoothed one. Needed for the same reason the
|
||||||
|
// smoothed cache is: while a slider in the image-adjustment panel moves, the thumbnail, the shaded
|
||||||
|
// preview's height and colour textures, the UV editor backdrop and the displacement preview job all ask
|
||||||
|
// for the same (image, adjustments) pair within one frame, and each of them running a full-size resample
|
||||||
|
// of its own is what would make the panel unusable on a large texture.
|
||||||
|
struct AdjustedTextureCache
|
||||||
|
{
|
||||||
|
struct Entry
|
||||||
|
{
|
||||||
|
std::weak_ptr<const std::vector<unsigned char>> source;
|
||||||
|
TextureAdjustments adjust;
|
||||||
|
DecodedHeightTexture texture;
|
||||||
|
};
|
||||||
|
std::mutex mutex;
|
||||||
|
std::unordered_map<const void *, Entry> entries;
|
||||||
|
};
|
||||||
|
AdjustedTextureCache g_adjusted_texture_cache;
|
||||||
} // namespace
|
} // namespace
|
||||||
|
|
||||||
namespace {
|
namespace {
|
||||||
@@ -338,6 +360,34 @@ DecodedHeightTexture decode_height_texture(const TextureDisplacementLayer &layer
|
|||||||
entries[key] = { std::weak_ptr<const std::vector<unsigned char>>(layer.image_data), result };
|
entries[key] = { std::weak_ptr<const std::vector<unsigned char>>(layer.image_data), result };
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// The image-adjustment panel's live edits, on top of the decode and before the smoothing. Before,
|
||||||
|
// because `preview_adjust` is an edit to the image while `smoothing` is a live low-pass over whatever
|
||||||
|
// the image is - the same order the panel presents them in, and the same order a commit bakes in.
|
||||||
|
//
|
||||||
|
// Nothing applies here once the panel has closed: it resets preview_adjust to identity, and identity
|
||||||
|
// is a no-op that costs one comparison.
|
||||||
|
if (!layer.preview_adjust.identity()) {
|
||||||
|
bool have_adjusted = false;
|
||||||
|
{
|
||||||
|
std::lock_guard<std::mutex> lock(g_adjusted_texture_cache.mutex);
|
||||||
|
auto it = g_adjusted_texture_cache.entries.find(key);
|
||||||
|
if (it != g_adjusted_texture_cache.entries.end() && it->second.adjust == layer.preview_adjust &&
|
||||||
|
it->second.source.lock() == layer.image_data) {
|
||||||
|
result = it->second.texture;
|
||||||
|
have_adjusted = true;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if (!have_adjusted) {
|
||||||
|
result = apply_texture_adjustments(result, layer.preview_adjust);
|
||||||
|
std::lock_guard<std::mutex> lock(g_adjusted_texture_cache.mutex);
|
||||||
|
auto &entries = g_adjusted_texture_cache.entries;
|
||||||
|
for (auto it = entries.begin(); it != entries.end();)
|
||||||
|
it = it->second.source.expired() ? entries.erase(it) : std::next(it);
|
||||||
|
entries[key] = { std::weak_ptr<const std::vector<unsigned char>>(layer.image_data),
|
||||||
|
layer.preview_adjust, result };
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// Smoothing radius scales with the texture so the same slider value blurs the same *fraction* of
|
// Smoothing radius scales with the texture so the same slider value blurs the same *fraction* of
|
||||||
// the image whatever resolution it came in at, and stays continuous in the slider - see
|
// the image whatever resolution it came in at, and stays continuous in the slider - see
|
||||||
// smooth_height_pixels(). The cap is a cost limit, not part of the mapping: the blur is
|
// smooth_height_pixels(). The cap is a cost limit, not part of the mapping: the blur is
|
||||||
@@ -348,7 +398,7 @@ DecodedHeightTexture decode_height_texture(const TextureDisplacementLayer &layer
|
|||||||
std::lock_guard<std::mutex> lock(g_smoothed_texture_cache.mutex);
|
std::lock_guard<std::mutex> lock(g_smoothed_texture_cache.mutex);
|
||||||
auto it = g_smoothed_texture_cache.entries.find(key);
|
auto it = g_smoothed_texture_cache.entries.find(key);
|
||||||
if (it != g_smoothed_texture_cache.entries.end() && it->second.smoothing == layer.smoothing &&
|
if (it != g_smoothed_texture_cache.entries.end() && it->second.smoothing == layer.smoothing &&
|
||||||
it->second.source.lock() == layer.image_data)
|
it->second.adjust == layer.preview_adjust && it->second.source.lock() == layer.image_data)
|
||||||
return it->second.texture;
|
return it->second.texture;
|
||||||
}
|
}
|
||||||
const float span = 0.05f * float(std::min(result.width, result.height));
|
const float span = 0.05f * float(std::min(result.width, result.height));
|
||||||
@@ -372,12 +422,70 @@ DecodedHeightTexture decode_height_texture(const TextureDisplacementLayer &layer
|
|||||||
auto &entries = g_smoothed_texture_cache.entries;
|
auto &entries = g_smoothed_texture_cache.entries;
|
||||||
for (auto it = entries.begin(); it != entries.end();)
|
for (auto it = entries.begin(); it != entries.end();)
|
||||||
it = it->second.source.expired() ? entries.erase(it) : std::next(it);
|
it = it->second.source.expired() ? entries.erase(it) : std::next(it);
|
||||||
entries[key] = { std::weak_ptr<const std::vector<unsigned char>>(layer.image_data), layer.smoothing, result };
|
entries[key] = { std::weak_ptr<const std::vector<unsigned char>>(layer.image_data), layer.smoothing,
|
||||||
|
layer.preview_adjust, result };
|
||||||
}
|
}
|
||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
|
|
||||||
namespace {
|
namespace {
|
||||||
|
// Fraction of the short side that TextureAdjustments::blur == 1 blurs over, and the cost cap on it.
|
||||||
|
// Deliberately the same pair decode_height_texture() uses for the Smoothing slider - see
|
||||||
|
// adjustment_blur_radius().
|
||||||
|
constexpr float SOURCE_BLUR_SPAN = 0.05f;
|
||||||
|
constexpr float SOURCE_BLUR_MAX_PX = 48.f;
|
||||||
|
|
||||||
|
// Radius of the unsharp mask's blurred reference, in texels. Small and only mildly resolution-dependent:
|
||||||
|
// a sharpen is meant to act on the finest detail the image holds, so its radius tracks the texel grid
|
||||||
|
// rather than the picture's size. 1024x1024 gives ~2 texels, the usual photo-editor default.
|
||||||
|
float unsharp_radius(int width, int height)
|
||||||
|
{
|
||||||
|
return std::max(1.f, 0.002f * float(std::min(width, height)));
|
||||||
|
}
|
||||||
|
|
||||||
|
// Brightness as a *lift* toward white (or toward black) rather than an additive offset: positive b maps
|
||||||
|
// v to v + b*(1 - v), negative to v*(1 + b). Both reach the endpoint exactly at |b| == 1 while staying
|
||||||
|
// monotonic and non-clipping in between, which an additive shift does not - it drives a whole region to
|
||||||
|
// a flat 255 and, because this image is also the height map, that region bakes as flat relief rather
|
||||||
|
// than as bright relief. Keeping the curve injective keeps the detail in it.
|
||||||
|
float apply_brightness(float v, float b)
|
||||||
|
{
|
||||||
|
return b >= 0.f ? v + b * (1.f - v) : v * (1.f + b);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Contrast about the 0.5 pivot. Gain is 1/(1-c) going up (c == 1 would be an infinite-slope threshold, so
|
||||||
|
// the caller's clamp keeps it finite) and 1+c going down, reaching a flat mid-grey at c == -1.
|
||||||
|
float apply_contrast(float v, float c)
|
||||||
|
{
|
||||||
|
const float gain = c >= 0.f ? 1.f / std::max(1e-3f, 1.f - c) : 1.f + c;
|
||||||
|
return (v - 0.5f) * gain + 0.5f;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Blur then sharpen one 8-bit channel in place. Shared by the grayscale path and by each of a colour
|
||||||
|
// image's three channels, so every channel gets the identical spatial treatment and a colour image's
|
||||||
|
// hue cannot shift just because its channels were filtered differently.
|
||||||
|
void adjust_channel_spatial(std::vector<uint8_t> &channel, int width, int height, float blur, float sharpness)
|
||||||
|
{
|
||||||
|
if (blur > 0.f)
|
||||||
|
smooth_height_pixels(channel, width, height, adjustment_blur_radius(blur, width, height));
|
||||||
|
|
||||||
|
if (sharpness <= 0.f)
|
||||||
|
return;
|
||||||
|
|
||||||
|
// Unsharp mask: push each texel away from its local average by `amount` times the difference. The
|
||||||
|
// blurred reference is a copy, so the sharpen reads the un-sharpened neighbourhood everywhere rather
|
||||||
|
// than its own partly-written output.
|
||||||
|
std::vector<uint8_t> base = channel;
|
||||||
|
smooth_height_pixels(base, width, height, unsharp_radius(width, height));
|
||||||
|
const float amount = 1.5f * std::clamp(sharpness, 0.f, 1.f);
|
||||||
|
tbb::parallel_for(tbb::blocked_range<size_t>(0, channel.size()), [&](const tbb::blocked_range<size_t> &r) {
|
||||||
|
for (size_t i = r.begin(); i < r.end(); ++i) {
|
||||||
|
const float v = float(channel[i]) + amount * (float(channel[i]) - float(base[i]));
|
||||||
|
channel[i] = uint8_t(std::lround(std::clamp(v, 0.f, 255.f)));
|
||||||
|
}
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
struct TextureDetailCache
|
struct TextureDetailCache
|
||||||
{
|
{
|
||||||
std::mutex mutex;
|
std::mutex mutex;
|
||||||
@@ -386,6 +494,150 @@ struct TextureDetailCache
|
|||||||
TextureDetailCache g_texture_detail_cache;
|
TextureDetailCache g_texture_detail_cache;
|
||||||
} // namespace
|
} // namespace
|
||||||
|
|
||||||
|
float adjustment_blur_radius(float blur, int width, int height)
|
||||||
|
{
|
||||||
|
if (blur <= 0.f || width <= 0 || height <= 0)
|
||||||
|
return 0.f;
|
||||||
|
const float span = SOURCE_BLUR_SPAN * float(std::min(width, height));
|
||||||
|
return std::clamp(blur, 0.f, 1.f) * std::min(span, SOURCE_BLUR_MAX_PX);
|
||||||
|
}
|
||||||
|
|
||||||
|
DecodedHeightTexture downscale_height_texture(const DecodedHeightTexture &src, int max_px)
|
||||||
|
{
|
||||||
|
if (src.empty() || max_px <= 0 || (src.width <= max_px && src.height <= max_px))
|
||||||
|
return src;
|
||||||
|
|
||||||
|
const int scale = std::max(1, (std::max(src.width, src.height) + max_px - 1) / max_px);
|
||||||
|
const int w = std::max(1, src.width / scale);
|
||||||
|
const int h = std::max(1, src.height / scale);
|
||||||
|
const bool color = src.has_color();
|
||||||
|
|
||||||
|
DecodedHeightTexture out;
|
||||||
|
out.width = w;
|
||||||
|
out.height = h;
|
||||||
|
out.pixels.resize(size_t(w) * size_t(h));
|
||||||
|
if (color)
|
||||||
|
out.rgb.resize(size_t(w) * size_t(h) * 3);
|
||||||
|
|
||||||
|
tbb::parallel_for(tbb::blocked_range<int>(0, h), [&](const tbb::blocked_range<int> &r) {
|
||||||
|
for (int y = r.begin(); y < r.end(); ++y)
|
||||||
|
for (int x = 0; x < w; ++x) {
|
||||||
|
// The source block this destination texel covers. The max() keeps the block non-empty
|
||||||
|
// when rounding would otherwise collapse it.
|
||||||
|
const int x0 = x * src.width / w, x1 = std::max(x0 + 1, (x + 1) * src.width / w);
|
||||||
|
const int y0 = y * src.height / h, y1 = std::max(y0 + 1, (y + 1) * src.height / h);
|
||||||
|
uint32_t sum_h = 0, sum_c[3] = { 0, 0, 0 }, n = 0;
|
||||||
|
for (int sy = y0; sy < y1 && sy < src.height; ++sy)
|
||||||
|
for (int sx = x0; sx < x1 && sx < src.width; ++sx, ++n) {
|
||||||
|
const size_t si = size_t(sy) * size_t(src.width) + size_t(sx);
|
||||||
|
sum_h += src.pixels[si];
|
||||||
|
if (color)
|
||||||
|
for (int c = 0; c < 3; ++c)
|
||||||
|
sum_c[c] += src.rgb[si * 3 + size_t(c)];
|
||||||
|
}
|
||||||
|
const size_t di = size_t(y) * size_t(w) + size_t(x);
|
||||||
|
out.pixels[di] = n > 0 ? uint8_t(sum_h / n) : 0;
|
||||||
|
if (color)
|
||||||
|
for (int c = 0; c < 3; ++c)
|
||||||
|
out.rgb[di * 3 + size_t(c)] = n > 0 ? uint8_t(sum_c[c] / n) : 0;
|
||||||
|
}
|
||||||
|
});
|
||||||
|
return out;
|
||||||
|
}
|
||||||
|
|
||||||
|
DecodedHeightTexture apply_texture_adjustments(const DecodedHeightTexture &src, const TextureAdjustments &adj)
|
||||||
|
{
|
||||||
|
DecodedHeightTexture out = src;
|
||||||
|
if (src.empty() || adj.identity())
|
||||||
|
return out;
|
||||||
|
|
||||||
|
const int w = out.width;
|
||||||
|
const int h = out.height;
|
||||||
|
const size_t n = size_t(w) * size_t(h);
|
||||||
|
|
||||||
|
const float brightness = std::clamp(adj.brightness, -1.f, 1.f);
|
||||||
|
// Short of 1, so apply_contrast()'s gain stays finite; at this value it is already a 1000x slope,
|
||||||
|
// i.e. a threshold in all but name.
|
||||||
|
const float contrast = std::clamp(adj.contrast, -1.f, 0.999f);
|
||||||
|
const float blur = std::clamp(adj.blur, 0.f, 1.f);
|
||||||
|
const float sharpness = std::clamp(adj.sharpness, 0.f, 1.f);
|
||||||
|
|
||||||
|
// The tonal pass: a 256-entry lookup table, because brightness and contrast are the same scalar
|
||||||
|
// curve for every texel and every channel. Building it once beats evaluating two curves a few
|
||||||
|
// million times, and it is what keeps this pass off the panel's critical path.
|
||||||
|
std::array<uint8_t, 256> tone{};
|
||||||
|
for (int i = 0; i < 256; ++i) {
|
||||||
|
float v = float(i) / 255.f;
|
||||||
|
v = apply_brightness(v, brightness);
|
||||||
|
v = apply_contrast(v, contrast);
|
||||||
|
tone[size_t(i)] = uint8_t(std::lround(std::clamp(v, 0.f, 1.f) * 255.f));
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!out.has_color()) {
|
||||||
|
// Grayscale: one channel, and hue has nothing to turn.
|
||||||
|
tbb::parallel_for(tbb::blocked_range<size_t>(0, n), [&](const tbb::blocked_range<size_t> &r) {
|
||||||
|
for (size_t i = r.begin(); i < r.end(); ++i)
|
||||||
|
out.pixels[i] = tone[out.pixels[i]];
|
||||||
|
});
|
||||||
|
adjust_channel_spatial(out.pixels, w, h, blur, sharpness);
|
||||||
|
return out;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Colour: tone each channel through the same table, then rotate the hue about the luminance axis.
|
||||||
|
//
|
||||||
|
// The rotation is feColorMatrix's hueRotate matrix (SVG filters), which holds Rec.709 luma fixed.
|
||||||
|
// The height below is taken with decode_height_texture()'s Rec.601 coefficients instead, so a hue
|
||||||
|
// turn is not perfectly height-neutral - a few levels at full saturation. Reconciling the two would
|
||||||
|
// mean a different rotation than every other tool's, which is the worse trade: the user is watching
|
||||||
|
// the colour, and the height follows the colour by construction either way.
|
||||||
|
const float theta = adj.hue_deg * float(M_PI) / 180.f;
|
||||||
|
const float c = std::cos(theta);
|
||||||
|
const float s = std::sin(theta);
|
||||||
|
const float m[9] = {
|
||||||
|
0.213f + c * 0.787f - s * 0.213f, 0.715f - c * 0.715f - s * 0.715f, 0.072f - c * 0.072f + s * 0.928f,
|
||||||
|
0.213f - c * 0.213f + s * 0.143f, 0.715f + c * 0.285f + s * 0.140f, 0.072f - c * 0.072f - s * 0.283f,
|
||||||
|
0.213f - c * 0.213f - s * 0.787f, 0.715f - c * 0.715f + s * 0.715f, 0.072f + c * 0.928f + s * 0.072f,
|
||||||
|
};
|
||||||
|
const bool turn_hue = adj.hue_deg != 0.f;
|
||||||
|
|
||||||
|
tbb::parallel_for(tbb::blocked_range<size_t>(0, n), [&](const tbb::blocked_range<size_t> &r) {
|
||||||
|
for (size_t i = r.begin(); i < r.end(); ++i) {
|
||||||
|
const float rr = float(tone[out.rgb[i * 3]]);
|
||||||
|
const float gg = float(tone[out.rgb[i * 3 + 1]]);
|
||||||
|
const float bb = float(tone[out.rgb[i * 3 + 2]]);
|
||||||
|
const float nr = turn_hue ? m[0] * rr + m[1] * gg + m[2] * bb : rr;
|
||||||
|
const float ng = turn_hue ? m[3] * rr + m[4] * gg + m[5] * bb : gg;
|
||||||
|
const float nb = turn_hue ? m[6] * rr + m[7] * gg + m[8] * bb : bb;
|
||||||
|
out.rgb[i * 3] = uint8_t(std::lround(std::clamp(nr, 0.f, 255.f)));
|
||||||
|
out.rgb[i * 3 + 1] = uint8_t(std::lround(std::clamp(ng, 0.f, 255.f)));
|
||||||
|
out.rgb[i * 3 + 2] = uint8_t(std::lround(std::clamp(nb, 0.f, 255.f)));
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
// The spatial pass wants one channel at a time (smooth_height_pixels() is a single-channel blur, and
|
||||||
|
// reusing it is what keeps this consistent with Smoothing), so de-interleave, filter, re-interleave.
|
||||||
|
if (blur > 0.f || sharpness > 0.f) {
|
||||||
|
std::vector<uint8_t> channel(n);
|
||||||
|
for (int ch = 0; ch < 3; ++ch) {
|
||||||
|
for (size_t i = 0; i < n; ++i)
|
||||||
|
channel[i] = out.rgb[i * 3 + size_t(ch)];
|
||||||
|
adjust_channel_spatial(channel, w, h, blur, sharpness);
|
||||||
|
for (size_t i = 0; i < n; ++i)
|
||||||
|
out.rgb[i * 3 + size_t(ch)] = channel[i];
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Height is the luminance of the colour that came out, not the toned luminance of the colour that
|
||||||
|
// went in: the two differ once hue rotation or a per-channel clamp has moved the channels around,
|
||||||
|
// and a height that disagrees with the colour it is stored next to is the bug this avoids.
|
||||||
|
tbb::parallel_for(tbb::blocked_range<size_t>(0, n), [&](const tbb::blocked_range<size_t> &r) {
|
||||||
|
for (size_t i = r.begin(); i < r.end(); ++i)
|
||||||
|
out.pixels[i] = uint8_t(std::lround(0.299 * out.rgb[i * 3] + 0.587 * out.rgb[i * 3 + 1] +
|
||||||
|
0.114 * out.rgb[i * 3 + 2]));
|
||||||
|
});
|
||||||
|
return out;
|
||||||
|
}
|
||||||
|
|
||||||
TextureDetail analyze_texture_detail(const TextureDisplacementLayer &layer)
|
TextureDetail analyze_texture_detail(const TextureDisplacementLayer &layer)
|
||||||
{
|
{
|
||||||
TextureDetail out;
|
TextureDetail out;
|
||||||
@@ -491,6 +743,57 @@ V2Resolution recommend_v2_resolution(const indexed_triangle_set
|
|||||||
return out;
|
return out;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
namespace {
|
||||||
|
// Which side of a world plane a face is on, with an exactly zero component counted as the positive
|
||||||
|
// side. The tie never shows: a normal component of zero carries zero tri-planar blend weight (see
|
||||||
|
// triplanar_weights()), so the plane it orients contributes nothing at that point.
|
||||||
|
inline float box_face_sign(float n) { return n >= 0.f ? 1.f : -1.f; }
|
||||||
|
|
||||||
|
// The box projection's 2D basis for one of the three world planes, oriented the way a viewer
|
||||||
|
// standing outside the model sees that face.
|
||||||
|
//
|
||||||
|
// v runs *down* the image, because that is what v means to the sampler: v = 0 is the texture's first
|
||||||
|
// pixel row, i.e. its top (DecodedHeightTexture::sample(); the UV editor negates Y on screen for the
|
||||||
|
// same reason, see UVEditorCanvas::render()). So v = -z on the four upright planes and v = -y on the
|
||||||
|
// horizontal one, which is what puts the top of an image at the top of the model rather than
|
||||||
|
// upside down.
|
||||||
|
//
|
||||||
|
// u then has to depend on which *side* of the plane the face is on, or one of the two faces sharing
|
||||||
|
// a plane comes out left-right mirrored: with a single u per plane, a portrait image reads upright on
|
||||||
|
// +X and 180 degrees round on -X. Fixing that is the sign below, chosen so that u x v == -normal,
|
||||||
|
// i.e. (right, down, into the surface) is right-handed for a viewer outside:
|
||||||
|
//
|
||||||
|
// face u v face u v face u v
|
||||||
|
// +X +y -z +Y -x -z +Z +x -y
|
||||||
|
// -X -y -z -Y +x -z -Z -x -y
|
||||||
|
//
|
||||||
|
// The sign flips where its own normal component crosses zero, and the blend weight of the plane it
|
||||||
|
// belongs to is exactly zero there, so the blended tri-planar sum stays continuous across the flip -
|
||||||
|
// it is not a return of the hard axis switch described on TextureProjectionMethod::Triplanar.
|
||||||
|
inline Vec2f box_plane_yz(const Vec3f &p, float nx) { return Vec2f(box_face_sign(nx) * p.y(), -p.z()); }
|
||||||
|
inline Vec2f box_plane_xz(const Vec3f &p, float ny) { return Vec2f(-box_face_sign(ny) * p.x(), -p.z()); }
|
||||||
|
inline Vec2f box_plane_xy(const Vec3f &p, float nz) { return Vec2f(box_face_sign(nz) * p.x(), -p.y()); }
|
||||||
|
} // namespace
|
||||||
|
|
||||||
|
void box_projection_axes(const Vec3f &normal, Vec3f &u_axis, Vec3f &v_axis)
|
||||||
|
{
|
||||||
|
// The same table as box_plane_yz()/box_plane_xz()/box_plane_xy(), handed out as a pair of world
|
||||||
|
// directions for the plane the normal is closest to. Two shapes of one table, because the bake's
|
||||||
|
// hot path wants the closed form and the GUI wants the axes; the test suite checks them against
|
||||||
|
// each other so they cannot drift apart.
|
||||||
|
const Vec3f n = normal.cwiseAbs();
|
||||||
|
if (n.x() >= n.y() && n.x() >= n.z()) {
|
||||||
|
u_axis = box_face_sign(normal.x()) * Vec3f::UnitY();
|
||||||
|
v_axis = -Vec3f::UnitZ();
|
||||||
|
} else if (n.y() >= n.x() && n.y() >= n.z()) {
|
||||||
|
u_axis = -box_face_sign(normal.y()) * Vec3f::UnitX();
|
||||||
|
v_axis = -Vec3f::UnitZ();
|
||||||
|
} else {
|
||||||
|
u_axis = box_face_sign(normal.z()) * Vec3f::UnitX();
|
||||||
|
v_axis = -Vec3f::UnitY();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
Vec2f project_planar(const Vec3f &position, const Vec3f &normal)
|
Vec2f project_planar(const Vec3f &position, const Vec3f &normal)
|
||||||
{
|
{
|
||||||
// Planar-project onto the two axes orthogonal to the dominant component of `normal`. Called
|
// Planar-project onto the two axes orthogonal to the dominant component of `normal`. Called
|
||||||
@@ -501,23 +804,26 @@ Vec2f project_planar(const Vec3f &position, const Vec3f &normal)
|
|||||||
// other face in the same patch - exactly the bug an earlier version of this feature had).
|
// other face in the same patch - exactly the bug an earlier version of this feature had).
|
||||||
const Vec3f n = normal.cwiseAbs();
|
const Vec3f n = normal.cwiseAbs();
|
||||||
if (n.x() >= n.y() && n.x() >= n.z())
|
if (n.x() >= n.y() && n.x() >= n.z())
|
||||||
return Vec2f(position.y(), position.z());
|
return box_plane_yz(position, normal.x());
|
||||||
if (n.y() >= n.x() && n.y() >= n.z())
|
if (n.y() >= n.x() && n.y() >= n.z())
|
||||||
return Vec2f(position.x(), position.z());
|
return box_plane_xz(position, normal.y());
|
||||||
return Vec2f(position.x(), position.y());
|
return box_plane_xy(position, normal.z());
|
||||||
}
|
}
|
||||||
|
|
||||||
namespace {
|
namespace {
|
||||||
// Wrapped around patch_axis, centered at patch_center. u is the arc length (mm) around the axis at
|
// Wrapped around patch_axis, centered at patch_center. u is the arc length (mm) around the axis at
|
||||||
// this point's own radius, v is the signed distance along the axis - a reasonable approximation
|
// this point's own radius, v is the distance along the axis, measured *against* it - a reasonable
|
||||||
// for roughly cylindrical selections, not an exact fit for arbitrary geometry.
|
// approximation for roughly cylindrical selections, not an exact fit for arbitrary geometry.
|
||||||
Vec2f project_cylindrical(const Vec3f &position, const Vec3f &patch_center, const Vec3f &patch_axis)
|
Vec2f project_cylindrical(const Vec3f &position, const Vec3f &patch_center, const Vec3f &patch_axis)
|
||||||
{
|
{
|
||||||
Vec3f up = patch_axis;
|
Vec3f up = patch_axis;
|
||||||
up = (up.norm() > 1e-8f) ? Vec3f(up.normalized()) : Vec3f::UnitZ();
|
up = (up.norm() > 1e-8f) ? Vec3f(up.normalized()) : Vec3f::UnitZ();
|
||||||
const Vec3f arbitrary = (std::abs(up.dot(Vec3f::UnitZ())) < 0.9f) ? Vec3f::UnitZ() : Vec3f::UnitX();
|
const Vec3f arbitrary = (std::abs(up.dot(Vec3f::UnitZ())) < 0.9f) ? Vec3f::UnitZ() : Vec3f::UnitX();
|
||||||
const Vec3f right = Vec3f(up.cross(arbitrary).normalized());
|
const Vec3f right = Vec3f(up.cross(arbitrary).normalized());
|
||||||
const Vec3f fwd = Vec3f(right.cross(up).normalized());
|
// up x right, not right x up: that makes (right, fwd, up) right-handed, so the angle below grows
|
||||||
|
// anticlockwise about the axis - which, seen from outside the cylinder, is to the viewer's right.
|
||||||
|
// The other way round the texture wraps on mirrored, as if seen through the model from behind.
|
||||||
|
const Vec3f fwd = Vec3f(up.cross(right).normalized());
|
||||||
|
|
||||||
const Vec3f rel = position - patch_center;
|
const Vec3f rel = position - patch_center;
|
||||||
const float along_axis = rel.dot(up);
|
const float along_axis = rel.dot(up);
|
||||||
@@ -526,7 +832,9 @@ Vec2f project_cylindrical(const Vec3f &position, const Vec3f &patch_center, cons
|
|||||||
const float radius = std::sqrt(x * x + y * y);
|
const float radius = std::sqrt(x * x + y * y);
|
||||||
const float angle = std::atan2(y, x);
|
const float angle = std::atan2(y, x);
|
||||||
|
|
||||||
return Vec2f(angle * radius, along_axis);
|
// Negated, like every other projection's v: v = 0 is the texture's top row, so v has to grow
|
||||||
|
// *down* the axis for the top of the image to sit at the top of the model.
|
||||||
|
return Vec2f(angle * radius, -along_axis);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Longitude/latitude around patch_center. u/v are scaled by this point's own distance from the
|
// Longitude/latitude around patch_center. u/v are scaled by this point's own distance from the
|
||||||
@@ -542,7 +850,9 @@ Vec2f project_spherical(const Vec3f &position, const Vec3f &patch_center)
|
|||||||
const Vec3f dir = rel / radius;
|
const Vec3f dir = rel / radius;
|
||||||
const float longitude = std::atan2(dir.y(), dir.x());
|
const float longitude = std::atan2(dir.y(), dir.x());
|
||||||
const float latitude = std::asin(std::clamp(dir.z(), -1.f, 1.f));
|
const float latitude = std::asin(std::clamp(dir.z(), -1.f, 1.f));
|
||||||
return Vec2f(longitude, latitude) * radius;
|
// Longitude already grows to the right as seen from outside; latitude grows toward the north
|
||||||
|
// pole, so it is negated to put the image's top row (v = 0) at the top of the model.
|
||||||
|
return Vec2f(longitude, -latitude) * radius;
|
||||||
}
|
}
|
||||||
|
|
||||||
// CGAL's LSCM parameterizer expects a clean mesh with no isolated (unreferenced) vertices - but
|
// CGAL's LSCM parameterizer expects a clean mesh with no isolated (unreferenced) vertices - but
|
||||||
@@ -837,9 +1147,26 @@ std::vector<int> segment_into_charts(const indexed_triangle_set &mesh, const std
|
|||||||
// solve at all, and why this also serves as the fallback for a chart LSCM cannot handle.
|
// solve at all, and why this also serves as the fallback for a chart LSCM cannot handle.
|
||||||
std::vector<Vec2f> project_to_tangent_plane(const indexed_triangle_set &chart, const Vec3f &normal)
|
std::vector<Vec2f> project_to_tangent_plane(const indexed_triangle_set &chart, const Vec3f &normal)
|
||||||
{
|
{
|
||||||
const Vec3f seed = (std::abs(normal.z()) < 0.9f) ? Vec3f::UnitZ() : Vec3f::UnitX();
|
// Oriented like the box projection (see box_projection_axes()), so a chart reads the right way up
|
||||||
const Vec3f u = Vec3f(seed.cross(normal).normalized());
|
// and unmirrored instead of being flattened to whichever basis a cross product happened to give.
|
||||||
const Vec3f v = Vec3f(normal.cross(u).normalized());
|
// For a chart whose normal *is* a world axis - a cube face, which is the common case once the
|
||||||
|
// seam angle has cut the patch along its sharp edges - this is exactly the box basis, so such a
|
||||||
|
// face unwraps to the same orientation Triplanar would have given it.
|
||||||
|
Vec3f u, v;
|
||||||
|
box_projection_axes(normal, u, v);
|
||||||
|
// The box axes lie in the tangent plane already when the normal is a world axis; for any other
|
||||||
|
// normal, u is squared up against it and v follows. u x v == -normal keeps the chart the way
|
||||||
|
// round a viewer outside the model sees it (a plain normal x u would mirror it).
|
||||||
|
u = u - normal * normal.dot(u);
|
||||||
|
if (u.norm() <= 1e-6f) {
|
||||||
|
// Out of reach for a unit normal - the box basis puts u perpendicular to the normal's own
|
||||||
|
// dominant axis, so the two can never be within 45 degrees of each other - but a caller
|
||||||
|
// handing over an unnormalized normal should still get a usable basis rather than a NaN.
|
||||||
|
const Vec3f seed = (std::abs(normal.z()) < 0.9f) ? Vec3f::UnitZ() : Vec3f::UnitX();
|
||||||
|
u = seed.cross(normal);
|
||||||
|
}
|
||||||
|
u = Vec3f(u.normalized());
|
||||||
|
v = Vec3f(u.cross(normal).normalized());
|
||||||
|
|
||||||
std::vector<Vec2f> uvs(chart.vertices.size());
|
std::vector<Vec2f> uvs(chart.vertices.size());
|
||||||
for (size_t i = 0; i < chart.vertices.size(); ++i)
|
for (size_t i = 0; i < chart.vertices.size(); ++i)
|
||||||
@@ -1814,8 +2141,10 @@ float sample_layer_height(const DecodedHeightTexture &texture, const TextureDisp
|
|||||||
return texture.sample(uv, layer.tile_enabled, layer.tile_method);
|
return texture.sample(uv, layer.tile_enabled, layer.tile_method);
|
||||||
}
|
}
|
||||||
// Flat projection onto the captured projector plane. Single-valued per point, so unlike
|
// Flat projection onto the captured projector plane. Single-valued per point, so unlike
|
||||||
// blended triplanar it is one sample, and it is what "project from view" places.
|
// blended triplanar it is one sample, and it is what "project from view" places. The
|
||||||
return sample_at(Vec2f(position.dot(layer.view_project_right), position.dot(layer.view_project_up)));
|
// projector's up axis is negated because v runs *down* the image (v = 0 is its first pixel
|
||||||
|
// row), the same reason the projective branch above measures window y downward.
|
||||||
|
return sample_at(Vec2f(position.dot(layer.view_project_right), -position.dot(layer.view_project_up)));
|
||||||
case TextureProjectionMethod::LSCM: // no usable unwrap for this patch - fall back to Triplanar
|
case TextureProjectionMethod::LSCM: // no usable unwrap for this patch - fall back to Triplanar
|
||||||
case TextureProjectionMethod::Triplanar:
|
case TextureProjectionMethod::Triplanar:
|
||||||
default: break;
|
default: break;
|
||||||
@@ -1830,14 +2159,15 @@ float sample_layer_height(const DecodedHeightTexture &texture, const TextureDisp
|
|||||||
const float w_sum = w.x() + w.y() + w.z();
|
const float w_sum = w.x() + w.y() + w.z();
|
||||||
if (w_sum < 1e-8f)
|
if (w_sum < 1e-8f)
|
||||||
// Degenerate normal: no axis is meaningfully dominant, so no blend is meaningful either.
|
// Degenerate normal: no axis is meaningfully dominant, so no blend is meaningful either.
|
||||||
return sample_at(Vec2f(position.x(), position.y()));
|
return sample_at(box_plane_xy(position, normal.z()));
|
||||||
w /= w_sum;
|
w /= w_sum;
|
||||||
|
|
||||||
// Each plane drops the axis it is named for, matching project_planar()'s own convention (which
|
// Each plane drops the axis it is named for and is oriented for the side of that plane the normal
|
||||||
// the GUI's on-canvas placement gizmo also relies on).
|
// points to, matching project_planar()'s own convention (which the GUI's on-canvas placement
|
||||||
return w.x() * sample_at(Vec2f(position.y(), position.z())) +
|
// gizmo also relies on). See box_plane_yz() for why the orientation is not simply (y, z).
|
||||||
w.y() * sample_at(Vec2f(position.x(), position.z())) +
|
return w.x() * sample_at(box_plane_yz(position, normal.x())) +
|
||||||
w.z() * sample_at(Vec2f(position.x(), position.y()));
|
w.y() * sample_at(box_plane_xz(position, normal.y())) +
|
||||||
|
w.z() * sample_at(box_plane_xy(position, normal.z()));
|
||||||
}
|
}
|
||||||
|
|
||||||
bool sample_layer_color(const DecodedHeightTexture &texture, const TextureDisplacementLayer &layer,
|
bool sample_layer_color(const DecodedHeightTexture &texture, const TextureDisplacementLayer &layer,
|
||||||
@@ -1899,7 +2229,8 @@ bool sample_layer_color(const DecodedHeightTexture &texture, const TextureDispla
|
|||||||
out = texture.sample_color(uv, layer.tile_enabled, layer.tile_method);
|
out = texture.sample_color(uv, layer.tile_enabled, layer.tile_method);
|
||||||
return true;
|
return true;
|
||||||
} else {
|
} else {
|
||||||
const Vec2f p(position.dot(layer.view_project_right), position.dot(layer.view_project_up));
|
// Negated up, exactly as sample_layer_height() does it.
|
||||||
|
const Vec2f p(position.dot(layer.view_project_right), -position.dot(layer.view_project_up));
|
||||||
if (!covered(p))
|
if (!covered(p))
|
||||||
return false;
|
return false;
|
||||||
out = sample_at(p);
|
out = sample_at(p);
|
||||||
@@ -1915,7 +2246,7 @@ bool sample_layer_color(const DecodedHeightTexture &texture, const TextureDispla
|
|||||||
Vec3f w = triplanar_weights(normal);
|
Vec3f w = triplanar_weights(normal);
|
||||||
const float w_sum = w.x() + w.y() + w.z();
|
const float w_sum = w.x() + w.y() + w.z();
|
||||||
if (w_sum < 1e-8f) {
|
if (w_sum < 1e-8f) {
|
||||||
const Vec2f p(position.x(), position.y());
|
const Vec2f p = box_plane_xy(position, normal.z());
|
||||||
if (!covered(p))
|
if (!covered(p))
|
||||||
return false;
|
return false;
|
||||||
out = sample_at(p);
|
out = sample_at(p);
|
||||||
@@ -1926,8 +2257,8 @@ bool sample_layer_color(const DecodedHeightTexture &texture, const TextureDispla
|
|||||||
// A blend of three planes is only "not covered" where *every* contributing plane is outside the
|
// A blend of three planes is only "not covered" where *every* contributing plane is outside the
|
||||||
// placement; where some are, the covered ones are renormalised so the colour does not fade toward
|
// placement; where some are, the covered ones are renormalised so the colour does not fade toward
|
||||||
// black at the edge of an untiled tri-planar layer.
|
// black at the edge of an untiled tri-planar layer.
|
||||||
const std::array<Vec2f, 3> planes = { Vec2f(position.y(), position.z()), Vec2f(position.x(), position.z()),
|
const std::array<Vec2f, 3> planes = { box_plane_yz(position, normal.x()), box_plane_xz(position, normal.y()),
|
||||||
Vec2f(position.x(), position.y()) };
|
box_plane_xy(position, normal.z()) };
|
||||||
Vec3f acc = Vec3f::Zero();
|
Vec3f acc = Vec3f::Zero();
|
||||||
float acc_w = 0.f;
|
float acc_w = 0.f;
|
||||||
for (int i = 0; i < 3; ++i)
|
for (int i = 0; i < 3; ++i)
|
||||||
@@ -5166,5 +5497,260 @@ indexed_triangle_set cut_mesh_at_steps(const indexed_triangle_set &mesh, const s
|
|||||||
return out;
|
return out;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// ---------------------------------------------------------------------------------------------
|
||||||
|
// Project persistence. See the declarations in TextureDisplacement.hpp for why this is JSON rather
|
||||||
|
// than the cereal stream next to them.
|
||||||
|
// ---------------------------------------------------------------------------------------------
|
||||||
|
namespace {
|
||||||
|
|
||||||
|
nlohmann::json vec2_to_json(const Vec2f &v) { return nlohmann::json::array({ v.x(), v.y() }); }
|
||||||
|
nlohmann::json vec3_to_json(const Vec3f &v) { return nlohmann::json::array({ v.x(), v.y(), v.z() }); }
|
||||||
|
|
||||||
|
Vec2f vec2_from_json(const nlohmann::json &j, const Vec2f &fallback)
|
||||||
|
{
|
||||||
|
if (!j.is_array() || j.size() != 2)
|
||||||
|
return fallback;
|
||||||
|
return Vec2f(j[0].get<float>(), j[1].get<float>());
|
||||||
|
}
|
||||||
|
Vec3f vec3_from_json(const nlohmann::json &j, const Vec3f &fallback)
|
||||||
|
{
|
||||||
|
if (!j.is_array() || j.size() != 3)
|
||||||
|
return fallback;
|
||||||
|
return Vec3f(j[0].get<float>(), j[1].get<float>(), j[2].get<float>());
|
||||||
|
}
|
||||||
|
|
||||||
|
// Reads key `k` into `out` when it is present and of the expected type, leaving `out` alone otherwise.
|
||||||
|
// That "leave it alone" is the whole point: every member starts at its struct default, so a project
|
||||||
|
// written by an older build simply keeps the defaults for whatever it did not know about.
|
||||||
|
template<class T> void read(const nlohmann::json &j, const char *k, T &out)
|
||||||
|
{
|
||||||
|
const auto it = j.find(k);
|
||||||
|
if (it == j.end())
|
||||||
|
return;
|
||||||
|
try {
|
||||||
|
out = it->get<T>();
|
||||||
|
} catch (...) {
|
||||||
|
}
|
||||||
|
}
|
||||||
|
void read_enum(const nlohmann::json &j, const char *k, int &out)
|
||||||
|
{
|
||||||
|
const auto it = j.find(k);
|
||||||
|
if (it != j.end() && it->is_number_integer())
|
||||||
|
out = it->get<int>();
|
||||||
|
}
|
||||||
|
|
||||||
|
} // namespace
|
||||||
|
|
||||||
|
std::string texture_displacement_layers_to_json(const std::vector<TextureDisplacementLayer> &layers,
|
||||||
|
const TextureDisplacementOptions &options)
|
||||||
|
{
|
||||||
|
nlohmann::json root;
|
||||||
|
root["version"] = 1;
|
||||||
|
|
||||||
|
nlohmann::json &opt = root["options"];
|
||||||
|
opt["displace_border"] = options.displace_border;
|
||||||
|
opt["smooth_enabled"] = options.smooth_enabled;
|
||||||
|
opt["smooth_strength"] = options.smooth_strength;
|
||||||
|
opt["smooth_iterations"] = options.smooth_iterations;
|
||||||
|
opt["smooth_skip_border"] = options.smooth_skip_border;
|
||||||
|
opt["pipeline_v2"] = options.pipeline_v2;
|
||||||
|
opt["v2_refine_mm"] = options.v2_refine_mm;
|
||||||
|
opt["v2_regularize"] = options.v2_regularize;
|
||||||
|
opt["v2_max_triangles_k"] = options.v2_max_triangles_k;
|
||||||
|
opt["v2_relocate"] = options.v2_relocate;
|
||||||
|
opt["v2_flip_edges"] = options.v2_flip_edges;
|
||||||
|
opt["color_mix_enabled"] = options.color_mix_enabled;
|
||||||
|
opt["color_despeckle"] = options.color_despeckle;
|
||||||
|
opt["color_mix_count"] = options.color_mix_count;
|
||||||
|
opt["active_slot"] = options.active_slot;
|
||||||
|
opt["panel_mode"] = options.panel_mode;
|
||||||
|
|
||||||
|
nlohmann::json &arr = root["layers"];
|
||||||
|
arr = nlohmann::json::array();
|
||||||
|
for (const TextureDisplacementLayer &l : layers) {
|
||||||
|
nlohmann::json j;
|
||||||
|
j["slot"] = l.slot;
|
||||||
|
j["name"] = l.name;
|
||||||
|
j["path"] = l.path;
|
||||||
|
j["path_in_3mf"] = l.path_in_3mf;
|
||||||
|
|
||||||
|
j["depth_mm"] = l.depth_mm;
|
||||||
|
j["tiling_scale"] = l.tiling_scale;
|
||||||
|
j["rotation_deg"] = l.rotation_deg;
|
||||||
|
j["offset"] = vec2_to_json(l.offset);
|
||||||
|
j["invert"] = l.invert;
|
||||||
|
j["midlevel"] = l.midlevel;
|
||||||
|
j["smoothing"] = l.smoothing;
|
||||||
|
|
||||||
|
j["edge_smoothing"] = l.edge_smoothing;
|
||||||
|
j["edge_smoothing_amount"] = l.edge_smoothing_amount;
|
||||||
|
j["auto_connect_islands"] = l.auto_connect_islands;
|
||||||
|
|
||||||
|
j["tile_enabled"] = l.tile_enabled;
|
||||||
|
j["tile_method"] = int(l.tile_method);
|
||||||
|
j["projection_method"] = int(l.projection_method);
|
||||||
|
j["blend_mode"] = int(l.blend_mode);
|
||||||
|
j["color_enabled"] = l.color_enabled;
|
||||||
|
|
||||||
|
j["lscm_seam_angle_deg"] = l.lscm_seam_angle_deg;
|
||||||
|
j["island_padding_mm"] = l.island_padding_mm;
|
||||||
|
|
||||||
|
j["view_project_right"] = vec3_to_json(l.view_project_right);
|
||||||
|
j["view_project_up"] = vec3_to_json(l.view_project_up);
|
||||||
|
j["view_project_projective"] = l.view_project_projective;
|
||||||
|
j["view_project_matrix"] = l.view_project_matrix;
|
||||||
|
|
||||||
|
// Flat pairs rather than nested arrays: shorter, and the reader can simply ignore a trailing
|
||||||
|
// odd element instead of having to validate every sub-array.
|
||||||
|
nlohmann::json &seams = j["lscm_seam_edges"];
|
||||||
|
seams = nlohmann::json::array();
|
||||||
|
for (const auto &[a, b] : l.lscm_seam_edges) {
|
||||||
|
seams.push_back(a);
|
||||||
|
seams.push_back(b);
|
||||||
|
}
|
||||||
|
|
||||||
|
nlohmann::json &islands = j["islands"];
|
||||||
|
islands = nlohmann::json::array();
|
||||||
|
for (const TextureIsland &island : l.islands)
|
||||||
|
islands.push_back(nlohmann::json::array(
|
||||||
|
{ island.offset.x(), island.offset.y(), island.rotation_deg, island.scale }));
|
||||||
|
|
||||||
|
j["island_groups"] = l.island_groups;
|
||||||
|
|
||||||
|
nlohmann::json &overrides = j["lscm_uv_overrides"];
|
||||||
|
overrides = nlohmann::json::array();
|
||||||
|
for (const auto &[key, uv] : l.lscm_uv_overrides)
|
||||||
|
overrides.push_back(nlohmann::json::array({ key, uv.x(), uv.y() }));
|
||||||
|
|
||||||
|
arr.push_back(std::move(j));
|
||||||
|
}
|
||||||
|
return root.dump();
|
||||||
|
}
|
||||||
|
|
||||||
|
bool texture_displacement_layers_from_json(const std::string &text,
|
||||||
|
std::vector<TextureDisplacementLayer> &layers,
|
||||||
|
TextureDisplacementOptions &options)
|
||||||
|
{
|
||||||
|
nlohmann::json root;
|
||||||
|
try {
|
||||||
|
root = nlohmann::json::parse(text);
|
||||||
|
} catch (...) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
if (!root.is_object())
|
||||||
|
return false;
|
||||||
|
|
||||||
|
TextureDisplacementOptions out_options;
|
||||||
|
if (const auto it = root.find("options"); it != root.end() && it->is_object()) {
|
||||||
|
const nlohmann::json &opt = *it;
|
||||||
|
read(opt, "displace_border", out_options.displace_border);
|
||||||
|
read(opt, "smooth_enabled", out_options.smooth_enabled);
|
||||||
|
read(opt, "smooth_strength", out_options.smooth_strength);
|
||||||
|
read(opt, "smooth_iterations", out_options.smooth_iterations);
|
||||||
|
read(opt, "smooth_skip_border", out_options.smooth_skip_border);
|
||||||
|
read(opt, "pipeline_v2", out_options.pipeline_v2);
|
||||||
|
read(opt, "v2_refine_mm", out_options.v2_refine_mm);
|
||||||
|
read(opt, "v2_regularize", out_options.v2_regularize);
|
||||||
|
read(opt, "v2_max_triangles_k", out_options.v2_max_triangles_k);
|
||||||
|
read(opt, "v2_relocate", out_options.v2_relocate);
|
||||||
|
read(opt, "v2_flip_edges", out_options.v2_flip_edges);
|
||||||
|
read(opt, "color_mix_enabled", out_options.color_mix_enabled);
|
||||||
|
read(opt, "color_despeckle", out_options.color_despeckle);
|
||||||
|
read(opt, "color_mix_count", out_options.color_mix_count);
|
||||||
|
read(opt, "active_slot", out_options.active_slot);
|
||||||
|
read(opt, "panel_mode", out_options.panel_mode);
|
||||||
|
out_options.active_slot = std::clamp(out_options.active_slot, 0, int(TEXTURE_DISPLACEMENT_MAX_LAYERS) - 1);
|
||||||
|
out_options.panel_mode = std::clamp(out_options.panel_mode, 0, 1);
|
||||||
|
}
|
||||||
|
|
||||||
|
std::vector<TextureDisplacementLayer> out_layers;
|
||||||
|
// read() skips a value of the wrong type, but the vector, matrix, seam, island and UV-override arrays
|
||||||
|
// below read their numbers with get<>(), which throws on one; that rejects the document, like text that
|
||||||
|
// does not parse.
|
||||||
|
try {
|
||||||
|
if (const auto it = root.find("layers"); it != root.end() && it->is_array()) {
|
||||||
|
for (const nlohmann::json &j : *it) {
|
||||||
|
if (!j.is_object())
|
||||||
|
continue;
|
||||||
|
TextureDisplacementLayer l;
|
||||||
|
read(j, "slot", l.slot);
|
||||||
|
// The panel and the paint masks are indexed by slot, so a layer without a valid one rejects the
|
||||||
|
// document rather than reaching them.
|
||||||
|
if (l.slot < 0 || l.slot >= int(TEXTURE_DISPLACEMENT_MAX_LAYERS))
|
||||||
|
return false;
|
||||||
|
read(j, "name", l.name);
|
||||||
|
read(j, "path", l.path);
|
||||||
|
read(j, "path_in_3mf", l.path_in_3mf);
|
||||||
|
|
||||||
|
read(j, "depth_mm", l.depth_mm);
|
||||||
|
read(j, "tiling_scale", l.tiling_scale);
|
||||||
|
read(j, "rotation_deg", l.rotation_deg);
|
||||||
|
if (const auto o = j.find("offset"); o != j.end())
|
||||||
|
l.offset = vec2_from_json(*o, l.offset);
|
||||||
|
read(j, "invert", l.invert);
|
||||||
|
read(j, "midlevel", l.midlevel);
|
||||||
|
read(j, "smoothing", l.smoothing);
|
||||||
|
|
||||||
|
read(j, "edge_smoothing", l.edge_smoothing);
|
||||||
|
read(j, "edge_smoothing_amount", l.edge_smoothing_amount);
|
||||||
|
read(j, "auto_connect_islands", l.auto_connect_islands);
|
||||||
|
|
||||||
|
read(j, "tile_enabled", l.tile_enabled);
|
||||||
|
read(j, "color_enabled", l.color_enabled);
|
||||||
|
int tile_method = int(l.tile_method), projection = int(l.projection_method), blend = int(l.blend_mode);
|
||||||
|
read_enum(j, "tile_method", tile_method);
|
||||||
|
read_enum(j, "projection_method", projection);
|
||||||
|
read_enum(j, "blend_mode", blend);
|
||||||
|
l.tile_method = TextureTileMethod(tile_method);
|
||||||
|
l.projection_method = TextureProjectionMethod(std::clamp(projection, 0, 4));
|
||||||
|
l.blend_mode = TextureBlendMode(blend);
|
||||||
|
|
||||||
|
read(j, "lscm_seam_angle_deg", l.lscm_seam_angle_deg);
|
||||||
|
read(j, "island_padding_mm", l.island_padding_mm);
|
||||||
|
|
||||||
|
if (const auto v = j.find("view_project_right"); v != j.end())
|
||||||
|
l.view_project_right = vec3_from_json(*v, l.view_project_right);
|
||||||
|
if (const auto v = j.find("view_project_up"); v != j.end())
|
||||||
|
l.view_project_up = vec3_from_json(*v, l.view_project_up);
|
||||||
|
read(j, "view_project_projective", l.view_project_projective);
|
||||||
|
if (const auto v = j.find("view_project_matrix"); v != j.end() && v->is_array() && v->size() == 12)
|
||||||
|
for (size_t i = 0; i < 12; ++i)
|
||||||
|
l.view_project_matrix[i] = (*v)[i].get<float>();
|
||||||
|
|
||||||
|
if (const auto v = j.find("lscm_seam_edges"); v != j.end() && v->is_array())
|
||||||
|
for (size_t i = 0; i + 1 < v->size(); i += 2)
|
||||||
|
l.lscm_seam_edges.emplace_back((*v)[i].get<int>(), (*v)[i + 1].get<int>());
|
||||||
|
|
||||||
|
if (const auto v = j.find("islands"); v != j.end() && v->is_array())
|
||||||
|
for (const nlohmann::json &e : *v) {
|
||||||
|
if (!e.is_array() || e.size() != 4)
|
||||||
|
continue;
|
||||||
|
TextureIsland island;
|
||||||
|
island.offset = Vec2f(e[0].get<float>(), e[1].get<float>());
|
||||||
|
island.rotation_deg = e[2].get<float>();
|
||||||
|
island.scale = e[3].get<float>();
|
||||||
|
l.islands.push_back(island);
|
||||||
|
}
|
||||||
|
|
||||||
|
read(j, "island_groups", l.island_groups);
|
||||||
|
|
||||||
|
if (const auto v = j.find("lscm_uv_overrides"); v != j.end() && v->is_array())
|
||||||
|
for (const nlohmann::json &e : *v) {
|
||||||
|
if (!e.is_array() || e.size() != 3)
|
||||||
|
continue;
|
||||||
|
l.lscm_uv_overrides.emplace_back(e[0].get<int>(), Vec2f(e[1].get<float>(), e[2].get<float>()));
|
||||||
|
}
|
||||||
|
|
||||||
|
out_layers.push_back(std::move(l));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
} catch (const nlohmann::json::exception &) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
layers = std::move(out_layers);
|
||||||
|
options = out_options;
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
} // namespace Slic3r
|
} // namespace Slic3r
|
||||||
|
|||||||
@@ -154,6 +154,38 @@ struct TextureIsland
|
|||||||
// chart to its true mm area, so a freshly unwrapped patch has uniform texel density to begin with.
|
// chart to its true mm area, so a freshly unwrapped patch has uniform texel density to begin with.
|
||||||
void average_island_scales(std::vector<TextureIsland> &islands);
|
void average_island_scales(std::vector<TextureIsland> &islands);
|
||||||
|
|
||||||
|
// Photo-style adjustments to a layer's source image, as the gizmo's image-adjustment panel sets them.
|
||||||
|
//
|
||||||
|
// These are *not* layer parameters: nothing here is stored on TextureDisplacementLayer and nothing here is
|
||||||
|
// re-applied at bake time. The panel applies them once, to the image, and the result becomes the layer's
|
||||||
|
// image - so the adjusted pixels feed the colour and the displacement together, and a brightness change
|
||||||
|
// really does change the relief. That is the intended behaviour: one image, one source of truth, rather
|
||||||
|
// than a second set of knobs the bake would have to replay in the right order.
|
||||||
|
//
|
||||||
|
// Contrast with TextureDisplacementLayer::smoothing, which *is* a layer parameter applied on every decode:
|
||||||
|
// `blur` here is a destructive edit of the image, `smoothing` is a live low-pass over whatever the image is.
|
||||||
|
struct TextureAdjustments
|
||||||
|
{
|
||||||
|
float brightness = 0.f; // [-1, 1]; 0 unchanged, -1 black, +1 white
|
||||||
|
float contrast = 0.f; // [-1, 1]; 0 unchanged, -1 flat mid-grey, +1 hard threshold
|
||||||
|
float sharpness = 0.f; // [0, 1]; 0 unchanged. Unsharp-mask amount
|
||||||
|
float blur = 0.f; // [0, 1]; 0 unchanged. Fraction of SOURCE_BLUR_SPAN, as `smoothing` is
|
||||||
|
float hue_deg = 0.f; // [-180, 180]; 0 unchanged. No effect on a grayscale image - grey has no hue
|
||||||
|
|
||||||
|
bool identity() const
|
||||||
|
{
|
||||||
|
return brightness == 0.f && contrast == 0.f && sharpness == 0.f && blur == 0.f && hue_deg == 0.f;
|
||||||
|
}
|
||||||
|
// Exact equality, which is what is wanted: these come straight off sliders, and the question asked of
|
||||||
|
// them is "is this still the value the preview on screen was computed from", not "are these close".
|
||||||
|
bool operator==(const TextureAdjustments &o) const
|
||||||
|
{
|
||||||
|
return brightness == o.brightness && contrast == o.contrast && sharpness == o.sharpness &&
|
||||||
|
blur == o.blur && hue_deg == o.hue_deg;
|
||||||
|
}
|
||||||
|
bool operator!=(const TextureAdjustments &o) const { return !(*this == o); }
|
||||||
|
};
|
||||||
|
|
||||||
// One texture asset plus its projection/displacement parameters. Several layers may be painted
|
// One texture asset plus its projection/displacement parameters. Several layers may be painted
|
||||||
// onto overlapping areas of the same volume: their displacements are combined per vertex, in slot
|
// onto overlapping areas of the same volume: their displacements are combined per vertex, in slot
|
||||||
// order, each layer folding into the total via its own TextureBlendMode (see
|
// order, each layer folding into the total via its own TextureBlendMode (see
|
||||||
@@ -277,6 +309,18 @@ struct TextureDisplacementLayer
|
|||||||
// - zero or positive: a mesh vertex, every unwrapped copy of it (how edits were stored before).
|
// - zero or positive: a mesh vertex, every unwrapped copy of it (how edits were stored before).
|
||||||
std::vector<std::pair<int, Vec2f>> lscm_uv_overrides;
|
std::vector<std::pair<int, Vec2f>> lscm_uv_overrides;
|
||||||
|
|
||||||
|
// Live, unsaved image adjustments from the gizmo's image-adjustment panel, applied by
|
||||||
|
// decode_height_texture() on top of the decoded image - so while the panel is open the relief, the
|
||||||
|
// colour, the thumbnails and the bake all see the adjusted image, and moving a slider really does
|
||||||
|
// change the displacement. See TextureAdjustments.
|
||||||
|
//
|
||||||
|
// Deliberately *not* serialized, by either save()/load() here or the .3mf: it is the state of an open
|
||||||
|
// editor, not a property of the layer. The panel resets it when it closes, and "Save as copy" resolves
|
||||||
|
// it by writing a new image and pointing the layer at that - which is the only way an adjustment
|
||||||
|
// becomes permanent. A project saved mid-adjustment therefore stores the unadjusted image, which is
|
||||||
|
// the honest answer: nothing was committed.
|
||||||
|
TextureAdjustments preview_adjust;
|
||||||
|
|
||||||
// How this layer folds into the displacement accumulated by the layers below it. Ignored for
|
// How this layer folds into the displacement accumulated by the layers below it. Ignored for
|
||||||
// the lowest-slot painted layer, which has nothing beneath it to combine with (the GUI shows
|
// the lowest-slot painted layer, which has nothing beneath it to combine with (the GUI shows
|
||||||
// it as the "Base" layer and hides the control).
|
// it as the "Base" layer and hides the control).
|
||||||
@@ -397,14 +441,41 @@ struct TextureDisplacementOptions
|
|||||||
// finer than the mesh leaves behind, without eating features that are genuinely a facet wide.
|
// finer than the mesh leaves behind, without eating features that are genuinely a facet wide.
|
||||||
int color_despeckle = 2;
|
int color_despeckle = 2;
|
||||||
|
|
||||||
|
// Where the panel was left, rather than anything the bake reads. It lives with the volume because
|
||||||
|
// that is what it describes: reopening a project should put the user back on the layer they were
|
||||||
|
// editing, in the mode they were editing it in, not on slot 0 in Standard.
|
||||||
|
int active_slot = 0;
|
||||||
|
int panel_mode = 0; // 0 Standard, 1 Pro
|
||||||
|
|
||||||
template<class Archive> void serialize(Archive &ar)
|
template<class Archive> void serialize(Archive &ar)
|
||||||
{
|
{
|
||||||
ar(displace_border, smooth_enabled, smooth_strength, smooth_iterations, smooth_skip_border,
|
ar(displace_border, smooth_enabled, smooth_strength, smooth_iterations, smooth_skip_border,
|
||||||
pipeline_v2, v2_refine_mm, v2_regularize, v2_max_triangles_k,
|
pipeline_v2, v2_refine_mm, v2_regularize, v2_max_triangles_k,
|
||||||
v2_relocate, color_mix_enabled, color_despeckle, color_mix_count);
|
v2_relocate, v2_flip_edges, color_mix_enabled, color_despeckle, color_mix_count,
|
||||||
|
active_slot, panel_mode);
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
|
// Project persistence (see bbs_3mf.cpp). The layer stack and the per-volume options are written to the
|
||||||
|
// .3mf as JSON rather than through the cereal save()/load() above: those two are positional and
|
||||||
|
// unversioned, which is right for the undo/redo stack they serve (one session, one binary) but would
|
||||||
|
// make every future field a project-breaking change. A JSON object tolerates both directions - an
|
||||||
|
// unknown key is ignored, a missing one keeps the member's default - so old projects keep loading and
|
||||||
|
// new ones degrade gracefully in older builds.
|
||||||
|
//
|
||||||
|
// The texture image itself is *not* in here. It is a binary blob that belongs in the archive as a file
|
||||||
|
// of its own, exactly as EmbossShape stores its SVG; `path_in_3mf` names that file, and the caller is
|
||||||
|
// responsible for writing it and for filling `image_data` back in on load.
|
||||||
|
std::string texture_displacement_layers_to_json(const std::vector<TextureDisplacementLayer> &layers,
|
||||||
|
const TextureDisplacementOptions &options);
|
||||||
|
// Returns false and leaves both outputs untouched when the text is not a valid JSON object, a number in a
|
||||||
|
// layer's vector, matrix, seam, island or UV-override array has the wrong type, or a layer's slot is
|
||||||
|
// missing or outside [0, TEXTURE_DISPLACEMENT_MAX_LAYERS). Any other value of the wrong type or shape
|
||||||
|
// keeps its default.
|
||||||
|
bool texture_displacement_layers_from_json(const std::string &text,
|
||||||
|
std::vector<TextureDisplacementLayer> &layers,
|
||||||
|
TextureDisplacementOptions &options);
|
||||||
|
|
||||||
// How much detail a height texture carries: central differences of the grey image, the mean gradient
|
// How much detail a height texture carries: central differences of the grey image, the mean gradient
|
||||||
// and the share of texels steeper than 30 grey levels, mapped to how many texels one mesh edge may
|
// and the share of texels steeper than 30 grey levels, mapped to how many texels one mesh edge may
|
||||||
// span (1 for a hard-edged image, 4 for a smooth one). Cached per image, like the decode.
|
// span (1 for a hard-edged image, 4 for a smooth one). Cached per image, like the decode.
|
||||||
@@ -477,6 +548,36 @@ struct DecodedHeightTexture
|
|||||||
bool texel_tap(const Vec2f &uv, bool tile_enabled, TextureTileMethod tile_method, TexelTap &out) const;
|
bool texel_tap(const Vec2f &uv, bool tile_enabled, TextureTileMethod tile_method, TexelTap &out) const;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
// Applies `adj` to `src` and returns the result; `src` is left alone. An empty `src`, or an identity
|
||||||
|
// `adj`, gives back a copy.
|
||||||
|
//
|
||||||
|
// Order is tonal, then spatial: brightness, contrast and hue per texel first, then blur, then sharpness.
|
||||||
|
// Sharpness last is what lets the two spatial knobs be used together - blur to kill speckle, then
|
||||||
|
// sharpness to put the real edges back - instead of the blur simply undoing the sharpen.
|
||||||
|
//
|
||||||
|
// Grayscale in, grayscale out (`rgb` stays empty): promoting a grey image to RGB would hand the layer's
|
||||||
|
// colour feature a row of identical greys to "colour" the model with, and triple the stored PNG for it.
|
||||||
|
// For a colour image the height is recomputed as the luminance of the *adjusted* colour, with
|
||||||
|
// decode_height_texture()'s own coefficients, so the relief and the colour can never drift apart.
|
||||||
|
DecodedHeightTexture apply_texture_adjustments(const DecodedHeightTexture &src, const TextureAdjustments &adj);
|
||||||
|
|
||||||
|
// Blur radius, in texels, that TextureAdjustments::blur == 1 means on a `min(width, height)`-sized image:
|
||||||
|
// the same 5%-of-the-short-side span the Smoothing slider uses, under the same 48-texel cost cap, so the
|
||||||
|
// two controls bite at the same rate and a user moving between them is not surprised.
|
||||||
|
float adjustment_blur_radius(float blur, int width, int height);
|
||||||
|
|
||||||
|
// Box-filters `src` down so neither side exceeds `max_px`, preserving aspect; never upscales, and
|
||||||
|
// returns a copy when it already fits. Colour and height are filtered the same way, and the height
|
||||||
|
// stays the height - it is not recomputed from the filtered colour, because a box filter is linear and
|
||||||
|
// luminance is linear in the channels, so the two agree already.
|
||||||
|
//
|
||||||
|
// This is what lets the adjustment panel's live preview cost depend on the size of the box it is drawn
|
||||||
|
// in rather than on the size of the image: adjusting a downscaled copy per slider frame, and the
|
||||||
|
// full-size image only once, on commit. A box filter (rather than a plain decimation) is the point -
|
||||||
|
// these textures are high-frequency by nature, and dropping texels would alias the preview into
|
||||||
|
// showing detail the adjustment is not actually producing.
|
||||||
|
DecodedHeightTexture downscale_height_texture(const DecodedHeightTexture &src, int max_px);
|
||||||
|
|
||||||
// Decode a layer's raw image bytes into sampleable height data, plus colour when the source has any.
|
// Decode a layer's raw image bytes into sampleable height data, plus colour when the source has any.
|
||||||
// Both 8-bit grayscale PNGs (the shipped library, and anything imported before colour was kept) and
|
// Both 8-bit grayscale PNGs (the shipped library, and anything imported before colour was kept) and
|
||||||
// colour PNGs are accepted; for a colour source the height is its luminance, using the same
|
// colour PNGs are accepted; for a colour source the height is its luminance, using the same
|
||||||
@@ -524,11 +625,24 @@ struct TextureColorSettings
|
|||||||
bool empty() const { return palette.empty(); }
|
bool empty() const { return palette.empty(); }
|
||||||
};
|
};
|
||||||
|
|
||||||
|
// The two world directions the box projection takes its u and v along on a face whose outward
|
||||||
|
// normal is `normal`: the plane is the one that normal is closest to, and the pair is oriented as a
|
||||||
|
// viewer standing outside the model sees it - u to their right, v *down* the image, which is the
|
||||||
|
// direction v runs in the texture (v = 0 is the image's first pixel row, see
|
||||||
|
// DecodedHeightTexture::sample()). So an image comes out the way it looks in a file manager rather
|
||||||
|
// than upside down, and it is not mirrored on the three faces facing the other way.
|
||||||
|
//
|
||||||
|
// Exposed because the GUI needs the same basis for the on-canvas "adjust texture placement" gizmo
|
||||||
|
// (its ring's zero angle and its offset handle's plane), and it must not be a second, drifting copy
|
||||||
|
// of the table.
|
||||||
|
void box_projection_axes(const Vec3f &normal, Vec3f &u_axis, Vec3f &v_axis);
|
||||||
|
|
||||||
// Raw dominant-axis planar projection of `position` (in mm, not yet scaled/rotated/offset by any
|
// Raw dominant-axis planar projection of `position` (in mm, not yet scaled/rotated/offset by any
|
||||||
// layer), dropping the axis position that best aligns with `normal`. Exposed on its own (rather
|
// layer), dropping the axis position that best aligns with `normal`. Equivalent to projecting onto
|
||||||
// than only inline inside project_texture_displacement_uv()) so GUI code - the on-canvas
|
// box_projection_axes()' pair. Exposed on its own (rather than only inline inside
|
||||||
// "adjust texture placement" gizmo - can map a dragged 3D point into the exact same 2D space
|
// project_texture_displacement_uv()) so GUI code - the on-canvas "adjust texture placement" gizmo -
|
||||||
// tiling_scale/rotation_deg/offset operate in, without duplicating the axis-selection logic.
|
// can map a dragged 3D point into the exact same 2D space tiling_scale/rotation_deg/offset operate
|
||||||
|
// in, without duplicating the axis-selection logic.
|
||||||
Vec2f project_planar(const Vec3f &position, const Vec3f &normal);
|
Vec2f project_planar(const Vec3f &position, const Vec3f &normal);
|
||||||
|
|
||||||
// Applies a layer's tiling_scale/rotation_deg/offset to an already-projected planar coordinate
|
// Applies a layer's tiling_scale/rotation_deg/offset to an already-projected planar coordinate
|
||||||
|
|||||||
@@ -673,14 +673,14 @@ static bool repair_cluster_smooth(
|
|||||||
[&]() { return cancelled(); }, &repair_error);
|
[&]() { return cancelled(); }, &repair_error);
|
||||||
if (repaired) {
|
if (repaired) {
|
||||||
if (cancelled()) return false;
|
if (cancelled()) return false;
|
||||||
BOOST_LOG_TRIVIAL(info) << log_prefix << ": Windows 3D mesh repair finished.";
|
BOOST_LOG_TRIVIAL(info) << log_prefix << ": mesh repair finished.";
|
||||||
if (!resample_face_colors(TriMesh(std::move(repaired_its))))
|
if (!resample_face_colors(TriMesh(std::move(repaired_its))))
|
||||||
return false;
|
return false;
|
||||||
} else {
|
} else {
|
||||||
BOOST_LOG_TRIVIAL(warning) << log_prefix << ": Windows 3D mesh repair failed: " << repair_error;
|
BOOST_LOG_TRIVIAL(warning) << log_prefix << ": mesh repair failed: " << repair_error;
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
BOOST_LOG_TRIVIAL(info) << log_prefix << ": importing mesh without Windows 3D repair.";
|
BOOST_LOG_TRIVIAL(info) << log_prefix << ": importing mesh without repair.";
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,5 +1,4 @@
|
|||||||
#ifndef libslic3r_Timer_hpp_
|
#pragma once
|
||||||
#define libslic3r_Timer_hpp_
|
|
||||||
|
|
||||||
#include "TriangleMesh.hpp"
|
#include "TriangleMesh.hpp"
|
||||||
|
|
||||||
@@ -10,5 +9,3 @@ public:
|
|||||||
static TriangleMesh smooth_triangle_mesh(const TriangleMesh &mesh,bool& ok);
|
static TriangleMesh smooth_triangle_mesh(const TriangleMesh &mesh,bool& ok);
|
||||||
};
|
};
|
||||||
} // namespace Slic3r
|
} // namespace Slic3r
|
||||||
|
|
||||||
#endif // libslic3r_Timer_hpp_
|
|
||||||
|
|||||||
@@ -109,7 +109,6 @@ extern std::string format_memsize_MB(size_t n);
|
|||||||
extern std::string format_memsize(size_t bytes, unsigned int decimals = 1);
|
extern std::string format_memsize(size_t bytes, unsigned int decimals = 1);
|
||||||
// Return string to be added to the boost::log output to inform about the current process memory allocation.
|
// Return string to be added to the boost::log output to inform about the current process memory allocation.
|
||||||
// The string is non-empty if the loglevel >= info (3) or ignore_loglevel==true.
|
// The string is non-empty if the loglevel >= info (3) or ignore_loglevel==true.
|
||||||
// Latter is used to get the memory info from SysInfoDialog.
|
|
||||||
extern std::string log_memory_info(bool ignore_loglevel = false);
|
extern std::string log_memory_info(bool ignore_loglevel = false);
|
||||||
extern void disable_multi_threading();
|
extern void disable_multi_threading();
|
||||||
// Returns the size of physical memory (RAM) in bytes.
|
// Returns the size of physical memory (RAM) in bytes.
|
||||||
|
|||||||
@@ -1744,9 +1744,7 @@ std::string format_diameter_to_str(double diameter, int precision)
|
|||||||
return oss.str();
|
return oss.str();
|
||||||
}
|
}
|
||||||
|
|
||||||
// Returns platform-specific string to be used as log output or parsed in SysInfoDialog.
|
// Returns platform-specific string to be used as log output.
|
||||||
// The latter parses the string with (semi)colons as separators, it should look about as
|
|
||||||
// "desc1: value1; desc2: value2" or similar (spaces should not matter).
|
|
||||||
std::string log_memory_info(bool ignore_loglevel)
|
std::string log_memory_info(bool ignore_loglevel)
|
||||||
{
|
{
|
||||||
std::string out;
|
std::string out;
|
||||||
|
|||||||
@@ -21,7 +21,9 @@ namespace libvgcode {
|
|||||||
// the triangles that share it: the shader runs 8 times per segment instead of 24.
|
// the triangles that share it: the shader runs 8 times per segment instead of 24.
|
||||||
static constexpr const std::array<uint8_t, 8> VERTEX_DATA = { 0, 1, 2, 3, 4, 5, 6, 7 };
|
static constexpr const std::array<uint8_t, 8> VERTEX_DATA = { 0, 1, 2, 3, 4, 5, 6, 7 };
|
||||||
|
|
||||||
static constexpr const std::array<uint8_t, 24> INDEX_DATA = {
|
// 16-bit indices: GCN 1/2 GPUs have no 8-bit index support, and some of their drivers
|
||||||
|
// emulate it wrongly in instanced draws.
|
||||||
|
static constexpr const std::array<uint16_t, 24> INDEX_DATA = {
|
||||||
0, 1, 2, // front spike
|
0, 1, 2, // front spike
|
||||||
0, 2, 3, // front spike
|
0, 2, 3, // front spike
|
||||||
0, 3, 4, // right/bottom body
|
0, 3, 4, // right/bottom body
|
||||||
@@ -37,7 +39,7 @@ void SegmentTemplate::init()
|
|||||||
if (m_vao_id != 0)
|
if (m_vao_id != 0)
|
||||||
return;
|
return;
|
||||||
|
|
||||||
m_size_in_bytes_gpu += (VERTEX_DATA.size() + INDEX_DATA.size()) * sizeof(uint8_t);
|
m_size_in_bytes_gpu += VERTEX_DATA.size() * sizeof(uint8_t) + INDEX_DATA.size() * sizeof(uint16_t);
|
||||||
|
|
||||||
int curr_vertex_array;
|
int curr_vertex_array;
|
||||||
glsafe(glGetIntegerv(GL_VERTEX_ARRAY_BINDING, &curr_vertex_array));
|
glsafe(glGetIntegerv(GL_VERTEX_ARRAY_BINDING, &curr_vertex_array));
|
||||||
@@ -61,7 +63,7 @@ void SegmentTemplate::init()
|
|||||||
// and restored together with the vao.
|
// and restored together with the vao.
|
||||||
glsafe(glGenBuffers(1, &m_ibo_id));
|
glsafe(glGenBuffers(1, &m_ibo_id));
|
||||||
glsafe(glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, m_ibo_id));
|
glsafe(glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, m_ibo_id));
|
||||||
glsafe(glBufferData(GL_ELEMENT_ARRAY_BUFFER, INDEX_DATA.size() * sizeof(uint8_t), INDEX_DATA.data(), GL_STATIC_DRAW));
|
glsafe(glBufferData(GL_ELEMENT_ARRAY_BUFFER, INDEX_DATA.size() * sizeof(uint16_t), INDEX_DATA.data(), GL_STATIC_DRAW));
|
||||||
|
|
||||||
glsafe(glBindBuffer(GL_ARRAY_BUFFER, curr_array_buffer));
|
glsafe(glBindBuffer(GL_ARRAY_BUFFER, curr_array_buffer));
|
||||||
glsafe(glBindVertexArray(curr_vertex_array));
|
glsafe(glBindVertexArray(curr_vertex_array));
|
||||||
@@ -94,7 +96,7 @@ void SegmentTemplate::render(size_t count)
|
|||||||
glsafe(glGetIntegerv(GL_VERTEX_ARRAY_BINDING, &curr_vertex_array));
|
glsafe(glGetIntegerv(GL_VERTEX_ARRAY_BINDING, &curr_vertex_array));
|
||||||
|
|
||||||
glsafe(glBindVertexArray(m_vao_id));
|
glsafe(glBindVertexArray(m_vao_id));
|
||||||
glsafe(glDrawElementsInstanced(GL_TRIANGLES, static_cast<GLsizei>(INDEX_DATA.size()), GL_UNSIGNED_BYTE,
|
glsafe(glDrawElementsInstanced(GL_TRIANGLES, static_cast<GLsizei>(INDEX_DATA.size()), GL_UNSIGNED_SHORT,
|
||||||
nullptr, static_cast<GLsizei>(count)));
|
nullptr, static_cast<GLsizei>(count)));
|
||||||
glsafe(glBindVertexArray(curr_vertex_array));
|
glsafe(glBindVertexArray(curr_vertex_array));
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -927,15 +927,17 @@ void ViewerImpl::reset()
|
|||||||
m_used_extruders.clear();
|
m_used_extruders.clear();
|
||||||
m_total_time = { 0.0f, 0.0f };
|
m_total_time = { 0.0f, 0.0f };
|
||||||
m_travels_time = { 0.0f, 0.0f };
|
m_travels_time = { 0.0f, 0.0f };
|
||||||
m_vertices.clear();
|
|
||||||
m_vertices_colors.clear();
|
|
||||||
// swap rather than clear: these are sized by the print, and a reset means the memory
|
// swap rather than clear: these are sized by the print, and a reset means the memory
|
||||||
// should go back, not sit reserved until the next load
|
// should go back, not sit reserved until the next load
|
||||||
|
std::vector<PathVertex>().swap(m_vertices);
|
||||||
|
std::vector<float>().swap(m_vertices_colors);
|
||||||
for (std::vector<float>& times : m_layer_start_times)
|
for (std::vector<float>& times : m_layer_start_times)
|
||||||
std::vector<float>().swap(times);
|
std::vector<float>().swap(times);
|
||||||
std::vector<uint32_t>().swap(m_layer_first_vertex);
|
std::vector<uint32_t>().swap(m_layer_first_vertex);
|
||||||
m_layers_in_vertex_order = false;
|
m_layers_in_vertex_order = false;
|
||||||
m_valid_lines_bitset.clear();
|
// BitSet::clear() only zeroes the bits, it keeps the blocks allocated; load() builds a new
|
||||||
|
// bitset anyway and it is never read while m_vertices is empty
|
||||||
|
m_valid_lines_bitset = BitSet<>();
|
||||||
#if VGCODE_ENABLE_COG_AND_TOOL_MARKERS
|
#if VGCODE_ENABLE_COG_AND_TOOL_MARKERS
|
||||||
m_cog_marker.reset();
|
m_cog_marker.reset();
|
||||||
#endif // VGCODE_ENABLE_COG_AND_TOOL_MARKERS
|
#endif // VGCODE_ENABLE_COG_AND_TOOL_MARKERS
|
||||||
@@ -1834,6 +1836,7 @@ size_t ViewerImpl::get_used_cpu_memory() const
|
|||||||
ret += sizeof(m_extrusion_roles_colors);
|
ret += sizeof(m_extrusion_roles_colors);
|
||||||
ret += sizeof(m_options_colors);
|
ret += sizeof(m_options_colors);
|
||||||
ret += STDVEC_MEMSIZE(m_vertices, PathVertex);
|
ret += STDVEC_MEMSIZE(m_vertices, PathVertex);
|
||||||
|
ret += STDVEC_MEMSIZE(m_vertices_colors, float);
|
||||||
for (const std::vector<float>& times : m_layer_start_times)
|
for (const std::vector<float>& times : m_layer_start_times)
|
||||||
ret += STDVEC_MEMSIZE(times, float);
|
ret += STDVEC_MEMSIZE(times, float);
|
||||||
ret += STDVEC_MEMSIZE(m_layer_first_vertex, uint32_t);
|
ret += STDVEC_MEMSIZE(m_layer_first_vertex, uint32_t);
|
||||||
|
|||||||
@@ -416,8 +416,6 @@ set(SLIC3R_GUI_SOURCES
|
|||||||
GUI/MultiSendMachineModel.hpp
|
GUI/MultiSendMachineModel.hpp
|
||||||
GUI/MultiTaskManagerPage.cpp
|
GUI/MultiTaskManagerPage.cpp
|
||||||
GUI/MultiTaskManagerPage.hpp
|
GUI/MultiTaskManagerPage.hpp
|
||||||
GUI/MultiTaskModel.cpp
|
|
||||||
GUI/MultiTaskModel.hpp
|
|
||||||
GUI/NetworkTestDialog.cpp
|
GUI/NetworkTestDialog.cpp
|
||||||
GUI/NetworkTestDialog.hpp
|
GUI/NetworkTestDialog.hpp
|
||||||
GUI/Notebook.cpp
|
GUI/Notebook.cpp
|
||||||
@@ -802,7 +800,6 @@ set(SLIC3R_GUI_SOURCES
|
|||||||
Utils/PrintHost.hpp
|
Utils/PrintHost.hpp
|
||||||
Utils/Process.cpp
|
Utils/Process.cpp
|
||||||
Utils/Process.hpp
|
Utils/Process.hpp
|
||||||
Utils/Profile.hpp
|
|
||||||
Utils/RaycastManager.cpp
|
Utils/RaycastManager.cpp
|
||||||
Utils/RaycastManager.hpp
|
Utils/RaycastManager.hpp
|
||||||
Utils/Repetier.cpp
|
Utils/Repetier.cpp
|
||||||
|
|||||||
@@ -1,5 +1,4 @@
|
|||||||
#ifndef slic3r_GUI_SingleChoice_hpp_
|
#pragma once
|
||||||
#define slic3r_GUI_SingleChoice_hpp_
|
|
||||||
|
|
||||||
#include "GUI_Utils.hpp"
|
#include "GUI_Utils.hpp"
|
||||||
#include "Plater.hpp"
|
#include "Plater.hpp"
|
||||||
@@ -33,5 +32,3 @@ private:
|
|||||||
|
|
||||||
};
|
};
|
||||||
}} // namespace Slic3r::GUI
|
}} // namespace Slic3r::GUI
|
||||||
|
|
||||||
#endif
|
|
||||||
@@ -1,19 +0,0 @@
|
|||||||
#include <exception>
|
|
||||||
#include <stdexcept>
|
|
||||||
|
|
||||||
#include "libslic3r/Exception.hpp"
|
|
||||||
|
|
||||||
namespace Slic3r {
|
|
||||||
|
|
||||||
class ConfigError : public Slic3r::RuntimeError {
|
|
||||||
using Slic3r::RuntimeError::RuntimeError;
|
|
||||||
};
|
|
||||||
|
|
||||||
namespace GUI {
|
|
||||||
|
|
||||||
class ConfigGUITypeError : public ConfigError {
|
|
||||||
using ConfigError::ConfigError;
|
|
||||||
};
|
|
||||||
|
|
||||||
} // namespace GUI
|
|
||||||
} // namespace Slic3r
|
|
||||||
@@ -1105,6 +1105,10 @@ void ConfigManipulation::toggle_print_fff_options(DynamicPrintConfig *config, in
|
|||||||
toggle_field("support_filament", have_support_material || have_skirt);
|
toggle_field("support_filament", have_support_material || have_skirt);
|
||||||
|
|
||||||
toggle_line("raft_contact_distance", have_raft && !have_support_soluble);
|
toggle_line("raft_contact_distance", have_raft && !have_support_soluble);
|
||||||
|
// Orca:Hide raft expansion when raft is not enabled
|
||||||
|
toggle_line("raft_expansion", have_raft);
|
||||||
|
// Orca: Slim, Strong and Hybrid tree supports size their raft by first layer expansion only.
|
||||||
|
toggle_field("raft_expansion", !(is_tree(support_type) && (support_style == smsTreeSlim || support_style == smsTreeStrong || support_style == smsTreeHybrid)));
|
||||||
|
|
||||||
// Orca: First-layer density is available for supports broadly.
|
// Orca: First-layer density is available for supports broadly.
|
||||||
toggle_field("raft_first_layer_density", have_support_material);
|
toggle_field("raft_first_layer_density", have_support_material);
|
||||||
|
|||||||
@@ -25,9 +25,8 @@ DockPanel::DockPanel(wxWindow* parent,
|
|||||||
const std::string& html,
|
const std::string& html,
|
||||||
MessageHandler on_message,
|
MessageHandler on_message,
|
||||||
CloseHandler on_close,
|
CloseHandler on_close,
|
||||||
CloseHandler on_destroyed,
|
CloseHandler on_destroyed)
|
||||||
const wxString& profile)
|
: WebPanel(parent, web_hosting::orca_bridge_script())
|
||||||
: WebPanel(parent, web_hosting::orca_bridge_script(), profile)
|
|
||||||
, m_html(html)
|
, m_html(html)
|
||||||
, m_on_message(std::move(on_message))
|
, m_on_message(std::move(on_message))
|
||||||
, m_on_close(std::move(on_close))
|
, m_on_close(std::move(on_close))
|
||||||
|
|||||||
@@ -6,8 +6,6 @@
|
|||||||
#include <optional>
|
#include <optional>
|
||||||
#include <string>
|
#include <string>
|
||||||
|
|
||||||
#include <wx/string.h>
|
|
||||||
|
|
||||||
class wxWindow;
|
class wxWindow;
|
||||||
|
|
||||||
namespace Slic3r { namespace GUI {
|
namespace Slic3r { namespace GUI {
|
||||||
@@ -29,8 +27,7 @@ public:
|
|||||||
const std::string& html,
|
const std::string& html,
|
||||||
MessageHandler on_message,
|
MessageHandler on_message,
|
||||||
CloseHandler on_close,
|
CloseHandler on_close,
|
||||||
CloseHandler on_destroyed,
|
CloseHandler on_destroyed);
|
||||||
const wxString& profile = wxEmptyString);
|
|
||||||
~DockPanel() override;
|
~DockPanel() override;
|
||||||
|
|
||||||
// Main thread only.
|
// Main thread only.
|
||||||
|
|||||||
@@ -1514,6 +1514,8 @@ wxDEFINE_EVENT(EVT_GLCANVAS_PRINTABLE, SimpleEvent);
|
|||||||
const double GLCanvas3D::DefaultCameraZoomToBoxMarginFactor = 1.25;
|
const double GLCanvas3D::DefaultCameraZoomToBoxMarginFactor = 1.25;
|
||||||
const double GLCanvas3D::DefaultCameraZoomToBedMarginFactor = 2.00;
|
const double GLCanvas3D::DefaultCameraZoomToBedMarginFactor = 2.00;
|
||||||
const double GLCanvas3D::DefaultCameraZoomToPlateMarginFactor = 1.25;
|
const double GLCanvas3D::DefaultCameraZoomToPlateMarginFactor = 1.25;
|
||||||
|
// Main-thread only: _render_frame never runs off it, so no atomic is needed.
|
||||||
|
int GLCanvas3D::s_frames_in_progress = 0;
|
||||||
|
|
||||||
void GLCanvas3D::load_arrange_settings()
|
void GLCanvas3D::load_arrange_settings()
|
||||||
{
|
{
|
||||||
@@ -2468,7 +2470,8 @@ void GLCanvas3D::_render_frame(bool scene_dirty, bool only_init)
|
|||||||
}
|
}
|
||||||
|
|
||||||
m_in_render = true;
|
m_in_render = true;
|
||||||
Slic3r::ScopeGuard in_render_guard([this]() { m_in_render = false; });
|
++s_frames_in_progress;
|
||||||
|
Slic3r::ScopeGuard in_render_guard([this]() { m_in_render = false; --s_frames_in_progress; });
|
||||||
(void)in_render_guard;
|
(void)in_render_guard;
|
||||||
|
|
||||||
if (m_canvas == nullptr)
|
if (m_canvas == nullptr)
|
||||||
@@ -2713,15 +2716,31 @@ void GLCanvas3D::_render_frame(bool scene_dirty, bool only_init)
|
|||||||
|
|
||||||
// On Wayland, eglSwapBuffers blocks when the canvas is hidden or
|
// On Wayland, eglSwapBuffers blocks when the canvas is hidden or
|
||||||
// occluded. Skip the swap to avoid stalling the render loop.
|
// occluded. Skip the swap to avoid stalling the render loop.
|
||||||
if (m_canvas->IsShownOnScreen()) {
|
// Code run from inside this frame - a modal dialog a gizmo opened from its ImGui panel, a
|
||||||
|
// synchronous paint of another canvas - may have made a different surface current. Bind this one
|
||||||
|
// again before presenting, so the swap is not issued against a window the context no longer
|
||||||
|
// belongs to: on Mesa/X11 that is a fatal BadMatch, not the no-op it is on other platforms. Draws
|
||||||
|
// already issued before this point cannot be redirected - only this swap is protected.
|
||||||
|
if (m_canvas->IsShownOnScreen() && _set_current()) {
|
||||||
m_canvas->SwapBuffers();
|
m_canvas->SwapBuffers();
|
||||||
m_frame_profiler.mark("swap");
|
m_frame_profiler.mark("swap");
|
||||||
if (!overlay_tick)
|
if (!overlay_tick)
|
||||||
m_render_stats.increment_fps_counter();
|
m_render_stats.increment_fps_counter();
|
||||||
m_presented_signature = signature;
|
m_presented_signature = signature;
|
||||||
}
|
}
|
||||||
else
|
else {
|
||||||
|
if (m_canvas->IsShownOnScreen()) {
|
||||||
|
// Logged once: if the rebind fails it does so every frame, and a warning per frame would
|
||||||
|
// bury everything else.
|
||||||
|
static bool rebind_failure_logged = false;
|
||||||
|
if (!rebind_failure_logged) {
|
||||||
|
rebind_failure_logged = true;
|
||||||
|
BOOST_LOG_TRIVIAL(warning) << "GLCanvas3D: could not rebind the GL context to this canvas before "
|
||||||
|
"SwapBuffers(); the frame is not presented";
|
||||||
|
}
|
||||||
|
}
|
||||||
m_presented_signature.reset();
|
m_presented_signature.reset();
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Everything drawn into the 3D scene, from the clear to the post processing passes, ending in the
|
// Everything drawn into the 3D scene, from the clear to the post processing passes, ending in the
|
||||||
|
|||||||
@@ -643,6 +643,8 @@ private:
|
|||||||
#endif
|
#endif
|
||||||
unsigned int m_last_w, m_last_h;
|
unsigned int m_last_w, m_last_h;
|
||||||
bool m_in_render;
|
bool m_in_render;
|
||||||
|
// How many canvases are inside _render_frame() right now - see is_frame_in_progress().
|
||||||
|
static int s_frames_in_progress;
|
||||||
wxTimer m_timer;
|
wxTimer m_timer;
|
||||||
wxTimer m_timer_set_color;
|
wxTimer m_timer_set_color;
|
||||||
// Armed by each frame that draws the FPS overlay; its tick requests an overlay-only frame.
|
// Armed by each frame that draws the FPS overlay; its tick requests an overlay-only frame.
|
||||||
@@ -974,6 +976,11 @@ public:
|
|||||||
void on_change_color_mode(bool is_dark, bool reinit = true);
|
void on_change_color_mode(bool is_dark, bool reinit = true);
|
||||||
const bool get_dark_mode_status() { return m_is_dark; }
|
const bool get_dark_mode_status() { return m_is_dark; }
|
||||||
void set_as_dirty() { m_dirty = true; }
|
void set_as_dirty() { m_dirty = true; }
|
||||||
|
// True while any GLCanvas3D is inside _render_frame(). The other surfaces that share the app's one
|
||||||
|
// GL context (the UV editor canvas) check this before making themselves current: a frame interrupted
|
||||||
|
// by another surface finishes drawing into that surface and then presents a window the context no
|
||||||
|
// longer belongs to, which on Mesa/X11 is a fatal X error (BadMatch) rather than a no-op.
|
||||||
|
static bool is_frame_in_progress() { return s_frames_in_progress > 0; }
|
||||||
void requires_check_outside_state() { m_requires_check_outside_state = true; }
|
void requires_check_outside_state() { m_requires_check_outside_state = true; }
|
||||||
|
|
||||||
unsigned int get_volumes_count() const { return (unsigned int)m_volumes.volumes.size(); }
|
unsigned int get_volumes_count() const { return (unsigned int)m_volumes.volumes.size(); }
|
||||||
|
|||||||
@@ -719,9 +719,6 @@ void GLTexture::render_sub_texture(unsigned int tex_id, float left, float right,
|
|||||||
// does not treat anti-aliased icon edges as window transparency.
|
// does not treat anti-aliased icon edges as window transparency.
|
||||||
glsafe(::glBlendFuncSeparate(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA, GL_ONE, GL_ONE_MINUS_SRC_ALPHA));
|
glsafe(::glBlendFuncSeparate(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA, GL_ONE, GL_ONE_MINUS_SRC_ALPHA));
|
||||||
|
|
||||||
glsafe(::glEnable(GL_TEXTURE_2D));
|
|
||||||
glsafe(::glTexEnvi(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_REPLACE));
|
|
||||||
|
|
||||||
glsafe(::glBindTexture(GL_TEXTURE_2D, (GLuint)tex_id));
|
glsafe(::glBindTexture(GL_TEXTURE_2D, (GLuint)tex_id));
|
||||||
|
|
||||||
GLModel::Geometry init_data;
|
GLModel::Geometry init_data;
|
||||||
@@ -753,7 +750,6 @@ void GLTexture::render_sub_texture(unsigned int tex_id, float left, float right,
|
|||||||
|
|
||||||
glsafe(::glBindTexture(GL_TEXTURE_2D, 0));
|
glsafe(::glBindTexture(GL_TEXTURE_2D, 0));
|
||||||
|
|
||||||
glsafe(::glDisable(GL_TEXTURE_2D));
|
|
||||||
glsafe(::glDisable(GL_BLEND));
|
glsafe(::glDisable(GL_BLEND));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -4862,12 +4862,6 @@ void GUI_App::recreate_GUI(const wxString &msg_name)
|
|||||||
BOOST_LOG_TRIVIAL(info) << __FUNCTION__ << "recreate_GUI exit";
|
BOOST_LOG_TRIVIAL(info) << __FUNCTION__ << "recreate_GUI exit";
|
||||||
}
|
}
|
||||||
|
|
||||||
void GUI_App::system_info()
|
|
||||||
{
|
|
||||||
//SysInfoDialog dlg;
|
|
||||||
//dlg.ShowModal();
|
|
||||||
}
|
|
||||||
|
|
||||||
void GUI_App::keyboard_shortcuts(ShortcutContext page, wxWindow* parent)
|
void GUI_App::keyboard_shortcuts(ShortcutContext page, wxWindow* parent)
|
||||||
{
|
{
|
||||||
KBShortcutsDialog dlg(parent != nullptr ? parent : mainframe, page);
|
KBShortcutsDialog dlg(parent != nullptr ? parent : mainframe, page);
|
||||||
|
|||||||
@@ -519,7 +519,6 @@ public:
|
|||||||
void check_printer_presets();
|
void check_printer_presets();
|
||||||
|
|
||||||
void recreate_GUI(const wxString& message);
|
void recreate_GUI(const wxString& message);
|
||||||
void system_info();
|
|
||||||
void keyboard_shortcuts(ShortcutContext page, wxWindow* parent = nullptr); // the main frame when null
|
void keyboard_shortcuts(ShortcutContext page, wxWindow* parent = nullptr); // the main frame when null
|
||||||
void troubleshoot();
|
void troubleshoot();
|
||||||
void load_project(wxWindow *parent, wxString& input_file) const;
|
void load_project(wxWindow *parent, wxString& input_file) const;
|
||||||
|
|||||||
@@ -1952,6 +1952,16 @@ void MenuFactory::create_plate_menu()
|
|||||||
},
|
},
|
||||||
"", nullptr, []() { return !plater()->get_partplate_list().get_selected_plate()->get_objects().empty(); }, m_parent);
|
"", nullptr, []() { return !plater()->get_partplate_list().get_selected_plate()->get_objects().empty(); }, m_parent);
|
||||||
|
|
||||||
|
// fix objects on current plate
|
||||||
|
append_menu_item(menu, wxID_ANY, _L("Fix All"), _L("Fix all models on the current plate"),
|
||||||
|
[](wxCommandEvent&) { obj_list()->fix_all_through_cgal(false); }, "", nullptr,
|
||||||
|
[]() { return !plater()->get_partplate_list().get_selected_plate()->empty(); }, m_parent);
|
||||||
|
|
||||||
|
// fix objects on all plates
|
||||||
|
append_menu_item(menu, wxID_ANY, _L("Fix All Plates"), _L("Fix all models on all plates"),
|
||||||
|
[](wxCommandEvent&) { obj_list()->fix_all_through_cgal(true); }, "", nullptr,
|
||||||
|
[]() { return !plater()->model().objects.empty(); }, m_parent);
|
||||||
|
|
||||||
// orient objects on current plate
|
// orient objects on current plate
|
||||||
append_menu_item(menu, wxID_ANY, _L("Auto Rotate"), _L("Auto rotate current plate"),
|
append_menu_item(menu, wxID_ANY, _L("Auto Rotate"), _L("Auto rotate current plate"),
|
||||||
[](wxCommandEvent&) {
|
[](wxCommandEvent&) {
|
||||||
|
|||||||
@@ -6297,30 +6297,44 @@ void ObjectList::rename_item()
|
|||||||
}
|
}
|
||||||
|
|
||||||
void ObjectList::fix_through_cgal()
|
void ObjectList::fix_through_cgal()
|
||||||
|
{
|
||||||
|
std::vector<int> obj_idxs, vol_idxs;
|
||||||
|
get_selection_indexes(obj_idxs, vol_idxs);
|
||||||
|
fix_through_cgal(obj_idxs, vol_idxs);
|
||||||
|
}
|
||||||
|
|
||||||
|
void ObjectList::fix_all_through_cgal(bool all_plates)
|
||||||
|
{
|
||||||
|
std::vector<int> obj_idxs;
|
||||||
|
if (all_plates) {
|
||||||
|
for (int obj_idx = 0; obj_idx < int(m_objects->size()); ++obj_idx)
|
||||||
|
obj_idxs.push_back(obj_idx);
|
||||||
|
} else {
|
||||||
|
for (const ModelObject *mo : wxGetApp().plater()->get_partplate_list().get_selected_plate()->get_objects_on_this_plate())
|
||||||
|
obj_idxs.push_back(int(std::find(m_objects->begin(), m_objects->end(), mo) - m_objects->begin()));
|
||||||
|
std::sort(obj_idxs.begin(), obj_idxs.end());
|
||||||
|
obj_idxs.erase(std::unique(obj_idxs.begin(), obj_idxs.end()), obj_idxs.end());
|
||||||
|
}
|
||||||
|
fix_through_cgal(obj_idxs, {});
|
||||||
|
}
|
||||||
|
|
||||||
|
void ObjectList::fix_through_cgal(const std::vector<int> &obj_idxs, const std::vector<int> &vol_idxs)
|
||||||
{
|
{
|
||||||
// Do not fix anything when a gizmo is open. There might be issues with updates
|
// Do not fix anything when a gizmo is open. There might be issues with updates
|
||||||
// and what is worse, the snapshot time would refer to the internal stack.
|
// and what is worse, the snapshot time would refer to the internal stack.
|
||||||
if (!wxGetApp().plater()->get_view3D_canvas3D()->get_gizmos_manager().check_gizmos_closed_except(GLGizmosManager::Undefined))
|
if (obj_idxs.empty() || !wxGetApp().plater()->get_view3D_canvas3D()->get_gizmos_manager().check_gizmos_closed_except(GLGizmosManager::Undefined))
|
||||||
return;
|
return;
|
||||||
|
|
||||||
// model_name
|
// model_name
|
||||||
std::vector<std::string> succes_models;
|
std::vector<std::string> succes_models;
|
||||||
// model_name failing reason
|
// model_name failing reason
|
||||||
std::vector<std::pair<std::string, std::string>> failed_models;
|
std::vector<std::pair<std::string, std::string>> failed_models;
|
||||||
|
size_t unchanged_models = 0;
|
||||||
std::vector<int> obj_idxs, vol_idxs;
|
bool painting_removed = false;
|
||||||
get_selection_indexes(obj_idxs, vol_idxs);
|
|
||||||
|
|
||||||
std::vector<std::string> model_names;
|
std::vector<std::string> model_names;
|
||||||
|
|
||||||
// clear selections from the non-broken models if any exists
|
|
||||||
// and than fill names of models to repairing
|
|
||||||
if (vol_idxs.empty()) {
|
if (vol_idxs.empty()) {
|
||||||
#if !FIX_THROUGH_CGAL_ALWAYS
|
|
||||||
for (int i = int(obj_idxs.size())-1; i >= 0; --i)
|
|
||||||
if (object(obj_idxs[i])->get_repaired_errors_count() == 0)
|
|
||||||
obj_idxs.erase(obj_idxs.begin()+i);
|
|
||||||
#endif // FIX_THROUGH_CGAL_ALWAYS
|
|
||||||
for (int obj_idx : obj_idxs)
|
for (int obj_idx : obj_idxs)
|
||||||
if (object(obj_idx))
|
if (object(obj_idx))
|
||||||
model_names.push_back(object(obj_idx)->name);
|
model_names.push_back(object(obj_idx)->name);
|
||||||
@@ -6328,31 +6342,26 @@ void ObjectList::fix_through_cgal()
|
|||||||
else {
|
else {
|
||||||
ModelObject* obj = object(obj_idxs.front());
|
ModelObject* obj = object(obj_idxs.front());
|
||||||
if (obj) {
|
if (obj) {
|
||||||
#if !FIX_THROUGH_CGAL_ALWAYS
|
|
||||||
for (int i = int(vol_idxs.size()) - 1; i >= 0; --i)
|
|
||||||
if (obj->get_repaired_errors_count(vol_idxs[i]) == 0)
|
|
||||||
vol_idxs.erase(vol_idxs.begin() + i);
|
|
||||||
#endif // FIX_THROUGH_CGAL_ALWAYS
|
|
||||||
for (int vol_idx : vol_idxs)
|
for (int vol_idx : vol_idxs)
|
||||||
model_names.push_back(obj->volumes[vol_idx]->name);
|
model_names.push_back(obj->volumes[vol_idx]->name);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
auto plater = wxGetApp().plater();
|
auto plater = wxGetApp().plater();
|
||||||
|
const bool keep_painting = GUI::wxGetApp().app_config->get_bool("keep_painting");
|
||||||
|
|
||||||
auto fix_and_update_progress = [this, plater, model_names](const int obj_idx, const int vol_idx,
|
auto fix_and_update_progress = [&](const int obj_idx, const int vol_idx, int model_idx, ProgressDialog& progress_dlg)
|
||||||
int model_idx,
|
|
||||||
ProgressDialog& progress_dlg,
|
|
||||||
std::vector<std::string>& succes_models,
|
|
||||||
std::vector<std::pair<std::string, std::string>>& failed_models)
|
|
||||||
{
|
{
|
||||||
if (!object(obj_idx))
|
ModelObject *mo = object(obj_idx);
|
||||||
|
if (!mo)
|
||||||
return false;
|
return false;
|
||||||
|
|
||||||
const std::string& model_name = model_names[model_idx];
|
const std::string& model_name = model_names[model_idx];
|
||||||
wxString msg = _L("Repairing model object");
|
wxString msg = _L("Repairing model object");
|
||||||
if (model_names.size() == 1)
|
if (model_names.size() == 1)
|
||||||
msg += ": " + from_u8(model_name) + "\n";
|
msg += ": " + from_u8(model_name) + "\n";
|
||||||
|
else if (model_names.size() > 10)
|
||||||
|
msg += ": " + from_u8(model_name) + wxString::Format(" (%d/%d)", model_idx + 1, int(model_names.size())) + "\n";
|
||||||
else {
|
else {
|
||||||
msg += ":\n";
|
msg += ":\n";
|
||||||
for (int i = 0; i < int(model_names.size()); ++i)
|
for (int i = 0; i < int(model_names.size()); ++i)
|
||||||
@@ -6360,33 +6369,29 @@ void ObjectList::fix_through_cgal()
|
|||||||
msg += "\n";
|
msg += "\n";
|
||||||
}
|
}
|
||||||
|
|
||||||
const bool keep_painting = GUI::wxGetApp().app_config->get_bool("keep_painting");
|
auto count_painted = [mo]() { return std::count_if(mo->volumes.begin(), mo->volumes.end(), [](const ModelVolume *mv) { return mv->is_any_painted(); }); };
|
||||||
if (!keep_painting) {
|
const auto painted_before = count_painted();
|
||||||
plater->clear_before_change_mesh(obj_idx);
|
|
||||||
}
|
|
||||||
const size_t volumes_before = object(obj_idx)->volumes.size();
|
|
||||||
std::string res;
|
std::string res;
|
||||||
if (!fix_model_with_cgal_gui(*(object(obj_idx)), vol_idx, progress_dlg, msg, res, keep_painting))
|
bool modified = false;
|
||||||
|
if (!fix_model_with_cgal_gui(*mo, vol_idx, progress_dlg, msg, res, keep_painting, &modified))
|
||||||
return false;
|
return false;
|
||||||
//wxGetApp().plater()->changed_mesh(obj_idx);
|
|
||||||
object(obj_idx)->ensure_on_bed();
|
|
||||||
plater->changed_mesh(obj_idx);
|
|
||||||
|
|
||||||
const size_t volumes_after = object(obj_idx)->volumes.size();
|
if (modified) {
|
||||||
if (volumes_after != volumes_before)
|
painting_removed = painting_removed || count_painted() < painted_before;
|
||||||
add_volumes_to_object_in_list(obj_idx);
|
mo->ensure_on_bed();
|
||||||
|
plater->changed_mesh(obj_idx);
|
||||||
|
plater->get_partplate_list().notify_instance_update(obj_idx, 0);
|
||||||
|
plater->sidebar().obj_list()->update_plate_values_for_items();
|
||||||
|
update_item_error_icon(obj_idx, vol_idx);
|
||||||
|
update_info_items(obj_idx);
|
||||||
|
}
|
||||||
|
|
||||||
plater->get_partplate_list().notify_instance_update(obj_idx, 0);
|
if (!res.empty())
|
||||||
plater->sidebar().obj_list()->update_plate_values_for_items();
|
failed_models.push_back({ model_name, res });
|
||||||
|
else if (modified)
|
||||||
if (res.empty())
|
|
||||||
succes_models.push_back(model_name);
|
succes_models.push_back(model_name);
|
||||||
else
|
else
|
||||||
failed_models.push_back({ model_name, res });
|
++unchanged_models;
|
||||||
|
|
||||||
update_item_error_icon(obj_idx, vol_idx);
|
|
||||||
update_info_items(obj_idx);
|
|
||||||
|
|
||||||
return true;
|
return true;
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -6399,11 +6404,7 @@ void ObjectList::fix_through_cgal()
|
|||||||
if (vol_idxs.empty()) {
|
if (vol_idxs.empty()) {
|
||||||
int vol_idx{ -1 };
|
int vol_idx{ -1 };
|
||||||
for (int obj_idx : obj_idxs) {
|
for (int obj_idx : obj_idxs) {
|
||||||
#if !FIX_THROUGH_CGAL_ALWAYS
|
if (!fix_and_update_progress(obj_idx, vol_idx, model_idx, progress_dlg))
|
||||||
if (object(obj_idx)->get_repaired_errors_count(vol_idx) == 0)
|
|
||||||
continue;
|
|
||||||
#endif // FIX_THROUGH_CGAL_ALWAYS
|
|
||||||
if (!fix_and_update_progress(obj_idx, vol_idx, model_idx, progress_dlg, succes_models, failed_models))
|
|
||||||
break;
|
break;
|
||||||
model_idx++;
|
model_idx++;
|
||||||
}
|
}
|
||||||
@@ -6411,7 +6412,7 @@ void ObjectList::fix_through_cgal()
|
|||||||
else {
|
else {
|
||||||
int obj_idx{ obj_idxs.front() };
|
int obj_idx{ obj_idxs.front() };
|
||||||
for (int vol_idx : vol_idxs) {
|
for (int vol_idx : vol_idxs) {
|
||||||
if (!fix_and_update_progress(obj_idx, vol_idx, model_idx, progress_dlg, succes_models, failed_models))
|
if (!fix_and_update_progress(obj_idx, vol_idx, model_idx, progress_dlg))
|
||||||
break;
|
break;
|
||||||
model_idx++;
|
model_idx++;
|
||||||
}
|
}
|
||||||
@@ -6419,20 +6420,29 @@ void ObjectList::fix_through_cgal()
|
|||||||
// Close the progress dialog
|
// Close the progress dialog
|
||||||
progress_dlg.Update(100, "");
|
progress_dlg.Update(100, "");
|
||||||
|
|
||||||
|
if (painting_removed)
|
||||||
|
plater->notify_painting_removed();
|
||||||
|
|
||||||
// Show info notification
|
// Show info notification
|
||||||
wxString msg;
|
std::vector<wxString> blocks;
|
||||||
wxString bullet_suf = "\n - ";
|
wxString bullet_suf = "\n - ";
|
||||||
if (!succes_models.empty()) {
|
if (!succes_models.empty()) {
|
||||||
msg = _L_PLURAL("The following model object has been repaired", "The following model objects have been repaired", succes_models.size()) + ":";
|
wxString block = _L_PLURAL("The following model object has been repaired", "The following model objects have been repaired", succes_models.size()) + ":";
|
||||||
for (auto& model : succes_models)
|
for (auto& model : succes_models)
|
||||||
msg += bullet_suf + from_u8(model);
|
block += bullet_suf + from_u8(model);
|
||||||
msg += "\n\n";
|
blocks.push_back(block);
|
||||||
}
|
}
|
||||||
if (!failed_models.empty()) {
|
if (!failed_models.empty()) {
|
||||||
msg += _L_PLURAL("Failed to repair the following model object", "Failed to repair the following model objects", failed_models.size()) + ":\n";
|
wxString block = _L_PLURAL("Failed to repair the following model object", "Failed to repair the following model objects", failed_models.size()) + ":";
|
||||||
for (auto& model : failed_models)
|
for (auto& model : failed_models)
|
||||||
msg += bullet_suf + from_u8(model.first) + ": " + _(model.second);
|
block += bullet_suf + from_u8(model.first) + ": " + _(model.second);
|
||||||
|
blocks.push_back(block);
|
||||||
}
|
}
|
||||||
|
if (unchanged_models > 0)
|
||||||
|
blocks.push_back(format_wxstr(_L_PLURAL("%1$d model object needed no repair.", "%1$d model objects needed no repair.", unchanged_models), unchanged_models));
|
||||||
|
wxString msg;
|
||||||
|
for (const wxString &block : blocks)
|
||||||
|
msg += (msg.IsEmpty() ? "" : "\n\n") + block;
|
||||||
if (msg.IsEmpty())
|
if (msg.IsEmpty())
|
||||||
msg = _L("Repairing was canceled");
|
msg = _L("Repairing was canceled");
|
||||||
plater->get_notification_manager()->push_notification(NotificationType::CgalFinished, NotificationManager::NotificationLevel::PrintInfoShortNotificationLevel, into_u8(msg));
|
plater->get_notification_manager()->push_notification(NotificationType::CgalFinished, NotificationManager::NotificationLevel::PrintInfoShortNotificationLevel, into_u8(msg));
|
||||||
|
|||||||
@@ -47,9 +47,6 @@ typedef double coordf_t;
|
|||||||
typedef std::pair<coordf_t, coordf_t> t_layer_height_range;
|
typedef std::pair<coordf_t, coordf_t> t_layer_height_range;
|
||||||
typedef std::map<t_layer_height_range, ModelConfig> t_layer_config_ranges;
|
typedef std::map<t_layer_height_range, ModelConfig> t_layer_config_ranges;
|
||||||
|
|
||||||
// Manifold mesh may contain self-intersections, so we want to always allow fixing the mesh.
|
|
||||||
#define FIX_THROUGH_CGAL_ALWAYS 1
|
|
||||||
|
|
||||||
namespace GUI {
|
namespace GUI {
|
||||||
|
|
||||||
enum class Shortcut : uint8_t;
|
enum class Shortcut : uint8_t;
|
||||||
@@ -463,6 +460,9 @@ public:
|
|||||||
void split_instances();
|
void split_instances();
|
||||||
void rename_item();
|
void rename_item();
|
||||||
void fix_through_cgal();
|
void fix_through_cgal();
|
||||||
|
// Fixes every object on the selected plate, or on all plates.
|
||||||
|
void fix_all_through_cgal(bool all_plates);
|
||||||
|
void fix_through_cgal(const std::vector<int> &obj_idxs, const std::vector<int> &vol_idxs);
|
||||||
void simplify();
|
void simplify();
|
||||||
void smooth_mesh();
|
void smooth_mesh();
|
||||||
void update_item_error_icon(const int obj_idx, int vol_idx) const ;
|
void update_item_error_icon(const int obj_idx, int vol_idx) const ;
|
||||||
|
|||||||
@@ -1036,6 +1036,11 @@ bool GLGizmoPainterBase::on_mouse(const wxMouseEvent &mouse_event)
|
|||||||
Vec2d mouse_pos = mouse_coord.cast<double>();
|
Vec2d mouse_pos = mouse_coord.cast<double>();
|
||||||
|
|
||||||
if (mouse_event.Moving()) {
|
if (mouse_event.Moving()) {
|
||||||
|
// No button is down, yet a stroke is still open: its release went elsewhere, as a paint drag does not
|
||||||
|
// capture the mouse. End the stroke as that release would have.
|
||||||
|
if (m_button_down != Button::None)
|
||||||
|
gizmo_event(m_button_down == Button::Left ? SLAGizmoEventType::LeftUp : SLAGizmoEventType::RightUp, mouse_pos,
|
||||||
|
mouse_event.ShiftDown(), mouse_event.AltDown(), false);
|
||||||
gizmo_event(SLAGizmoEventType::Moving, mouse_pos, mouse_event.ShiftDown(), mouse_event.AltDown(), false);
|
gizmo_event(SLAGizmoEventType::Moving, mouse_pos, mouse_event.ShiftDown(), mouse_event.AltDown(), false);
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
@@ -1205,6 +1210,10 @@ void GLGizmoPainterBase::on_set_state()
|
|||||||
m_old_mo_id = -1;
|
m_old_mo_id = -1;
|
||||||
//m_iva.release_geometry();
|
//m_iva.release_geometry();
|
||||||
m_triangle_selectors.clear();
|
m_triangle_selectors.clear();
|
||||||
|
// A stroke still open goes with the selectors. Its state must not carry into the next session, where the
|
||||||
|
// first move would end it as if released and the first press would paint a line from its last position.
|
||||||
|
m_button_down = Button::None;
|
||||||
|
m_last_mouse_click = Vec2d::Zero();
|
||||||
|
|
||||||
//Camera& camera = wxGetApp().plater()->get_camera();
|
//Camera& camera = wxGetApp().plater()->get_camera();
|
||||||
//camera.look_at(camera.get_position(), m_previous_target, Vec3d::UnitZ());
|
//camera.look_at(camera.get_position(), m_previous_target, Vec3d::UnitZ());
|
||||||
|
|||||||
File diff suppressed because it is too large
Load Diff
@@ -23,6 +23,7 @@
|
|||||||
#include "libslic3r/Point.hpp"
|
#include "libslic3r/Point.hpp"
|
||||||
#include <imgui.h>
|
#include <imgui.h>
|
||||||
#include <map>
|
#include <map>
|
||||||
|
#include <future>
|
||||||
#include <memory>
|
#include <memory>
|
||||||
#include <optional>
|
#include <optional>
|
||||||
#include "slic3r/GUI/Gizmos/GLGizmoBase.hpp"
|
#include "slic3r/GUI/Gizmos/GLGizmoBase.hpp"
|
||||||
@@ -197,6 +198,27 @@ public:
|
|||||||
};
|
};
|
||||||
static PaintedColors painted_colors(const TriangleMesh &mesh, const TriangleSelector::TriangleSplittingData &paint);
|
static PaintedColors painted_colors(const TriangleMesh &mesh, const TriangleSelector::TriangleSplittingData &paint);
|
||||||
|
|
||||||
|
// The view while the UV editor's selected islands are highlighted on the model. The highlight lies on the
|
||||||
|
// undisplaced surface, so the Normal view's relief hides it wherever it rises: Normal gives way to Fast
|
||||||
|
// while islands are selected and comes back once none are. A view the user clicks in the View row is
|
||||||
|
// theirs - the pane's background buttons are not a pick, Height only meaning "the texture view".
|
||||||
|
struct IslandViewFollow
|
||||||
|
{
|
||||||
|
bool shown = false; // the highlight, as of the last step()
|
||||||
|
bool switched = false; // Fast was switched on for the highlight, so Normal comes back once it is gone
|
||||||
|
bool keep_normal = false; // the user picked Normal in the View row while the highlight was shown
|
||||||
|
// The view to apply this frame (0 Normal, 1 Fast), or -1 for none. `view` is the one on screen, numbered as
|
||||||
|
// apply_view_mode() takes it; `debug_open` a debug stage on screen, which holds Normal itself.
|
||||||
|
int step(bool shown_now, int view, bool debug_open);
|
||||||
|
// A View row button clicked, the active one included. The row is drawn after step() in the same frame,
|
||||||
|
// so `shown` is this frame's.
|
||||||
|
void picked(int view)
|
||||||
|
{
|
||||||
|
switched = false;
|
||||||
|
keep_normal = shown && view == 0;
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
void render_painter_gizmo() override;
|
void render_painter_gizmo() override;
|
||||||
|
|
||||||
// Intercepts mouse input while "Adjust Texture" mode is on (dragging the on-canvas offset/
|
// Intercepts mouse input while "Adjust Texture" mode is on (dragging the on-canvas offset/
|
||||||
@@ -262,6 +284,9 @@ private:
|
|||||||
// Standard is active so what Preview shows is always what Bake will do. Returns true if it actually
|
// Standard is active so what Preview shows is always what Bake will do. Returns true if it actually
|
||||||
// changed something, so the caller can invalidate the preview.
|
// changed something, so the caller can invalidate the preview.
|
||||||
bool apply_standard_mode_presets(ModelVolume *mv);
|
bool apply_standard_mode_presets(ModelVolume *mv);
|
||||||
|
// Copies the panel's own state (active layer, Standard/Pro) onto the volume, so the project file
|
||||||
|
// can carry it. Cheap and idempotent - called wherever either of the two changes.
|
||||||
|
void store_panel_state();
|
||||||
// Standard mode's Bake: remesh to an even density, refine where the texture bends, then displace.
|
// Standard mode's Bake: remesh to an even density, refine where the texture bends, then displace.
|
||||||
// The order matters and is the whole reason this is one button - a height map can only move
|
// The order matters and is the whole reason this is one button - a height map can only move
|
||||||
// existing vertices, so the mesh has to be prepared first, and remeshing after painting would drop
|
// existing vertices, so the mesh has to be prepared first, and remeshing after painting would drop
|
||||||
@@ -404,6 +429,77 @@ private:
|
|||||||
// Per slot: whether the layer's card shows every setting or only Depth, Tile size and Rotation.
|
// Per slot: whether the layer's card shows every setting or only Depth, Tile size and Rotation.
|
||||||
// Panel state only, not saved with the project.
|
// Panel state only, not saved with the project.
|
||||||
std::array<bool, TEXTURE_DISPLACEMENT_MAX_LAYERS> m_layer_expanded{};
|
std::array<bool, TEXTURE_DISPLACEMENT_MAX_LAYERS> m_layer_expanded{};
|
||||||
|
// The slider whose edit icon was just clicked, as its ImGui id, and the frame it was clicked on.
|
||||||
|
// The row acts on it on the next frame - ImGui's keyboard-focus request only takes effect a frame
|
||||||
|
// later - and clears it; the frame number is what retires a request whose row has gone off screen
|
||||||
|
// in the meantime. Panel state only, not saved with the project.
|
||||||
|
std::string m_slider_type_request;
|
||||||
|
int m_slider_type_request_frame = 0;
|
||||||
|
|
||||||
|
// ---- The image-adjustment panel ----
|
||||||
|
//
|
||||||
|
// Brightness/contrast/sharpness/blur/hue over one layer's image, shown on the image itself and
|
||||||
|
// updating as the sliders move. What it produces is not a set of layer parameters: it replaces the
|
||||||
|
// layer's *image*, so the adjusted pixels feed the colour and the displacement together and a
|
||||||
|
// brightness change moves the relief too (see TextureAdjustments).
|
||||||
|
//
|
||||||
|
// An ordinary floating window rather than a popup, and deliberately so. A popup dims the canvas
|
||||||
|
// behind it and closes on any click outside itself, which between them make it impossible to watch the
|
||||||
|
// relief change on the model - which is the whole point of adjusting the image here rather than in an
|
||||||
|
// image editor. A window leaves the 3D view live, clickable and orbitable while the panel is open.
|
||||||
|
void render_image_adjust_window(const ImVec2 &panel_min, const ImVec2 &panel_max);
|
||||||
|
// Opens the panel for `layer`, decoding its image into m_adjust_source. Sliders never re-decode
|
||||||
|
// the PNG.
|
||||||
|
void open_image_adjust(const TextureDisplacementLayer &layer);
|
||||||
|
// Reads `layer`'s stored image into the panel's source buffers and records which image it came from.
|
||||||
|
// Called when the panel opens and again whenever the layer's image is swapped under it, which is why
|
||||||
|
// it leaves the slider values alone. False when the image cannot be decoded.
|
||||||
|
bool load_image_adjust_source(const TextureDisplacementLayer &layer);
|
||||||
|
// Resolves the panel: writes the adjusted image into the user's texture library as a new file and
|
||||||
|
// points `layer` at it, which is the only way an adjustment becomes permanent. Closes the panel.
|
||||||
|
void commit_image_adjust(TextureDisplacementLayer &layer);
|
||||||
|
// Closes the panel and reverts the layer's live preview_adjust to identity, so every exit that is not
|
||||||
|
// a commit - Cancel, the window's close button, the gizmo closing - leaves the layer as it was found.
|
||||||
|
void close_image_adjust();
|
||||||
|
// Collects a finished preview and starts one for the current slider values. One at a time, so a drag
|
||||||
|
// coalesces into "whatever the sliders last said" instead of a queue of superseded frames.
|
||||||
|
void update_image_adjust_preview();
|
||||||
|
|
||||||
|
int m_adjust_slot = -1; // the layer the panel is open for; -1 when closed
|
||||||
|
TextureAdjustments m_adjust; // what the sliders currently say
|
||||||
|
// What the layer's live preview_adjust was last set from, so a slider move can be told from a frame in
|
||||||
|
// which nothing happened and only the former asks the displacement to be recomputed.
|
||||||
|
TextureAdjustments m_adjust_applied;
|
||||||
|
|
||||||
|
// The layer's image as it was when the panel opened, and a small copy of it. The sliders are applied
|
||||||
|
// to the small copy for the live preview and to the full-size one exactly once, on commit. Measured on
|
||||||
|
// a 1024x1024 with every knob engaged, a full-size pass costs 13-19 ms grayscale and 40-60 ms in
|
||||||
|
// colour (130-190 ms at 2048 in colour) - far too much to repeat per slider frame. The same pass on a
|
||||||
|
// 384 px copy is 3-4 ms / 9-12 ms, and that is all the preview box can show anyway.
|
||||||
|
DecodedHeightTexture m_adjust_source;
|
||||||
|
DecodedHeightTexture m_adjust_preview_source;
|
||||||
|
// Which image_data the two buffers above were decoded from, so the panel can notice the layer's image
|
||||||
|
// being swapped from the texture picker while it is open and re-read it. Compared, never dereferenced.
|
||||||
|
const void *m_adjust_source_image = nullptr;
|
||||||
|
// And which volume the panel was opened on. Slot numbers are per volume, so without this a change of
|
||||||
|
// selection would silently rebind the open panel to whichever layer happens to hold the same slot on
|
||||||
|
// the newly selected object - a different image, under a panel the user opened for this one.
|
||||||
|
size_t m_adjust_volume_id = 0;
|
||||||
|
// The preview image on screen, re-uploaded whenever a background pass finishes.
|
||||||
|
std::unique_ptr<GLTexture> m_adjust_preview_tex;
|
||||||
|
|
||||||
|
// The live preview runs on its own thread rather than on the UI thread or on the plater's job
|
||||||
|
// worker. Not the UI thread because even the small pass is milliseconds and this runs while a slider
|
||||||
|
// is being dragged; not the job worker because that is a single FIFO shared with Bake and the
|
||||||
|
// displacement preview (see queue_preview_job()), where a per-frame image filter would sit behind -
|
||||||
|
// and delay - multi-second mesh work.
|
||||||
|
std::future<DecodedHeightTexture> m_adjust_preview_job;
|
||||||
|
TextureAdjustments m_adjust_preview_running; // what the in-flight pass is computing
|
||||||
|
TextureAdjustments m_adjust_preview_shown; // what m_adjust_preview_tex holds
|
||||||
|
bool m_adjust_preview_valid = false;
|
||||||
|
// Drops the GPU copies of the layer's image so the next frame rebuilds them from the decode, which
|
||||||
|
// is where the live adjustment is applied. Called whenever the panel moves or reverts it.
|
||||||
|
void invalidate_adjust_textures();
|
||||||
|
|
||||||
// "Adjust Texture" mode: instead of painting, dragging an on-canvas handle changes the active
|
// "Adjust Texture" mode: instead of painting, dragging an on-canvas handle changes the active
|
||||||
// layer's offset. The handle is a flat panel lying in the paint patch's own tangent plane
|
// layer's offset. The handle is a flat panel lying in the paint patch's own tangent plane
|
||||||
@@ -423,8 +519,8 @@ private:
|
|||||||
// obvious whether the next stroke adds paint (default) or erases it (Shift). Uses ImGui's
|
// obvious whether the next stroke adds paint (default) or erases it (Shift). Uses ImGui's
|
||||||
// foreground draw list, so it must be called from inside the gizmo's ImGui frame.
|
// foreground draw list, so it must be called from inside the gizmo's ImGui frame.
|
||||||
void render_paint_cursor_hint();
|
void render_paint_cursor_hint();
|
||||||
// Mesh-local tangent-plane basis at m_adjust_anchor_normal, matching project_planar()'s
|
// Mesh-local tangent-plane basis at m_adjust_anchor_normal: box_projection_axes(), so dragging
|
||||||
// dominant-axis convention so dragging on-canvas maps consistently onto offset.
|
// on-canvas maps consistently onto offset whichever face the anchor is on.
|
||||||
void adjust_tangent_basis(Vec3f &u_axis, Vec3f &v_axis) const;
|
void adjust_tangent_basis(Vec3f &u_axis, Vec3f &v_axis) const;
|
||||||
|
|
||||||
// The plane a drag is measured against: the paint patch's anchor, lifted clear of the surface.
|
// The plane a drag is measured against: the paint patch's anchor, lifted clear of the surface.
|
||||||
@@ -504,6 +600,11 @@ private:
|
|||||||
// The panel's view modes: 0 Normal, 1 Fast, 2 Checker, 3 Distortion. Shared by the View row and the pane's
|
// The panel's view modes: 0 Normal, 1 Fast, 2 Checker, 3 Distortion. Shared by the View row and the pane's
|
||||||
// background buttons, so both switch views the same way.
|
// background buttons, so both switch views the same way.
|
||||||
void apply_view_mode(int mode);
|
void apply_view_mode(int mode);
|
||||||
|
// The view on screen, numbered as apply_view_mode() takes it.
|
||||||
|
int view_mode() const;
|
||||||
|
// Run once a frame, after the pane's commands: switches the view as m_island_view says.
|
||||||
|
void follow_island_highlight();
|
||||||
|
IslandViewFollow m_island_view;
|
||||||
// The pane header's thumbnail of the active layer's texture, rebuilt only when its image changes.
|
// The pane header's thumbnail of the active layer's texture, rebuilt only when its image changes.
|
||||||
static constexpr int UV_THUMB_PX = 64;
|
static constexpr int UV_THUMB_PX = 64;
|
||||||
const void *m_uv_thumb_source = nullptr;
|
const void *m_uv_thumb_source = nullptr;
|
||||||
@@ -735,6 +836,8 @@ private:
|
|||||||
// in place. Rebuilt whenever the pane's selection differs from the one it was built for.
|
// in place. Rebuilt whenever the pane's selection differs from the one it was built for.
|
||||||
GLModel m_island_overlay_glmodel;
|
GLModel m_island_overlay_glmodel;
|
||||||
std::vector<int> m_island_overlay_selection;
|
std::vector<int> m_island_overlay_selection;
|
||||||
|
// The pane's selection while the overlay applies - the pane open over an unwrapped LSCM layer - else null.
|
||||||
|
const std::vector<int> *island_highlight_selection();
|
||||||
void rebuild_island_overlay(const std::vector<int> &selection);
|
void rebuild_island_overlay(const std::vector<int> &selection);
|
||||||
void render_island_overlay();
|
void render_island_overlay();
|
||||||
// Set on every paint event, cleared when the overlay is rebuilt in render_painter_gizmo(). Kept
|
// Set on every paint event, cleared when the overlay is rebuilt in render_painter_gizmo(). Kept
|
||||||
@@ -878,6 +981,7 @@ private:
|
|||||||
enum class UVBackground { None, Height, Checker };
|
enum class UVBackground { None, Height, Checker };
|
||||||
UVBackground m_uv_editor_bg = UVBackground::None;
|
UVBackground m_uv_editor_bg = UVBackground::None;
|
||||||
float m_uv_editor_bg_smoothing = -1.f; // smoothing the height backdrop was uploaded at
|
float m_uv_editor_bg_smoothing = -1.f; // smoothing the height backdrop was uploaded at
|
||||||
|
TextureAdjustments m_uv_editor_bg_adjust; // and the live image adjustment it was uploaded at
|
||||||
const void *m_uv_editor_bg_image = nullptr; // the layer image it was uploaded from
|
const void *m_uv_editor_bg_image = nullptr; // the layer image it was uploaded from
|
||||||
// Per-chart distortion heatmap colour for the UV pane (#7/#14), computed once when the unwrap is
|
// Per-chart distortion heatmap colour for the UV pane (#7/#14), computed once when the unwrap is
|
||||||
// re-solved (relative stretch doesn't change when islands are merely moved), fed to the canvas only
|
// re-solved (relative stretch doesn't change when islands are merely moved), fed to the canvas only
|
||||||
@@ -915,25 +1019,26 @@ private:
|
|||||||
bool m_preview_job_pending = false;
|
bool m_preview_job_pending = false;
|
||||||
void queue_preview_job();
|
void queue_preview_job();
|
||||||
|
|
||||||
// Per-slot GPU thumbnail cache for the layer list panel, keyed by the image_data pointer that
|
// Per-slot GPU thumbnail cache for the layer list panel, each keyed by the image_data it was built from
|
||||||
// was current the last time each thumbnail was built (see get_layer_thumbnail()).
|
// (see get_layer_thumbnail()). Held weakly rather than by address, as decode_height_texture()'s cache is:
|
||||||
std::array<std::unique_ptr<GLTexture>, TEXTURE_DISPLACEMENT_MAX_LAYERS> m_thumbnails;
|
// an image freed and replaced by another at the same address must not pass for it.
|
||||||
std::array<const void *, TEXTURE_DISPLACEMENT_MAX_LAYERS> m_thumbnail_source{};
|
std::array<std::unique_ptr<GLTexture>, TEXTURE_DISPLACEMENT_MAX_LAYERS> m_thumbnails;
|
||||||
|
std::array<std::weak_ptr<const std::vector<unsigned char>>, TEXTURE_DISPLACEMENT_MAX_LAYERS> m_thumbnail_source;
|
||||||
// The smoothing each cached thumbnail was built at, so a smoothing change re-uploads it.
|
// The smoothing each cached thumbnail was built at, so a smoothing change re-uploads it.
|
||||||
std::array<float, TEXTURE_DISPLACEMENT_MAX_LAYERS> m_thumbnail_smoothing{};
|
std::array<float, TEXTURE_DISPLACEMENT_MAX_LAYERS> m_thumbnail_smoothing{};
|
||||||
|
|
||||||
// Full-resolution height texture for the preview shader, keyed the same way (see
|
// Full-resolution height texture for the preview shader, keyed the same way (see
|
||||||
// get_layer_height_texture()). A smoothing change re-uploads it, so the fast preview shows the
|
// get_layer_height_texture()). A smoothing change re-uploads it, so the fast preview shows the
|
||||||
// blur the bake will apply.
|
// blur the bake will apply.
|
||||||
std::unique_ptr<GLTexture> m_height_tex;
|
std::unique_ptr<GLTexture> m_height_tex;
|
||||||
const void *m_height_tex_source = nullptr;
|
std::weak_ptr<const std::vector<unsigned char>> m_height_tex_source;
|
||||||
float m_height_tex_smoothing = -1.f;
|
float m_height_tex_smoothing = -1.f;
|
||||||
|
|
||||||
// The same, for the layer's *colour*, which the fast preview quantizes per fragment so it shows
|
// The same, for the layer's *colour*, which the fast preview quantizes per fragment so it shows
|
||||||
// the image at texel resolution rather than at the mesh's. Null for a grayscale texture.
|
// the image at texel resolution rather than at the mesh's. Null for a grayscale texture.
|
||||||
std::unique_ptr<GLTexture> m_color_tex;
|
std::unique_ptr<GLTexture> m_color_tex;
|
||||||
const void *m_color_tex_source = nullptr;
|
std::weak_ptr<const std::vector<unsigned char>> m_color_tex_source;
|
||||||
float m_color_tex_smoothing = -1.f;
|
float m_color_tex_smoothing = -1.f;
|
||||||
|
|
||||||
// Library textures the picker has shown at least once, keyed by file path (see LibraryTexture).
|
// Library textures the picker has shown at least once, keyed by file path (see LibraryTexture).
|
||||||
std::map<std::string, LibraryTexture> m_library_textures;
|
std::map<std::string, LibraryTexture> m_library_textures;
|
||||||
@@ -971,9 +1076,12 @@ private:
|
|||||||
PatchUnwrap m_uv_editor_unwrap;
|
PatchUnwrap m_uv_editor_unwrap;
|
||||||
|
|
||||||
// When set, the panel is a free-floating window the user can drag anywhere (with a title bar to
|
// When set, the panel is a free-floating window the user can drag anywhere (with a title bar to
|
||||||
// grab), instead of being pinned to the right of the gizmo toolbar. Persisted across gizmo
|
// grab), instead of being pinned to the right of the gizmo toolbar. Kept in the application
|
||||||
// open/close within a session, so the choice sticks while working.
|
// config rather than in the project: it describes the user's window, not the model, so opening
|
||||||
|
// someone else's project must not move their panel.
|
||||||
bool m_undocked = false;
|
bool m_undocked = false;
|
||||||
|
// The config key behind m_undocked.
|
||||||
|
static constexpr const char *UNDOCKED_CONFIG_KEY = "texture_displacement_panel_undocked";
|
||||||
|
|
||||||
// Smooth scrolling for the panel body (everything between the header and the pinned Bake footer).
|
// Smooth scrolling for the panel body (everything between the header and the pinned Bake footer).
|
||||||
// ImGui jumps a fixed number of lines per wheel notch, which on tall layer cards reads as a hard
|
// ImGui jumps a fixed number of lines per wheel notch, which on tall layer cards reads as a hard
|
||||||
@@ -1016,6 +1124,9 @@ private:
|
|||||||
std::vector<std::pair<wxString, wxString>> m_shortcuts_bucket_fill;
|
std::vector<std::pair<wxString, wxString>> m_shortcuts_bucket_fill;
|
||||||
// Contains all shortcuts in the format of {shortcut, description}, e.g. {alt + _L("Left mouse button"), _L("Part_selection")}
|
// Contains all shortcuts in the format of {shortcut, description}, e.g. {alt + _L("Left mouse button"), _L("Part_selection")}
|
||||||
std::vector<std::pair<wxString, wxString>> m_shortcuts_gap_fill;
|
std::vector<std::pair<wxString, wxString>> m_shortcuts_gap_fill;
|
||||||
|
// The two ways every slider in the panel takes a typed value. They hold whatever tool is selected,
|
||||||
|
// so they are tacked onto each of the lists above and stand on their own when no tool is active.
|
||||||
|
std::vector<std::pair<wxString, wxString>> m_shortcuts_sliders;
|
||||||
|
|
||||||
// Icons for the panel's icon buttons (tools, views, mapping, tiling, layer actions). Loaded through IconManager with
|
// Icons for the panel's icon buttons (tools, views, mapping, tiling, layer actions). Loaded through IconManager with
|
||||||
// the same colour/monochrome variants the main toolbar uses, so an inactive button shows the icon in
|
// the same colour/monochrome variants the main toolbar uses, so an inactive button shows the icon in
|
||||||
|
|||||||
@@ -420,7 +420,10 @@ void GLGizmosManager::refresh_on_off_state()
|
|||||||
|
|
||||||
void GLGizmosManager::reset_all_states()
|
void GLGizmosManager::reset_all_states()
|
||||||
{
|
{
|
||||||
if (! m_enabled || m_serializing)
|
// The restore/new-project event can run before deferred OpenGL resource
|
||||||
|
// loading has populated the gizmo list. There is nothing to reset until
|
||||||
|
// initialization completes.
|
||||||
|
if (! m_enabled || m_serializing || m_gizmos.empty())
|
||||||
return;
|
return;
|
||||||
|
|
||||||
const EType current = get_current_type();
|
const EType current = get_current_type();
|
||||||
@@ -435,6 +438,9 @@ void GLGizmosManager::reset_all_states()
|
|||||||
|
|
||||||
bool GLGizmosManager::open_gizmo(EType type)
|
bool GLGizmosManager::open_gizmo(EType type)
|
||||||
{
|
{
|
||||||
|
if (m_gizmos.empty())
|
||||||
|
return false;
|
||||||
|
|
||||||
int idx = static_cast<int>(type);
|
int idx = static_cast<int>(type);
|
||||||
|
|
||||||
// re-open same type cause closing
|
// re-open same type cause closing
|
||||||
@@ -522,7 +528,7 @@ bool GLGizmosManager::is_running() const
|
|||||||
|
|
||||||
bool GLGizmosManager::open_gizmo_by_shortcut(Shortcut shortcut)
|
bool GLGizmosManager::open_gizmo_by_shortcut(Shortcut shortcut)
|
||||||
{
|
{
|
||||||
if (!m_enabled)
|
if (!m_enabled || m_gizmos.empty())
|
||||||
return false;
|
return false;
|
||||||
|
|
||||||
// The text tool opens without a selection because it creates its own object.
|
// The text tool opens without a selection because it creates its own object.
|
||||||
@@ -1427,10 +1433,12 @@ void GLGizmosManager::update_hover_state(const EType &type)
|
|||||||
|
|
||||||
bool GLGizmosManager::activate_gizmo(EType type)
|
bool GLGizmosManager::activate_gizmo(EType type)
|
||||||
{
|
{
|
||||||
assert(!m_gizmos.empty());
|
|
||||||
|
|
||||||
// already activated
|
// already activated
|
||||||
if (m_current == type) return true;
|
if (m_current == type)
|
||||||
|
return true;
|
||||||
|
|
||||||
|
if (m_gizmos.empty())
|
||||||
|
return false;
|
||||||
|
|
||||||
if (m_current != Undefined) {
|
if (m_current != Undefined) {
|
||||||
// clean up previous gizmo
|
// clean up previous gizmo
|
||||||
|
|||||||
@@ -925,8 +925,9 @@ void GizmoObjectManipulation::do_render_move_window(ImGuiWrapper *imgui_wrapper,
|
|||||||
|
|
||||||
m_last_active_item = current_active_id;
|
m_last_active_item = current_active_id;
|
||||||
last_move_input_window_width = ImGui::GetWindowWidth();
|
last_move_input_window_width = ImGui::GetWindowWidth();
|
||||||
|
ImGui::PopStyleVar();
|
||||||
imgui_wrapper->end();
|
imgui_wrapper->end();
|
||||||
ImGui::PopStyleVar(2);
|
ImGui::PopStyleVar();
|
||||||
ImGuiWrapper::pop_toolbar_style();
|
ImGuiWrapper::pop_toolbar_style();
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1131,10 +1132,11 @@ void GizmoObjectManipulation::do_render_rotate_window(ImGuiWrapper *imgui_wrappe
|
|||||||
|
|
||||||
m_last_active_item = current_active_id;
|
m_last_active_item = current_active_id;
|
||||||
last_rotate_input_window_width = ImGui::GetWindowWidth();
|
last_rotate_input_window_width = ImGui::GetWindowWidth();
|
||||||
|
ImGui::PopStyleVar();
|
||||||
imgui_wrapper->end();
|
imgui_wrapper->end();
|
||||||
|
|
||||||
// BBS
|
// BBS
|
||||||
ImGui::PopStyleVar(2);
|
ImGui::PopStyleVar();
|
||||||
ImGuiWrapper::pop_toolbar_style();
|
ImGuiWrapper::pop_toolbar_style();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -1,6 +0,0 @@
|
|||||||
|
|
||||||
namespace Slic3r {
|
|
||||||
namespace GUI {
|
|
||||||
|
|
||||||
} // namespace GUI
|
|
||||||
} // namespace Slic3r
|
|
||||||
@@ -1,11 +0,0 @@
|
|||||||
#ifndef slic3r_MultiTaskModel_hpp_
|
|
||||||
#define slic3r_MultiTaskModel_hpp_
|
|
||||||
|
|
||||||
namespace Slic3r {
|
|
||||||
namespace GUI {
|
|
||||||
|
|
||||||
|
|
||||||
} // namespace GUI
|
|
||||||
} // namespace Slic3r
|
|
||||||
|
|
||||||
#endif
|
|
||||||
@@ -1880,13 +1880,6 @@ void PartPlate::render_exclude_area(bool force_default_color) {
|
|||||||
// draw exclude area
|
// draw exclude area
|
||||||
glsafe(::glDepthMask(GL_FALSE));
|
glsafe(::glDepthMask(GL_FALSE));
|
||||||
|
|
||||||
if (m_selected) {
|
|
||||||
glsafe(::glColor4fv(select_color.data()));
|
|
||||||
}
|
|
||||||
else {
|
|
||||||
glsafe(::glColor4fv(unselect_color.data()));
|
|
||||||
}
|
|
||||||
|
|
||||||
m_exclude_triangles.set_color(m_selected ? select_color : unselect_color);
|
m_exclude_triangles.set_color(m_selected ? select_color : unselect_color);
|
||||||
m_exclude_triangles.render();
|
m_exclude_triangles.render();
|
||||||
glsafe(::glDepthMask(GL_TRUE));
|
glsafe(::glDepthMask(GL_TRUE));
|
||||||
|
|||||||
+11
-24
@@ -14984,24 +14984,8 @@ bool Plater::priv::can_fix_through_cgal() const
|
|||||||
std::vector<int> obj_idxs, vol_idxs;
|
std::vector<int> obj_idxs, vol_idxs;
|
||||||
sidebar->obj_list()->get_selection_indexes(obj_idxs, vol_idxs);
|
sidebar->obj_list()->get_selection_indexes(obj_idxs, vol_idxs);
|
||||||
|
|
||||||
#if FIX_THROUGH_CGAL_ALWAYS
|
// A closed mesh may still self-intersect, so fixing is always allowed.
|
||||||
// Fixing always.
|
|
||||||
return ! obj_idxs.empty() || ! vol_idxs.empty();
|
return ! obj_idxs.empty() || ! vol_idxs.empty();
|
||||||
#else // FIX_THROUGH_CGAL_ALWAYS
|
|
||||||
// Fixing only if the model is not manifold.
|
|
||||||
if (vol_idxs.empty()) {
|
|
||||||
for (auto obj_idx : obj_idxs)
|
|
||||||
if (model.objects[obj_idx]->get_repaired_errors_count() > 0)
|
|
||||||
return true;
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
|
|
||||||
int obj_idx = obj_idxs.front();
|
|
||||||
for (auto vol_idx : vol_idxs)
|
|
||||||
if (model.objects[obj_idx]->get_repaired_errors_count(vol_idx) > 0)
|
|
||||||
return true;
|
|
||||||
return false;
|
|
||||||
#endif // FIX_THROUGH_CGAL_ALWAYS
|
|
||||||
}
|
}
|
||||||
|
|
||||||
bool Plater::priv::can_simplify() const
|
bool Plater::priv::can_simplify() const
|
||||||
@@ -22041,13 +22025,16 @@ void Plater::clear_before_change_mesh(int obj_idx)
|
|||||||
mv->mmu_segmentation_facets.reset();
|
mv->mmu_segmentation_facets.reset();
|
||||||
mv->fuzzy_skin_facets.reset();
|
mv->fuzzy_skin_facets.reset();
|
||||||
}
|
}
|
||||||
if (paint_removed) {
|
if (paint_removed)
|
||||||
// snapshot_time is captured by copy so the lambda knows where to undo/redo to.
|
notify_painting_removed();
|
||||||
get_notification_manager()->push_notification(
|
}
|
||||||
NotificationType::CustomSupportsAndSeamRemovedAfterRepair,
|
|
||||||
NotificationManager::NotificationLevel::PrintInfoNotificationLevel,
|
void Plater::notify_painting_removed()
|
||||||
_u8L("Custom supports and color painting were removed before repairing."));
|
{
|
||||||
}
|
get_notification_manager()->push_notification(
|
||||||
|
NotificationType::CustomSupportsAndSeamRemovedAfterRepair,
|
||||||
|
NotificationManager::NotificationLevel::PrintInfoNotificationLevel,
|
||||||
|
_u8L("Custom supports and color painting were removed before repairing."));
|
||||||
}
|
}
|
||||||
|
|
||||||
void Plater::changed_mesh(int obj_idx)
|
void Plater::changed_mesh(int obj_idx)
|
||||||
|
|||||||
@@ -599,6 +599,7 @@ public:
|
|||||||
void reslice_SLA_until_step(SLAPrintObjectStep step, const ModelObject &object, bool postpone_error_messages = false);
|
void reslice_SLA_until_step(SLAPrintObjectStep step, const ModelObject &object, bool postpone_error_messages = false);
|
||||||
|
|
||||||
void clear_before_change_mesh(int obj_idx);
|
void clear_before_change_mesh(int obj_idx);
|
||||||
|
void notify_painting_removed();
|
||||||
void changed_mesh(int obj_idx);
|
void changed_mesh(int obj_idx);
|
||||||
|
|
||||||
void changed_object(ModelObject &object);
|
void changed_object(ModelObject &object);
|
||||||
|
|||||||
@@ -1,232 +0,0 @@
|
|||||||
#include "SysInfoDialog.hpp"
|
|
||||||
#include "I18N.hpp"
|
|
||||||
#include "3DScene.hpp"
|
|
||||||
#include "GUI.hpp"
|
|
||||||
#include "../Utils/UndoRedo.hpp"
|
|
||||||
#include "Plater.hpp"
|
|
||||||
|
|
||||||
#include <string>
|
|
||||||
|
|
||||||
#include <Eigen/Core>
|
|
||||||
|
|
||||||
#include <wx/clipbrd.h>
|
|
||||||
#include <wx/platinfo.h>
|
|
||||||
#include "GUI_App.hpp"
|
|
||||||
#include "MainFrame.hpp"
|
|
||||||
#include "wxExtensions.hpp"
|
|
||||||
#include "libslic3r/BlacklistedLibraryCheck.hpp"
|
|
||||||
#include "libslic3r/Color.hpp"
|
|
||||||
#include "format.hpp"
|
|
||||||
|
|
||||||
#ifdef _WIN32
|
|
||||||
// The standard Windows includes.
|
|
||||||
#define WIN32_LEAN_AND_MEAN
|
|
||||||
#ifndef NOMINMAX
|
|
||||||
#define NOMINMAX
|
|
||||||
#endif
|
|
||||||
#include <Windows.h>
|
|
||||||
#include <psapi.h>
|
|
||||||
#endif /* _WIN32 */
|
|
||||||
|
|
||||||
namespace Slic3r {
|
|
||||||
namespace GUI {
|
|
||||||
|
|
||||||
std::string get_main_info(bool format_as_html)
|
|
||||||
{
|
|
||||||
std::stringstream out;
|
|
||||||
|
|
||||||
std::string b_start = format_as_html ? "<b>" : "";
|
|
||||||
std::string b_end = format_as_html ? "</b>" : "";
|
|
||||||
std::string line_end = format_as_html ? "<br>" : "\n";
|
|
||||||
|
|
||||||
if (!format_as_html)
|
|
||||||
out << b_start << (wxGetApp().is_editor() ? SLIC3R_APP_FULL_NAME : GCODEVIEWER_APP_NAME) << b_end << line_end;
|
|
||||||
out << b_start << "Version: " << b_end << SLIC3R_VERSION << line_end;
|
|
||||||
out << b_start << "Build: " << b_end << (wxGetApp().is_editor() ? SLIC3R_BUILD_ID : GCODEVIEWER_BUILD_ID) << line_end;
|
|
||||||
out << line_end;
|
|
||||||
out << b_start << "Operating System: " << b_end << wxPlatformInfo::Get().GetOperatingSystemFamilyName() << line_end;
|
|
||||||
out << b_start << "System Architecture: " << b_end << wxPlatformInfo::Get().GetArchName() << line_end;
|
|
||||||
out << b_start <<
|
|
||||||
#if defined _WIN32
|
|
||||||
"Windows Version: "
|
|
||||||
#else
|
|
||||||
// Hopefully some kind of unix / linux.
|
|
||||||
"System Version: "
|
|
||||||
#endif
|
|
||||||
<< b_end << wxPlatformInfo::Get().GetOperatingSystemDescription() << line_end;
|
|
||||||
out << b_start << "Total RAM size [MB]: " << b_end << Slic3r::format_memsize_MB(Slic3r::total_physical_memory());
|
|
||||||
|
|
||||||
return out.str();
|
|
||||||
}
|
|
||||||
|
|
||||||
std::string get_mem_info(bool format_as_html)
|
|
||||||
{
|
|
||||||
std::stringstream out;
|
|
||||||
|
|
||||||
std::string b_start = format_as_html ? "<b>" : "";
|
|
||||||
std::string b_end = format_as_html ? "</b>" : "";
|
|
||||||
std::string line_end = format_as_html ? "<br>" : "\n";
|
|
||||||
|
|
||||||
std::string mem_info_str = log_memory_info(true);
|
|
||||||
std::istringstream mem_info(mem_info_str);
|
|
||||||
std::string value;
|
|
||||||
while (std::getline(mem_info, value, ':')) {
|
|
||||||
out << b_start << (value+": ") << b_end;
|
|
||||||
std::getline(mem_info, value, ';');
|
|
||||||
out << value << line_end;
|
|
||||||
}
|
|
||||||
|
|
||||||
const Slic3r::UndoRedo::Stack &stack = wxGetApp().plater()->undo_redo_stack_main();
|
|
||||||
out << b_start << "RAM size reserved for the Undo / Redo stack: " << b_end << Slic3r::format_memsize_MB(stack.get_memory_limit()) << line_end;
|
|
||||||
out << b_start << "RAM size occupied by the Undo / Redo stack: " << b_end << Slic3r::format_memsize_MB(stack.memsize()) << line_end << line_end;
|
|
||||||
|
|
||||||
return out.str();
|
|
||||||
}
|
|
||||||
|
|
||||||
SysInfoDialog::SysInfoDialog()
|
|
||||||
: DPIDialog(static_cast<wxWindow*>(wxGetApp().mainframe), wxID_ANY, (wxGetApp().is_editor() ? wxString(SLIC3R_APP_FULL_NAME) : wxString(GCODEVIEWER_APP_NAME)) + " - " + _L("System Information"), wxDefaultPosition, wxDefaultSize, wxDEFAULT_DIALOG_STYLE | wxRESIZE_BORDER)
|
|
||||||
{
|
|
||||||
wxColour bgr_clr = wxGetApp().get_window_default_clr();//wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOW);
|
|
||||||
SetBackgroundColour(bgr_clr);
|
|
||||||
SetFont(wxGetApp().normal_font());
|
|
||||||
|
|
||||||
wxBoxSizer* hsizer = new wxBoxSizer(wxHORIZONTAL);
|
|
||||||
hsizer->SetMinSize(wxSize(50 * wxGetApp().em_unit(), -1));
|
|
||||||
|
|
||||||
auto main_sizer = new wxBoxSizer(wxVERTICAL);
|
|
||||||
main_sizer->Add(hsizer, 1, wxEXPAND | wxALL, 10);
|
|
||||||
|
|
||||||
// logo
|
|
||||||
m_logo_bmp = ScalableBitmap(this, wxGetApp().logo_name(), 192);
|
|
||||||
m_logo = new wxStaticBitmap(this, wxID_ANY, m_logo_bmp.bmp());
|
|
||||||
hsizer->Add(m_logo, 0, wxALIGN_CENTER_VERTICAL);
|
|
||||||
|
|
||||||
wxBoxSizer* vsizer = new wxBoxSizer(wxVERTICAL);
|
|
||||||
hsizer->Add(vsizer, 1, wxEXPAND|wxLEFT, 20);
|
|
||||||
|
|
||||||
// title
|
|
||||||
{
|
|
||||||
wxStaticText* title = new wxStaticText(this, wxID_ANY, wxGetApp().is_editor() ? SLIC3R_APP_FULL_NAME : GCODEVIEWER_APP_NAME, wxDefaultPosition, wxDefaultSize);
|
|
||||||
wxFont title_font = wxGetApp().bold_font();
|
|
||||||
title_font.SetFamily(wxFONTFAMILY_ROMAN);
|
|
||||||
title_font.SetPointSize(22);
|
|
||||||
title->SetFont(title_font);
|
|
||||||
vsizer->Add(title, 0, wxEXPAND | wxTOP, wxGetApp().em_unit()/*50*/);
|
|
||||||
}
|
|
||||||
|
|
||||||
// main_info_text
|
|
||||||
wxFont font = get_default_font(this);
|
|
||||||
const auto text_clr = wxGetApp().get_label_clr_default();//wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOWTEXT);
|
|
||||||
auto text_clr_str = encode_color(ColorRGB(text_clr.Red(), text_clr.Green(), text_clr.Blue()));
|
|
||||||
auto bgr_clr_str = encode_color(ColorRGB(bgr_clr.Red(), bgr_clr.Green(), bgr_clr.Blue()));
|
|
||||||
|
|
||||||
const int fs = font.GetPointSize() - 1;
|
|
||||||
int size[] = { static_cast<int>(fs*1.5), static_cast<int>(fs*1.4), static_cast<int>(fs*1.3), fs, fs, fs, fs };
|
|
||||||
|
|
||||||
m_html = new wxHtmlWindow(this, wxID_ANY, wxDefaultPosition, wxDefaultSize, wxHW_SCROLLBAR_NEVER);
|
|
||||||
{
|
|
||||||
m_html->SetFonts(font.GetFaceName(), font.GetFaceName(), size);
|
|
||||||
m_html->SetBorders(2);
|
|
||||||
const auto text = wxString::Format(
|
|
||||||
"<html>"
|
|
||||||
"<body bgcolor= %s link= %s>"
|
|
||||||
"<font color=%s>"
|
|
||||||
"%s"
|
|
||||||
"</font>"
|
|
||||||
"</body>"
|
|
||||||
"</html>", bgr_clr_str, text_clr_str, text_clr_str,
|
|
||||||
get_main_info(true));
|
|
||||||
m_html->SetPage(text);
|
|
||||||
vsizer->Add(m_html, 1, wxEXPAND | wxBOTTOM, wxGetApp().em_unit());
|
|
||||||
}
|
|
||||||
|
|
||||||
// opengl_info
|
|
||||||
m_opengl_info_html = new wxHtmlWindow(this, wxID_ANY, wxDefaultPosition, wxDefaultSize, wxHW_SCROLLBAR_AUTO);
|
|
||||||
{
|
|
||||||
m_opengl_info_html->SetMinSize(wxSize(-1, 16 * wxGetApp().em_unit()));
|
|
||||||
m_opengl_info_html->SetFonts(font.GetFaceName(), font.GetFaceName(), size);
|
|
||||||
m_opengl_info_html->SetBorders(10);
|
|
||||||
wxString blacklisted_libraries_message;
|
|
||||||
#ifdef WIN32
|
|
||||||
std::wstring blacklisted_libraries = BlacklistedLibraryCheck::get_instance().get_blacklisted_string().c_str();
|
|
||||||
if (! blacklisted_libraries.empty())
|
|
||||||
blacklisted_libraries_message = wxString("<br><b>") + _L("Blacklisted libraries loaded into OrcaSlicer process:") + "</b><br>" + blacklisted_libraries;
|
|
||||||
#endif // WIN32
|
|
||||||
const auto text = GUI::format_wxstr(
|
|
||||||
"<html>"
|
|
||||||
"<body bgcolor= %s link= %s>"
|
|
||||||
"<font color=%s>"
|
|
||||||
"%s<br>%s<br>%s<br>%s"
|
|
||||||
"</font>"
|
|
||||||
"</body>"
|
|
||||||
"</html>", bgr_clr_str, text_clr_str, text_clr_str,
|
|
||||||
blacklisted_libraries_message,
|
|
||||||
get_mem_info(true), wxGetApp().get_gl_info(false),
|
|
||||||
"<b>" + _L("SIMD is supported:") + "</b> " + Eigen::SimdInstructionSetsInUse());
|
|
||||||
|
|
||||||
m_opengl_info_html->SetPage(text);
|
|
||||||
main_sizer->Add(m_opengl_info_html, 1, wxEXPAND | wxBOTTOM, 15);
|
|
||||||
}
|
|
||||||
|
|
||||||
wxStdDialogButtonSizer* buttons = this->CreateStdDialogButtonSizer(wxOK);
|
|
||||||
m_btn_copy_to_clipboard = new wxButton(this, wxID_ANY, _L("Copy to Clipboard"), wxDefaultPosition, wxDefaultSize);
|
|
||||||
|
|
||||||
buttons->Insert(0, m_btn_copy_to_clipboard, 0, wxALIGN_CENTER_VERTICAL | wxLEFT, 5);
|
|
||||||
m_btn_copy_to_clipboard->Bind(wxEVT_BUTTON, &SysInfoDialog::onCopyToClipboard, this);
|
|
||||||
|
|
||||||
this->SetEscapeId(wxID_OK);
|
|
||||||
this->Bind(wxEVT_BUTTON, &SysInfoDialog::onCloseDialog, this, wxID_OK);
|
|
||||||
main_sizer->Add(buttons, 0, wxEXPAND | wxRIGHT | wxBOTTOM, 3);
|
|
||||||
|
|
||||||
wxGetApp().UpdateDlgDarkUI(this, true);
|
|
||||||
|
|
||||||
// this->Bind(wxEVT_LEFT_DOWN, &SysInfoDialog::onCloseDialog, this);
|
|
||||||
// logo->Bind(wxEVT_LEFT_DOWN, &SysInfoDialog::onCloseDialog, this);
|
|
||||||
|
|
||||||
SetSizer(main_sizer);
|
|
||||||
main_sizer->SetSizeHints(this);
|
|
||||||
}
|
|
||||||
|
|
||||||
void SysInfoDialog::on_dpi_changed(const wxRect &suggested_rect)
|
|
||||||
{
|
|
||||||
m_logo_bmp.msw_rescale();
|
|
||||||
m_logo->SetBitmap(m_logo_bmp.bmp());
|
|
||||||
|
|
||||||
wxFont font = get_default_font(this);
|
|
||||||
const int fs = font.GetPointSize() - 1;
|
|
||||||
int font_size[] = { static_cast<int>(fs*1.5), static_cast<int>(fs*1.4), static_cast<int>(fs*1.3), fs, fs, fs, fs };
|
|
||||||
|
|
||||||
m_html->SetFonts(font.GetFaceName(), font.GetFaceName(), font_size);
|
|
||||||
m_html->Refresh();
|
|
||||||
|
|
||||||
const int& em = em_unit();
|
|
||||||
|
|
||||||
msw_buttons_rescale(this, em, { wxID_OK, m_btn_copy_to_clipboard->GetId() });
|
|
||||||
|
|
||||||
m_opengl_info_html->SetMinSize(wxSize(-1, 16 * em));
|
|
||||||
m_opengl_info_html->SetFonts(font.GetFaceName(), font.GetFaceName(), font_size);
|
|
||||||
m_opengl_info_html->Refresh();
|
|
||||||
|
|
||||||
const wxSize& size = wxSize(65 * em, 55 * em);
|
|
||||||
|
|
||||||
SetMinSize(size);
|
|
||||||
Fit();
|
|
||||||
|
|
||||||
Refresh();
|
|
||||||
}
|
|
||||||
|
|
||||||
void SysInfoDialog::onCopyToClipboard(wxEvent &)
|
|
||||||
{
|
|
||||||
wxTheClipboard->Open();
|
|
||||||
const auto text = get_main_info(false) + "\n" + wxGetApp().get_gl_info(true);
|
|
||||||
wxTheClipboard->SetData(new wxTextDataObject(text));
|
|
||||||
wxTheClipboard->Close();
|
|
||||||
}
|
|
||||||
|
|
||||||
void SysInfoDialog::onCloseDialog(wxEvent &)
|
|
||||||
{
|
|
||||||
this->EndModal(wxID_CLOSE);
|
|
||||||
}
|
|
||||||
|
|
||||||
} // namespace GUI
|
|
||||||
} // namespace Slic3r
|
|
||||||
@@ -1,36 +0,0 @@
|
|||||||
#ifndef slic3r_GUI_SysInfoDialog_hpp_
|
|
||||||
#define slic3r_GUI_SysInfoDialog_hpp_
|
|
||||||
|
|
||||||
#include <wx/event.h>
|
|
||||||
#include <wx/wx.h>
|
|
||||||
#include <wx/html/htmlwin.h>
|
|
||||||
|
|
||||||
#include "GUI_Utils.hpp"
|
|
||||||
#include "wxExtensions.hpp"
|
|
||||||
|
|
||||||
namespace Slic3r {
|
|
||||||
namespace GUI {
|
|
||||||
|
|
||||||
class SysInfoDialog : public DPIDialog
|
|
||||||
{
|
|
||||||
ScalableBitmap m_logo_bmp;
|
|
||||||
wxStaticBitmap* m_logo;
|
|
||||||
wxHtmlWindow* m_opengl_info_html;
|
|
||||||
wxHtmlWindow* m_html;
|
|
||||||
|
|
||||||
wxButton* m_btn_copy_to_clipboard;
|
|
||||||
|
|
||||||
public:
|
|
||||||
SysInfoDialog();
|
|
||||||
|
|
||||||
protected:
|
|
||||||
void on_dpi_changed(const wxRect &suggested_rect) override;
|
|
||||||
|
|
||||||
private:
|
|
||||||
void onCopyToClipboard(wxEvent &);
|
|
||||||
void onCloseDialog(wxEvent &);
|
|
||||||
};
|
|
||||||
} // namespace GUI
|
|
||||||
} // namespace Slic3r
|
|
||||||
|
|
||||||
#endif
|
|
||||||
@@ -3098,6 +3098,7 @@ void TabPrint::build()
|
|||||||
optgroup = page->new_optgroup(L("Raft"), L"param_raft");
|
optgroup = page->new_optgroup(L("Raft"), L"param_raft");
|
||||||
optgroup->append_single_option_line("raft_layers", "support_settings_raft");
|
optgroup->append_single_option_line("raft_layers", "support_settings_raft");
|
||||||
optgroup->append_single_option_line("raft_contact_distance", "support_settings_raft");
|
optgroup->append_single_option_line("raft_contact_distance", "support_settings_raft");
|
||||||
|
optgroup->append_single_option_line("raft_expansion", "support_settings_raft");
|
||||||
|
|
||||||
optgroup = page->new_optgroup(L("Filament for Supports"), L"param_support_filament");
|
optgroup = page->new_optgroup(L("Filament for Supports"), L"param_support_filament");
|
||||||
optgroup->append_single_option_line("support_filament", "support_settings_filament#base");
|
optgroup->append_single_option_line("support_filament", "support_settings_filament#base");
|
||||||
|
|||||||
@@ -14,7 +14,7 @@
|
|||||||
#include "Widgets/StateColor.hpp"
|
#include "Widgets/StateColor.hpp"
|
||||||
#include "Widgets/StaticLine.hpp"
|
#include "Widgets/StaticLine.hpp"
|
||||||
#include "libslic3r/ColorDecomposeRecipe.hpp"
|
#include "libslic3r/ColorDecomposeRecipe.hpp"
|
||||||
#include "libslic3r/MeshBoolean.hpp"
|
#include "libslic3r/MeshRepair.hpp"
|
||||||
#include "libslic3r/TriangleSelector.hpp"
|
#include "libslic3r/TriangleSelector.hpp"
|
||||||
|
|
||||||
#include <utility>
|
#include <utility>
|
||||||
@@ -2436,25 +2436,25 @@ void TextureImportDialog::start_computation(bool auto_color, bool initial)
|
|||||||
settings.target_colors_num = auto_color ? 0 : (size_t)m_param_color_count;
|
settings.target_colors_num = auto_color ? 0 : (size_t)m_param_color_count;
|
||||||
settings.smooth_weight = m_param_smooth / 10.0;
|
settings.smooth_weight = m_param_smooth / 10.0;
|
||||||
settings.mesh_repair_decision = m_mesh_repair_decision;
|
settings.mesh_repair_decision = m_mesh_repair_decision;
|
||||||
// BBS repairs the mesh through the Windows 3D SDK, which is only available on Windows
|
|
||||||
// builds that ship the SDK. Orca's CGAL-based repair (MeshBoolean::cgal::repair) works
|
|
||||||
// on all three platforms, so use that instead.
|
|
||||||
settings.mesh_repair_callback = [](const indexed_triangle_set& mesh,
|
settings.mesh_repair_callback = [](const indexed_triangle_set& mesh,
|
||||||
indexed_triangle_set& repaired_mesh,
|
indexed_triangle_set& repaired_mesh,
|
||||||
std::function<void(const char*, unsigned)> progress_callback,
|
std::function<void(const char*, unsigned)> progress_callback,
|
||||||
std::function<bool()> cancel_callback,
|
std::function<bool()> cancel_callback,
|
||||||
std::string* error_message) -> bool {
|
std::string* error_message) -> bool {
|
||||||
if (cancel_callback && cancel_callback())
|
|
||||||
return false;
|
|
||||||
if (progress_callback)
|
if (progress_callback)
|
||||||
progress_callback(_u8L("Repairing mesh").c_str(), 0);
|
progress_callback(_u8L("Repairing mesh").c_str(), 0);
|
||||||
|
|
||||||
|
struct Canceled {};
|
||||||
TriangleMesh tm(mesh);
|
TriangleMesh tm(mesh);
|
||||||
if (!MeshBoolean::cgal::repair(tm, nullptr, error_message))
|
try {
|
||||||
return false;
|
if (!repair_mesh(tm, nullptr, error_message, [&cancel_callback](int) {
|
||||||
|
if (cancel_callback && cancel_callback())
|
||||||
if (cancel_callback && cancel_callback())
|
throw Canceled();
|
||||||
|
}))
|
||||||
|
return false;
|
||||||
|
} catch (const Canceled &) {
|
||||||
return false;
|
return false;
|
||||||
|
}
|
||||||
repaired_mesh = tm.its;
|
repaired_mesh = tm.its;
|
||||||
if (progress_callback)
|
if (progress_callback)
|
||||||
progress_callback(_u8L("Repairing mesh").c_str(), 100);
|
progress_callback(_u8L("Repairing mesh").c_str(), 100);
|
||||||
@@ -2683,12 +2683,12 @@ void TextureImportDialog::on_mesh_repair_decision_required(wxCommandEvent&)
|
|||||||
m_progress_dlg = nullptr;
|
m_progress_dlg = nullptr;
|
||||||
}
|
}
|
||||||
|
|
||||||
#ifdef HAS_WIN10SDK
|
|
||||||
Slic3r::GUI::MessageDialog dlg(initial ? GetParent() : this,
|
Slic3r::GUI::MessageDialog dlg(initial ? GetParent() : this,
|
||||||
_L("The mesh has non-manifold geometry or open boundaries. You can import it as-is or repair it with Windows 3D repair service before importing."),
|
_L("The mesh has non-manifold geometry or open boundaries. You can import it as-is or repair it before importing."),
|
||||||
_L("Mesh repair"), wxYES_NO | wxICON_WARNING | wxYES_DEFAULT);
|
_L("Mesh repair"), wxYES_NO | wxCANCEL | wxICON_WARNING | wxYES_DEFAULT);
|
||||||
dlg.SetButtonLabel(wxID_YES, _L("Import without repair"));
|
dlg.SetButtonLabel(wxID_YES, _L("Import without repair"));
|
||||||
dlg.SetButtonLabel(wxID_NO, _L("Repair and import"), true);
|
dlg.SetButtonLabel(wxID_NO, _L("Repair and import"), true);
|
||||||
|
dlg.SetButtonLabel(wxID_CANCEL, _L("Cancel"));
|
||||||
// "Repair and import" is the recommended action here, so the accent moves off the default YES
|
// "Repair and import" is the recommended action here, so the accent moves off the default YES
|
||||||
// button onto NO. MsgDialog::add_button already styled both as ButtonType::Choice, so restyling
|
// button onto NO. MsgDialog::add_button already styled both as ButtonType::Choice, so restyling
|
||||||
// with the same type swaps only the palette and leaves the geometry alone.
|
// with the same type swaps only the palette and leaves the geometry alone.
|
||||||
@@ -2704,17 +2704,7 @@ void TextureImportDialog::on_mesh_repair_decision_required(wxCommandEvent&)
|
|||||||
dlg.Fit();
|
dlg.Fit();
|
||||||
dlg.CenterOnParent();
|
dlg.CenterOnParent();
|
||||||
int ret = dlg.ShowModal();
|
int ret = dlg.ShowModal();
|
||||||
m_mesh_repair_decision = (ret == wxID_NO)
|
if (ret == wxID_CANCEL) {
|
||||||
? Slic3r::TexturePaintingSettings::MeshRepairDecision::RepairAndImport
|
|
||||||
: Slic3r::TexturePaintingSettings::MeshRepairDecision::ImportWithoutRepair;
|
|
||||||
#else
|
|
||||||
Slic3r::GUI::MessageDialog dlg(initial ? GetParent() : this,
|
|
||||||
_L("Please note that the mesh has non-manifold geometry or open boundaries."),
|
|
||||||
_L("Mesh issue"), wxOK | wxCANCEL | wxICON_WARNING | wxOK_DEFAULT);
|
|
||||||
dlg.SetButtonLabel(wxID_OK, _L("Continue"), true);
|
|
||||||
dlg.SetButtonLabel(wxID_CANCEL, _L("Cancel"));
|
|
||||||
int ret = dlg.ShowModal();
|
|
||||||
if (ret != wxID_OK) {
|
|
||||||
m_cancel_flag = true;
|
m_cancel_flag = true;
|
||||||
if (initial) {
|
if (initial) {
|
||||||
m_initial_computation_cancelled = true;
|
m_initial_computation_cancelled = true;
|
||||||
@@ -2727,8 +2717,9 @@ void TextureImportDialog::on_mesh_repair_decision_required(wxCommandEvent&)
|
|||||||
}
|
}
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
m_mesh_repair_decision = Slic3r::TexturePaintingSettings::MeshRepairDecision::ImportWithoutRepair;
|
m_mesh_repair_decision = (ret == wxID_NO)
|
||||||
#endif
|
? Slic3r::TexturePaintingSettings::MeshRepairDecision::RepairAndImport
|
||||||
|
: Slic3r::TexturePaintingSettings::MeshRepairDecision::ImportWithoutRepair;
|
||||||
|
|
||||||
start_computation(auto_color, initial);
|
start_computation(auto_color, initial);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -27,6 +27,7 @@
|
|||||||
#include <wx/mstream.h>
|
#include <wx/mstream.h>
|
||||||
|
|
||||||
#include "libslic3r/PNGReadWrite.hpp"
|
#include "libslic3r/PNGReadWrite.hpp"
|
||||||
|
#include "libslic3r/TextureDisplacement.hpp"
|
||||||
#include "libslic3r/Utils.hpp"
|
#include "libslic3r/Utils.hpp"
|
||||||
|
|
||||||
#include "libslic3r/AppConfig.hpp"
|
#include "libslic3r/AppConfig.hpp"
|
||||||
@@ -158,6 +159,28 @@ bool encode_png_bytes(const wxImage &image, std::vector<unsigned char> &out, std
|
|||||||
: encode_gray_png_bytes(image, out, error);
|
: encode_gray_png_bytes(image, out, error);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// A wxImage over decoded pixels, so the encoders above can be reached from an in-memory image as well as
|
||||||
|
// from a file. Grayscale is expanded to the three equal channels wxImage always stores, which is what
|
||||||
|
// image_has_color() then reads as "no colour" - so a grey image still encodes as a grayscale PNG.
|
||||||
|
//
|
||||||
|
// `scratch` holds the pixel buffer: the wxImage is constructed over it without taking ownership, so it
|
||||||
|
// has to outlive every use of the returned image.
|
||||||
|
wxImage image_from_decoded(const DecodedHeightTexture &image, std::vector<unsigned char> &scratch)
|
||||||
|
{
|
||||||
|
if (image.empty())
|
||||||
|
return wxImage();
|
||||||
|
|
||||||
|
const size_t n = size_t(image.width) * size_t(image.height);
|
||||||
|
scratch.resize(n * 3);
|
||||||
|
if (image.has_color())
|
||||||
|
scratch.assign(image.rgb.begin(), image.rgb.end());
|
||||||
|
else
|
||||||
|
for (size_t i = 0; i < n; ++i)
|
||||||
|
scratch[i * 3] = scratch[i * 3 + 1] = scratch[i * 3 + 2] = image.pixels[i];
|
||||||
|
|
||||||
|
return wxImage(image.width, image.height, scratch.data(), /* static_data */ true);
|
||||||
|
}
|
||||||
|
|
||||||
std::vector<unsigned char> read_file_bytes(const std::string &path)
|
std::vector<unsigned char> read_file_bytes(const std::string &path)
|
||||||
{
|
{
|
||||||
std::ifstream ifs(path, std::ios::binary);
|
std::ifstream ifs(path, std::ios::binary);
|
||||||
@@ -186,6 +209,42 @@ bool is_supported_height_map(const std::vector<unsigned char> &bytes)
|
|||||||
std::vector<TextureLibraryEntry> g_library;
|
std::vector<TextureLibraryEntry> g_library;
|
||||||
bool g_library_scanned = false;
|
bool g_library_scanned = false;
|
||||||
|
|
||||||
|
// Writes `bytes` into the user's own texture folder as `stem`.png, uniquified so an existing texture -
|
||||||
|
// shipped-name collision, or a second edit of the same source - is never overwritten. Returns the new
|
||||||
|
// file's library entry. Shared by import_texture_to_library() and save_texture_to_library(), which
|
||||||
|
// differ only in where their bytes came from.
|
||||||
|
std::optional<TextureLibraryEntry> write_user_texture(const std::vector<unsigned char> &bytes, const std::string &stem,
|
||||||
|
std::string &error)
|
||||||
|
{
|
||||||
|
const std::string user_dir = user_texture_dir();
|
||||||
|
if (user_dir.empty()) {
|
||||||
|
error = _u8L("Could not create the folder for imported textures.");
|
||||||
|
return std::nullopt;
|
||||||
|
}
|
||||||
|
|
||||||
|
boost::filesystem::path dest = boost::filesystem::path(user_dir) / (stem + ".png");
|
||||||
|
for (int i = 2; boost::filesystem::exists(dest); ++i)
|
||||||
|
dest = boost::filesystem::path(user_dir) / (stem + " (" + std::to_string(i) + ").png");
|
||||||
|
|
||||||
|
{
|
||||||
|
boost::nowide::ofstream ofs(dest.string(), std::ios::binary);
|
||||||
|
ofs.write(reinterpret_cast<const char *>(bytes.data()), std::streamsize(bytes.size()));
|
||||||
|
if (!ofs.good()) {
|
||||||
|
error = _u8L("Failed to save the imported texture.");
|
||||||
|
return std::nullopt;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
texture_library(true); // pick the new file up
|
||||||
|
const std::string dest_str = dest.string();
|
||||||
|
for (const TextureLibraryEntry &e : g_library)
|
||||||
|
if (e.path == dest_str)
|
||||||
|
return e;
|
||||||
|
|
||||||
|
error = _u8L("Failed to save the imported texture.");
|
||||||
|
return std::nullopt;
|
||||||
|
}
|
||||||
|
|
||||||
// The user's own textures, most recently used first, kept in the app config. File names are stored rather
|
// The user's own textures, most recently used first, kept in the app config. File names are stored rather
|
||||||
// than paths so the order survives a moved data directory; '/' separates them because no platform allows
|
// than paths so the order survives a moved data directory; '/' separates them because no platform allows
|
||||||
// it inside a file name. Bounded so a long-lived config does not grow a line without end.
|
// it inside a file name. Bounded so a long-lived config does not grow a line without end.
|
||||||
@@ -317,12 +376,6 @@ bool remove_user_texture(const std::string &path, std::string &error)
|
|||||||
|
|
||||||
std::optional<TextureLibraryEntry> import_texture_to_library(const std::string &source_path, std::string &error)
|
std::optional<TextureLibraryEntry> import_texture_to_library(const std::string &source_path, std::string &error)
|
||||||
{
|
{
|
||||||
const std::string user_dir = user_texture_dir();
|
|
||||||
if (user_dir.empty()) {
|
|
||||||
error = _u8L("Could not create the folder for imported textures.");
|
|
||||||
return std::nullopt;
|
|
||||||
}
|
|
||||||
|
|
||||||
wxImage image;
|
wxImage image;
|
||||||
if (!image.LoadFile(from_u8(source_path)) || !image.IsOk()) {
|
if (!image.LoadFile(from_u8(source_path)) || !image.IsOk()) {
|
||||||
error = _u8L("Could not load the selected image.");
|
error = _u8L("Could not load the selected image.");
|
||||||
@@ -333,30 +386,7 @@ std::optional<TextureLibraryEntry> import_texture_to_library(const std::string &
|
|||||||
if (!encode_png_bytes(image, bytes, error))
|
if (!encode_png_bytes(image, bytes, error))
|
||||||
return std::nullopt;
|
return std::nullopt;
|
||||||
|
|
||||||
// Never overwrite an existing texture (the user's or, if they picked the same name twice, their
|
return write_user_texture(bytes, boost::filesystem::path(source_path).stem().string(), error);
|
||||||
// own earlier import) - uniquify instead.
|
|
||||||
const std::string stem = boost::filesystem::path(source_path).stem().string();
|
|
||||||
boost::filesystem::path dest = boost::filesystem::path(user_dir) / (stem + ".png");
|
|
||||||
for (int i = 2; boost::filesystem::exists(dest); ++i)
|
|
||||||
dest = boost::filesystem::path(user_dir) / (stem + " (" + std::to_string(i) + ").png");
|
|
||||||
|
|
||||||
{
|
|
||||||
boost::nowide::ofstream ofs(dest.string(), std::ios::binary);
|
|
||||||
ofs.write(reinterpret_cast<const char *>(bytes.data()), std::streamsize(bytes.size()));
|
|
||||||
if (!ofs.good()) {
|
|
||||||
error = _u8L("Failed to save the imported texture.");
|
|
||||||
return std::nullopt;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
texture_library(true); // pick the new file up
|
|
||||||
const std::string dest_str = dest.string();
|
|
||||||
for (const TextureLibraryEntry &e : g_library)
|
|
||||||
if (e.path == dest_str)
|
|
||||||
return e;
|
|
||||||
|
|
||||||
error = _u8L("Failed to save the imported texture.");
|
|
||||||
return std::nullopt;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
std::shared_ptr<std::vector<unsigned char>> load_texture_image_data(const std::string &path, std::string &error)
|
std::shared_ptr<std::vector<unsigned char>> load_texture_image_data(const std::string &path, std::string &error)
|
||||||
@@ -382,4 +412,21 @@ std::shared_ptr<std::vector<unsigned char>> load_texture_image_data(const std::s
|
|||||||
return std::make_shared<std::vector<unsigned char>>(std::move(converted));
|
return std::make_shared<std::vector<unsigned char>>(std::move(converted));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
std::optional<TextureLibraryEntry> save_texture_to_library(const DecodedHeightTexture &image, const std::string &stem,
|
||||||
|
std::string &error)
|
||||||
|
{
|
||||||
|
std::vector<unsigned char> scratch;
|
||||||
|
const wxImage wx = image_from_decoded(image, scratch);
|
||||||
|
if (!wx.IsOk()) {
|
||||||
|
error = _u8L("The selected image is empty.");
|
||||||
|
return std::nullopt;
|
||||||
|
}
|
||||||
|
|
||||||
|
std::vector<unsigned char> bytes;
|
||||||
|
if (!encode_png_bytes(wx, bytes, error))
|
||||||
|
return std::nullopt;
|
||||||
|
|
||||||
|
return write_user_texture(bytes, stem.empty() ? std::string("texture") : stem, error);
|
||||||
|
}
|
||||||
|
|
||||||
} // namespace Slic3r::GUI
|
} // namespace Slic3r::GUI
|
||||||
|
|||||||
@@ -6,6 +6,8 @@
|
|||||||
#include <string>
|
#include <string>
|
||||||
#include <vector>
|
#include <vector>
|
||||||
|
|
||||||
|
#include "libslic3r/TextureDisplacement.hpp"
|
||||||
|
|
||||||
namespace Slic3r::GUI {
|
namespace Slic3r::GUI {
|
||||||
|
|
||||||
// One selectable height-map texture in the texture-displacement gizmo's texture picker.
|
// One selectable height-map texture in the texture-displacement gizmo's texture picker.
|
||||||
@@ -57,6 +59,14 @@ std::optional<TextureLibraryEntry> import_texture_to_library(const std::string &
|
|||||||
// Returns nullptr with `error` set if the file cannot be read or decoded at all.
|
// Returns nullptr with `error` set if the file cannot be read or decoded at all.
|
||||||
std::shared_ptr<std::vector<unsigned char>> load_texture_image_data(const std::string &path, std::string &error);
|
std::shared_ptr<std::vector<unsigned char>> load_texture_image_data(const std::string &path, std::string &error);
|
||||||
|
|
||||||
|
// Writes `image` into user_texture_dir() as a new PNG named after `stem` (uniquified if taken, so an
|
||||||
|
// existing texture is never overwritten) and returns its library entry. The in-memory counterpart of
|
||||||
|
// import_texture_to_library(), for an image that was edited rather than read off disk.
|
||||||
|
//
|
||||||
|
// Returns nullopt with `error` set on failure.
|
||||||
|
std::optional<TextureLibraryEntry> save_texture_to_library(const DecodedHeightTexture &image, const std::string &stem,
|
||||||
|
std::string &error);
|
||||||
|
|
||||||
} // namespace Slic3r::GUI
|
} // namespace Slic3r::GUI
|
||||||
|
|
||||||
#endif // slic3r_TextureLibrary_hpp_
|
#endif // slic3r_TextureLibrary_hpp_
|
||||||
|
|||||||
@@ -36,6 +36,7 @@
|
|||||||
|
|
||||||
#include "3DScene.hpp"
|
#include "3DScene.hpp"
|
||||||
#include "BitmapCache.hpp"
|
#include "BitmapCache.hpp"
|
||||||
|
#include "GLCanvas3D.hpp"
|
||||||
#include "GLShader.hpp"
|
#include "GLShader.hpp"
|
||||||
#include "GUI_App.hpp"
|
#include "GUI_App.hpp"
|
||||||
#include "I18N.hpp"
|
#include "I18N.hpp"
|
||||||
@@ -939,7 +940,8 @@ void UVEditorCanvas::on_mouse(wxMouseEvent &evt)
|
|||||||
m_active_edge = (hit.first >= 0 && is_edge_selected(hit)) ? hit : std::pair<int, int>{ -1, -1 };
|
m_active_edge = (hit.first >= 0 && is_edge_selected(hit)) ? hit : std::pair<int, int>{ -1, -1 };
|
||||||
m_gesture = (m_active_edge.first >= 0) ? Gesture::MoveEdge : Gesture::Pan;
|
m_gesture = (m_active_edge.first >= 0) ? Gesture::MoveEdge : Gesture::Pan;
|
||||||
} else {
|
} else {
|
||||||
const int hit = island_at(uv);
|
const std::vector<int> selection_before = m_selection;
|
||||||
|
const int hit = island_at(uv);
|
||||||
if (hit >= 0) {
|
if (hit >= 0) {
|
||||||
if (evt.ShiftDown()) {
|
if (evt.ShiftDown()) {
|
||||||
// Shift adds to the selection (and makes the clicked one the new primary).
|
// Shift adds to the selection (and makes the clicked one the new primary).
|
||||||
@@ -969,6 +971,10 @@ void UVEditorCanvas::on_mouse(wxMouseEvent &evt)
|
|||||||
m_selected_island = -1;
|
m_selected_island = -1;
|
||||||
}
|
}
|
||||||
m_gesture = (m_selected_island >= 0) ? Gesture::MoveIsland : Gesture::Pan;
|
m_gesture = (m_selected_island >= 0) ? Gesture::MoveIsland : Gesture::Pan;
|
||||||
|
// The owner shows the selection on the model and would not hear of this click otherwise in time: a
|
||||||
|
// click that clears the selection starts no gesture, and one that sets it reports only on release.
|
||||||
|
if (m_selection != selection_before)
|
||||||
|
run_command(Command::SelectionChanged);
|
||||||
}
|
}
|
||||||
grab_mouse();
|
grab_mouse();
|
||||||
Refresh();
|
Refresh();
|
||||||
@@ -1319,8 +1325,13 @@ void UVEditorCanvas::on_size(wxSizeEvent &evt)
|
|||||||
// Update() flushes it immediately - still through the normal paint path (unlike calling
|
// Update() flushes it immediately - still through the normal paint path (unlike calling
|
||||||
// render() directly), which matters because this canvas shares the app's one GL context with
|
// render() directly), which matters because this canvas shares the app's one GL context with
|
||||||
// the 3D view and must not hijack it outside its own paint.
|
// the 3D view and must not hijack it outside its own paint.
|
||||||
|
// Not while a 3D canvas frame is in progress, though: wxGTK delivers this size event synchronously
|
||||||
|
// when the texture displacement gizmo relays out the pane from its ImGui panel, i.e. from inside
|
||||||
|
// that frame, and flushing the paint there would take the shared context away from it. The Refresh()
|
||||||
|
// then runs the paint once the frame is over.
|
||||||
Refresh();
|
Refresh();
|
||||||
Update();
|
if (!GLCanvas3D::is_frame_in_progress())
|
||||||
|
Update();
|
||||||
}
|
}
|
||||||
|
|
||||||
void UVEditorCanvas::on_leave(wxMouseEvent &evt)
|
void UVEditorCanvas::on_leave(wxMouseEvent &evt)
|
||||||
@@ -1341,6 +1352,16 @@ void UVEditorCanvas::render()
|
|||||||
{
|
{
|
||||||
if (m_context == nullptr || !IsShownOnScreen())
|
if (m_context == nullptr || !IsShownOnScreen())
|
||||||
return;
|
return;
|
||||||
|
// Painted from inside a 3D canvas frame - a modal dialog the gizmo opened from its ImGui panel runs
|
||||||
|
// this paint, as does any other synchronous event raised there. Making this surface current now
|
||||||
|
// would take the shared context away from that canvas mid-frame: its remaining draws would land
|
||||||
|
// here and, on Mesa/X11, its SwapBuffers() would be a fatal BadMatch. Skip, but ask for another
|
||||||
|
// paint so the skipped one is not simply lost. The pane stays stale for as long as a nested modal
|
||||||
|
// loop keeps a frame on the stack, which is behind the dialog anyway.
|
||||||
|
if (GLCanvas3D::is_frame_in_progress()) {
|
||||||
|
Refresh();
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
// wxGLCanvas::SetCurrent() genuinely fails (returns false) on a canvas that isn't shown on
|
// wxGLCanvas::SetCurrent() genuinely fails (returns false) on a canvas that isn't shown on
|
||||||
// screen, and can also fail on a pixel-format mismatch with the context - and every GL call
|
// screen, and can also fail on a pixel-format mismatch with the context - and every GL call
|
||||||
|
|||||||
@@ -108,10 +108,12 @@ public:
|
|||||||
// the command callback - the canvas has the selection and the view, the gizmo has the layer.
|
// the command callback - the canvas has the selection and the view, the gizmo has the layer.
|
||||||
// `value` carries the new setting for the Set* commands (an angle, a flag as 0/1, or an index into
|
// `value` carries the new setting for the Set* commands (an angle, a flag as 0/1, or an index into
|
||||||
// SelectMode / Background) and is 0 otherwise.
|
// SelectMode / Background) and is 0 otherwise.
|
||||||
|
// SelectionChanged is sent by the canvas itself when a click changes the island selection. It carries
|
||||||
|
// nothing: the owner reads selected_islands() back, and only needs telling that it should look.
|
||||||
enum class Command {
|
enum class Command {
|
||||||
FrameAll, ToggleSnap, AverageScale, CutSelectedIsland, ProjectFromView, JoinSelected, UnjoinSelected,
|
FrameAll, ToggleSnap, AverageScale, CutSelectedIsland, ProjectFromView, JoinSelected, UnjoinSelected,
|
||||||
Unwrap, SetSeamAngle, SetConnectIslands, SetSelectMode, SetMarkSeams, SetSeamPath, ClearSeams, ClearUVEdits,
|
Unwrap, SetSeamAngle, SetConnectIslands, SetSelectMode, SetMarkSeams, SetSeamPath, ClearSeams, ClearUVEdits,
|
||||||
SetBackground, PickTexture, PaneClosed
|
SetBackground, PickTexture, PaneClosed, SelectionChanged
|
||||||
};
|
};
|
||||||
void run_command(Command cmd, float value = 0.f);
|
void run_command(Command cmd, float value = 0.f);
|
||||||
using CommandFn = std::function<void(Command, float)>;
|
using CommandFn = std::function<void(Command, float)>;
|
||||||
|
|||||||
@@ -27,8 +27,7 @@ WebDialog::WebDialog(wxWindow* parent,
|
|||||||
SubmitHandler on_submit,
|
SubmitHandler on_submit,
|
||||||
CloseHandler on_close,
|
CloseHandler on_close,
|
||||||
CloseHandler on_destroyed,
|
CloseHandler on_destroyed,
|
||||||
long wx_style,
|
long wx_style)
|
||||||
const wxString& profile)
|
|
||||||
: WebViewHostDialog(parent, wxID_ANY, title, wxDefaultPosition, size, wx_style)
|
: WebViewHostDialog(parent, wxID_ANY, title, wxDefaultPosition, size, wx_style)
|
||||||
, m_html(html)
|
, m_html(html)
|
||||||
, m_on_message(std::move(on_message))
|
, m_on_message(std::move(on_message))
|
||||||
@@ -38,7 +37,7 @@ WebDialog::WebDialog(wxWindow* parent,
|
|||||||
{
|
{
|
||||||
// A tiny bundled bootstrap page brings the webview up; the real plugin HTML
|
// A tiny bundled bootstrap page brings the webview up; the real plugin HTML
|
||||||
// is swapped in via SetPage once the bootstrap finishes loading.
|
// is swapped in via SetPage once the bootstrap finishes loading.
|
||||||
create_webview(web_hosting::BOOTSTRAP_PAGE, title, size, wxSize(320, 240), profile);
|
create_webview(web_hosting::BOOTSTRAP_PAGE, title, size, wxSize(320, 240));
|
||||||
|
|
||||||
// Paint the window/webview in the themed background so there is no white
|
// Paint the window/webview in the themed background so there is no white
|
||||||
// flash before the (transparent) bootstrap page and plugin HTML render.
|
// flash before the (transparent) bootstrap page and plugin HTML render.
|
||||||
|
|||||||
@@ -49,8 +49,7 @@ public:
|
|||||||
SubmitHandler on_submit,
|
SubmitHandler on_submit,
|
||||||
CloseHandler on_close,
|
CloseHandler on_close,
|
||||||
CloseHandler on_destroyed,
|
CloseHandler on_destroyed,
|
||||||
long wx_style = wxSYSTEM_MENU | wxCAPTION | wxCLOSE_BOX | wxMAXIMIZE_BOX | wxRESIZE_BORDER,
|
long wx_style = wxSYSTEM_MENU | wxCAPTION | wxCLOSE_BOX | wxMAXIMIZE_BOX | wxRESIZE_BORDER);
|
||||||
const wxString& profile = wxEmptyString);
|
|
||||||
~WebDialog() override;
|
~WebDialog() override;
|
||||||
|
|
||||||
static void post_message(WebDialog* dialog, const nlohmann::json& data);
|
static void post_message(WebDialog* dialog, const nlohmann::json& data);
|
||||||
|
|||||||
@@ -17,7 +17,7 @@
|
|||||||
|
|
||||||
namespace Slic3r { namespace GUI {
|
namespace Slic3r { namespace GUI {
|
||||||
|
|
||||||
WebPanel::WebPanel(wxWindow* parent, const char* bridge_script, const wxString& profile)
|
WebPanel::WebPanel(wxWindow* parent, const char* bridge_script)
|
||||||
: wxPanel(parent, wxID_ANY)
|
: wxPanel(parent, wxID_ANY)
|
||||||
{
|
{
|
||||||
SetBackgroundColour(wxGetApp().get_window_default_clr());
|
SetBackgroundColour(wxGetApp().get_window_default_clr());
|
||||||
@@ -25,7 +25,7 @@ WebPanel::WebPanel(wxWindow* parent, const char* bridge_script, const wxString&
|
|||||||
SetSizer(sizer);
|
SetSizer(sizer);
|
||||||
|
|
||||||
// Never null: WebView::CreateWebView substitutes a placeholder view when no backend is available.
|
// Never null: WebView::CreateWebView substitutes a placeholder view when no backend is available.
|
||||||
m_browser = WebView::CreateWebView(this, web_hosting::bootstrap_url(), profile);
|
m_browser = WebView::CreateWebView(this, web_hosting::bootstrap_url());
|
||||||
m_browser->SetBackgroundColour(GetBackgroundColour());
|
m_browser->SetBackgroundColour(GetBackgroundColour());
|
||||||
m_browser->AddUserScript(wxString::FromUTF8(WebViewHostDialog::theme_user_script()));
|
m_browser->AddUserScript(wxString::FromUTF8(WebViewHostDialog::theme_user_script()));
|
||||||
m_browser->AddUserScript(wxString::FromUTF8(WebViewHostDialog::element_defaults_user_script()));
|
m_browser->AddUserScript(wxString::FromUTF8(WebViewHostDialog::element_defaults_user_script()));
|
||||||
|
|||||||
@@ -4,7 +4,6 @@
|
|||||||
|
|
||||||
#include <wx/event.h>
|
#include <wx/event.h>
|
||||||
#include <wx/panel.h>
|
#include <wx/panel.h>
|
||||||
#include <wx/string.h>
|
|
||||||
#include <wx/webview.h>
|
#include <wx/webview.h>
|
||||||
|
|
||||||
#include <optional>
|
#include <optional>
|
||||||
@@ -23,7 +22,7 @@ namespace Slic3r { namespace GUI {
|
|||||||
class WebPanel : public wxPanel
|
class WebPanel : public wxPanel
|
||||||
{
|
{
|
||||||
public:
|
public:
|
||||||
WebPanel(wxWindow* parent, const char* bridge_script, const wxString& profile = wxEmptyString);
|
WebPanel(wxWindow* parent, const char* bridge_script);
|
||||||
|
|
||||||
protected:
|
protected:
|
||||||
wxWebView* browser() const { return m_browser; }
|
wxWebView* browser() const { return m_browser; }
|
||||||
|
|||||||
@@ -3,8 +3,6 @@
|
|||||||
#include "slic3r/GUI/GUI_App.hpp"
|
#include "slic3r/GUI/GUI_App.hpp"
|
||||||
#include "slic3r/Utils/MacDarkMode.hpp"
|
#include "slic3r/Utils/MacDarkMode.hpp"
|
||||||
|
|
||||||
#include <libslic3r/Utils.hpp>
|
|
||||||
|
|
||||||
#include <algorithm>
|
#include <algorithm>
|
||||||
#include <boost/log/trivial.hpp>
|
#include <boost/log/trivial.hpp>
|
||||||
|
|
||||||
@@ -14,7 +12,6 @@
|
|||||||
#include <exception>
|
#include <exception>
|
||||||
#include <thread>
|
#include <thread>
|
||||||
|
|
||||||
#include <wx/chartype.h>
|
|
||||||
#include <wx/setup.h>
|
#include <wx/setup.h>
|
||||||
#include <wx/webview.h>
|
#include <wx/webview.h>
|
||||||
#include <wx/string.h>
|
#include <wx/string.h>
|
||||||
@@ -75,26 +72,6 @@ webkit_javascript_result_unref (WebKitJavascriptResult *js_result);
|
|||||||
}
|
}
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
// Private storage root for an isolated (plugin) profile. Plugin pages must not reach the shared
|
|
||||||
// default store's cookies/session (e.g. the OrcaCloud login), so each profile gets its own dir.
|
|
||||||
// macOS isolates with an in-memory store instead (see CreateWebView), so this is unused there.
|
|
||||||
#if !defined(__WXOSX__)
|
|
||||||
static wxString isolated_profile_path(const wxString& profile)
|
|
||||||
{
|
|
||||||
wxString safe;
|
|
||||||
safe.reserve(profile.size());
|
|
||||||
for (wxString::const_iterator it = profile.begin(); it != profile.end(); ++it) {
|
|
||||||
const wxChar c = *it;
|
|
||||||
const bool keep = (c >= wxT('a') && c <= wxT('z')) || (c >= wxT('A') && c <= wxT('Z')) ||
|
|
||||||
(c >= wxT('0') && c <= wxT('9')) || c == wxT('.') || c == wxT('-') || c == wxT('_');
|
|
||||||
safe += keep ? c : wxT('_');
|
|
||||||
}
|
|
||||||
if (safe.empty())
|
|
||||||
safe = wxT("default");
|
|
||||||
return wxString::FromUTF8((boost::filesystem::path(Slic3r::data_dir()) / "web_profiles" / safe.ToStdString()).string());
|
|
||||||
}
|
|
||||||
#endif
|
|
||||||
|
|
||||||
#ifdef __WIN32__
|
#ifdef __WIN32__
|
||||||
// Run Download and Install in another thread so we don't block the UI thread
|
// Run Download and Install in another thread so we don't block the UI thread
|
||||||
DWORD DownloadAndInstallWV2RT() {
|
DWORD DownloadAndInstallWV2RT() {
|
||||||
@@ -158,9 +135,6 @@ DWORD DownloadAndInstallWV2RT() {
|
|||||||
class WebViewEdge : public wxWebViewEdge
|
class WebViewEdge : public wxWebViewEdge
|
||||||
{
|
{
|
||||||
public:
|
public:
|
||||||
WebViewEdge() = default;
|
|
||||||
explicit WebViewEdge(const wxWebViewConfiguration& config) : wxWebViewEdge(config) {}
|
|
||||||
|
|
||||||
bool SetUserAgent(const wxString &userAgent) override
|
bool SetUserAgent(const wxString &userAgent) override
|
||||||
{
|
{
|
||||||
bool dark = userAgent.Contains("dark");
|
bool dark = userAgent.Contains("dark");
|
||||||
@@ -239,11 +213,6 @@ public:
|
|||||||
{
|
{
|
||||||
}
|
}
|
||||||
|
|
||||||
explicit WebViewWebKit(const wxWebViewConfiguration& config)
|
|
||||||
: wxWebViewWebKit(config)
|
|
||||||
{
|
|
||||||
}
|
|
||||||
|
|
||||||
~WebViewWebKit() override
|
~WebViewWebKit() override
|
||||||
{
|
{
|
||||||
RemoveScriptMessageHandler("wx");
|
RemoveScriptMessageHandler("wx");
|
||||||
@@ -315,7 +284,7 @@ static WebViewRef *webview_ref(wxWebView *webView)
|
|||||||
return webView ? static_cast<WebViewRef *>(webView->GetRefData()) : nullptr;
|
return webView ? static_cast<WebViewRef *>(webView->GetRefData()) : nullptr;
|
||||||
}
|
}
|
||||||
|
|
||||||
wxWebView* WebView::CreateWebView(wxWindow * parent, wxString const & url, wxString const & profile)
|
wxWebView* WebView::CreateWebView(wxWindow * parent, wxString const & url)
|
||||||
{
|
{
|
||||||
#if wxUSE_WEBVIEW_EDGE
|
#if wxUSE_WEBVIEW_EDGE
|
||||||
// Check if a fixed version of edge is present in
|
// Check if a fixed version of edge is present in
|
||||||
@@ -335,36 +304,12 @@ wxWebView* WebView::CreateWebView(wxWindow * parent, wxString const & url, wxStr
|
|||||||
if (!url2.empty()) { url2 = wxURI(url2).BuildURI(); }
|
if (!url2.empty()) { url2 = wxURI(url2).BuildURI(); }
|
||||||
BOOST_LOG_TRIVIAL(trace) << __FUNCTION__ << ": " << url2.ToUTF8();
|
BOOST_LOG_TRIVIAL(trace) << __FUNCTION__ << ": " << url2.ToUTF8();
|
||||||
|
|
||||||
const bool isolated = !profile.IsEmpty();
|
|
||||||
|
|
||||||
#ifdef __WIN32__
|
#ifdef __WIN32__
|
||||||
wxWebView* webView = nullptr;
|
wxWebView* webView = new WebViewEdge;
|
||||||
if (isolated) {
|
|
||||||
wxWebViewConfiguration config = wxWebView::NewConfiguration(wxWebViewBackendEdge);
|
|
||||||
config.SetDataPath(isolated_profile_path(profile));
|
|
||||||
webView = new WebViewEdge(config);
|
|
||||||
} else {
|
|
||||||
webView = new WebViewEdge;
|
|
||||||
}
|
|
||||||
#elif defined(__WXOSX__)
|
#elif defined(__WXOSX__)
|
||||||
wxWebView* webView = nullptr;
|
wxWebView* webView = new WebViewWebKit;
|
||||||
if (isolated) {
|
|
||||||
// wx has no SetDataPath on macOS; give the view its own in-memory store instead.
|
|
||||||
wxWebViewConfiguration config = wxWebView::NewConfiguration(wxWebViewBackendWebKit);
|
|
||||||
Slic3r::GUI::WKWebViewConfiguration_setNonPersistentDataStore(config.GetNativeConfiguration());
|
|
||||||
webView = new WebViewWebKit(config);
|
|
||||||
} else {
|
|
||||||
webView = new WebViewWebKit;
|
|
||||||
}
|
|
||||||
#else
|
#else
|
||||||
wxWebView* webView = nullptr;
|
auto webView = wxWebView::New();
|
||||||
if (isolated) {
|
|
||||||
wxWebViewConfiguration config = wxWebView::NewConfiguration(wxWebViewBackendWebKit);
|
|
||||||
config.SetDataPath(isolated_profile_path(profile));
|
|
||||||
webView = wxWebView::New(config);
|
|
||||||
} else {
|
|
||||||
webView = wxWebView::New();
|
|
||||||
}
|
|
||||||
#endif
|
#endif
|
||||||
if (webView) {
|
if (webView) {
|
||||||
webView->SetBackgroundColour(StateColor::darkModeColorFor(*wxWHITE));
|
webView->SetBackgroundColour(StateColor::darkModeColorFor(*wxWHITE));
|
||||||
|
|||||||
@@ -14,11 +14,7 @@ wxDECLARE_EVENT(EVT_WEBVIEW_RECREATED, wxCommandEvent);
|
|||||||
class WebView
|
class WebView
|
||||||
{
|
{
|
||||||
public:
|
public:
|
||||||
// `profile` empty -> the shared default backend store used by all trusted UI.
|
static wxWebView *CreateWebView(wxWindow *parent, wxString const &url);
|
||||||
// `profile` non-empty -> a private store keyed by `profile`, so this view shares no
|
|
||||||
// cookies/storage/session with the shared store or any other profile. Used for
|
|
||||||
// plugin-supplied (untrusted) content.
|
|
||||||
static wxWebView *CreateWebView(wxWindow *parent, wxString const &url, wxString const &profile = wxEmptyString);
|
|
||||||
#if wxUSE_WEBVIEW_EDGE
|
#if wxUSE_WEBVIEW_EDGE
|
||||||
static bool CheckWebViewRuntime();
|
static bool CheckWebViewRuntime();
|
||||||
static bool DownloadAndInstallWebViewRuntime();
|
static bool DownloadAndInstallWebViewRuntime();
|
||||||
|
|||||||
@@ -172,8 +172,7 @@ WebViewHostDialog::WebViewHostDialog(wxWindow* parent,
|
|||||||
bool WebViewHostDialog::create_webview(const std::string& resource_path,
|
bool WebViewHostDialog::create_webview(const std::string& resource_path,
|
||||||
const wxString& title,
|
const wxString& title,
|
||||||
const wxSize& dialog_size,
|
const wxSize& dialog_size,
|
||||||
const wxSize& min_size,
|
const wxSize& min_size)
|
||||||
const wxString& profile)
|
|
||||||
{
|
{
|
||||||
SetTitle(title);
|
SetTitle(title);
|
||||||
SetMinSize(FromDIP(min_size));
|
SetMinSize(FromDIP(min_size));
|
||||||
@@ -182,7 +181,7 @@ bool WebViewHostDialog::create_webview(const std::string& resource_path,
|
|||||||
wxBoxSizer* topsizer = new wxBoxSizer(wxVERTICAL);
|
wxBoxSizer* topsizer = new wxBoxSizer(wxVERTICAL);
|
||||||
|
|
||||||
// Created empty and loaded below, after the user scripts are added, so the first load already has them.
|
// Created empty and loaded below, after the user scripts are added, so the first load already has them.
|
||||||
m_browser = WebView::CreateWebView(this, wxEmptyString, profile);
|
m_browser = WebView::CreateWebView(this, wxEmptyString);
|
||||||
if (m_browser == nullptr) {
|
if (m_browser == nullptr) {
|
||||||
wxLogError("Could not init m_browser");
|
wxLogError("Could not init m_browser");
|
||||||
delete topsizer;
|
delete topsizer;
|
||||||
|
|||||||
@@ -38,8 +38,7 @@ public:
|
|||||||
bool create_webview(const std::string& resource_path,
|
bool create_webview(const std::string& resource_path,
|
||||||
const wxString& title,
|
const wxString& title,
|
||||||
const wxSize& dialog_size = wxSize(820, 660),
|
const wxSize& dialog_size = wxSize(820, 660),
|
||||||
const wxSize& min_size = wxSize(640, 640),
|
const wxSize& min_size = wxSize(640, 640));
|
||||||
const wxString& profile = wxEmptyString);
|
|
||||||
|
|
||||||
void load_url(const wxString& url);
|
void load_url(const wxString& url);
|
||||||
bool run_script(const wxString& script);
|
bool run_script(const wxString& script);
|
||||||
|
|||||||
@@ -1,15 +0,0 @@
|
|||||||
#ifndef slic3r_wxinit_hpp_
|
|
||||||
#define slic3r_wxinit_hpp_
|
|
||||||
|
|
||||||
#include <wx/wx.h>
|
|
||||||
#include <wx/intl.h>
|
|
||||||
#include <wx/html/htmlwin.h>
|
|
||||||
|
|
||||||
// Perl redefines a _ macro, so we undef this one
|
|
||||||
#undef _
|
|
||||||
|
|
||||||
// We do want to use translation however, so define it as __ so we can do a find/replace
|
|
||||||
// later when we no longer need to undef _
|
|
||||||
#define __(s) wxGetTranslation((s))
|
|
||||||
|
|
||||||
#endif
|
|
||||||
@@ -3,240 +3,115 @@
|
|||||||
#include <algorithm>
|
#include <algorithm>
|
||||||
#include <atomic>
|
#include <atomic>
|
||||||
#include <chrono>
|
#include <chrono>
|
||||||
#include <cmath>
|
|
||||||
#include <condition_variable>
|
#include <condition_variable>
|
||||||
#include "libslic3r/TriangleMesh.hpp"
|
|
||||||
#include "libslic3r/BoundingBox.hpp"
|
|
||||||
#include "libslic3r/Point.hpp"
|
|
||||||
#include "libslic3r/libslic3r.h"
|
|
||||||
#include <exception>
|
|
||||||
#include <cstddef>
|
#include <cstddef>
|
||||||
#include "libslic3r/Exception.hpp"
|
#include <exception>
|
||||||
#include <limits>
|
|
||||||
#include <mutex>
|
#include <mutex>
|
||||||
#include "slic3r/GUI/Widgets/ProgressDialog.hpp"
|
|
||||||
#include <optional>
|
|
||||||
#include <string>
|
#include <string>
|
||||||
#include <thread>
|
#include <thread>
|
||||||
#include <utility>
|
|
||||||
#include <vector>
|
#include <vector>
|
||||||
|
|
||||||
#include <wx/string.h>
|
#include <wx/string.h>
|
||||||
|
|
||||||
#include "libslic3r/MeshBoolean.hpp"
|
|
||||||
#include "libslic3r/Model.hpp"
|
|
||||||
#include "libslic3r/Format/bbs_3mf.hpp"
|
#include "libslic3r/Format/bbs_3mf.hpp"
|
||||||
#include "libslic3r/format.hpp"
|
#include "libslic3r/MeshRepair.hpp"
|
||||||
|
#include "libslic3r/Model.hpp"
|
||||||
#include "libslic3r/Thread.hpp"
|
#include "libslic3r/Thread.hpp"
|
||||||
#include "../GUI/I18N.hpp"
|
#include "slic3r/GUI/I18N.hpp"
|
||||||
#include "libslic3r/TriangleSelector.hpp"
|
#include "slic3r/GUI/Widgets/ProgressDialog.hpp"
|
||||||
|
|
||||||
// Orca: This file provides utilities for repairing 3D model meshes using the CGAL library, handling mesh splitting, merging, and boolean operations.
|
|
||||||
|
|
||||||
namespace Slic3r {
|
namespace Slic3r {
|
||||||
|
|
||||||
namespace {
|
namespace {
|
||||||
|
|
||||||
// Orca: Helper functions for analyzing mesh properties and transformations.
|
class RepairCanceledException : public std::exception
|
||||||
|
|
||||||
bool is_not_3dimensional_part(const TriangleMesh &mesh)
|
|
||||||
{
|
{
|
||||||
// Orca: Determines if a mesh is degenerate or represents a non-3dimensional part by checking volume and bounding box dimensions.
|
public:
|
||||||
if (mesh.its.indices.empty())
|
const char *what() const noexcept override { return "Model repair has been canceled"; }
|
||||||
return true;
|
};
|
||||||
|
|
||||||
indexed_triangle_set tmp = mesh.its;
|
|
||||||
its_remove_degenerate_faces(tmp, true);
|
|
||||||
if (tmp.indices.empty())
|
|
||||||
return true;
|
|
||||||
|
|
||||||
const BoundingBoxf3 bbox = mesh.bounding_box();
|
|
||||||
const Vec3d size = bbox.size();
|
|
||||||
const double min_dim = std::min(size.x(), std::min(size.y(), size.z()));
|
|
||||||
const double max_dim = std::max(size.x(), std::max(size.y(), size.z()));
|
|
||||||
if (min_dim <= EPSILON)
|
|
||||||
return true;
|
|
||||||
|
|
||||||
const double volume = std::abs(its_volume(mesh.its));
|
|
||||||
const double bbox_volume = size.x() * size.y() * size.z();
|
|
||||||
if (volume <= EPSILON)
|
|
||||||
return true;
|
|
||||||
|
|
||||||
const double min_relative_thickness = 1e-6;
|
|
||||||
const double min_volume_ratio = 1e-6;
|
|
||||||
if (min_dim / max_dim <= min_relative_thickness)
|
|
||||||
return true;
|
|
||||||
if (bbox_volume > 0.0 && volume / bbox_volume <= min_volume_ratio)
|
|
||||||
return true;
|
|
||||||
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
|
|
||||||
} // namespace
|
} // namespace
|
||||||
|
|
||||||
// Orca: Exception class for handling user-initiated cancellation of model repair operations.
|
bool fix_model_with_cgal_gui(ModelObject &model_object, int volume_idx, GUI::ProgressDialog &progress_dialog, const wxString &msg_header, std::string &fix_result, bool keep_painting,
|
||||||
class RepairCanceledException : public std::exception {
|
bool *modified)
|
||||||
public:
|
|
||||||
const char* what() const noexcept override { return "Model repair has been canceled"; }
|
|
||||||
};
|
|
||||||
|
|
||||||
// Orca: Main function to repair model objects using CGAL, with progress dialog and cancellation support.
|
|
||||||
// Returns false if fixing was canceled. fix_result contains error message if failed.
|
|
||||||
bool fix_model_with_cgal_gui(ModelObject &model_object, int volume_idx, GUI::ProgressDialog &progress_dialog, const wxString &msg_header, std::string &fix_result, bool keep_painting)
|
|
||||||
{
|
{
|
||||||
// Hold SaveObjectGaurd to prevent backup manager from racing concurrent mesh mutations (use-after-free).
|
// Keeps the backup manager from reading a mesh while the worker replaces it.
|
||||||
SaveObjectGaurd backup_gaurd(model_object);
|
SaveObjectGaurd backup_gaurd(model_object);
|
||||||
|
|
||||||
// Orca: Synchronization primitives for progress updates between worker thread and GUI.
|
std::vector<ModelVolume *> volumes;
|
||||||
std::mutex mtx;
|
if (volume_idx < 0)
|
||||||
std::condition_variable condition;
|
volumes = model_object.volumes;
|
||||||
struct Progress {
|
else if (std::size_t(volume_idx) < model_object.volumes.size())
|
||||||
std::string message;
|
volumes.push_back(model_object.volumes[volume_idx]);
|
||||||
int percent = 0;
|
|
||||||
bool updated = false;
|
|
||||||
} progress;
|
|
||||||
|
|
||||||
|
std::mutex mtx;
|
||||||
|
std::condition_variable condition;
|
||||||
|
struct Progress
|
||||||
|
{
|
||||||
|
std::string message;
|
||||||
|
int percent = 0;
|
||||||
|
bool updated = false;
|
||||||
|
} progress;
|
||||||
std::atomic<bool> canceled = false;
|
std::atomic<bool> canceled = false;
|
||||||
std::atomic<bool> finished = false;
|
std::atomic<bool> finished = false;
|
||||||
|
bool any_modified = false;
|
||||||
|
std::string errors;
|
||||||
|
|
||||||
bool success = false;
|
auto on_progress = [&mtx, &condition, &progress](const std::string &msg, int percent) {
|
||||||
size_t ivolume = 0;
|
std::lock_guard<std::mutex> lock(mtx);
|
||||||
|
|
||||||
// Orca: Lambda for updating progress from worker thread.
|
|
||||||
auto on_progress = [&mtx, &condition, &ivolume, &model_object, &progress](const std::string &msg, unsigned prcnt) {
|
|
||||||
std::unique_lock<std::mutex> lock(mtx);
|
|
||||||
progress.message = msg;
|
progress.message = msg;
|
||||||
const size_t total = std::max<size_t>(1, model_object.volumes.size());
|
progress.percent = percent;
|
||||||
progress.percent = int(std::floor((float(prcnt) + float(ivolume) * 100.f) / float(total)));
|
|
||||||
progress.updated = true;
|
progress.updated = true;
|
||||||
condition.notify_all();
|
condition.notify_all();
|
||||||
};
|
};
|
||||||
|
|
||||||
// Orca: Worker thread that performs the actual model repair operations.
|
auto worker_thread = std::thread([&]() {
|
||||||
auto worker_thread = std::thread([&model_object, volume_idx, &ivolume, on_progress, &success, &canceled, &finished, &fix_result, keep_painting]() {
|
set_current_thread_name("cgal_fix_model");
|
||||||
try {
|
try {
|
||||||
set_current_thread_name("cgal_fix_model");
|
for (std::size_t i = 0; i < volumes.size(); ++i) {
|
||||||
|
ModelVolume *volume = volumes[i];
|
||||||
|
const std::string name = volumes.size() > 1 ? volume->name : std::string();
|
||||||
|
const auto report = [&](int percent) {
|
||||||
|
if (canceled)
|
||||||
|
throw RepairCanceledException();
|
||||||
|
on_progress(name, int((100 * i + std::size_t(percent)) / volumes.size()));
|
||||||
|
};
|
||||||
|
report(0);
|
||||||
|
|
||||||
size_t start_volume = volume_idx == -1 ? 0 : size_t(volume_idx);
|
MeshRepairStats stats;
|
||||||
size_t end_volume = volume_idx == -1 ? std::numeric_limits<size_t>::max() : size_t(volume_idx);
|
std::string error;
|
||||||
|
if (!volume->repair(keep_painting, &stats, &error, report))
|
||||||
for (ivolume = start_volume; ivolume < model_object.volumes.size(); ++ivolume) {
|
errors += (errors.empty() ? "" : "\n") + (volumes.size() > 1 ? volume->name + ": " : std::string()) + error;
|
||||||
if (volume_idx != -1 && ivolume > end_volume)
|
any_modified = any_modified || stats.modified;
|
||||||
break;
|
|
||||||
if (canceled)
|
|
||||||
throw RepairCanceledException();
|
|
||||||
|
|
||||||
on_progress(_u8L("Repairing model object"), 10);
|
|
||||||
|
|
||||||
ModelVolume *volume = model_object.volumes[ivolume];
|
|
||||||
|
|
||||||
// Orca: Split splittable volumes into parts for individual processing.
|
|
||||||
size_t parts_count = 1;
|
|
||||||
if (volume->is_splittable()) {
|
|
||||||
parts_count = volume->split(1, keep_painting);
|
|
||||||
if (parts_count > 1) {
|
|
||||||
const std::string msg = Slic3r::format(L("Split into %1% parts"), parts_count);
|
|
||||||
on_progress(msg, 10);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
size_t part_end = std::min(ivolume + parts_count - 1, model_object.volumes.size() - 1);
|
|
||||||
if (volume_idx != -1)
|
|
||||||
end_volume = part_end;
|
|
||||||
|
|
||||||
size_t removed_parts = 0;
|
|
||||||
for (size_t idx = part_end + 1; idx > ivolume; --idx) {
|
|
||||||
const size_t part_idx = idx - 1;
|
|
||||||
const ModelVolume *part_volume = model_object.volumes[part_idx];
|
|
||||||
if (!is_not_3dimensional_part(part_volume->mesh()))
|
|
||||||
continue;
|
|
||||||
|
|
||||||
model_object.delete_volume(part_idx);
|
|
||||||
++removed_parts;
|
|
||||||
if (part_end > 0)
|
|
||||||
--part_end;
|
|
||||||
else
|
|
||||||
part_end = 0;
|
|
||||||
if (volume_idx != -1)
|
|
||||||
end_volume = part_end;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (removed_parts >= parts_count) {
|
|
||||||
ivolume = part_end;
|
|
||||||
on_progress(_u8L("Repair finished"), 100);
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
|
|
||||||
for (size_t part_idx = ivolume; part_idx <= part_end && part_idx < model_object.volumes.size(); ++part_idx) {
|
|
||||||
ModelVolume *part_volume = model_object.volumes[part_idx];
|
|
||||||
TriangleMesh mesh = part_volume->mesh();
|
|
||||||
if (its_num_open_edges(mesh.its) != 0) {
|
|
||||||
|
|
||||||
// Save painting for later remap
|
|
||||||
const std::optional<TriangleSelector::SavedPainting> saved_painting = keep_painting ?
|
|
||||||
part_volume->save_painting() :
|
|
||||||
std::optional<TriangleSelector::SavedPainting>{};
|
|
||||||
|
|
||||||
std::string error;
|
|
||||||
if (!MeshBoolean::cgal::repair(mesh, nullptr, &error))
|
|
||||||
throw Slic3r::RuntimeError(error.empty() ? _u8L("Repair failed") : error);
|
|
||||||
|
|
||||||
part_volume->set_mesh(std::move(mesh));
|
|
||||||
part_volume->calculate_convex_hull();
|
|
||||||
part_volume->invalidate_convex_hull_2d();
|
|
||||||
part_volume->set_new_unique_id();
|
|
||||||
|
|
||||||
// Remap paint back
|
|
||||||
part_volume->restore_painting(saved_painting);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
ivolume = part_end;
|
|
||||||
|
|
||||||
on_progress(_u8L("Repair finished"), 100);
|
|
||||||
}
|
}
|
||||||
|
} catch (const RepairCanceledException &) {
|
||||||
model_object.invalidate_bounding_box();
|
|
||||||
|
|
||||||
if (ivolume > 0)
|
|
||||||
--ivolume;
|
|
||||||
on_progress(_u8L("Repair finished"), 100);
|
|
||||||
success = true;
|
|
||||||
finished = true;
|
|
||||||
} catch (RepairCanceledException &) {
|
|
||||||
canceled = true;
|
canceled = true;
|
||||||
finished = true;
|
} catch (const std::exception &ex) {
|
||||||
on_progress(_u8L("Repair canceled"), 100);
|
errors += (errors.empty() ? "" : "\n") + std::string(ex.what());
|
||||||
} catch (std::exception &ex) {
|
|
||||||
success = false;
|
|
||||||
finished = true;
|
|
||||||
fix_result = ex.what();
|
|
||||||
on_progress(ex.what(), 100);
|
|
||||||
}
|
}
|
||||||
|
// Volumes repaired before a cancel or an error keep their new mesh.
|
||||||
|
model_object.invalidate_bounding_box();
|
||||||
|
finished = true;
|
||||||
|
on_progress(_u8L("Repair finished"), 100);
|
||||||
});
|
});
|
||||||
|
|
||||||
// Orca: Main GUI loop to update progress dialog and handle cancellation.
|
|
||||||
while (!finished) {
|
while (!finished) {
|
||||||
std::unique_lock<std::mutex> lock(mtx);
|
std::unique_lock<std::mutex> lock(mtx);
|
||||||
condition.wait_for(lock, std::chrono::milliseconds(250), [&progress]{ return progress.updated; });
|
condition.wait_for(lock, std::chrono::milliseconds(250), [&progress] { return progress.updated; });
|
||||||
|
// One percent short of the maximum, so that the dialog does not close itself.
|
||||||
// Decrease progress percent slightly to avoid auto-closing.
|
if (!progress_dialog.Update(std::max(0, progress.percent - 1), msg_header + wxString::FromUTF8(progress.message)))
|
||||||
if (!progress_dialog.Update(progress.percent - 1, msg_header + _(progress.message)))
|
|
||||||
canceled = true;
|
canceled = true;
|
||||||
else
|
else
|
||||||
progress_dialog.Fit();
|
progress_dialog.Fit();
|
||||||
|
|
||||||
progress.updated = false;
|
progress.updated = false;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (canceled) {
|
|
||||||
// Nothing to show.
|
|
||||||
} else if (success) {
|
|
||||||
fix_result.clear();
|
|
||||||
}
|
|
||||||
|
|
||||||
if (worker_thread.joinable())
|
if (worker_thread.joinable())
|
||||||
worker_thread.join();
|
worker_thread.join();
|
||||||
|
|
||||||
|
fix_result = canceled ? std::string() : errors;
|
||||||
|
if (modified)
|
||||||
|
*modified = any_modified;
|
||||||
return !canceled;
|
return !canceled;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -12,8 +12,9 @@ class Model;
|
|||||||
class ModelObject;
|
class ModelObject;
|
||||||
class Print;
|
class Print;
|
||||||
|
|
||||||
// Return false if fixing was canceled. fix_result is empty on success.
|
// Return false if fixing was canceled. fix_result is empty on success; modified tells whether any mesh changed.
|
||||||
extern bool fix_model_with_cgal_gui(ModelObject &model_object, int volume_idx, GUI::ProgressDialog &progress_dlg, const wxString &msg_header, std::string &fix_result, bool keep_painting);
|
extern bool fix_model_with_cgal_gui(ModelObject &model_object, int volume_idx, GUI::ProgressDialog &progress_dlg, const wxString &msg_header, std::string &fix_result, bool keep_painting,
|
||||||
|
bool *modified = nullptr);
|
||||||
|
|
||||||
} // namespace Slic3r
|
} // namespace Slic3r
|
||||||
|
|
||||||
|
|||||||
@@ -12,7 +12,6 @@ extern double mac_max_scaling_factor();
|
|||||||
extern void set_miniaturizable(void * window);
|
extern void set_miniaturizable(void * window);
|
||||||
void WKWebView_evaluateJavaScript(void * web, wxString const & script, void (*callback)(wxString const &));
|
void WKWebView_evaluateJavaScript(void * web, wxString const & script, void (*callback)(wxString const &));
|
||||||
void WKWebView_setTransparentBackground(void * web);
|
void WKWebView_setTransparentBackground(void * web);
|
||||||
void WKWebViewConfiguration_setNonPersistentDataStore(void * configuration);
|
|
||||||
void WKWebView_force_display(void * web);
|
void WKWebView_force_display(void * web);
|
||||||
void set_tag_when_enter_full_screen(bool isfullscreen);
|
void set_tag_when_enter_full_screen(bool isfullscreen);
|
||||||
void set_title_colour_after_set_title(void * window);
|
void set_title_colour_after_set_title(void * window);
|
||||||
|
|||||||
@@ -102,15 +102,6 @@ void WKWebView_setTransparentBackground(void * web)
|
|||||||
[webView registerForDraggedTypes: @[NSFilenamesPboardType]];
|
[webView registerForDraggedTypes: @[NSFilenamesPboardType]];
|
||||||
}
|
}
|
||||||
|
|
||||||
// Give a WKWebViewConfiguration its own in-memory website data store, so the view's cookies and
|
|
||||||
// storage neither come from nor leak into the shared default store. Used to isolate plugin web views.
|
|
||||||
void WKWebViewConfiguration_setNonPersistentDataStore(void * configuration)
|
|
||||||
{
|
|
||||||
WKWebViewConfiguration * config = (WKWebViewConfiguration*)configuration;
|
|
||||||
if (config)
|
|
||||||
config.websiteDataStore = [WKWebsiteDataStore nonPersistentDataStore];
|
|
||||||
}
|
|
||||||
|
|
||||||
// Force a WKWebView to re-lay-out and repaint. Needed for chrome-less popups: the window is
|
// Force a WKWebView to re-lay-out and repaint. Needed for chrome-less popups: the window is
|
||||||
// transparent, so a WKWebView whose layer has no pending frame leaves the whole window invisible
|
// transparent, so a WKWebView whose layer has no pending frame leaves the whole window invisible
|
||||||
// until the user generates input (scroll/arrow). setNeedsDisplay alone does not always reach the
|
// until the user generates input (scroll/arrow). setNeedsDisplay alone does not always reach the
|
||||||
|
|||||||
@@ -1,19 +0,0 @@
|
|||||||
#ifndef slic3r_GUI_Profile_hpp_
|
|
||||||
#define slic3r_GUI_Profile_hpp_
|
|
||||||
|
|
||||||
// Profiling support using the Shiny intrusive profiler
|
|
||||||
//#define SLIC3R_PROFILE_GUI
|
|
||||||
#if defined(SLIC3R_PROFILE) && defined(SLIC3R_PROFILE_GUI)
|
|
||||||
#include <Shiny/Shiny.h>
|
|
||||||
#define SLIC3R_GUI_PROFILE_FUNC() PROFILE_FUNC()
|
|
||||||
#define SLIC3R_GUI_PROFILE_BLOCK(name) PROFILE_BLOCK(name)
|
|
||||||
#define SLIC3R_GUI_PROFILE_UPDATE() PROFILE_UPDATE()
|
|
||||||
#define SLIC3R_GUI_PROFILE_OUTPUT(x) PROFILE_OUTPUT(x)
|
|
||||||
#else
|
|
||||||
#define SLIC3R_GUI_PROFILE_FUNC()
|
|
||||||
#define SLIC3R_GUI_PROFILE_BLOCK(name)
|
|
||||||
#define SLIC3R_GUI_PROFILE_UPDATE()
|
|
||||||
#define SLIC3R_GUI_PROFILE_OUTPUT(x)
|
|
||||||
#endif
|
|
||||||
|
|
||||||
#endif // slic3r_GUI_Profile_hpp_
|
|
||||||
@@ -390,8 +390,7 @@ py::object ui_create_window(const std::string& html, const std::string& title, i
|
|||||||
|
|
||||||
auto* dlg = new GUI::WebDialog(ui_parent(), wxString::FromUTF8(title), html,
|
auto* dlg = new GUI::WebDialog(ui_parent(), wxString::FromUTF8(title), html,
|
||||||
wxSize(w, h), std::move(msg_adapter), std::move(submit_adapter),
|
wxSize(w, h), std::move(msg_adapter), std::move(submit_adapter),
|
||||||
std::move(on_close), std::move(on_destroyed), PLUGIN_WX_STYLE,
|
std::move(on_close), std::move(on_destroyed), PLUGIN_WX_STYLE);
|
||||||
wxString::FromUTF8(plugin_key));
|
|
||||||
UiRegistry::instance().bind(new_id, dlg, plugin_key);
|
UiRegistry::instance().bind(new_id, dlg, plugin_key);
|
||||||
if (modal) {
|
if (modal) {
|
||||||
dlg->ShowModal();
|
dlg->ShowModal();
|
||||||
@@ -488,7 +487,7 @@ py::object ui_create_dock_panel(const std::string& html, const std::string& titl
|
|||||||
|
|
||||||
auto on_destroyed = [new_id]() { UiRegistry::instance().remove(new_id); };
|
auto on_destroyed = [new_id]() { UiRegistry::instance().remove(new_id); };
|
||||||
auto* panel = new GUI::DockPanel(plater, html, std::move(msg_adapter), make_close_adapter(close_holder),
|
auto* panel = new GUI::DockPanel(plater, html, std::move(msg_adapter), make_close_adapter(close_holder),
|
||||||
std::move(on_destroyed), wxString::FromUTF8(plugin_key));
|
std::move(on_destroyed));
|
||||||
UiRegistry::instance().bind(new_id, panel, plugin_key);
|
UiRegistry::instance().bind(new_id, panel, plugin_key);
|
||||||
plater->add_dock_pane(panel, GUI::plugin_pane_name(plugin_key, title), wxString::FromUTF8(title), dock,
|
plater->add_dock_pane(panel, GUI::plugin_pane_name(plugin_key, title), wxString::FromUTF8(title), dock,
|
||||||
wxSize(w, h), [panel]() { panel->fire_close(); });
|
wxSize(w, h), [panel]() { panel->fire_close(); });
|
||||||
|
|||||||
@@ -77,8 +77,7 @@ constexpr char PLUGIN_PAGE_BRIDGE_JS[] = R"JS(
|
|||||||
} // namespace
|
} // namespace
|
||||||
|
|
||||||
PluginPage::PluginPage(wxWindow* parent, std::shared_ptr<PagesPluginCapability> capability)
|
PluginPage::PluginPage(wxWindow* parent, std::shared_ptr<PagesPluginCapability> capability)
|
||||||
: GUI::WebPanel(parent, PLUGIN_PAGE_BRIDGE_JS,
|
: GUI::WebPanel(parent, PLUGIN_PAGE_BRIDGE_JS)
|
||||||
wxString::FromUTF8(capability ? capability->identity().plugin_key : std::string()))
|
|
||||||
, m_cap(std::move(capability))
|
, m_cap(std::move(capability))
|
||||||
, m_lifetime(std::make_shared<std::atomic<PluginPage*>>(this))
|
, m_lifetime(std::make_shared<std::atomic<PluginPage*>>(this))
|
||||||
{
|
{
|
||||||
|
|||||||
@@ -31,6 +31,22 @@ set_tests_properties(cli_project_missing_keys PROPERTIES
|
|||||||
SKIP_RETURN_CODE 77
|
SKIP_RETURN_CODE 77
|
||||||
TIMEOUT 900)
|
TIMEOUT 900)
|
||||||
|
|
||||||
|
add_test(NAME cli_arrange_rotations
|
||||||
|
COMMAND bash ${CMAKE_CURRENT_SOURCE_DIR}/test_cli_arrange_rotations.sh $<TARGET_FILE:OrcaSlicer> ${ORCA_CLI_TEST_PYTHON}
|
||||||
|
${CMAKE_SOURCE_DIR}/resources/profiles/BBL)
|
||||||
|
set_tests_properties(cli_arrange_rotations PROPERTIES
|
||||||
|
LABELS "CLI;RequiresApp"
|
||||||
|
SKIP_RETURN_CODE 77
|
||||||
|
TIMEOUT 900)
|
||||||
|
|
||||||
|
add_test(NAME cli_no_suitable_objects
|
||||||
|
COMMAND bash ${CMAKE_CURRENT_SOURCE_DIR}/test_cli_no_suitable_objects.sh $<TARGET_FILE:OrcaSlicer> ${ORCA_CLI_TEST_PYTHON}
|
||||||
|
${CMAKE_SOURCE_DIR}/resources/profiles/BBL)
|
||||||
|
set_tests_properties(cli_no_suitable_objects PROPERTIES
|
||||||
|
LABELS "CLI;RequiresApp"
|
||||||
|
SKIP_RETURN_CODE 77
|
||||||
|
TIMEOUT 900)
|
||||||
|
|
||||||
add_test(NAME cli_malformed_input
|
add_test(NAME cli_malformed_input
|
||||||
COMMAND bash ${CMAKE_CURRENT_SOURCE_DIR}/test_cli_malformed_input.sh $<TARGET_FILE:OrcaSlicer> ${ORCA_CLI_TEST_PYTHON})
|
COMMAND bash ${CMAKE_CURRENT_SOURCE_DIR}/test_cli_malformed_input.sh $<TARGET_FILE:OrcaSlicer> ${ORCA_CLI_TEST_PYTHON})
|
||||||
set_tests_properties(cli_malformed_input PROPERTIES
|
set_tests_properties(cli_malformed_input PROPERTIES
|
||||||
|
|||||||
Executable
+89
@@ -0,0 +1,89 @@
|
|||||||
|
#!/usr/bin/env bash
|
||||||
|
# End-to-end check of the CLI's arrange rotation policy.
|
||||||
|
#
|
||||||
|
# Arrange is translate-only unless --allow-rotations is passed, so a bar that fits the bed only
|
||||||
|
# diagonally is not placed and the plate ends up with nothing fully inside the print volume. The
|
||||||
|
# run must then say that rotations were off, on stderr as well as in result.json, because
|
||||||
|
# result.json is written on Linux only. Passing the flag must place the same bar and slice it, and
|
||||||
|
# an object that fits axis-aligned must be unaffected by the default.
|
||||||
|
#
|
||||||
|
# usage: test_cli_arrange_rotations.sh <orca-slicer binary> <python3> <resources/profiles/BBL>
|
||||||
|
set -u
|
||||||
|
|
||||||
|
BIN="${1:-}"
|
||||||
|
PY="${2:-python3}"
|
||||||
|
PROFILES="${3:-}"
|
||||||
|
# 77 is the test's SKIP_RETURN_CODE.
|
||||||
|
[ -x "$BIN" ] || { echo "SKIP: orca-slicer binary not found: $BIN"; exit 77; }
|
||||||
|
[ -d "$PROFILES" ] || { echo "FAIL: profiles directory not found: $PROFILES"; exit 1; }
|
||||||
|
|
||||||
|
WORK="$(mktemp -d "${TMPDIR:-/tmp}/orca-cli-arrange-rotations.XXXXXX")"
|
||||||
|
trap 'rm -rf "$WORK"' EXIT
|
||||||
|
|
||||||
|
# box <file> <x> <y> <z>: an ASCII STL box, so the test needs no fixture.
|
||||||
|
box() {
|
||||||
|
"$PY" - "$@" <<'EOF'
|
||||||
|
import sys
|
||||||
|
|
||||||
|
out, sx, sy, sz = sys.argv[1], float(sys.argv[2]), float(sys.argv[3]), float(sys.argv[4])
|
||||||
|
v = [(x, y, z) for z in (0, sz) for y in (0, sy) for x in (0, sx)]
|
||||||
|
with open(out, "w") as f:
|
||||||
|
f.write("solid box\n")
|
||||||
|
for a, b, c, d in ((0, 2, 3, 1), (4, 5, 7, 6), (0, 1, 5, 4), (2, 6, 7, 3), (0, 4, 6, 2), (1, 3, 7, 5)):
|
||||||
|
for tri in ((v[a], v[b], v[c]), (v[a], v[c], v[d])):
|
||||||
|
f.write("facet normal 0 0 0\nouter loop\n")
|
||||||
|
for p in tri:
|
||||||
|
f.write("vertex %g %g %g\n" % p)
|
||||||
|
f.write("endloop\nendfacet\n")
|
||||||
|
f.write("endsolid box\n")
|
||||||
|
EOF
|
||||||
|
}
|
||||||
|
|
||||||
|
# Longer than the 256 mm bed edge, shorter than its 362 mm diagonal: it fits only turned.
|
||||||
|
box "$WORK/bar.stl" 300 10 5
|
||||||
|
# Fits axis-aligned, so the default must not change anything for it.
|
||||||
|
box "$WORK/cube.stl" 10 10 10
|
||||||
|
|
||||||
|
# slice <tag> <input> [option...] -> $WORK/<tag>/{rc,stdout,stderr,result.json}
|
||||||
|
slice() {
|
||||||
|
local out="$WORK/$1" input="$2"; shift 2
|
||||||
|
mkdir -p "$out"
|
||||||
|
timeout 300 "$BIN" --datadir "$out/datadir" \
|
||||||
|
--load-settings "$PROFILES/machine/Bambu Lab X1 Carbon 0.4 nozzle.json;$PROFILES/process/0.20mm Standard @BBL X1C.json" \
|
||||||
|
--load-defaultfila "$@" --slice 0 --outputdir "$out" "$input" \
|
||||||
|
> "$out/stdout" 2> "$out/stderr"
|
||||||
|
echo "$?" > "$out/rc"
|
||||||
|
}
|
||||||
|
|
||||||
|
# exit_code <tag>: the CLI's negative code as the shell saw it, e.g. -50 arrives as 206.
|
||||||
|
exit_code() { "$PY" -c "import sys; rc = int(open(sys.argv[1]).read()); print(rc - 256 if rc > 127 else rc)" "$WORK/$1/rc"; }
|
||||||
|
|
||||||
|
fail() { echo "FAIL: $*"; exit 1; }
|
||||||
|
|
||||||
|
# 1. Default: no flag, so no rotations, so the bar does not fit and the reason names rotation.
|
||||||
|
slice default "$WORK/bar.stl"
|
||||||
|
[ "$(exit_code default)" = "-50" ] || fail "default: expected -50, got $(exit_code default)"
|
||||||
|
grep -q "Arrange ran without rotations" "$WORK/default/stderr" \
|
||||||
|
|| fail "default: stderr does not mention rotations: $(cat "$WORK/default/stderr")"
|
||||||
|
"$PY" - "$WORK/default/result.json" <<'EOF' || exit 1
|
||||||
|
import json, sys
|
||||||
|
|
||||||
|
result = json.load(open(sys.argv[1]))
|
||||||
|
if result["return_code"] != -50:
|
||||||
|
sys.exit("FAIL: result.json return_code %s, expected -50" % result["return_code"])
|
||||||
|
if "Arrange ran without rotations" not in result["error_string"]:
|
||||||
|
sys.exit("FAIL: result.json error_string does not mention rotations: %s" % result["error_string"])
|
||||||
|
EOF
|
||||||
|
|
||||||
|
# 2. The flag is coBool, so it takes no value: it must place the same bar and slice it.
|
||||||
|
slice rotations "$WORK/bar.stl" --allow-rotations
|
||||||
|
[ "$(exit_code rotations)" = "0" ] || fail "--allow-rotations: expected 0, got $(exit_code rotations); $(tail -n 5 "$WORK/rotations/stdout")"
|
||||||
|
[ -s "$WORK/rotations/plate_1.gcode" ] || fail "--allow-rotations: no g-code written"
|
||||||
|
|
||||||
|
# 3. An object that fits axis-aligned is unaffected by the default, and says nothing about rotation.
|
||||||
|
slice cube "$WORK/cube.stl"
|
||||||
|
[ "$(exit_code cube)" = "0" ] || fail "cube: expected 0, got $(exit_code cube); $(tail -n 5 "$WORK/cube/stdout")"
|
||||||
|
[ -s "$WORK/cube/plate_1.gcode" ] || fail "cube: no g-code written"
|
||||||
|
grep -q "Arrange ran without rotations" "$WORK/cube/stderr" && fail "cube: unexpected rotation message on a successful run"
|
||||||
|
|
||||||
|
echo "PASS: arrange rotation default, its failure message, and the opt-in flag"
|
||||||
Executable
+83
@@ -0,0 +1,83 @@
|
|||||||
|
#!/usr/bin/env bash
|
||||||
|
# The reason recorded for CLI_NO_SUITABLE_OBJECTS (-50) has to fit the input the CLI was given.
|
||||||
|
# Any input format is arranged and sliced, so an object larger than the bed empties the plate just
|
||||||
|
# as a 3mf with an empty plate does, and the recorded reason must not send such a caller off to
|
||||||
|
# inspect a 3mf or an upload that is not part of their run.
|
||||||
|
#
|
||||||
|
# usage: test_cli_no_suitable_objects.sh <orca-slicer binary> <python3> <resources/profiles/BBL>
|
||||||
|
set -u
|
||||||
|
|
||||||
|
BIN="${1:-}"
|
||||||
|
PY="${2:-python3}"
|
||||||
|
PROFILES="${3:-}"
|
||||||
|
# 77 is the test's SKIP_RETURN_CODE.
|
||||||
|
[ -x "$BIN" ] || { echo "SKIP: orca-slicer binary not found: $BIN"; exit 77; }
|
||||||
|
[ -d "$PROFILES" ] || { echo "FAIL: profiles directory not found: $PROFILES"; exit 1; }
|
||||||
|
|
||||||
|
WORK="$(mktemp -d "${TMPDIR:-/tmp}/orca-cli-no-suitable-objects.XXXXXX")"
|
||||||
|
trap 'rm -rf "$WORK"' EXIT
|
||||||
|
|
||||||
|
# box <file> <x> <y> <z>: an ASCII STL box, so the test needs no fixture.
|
||||||
|
box() {
|
||||||
|
"$PY" - "$@" <<'EOF'
|
||||||
|
import sys
|
||||||
|
|
||||||
|
out, sx, sy, sz = sys.argv[1], float(sys.argv[2]), float(sys.argv[3]), float(sys.argv[4])
|
||||||
|
v = [(x, y, z) for z in (0, sz) for y in (0, sy) for x in (0, sx)]
|
||||||
|
with open(out, "w") as f:
|
||||||
|
f.write("solid box\n")
|
||||||
|
for a, b, c, d in ((0, 2, 3, 1), (4, 5, 7, 6), (0, 1, 5, 4), (2, 6, 7, 3), (0, 4, 6, 2), (1, 3, 7, 5)):
|
||||||
|
for tri in ((v[a], v[b], v[c]), (v[a], v[c], v[d])):
|
||||||
|
f.write("facet normal 0 0 0\nouter loop\n")
|
||||||
|
for p in tri:
|
||||||
|
f.write("vertex %g %g %g\n" % p)
|
||||||
|
f.write("endloop\nendfacet\n")
|
||||||
|
f.write("endsolid box\n")
|
||||||
|
EOF
|
||||||
|
}
|
||||||
|
|
||||||
|
# Wider than the 256 mm bed and wider than its 362 mm diagonal, so no placement can fit it.
|
||||||
|
box "$WORK/slab.stl" 400 400 5
|
||||||
|
# Fits, so the run must succeed: proves the harness itself is sound.
|
||||||
|
box "$WORK/cube.stl" 10 10 10
|
||||||
|
|
||||||
|
# slice <tag> <input> [option...] -> $WORK/<tag>/{rc,stdout,stderr,result.json}
|
||||||
|
slice() {
|
||||||
|
local out="$WORK/$1" input="$2"; shift 2
|
||||||
|
mkdir -p "$out"
|
||||||
|
timeout 300 "$BIN" --datadir "$out/datadir" \
|
||||||
|
--load-settings "$PROFILES/machine/Bambu Lab X1 Carbon 0.4 nozzle.json;$PROFILES/process/0.20mm Standard @BBL X1C.json" \
|
||||||
|
"$@" --slice 0 --outputdir "$out" "$input" \
|
||||||
|
> "$out/stdout" 2> "$out/stderr"
|
||||||
|
echo "$?" > "$out/rc"
|
||||||
|
}
|
||||||
|
|
||||||
|
# exit_code <tag>: the CLI's negative code as the shell saw it, e.g. -50 arrives as 206.
|
||||||
|
exit_code() { "$PY" -c "import sys; rc = int(open(sys.argv[1]).read()); print(rc - 256 if rc > 127 else rc)" "$WORK/$1/rc"; }
|
||||||
|
|
||||||
|
fail() { echo "FAIL: $*"; exit 1; }
|
||||||
|
|
||||||
|
# --allow-rotations keeps this on the generic reason: a translate-only arrange has its own,
|
||||||
|
# more specific one. The slab is wider than the 362 mm bed diagonal, so rotation cannot place it.
|
||||||
|
slice slab "$WORK/slab.stl" --allow-rotations
|
||||||
|
[ "$(exit_code slab)" = "-50" ] || fail "slab: expected -50, got $(exit_code slab); $(tail -n 5 "$WORK/slab/stdout")"
|
||||||
|
"$PY" - "$WORK/slab/result.json" <<'EOF' || exit 1
|
||||||
|
import json, sys
|
||||||
|
|
||||||
|
result = json.load(open(sys.argv[1]))
|
||||||
|
if result["return_code"] != -50:
|
||||||
|
sys.exit("FAIL: result.json return_code %s, expected -50" % result["return_code"])
|
||||||
|
reason = result["error_string"]
|
||||||
|
if not reason.strip():
|
||||||
|
sys.exit("FAIL: result.json carries no error_string")
|
||||||
|
# The run was handed an STL and asked for g-code: neither a 3mf nor an upload exists to check.
|
||||||
|
for word in ("3mf", "3MF", "upload"):
|
||||||
|
if word in reason:
|
||||||
|
sys.exit("FAIL: error_string mentions %r for an STL run: %s" % (word, reason))
|
||||||
|
EOF
|
||||||
|
|
||||||
|
slice cube "$WORK/cube.stl"
|
||||||
|
[ "$(exit_code cube)" = "0" ] || fail "cube: expected 0, got $(exit_code cube); $(tail -n 5 "$WORK/cube/stdout")"
|
||||||
|
[ -s "$WORK/cube/plate_1.gcode" ] || fail "cube: no g-code written"
|
||||||
|
|
||||||
|
echo "PASS: the no-suitable-objects reason fits a non-3mf run"
|
||||||
@@ -0,0 +1,35 @@
|
|||||||
|
ISO-10303-21;
|
||||||
|
HEADER;
|
||||||
|
FILE_DESCRIPTION((''),'2;1');
|
||||||
|
FILE_NAME('surface_model_geometric_set','2026-10-12T00:00:00',(''),(''),'','','');
|
||||||
|
FILE_SCHEMA(('CONFIG_CONTROL_DESIGN'));
|
||||||
|
ENDSEC;
|
||||||
|
DATA;
|
||||||
|
#1=APPLICATION_CONTEXT('configuration controlled 3d designs of mechanical parts and assemblies');
|
||||||
|
#2=APPLICATION_PROTOCOL_DEFINITION('international standard','config_control_design',1994,#1);
|
||||||
|
#3=MECHANICAL_CONTEXT('',#1,'mechanical');
|
||||||
|
#4=PRODUCT('surfaces','surfaces','',(#3));
|
||||||
|
#5=PRODUCT_DEFINITION_FORMATION_WITH_SPECIFIED_SOURCE('','',#4,.NOT_KNOWN.);
|
||||||
|
#6=DESIGN_CONTEXT('',#1,'design');
|
||||||
|
#7=PRODUCT_DEFINITION('','',#5,#6);
|
||||||
|
#8=PRODUCT_DEFINITION_SHAPE('','',#7);
|
||||||
|
#9=SHAPE_DEFINITION_REPRESENTATION(#8,#20);
|
||||||
|
#10=(LENGTH_UNIT()NAMED_UNIT(*)SI_UNIT(.MILLI.,.METRE.));
|
||||||
|
#11=(NAMED_UNIT(*)PLANE_ANGLE_UNIT()SI_UNIT($,.RADIAN.));
|
||||||
|
#12=(NAMED_UNIT(*)SI_UNIT($,.STERADIAN.)SOLID_ANGLE_UNIT());
|
||||||
|
#13=UNCERTAINTY_MEASURE_WITH_UNIT(LENGTH_MEASURE(1.E-6),#10,'distance_accuracy_value','');
|
||||||
|
#14=(GEOMETRIC_REPRESENTATION_CONTEXT(3)GLOBAL_UNCERTAINTY_ASSIGNED_CONTEXT((#13))GLOBAL_UNIT_ASSIGNED_CONTEXT((#10,#11,#12))REPRESENTATION_CONTEXT('',''));
|
||||||
|
#15=CARTESIAN_POINT('',(0.,0.,0.));
|
||||||
|
#16=DIRECTION('',(0.,0.,1.));
|
||||||
|
#17=DIRECTION('',(1.,0.,0.));
|
||||||
|
#18=AXIS2_PLACEMENT_3D('',#15,#16,#17);
|
||||||
|
#19=GEOMETRIC_SET('',(#30,#40));
|
||||||
|
#20=GEOMETRICALLY_BOUNDED_SURFACE_SHAPE_REPRESENTATION('',(#18,#19),#14);
|
||||||
|
#30=RECTANGULAR_TRIMMED_SURFACE('',#31,0.,10.,0.,10.,.T.,.T.);
|
||||||
|
#31=PLANE('',#18);
|
||||||
|
#40=RECTANGULAR_TRIMMED_SURFACE('',#41,0.,10.,0.,10.,.T.,.T.);
|
||||||
|
#41=PLANE('',#42);
|
||||||
|
#42=AXIS2_PLACEMENT_3D('',#43,#16,#17);
|
||||||
|
#43=CARTESIAN_POINT('',(0.,0.,10.));
|
||||||
|
ENDSEC;
|
||||||
|
END-ISO-10303-21;
|
||||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user