Address Review of the Reworked Unit Tests

Recompute the v4 recipe comparison once instead of per feature (148 s to 6 s) and compare bounding boxes as well as volumes; drop the incidental NaN loop from the unrepairable Voronoi case; prove the renamed preset is the one selected instead of checking a dirty flag that selecting clears; tell sparse from empty infill in the solid-shell test; plus smaller cleanups.

localization/i18n/OrcaSlicer.pot

@@ -10657,6 +10657,9 @@ msgstr ""
 msgid "Send Failed"
 msgstr ""
 
+msgid "No available printers"
+msgstr ""
+
 msgid "The name length exceeds the limit."
 msgstr ""
 

src/libslic3r/Preset.hpp

@@ -756,7 +756,14 @@ public:
     Preset&         get_edited_preset()         { return m_edited_preset; }
     const Preset&   get_edited_preset() const   { return m_edited_preset; }
 
-    const Preset& get_selected_preset_base() const { return *get_preset_base(m_presets[m_idx_selected]); }
+    // The root of the selected preset's inherits chain, or the selected preset itself when
+    // the chain names a preset that is not loaded (e.g. a vendor that is not installed).
+    const Preset& get_selected_preset_base() const
+    {
+        const Preset &selected = m_presets[m_idx_selected];
+        const Preset *base     = get_preset_base(selected);
+        return base ? *base : selected;
+    }
 
     // Return the last saved preset.
 //  const Preset&   get_saved_preset() const { return m_saved_preset; }

src/slic3r/GUI/ConnectPrinter.cpp

@@ -15,7 +15,6 @@
 #include <string>
 #include "slic3r/GUI/wxExtensions.hpp"
 #include "libslic3r/AppConfig.hpp"
-#include "IPrinterAgent.hpp"
 
 #include "DeviceCore/DevManager.h"
 
@@ -171,16 +170,14 @@ void ConnectPrinterDialog::on_input_enter(wxCommandEvent& evt)
 void ConnectPrinterDialog::on_button_confirm(wxCommandEvent &event)
 {
     wxString code = m_textCtrl_code->GetTextCtrl()->GetValue();
-    // Validate only what the user typed; the no-key sentinel is applied afterwards (it contains
+    if (code.empty() && (!m_obj || m_obj->printer_agent_id != MOONRAKER_PRINTER_AGENT_ID))
-    // non-alphanumeric characters, so it must not go through this check).
+        code = "88888888";
     for (char c : code) {
         if (!(('0' <= c && c <= '9') || ('a' <= c && c <= 'z') || ('A' <= c && c <= 'Z'))) {
             show_error(this, _L("Invalid input"));
             return;
         }
     }
-    if (code.empty())
-        code = NO_API_KEY_SENTINEL;
     if (m_obj) {
         m_obj->set_access_code(code.ToStdString());
     }

src/slic3r/GUI/CreatePresetsDialog.cpp

@@ -3151,7 +3151,7 @@ void CreatePrinterPresetDialog::set_current_visible_printer()
     m_printer_name_to_preset.clear();
     for (const Preset &printer_preset : printer_presets) {
         if (!printer_preset.is_visible) continue;
-        if (preset_bundle->printers.get_preset_base(printer_preset)->name != printer_preset.name) continue;
+        if (preset_bundle->printers.get_preset_base(printer_preset) != &printer_preset) continue;
         if (auto printer_model = dynamic_cast<ConfigOptionString*>(const_cast<Preset&>(printer_preset).config.option("printer_model", false))) {
             if (m_printer_name_to_preset.find(printer_model->value) == m_printer_name_to_preset.end()) {
                 printer_choice.push_back(from_u8(printer_model->value));
@@ -4962,7 +4962,7 @@ void CreatePresetForPrinterDialog::get_visible_printer_and_compatible_filament_p
                     if (filament_preset.is_default || !filament_preset.is_compatible || filament_preset.is_project_embedded) continue;
                     ConfigOptionStrings *filament_types;
                     const Preset *       filament_preset_base = m_preset_bundle->filaments.get_preset_base(filament_preset);
-                    if (filament_preset_base == &filament_preset) {
+                    if (filament_preset_base == &filament_preset || filament_preset_base == nullptr) {
                         filament_types = dynamic_cast<ConfigOptionStrings *>(const_cast<Preset *>(&filament_preset)->config.option("filament_type"));
                     } else {
                         filament_types = dynamic_cast<ConfigOptionStrings *>(const_cast<Preset *>(filament_preset_base)->config.option("filament_type"));

src/slic3r/GUI/DeviceManager.cpp

@@ -2685,8 +2685,7 @@ int MachineObject::connect()
 {
     if (m_access_revoked || get_dev_ip().empty()) return -1;
     std::string username = m_agent ? m_agent->default_lan_username() : std::string();
-    // The stored access code may be the "no API key" sentinel; agents expect an empty credential.
+    std::string password = get_access_code();
-    std::string password = normalize_access_code(get_access_code());
 
     std::string port;
     std::string input = get_dev_ip();

src/slic3r/GUI/GUI_App.cpp

@@ -4354,11 +4354,6 @@ void GUI_App::select_machine(const std::string& agent_id)
         machine.dev_ip = dev_id;
         machine.dev_name = dev_id;
         machine.printer_type = preset.config.opt_string("printer_model");
-        auto access_code = preset.config.opt_string("printhost_apikey");
-        // Orca expect non empty access code
-        if (access_code.empty()) {
-            access_code = NO_API_KEY_SENTINEL;
-        }
 
         existing = m_device_manager->insert_local_device(
             machine, "lan", "free", "", access_code);

src/slic3r/GUI/ReleaseNote.cpp

@@ -2,7 +2,6 @@
 #include "I18N.hpp"
 
 #include "bambu_networking.hpp"
-#include "IPrinterAgent.hpp"
 #include "libslic3r/Utils.hpp"
 #include "GUI.hpp"
 #include "GUI_App.hpp"
@@ -1904,7 +1903,7 @@ void InputIpAddressDialog::on_ok(wxMouseEvent& evt)
     std::string str_ip = m_input_ip->GetTextCtrl()->GetValue().ToStdString();
     std::string str_access_code = m_input_access_code->GetTextCtrl()->GetValue().ToStdString();
     if (str_access_code.empty())
-        str_access_code = NO_API_KEY_SENTINEL;
+        str_access_code = "88888888";
     std::string str_name = m_input_printer_name->GetTextCtrl()->GetValue().Strip(wxString::both).ToStdString();
     // Serial number should not contain lower case letters, and bambu_network plugin crashes
     // if user entered the wrong serial number, so we call `Upper()` here.
@@ -1951,7 +1950,7 @@ void InputIpAddressDialog::on_send_retry()
     wxString ip              = m_input_ip->GetTextCtrl()->GetValue();
     wxString str_access_code = m_input_access_code->GetTextCtrl()->GetValue();
     if (str_access_code.IsEmpty())
-        str_access_code = NO_API_KEY_SENTINEL;
+        str_access_code = "88888888";
 
     // check support function
     if (!m_obj) return;

src/slic3r/GUI/SelectMachine.cpp

@@ -4087,7 +4087,7 @@ void SelectMachineDialog::update_user_printer()
     {
         m_printer_last_select = "";
         update_select_layout(nullptr);
-        m_printer_box->GetPrinterComboBox()->SetTextLabel("");
+        m_printer_box->GetPrinterComboBox()->SetValue(_L("No available printers"));
     }
 
     BOOST_LOG_TRIVIAL(info) << __FUNCTION__ << "for send task, current printer id =  " << m_printer_last_select << std::endl;

src/slic3r/GUI/SendToPrinter.cpp

@@ -1229,7 +1229,7 @@ void SendToPrinterDialog::update_user_printer()
     }
     else {
         m_printer_last_select = "";
-        m_comboBox_printer->SetTextLabel("");
+        m_comboBox_printer->SetValue(_L("No available printers"));
     }
 
     BOOST_LOG_TRIVIAL(info) << __FUNCTION__ << "for send task, current printer id =  " << m_printer_last_select << std::endl;

src/slic3r/GUI/Widgets/ComboBox.cpp

@@ -287,7 +287,7 @@ void ComboBox::DoDeleteOneItem(unsigned int pos)
 
 void ComboBox::ForceDropdownOpen()
 {
-    if (!IsEnabled())
+    if (!IsEnabled() || items.empty())
         return;
 
     if (!drop_down) {
@@ -398,7 +398,7 @@ void ComboBox::mouseDown(wxMouseEvent &event)
     SetFocus();
     if (drop_down) {
         drop.Hide();
-    } else if (drop.HasDismissLongTime()) {
+    } else if (!items.empty() && drop.HasDismissLongTime()) { // DropDown paints nothing for an empty list
         drop.autoPosition();
         drop_down = true;
         drop.Popup(&drop);
@@ -426,7 +426,7 @@ void ComboBox::keyDown(wxKeyEvent& event)
         case WXK_SPACE:
             if (drop_down) {
                 drop.DismissAndNotify();
-            } else if (drop.HasDismissLongTime()) {
+            } else if (!items.empty() && drop.HasDismissLongTime()) {
                 drop.autoPosition();
                 drop_down = true;
                 drop.Popup();

src/slic3r/Utils/BBLPrinterAgent.cpp

@@ -204,9 +204,8 @@ int BBLPrinterAgent::command_axis_control(std::string dev_id, std::string axis,
         int dir = input_val > 0 ? 1 : -1;
         // i3-arch printers move the bed for Y/Z, so the on-screen direction is
         // reversed -- same negation the g-code fallback below applies.
-        if (!is_core_xy && (axis == "Y" || axis == "Z")) {
+        if (!is_core_xy && (axis == "Y" || axis == "Z"))
             dir = -dir;
-        }
 
         j["print"]["command"] = "xyz_ctrl";
         j["print"]["axis"] = axis;
@@ -216,9 +215,8 @@ int BBLPrinterAgent::command_axis_control(std::string dev_id, std::string axis,
     }
 
     double value = input_val;
-    if (!is_core_xy && (axis == "Y" || axis == "Z")) {
+    if (!is_core_xy && (axis == "Y" || axis == "Z"))
-        value = -1.0 * input_val;
+        value = -input_val;
-    }
 
     std::string value_str = (boost::format("%.1f") % (value * unit)).str();
     std::string gcode;
@@ -239,11 +237,10 @@ int BBLPrinterAgent::command_axis_control(std::string dev_id, std::string axis,
 int BBLPrinterAgent::publish(const std::string& dev_id, const nlohmann::json& j, bool lan_mode)
 {
     const int rtn = lan_mode ? send_message_to_printer(dev_id, j.dump(), 0, 0) : send_message(dev_id, j.dump(), 0, 0);
-    if (rtn == 0) {
+    if (rtn == 0)
         BOOST_LOG_TRIVIAL(info) << "publish_json: " << j.dump() << " code: " << rtn;
-    } else {
+    else
         BOOST_LOG_TRIVIAL(error) << "publish_json: " << j.dump() << " code: " << rtn;
-    }
     return rtn;
 }
 
@@ -589,21 +586,8 @@ int BBLPrinterAgent::start_local_print_with_record(PrintParams params, OnUpdateS
 
 int BBLPrinterAgent::start_send_gcode_to_sdcard(PrintParams params, OnUpdateStatusFn update_fn, WasCancelledFn cancel_fn, OnWaitFn wait_fn)
 {
-    // dispatch_start() moves out of `params`, so snapshot the diagnostic fields first;
+    return dispatch_start<func_start_send_gcode_to_sdcard_legacy, func_start_send_gcode_to_sdcard_0203>(
-    // logging them after the call would print empty strings.
-    const bool        try_emmc_print = params.try_emmc_print;
-    const std::string dev_ip         = params.dev_ip;
-    const std::string dev_id         = params.dev_id;
-
-    int result = dispatch_start<func_start_send_gcode_to_sdcard_legacy, func_start_send_gcode_to_sdcard_0203>(
         BBLNetworkPlugin::instance().get_start_send_gcode_to_sdcard(), params, update_fn, cancel_fn, wait_fn);
-    if (result != 0) {
-        BOOST_LOG_TRIVIAL(error) << "start_send_gcode_to_sdcard failed: result=" << result
-            << ", try_emmc_print=" << try_emmc_print
-            << ", legacy_mode=" << BBLNetworkPlugin::instance().use_legacy_network()
-            << ", dev_ip=" << dev_ip << ", dev_id=" << dev_id;
-    }
-    return result;
 }
 
 int BBLPrinterAgent::start_local_print(PrintParams params, OnUpdateStatusFn update_fn, WasCancelledFn cancel_fn)

src/slic3r/Utils/BBLPrinterAgent.hpp

@@ -110,7 +110,6 @@ public:
     static std::string from_orca_payload(std::string json_text);
 
 private:
-    // why: the lan/cloud DECISION stays machine-side; keep this mechanical branch in sync with publish_json.
     int publish(const std::string& dev_id, const nlohmann::json& j, bool lan_mode);
 };
 

src/slic3r/Utils/CrealityPrintAgent.cpp

@@ -288,27 +288,22 @@ bool CrealityPrintAgent::parse_cfs_response(const std::string&    response,
     return true;
 }
 
-bool CrealityPrintAgent::fetch_filament_info(std::string dev_id, FilamentSyncMode sync_mode)
+bool CrealityPrintAgent::fetch_filament_info(std::string dev_id, FilamentSyncMode /*sync_mode*/)
 {
-    if (sync_mode != get_filament_sync_mode())
+    if (device_info.dev_ip.empty()) {
-        return false;
-
-    const MoonrakerDeviceInfo info = snapshot_device_info();
-
-    if (info.dev_ip.empty()) {
         BOOST_LOG_TRIVIAL(warning)
             << "CrealityPrintAgent::fetch_filament_info: no device IP, falling back to base agent";
-        return MoonrakerPrinterAgent::fetch_filament_info(std::move(dev_id), sync_mode);
+        return MoonrakerPrinterAgent::fetch_filament_info(std::move(dev_id));
     }
 
     // Build a CrealityPrint helper so we can use its model detection + WS helpers
     // (added in upstream PR #13291).
     DynamicPrintConfig cfg;
-    cfg.set_key_value("print_host",                  new ConfigOptionString("http://" + info.dev_ip));
+    cfg.set_key_value("print_host",                  new ConfigOptionString("http://" + device_info.dev_ip));
     cfg.set_key_value("print_host_webui",            new ConfigOptionString(""));
     cfg.set_key_value("printhost_cafile",            new ConfigOptionString(""));
     cfg.set_key_value("printhost_port",              new ConfigOptionString(""));
-    cfg.set_key_value("printhost_apikey",            new ConfigOptionString(info.api_key));
+    cfg.set_key_value("printhost_apikey",            new ConfigOptionString(device_info.api_key));
     cfg.set_key_value("printhost_ssl_ignore_revoke", new ConfigOptionBool(false));
 
     CrealityPrint host(&cfg);
@@ -318,7 +313,7 @@ bool CrealityPrintAgent::fetch_filament_info(std::string dev_id, FilamentSyncMod
         BOOST_LOG_TRIVIAL(info)
             << "CrealityPrintAgent: " << host.model_name()
             << " is not CFS-capable, deferring to base Moonraker agent";
-        return MoonrakerPrinterAgent::fetch_filament_info(std::move(dev_id), sync_mode);
+        return MoonrakerPrinterAgent::fetch_filament_info(std::move(dev_id));
     }
 
     BOOST_LOG_TRIVIAL(info)
@@ -333,7 +328,7 @@ bool CrealityPrintAgent::fetch_filament_info(std::string dev_id, FilamentSyncMod
         BOOST_LOG_TRIVIAL(warning)
             << "CrealityPrintAgent: CFS query failed (" << parse_err << "), "
             << "falling back to base agent";
-        return MoonrakerPrinterAgent::fetch_filament_info(std::move(dev_id), sync_mode);
+        return MoonrakerPrinterAgent::fetch_filament_info(std::move(dev_id));
     }
 
     if (box_count == 0) {
@@ -342,7 +337,7 @@ bool CrealityPrintAgent::fetch_filament_info(std::string dev_id, FilamentSyncMod
         // Moonraker exposes.
         BOOST_LOG_TRIVIAL(info)
             << "CrealityPrintAgent: no active CFS boxes, deferring to base agent";
-        return MoonrakerPrinterAgent::fetch_filament_info(std::move(dev_id), sync_mode);
+        return MoonrakerPrinterAgent::fetch_filament_info(std::move(dev_id));
     }
 
     BOOST_LOG_TRIVIAL(info)
@@ -387,7 +382,7 @@ bool CrealityPrintAgent::fetch_filament_info(std::string dev_id, FilamentSyncMod
         }
     }
 
-    build_ams_payload(box_count, max_slots - 1, trays, sync_mode == FilamentSyncMode::pull);
+    build_ams_payload(box_count, max_slots - 1, trays);
     return true;
 }
 

src/slic3r/Utils/CrealityPrintAgent.hpp

@@ -37,13 +37,12 @@ public:
     };
 
     explicit CrealityPrintAgent(std::string log_dir);
-    ~CrealityPrintAgent() override { shutdown(); }
+    ~CrealityPrintAgent() override = default;
 
     static AgentInfo get_agent_info_static();
     AgentInfo        get_agent_info() override { return get_agent_info_static(); }
 
     bool fetch_filament_info(std::string dev_id, FilamentSyncMode sync_mode = FilamentSyncMode::pull) override;
-    FilamentSyncMode get_filament_sync_mode() const override { return FilamentSyncMode::pull; }
 
     // Parse the boxsInfo JSON returned by CrealityPrint::query_boxes_info() into
     // a flat list of loaded slots, plus the count of CFS boxes the printer reports.

src/slic3r/Utils/IPrinterAgent.hpp

@@ -45,17 +45,6 @@ struct PrinterConnectionParams
     std::string ca_file;
 };
 
-// Sentinel stored as a LAN device's access code when the user has not supplied one, so the device
-// stays registered (has_access_right() is !access_code.empty()). It is not a real credential: every
-// printer agent must translate it back to an empty string before using/sending it on the wire.
-inline constexpr const char* NO_API_KEY_SENTINEL = "*_{NO_API_KEY}_*";
-
-// Returns an empty string when `code` is the "no API key" sentinel, otherwise `code` unchanged.
-inline std::string normalize_access_code(const std::string& code)
-{
-    return code == NO_API_KEY_SENTINEL ? std::string() : code;
-}
-
 /**
  * FilamentSyncMode - Modes for filament data synchronization.
  *
@@ -466,16 +455,9 @@ public:
     virtual CameraStreamMode get_camera_stream_mode() const { return CameraStreamMode::none; }
 
     /**
-     * Refresh filament info from the printer.
+     * Refresh filament info from the printer synchronously.
-     *
+     * Should only be called when get_filament_sync_mode() returns FilamentSyncMode::pull.
-     * When called with FilamentSyncMode::pull (which requires get_filament_sync_mode() to
+     * Populates the MachineObject's DevFilaSystem with fetched filament data.
-     * return pull) this is a blocking, synchronous call: when it returns true the MachineObject's
-     * DevFilaSystem has already been populated and the caller may read it immediately.
-     *
-     * When called with FilamentSyncMode::subscription — by an implementation's own status loop —
-     * the refresh may be performed asynchronously: a true return then means the refresh was
-     * scheduled (or is already in flight), and DevFilaSystem is updated later on the main thread.
-     * Callers must not assume the data is ready on return.
      */
     virtual bool fetch_filament_info(std::string dev_id, FilamentSyncMode sync_mode = FilamentSyncMode::pull) { return false; }
 

src/slic3r/Utils/MoonrakerPrinterAgent.hpp

@@ -13,8 +13,6 @@
 #include <set>
 #include <string>
 #include <thread>
-#include <condition_variable>
-#include <deque>
 
 #include <nlohmann/json.hpp>
 #include <vector>
@@ -23,56 +21,6 @@ namespace Slic3r { class ICloudServiceAgent; }
 
 namespace Slic3r {
 
-class Http;
-
-bool moonraker_is_light_name(const std::string& name);
-// Direction encoded by a light name: +1 turns on, -1 turns off, 0 is an ambiguous toggle.
-// e.g. LIGHT_ON -> +1, LIGHT_OFF -> -1, LIGHT -> 0.
-int moonraker_light_name_direction(const std::string& name);
-
-struct MoonrakerWebcamSelection
-{
-    std::string      url;
-    CameraStreamMode mode = CameraStreamMode::none;
-    std::string      name;
-    std::string      error;  // set when no selectable webcam was found
-};
-
-// Selects a webcam from a parsed /server/webcams/list response (the top-level JSON or its
-// "result" value). Returns true and fills url/mode/name on success; on failure returns
-// false and sets error.
-bool moonraker_parse_webcam_list(const nlohmann::json& response, const std::string& base_url,
-                                 MoonrakerWebcamSelection& out);
-
-class MoonrakerWebsocket
-{
-public:
-    enum class ReadResult
-    {
-        message,
-        timeout,
-        closed,
-        error,
-    };
-
-    MoonrakerWebsocket(bool secure, std::string api_key, std::string ca_file);
-    ~MoonrakerWebsocket();
-
-    void connect(const std::string& host, const std::string& port, std::chrono::seconds timeout);
-    void tls_handshake(const std::string& host);
-    void handshake(const std::string& host, const std::string& target);
-    void text(bool enabled);
-    void write(const std::string& body);
-    ReadResult read(std::string& payload, std::string& error_message);
-    void close();
-    void expires_after(std::chrono::seconds timeout);
-    void abort();
-
-private:
-    struct Impl;
-    std::unique_ptr<Impl> m_impl;
-};
-
 class MoonrakerPrinterAgent : public IPrinterAgent
 {
 public:
@@ -118,26 +66,12 @@ public:
     int set_on_local_connect_fn(OnLocalConnectedFn fn) override;
     int set_on_local_message_fn(OnMessageFn fn) override;
     int set_queue_on_main_fn(QueueOnMainFn fn) override;
-    bool fetch_filament_info(std::string dev_id, FilamentSyncMode sync_mode = FilamentSyncMode::pull) override;
+
     // Pull-mode agent (on-demand filament sync)
     FilamentSyncMode get_filament_sync_mode() const override { return FilamentSyncMode::pull; }
-    CameraStreamMode get_camera_stream_mode() const override;
+    bool fetch_filament_info(std::string dev_id, FilamentSyncMode sync_mode = FilamentSyncMode::pull) override;
-    std::string get_camera_url() const override;
-
-    // Called by the fetch-thread RAII guard when a background filament fetch finishes.
-    // Serialized with the reservation so shutdown()'s wait cannot miss the transition to 0.
-    void release_fetch_slot() noexcept;
 
 protected:
-    struct ConnectionSettings
-    {
-        std::string dev_id;
-        std::string base_url;
-        std::string api_key;
-        bool        use_ssl = false;
-        std::string ca_file;
-    };
-
     struct MoonrakerDeviceInfo
     {
         std::string dev_id;
@@ -149,9 +83,7 @@ protected:
         std::string dev_name;
         std::string version;
         std::string klippy_state;
-        float       nozzle_diameter = 0.0f;
         bool        use_ssl = false;
-        std::string ca_file;
     } device_info;
 
     // Copied when the stream starts, so changes apply to the next start_status_stream()
@@ -175,47 +107,18 @@ protected:
         int         nozzle_temp = 0;     // Optional
     };
 
-    // Build ams JSON and call parser.
+    // Build ams JSON and call parser
-    // apply_inline: when true the MachineObject mutation runs on the calling thread, which
+    void build_ams_payload(int ams_count, int max_lane_index, const std::vector<AmsTrayData>& trays);
-    // must therefore be the main thread; when false it is deferred through queue_on_main_fn.
-    // Pull-mode fetches run synchronously on the GUI thread and are read back immediately, so
-    // they pass true to avoid the deferred mutation landing after the caller's read.
-    //
-    // resolve_tray_ids: optional hook that runs as part of the commit, i.e. on the main thread.
-    // Agents that would otherwise resolve tray_info_idx against GUI-owned preset state on a
-    // background fetch thread must do it here to avoid racing the GUI. It must not capture
-    // `this` (the commit may outlive the agent).
-    using ResolveAmsTrayIdsFn = std::function<void(std::vector<AmsTrayData>&)>;
-    void build_ams_payload(int ams_count, int max_lane_index, const std::vector<AmsTrayData>& trays, bool apply_inline = false,
-                           ResolveAmsTrayIdsFn resolve_tray_ids = {});
 
     // Methods that derived classes may need to override or access
-    virtual bool init_device_info(const PrinterConnectionParams& params);
+    virtual bool init_device_info(const std::string& dev_id, const std::string& dev_ip, const std::string& username, const std::string& password, bool use_ssl, const std::string& port);
-    virtual bool fetch_device_info(const ConnectionSettings& connection, MoonrakerDeviceInfo& info, std::string& error) const;
+    virtual bool fetch_device_info(const std::string& base_url, const std::string& api_key, MoonrakerDeviceInfo& info, std::string& error) const;
-    ConnectionSettings get_connection_settings() const;
+    void start_status_stream(const std::string& dev_id, const std::string& base_url, const std::string& api_key);
-    // Copy of the mutable connection state, taken under connect_mutex. Background threads
-    // must use this instead of reading device_info directly.
-    MoonrakerDeviceInfo snapshot_device_info() const;
-    void configure_http(Http& http, const ConnectionSettings& connection) const;
-    static float parse_nozzle_diameter(const nlohmann::json& response);
-    // The connection is copied when the stream starts, so changes apply to the next start.
-    void start_status_stream(const std::string& dev_id, ConnectionSettings connection);
     void stop_status_stream();
 
     // State access for derived classes
     mutable std::recursive_mutex       state_mutex;
 
-    // Detached fetch threads hold a raw `this`; shutdown() waits for this to reach 0.
-    std::atomic<int> filament_fetch_in_flight{0};
-
-    // Idempotent teardown; must be called from the most-derived destructor.
-    void shutdown();
-    std::atomic<bool> shutting_down{false};
-
-    // Serializes the shutting_down check with the in-flight reservation.
-    std::mutex fetch_lifecycle_mutex;
-    std::condition_variable fetch_done_cv;  // notified when filament_fetch_in_flight reaches 0
-
     // Helpers
     bool        is_numeric(const std::string& value);
     std::string normalize_base_url(bool use_ssl, const std::string& host, const std::string& port);
@@ -228,30 +131,13 @@ protected:
     // Map filament type to OrcaFilamentLibrary preset ID for AMS sync compatibility
     static std::string map_filament_type_to_generic_id(const std::string& filament_type);
 
-    // Send a G-code script via Moonraker (/printer/gcode/script)
-    bool send_gcode(const std::string& dev_id, const std::string& gcode) const;
-    bool send_gcode(const std::string& dev_id, const std::string& gcode,
-                    const ConnectionSettings& connection) const;
-    bool post_print_action(const std::string& action) const;
-    bool post_print_action(const std::string& action,
-                           const ConnectionSettings& connection) const;
-
-    bool send_ws_rpc(const std::string& method, const nlohmann::json& params);
-
-    virtual void on_status_loop_tick(const std::string& dev_id) {}
-
-    // Queue work that may use agent state. The command worker is joined during
-    // destruction, so queued commands cannot outlive the agent.
-    void enqueue_command(std::function<void()> fn);
-    mutable std::recursive_mutex connect_mutex;
-
 private:
     int handle_request(const std::string& dev_id, const std::string& json_str);
     int send_version_info(const std::string& dev_id);
     int send_access_code(const std::string& dev_id);
 
-    bool fetch_object_list(const ConnectionSettings& connection, std::set<std::string>& objects, std::string& error) const;
+    bool fetch_object_list(const std::string& base_url, const std::string& api_key, std::set<std::string>& objects, std::string& error) const;
-    bool query_printer_status(const ConnectionSettings& connection, nlohmann::json& status, std::string& error) const;
+    bool query_printer_status(const std::string& base_url, const std::string& api_key, nlohmann::json& status, std::string& error) const;
     bool send_gcode_sync(const std::string& dev_id, const std::string& gcode) const;
     void send_gcode_async(const std::string& dev_id, const std::string& gcode,
                           std::function<void(bool)> on_result = {}) const;
@@ -259,46 +145,38 @@ private:
     void announce_printhost_device();
     void dispatch_local_connect(int state, const std::string& dev_id, const std::string& msg);
     void dispatch_printer_connected(const std::string& dev_id);
-
-    // Self-contained snapshot of the message callbacks. Async completions capture this
-    // by value so they never dereference `this` after the agent may have been destroyed.
-    struct MessageRouter
-    {
-        OnMessageFn   local_fn;
-        OnMessageFn   cloud_fn;
-        QueueOnMainFn queue_fn;
-        std::string   dev_id;
-
-        void deliver(std::string payload) const;
-    };
-
-    MessageRouter make_message_router(const std::string& dev_id) const;
     void dispatch_message(const std::string& dev_id, const std::string& payload);
     // Joins a stream stopped from its own callback, so a new stream can start without waiting on it under connect_mutex
     void join_stopped_status_stream();
-    void run_status_stream(std::string dev_id, ConnectionSettings connection, StatusStreamTimings timings);
+    void run_status_stream(std::string dev_id, std::string base_url, std::string api_key, StatusStreamTimings timings);
-    void handle_ws_message(std::string dev_id, std::string payload, ConnectionSettings connection);
+    void handle_ws_message(const std::string& dev_id, const std::string& payload);
     void send_heartbeat_if_due(const std::string& dev_id, std::chrono::milliseconds interval);
-    void refresh_thumbnail_url(const ConnectionSettings& connection);
     void update_status_cache(const nlohmann::json& updates);
     nlohmann::json build_print_payload_locked() const;
 
+    // Print control helpers
+    int pause_print(const std::string& dev_id);
+    int resume_print(const std::string& dev_id);
+    int cancel_print(const std::string& dev_id);
+
     // File upload
     bool upload_gcode(const std::string& local_path, const std::string& filename,
-                      const ConnectionSettings& connection,
+                      const std::string& base_url, const std::string& api_key,
                       OnUpdateStatusFn update_fn, WasCancelledFn cancel_fn);
 
+    // JSON-RPC helper
+    bool send_jsonrpc_command(const std::string& base_url, const std::string& api_key,
+                              const nlohmann::json& request, std::string& response) const;
+
     // Connection thread management
     void perform_connection_async(const std::string& dev_id,
-                                   ConnectionSettings connection,
+                                   const std::string& base_url,
+                                   const std::string& api_key,
                                    uint64_t generation);
 
-    void refresh_webcam_info() const;
-    bool fetch_webcam_info(const ConnectionSettings& connection, uint64_t generation) const;
-
     // System-specific filament fetch methods
-    bool fetch_hh_filament_info(const ConnectionSettings& connection, std::vector<AmsTrayData>& trays, int& max_lane_index);
+    bool fetch_hh_filament_info(std::vector<AmsTrayData>& trays, int& max_lane_index);
-    bool fetch_moonraker_filament_data(const ConnectionSettings& connection, std::vector<AmsTrayData>& trays, int& max_lane_index);
+    bool fetch_moonraker_filament_data(std::vector<AmsTrayData>& trays, int& max_lane_index);
 
     // JSON helper methods
     static std::string safe_json_string(const nlohmann::json& obj, const char* key);
@@ -324,37 +202,16 @@ private:
 
     mutable std::recursive_mutex payload_mutex;
     nlohmann::json     status_cache;
-    // note: guarded by payload_mutex; filled by refresh_thumbnail_url(), empty url = looked up, none found
-    std::string        thumbnail_filename;
-    std::string        thumbnail_url;
-    mutable std::string        webcam_stream_url;
-    mutable CameraStreamMode   webcam_stream_mode = CameraStreamMode::none;
-    // Next time the status loop may look the webcam up again (steady_clock ms).
-    mutable std::atomic<uint64_t> webcam_info_next_attempt_ms{0};
-    unsigned            thumbnail_lookup_attempts = 0;
-
-    static constexpr uint64_t WEBCAM_INFO_REFRESH_INTERVAL_MS = 30000;
-    static constexpr uint64_t WEBCAM_INFO_FAILURE_BACKOFF_MS  = 60000;
 
     std::atomic<int>       next_jsonrpc_id{1};
     std::set<std::string>  available_objects;  // Track for feature detection
-    bool                   assumed_light_on = false;
 
     std::atomic<bool>   ws_stop{false};
     std::atomic<bool>   ws_reconnect_requested{false};  // Flag to trigger reconnection
     std::atomic<uint64_t> ws_last_emit_ms{0};
     std::thread         ws_thread;
-
+    std::mutex          ws_abort_mutex; // Guards ws_thread and ws_abort
-    // Guards ws_thread and ws_abort. ws_abort posts to the stream's io_context, cancelling the
+    std::function<void()> ws_abort; // Interrupts whatever the stream thread is waiting on, from any thread
-    // reconnect wait and interrupting whatever connection attempt is running, so stop is prompt
-    // even when the stream thread is blocked on connect, TLS, or a read.
-    std::mutex            ws_abort_mutex;
-    std::function<void()> ws_abort;  // guarded by ws_abort_mutex
-
-    // AMS/filament refresh cadence, independent of telemetry dispatch so a steady
-    // stream of status updates can't starve it (ws_last_emit_ms is reset by those).
-    static constexpr uint64_t AMS_REFRESH_INTERVAL_MS = 10000;
-    std::atomic<uint64_t> ams_last_fetch_ms{0};
 
     // Throttling configuration for WebSocket updates
     // Critical changes (state transitions) dispatch immediately; telemetry is throttled
@@ -365,13 +222,7 @@ private:
     // Connection thread management
     std::atomic<uint64_t>  connect_generation{0};
     std::thread            connect_thread;
-
+    std::recursive_mutex   connect_mutex;
-    void run_command_worker();
-    std::thread cmd_thread;
-    std::deque<std::function<void()>> cmd_queue;
-    std::mutex cmd_mutex;
-    std::condition_variable cmd_cv;
-    bool cmd_stop = false;
 };
 
 } // namespace Slic3r

src/slic3r/Utils/QidiPrinterAgent.cpp

@@ -2,25 +2,18 @@
 #include "Http.hpp"
 #include "MoonrakerPrinterAgent.hpp"
 #include "IPrinterAgent.hpp"
-#include "bambu_networking.hpp"
 #include "libslic3r/PresetBundle.hpp"
 #include "slic3r/GUI/GUI_App.hpp"
 
 #include "nlohmann/json.hpp"
-#include <atomic>
 #include <boost/algorithm/string.hpp>
 #include <boost/algorithm/string/trim.hpp>
 #include <boost/algorithm/string/case_conv.hpp>
 #include <boost/log/trivial.hpp>
 #include <cctype>
-#include <cmath>
 #include "libslic3r/Preset.hpp"
-#include <cstddef>
-#include <exception>
 #include <map>
-#include <mutex>
 #include <sstream>
-#include <thread>
 #include <string>
 #include <utility>
 #include <vector>
@@ -41,40 +34,6 @@ bool has_visible_base_preset(const PresetCollection& filaments, const std::strin
     return false;
 }
 
-// RAII release of the in-flight fetch slot; movable so a failed thread start still releases it.
-struct InFlightGuard
-{
-    MoonrakerPrinterAgent* owner;
-    explicit InFlightGuard(MoonrakerPrinterAgent& o) noexcept : owner(&o) {}
-    InFlightGuard(InFlightGuard&& other) noexcept : owner(other.owner) { other.owner = nullptr; }
-    InFlightGuard(const InFlightGuard&) = delete;
-    InFlightGuard& operator=(const InFlightGuard&) = delete;
-    InFlightGuard& operator=(InFlightGuard&&) = delete;
-    ~InFlightGuard() { if (owner) owner->release_fetch_slot(); }
-};
-
-// nlohmann::json::value() returns the default only when the key is absent; a present but
-// null/wrong-typed value throws. Firmware JSON is untrusted, so read defensively.
-int read_int_or(const nlohmann::json& obj, const std::string& key, int fallback)
-{
-    auto it = obj.find(key);
-    if (it == obj.end()) {
-        return fallback;
-    }
-    if (it->is_number_integer()) {
-        return it->get<int>();
-    }
-    // Firmware may report an integral field as a JSON float (e.g. 2.0). Accept it only when it
-    // has no fractional part, so a genuinely fractional value falls back instead of truncating.
-    if (it->is_number_float()) {
-        const double value = it->get<double>();
-        if (value == std::floor(value)) {
-            return static_cast<int>(value);
-        }
-    }
-    return fallback;
-}
-
 } // anonymous namespace
 
 const std::string QidiPrinterAgent_VERSION = "0.0.1";
@@ -88,179 +47,51 @@ AgentInfo QidiPrinterAgent::get_agent_info_static()
     return AgentInfo{"qidi", "Qidi", QidiPrinterAgent_VERSION, "Qidi printer agent"};
 }
 
-FilamentSyncMode QidiPrinterAgent::get_filament_sync_mode() const
+bool QidiPrinterAgent::fetch_filament_info(std::string dev_id, FilamentSyncMode /*sync_mode*/)
 {
-    if (GUI::wxGetApp().app_config->get_bool("use_printer_agents"))
-        return FilamentSyncMode::subscription;
-    return FilamentSyncMode::pull;
-}
-
-bool QidiPrinterAgent::fetch_filament_info(std::string dev_id, FilamentSyncMode sync_mode)
-{
-    if (sync_mode != get_filament_sync_mode())
-        return false;
-
-    // Snapshot what the fetch needs; a reconnect can rewrite device_info meanwhile.
-    ConnectionSettings connection = get_connection_settings();
-    std::string        model_id;
-    std::string        model_name;
-    {
-        std::lock_guard<std::recursive_mutex> lock(connect_mutex);
-        model_id   = device_info.model_id;
-        model_name = device_info.model_name;
-    }
-
-    // One implementation for both modes; only where it runs differs. pull is the documented
-    // blocking contract (the GUI thread reads DevFilaSystem right after the call), so it runs
-    // on the caller with the payload applied inline. subscription runs on a background thread
-    // so the status loop is not stalled, and the payload is marshalled back to the main thread.
-    auto work = [this, connection = std::move(connection), model_id, model_name](bool apply_inline) -> bool {
-        try {
     std::string error;
 
     // 1. Fetch device info and infer series_id
     std::string series_id;
     {
         MoonrakerDeviceInfo info;
-                if (fetch_device_info(connection, info, error)) {
+        if (fetch_device_info(device_info.base_url, device_info.api_key, info, error)) {
             series_id = infer_series_id(info.model_id, info.dev_name);
         }
     }
     if (series_id.empty()) {
         // Fall back to the configured Orca model if Moonraker doesn't expose a usable identifier.
-                series_id = infer_series_id(model_id, model_name);
+        series_id = infer_series_id(device_info.model_id, device_info.model_name);
     }
 
     // 2. Fetch filament dictionary
     QidiFilamentDict dict;
-            if (!fetch_filament_dict(connection, dict, error)) {
+    if (!fetch_filament_dict(device_info.base_url, device_info.api_key, dict, error)) {
         BOOST_LOG_TRIVIAL(warning) << "QidiPrinterAgent::fetch_filament_info: Failed to fetch filament dict: " << error;
     }
 
     // 3. Fetch slot info and build AmsTrayData directly
     std::vector<AmsTrayData> trays;
     int                      box_count = 0;
-            if (!fetch_slot_info(connection, dict, series_id, trays, box_count, error)) {
+    if (!fetch_slot_info(device_info.base_url, device_info.api_key, dict, series_id, trays, box_count, error)) {
         BOOST_LOG_TRIVIAL(warning) << "QidiPrinterAgent::fetch_filament_info: Failed to fetch slot info: " << error;
         return false;
     }
 
-            // 4. Build the AMS payload, resolving preset-dependent ids on the main thread.
+    // 4. Build the AMS payload
-            auto resolve_ids = [](std::vector<AmsTrayData>& resolved_trays) {
+    build_ams_payload(box_count, box_count * 4 - 1, trays);
-                auto* bundle = GUI::wxGetApp().preset_bundle;
-                if (!bundle) {
-                    return; // keep the Qidi-specific ids computed from device data
-                }
-                for (auto& tray : resolved_trays) {
-                    if (!tray.has_filament) {
-                        continue;
-                    }
-                    if (!tray.tray_info_idx.empty() && has_visible_base_preset(bundle->filaments, tray.tray_info_idx)) {
-                        continue;
-                    }
-                    tray.tray_info_idx = bundle->filaments.filament_id_by_type(tray.tray_type);
-                }
-            };
-            build_ams_payload(box_count, box_count * 4 - 1, trays, apply_inline, resolve_ids);
-            return true;
-        } catch (const std::exception& e) {
-            // why: an exception escaping a detached thread is std::terminate, and firmware
-            // JSON is untrusted; mirror run_command_worker and swallow it here.
-            BOOST_LOG_TRIVIAL(error) << "QidiPrinterAgent::fetch_filament_info: unhandled exception: " << e.what();
-            return false;
-        } catch (...) {
-            BOOST_LOG_TRIVIAL(error) << "QidiPrinterAgent::fetch_filament_info: unhandled exception";
-            return false;
-        }
-    };
-
-    if (sync_mode == FilamentSyncMode::pull) {
-        return work(/*apply_inline=*/true);
-    }
-
-    // Subscription: fire-and-forget. A `true` return means the refresh was scheduled (or is
-    // already running), not that DevFilaSystem has been updated. Reserve under the same mutex
-    // shutdown() uses, so the flag and the count can't race.
-    {
-        std::lock_guard<std::mutex> lock(fetch_lifecycle_mutex);
-        if (shutting_down.load())
-            return false;
-        if (filament_fetch_in_flight.load() > 0)
-            return true; // a fetch is already running; don't pile on
-        filament_fetch_in_flight.fetch_add(1, std::memory_order_relaxed);
-    }
-
-    InFlightGuard guard{*this};
-    std::thread([work = std::move(work), guard = std::move(guard)]() mutable {
-        work(/*apply_inline=*/false);
-    }).detach();
     return true;
 }
 
-bool QidiPrinterAgent::apply_box_mapping(const PrintParams& params) const
+bool QidiPrinterAgent::fetch_slot_info(const std::string&        base_url,
-{
+                                       const std::string&        api_key,
-    // enable_box mirrors task_use_ams: engage the multi-color box only when this
-    // job actually routes filament through it. (See qidi-ams-findings.md §2/§8.3 —
-    // if firmware treats enable_box as "a box exists" rather than "use it this job",
-    // switch this gate to HasAms()/box_count instead.)
-    const int         enable = params.task_use_ams ? 1 : 0;
-    const std::string dev_id = get_connection_settings().dev_id;
-
-    // Build one gcode/script request instead of N blocking HTTP calls: apply_box_mapping
-    // runs on the caller's (GUI) thread before the print starts, so per-tool round trips
-    // would freeze the UI.
-    std::string script = "SAVE_VARIABLE VARIABLE=enable_box VALUE=" + std::to_string(enable);
-
-    // When the box isn't used this job, leave the existing value_t<tool> slot
-    // assignments untouched (enable_box=0 is enough to disengage it).
-    if (enable) {
-        if (params.ams_mapping.empty()) {
-            BOOST_LOG_TRIVIAL(warning) << "QidiPrinterAgent::apply_box_mapping: enable_box set but ams_mapping is empty";
-        } else {
-            // ams_mapping (v0) is a JSON array indexed by filament/tool; each value is the
-            // physical box slot (-1 = unmapped). Mirror it onto value_t<tool>.
-            auto mapping = nlohmann::json::parse(params.ams_mapping, nullptr, /*allow_exceptions*/ false);
-            if (mapping.is_discarded() || !mapping.is_array()) {
-                BOOST_LOG_TRIVIAL(error) << "QidiPrinterAgent::apply_box_mapping: invalid ams_mapping: " << params.ams_mapping;
-                return false;
-            }
-            for (size_t tool = 0; tool < mapping.size(); ++tool) {
-                if (!mapping[tool].is_number_integer())
-                    continue;
-                const int slot = mapping[tool].get<int>();
-                if (slot < 0)
-                    continue; // unmapped filament — skip
-                script += "\nSAVE_VARIABLE VARIABLE=value_t" + std::to_string(tool) +
-                          " VALUE=\"'slot" + std::to_string(slot) + "'\"";
-            }
-        }
-    }
-
-    if (!send_gcode(dev_id, script)) {
-        BOOST_LOG_TRIVIAL(error) << "QidiPrinterAgent::apply_box_mapping: failed to send box mapping";
-        return false;
-    }
-    return true;
-}
-
-int QidiPrinterAgent::start_local_print(PrintParams params, OnUpdateStatusFn update_fn, WasCancelledFn cancel_fn)
-{
-    // Only the LAN print path is implemented by the Moonraker base; the box config is emitted
-    // here, before the print starts. The cloud/record/sdcard variants inherited from the base
-    // deliberately return ORCA_NETWORK_ERR_CMD_NOT_SUPPORTED without side effects.
-    if (!apply_box_mapping(params))
-        return BAMBU_NETWORK_ERR_PRINT_LP_PUBLISH_MSG_FAILED;
-    return MoonrakerPrinterAgent::start_local_print(std::move(params), update_fn, cancel_fn);
-}
-
-bool QidiPrinterAgent::fetch_slot_info(const ConnectionSettings& connection,
                                        const QidiFilamentDict&   dict,
                                        const std::string&        series_id,
                                        std::vector<AmsTrayData>& trays,
                                        int&                      box_count,
                                        std::string&              error)
 {
-    std::string url = join_url(connection.base_url, "/printer/objects/query?save_variables=variables");
+    std::string url = join_url(base_url, "/printer/objects/query?save_variables=variables");
     for (int i = 0; i < 16; ++i) {
         url += "&box_stepper%20slot" + std::to_string(i) + "=runout_button";
     }
@@ -270,9 +101,8 @@ bool QidiPrinterAgent::fetch_slot_info(const ConnectionSettings& connection,
     std::string http_error;
 
     auto http = Http::get(url);
-    configure_http(http, connection);
+    if (!api_key.empty()) {
-    if (!connection.api_key.empty()) {
+        http.header("X-Api-Key", api_key);
-        http.header("X-Api-Key", connection.api_key);
     }
     http.timeout_connect(5)
         .timeout_max(10)
@@ -297,12 +127,22 @@ bool QidiPrinterAgent::fetch_slot_info(const ConnectionSettings& connection,
         return false;
     }
 
-    nlohmann::json status;
+    auto json = nlohmann::json::parse(response_body, nullptr, false, true);
-    nlohmann::json variables;
+    if (json.is_discarded()) {
-    if (!parse_slot_response(response_body, status, variables, error))
+        error = "Invalid JSON response";
         return false;
+    }
 
-    box_count = read_int_or(variables, "box_count", 1);
+    if (!json.contains("result") || !json["result"].contains("status") || !json["result"]["status"].contains("save_variables") ||
+        !json["result"]["status"]["save_variables"].contains("variables")) {
+        error = "Unexpected JSON structure";
+        return false;
+    }
+
+    auto& variables = json["result"]["status"]["save_variables"]["variables"];
+    auto& status    = json["result"]["status"];
+
+    box_count = variables.value("box_count", 1);
     if (box_count < 0) {
         box_count = 0;
     }
@@ -325,9 +165,9 @@ bool QidiPrinterAgent::fetch_slot_info(const ConnectionSettings& connection,
         tray.slot_index = i;
 
         // Read slot variables
-        const int color_index     = read_int_or(variables, "color_slot" + std::to_string(i), 1);
+        const int color_index     = variables.value("color_slot" + std::to_string(i), 1);
-        const int filament_type   = read_int_or(variables, "filament_slot" + std::to_string(i), 1);
+        const int filament_type   = variables.value("filament_slot" + std::to_string(i), 1);
-        const int vendor_type     = read_int_or(variables, "vendor_slot" + std::to_string(i), 0);
+        const int vendor_type     = variables.value("vendor_slot" + std::to_string(i), 0);
 
         // Check filament presence via runout sensor
         std::string box_stepper_key = "box_stepper slot" + std::to_string(i);
@@ -335,7 +175,7 @@ bool QidiPrinterAgent::fetch_slot_info(const ConnectionSettings& connection,
         if (status.contains(box_stepper_key)) {
             auto& box_stepper = status[box_stepper_key];
             if (box_stepper.contains("runout_button") && !box_stepper["runout_button"].is_null()) {
-                const int runout_button = read_int_or(box_stepper, "runout_button", 0);
+                int runout_button = box_stepper["runout_button"].template get<int>();
                 tray.has_filament = (runout_button == 0);
             }
         }
@@ -349,9 +189,16 @@ bool QidiPrinterAgent::fetch_slot_info(const ConnectionSettings& connection,
             }
             tray.tray_type = normalize_filament_type(filament_name);
 
-            // Qidi-specific setting id derived from device data only; the preset-dependent
+            // Try Qidi-specific setting ID first; fall back to visible preset by type
-            // fallback runs on the main thread in the resolve hook passed to build_ams_payload.
+            std::string setting_id = build_setting_id(filament_type, vendor_type, tray.tray_type);
-            tray.tray_info_idx = build_setting_id(filament_type, vendor_type, tray.tray_type);
+            auto* bundle = GUI::wxGetApp().preset_bundle;
+            if (!bundle) {
+                tray.tray_info_idx = setting_id;
+            } else if (!setting_id.empty() && has_visible_base_preset(bundle->filaments, setting_id)) {
+                tray.tray_info_idx = setting_id;
+            } else {
+                tray.tray_info_idx = bundle->filaments.filament_id_by_type(tray.tray_type);
+            }
 
             // Look up color from dictionary
             auto color_it = dict.colors.find(color_index);
@@ -368,45 +215,20 @@ bool QidiPrinterAgent::fetch_slot_info(const ConnectionSettings& connection,
     return true;
 }
 
-bool QidiPrinterAgent::parse_slot_response(const std::string& response_body,
+bool QidiPrinterAgent::fetch_filament_dict(const std::string& base_url,
-                                           nlohmann::json&    status,
+                                           const std::string& api_key,
-                                           nlohmann::json&    variables,
-                                           std::string&       error)
-{
-    auto json = nlohmann::json::parse(response_body, nullptr, false, true);
-    if (json.is_discarded()) {
-        error = "Invalid JSON response";
-        return false;
-    }
-
-    if (!json.is_object() || !json.contains("result") || !json["result"].is_object() || !json["result"].contains("status") ||
-        !json["result"]["status"].is_object() || !json["result"]["status"].contains("save_variables") ||
-        !json["result"]["status"]["save_variables"].is_object() || !json["result"]["status"]["save_variables"].contains("variables") ||
-        !json["result"]["status"]["save_variables"]["variables"].is_object()) {
-        // why: Qidi firmware may send null here, but json::value() throws for it.
-        error = "Unexpected JSON structure: save_variables.variables must be an object";
-        return false;
-    }
-
-    status    = json["result"]["status"];
-    variables = status["save_variables"]["variables"];
-    return true;
-}
-
-bool QidiPrinterAgent::fetch_filament_dict(const ConnectionSettings& connection,
                                            QidiFilamentDict& dict,
                                            std::string& error) const
 {
-    std::string url = join_url(connection.base_url, "/server/files/config/officiall_filas_list.cfg");
+    std::string url = join_url(base_url, "/server/files/config/officiall_filas_list.cfg");
 
     std::string response_body;
     bool        success = false;
     std::string http_error;
 
     auto http = Http::get(url);
-    configure_http(http, connection);
+    if (!api_key.empty()) {
-    if (!connection.api_key.empty()) {
+        http.header("X-Api-Key", api_key);
-        http.header("X-Api-Key", connection.api_key);
     }
     http.timeout_connect(5)
         .timeout_max(10)

src/slic3r/Utils/QidiPrinterAgent.hpp

@@ -3,8 +3,6 @@
 
 #include "IPrinterAgent.hpp"
 #include "MoonrakerPrinterAgent.hpp"
-#include "bambu_networking.hpp"
-#include "nlohmann/json_fwd.hpp"
 
 #include <map>
 #include <string>
@@ -16,7 +14,7 @@ class QidiPrinterAgent final : public MoonrakerPrinterAgent
 {
 public:
     explicit QidiPrinterAgent(std::string log_dir);
-    ~QidiPrinterAgent() override { shutdown(); }
+    ~QidiPrinterAgent() override = default;
 
     static AgentInfo get_agent_info_static();
     AgentInfo        get_agent_info() override { return get_agent_info_static(); }
@@ -24,22 +22,7 @@ public:
     // Override filament sync (Qidi-specific implementation)
     bool fetch_filament_info(std::string dev_id, FilamentSyncMode sync_mode = FilamentSyncMode::pull) override;
 
-    static bool parse_slot_response(const std::string& response_body,
-                                    nlohmann::json&    status,
-                                    nlohmann::json&    variables,
-                                    std::string&       error);
-
-    // Print operations — emit QiDi multi-color box config, then delegate to base.
-    // Only the LAN print path is supported by the base; the cloud/record/sdcard variants
-    // are inherited and return ORCA_NETWORK_ERR_CMD_NOT_SUPPORTED.
-    int start_local_print(PrintParams params, OnUpdateStatusFn update_fn, WasCancelledFn cancel_fn) override;
-
-    FilamentSyncMode get_filament_sync_mode() const override;
-
 private:
-    // Push enable_box + value_t<tool> SAVE_VARIABLEs before a print starts.
-    // Returns false if any command fails (caller should abort the print).
-    bool apply_box_mapping(const PrintParams& params) const;
     struct QidiFilamentDict
     {
         std::map<int, std::string> colors;
@@ -47,13 +30,14 @@ private:
     };
 
     // Qidi-specific methods
-    bool fetch_slot_info(const ConnectionSettings& connection,
+    bool fetch_slot_info(const std::string&        base_url,
+                         const std::string&        api_key,
                          const QidiFilamentDict&   dict,
                          const std::string&        series_id,
                          std::vector<AmsTrayData>& trays,
                          int&                      box_count,
                          std::string&              error);
-    bool fetch_filament_dict(const ConnectionSettings& connection, QidiFilamentDict& dict, std::string& error) const;
+    bool fetch_filament_dict(const std::string& base_url, const std::string& api_key, QidiFilamentDict& dict, std::string& error) const;
     std::string normalize_filament_type(const std::string& filament_type);
     std::string infer_series_id(const std::string& model_id, const std::string& dev_name);
     std::string normalize_model_key(std::string value);

src/slic3r/Utils/SnapmakerPrinterAgent.cpp

@@ -2,20 +2,11 @@
 #include "Http.hpp"
 #include "MoonrakerPrinterAgent.hpp"
 #include "IPrinterAgent.hpp"
-#include "bambu_networking.hpp"
 #include "libslic3r/PresetBundle.hpp"
 #include "slic3r/GUI/GUI_App.hpp"
 
 #include "nlohmann/json.hpp"
-#include <atomic>
 #include <boost/log/trivial.hpp>
-#include <chrono>
-#include <cmath>
-#include <cstdint>
-#include <exception>
-#include <mutex>
-#include <sstream>
-#include <thread>
 #include <vector>
 #include <string>
 #include "libslic3r/Preset.hpp"
@@ -27,91 +18,6 @@ namespace Slic3r {
 namespace {
 
 constexpr const char* SNAPMAKER_AGENT_VERSION = "0.0.1";
-constexpr int64_t     CAMERA_REFRESH_INTERVAL_MS = 300'000;
-
-int64_t now_ms()
-{
-    return std::chrono::duration_cast<std::chrono::milliseconds>(
-        std::chrono::steady_clock::now().time_since_epoch()).count();
-}
-
-// RAII release of the in-flight fetch slot; movable so a failed thread start still releases it.
-struct InFlightGuard
-{
-    MoonrakerPrinterAgent* owner;
-    explicit InFlightGuard(MoonrakerPrinterAgent& o) noexcept : owner(&o) {}
-    InFlightGuard(InFlightGuard&& other) noexcept : owner(other.owner) { other.owner = nullptr; }
-    InFlightGuard(const InFlightGuard&) = delete;
-    InFlightGuard& operator=(const InFlightGuard&) = delete;
-    InFlightGuard& operator=(InFlightGuard&&) = delete;
-    ~InFlightGuard() { if (owner) owner->release_fetch_slot(); }
-};
-
-// nlohmann::json::value() returns the default only when the key is absent; a present but
-// null/wrong-typed value throws. Firmware JSON is untrusted, so read defensively.
-int read_int_or(const nlohmann::json& obj, const char* key, int fallback)
-{
-    auto it = obj.find(key);
-    if (it == obj.end()) {
-        return fallback;
-    }
-    if (it->is_number_integer()) {
-        return it->get<int>();
-    }
-    // Firmware may report an integral field as a JSON float (e.g. 2.0). Accept it only when it
-    // has no fractional part, so a genuinely fractional value falls back instead of truncating.
-    if (it->is_number_float()) {
-        const double value = it->get<double>();
-        if (value == std::floor(value)) {
-            return static_cast<int>(value);
-        }
-    }
-    return fallback;
-}
-
-std::vector<std::string> read_string_array_or(const nlohmann::json& obj, const char* key)
-{
-    auto it = obj.find(key);
-    if (it == obj.end() || !it->is_array())
-        return {};
-    std::vector<std::string> out;
-    out.reserve(it->size());
-    for (const auto& v : *it)
-        out.push_back(v.is_string() ? v.get<std::string>() : std::string{});
-    return out;
-}
-
-std::vector<bool> read_bool_array_or(const nlohmann::json& obj, const char* key)
-{
-    auto it = obj.find(key);
-    if (it == obj.end() || !it->is_array())
-        return {};
-    std::vector<bool> out;
-    out.reserve(it->size());
-    for (const auto& v : *it)
-        out.push_back(v.is_boolean() ? v.get<bool>() : false);
-    return out;
-}
-
-// Parse a hex colour, stopping at the first non-hex character. std::stoul throws on
-// empty/non-hex input, which must not escape the detached fetch thread.
-unsigned int parse_hex_color(const std::string& hex)
-{
-    unsigned int value = 0;
-    for (char c : hex) {
-        int digit;
-        if (c >= '0' && c <= '9')
-            digit = c - '0';
-        else if (c >= 'a' && c <= 'f')
-            digit = c - 'a' + 10;
-        else if (c >= 'A' && c <= 'F')
-            digit = c - 'A' + 10;
-        else
-            break;
-        value = (value << 4) | static_cast<unsigned int>(digit);
-    }
-    return value;
-}
 
 // Safely access a parallel array by index, returning a fallback if out of bounds.
 template<typename T>
@@ -134,16 +40,14 @@ std::string find_closest_color_preset_by_vendor_and_type(const PresetCollection&
             filaments.get_preset_base(p) == &p && p.config.opt_string("filament_vendor", 0u) == vendor_name &&
             p.config.opt_string("filament_type", 0u) == filament_type) {
             // The printer returns RGBA in the format RRGGBBAA, but profiles store color as #RRGGBB,
-            // so we must remove # and ignore alpha channel for distance calculation. Firmware
+            // so we must remove # and ignore alpha channel for distance calculation
-            // colours are untrusted; parse_hex_color tolerates empty/non-hex instead of throwing.
+            unsigned int target_color_value = std::stoul(color_rgba.substr(0, color_rgba.length() - 2), nullptr, 16);
-            unsigned int target_color_value =
-                parse_hex_color(color_rgba.substr(0, color_rgba.size() >= 2 ? color_rgba.size() - 2 : 0));
 
             std::string  p_color = p.config.opt_string("default_filament_colour", 0u);
-            unsigned int p_color_value = 0;
+            unsigned int p_color_value;
             if (!p_color.empty()) {
                 size_t       hash_pos = p_color.find("#");
-                p_color_value   = parse_hex_color(p_color.substr(hash_pos != std::string::npos ? hash_pos + 1 : 0));
+                p_color_value         = std::stoul(p_color.substr(hash_pos != std::string::npos ? hash_pos + 1 : 0), nullptr, 16);
             } else {
                 // Default to black if no color specified in profile. Assume other profiles might be a closer color match.
                 // Could be a problem if the target color is also black and there exist a specific profile for that type, vendor and color
@@ -170,31 +74,6 @@ std::string find_closest_color_preset_by_vendor_and_type(const PresetCollection&
 
 SnapmakerPrinterAgent::SnapmakerPrinterAgent(std::string log_dir) : MoonrakerPrinterAgent(std::move(log_dir)) {}
 
-void SnapmakerPrinterAgent::start_camera_monitor()
-{
-    enqueue_command([this] {
-        send_ws_rpc("camera.start_monitor",
-                    {{"domain", "lan"}, {"interval", 0}, {"expect_pw", false}});
-    });
-    m_camera_last_fire_ms.store(now_ms());
-}
-
-void SnapmakerPrinterAgent::on_status_loop_tick(const std::string& dev_id)
-{
-    (void) dev_id;
-    const int64_t last = m_camera_last_fire_ms.load();
-    if (last == 0 || now_ms() - last >= CAMERA_REFRESH_INTERVAL_MS) {
-        start_camera_monitor();
-    }
-}
-
-int SnapmakerPrinterAgent::command_start_camera(std::string dev_id)
-{
-    (void) dev_id;
-    start_camera_monitor();
-    return BAMBU_NETWORK_SUCCESS;
-}
-
 AgentInfo SnapmakerPrinterAgent::get_agent_info_static()
 {
     return AgentInfo{"snapmaker", "Snapmaker", SNAPMAKER_AGENT_VERSION, "Snapmaker printer agent"};
@@ -230,32 +109,17 @@ std::string SnapmakerPrinterAgent::combine_filament_type(const std::string& type
     return base;
 }
 
-bool SnapmakerPrinterAgent::fetch_filament_info(std::string dev_id, FilamentSyncMode sync_mode)
+bool SnapmakerPrinterAgent::fetch_filament_info(std::string dev_id, FilamentSyncMode /*sync_mode*/)
 {
-    (void) dev_id;
+    std::string url = join_url(device_info.base_url, "/printer/objects/query?print_task_config&filament_detect");
-    if (sync_mode != get_filament_sync_mode())
-        return false;
-
-    // Snapshot everything the fetch needs (URL, api key, TLS/CA): a reconnect can rewrite
-    // device_info meanwhile.
-    const ConnectionSettings connection = get_connection_settings();
-
-    // One implementation for both modes; only where it runs differs. pull is the documented
-    // blocking contract (the GUI thread reads DevFilaSystem right after the call), so it runs
-    // on the caller with the payload applied inline. subscription runs on a background thread
-    // so the status loop is not stalled, and the payload is marshalled back to the main thread.
-    auto work = [this, connection](bool apply_inline) -> bool {
-        try {
-            const std::string url = join_url(connection.base_url, "/printer/objects/query?print_task_config&filament_detect");
 
     std::string response_body;
     bool        success = false;
     std::string http_error;
 
     auto http = Http::get(url);
-            configure_http(http, connection);
+    if (!device_info.api_key.empty()) {
-            if (!connection.api_key.empty()) {
+        http.header("X-Api-Key", device_info.api_key);
-                http.header("X-Api-Key", connection.api_key);
     }
     http.timeout_connect(5)
         .timeout_max(10)
@@ -287,7 +151,8 @@ bool SnapmakerPrinterAgent::fetch_filament_info(std::string dev_id, FilamentSync
     }
 
     // Navigate to result.status.print_task_config
-            if (!json.contains("result") || !json["result"].contains("status") || !json["result"]["status"].contains("print_task_config")) {
+    if (!json.contains("result") || !json["result"].contains("status") ||
+        !json["result"]["status"].contains("print_task_config")) {
         BOOST_LOG_TRIVIAL(warning) << "SnapmakerPrinterAgent::fetch_filament_info: Missing print_task_config in response";
         return false;
     }
@@ -295,11 +160,11 @@ bool SnapmakerPrinterAgent::fetch_filament_info(std::string dev_id, FilamentSync
     auto& ptc = json["result"]["status"]["print_task_config"];
 
     // Read parallel arrays from print_task_config
-            auto filament_exist    = read_bool_array_or(ptc, "filament_exist");
+    auto filament_exist    = ptc.value("filament_exist", std::vector<bool>{});
-            auto filament_type     = read_string_array_or(ptc, "filament_type");
+    auto filament_type     = ptc.value("filament_type", std::vector<std::string>{});
-            auto filament_sub_type = read_string_array_or(ptc, "filament_sub_type");
+    auto filament_sub_type = ptc.value("filament_sub_type", std::vector<std::string>{});
-            auto filament_color    = read_string_array_or(ptc, "filament_color_rgba");
+    auto filament_color    = ptc.value("filament_color_rgba", std::vector<std::string>{});
-            auto filament_vendor   = read_string_array_or(ptc, "filament_vendor");
+    auto filament_vendor   = ptc.value("filament_vendor", std::vector<std::string>{});
 
     const int slot_count = static_cast<int>(filament_exist.size());
     if (slot_count == 0) {
@@ -309,16 +174,14 @@ bool SnapmakerPrinterAgent::fetch_filament_info(std::string dev_id, FilamentSync
 
     // Read NFC filament_detect data for temperature info (optional)
     nlohmann::json nfc_info;
-            if (json["result"]["status"].contains("filament_detect") && json["result"]["status"]["filament_detect"].contains("info")) {
+    if (json["result"]["status"].contains("filament_detect") &&
+        json["result"]["status"]["filament_detect"].contains("info")) {
         nfc_info = json["result"]["status"]["filament_detect"]["info"];
     }
 
     static const std::string empty_str;
     static const std::string default_color = "FFFFFFFF";
 
-            // Per-tray vendor names, kept so the preset lookup can run on the main thread.
-            std::vector<std::string> vendors(slot_count);
-
     std::vector<AmsTrayData> trays;
     trays.reserve(slot_count);
 
@@ -328,24 +191,36 @@ bool SnapmakerPrinterAgent::fetch_filament_info(std::string dev_id, FilamentSync
         tray.has_filament = filament_exist[i];
 
         if (tray.has_filament) {
-                    tray.tray_type  = combine_filament_type(safe_at(filament_type, i, empty_str), safe_at(filament_sub_type, i, empty_str));
+            tray.tray_type     = combine_filament_type(safe_at(filament_type, i, empty_str),
+                                                       safe_at(filament_sub_type, i, empty_str));
             tray.tray_color    = safe_at(filament_color, i, default_color);
-                    vendors[i]      = safe_at(filament_vendor, i, empty_str);
 
-                    // Generic id derived from device data only; the preset-dependent lookup runs
+            auto* bundle = GUI::wxGetApp().preset_bundle;
-                    // on the main thread in the resolve hook passed to build_ams_payload.
+            // Try to find a matching preset for this filament based on vendor, type and color.
+            // If not found, default to traditional search by type only or generic type mapping.
+            if (bundle) {
+                std::string vendor      = safe_at(filament_vendor, i, empty_str);
+                std::string filament_id = find_closest_color_preset_by_vendor_and_type(bundle->filaments, vendor, tray.tray_type,
+                                                                                       tray.tray_color);
+
+                if (!filament_id.empty()) {
+                    tray.tray_info_idx = filament_id;
+                    BOOST_LOG_TRIVIAL(warning) << "Filament sync: Found manufacturer-specific profile for slot " << i << ": "
+                                               << filament_id;
+                } else {
+                    tray.tray_info_idx = bundle->filaments.filament_id_by_type(tray.tray_type);
+                }
+            } else {
                 tray.tray_info_idx = map_filament_type_to_generic_id(tray.tray_type);
+            }
 
             // Extract NFC temperature data if available
             if (nfc_info.is_array() && i < static_cast<int>(nfc_info.size()) && nfc_info[i].is_object()) {
                 auto& nfc_slot = nfc_info[i];
-                        std::string vendor   = "NONE";
+                std::string vendor = nfc_slot.value("VENDOR", "NONE");
-                        if (auto vendor_it = nfc_slot.find("VENDOR"); vendor_it != nfc_slot.end() && vendor_it->is_string()) {
-                            vendor = vendor_it->get<std::string>();
-                        }
                 if (vendor != "NONE" && !vendor.empty()) {
-                            tray.bed_temp    = read_int_or(nfc_slot, "BED_TEMP", 0);
+                    tray.bed_temp    = nfc_slot.value("BED_TEMP", 0);
-                            tray.nozzle_temp = read_int_or(nfc_slot, "FIRST_LAYER_TEMP", 0);
+                    tray.nozzle_temp = nfc_slot.value("FIRST_LAYER_TEMP", 0);
                 }
             }
         }
@@ -353,69 +228,8 @@ bool SnapmakerPrinterAgent::fetch_filament_info(std::string dev_id, FilamentSync
         trays.emplace_back(std::move(tray));
     }
 
-            // Resolve against GUI-owned presets on the main thread (inside build_ams_payload).
+    build_ams_payload(1, slot_count - 1, trays);
-            auto resolve_ids = [vendors](std::vector<AmsTrayData>& resolved_trays) {
-                auto* bundle = GUI::wxGetApp().preset_bundle;
-                if (!bundle) {
-                    return; // keep the generic ids computed from device data
-                }
-                for (size_t i = 0; i < resolved_trays.size() && i < vendors.size(); ++i) {
-                    AmsTrayData& tray = resolved_trays[i];
-                    if (!tray.has_filament) {
-                        continue;
-                    }
-                    // Prefer a manufacturer/colour-specific preset, else fall back to type.
-                    std::string filament_id = find_closest_color_preset_by_vendor_and_type(bundle->filaments, vendors[i], tray.tray_type,
-                                                                                           tray.tray_color);
-                    tray.tray_info_idx = filament_id.empty() ? bundle->filaments.filament_id_by_type(tray.tray_type) : filament_id;
-                }
-            };
-            build_ams_payload(1, slot_count - 1, trays, apply_inline, resolve_ids);
     return true;
-        } catch (const std::exception& e) {
-            // why: an exception escaping a detached thread is std::terminate, and firmware
-            // JSON is untrusted; mirror run_command_worker and swallow it here.
-            BOOST_LOG_TRIVIAL(error) << "SnapmakerPrinterAgent::fetch_filament_info: unhandled exception: " << e.what();
-            return false;
-        } catch (...) {
-            BOOST_LOG_TRIVIAL(error) << "SnapmakerPrinterAgent::fetch_filament_info: unhandled exception";
-            return false;
-        }
-    };
-
-    if (sync_mode == FilamentSyncMode::pull) {
-        return work(/*apply_inline=*/true);
-    }
-
-    // Subscription: fire-and-forget. A `true` return means the refresh was scheduled (or is
-    // already running), not that DevFilaSystem has been updated. Reserve under the same mutex
-    // shutdown() uses, so the flag and the count can't race.
-    {
-        std::lock_guard<std::mutex> lock(fetch_lifecycle_mutex);
-        if (shutting_down.load())
-            return false;
-        if (filament_fetch_in_flight.load() > 0)
-            return true; // a fetch is already running; don't pile on
-        filament_fetch_in_flight.fetch_add(1, std::memory_order_relaxed);
-    }
-
-    InFlightGuard guard{*this};
-    std::thread([work = std::move(work), guard = std::move(guard)]() mutable {
-        work(/*apply_inline=*/false);
-    }).detach();
-    return true;
-}
-
-std::string SnapmakerPrinterAgent::get_camera_url() const
-{
-    return join_url(get_connection_settings().base_url, "/server/files/camera/monitor.jpg");
-}
-
-FilamentSyncMode SnapmakerPrinterAgent::get_filament_sync_mode() const
-{
-    if (GUI::wxGetApp().app_config->get_bool("use_printer_agents"))
-        return FilamentSyncMode::subscription;
-    return FilamentSyncMode::pull;
 }
 
 } // namespace Slic3r

src/slic3r/Utils/SnapmakerPrinterAgent.hpp

@@ -3,8 +3,6 @@
 #include "IPrinterAgent.hpp"
 #include "MoonrakerPrinterAgent.hpp"
 
-#include <atomic>
-#include <cstdint>
 #include <string>
 
 namespace Slic3r {
@@ -13,25 +11,16 @@ class SnapmakerPrinterAgent final : public MoonrakerPrinterAgent
 {
 public:
     explicit SnapmakerPrinterAgent(std::string log_dir);
-    ~SnapmakerPrinterAgent() override { shutdown(); }
+    ~SnapmakerPrinterAgent() override = default;
 
     static AgentInfo get_agent_info_static();
     AgentInfo        get_agent_info() override { return get_agent_info_static(); }
 
     bool fetch_filament_info(std::string dev_id, FilamentSyncMode sync_mode = FilamentSyncMode::pull) override;
-    FilamentSyncMode get_filament_sync_mode() const override;
-    int command_start_camera(std::string dev_id) override;
-    CameraStreamMode get_camera_stream_mode() const override { return CameraStreamMode::http_snapshot; }
-    std::string get_camera_url() const override;
 
 private:
     // Combine filament_type + filament_sub_type into a unified type string
     static std::string combine_filament_type(const std::string& type, const std::string& sub_type);
-
-    void start_camera_monitor();
-    void on_status_loop_tick(const std::string& dev_id) override;
-
-    std::atomic<int64_t> m_camera_last_fire_ms{0};
 };
 
 } // namespace Slic3r

src/slic3r/plugin/PythonInterpreter.cpp

@@ -584,6 +584,19 @@ bool PythonInterpreter::initialize()
         }
         BOOST_LOG_TRIVIAL(debug) << "Program name set successfully";
 
+        // Keep bytecode out of the Python home. The shipped .pyc files are stale against their
+        // sources, so a writable install would rewrite them inside the app (breaking a signed
+        // macOS bundle's seal) and a read-only one would recompile them on every launch.
+        const std::string pycache_prefix = data_dir() + "/python/pycache";
+#ifdef _WIN32
+        status = PyConfig_SetString(&config, &config.pycache_prefix, boost::nowide::widen(pycache_prefix).c_str());
+#else
+        status = PyConfig_SetBytesString(&config, &config.pycache_prefix, pycache_prefix.c_str());
+#endif
+        if (PyStatus_Exception(status))
+            BOOST_LOG_TRIVIAL(warning) << "Failed to set the Python bytecode cache to " << pycache_prefix << ": "
+                                       << (status.err_msg ? status.err_msg : "unknown error");
+
         // Use pybind11's scoped_interpreter which properly initializes
         // pybind11 internals for multi-threaded use — raw Py_InitializeFromConfig
         // does not set up thread state tracking that pybind11 requires.

tests/fff_print/test_cooling.cpp

@@ -1,6 +1,7 @@
 #include <catch2/catch_all.hpp>
 
 #include <catch2/catch_test_macros.hpp>
+#include <catch2/catch_message.hpp>
 #include "test_helpers.hpp"
 
 #include <algorithm>
@@ -17,15 +18,48 @@
 using namespace Slic3r;
 using namespace Slic3r::Test;
 
-// The fan is held off for the first close_fan_the_first_x_layers layers, so an explicit
+// The fan stays off while printing the first close_fan_the_first_x_layers layers and runs afterwards.
-// fan-off command is emitted.
 TEST_CASE("Fan is held off for the initial layers", "[Cooling]")
 {
+    const int fan_off_layers = 5;
     const std::string gcode = slice({ cube(20) }, {
-        { "cooling",                      true },
+        { "close_fan_the_first_x_layers", fan_off_layers },
-        { "close_fan_the_first_x_layers", 5 },
+        { "full_fan_speed_layer",         0 },
+        { "fan_min_speed",                50 },
+        { "fan_max_speed",                100 },
+        { "fan_cooling_layer_time",       1000 }, // every layer is short enough to run the fan
+        { "layer_height",                 0.2 },
+        { "initial_layer_print_height",   0.2 },
     });
-    CHECK(gcode.find("M106 S0") != std::string::npos);
+
+    // Record, for each layer, whether any extrusion was printed with the part fan running.
+    std::vector<bool> extruded_with_fan;
+    int  layer    = -1;
+    bool fan_on   = false;
+    std::istringstream input(gcode);
+    std::string line;
+    while (std::getline(input, line)) {
+        if (line.rfind(";LAYER_CHANGE", 0) == 0) {
+            ++layer;
+            extruded_with_fan.push_back(false);
+        } else if (line.rfind("M107", 0) == 0) {
+            fan_on = false;
+        } else if (line.rfind("M106 ", 0) == 0 && line.find(" P") == std::string::npos) {
+            const size_t s = line.find(" S");
+            fan_on = s != std::string::npos && std::stod(line.substr(s + 2)) > 0.;
+        } else if (layer >= 0 && fan_on && line.rfind("G1 ", 0) == 0 && line.find(" E") != std::string::npos &&
+                   (line.find(" X") != std::string::npos || line.find(" Y") != std::string::npos)) {
+            extruded_with_fan[layer] = true;
+        }
+    }
+
+    // A 20 mm cube at 0.2 mm layers has 100 layers.
+    REQUIRE(extruded_with_fan.size() == 100);
+    for (int i = 0; i < fan_off_layers; ++i) {
+        CAPTURE(i);
+        CHECK_FALSE(extruded_with_fan[i]);
+    }
+    CHECK(extruded_with_fan[fan_off_layers]);
 }
 
 // The cooling pass resolves and strips its internal speed placeholders; none leak into

tests/fff_print/test_fill.cpp

@@ -86,10 +86,9 @@ TEST_CASE("Pattern path length", "[Fill]") {
             Slic3r::Polylines paths = test(Slic3r::ExPolygon(test_set));
             REQUIRE(paths.size() == 1); // one continuous path
 
-            // TODO: determine what the "Expected length" should be for rectilinear fill of a 100x100 polygon. 
+            // Lines are 50 mm apart and the square is inset by half a spacing, so the lines on its edges drop out
-            // This check only checks that it's above scale(3*100 + 2*50) + scaled_epsilon.
+            // and a single line crosses the middle, ending within half a spacing of the edges.
-            // ok abs($paths->[0]->length - scale(3*100 + 2*50)) - scaled_epsilon, 'path has expected length';
+            CHECK_THAT(unscale<double>(paths[0].length()), Catch::Matchers::WithinAbs(100., filler->spacing / 2.));
-            REQUIRE(std::abs(paths[0].length() - static_cast<double>(scale_(3*100 + 2*50))) - SCALED_EPSILON > 0); // path has expected length
 
             test_set.clear();
         }
@@ -148,10 +147,9 @@ TEST_CASE("Pattern path length", "[Fill]") {
         Slic3r::Polylines paths = test(Slic3r::ExPolygon(points));
         REQUIRE(paths.size() == 1); // one continuous path
 
-        // TODO: determine what the "Expected length" should be for rectilinear fill of a 100x100 polygon. 
+        // A solid fill covers the area with lines one spacing apart, so a missing segment shortens the path.
-        // This check only checks that it's above scale(3*100 + 2*50) + scaled_epsilon.
+        const double expected_length = unscale<double>(unscale<double>(Slic3r::ExPolygon(points).area())) / filler->spacing;
-        // ok abs($paths->[0]->length - scale(3*100 + 2*50)) - scaled_epsilon, 'path has expected length';
+        CHECK_THAT(unscale<double>(paths[0].length()), Catch::Matchers::WithinRel(expected_length, 0.01));
-        REQUIRE(std::abs(paths[0].length() - static_cast<double>(scale_(3*100 + 2*50))) - SCALED_EPSILON > 0); // path has expected length
     }
 
     SECTION("Rotated Square") {
@@ -168,8 +166,9 @@ TEST_CASE("Pattern path length", "[Fill]") {
 		fill_params.density = 1.0;
 		filler->spacing = flow.spacing();
 
-        for (auto angle : { 0.0, 45.0}) {
+        for (auto angle : { 0.0, PI / 4.0 }) {
             surface.expolygon.rotate(angle, Point(0,0));
+            filler->bounding_box = get_extents(surface.expolygon.contour);
             Polylines paths = filler->fill_surface(&surface, fill_params);
             REQUIRE(paths.size() == 1);
         }
@@ -222,7 +221,7 @@ TEST_CASE("Pattern path length", "[Fill]") {
         };
         Slic3r::ExPolygon expolygon(points);
          
-        REQUIRE(test_if_solid_surface_filled(expolygon, 0.5, 45.0, 0.99) == true);
+        REQUIRE(test_if_solid_surface_filled(expolygon, 0.5, PI / 4.0, 0.99) == true);
     }
 }
 

tests/fff_print/test_print.cpp

@@ -123,38 +123,58 @@ SCENARIO("Changing the number of solid shell layers does not make all surfaces i
 		config.set_deserialize_strict({
             { "top_shell_layers",           2 },
             { "bottom_shell_layers",        1 },
-            { "layer_height",               0.25 }, // get a known number of layers
+            // Shell counts alone decide which layers are solid.
+            { "top_shell_thickness",        0 },
+            { "bottom_shell_thickness",     0 },
+            { "sparse_infill_density",      "20%" },
+            { "layer_height",               0.25 }, // 80 layers: 0..79
             { "initial_layer_print_height", 0.25 }
 			});
         Slic3r::Print print;
         Slic3r::Model model;
         Slic3r::Test::init_print({cube(20)}, print, model, config);
-        // Precondition: Ensure that the model has 2 solid top layers (79, 78)
+        // True when the layer has fill surfaces and all of them are solid.
-        // and one solid bottom layer (0).
+		auto is_solid_infill = [&print](size_t obj_id, size_t layer_id) {
-		auto test_is_solid_infill = [&print](size_t obj_id, size_t layer_id) {
 		    const Layer &layer = *(print.objects().at(obj_id)->get_layer((int)layer_id));
-		    // iterate over all of the regions in the layer
+		    bool has_fill = false;
-		    for (const LayerRegion *region : layer.regions()) {
+		    for (const LayerRegion *region : layer.regions())
-		        // for each region, iterate over the fill surfaces
+		        for (const Surface &surface : region->fill_surfaces.surfaces) {
-		        for (const Surface &surface : region->fill_surfaces.surfaces)
+		            if (! surface.is_solid())
-		            CHECK(surface.is_solid());
+		                return false;
+		            has_fill = true;
 		        }
+		    return has_fill;
+		};
+        // True when the layer has a sparse fill surface, so a layer with no fill at all does not count.
+		auto has_sparse_infill = [&print](size_t obj_id, size_t layer_id) {
+		    const Layer &layer = *(print.objects().at(obj_id)->get_layer(static_cast<int>(layer_id)));
+		    for (const LayerRegion *region : layer.regions())
+		        for (const Surface &surface : region->fill_surfaces.surfaces)
+		            if (! surface.is_solid())
+		                return true;
+		    return false;
 		};
         print.process();
-        test_is_solid_infill(0,  0); // should be solid
+        // Precondition: 2 solid top layers (79, 78) and one solid bottom layer (0).
-        test_is_solid_infill(0, 79); // should be solid
+        REQUIRE(is_solid_infill(0,  0));
-        test_is_solid_infill(0, 78); // should be solid
+        REQUIRE(is_solid_infill(0, 79));
+        REQUIRE(is_solid_infill(0, 78));
+        REQUIRE(has_sparse_infill(0, 77));
         WHEN("Model is re-sliced with top_shell_layers == 3") {
 			config.set("top_shell_layers", 3);
 			print.apply(model, config);
             print.process();
             THEN("Print object does not have 0 solid bottom layers.") {
-                test_is_solid_infill(0, 0);
+                CHECK(is_solid_infill(0, 0));
             }
             AND_THEN("Print object has 3 top solid layers") {
-                test_is_solid_infill(0, 79);
+                CHECK(is_solid_infill(0, 79));
-                test_is_solid_infill(0, 78);
+                CHECK(is_solid_infill(0, 78));
-                test_is_solid_infill(0, 77);
+                CHECK(is_solid_infill(0, 77));
+                CHECK(has_sparse_infill(0, 76));
+            }
+            AND_THEN("Middle layers keep sparse infill") {
+                CHECK(has_sparse_infill(0, 40));
             }
         }
     }
@@ -672,14 +692,18 @@ TEST_CASE("gcode_skip_config_block omits the resolved-settings comment block", "
 {
     const std::string gcode = slice({ cube(20) }, {
         { "gcode_skip_config_block", true },
-        { "gcode_comments",         true },
     });
     CHECK(gcode.find("; CONFIG_BLOCK_START")     == std::string::npos);
     CHECK(gcode.find("; CONFIG_BLOCK_END")       == std::string::npos);
     CHECK(gcode.find("; layer_height =")         == std::string::npos);
-    CHECK(gcode.find("; fill_density =")         == std::string::npos);
+    CHECK(gcode.find("; sparse_infill_density =") == std::string::npos);
     CHECK(gcode.find("; HEADER_BLOCK_START")     != std::string::npos);
     CHECK(gcode.find("; EXECUTABLE_BLOCK_START") != std::string::npos);
+
+    const std::string with_block = slice({ cube(20) }, { { "gcode_skip_config_block", false } });
+    CHECK(with_block.find("; CONFIG_BLOCK_START")      != std::string::npos);
+    CHECK(with_block.find("; layer_height =")          != std::string::npos);
+    CHECK(with_block.find("; sparse_infill_density =") != std::string::npos);
 }
 
 // Some firmwares only scan the last N lines of the file for "estimated printing time", so it

tests/fff_print/test_trianglemesh.cpp

@@ -1,6 +1,8 @@
 #include <catch2/catch_all.hpp>
 
 #include <catch2/catch_test_macros.hpp>
+#include <catch2/matchers/catch_matchers_floating_point.hpp>
+#include <catch2/matchers/catch_matchers.hpp>
 #include "libslic3r/TriangleMesh.hpp"
 #include "libslic3r/TriangleMeshSlicer.hpp"
 #include "libslic3r/Point.hpp"
@@ -162,21 +164,29 @@ SCENARIO("Slice behavior", "[TriangleMesh]") {
         const std::vector<Vec3f> vertices {{0,0,0},{0,0,20},{0,5,0},{0,5,20},{50,0,0},{50,0,20},{15,5,0},{35,5,0},{15,20,0},{50,5,0},{35,20,0},{15,5,10},{50,5,20},{35,5,10},{35,20,10},{15,20,10}};
         const std::vector<Vec3i32> facets {{0,1,2},{2,1,3},{1,0,4},{5,1,4},{0,2,4},{4,2,6},{7,6,8},{4,6,7},{9,4,7},{7,8,10},{2,3,6},{11,3,12},{7,12,9},{13,12,7},{6,3,11},{11,12,13},{3,1,5},{12,3,5},{5,4,9},{12,5,9},{13,7,10},{14,13,10},{8,15,10},{10,15,14},{6,11,8},{8,11,15},{15,11,13},{14,15,13}};
 
-		auto cube = make_cube();
+		TriangleMesh mesh(vertices, facets);
+        // A 50x5x20 wall with a 20x15x10 block against it, so the block's top is at Z = 10.
+        const double wall_area       = 50. * 5.;
+        const double wall_block_area = wall_area + 20. * 15.;
+        const auto area_mm2 = [](const ExPolygons &slice) { return slice.at(0).area() * SCALING_FACTOR * SCALING_FACTOR; };
         WHEN(" a top tangent plane is sliced") {
-            // At Z = 10 we have a top horizontal surface.
+			std::vector<ExPolygons> slices = mesh.slice({5.0, 10.0});
-			std::vector<ExPolygons> slices = cube.slice({5.0, 10.0});
             THEN( "its area is included") {
-                REQUIRE(slices.at(0).at(0).area() > 0);
+                REQUIRE(slices.at(0).size() == 1);
-                REQUIRE(slices.at(1).at(0).area() > 0);
+                REQUIRE(slices.at(1).size() == 1);
+                CHECK_THAT(area_mm2(slices.at(0)), Catch::Matchers::WithinRel(wall_block_area, 1e-6));
+                CHECK_THAT(area_mm2(slices.at(1)), Catch::Matchers::WithinRel(wall_block_area, 1e-6));
             }
         }
         WHEN(" a model that has been transformed is sliced") {
-            cube.mirror_z();
+            mesh.mirror_z();
-			std::vector<ExPolygons> slices = cube.slice({-5.0, -10.0});
+			std::vector<ExPolygons> slices = mesh.slice({-5.0, -10.0});
-            THEN( "it is sliced properly (mirrored bottom plane area is included)") {
+            THEN( "it is sliced like the original, and the mirrored block's bottom plane is not part of it") {
-                REQUIRE(slices.at(0).at(0).area() > 0);
+                REQUIRE(slices.at(0).size() == 1);
-                REQUIRE(slices.at(1).at(0).area() > 0);
+                REQUIRE(slices.at(1).size() == 1);
+                CHECK_THAT(area_mm2(slices.at(0)), Catch::Matchers::WithinRel(wall_block_area, 1e-6));
+                // A triangle owns its top edge but not its bottom edge, so a bottom tangent plane is left out.
+                CHECK_THAT(area_mm2(slices.at(1)), Catch::Matchers::WithinRel(wall_area, 1e-6));
             }
         }
     }

tests/filament_group/filament_group_regression_main.cpp

@@ -319,9 +319,18 @@ TEST_CASE("FilamentGroup property checks", "[filament_group][property]") {
         // build (config_b/config_c cases evaluate the full per-layer nozzle-aware reorder for every
         // candidate grouping; this is a guard against hangs, not a micro-perf gate).
         REQUIRE(result.elapsed_ms < 40000.0);
-        REQUIRE(result.flush_cost >= 0);
 
+        // Every case, feasible or not, must yield a usable grouping: each used filament is
+        // assigned to an existing nozzle.
         auto used_filaments = collect_sorted_used_filaments(tc.context.model_info.layer_filaments);
+        const auto &nozzle_list = tc.context.nozzle_info.nozzle_list;
+        for (unsigned int fil : used_filaments) {
+            INFO("Filament: " << fil);
+            REQUIRE(fil < result.filament_map.size());
+            CHECK(result.filament_map[fil] >= 0);
+            CHECK(result.filament_map[fil] < static_cast<int>(nozzle_list.size()));
+        }
+
         if (is_constraint_feasible(tc.context, used_filaments)) {
             if (!result.constraints_ok) {
                 for (auto& v : result.violations)

tests/libslic3r/test_3mf.cpp

@@ -1033,29 +1033,52 @@ SCENARIO("Non-standard nozzle diameter survives .3mf save on a single-nozzle pri
     }
 }
 
-// A legacy / foreign project (no multi-nozzle metadata) must load crash-safe through the BBS
+// A project without multi-nozzle metadata must load through the BBS importer and must not
-// importer and must not fabricate a filament_volume_map.
+// fabricate a filament_volume_map.
-SCENARIO("Legacy project loads crash-safe via load_bbs_3mf", "[3mf][MultiNozzle]") {
+SCENARIO("Projects without multi-nozzle metadata load without a per-filament volume map", "[3mf][MultiNozzle]") {
-    GIVEN("a project without any multi-nozzle metadata") {
-        std::string path = std::string(TEST_DATA_DIR) + "/test_3mf/Geräte/Büchse.3mf";
-        Model                model;
-        DynamicPrintConfig   config;
     ConfigSubstitutionContext ctxt{ ForwardCompatibilitySubstitutionRule::Enable };
-        PlateDataPtrs        plates;
     std::vector<Preset*>      project_presets;
     bool   is_bbl_3mf = false, is_orca_3mf = false;
     Semver file_version;
 
+    GIVEN("a legacy project with a bare model and no plate metadata") {
+        std::string        path = std::string(TEST_DATA_DIR) + "/test_3mf/Geräte/Büchse.3mf";
+        Model              model;
+        DynamicPrintConfig config;
+        PlateDataPtrs      plates;
+
         WHEN("loaded through the BBS importer") {
             bool loaded = false;
             REQUIRE_NOTHROW(loaded = load_bbs_3mf(path.c_str(), &config, &ctxt, &model, &plates,
                                                   &project_presets, &is_bbl_3mf, &is_orca_3mf,
                                                   &file_version, nullptr,
                                                   LoadStrategy::LoadModel | LoadStrategy::LoadConfig));
-            THEN("it does not crash and invents no per-filament volume map") {
+            THEN("the model loads") {
-                for (PlateData* p : plates) {
+                REQUIRE(loaded);
-                    REQUIRE(p->config.option<ConfigOptionInts>("filament_volume_map") == nullptr);
+                REQUIRE_FALSE(model.objects.empty());
             }
+            release_PlateData_list(plates);
+        }
+    }
+
+    GIVEN("a project with plate metadata but no filament volume map") {
+        ScopedTemporaryFile temp(".3mf");
+        store_painted_cube(temp.string());
+        ScopedTemporaryDir backup_dir("orca_volume_map_dst");
+        Model              model;
+        model.set_backup_path(backup_dir.string());
+        DynamicPrintConfig config;
+        PlateDataPtrs      plates;
+
+        WHEN("loaded through the BBS importer") {
+            const bool loaded = load_bbs_3mf(temp.string().c_str(), &config, &ctxt, &model, &plates,
+                                             &project_presets, &is_bbl_3mf, &is_orca_3mf, &file_version,
+                                             nullptr, LoadStrategy::LoadModel | LoadStrategy::LoadConfig);
+            THEN("every plate loads without a per-filament volume map") {
+                REQUIRE(loaded);
+                REQUIRE_FALSE(plates.empty());
+                for (PlateData* p : plates)
+                    CHECK(p->config.option<ConfigOptionInts>("filament_volume_map") == nullptr);
             }
             release_PlateData_list(plates);
         }
@@ -2026,8 +2049,8 @@ SCENARIO("Published 3MF round-trips the extended material metadata", "[3mf]") {
                 REQUIRE(dst_model.model_info != nullptr);
                 REQUIRE(dst_model.model_info->metadata_items[ORCA_PUBLISHED_MATERIAL_TAG] == material_keys_json);
 
-                // The value must parse back with every extended field intact.
+                // The loaded value must parse back with every extended field intact.
-                nlohmann::json entries = nlohmann::json::parse(material_keys_json);
+                nlohmann::json entries = nlohmann::json::parse(dst_model.model_info->metadata_items[ORCA_PUBLISHED_MATERIAL_TAG]);
                 REQUIRE(entries.is_array());
                 REQUIRE(entries.size() == 1);
                 REQUIRE(entries[0]["full"].get<bool>() == true);

tests/libslic3r/test_caddocument.cpp

@@ -44,6 +44,7 @@
 
 #include <cmath>
 #include <cstring>
+#include <boost/filesystem/path.hpp>
 #include <fstream>
 #include <memory>
 #include <set>
@@ -53,6 +54,7 @@
 #include <BRepAdaptor_Surface.hxx>
 #include <TopExp_Explorer.hxx>
 #include <TopoDS.hxx>
+#include <BRepAlgoAPI_Common.hxx>
 #include <BRepGProp.hxx>
 #include <GProp_GProps.hxx>
 #include <BRepPrimAPI_MakeBox.hxx>
@@ -772,16 +774,10 @@ TEST_CASE("entity constraints: tangent/midpoint/symmetric/angle", "[CadDocument]
 
 TEST_CASE("imported text glyphs all extrude without failing (charset sweep)", "[CadDocument]")
 {
-    std::string font = resources_dir().empty()
+    // The bundled font, from the source tree: PROFILES_DIR is <repo>/resources/profiles.
-        ? std::string("resources/fonts/HarmonyOS_Sans_SC_Regular.ttf")
+    const std::string font =
-        : resources_dir() + "/fonts/HarmonyOS_Sans_SC_Regular.ttf";
+        (boost::filesystem::path(PROFILES_DIR).parent_path() / "fonts" / "HarmonyOS_Sans_SC_Regular.ttf").string();
-    {
+    REQUIRE(std::ifstream(font).good());
-        std::ifstream probe(font);
-        if (!probe.good()) {
-            SUCCEED("bundled font not reachable in this environment; covered live on :10");
-            return;
-        }
-    }
 
     const std::string charset =
         "ABCDEFGHIJKLMNOPQRSTUVWXYZ"
@@ -2853,9 +2849,10 @@ TEST_CASE("datum coordinate system: non-perpendicular inputs produce orthonormal
     using Catch::Matchers::WithinAbs;
 
     CadDocument doc;
-    // Build a body so we have a face to reference for FaceAndDirection.
+    // A cylinder's end cap is bounded by one closed circular edge, which offers no in-plane
-    int sk = doc.add_sketch(SketchShape::Rectangle, SketchPlane::XY(), 20, 20, 10, "Box");
+    // direction, so the frame has to fall back on coordsys_x_hint.
-    doc.add_extrude(sk, 10.0, false, BooleanMode::New, "BoxExt");
+    int sk = doc.add_sketch(SketchShape::Circle, SketchPlane::XY(), 0, 0, 5.0, "Circle");
+    doc.add_extrude(sk, 10.0, false, BooleanMode::New, "Cyl");
     REQUIRE(doc.recompute());
     REQUIRE(doc.bodies.size() == 1);
     int n_faces = GeometryEngine::face_count(doc.bodies[0].shape);
@@ -2865,34 +2862,33 @@ TEST_CASE("datum coordinate system: non-perpendicular inputs produce orthonormal
         if (fn.z() > 0.9) { top_face = i; break; }
     }
     REQUIRE(top_face >= 0);
+    const Vec3d Z = GeometryEngine::face_normal_world(GeometryEngine::face_by_index(doc.bodies[0].shape, top_face));
 
     int cs = doc.add_coordsys(CoordSysType::PointWorld, Vec3d(0, 0, 0), "CS1");
     REQUIRE(cs >= 0);
     doc.features[cs].coordsys_type   = CoordSysType::FaceAndDirection;
     doc.features[cs].coordsys_body   = 0;
     doc.features[cs].coordsys_face   = top_face;
-    // Deliberately non-perpendicular X hint (NOT orthogonal to face normal ~+Z).
+    // Deliberately non-perpendicular X hint (NOT orthogonal to the face normal +Z).
     doc.features[cs].coordsys_x_hint = Vec3d(3.0, -1.0, 0.5);
 
     auto css = doc.resolve_datum_coordsys();
     REQUIRE(css.size() == 1);
     REQUIRE(css[0].error.empty());
 
-    Vec3d X = css[0].x, Y = css[0].y;
+    const Vec3d X = css[0].x, Y = css[0].y;
-    // Orthonormality: each axis has unit length
+    // X is the hint projected into the face plane.
+    const Vec3d expected_x = Vec3d(3.0, -1.0, 0.0).normalized();
+    CHECK_THAT(X.x(), WithinAbs(expected_x.x(), 1e-9));
+    CHECK_THAT(X.y(), WithinAbs(expected_x.y(), 1e-9));
+    CHECK_THAT(X.z(), WithinAbs(expected_x.z(), 1e-9));
+    // Orthonormal, with Z the face normal and the frame right-handed.
     CHECK_THAT(X.norm(), WithinAbs(1.0, 1e-9));
     CHECK_THAT(Y.norm(), WithinAbs(1.0, 1e-9));
-    // Pairwise dot products are ~0
+    CHECK_THAT(X.dot(Y), WithinAbs(0.0, 1e-9));
-    CHECK_THAT(std::abs(X.dot(Y)), WithinAbs(0.0, 1e-9));
+    CHECK_THAT(X.dot(Z), WithinAbs(0.0, 1e-9));
-    // Z = X x Y (derived), also unit and perpendicular
+    CHECK_THAT(Y.dot(Z), WithinAbs(0.0, 1e-9));
-    Vec3d Z = X.cross(Y);
+    CHECK_THAT(X.cross(Y).dot(Z), WithinAbs(1.0, 1e-9));
-    CHECK_THAT(Z.norm(), WithinAbs(1.0, 1e-9));
-    CHECK_THAT(std::abs(X.dot(Z)), WithinAbs(0.0, 1e-9));
-    CHECK_THAT(std::abs(Y.dot(Z)), WithinAbs(0.0, 1e-9));
-    // Right-handedness: X x Y == Z
-    CHECK_THAT(Z.x(), WithinAbs((X.cross(Y)).x(), 1e-9));
-    CHECK_THAT(Z.y(), WithinAbs((X.cross(Y)).y(), 1e-9));
-    CHECK_THAT(Z.z(), WithinAbs((X.cross(Y)).z(), 1e-9));
 }
 
 TEST_CASE("datum coordinate system: a face-only frame rotates with its body", "[CadDocument]")
@@ -3917,17 +3913,23 @@ TEST_CASE("Use/Convert Entities: construction references never become solid", "[
     }
     REQUIRE(top_face >= 0);
 
-    const size_t body_count_before = doc.bodies.size();
-    const double volume_before     = doc.body_mass_properties(0).volume;
-
     int target   = doc.add_sketch_entities({}, SketchPlane::XY(), "Use");
     int appended = doc.project_edges_into_sketch(target, 0, {}, top_face);
     REQUIRE(appended == 4);
+    doc.add_extrude(target, 5.0, false, BooleanMode::New, "UseExt");
 
+    SECTION("construction edges form no profile, so the extrude fails") {
+        REQUIRE_FALSE(doc.recompute());
+        REQUIRE_FALSE(doc.error.empty());
+    }
+    SECTION("the same edges as solid geometry extrude a 20x20x5 body") {
+        for (auto& e : doc.features[target].entities)
+            e.construction = false;
         REQUIRE(doc.recompute());
         REQUIRE(doc.error.empty());
-    REQUIRE(doc.bodies.size() == body_count_before);
+        REQUIRE(doc.bodies.size() == 2);
-    REQUIRE_THAT(doc.body_mass_properties(0).volume, WithinRel(volume_before, 1e-9));
+        REQUIRE_THAT(doc.body_mass_properties(1).volume, WithinRel(20.0 * 20.0 * 5.0, 1e-6));
+    }
 }
 
 TEST_CASE("Use/Convert Entities: bad references return -1 and change nothing", "[CadDocument][project]")
@@ -4252,7 +4254,7 @@ TEST_CASE("a previous-format recipe is refused, not silently misread", "[CadDocu
     REQUIRE(doc.features.empty());   // nothing half-read was left behind
 }
 
-TEST_CASE("golden recipe v1 still deserialises", "[CadDocument]")
+TEST_CASE("a v4 recipe keeps every field value", "[CadDocument]")
 {
     using Catch::Matchers::WithinRel;
     using Catch::Matchers::WithinAbs;
@@ -4282,20 +4284,16 @@ TEST_CASE("golden recipe v1 still deserialises", "[CadDocument]")
     }
 
     CadDocument expected = make_golden_doc_v1();
-    // Scoped tightly: this advice is ONLY valid for a count mismatch. It must not be in
-    // scope for the field-value assertions below, where "regenerate the fixture" is the
-    // one thing you must never do -- regenerating after a reorder bakes the corrupted
-    // layout in as the new golden and permanently disarms this test.
     {
-        INFO("Feature count changed - did you add/remove features in make_golden_doc_v1()?");
+        INFO("Feature count changed - make_golden_doc_v1() must keep building exactly the tree "
-        INFO("If so: run libslic3r_tests \"[.regen]\" and re-run this test.");
+             "frozen in cad_recipe_v4.bin, so do not add or remove features there.");
         REQUIRE(features.size() == expected.features.size());
     }
 
     // A failure BELOW this point means the on-disk serialization format changed: some field
     // in CadFeature::save/load was reordered, retyped, or removed. Fields may only ever be
     // APPENDED at the end of both lists. Do NOT regenerate the fixture to make this pass --
-    // fix the field order instead. See scripts/CAD/run-kernel-tests.sh and the [.regen] case.
+    // fix the field order instead.
 
     // Field-by-field assertions against expected values.
     // Every field set to a distinctive non-default literal must be checked here.
@@ -4550,34 +4548,48 @@ TEST_CASE("golden recipe v1 still deserialises", "[CadDocument]")
         }
     }
 
-    // --- Layer 2: geometry check (optional — only if the document recomputes) ---
+    // --- Layer 2: the production v4 load rebuilds the same geometry as the in-memory tree ---
-    // Build expected document and try to recompute it.
+    // The golden tree is serialization coverage and does not recompute as a whole: these
-    // ponytail: the field-value layer above is the real tripwire;
+    // features fail on the geometry they get, so they are left off in both trees.
-    // this layer is a bonus sanity check on the full recompute path.
+    const std::set<std::string> unbuildable{"Fillet_Lat35", "Chamfer_Top2", "Draft_F3", "Shell_T1375",
+                                            "GoldenProject"};
     CadDocument exp_doc = make_golden_doc_v1();
-    bool exp_ok = exp_doc.recompute();
+    // Fields appended after v4 are not in the file, so a v4 project reads them as defaults
-    if (!exp_ok) {
+    // (a v4 thread, for one, is not major-nominal). The reference has to match that.
-        INFO("Expected document from make_golden_doc_v1() could not recompute "
+    const CadFeature def;
-             "(complex feature tree). Field-value checks above are sufficient.");
+    for (CadFeature& f : exp_doc.features) {
+        f.thread_major_nominal = def.thread_major_nominal;
+        f.pattern_inclusive    = def.pattern_inclusive;
+        f.dressup_edges        = def.dressup_edges;
+        f.text_string          = def.text_string;
+        f.text_font            = def.text_font;
+        f.text_height          = def.text_height;
+        f.revolve_axis_entity  = def.revolve_axis_entity;
     }
-
     CadDocument doc;
-    bool ser_ok = doc.deserialize_recipe(blob);
+    doc.deserialize_recipe(blob);
-
+    REQUIRE(doc.features.size() == exp_doc.features.size());
-    if (exp_ok && ser_ok) {
+    for (size_t i = 0; i < exp_doc.features.size(); ++i)
-        REQUIRE(doc.error.empty());
+        exp_doc.features[i].enabled = doc.features[i].enabled = unbuildable.count(exp_doc.features[i].name) == 0;
+    const bool exp_built = exp_doc.recompute();
+    INFO("reference error: " << exp_doc.error);
+    REQUIRE(exp_built);
+    const bool built = doc.recompute();
+    INFO("loaded error: " << doc.error);
+    REQUIRE(built);
+    REQUIRE_FALSE(exp_doc.bodies.empty());
     REQUIRE(doc.bodies.size() == exp_doc.bodies.size());
-        for (size_t i = 0; i < doc.bodies.size(); ++i) {
+    for (size_t b = 0; b < doc.bodies.size(); ++b) {
-            double v = double(SketchEngine::tessellate(doc.bodies[i].shape).volume());
+        INFO("body " << b);
-            double ev = double(SketchEngine::tessellate(exp_doc.bodies[i].shape).volume());
+        TriangleMesh mesh     = SketchEngine::tessellate(doc.bodies[b].shape);
-            REQUIRE_THAT(v, WithinRel(ev, 1e-6));
+        TriangleMesh exp_mesh = SketchEngine::tessellate(exp_doc.bodies[b].shape);
+        CHECK_THAT(double(mesh.volume()), WithinRel(double(exp_mesh.volume()), 1e-6));
+        // Volume alone is blind to fields that only place a body, such as a transform.
+        const BoundingBoxf3 bb = mesh.bounding_box(), exp_bb = exp_mesh.bounding_box();
+        for (int k = 0; k < 3; ++k) {
+            CHECK_THAT(bb.min[k], WithinAbs(exp_bb.min[k], 1e-6));
+            CHECK_THAT(bb.max[k], WithinAbs(exp_bb.max[k], 1e-6));
         }
-    } else {
-        INFO("The golden recipe fixture was loaded and field-value checks passed.");
-        INFO("Recompute on the deserialized or expected document failed — this is");
-        INFO("expected for the extended golden fixture (many feature types coexist");
-        INFO("purely for serialization coverage). The field-value tripwire above is");
-        INFO("the primary format check.");
     }
 }
 
@@ -5781,8 +5793,9 @@ TEST_CASE("fastened mate with angle", "[CadDocument][mate]")
     REQUIRE(doc.recompute());
     REQUIRE(doc.error.empty());
 
-    int sk2 = doc.add_sketch(SketchShape::Circle, SketchPlane::XY(), 0, 0, 3, "Cyl");
+    // A 20x10 plate, so a quarter turn about the connector's Z swaps its X and Y extents.
-    doc.add_extrude(sk2, 10.0, false, BooleanMode::New, "CylExt");
+    int sk2 = doc.add_sketch(SketchShape::Rectangle, SketchPlane::XY(), 20, 10, 0, "Plate");
+    doc.add_extrude(sk2, 10.0, false, BooleanMode::New, "PlateExt");
     REQUIRE(doc.recompute());
     REQUIRE(doc.error.empty());
 
@@ -5801,6 +5814,13 @@ TEST_CASE("fastened mate with angle", "[CadDocument][mate]")
     gp_Pnt com = props.CentreOfMass();
     REQUIRE_THAT(double(com.X()), WithinAbs(5.0, 1e-4));
     REQUIRE_THAT(double(com.Y()), WithinAbs(5.0, 1e-4));
+
+    Bnd_Box bb;
+    BRepBndLib::Add(doc.bodies[1].shape, bb);
+    double x0, y0, z0, x1, y1, z1;
+    bb.Get(x0, y0, z0, x1, y1, z1);
+    REQUIRE_THAT(x1 - x0, WithinAbs(10.0, 1e-3));
+    REQUIRE_THAT(y1 - y0, WithinAbs(20.0, 1e-3));
 }
 
 TEST_CASE("fastened mate with flip", "[CadDocument][mate]")
@@ -5823,7 +5843,9 @@ TEST_CASE("fastened mate with flip", "[CadDocument][mate]")
     REQUIRE(doc.recompute());
     REQUIRE(doc.error.empty());
 
-    int cs_moving = doc.add_coordsys(CoordSysType::PointWorld, Vec3d(0, 0, 5), "CS_Moving");
+    // The connector sits on the cylinder's base, so the flip decides which side of the
+    // fixed connector (z = 5) the 10 mm cylinder hangs: above it unflipped, below it flipped.
+    int cs_moving = doc.add_coordsys(CoordSysType::PointWorld, Vec3d(0, 0, 0), "CS_Moving");
     doc.features[cs_moving].coordsys_body = 1;
     REQUIRE(doc.recompute());
     REQUIRE(doc.error.empty());
@@ -5837,8 +5859,7 @@ TEST_CASE("fastened mate with flip", "[CadDocument][mate]")
     gp_Pnt com = props.CentreOfMass();
     REQUIRE_THAT(double(com.X()), WithinAbs(5.0, 1e-4));
     REQUIRE_THAT(double(com.Y()), WithinAbs(5.0, 1e-4));
-    // Flip opposes Z axes: for a symmetric cylinder this is invisible in centroid,
+    REQUIRE_THAT(double(com.Z()), WithinAbs(5.0 - 10.0 / 2, 1e-4));
-    // but the mate executed cleanly and the body moved to the target connector.
 }
 
 TEST_CASE("planar mate: normal distance becomes mate_offset", "[CadDocument][mate]")
@@ -6525,23 +6546,19 @@ TEST_CASE("fastened mate with flip on asymmetric body", "[CadDocument][mate]")
     REQUIRE(doc.recompute());
     REQUIRE(doc.error.empty());
 
-    // Fastened, NO flip
+    // The same assembly mated once without and once with flip, each in its own copy.
-    doc.add_mate(0, cs_fixed, cs_moving, 0.0, 0.0, false, "MateNoFlip");
+    auto mated_com_z = [&](bool flip) {
-    REQUIRE(doc.recompute());
+        CadDocument d = doc;
-    REQUIRE(doc.error.empty());
+        d.add_mate(0, cs_fixed, cs_moving, 0.0, 0.0, flip, "Mate");
-    GProp_GProps nf_props;
+        REQUIRE(d.recompute());
-    BRepGProp::VolumeProperties(doc.bodies[1].shape, nf_props);
+        REQUIRE(d.error.empty());
-    double nf_z = nf_props.CentreOfMass().Z();
+        REQUIRE(d.mate_conflicts.empty());
-
+        GProp_GProps props;
-    doc.undo();
+        BRepGProp::VolumeProperties(d.bodies[1].shape, props);
-
+        return props.CentreOfMass().Z();
-    // Fastened, WITH flip
+    };
-    doc.add_mate(0, cs_fixed, cs_moving, 0.0, 0.0, true, "MateFlip");
+    const double nf_z = mated_com_z(false);
-    REQUIRE(doc.recompute());
+    const double f_z  = mated_com_z(true);
-    REQUIRE(doc.error.empty());
-    GProp_GProps f_props;
-    BRepGProp::VolumeProperties(doc.bodies[1].shape, f_props);
-    double f_z = f_props.CentreOfMass().Z();
 
     // Flip changes the centroid Z for an asymmetric body
     REQUIRE_THAT(f_z, !WithinAbs(nf_z, 1e-4));
@@ -7324,13 +7341,22 @@ TEST_CASE("interference: sheet bodies are skipped", "[CadDocument][interference]
     CadDocument doc;
     int sk_a = doc.add_sketch(SketchShape::Rectangle, SketchPlane::XY(), 20, 20, 0, "BoxA");
     doc.add_extrude(sk_a, 10.0, false, BooleanMode::New, "EA");
-    // A sheet passing straight through the solid: it has no volume, so no interference.
+    // Four 10x5 walls standing inside the 20x20x10 solid: a sheet has no volume, so no interference.
-    int sk_s = doc.add_sketch(SketchShape::Rectangle, SketchPlane::XY(), 40, 40, 0, "Sheet");
+    int sk_s = doc.add_sketch(SketchShape::Rectangle, SketchPlane::XY(), 10, 10, 0, "Sheet");
     doc.add_surface_extrude(sk_s, 5.0, "SE");
     REQUIRE(doc.recompute());
     REQUIRE(doc.bodies.size() == 2);
     REQUIRE(CadDocument::is_sheet_shape(doc.bodies[1].shape));
 
+    // The raw overlap of the walls with the solid does measure a volume, so only the sheet
+    // skip keeps it out of the report.
+    BRepAlgoAPI_Common common(doc.bodies[0].shape, doc.bodies[1].shape);
+    common.Build();
+    REQUIRE(common.IsDone());
+    GProp_GProps props;
+    BRepGProp::VolumeProperties(common.Shape(), props);
+    REQUIRE(std::abs(props.Mass()) > 1e-6);
+
     REQUIRE(doc.check_interference().empty());
 }
 
@@ -7540,9 +7566,8 @@ TEST_CASE("A cut that removes no material is an error, not a silent success", "[
         CHECK(doc.error.find("removed no material") != std::string::npos);
 
         // And the body is left as it was, not half-applied.
-        CadDocument again = box();
+        REQUIRE(doc.bodies.size() == 1);
-        REQUIRE(again.recompute());
+        CHECK_THAT(doc.body_mass_properties(0).volume,
-        CHECK_THAT(again.body_mass_properties(0).volume,
                    Catch::Matchers::WithinAbs(solid, 1e-6));
     }
 

tests/libslic3r/test_config.cpp

@@ -75,11 +75,10 @@ SCENARIO("Config accessor functions perform as expected.", "[Config]") {
             }
         }
         WHEN("A boolean option is set to a string value representing something other than 0 or 1") {
-            THEN("A BadOptionTypeException exception is thrown.") {
+            config.set("gcode_comments", true);
+            THEN("A BadOptionTypeException exception is thrown and the value is unchanged.") {
                 REQUIRE_THROWS_AS(config.set("gcode_comments", "Z"), BadOptionTypeException);
-            }
+                REQUIRE(config.opt<ConfigOptionBool>("gcode_comments")->getBool() == true);
-            AND_THEN("Value is unchanged.") {
-                REQUIRE(config.opt<ConfigOptionBool>("gcode_comments")->getBool() == false);
             }
         }
         WHEN("A boolean option is set to an int value") {
@@ -117,12 +116,10 @@ SCENARIO("Config accessor functions perform as expected.", "[Config]") {
             }
         }
         WHEN("A numeric option is set to a non-numeric value.") {
-	    auto prev_value = config.opt<ConfigOptionFloat>("max_bridge_length")->getFloat();
+            config.set("max_bridge_length", 7.5);
-            THEN("A BadOptionTypeException exception is thrown.") {
+            THEN("A BadOptionValueException exception is thrown and the value does not change.") {
                 REQUIRE_THROWS_AS(config.set_deserialize_strict("max_bridge_length", "zzzz"), BadOptionValueException);
-            }
+                REQUIRE_THAT(config.opt<ConfigOptionFloat>("max_bridge_length")->getFloat(), Catch::Matchers::WithinAbs(7.5, 1e-9));
-            THEN("The value does not change.") {
-                REQUIRE(config.opt<ConfigOptionFloat>("max_bridge_length")->getFloat() == prev_value);
             }
         }
         WHEN("A string option is set through the string interface") {
@@ -198,7 +195,7 @@ SCENARIO("Config accessor functions perform as expected.", "[Config]") {
 	    }
         }
         WHEN("An invalid option is requested during set.") {
-            THEN("A BadOptionTypeException exception is thrown.") {
+            THEN("A UnknownOptionException exception is thrown.") {
                 REQUIRE_THROWS_AS(config.set("deadbeef_invalid_option", 1), UnknownOptionException);
                 REQUIRE_THROWS_AS(config.set("deadbeef_invalid_option", 1.0), UnknownOptionException);
                 REQUIRE_THROWS_AS(config.set("deadbeef_invalid_option", "1"), UnknownOptionException);

tests/libslic3r/test_filament_mixer.cpp

@@ -65,41 +65,25 @@ TEST_CASE("expand_mixed_filaments replaces mixed slots with their components", "
     }
 }
 
-TEST_CASE("belt purge tower island count ignores virtual mixed slots", "[FilamentMixer][belt]")
+TEST_CASE("A mixed slot whose components are already used adds no filaments", "[FilamentMixer][belt]")
 {
-    // Regression for the "extra purge tower" on a belt printer with a mixed
+    // The belt purge tower sizes its islands from the expanded set. A mixed slot is virtual: no
-    // filament (MCTEST5). The belt purge prism is sized as
+    // nozzle carries it and ToolOrdering::resolve_mixed_filaments() replaces it with its
-    //   n_islands = used_filaments.size() - 1
+    // components, so it must not count as a filament of its own.
-    // and GUI::ensure_belt_purge_tower() collected those filaments straight off
-    // the model objects' extruder assignments. A mixed slot is VIRTUAL -- no
-    // nozzle carries it, and ToolOrdering::resolve_mixed_filaments() replaces it
-    // with its components before any G-code is emitted -- so counting it as a
-    // filament of its own provisions one island that can never be reached.
-    //
-    // MCTEST5: five cubes on extruders 1..5, where filament 5 is a 50/50 blend of
-    // filaments 2 and 4. The G-code uses only T0..T3 and reports
-    // "filament used [g] = 53.35, 141.11, 40.84, 107.23, 0.00" -- filament 5
-    // consumes nothing, exactly as a virtual slot should.
     const std::vector<unsigned char> is_mixed  = {0, 0, 0, 0, 1};
     const std::vector<std::string>   comp_strs = {"", "", "", "", "2,4"};
 
-    // The set the sizer used to see: slots 0..4 (filaments 1..5).
     const std::vector<unsigned int> assigned = {0, 1, 2, 3, 4};
     const auto physical = expand_mixed_filaments(assigned, is_mixed, comp_strs);
 
     // Slot 4 dissolves into 1 and 3, which are already present.
     REQUIRE(physical == std::vector<unsigned int>({0, 1, 2, 3}));
 
-    // Four physical filaments => three transitions => three islands, not four.
-    REQUIRE(int(physical.size()) - 1 == 3);
-    REQUIRE(int(assigned.size()) - 1 == 4);   // what it produced before the fix
-
     SECTION("A mixed slot whose components are otherwise unused still counts them") {
-        // Only the mixed slot is assigned: it must still yield its two components,
+        // Only the mixed slot is assigned: it must still yield its two components rather than
-        // i.e. one island, rather than collapsing to zero.
+        // collapsing to nothing.
         const auto only_mixed = expand_mixed_filaments({4}, is_mixed, comp_strs);
         REQUIRE(only_mixed == std::vector<unsigned int>({1, 3}));
-        REQUIRE(int(only_mixed.size()) - 1 == 1);
     }
 
     SECTION("No mixed filaments anywhere leaves the set untouched") {

tests/libslic3r/test_preset_bundle_loading.cpp

@@ -1219,6 +1219,24 @@ TEST_CASE("find_preset2 auto-matches removed Generic vendor profiles to the libr
     CHECK(bundle.filaments.find_preset2("BrandX Generic PETG", /*auto_match=*/true) == nullptr);
 }
 
+TEST_CASE("The selected preset is its own base when its parent is not loaded", "[Preset]")
+{
+    PresetCollection printers(Preset::TYPE_PRINTER, Preset::printer_options(),
+                              static_cast<const PrintRegionConfig &>(FullPrintConfig::defaults()));
+    add_inmemory_preset(printers, "Printer");
+    add_inmemory_preset(printers, "User Printer", "Printer");
+    add_inmemory_preset(printers, "Orphan Printer", "Uninstalled Vendor Printer");
+
+    printers.select_preset_by_name("User Printer", true);
+    REQUIRE(printers.get_selected_preset_name() == "User Printer");
+    CHECK(printers.get_selected_preset_base().name == "Printer");
+
+    printers.select_preset_by_name("Orphan Printer", true);
+    REQUIRE(printers.get_selected_preset_name() == "Orphan Printer");
+    REQUIRE(printers.get_preset_base(printers.get_selected_preset()) == nullptr);
+    CHECK(printers.get_selected_preset_base().name == "Orphan Printer");
+}
+
 TEST_CASE("Renamed parent is normalized into a loaded preset's inherits", "[Preset][Rename]")
 {
     ScopedTemporaryDir   temp_dir;
@@ -1316,12 +1334,17 @@ TEST_CASE("Renamed printer/process names are normalized into compatible lists on
     CHECK(compatible_list(bundle.filaments, "My Filament", "compatible_printers") ==
           (std::vector<std::string>{ "New Printer", "Unknown Printer" }));
 
-    // Normalizing rewrites config in place without flagging the preset dirty.
+    // Normalization runs before selection, so selecting copies the rewritten list into the edited preset.
-    CHECK_FALSE(bundle.prints.find_preset("My Process", false, true)->is_dirty);
+    bundle.prints.select_preset_by_name("My Process", true);
+    REQUIRE(bundle.prints.get_selected_preset_name() == "My Process");
+    CHECK(bundle.prints.get_edited_preset().config.option<ConfigOptionStrings>("compatible_printers")->values ==
+          std::vector<std::string>{ "New Printer" });
 
-    // A system preset that already references the current name is left untouched (idempotent no-op).
+    // Normalizing again is a no-op: the stored preset keeps the current name and still matches the
+    // edited copy, so the selection is not reported modified.
     bundle.normalize_compatible_presets();
     CHECK(compatible_list(bundle.prints, "My Process", "compatible_printers") == std::vector<std::string>{ "New Printer" });
+    CHECK_FALSE(bundle.prints.current_is_dirty());
 }
 
 TEST_CASE("Renamed names are normalized into a SYSTEM preset's compatible lists", "[Preset][Rename]")
@@ -1351,11 +1374,17 @@ TEST_CASE("Renamed names are normalized into a SYSTEM preset's compatible lists"
     CHECK(compatible_list(bundle.filaments, "System Filament", "compatible_prints") ==
           std::vector<std::string>{ "New Process" });
 
-    // The rewrite does not flag the system preset dirty, and is idempotent.
+    // Normalization runs before selection, so selecting copies the rewritten lists into the edited preset.
-    CHECK_FALSE(bundle.filaments.find_preset("System Filament", false, true)->is_dirty);
+    bundle.filaments.select_preset_by_name("System Filament", true);
+    REQUIRE(bundle.filaments.get_selected_preset_name() == "System Filament");
+    CHECK(bundle.filaments.get_edited_preset().config.option<ConfigOptionStrings>("compatible_printers")->values ==
+          std::vector<std::string>{ "New Printer" });
+
+    // Normalizing again is a no-op, so the selection is not reported modified.
     bundle.normalize_compatible_presets();
     CHECK(compatible_list(bundle.filaments, "System Filament", "compatible_printers") ==
           std::vector<std::string>{ "New Printer" });
+    CHECK_FALSE(bundle.filaments.current_is_dirty());
 }
 
 TEST_CASE("compatible_prints on SLA materials resolves against sla_prints, not prints", "[Preset][Rename]")
@@ -5548,16 +5577,6 @@ TEST_CASE("Sizing down to the nozzle count plus mixes is what eats the mixed tai
         CHECK(bundle.num_mixed_filaments() == 0);
         CHECK(bundle.num_physical_filaments() == target);
     }
-
-    SECTION("applied as a floor, the mix is left alone") {
-        if (target > bundle.filament_presets.size())
-            bundle.set_num_filaments(target);
-
-        CHECK(bundle.filament_presets.size() == 6);
-        CHECK(bundle.num_mixed_filaments() == 1);
-        CHECK(bundle.is_mixed_filament(5));
-        CHECK(bundle.project_config.option<ConfigOptionStrings>("filament_mixed_components")->values[5] == "1,2");
-    }
 }
 
 // After a published-3MF import relocated mixed-filament definitions, the freshly loaded

tests/libslic3r/test_sketchimport.cpp

@@ -5,9 +5,9 @@
 #include <catch2/matchers/catch_matchers.hpp>
 #include <catch2/matchers/catch_matchers_floating_point.hpp>
 #include "libslic3r/CAD/SketchImport.hpp"
-#include "libslic3r/Utils.hpp"   // resources_dir
 #include "test_utils.hpp"        // ScopedTemporaryFile
 
+#include <boost/filesystem/path.hpp>
 #include <cstdlib>
 #include <fstream>
 #include "libslic3r/Point.hpp"
@@ -78,18 +78,10 @@ TEST_CASE("transform_regions moves and scales independently", "[SketchImport]")
 
 TEST_CASE("text_to_regions vectorizes glyphs with counters", "[SketchImport]")
 {
-    // Locate the bundled font; resources_dir() may be unset under ctest, so
+    // The bundled font, from the source tree: PROFILES_DIR is <repo>/resources/profiles.
-    // fall back to a cwd-relative path (tests run from the repo root).
+    const std::string font =
-    std::string font = resources_dir().empty()
+        (boost::filesystem::path(PROFILES_DIR).parent_path() / "fonts" / "HarmonyOS_Sans_SC_Regular.ttf").string();
-                           ? std::string("resources/fonts/HarmonyOS_Sans_SC_Regular.ttf")
+    REQUIRE(std::ifstream(font).good());
-                           : resources_dir() + "/fonts/HarmonyOS_Sans_SC_Regular.ttf";
-    {
-        std::ifstream probe(font);
-        if (!probe.good()) {
-            SUCCEED("bundled font not reachable in this environment; covered live on :10");
-            return;
-        }
-    }
 
     // Bad input is rejected without throwing.
     REQUIRE(text_to_regions("", 10.0, font).empty());

tests/libslic3r/test_sketchinference.cpp

@@ -33,8 +33,9 @@ TEST_CASE("inference: cursor near a line endpoint snaps Coincident-able to it",
 TEST_CASE("inference: endpoint beats midpoint when both are in range", "[inference]")
 {
     std::vector<SketchEntity> ents = { line({0, 0}, {2, 0}) };
-    // Query equidistant-ish but closer to the endpoint: endpoint tier wins regardless.
+    // Query 0.2 from the midpoint (1,0) and 0.8 from the endpoint (2,0): the endpoint tier
-    auto s = infer_point_snap(ents, {1.9, 0.0}, 5.0);
+    // wins even though the midpoint is nearer.
+    auto s = infer_point_snap(ents, {1.2, 0.0}, 5.0, /*include_origin=*/false);
     CHECK(s.kind == K::Endpoint);
     CHECK(s.role == SketchPointRole::P1);
 }

tests/libslic3r/test_sketchprofile.cpp

@@ -113,14 +113,11 @@ TEST_CASE("profile: offsetting a closed rectangle keeps it closed", "[SketchProf
     REQUIRE(closed_wires(out) == 1);
 }
 
-TEST_CASE("profile: offset outward grows the enclosed area by the right amount", "[SketchProfile]")
+TEST_CASE("profile: offsetting a closed rectangle outward keeps it one closed loop", "[SketchProfile]")
 {
-    // A rectangle offset outward by d is (w+2d) x (h+2d) with the corners rounded at r=d,
+    // Outward is -d for a CCW loop. The miter join reconnects the corners, so the result is one
-    // so its area is w*h + 2d(w+h) + pi*d^2 whichever way the corners are healed... except
+    // closed wire, not four disconnected segments. Its area is checked by the sign test below.
-    // for a sharp-corner offset, which is exactly (w+2d)*(h+2d). Either healing is defensible;
+    const auto out = SketchEngine::offset_entities(rect(40, 20), -5.0);
-    // a set of four disconnected segments is not, and that is what this measures.
-    const double w = 40, h = 20, d = 5;
-    const auto out = SketchEngine::offset_entities(rect(w, h), d);
     const auto ws  = SketchEngine::entities_to_wires(out, xy_plane());
     REQUIRE(ws.size() == 1);
     REQUIRE(ws[0].Closed());

tests/libslic3r/test_toolordering_nozzle_group.cpp

@@ -60,9 +60,8 @@ std::vector<NozzleInfo> single_nozzle_per_extruder(int extruder_count)
 }
 } // namespace
 
-TEST_CASE("Multi-nozzle gate predicate mirrors BambuStudio", "[ToolOrdering][H2C]")
+TEST_CASE("Multi-nozzle options exist and default to one nozzle per extruder", "[ToolOrdering][H2C]")
 {
-    // The multi-nozzle gate: std::any_of(extruder_max_nozzle_count > 1).
     DynamicPrintConfig config = DynamicPrintConfig::full_print_config();
 
     auto *opt = config.option<ConfigOptionIntsNullable>("extruder_max_nozzle_count");
@@ -72,15 +71,11 @@ TEST_CASE("Multi-nozzle gate predicate mirrors BambuStudio", "[ToolOrdering][H2C
     // 3mf projects round-trip the per-extruder nozzle inventory (GUI producers wire it later).
     REQUIRE(config.option<ConfigOptionStrings>("extruder_nozzle_stats") != nullptr);
 
-    auto has_multiple_nozzle = [](const std::vector<int> &values) {
+    // Default for every existing printer: 1 nozzle per extruder, so the multi-nozzle gate
-        return std::any_of(values.begin(), values.end(), [](int v) { return v > 1; });
+    // (any extruder_max_nozzle_count > 1) stays closed.
-    };
+    REQUIRE_FALSE(opt->values.empty());
-
+    for (int count : opt->values)
-    // Default for every existing printer: 1 nozzle per extruder => gate is closed.
+        CHECK(count == 1);
-    REQUIRE_FALSE(has_multiple_nozzle(opt->values));
-
-    // Synthetic H2C-like machine: extruder 1 is a 6-nozzle cluster => gate opens.
-    REQUIRE(has_multiple_nozzle(std::vector<int>{1, 6}));
 }
 
 TEST_CASE("Single-nozzle grouping: every filament maps to its extruder nozzle", "[ToolOrdering][H2C]")

tests/libslic3r/test_voronoi.cpp

@@ -32,6 +32,7 @@
 using namespace Slic3r;
 
 using VD = Geometry::VoronoiDiagram;
+static bool has_missing_voronoi_vertices(const Polygons &polygons, const VD &vd);
 using BoostVD = boost::polygon::voronoi_diagram<double>;
 
 // https://svn.boost.org/trac10/ticket/12067
@@ -198,8 +199,12 @@ TEST_CASE("Voronoi missing edges - Alessandro gapfill 12707", "[Voronoi]")
     REQUIRE(intersecting_edges({ poly }).empty());
 
     Lines lines = to_lines(poly);
-    BoostVD vd;
+    VD vd;
-    construct_voronoi(lines.begin(), lines.end(), &vd);
+    vd.construct_voronoi(lines.begin(), lines.end());
+    // Orca's detector finds nothing wrong with this input, so no repair is needed.
+    CHECK(VD::detect_known_issues(vd, lines.begin(), lines.end()) == VD::IssueType::NO_ISSUE_DETECTED);
+    CHECK(vd.get_state() == VD::State::REPAIR_NOT_NEEDED);
+    CHECK_FALSE(has_missing_voronoi_vertices({ poly }, vd));
 
 #ifdef VORONOI_DEBUG_OUT
     dump_voronoi_to_svg(debug_out_path("voronoi-lines.svg").c_str(),
@@ -305,9 +310,16 @@ TEST_CASE("Voronoi weirdness", "[Voronoi]")
     }
 #endif
 
-    BoostVD vd;
+    VD vd;
     Lines lines = to_lines(poly);
-    construct_voronoi(lines.begin(), lines.end(), &vd);
+    vd.construct_voronoi(lines.begin(), lines.end());
+    // Unrepaired, the diagram is missing a Voronoi vertex. construct_voronoi detects it and repairs it
+    // by rotating the input.
+    VD raw_vd;
+    raw_vd.construct_voronoi(lines.begin(), lines.end(), false);
+    CHECK(VD::detect_known_issues(raw_vd, lines.begin(), lines.end()) == VD::IssueType::MISSING_VORONOI_VERTEX);
+    CHECK(vd.get_state() == VD::State::REPAIR_SUCCESSFUL);
+    CHECK(vd.get_issue_type() == VD::IssueType::NO_ISSUE_DETECTED);
 
 #ifdef VORONOI_DEBUG_OUT
     dump_voronoi_to_svg(debug_out_path("voronoi-weirdness.svg").c_str(),
@@ -347,9 +359,8 @@ TEST_CASE("Voronoi division by zero 12903", "[Voronoi]")
 
 // https://svn.boost.org/trac10/ticket/12139
 // Funny sample from a dental industry?
-// Vojtech confirms this test fails and rightly so, because the input data contain self intersections.
+// The input data contain self intersections, so no valid Voronoi diagram can be built from it.
-// This test is suppressed.
+TEST_CASE("Voronoi NaN coordinates 12139", "[Voronoi]")
-TEST_CASE("Voronoi NaN coordinates 12139", "[Voronoi][.][!mayfail]")
 {
     Lines lines = {
         { {  260500,1564400 }, { 261040,1562960 } },
@@ -1327,18 +1338,13 @@ TEST_CASE("Voronoi NaN coordinates 12139", "[Voronoi][.][!mayfail]")
         }
 #endif
 
-    BoostVD vd;
+    VD vd;
-    construct_voronoi(lines.begin(), lines.end(), &vd);
+    vd.construct_voronoi(lines.begin(), lines.end());
-
+    // The diagram built from this self-intersecting input has non-finite vertices, and rotating the
-    for (const auto& edge : vd.edges())
+    // input does not repair it. It must be reported as invalid, which is what MedialAxis::build
-        if (edge.is_finite()) {
+    // checks before falling back to a morphological closing.
-            auto v0 = edge.vertex0();
+    CHECK(vd.get_state() == VD::State::REPAIR_UNSUCCESSFUL);
-            auto v1 = edge.vertex1();
+    CHECK_FALSE(vd.is_valid());
-            REQUIRE((v0->x() == 0 || std::isnormal(v0->x())));
-            REQUIRE((v0->y() == 0 || std::isnormal(v0->y())));
-            REQUIRE((v1->x() == 0 || std::isnormal(v1->x())));
-            REQUIRE((v1->y() == 0 || std::isnormal(v1->y())));
-        }
 
 #ifdef VORONOI_DEBUG_OUT
     dump_voronoi_to_svg(debug_out_path("voronoi-NaNs.svg").c_str(),
@@ -1935,7 +1941,7 @@ TEST_CASE("Voronoi skeleton", "[VoronoiSkeleton]")
 }
 
 // Simple detection with complexity N^2 if there is any point in the input polygons that doesn't have Voronoi vertex.
-[[maybe_unused]] static bool has_missing_voronoi_vertices(const Polygons &polygons, const VD &vd)
+static bool has_missing_voronoi_vertices(const Polygons &polygons, const VD &vd)
 {
     auto are_equal = [](const VD::vertex_type v, const Point &p) { return (Vec2d(v.x(), v.y()) - p.cast<double>()).norm() <= SCALED_EPSILON; };
 
@@ -1957,7 +1963,7 @@ TEST_CASE("Voronoi skeleton", "[VoronoiSkeleton]")
 // into two parts. Even we add more points to the edge, and then for these points, the Voronoin vertex is also missing. An
 // infinity-edge passes through the missing Voronoi vertex. Therefore, this missing Voronoi vertex and edge can be reconstructed
 // using the intersection between the infinity-edge with the input polygon.
-// Rotation of the polygon solves this problem.
+// VoronoiDiagram::construct_voronoi repairs it by rotating the input.
 TEST_CASE("Voronoi missing vertex 1", "[VoronoiMissingVertex1]")
 {
     Polygon poly = {
@@ -1981,7 +1987,14 @@ TEST_CASE("Voronoi missing vertex 1", "[VoronoiMissingVertex1]")
     dump_voronoi_to_svg(debug_out_path("voronoi-missing-vertex1-out.svg").c_str(), vd, Points(), lines);
 #endif
 
-//    REQUIRE(!has_missing_voronoi_vertices({poly}, vd));
+    // Unrepaired, the diagram shows the defect. construct_voronoi detects it and repairs it by
+    // rotating the input.
+    VD raw_vd;
+    raw_vd.construct_voronoi(lines.begin(), lines.end(), false);
+    CHECK(has_missing_voronoi_vertices({poly}, raw_vd));
+    CHECK(vd.get_state() == VD::State::REPAIR_SUCCESSFUL);
+    CHECK(vd.get_issue_type() == VD::IssueType::NO_ISSUE_DETECTED);
+    CHECK_FALSE(has_missing_voronoi_vertices({poly}, vd));
 }
 
 // This case is composed of two square polygons (contour and hole), and again one of the edges is divided into two parts by a
@@ -1989,7 +2002,7 @@ TEST_CASE("Voronoi missing vertex 1", "[VoronoiMissingVertex1]")
 // that for this case, through the missing Voronoi vertex is passing a finite edge between two internal Voronoin vertices.
 // Therefore, this missing Voronoi vertex and edge can be reconstructed using the intersection between the finite edge with the
 // input polygon.
-// Rotation of the polygons solves this problem.
+// VoronoiDiagram::construct_voronoi repairs it by rotating the input.
 TEST_CASE("Voronoi missing vertex 2", "[VoronoiMissingVertex2]")
 {
     Polygons poly = {
@@ -2021,13 +2034,20 @@ TEST_CASE("Voronoi missing vertex 2", "[VoronoiMissingVertex2]")
     dump_voronoi_to_svg(debug_out_path("voronoi-missing-vertex2-out.svg").c_str(), vd, Points(), lines);
 #endif
 
-//    REQUIRE(!has_missing_voronoi_vertices(poly, vd));
+    // Unrepaired, the diagram shows the defect. construct_voronoi detects it and repairs it by
+    // rotating the input.
+    VD raw_vd;
+    raw_vd.construct_voronoi(lines.begin(), lines.end(), false);
+    CHECK(has_missing_voronoi_vertices(poly, raw_vd));
+    CHECK(vd.get_state() == VD::State::REPAIR_SUCCESSFUL);
+    CHECK(vd.get_issue_type() == VD::IssueType::NO_ISSUE_DETECTED);
+    CHECK_FALSE(has_missing_voronoi_vertices(poly, vd));
 }
 
 // This case is composed of two polygons, and again one of the edges is divided into two parts by a point that lies on this edge,
 // and for this point is Voronoi vertex missing. A difference between the previous cases and this case through the missing
 // Voronoi vertex is passing finite edge between one inner Voronoi vertex and one outer Voronoi vertex.
-// Rotating the polygon also help solve this problem.
+// VoronoiDiagram::construct_voronoi repairs it by rotating the input.
 TEST_CASE("Voronoi missing vertex 3", "[VoronoiMissingVertex3]")
 {
     Polygons poly = {
@@ -2055,20 +2075,27 @@ TEST_CASE("Voronoi missing vertex 3", "[VoronoiMissingVertex3]")
     //    polygons_rotate(poly, PI/180);
     //    polygons_rotate(poly, PI/6);
 
-    BoostVD vd;
+    VD    vd;
     Lines lines = to_lines(poly);
-    construct_voronoi(lines.begin(), lines.end(), &vd);
+    vd.construct_voronoi(lines.begin(), lines.end());
 #ifdef VORONOI_DEBUG_OUT
     dump_voronoi_to_svg(debug_out_path("voronoi-missing-vertex3-out.svg").c_str(), vd, Points(), lines);
 #endif
 
-//    REQUIRE(!has_missing_voronoi_vertices(poly, vd));
+    // Unrepaired, the diagram shows the defect. construct_voronoi detects it and repairs it by
+    // rotating the input.
+    VD raw_vd;
+    raw_vd.construct_voronoi(lines.begin(), lines.end(), false);
+    CHECK(has_missing_voronoi_vertices(poly, raw_vd));
+    CHECK(vd.get_state() == VD::State::REPAIR_SUCCESSFUL);
+    CHECK(vd.get_issue_type() == VD::IssueType::NO_ISSUE_DETECTED);
+    CHECK_FALSE(has_missing_voronoi_vertices(poly, vd));
 }
 
 // In this case, the Voronoi vertex (146873, -146873) is included twice.
 // Also, near to those duplicate Voronoi vertices is another Voronoi vertex (146872, -146872).
 // Rotating the polygon will help solve this problem, but then there arise three very close Voronoi vertices.
-// Rotating of the input polygon will help solve this problem.
+// VoronoiDiagram::construct_voronoi repairs it by rotating the input.
 TEST_CASE("Duplicate Voronoi vertices", "[Voronoi]")
 {
     Polygon poly = {
@@ -2095,7 +2122,7 @@ TEST_CASE("Duplicate Voronoi vertices", "[Voronoi]")
     dump_voronoi_to_svg(debug_out_path("voronoi-duplicate-vertices-out.svg").c_str(), vd, Points(), lines);
 #endif
 
-    [[maybe_unused]] auto has_duplicate_vertices = [](const VD &vd) -> bool {
+    auto has_duplicate_vertices = [](const VD &vd) -> bool {
         std::vector<Vec2d> vertices;
         for (const auto &vertex : vd.vertices())
             vertices.emplace_back(Vec2d(vertex.x(), vertex.y()));
@@ -2104,14 +2131,21 @@ TEST_CASE("Duplicate Voronoi vertices", "[Voronoi]")
         return std::unique(vertices.begin(), vertices.end()) != vertices.end();
     };
 
-//    REQUIRE(!has_duplicate_vertices(vd));
+    // Unrepaired, the diagram shows the defect. construct_voronoi detects it and repairs it by
+    // rotating the input.
+    VD raw_vd;
+    raw_vd.construct_voronoi(lines.begin(), lines.end(), false);
+    CHECK(has_duplicate_vertices(raw_vd));
+    CHECK(vd.get_state() == VD::State::REPAIR_SUCCESSFUL);
+    CHECK(vd.get_issue_type() == VD::IssueType::NO_ISSUE_DETECTED);
+    CHECK_FALSE(has_duplicate_vertices(vd));
 }
 
 // In this case, there are three very close Voronoi vertices like in the previous test case after rotation. There is also one
 // missing Voronoi vertex. One infinity-edge (after clip [(146872, -70146871), (146872, -146871)]) passes through this missing
 // Voronoi vertex. This infinite edge [(146872, -70146871), (146872, -146871)] and edge [(146873, -146873), (0, 0)] are intersecting.
 // They intersect probably because the three points are very close to each other, with a combination of the missing Voronoi vertex.
-// Rotating of the input polygon will help solve this problem.
+// VoronoiDiagram::construct_voronoi repairs it by rotating the input.
 TEST_CASE("Intersecting Voronoi edges", "[Voronoi]")
 {
     Polygon poly = {
@@ -2135,7 +2169,7 @@ TEST_CASE("Intersecting Voronoi edges", "[Voronoi]")
     dump_voronoi_to_svg(debug_out_path("voronoi-intersecting-edges-out.svg").c_str(), vd, Points(), lines);
 #endif
 
-    [[maybe_unused]] auto has_intersecting_edges = [](const Polygon &poly, const VD &vd) -> bool {
+    auto has_intersecting_edges = [](const Polygon &poly, const VD &vd) -> bool {
         BoundingBox  bbox         = get_extents(poly);
         const double bbox_dim_max = double(std::max(bbox.size().x(), bbox.size().y()));
 
@@ -2166,5 +2200,12 @@ TEST_CASE("Intersecting Voronoi edges", "[Voronoi]")
         return false;
     };
 
-//    REQUIRE(!has_intersecting_edges(poly, vd));
+    // Unrepaired, the diagram shows the defect. construct_voronoi detects it and repairs it by
+    // rotating the input.
+    VD raw_vd;
+    raw_vd.construct_voronoi(lines.begin(), lines.end(), false);
+    CHECK(has_intersecting_edges(poly, raw_vd));
+    CHECK(vd.get_state() == VD::State::REPAIR_SUCCESSFUL);
+    CHECK(vd.get_issue_type() == VD::IssueType::NO_ISSUE_DETECTED);
+    CHECK_FALSE(has_intersecting_edges(poly, vd));
 }

tests/slic3rutils/CMakeLists.txt

@@ -30,7 +30,6 @@ add_executable(${_TEST_NAME}_tests
     test_plugin_capabilities_in_use.cpp
     test_plugin_status.cpp
     test_printer_agent.cpp
-    test_qidi_printer_agent.cpp
     test_plugin_install.cpp
     test_plugin_lifecycle.cpp
     test_plugin_resource_texture.cpp

tests/slic3rutils/test_moonraker_printer_agent.cpp

@@ -53,7 +53,7 @@ public:
     mutable unsigned fetch_count = 0;
 
 protected:
-    bool fetch_device_info(const ConnectionSettings&, MoonrakerDeviceInfo& info, std::string&) const override
+    bool fetch_device_info(const std::string&, const std::string&, MoonrakerDeviceInfo& info, std::string&) const override
     {
         ++fetch_count;
         info.dev_name = "Test printer";
@@ -65,32 +65,21 @@ class StreamAgent : public MoonrakerPrinterAgent
 {
 public:
     using MoonrakerPrinterAgent::MoonrakerPrinterAgent;
+    using MoonrakerPrinterAgent::start_status_stream;
+    using MoonrakerPrinterAgent::stop_status_stream;
     using MoonrakerPrinterAgent::ws_timings;
 
-    // Starts the stream the way a connection does, from a snapshot of the connection settings.
-    void start_stream(const std::string& base_url, bool use_ssl = false)
-    {
-        const std::string dev_id = "printer";
-        ConnectionSettings connection;
-        connection.dev_id   = dev_id;
-        connection.base_url = base_url;
-        connection.use_ssl  = use_ssl;
-        start_status_stream(dev_id, std::move(connection));
-    }
-
-    void stop_stream() { stop_status_stream(); }
-
 protected:
-    bool init_device_info(const PrinterConnectionParams& params) override
+    bool init_device_info(
+        const std::string& dev_id, const std::string& dev_ip, const std::string&, const std::string&, bool, const std::string& port) override
     {
         device_info          = MoonrakerDeviceInfo{};
-        device_info.dev_id   = params.dev_id;
+        device_info.dev_id   = dev_id;
-        device_info.dev_ip   = params.host;
+        device_info.base_url = "http://" + dev_ip + ":" + port;
-        device_info.base_url = std::string(params.use_ssl ? "https://" : "http://") + params.host + ":" + params.port;
         return true;
     }
 
-    bool fetch_device_info(const ConnectionSettings&, MoonrakerDeviceInfo& info, std::string&) const override
+    bool fetch_device_info(const std::string&, const std::string&, MoonrakerDeviceInfo& info, std::string&) const override
     {
         info.dev_name = "Test printer";
         return true;
@@ -108,7 +97,6 @@ enum class Behavior {
     IgnoresClose,              // Reports Klippy disconnected, then never answers the close
     StallsObjectList,          // Never answers the stream's object list request
     StallsStatusQuery,         // Never answers HTTP requests until released, then hangs up on them
-    RejectsTls,                // Records the first byte of the stream, which a TLS client sends as a handshake
 };
 
 class FakePrinter
@@ -162,19 +150,6 @@ public:
         return m_close_frames;
     }
 
-    // First byte the stream sent, or -1 until it has sent one.
-    bool wait_for_first_byte()
-    {
-        std::unique_lock<std::mutex> lock(m_mutex);
-        return m_changed.wait_for(lock, 10s, [&] { return m_first_byte >= 0; });
-    }
-
-    int first_byte()
-    {
-        std::lock_guard<std::mutex> lock(m_mutex);
-        return m_first_byte;
-    }
-
     // Hangs up every connection that is waiting.
     void release()
     {
@@ -207,20 +182,6 @@ private:
             return;
         }
 
-        if (m_behavior == Behavior::RejectsTls) {
-            char              first = 0;
-            beast::error_code ec;
-            socket.read_some(net::buffer(&first, 1), ec);
-            if (!ec) {
-                std::lock_guard<std::mutex> lock(m_mutex);
-                m_first_byte = static_cast<unsigned char>(first);
-                m_changed.notify_all();
-            }
-            mark_ready();
-            wait_for_release();
-            return;
-        }
-
         beast::flat_buffer buffer;
         http::request<http::string_body> request;
         beast::error_code ec;
@@ -374,7 +335,6 @@ private:
     int m_http_requests = 0;
     int m_http_hung_up  = 0;
     int m_close_frames  = 0;
-    int m_first_byte    = -1;
     bool m_released     = false;
 };
 
@@ -417,15 +377,12 @@ struct StreamFixture
     // Runs before the members are destroyed, so the agent's destructor never joins a stream the printer still holds open.
     ~StreamFixture() { printer.release(); }
 
-    void start() { agent.start_stream(printer.base_url()); }
+    void start() { agent.start_status_stream("printer", printer.base_url(), ""); }
-
-    // Runs the stream as a wss client; the printer must be served on the same port.
-    void start_secure() { agent.start_stream("https://" + printer.host() + ":" + printer.port(), true); }
 
     // Stops the stream, giving it `limit` to return before the printer hangs up on it.
     bool stops_within(std::chrono::milliseconds limit)
     {
-        auto stopped       = std::async(std::launch::async, [this] { agent.stop_stream(); });
+        auto stopped       = std::async(std::launch::async, [this] { agent.stop_status_stream(); });
         const bool in_time = stopped.wait_for(limit) == std::future_status::ready;
         printer.release();
         stopped.wait();
@@ -481,16 +438,6 @@ TEST_CASE("Stopping the status stream gives a silent printer no more than its ti
     CHECK(f.stops_within(limit));
 }
 
-TEST_CASE("A secure status stream opens with a TLS handshake", "[MoonrakerPrinterAgent][StatusStream]")
-{
-    StreamFixture f(Behavior::RejectsTls);
-    f.start_secure();
-    REQUIRE(f.printer.wait_for_first_byte());
-    // 0x16 is a TLS handshake record; a plaintext client would send "GET".
-    CHECK(f.printer.first_byte() == 0x16);
-    CHECK(f.stops_within(3s));
-}
-
 TEST_CASE("Stopping the status stream sends the printer a close frame", "[MoonrakerPrinterAgent][StatusStream]")
 {
     // A stop while the stream reads, and one while it waits on the object list request.
@@ -567,7 +514,7 @@ TEST_CASE("A callback on the stream thread can stop the status stream", "[Moonra
     StreamFixture f(Behavior::AnswersPings);
     f.agent.set_on_local_message_fn([&](std::string, std::string) {
         std::call_once(stopped_once, [&] {
-            f.agent.stop_stream();
+            f.agent.stop_status_stream();
             stopped.set_value();
         });
     });
@@ -625,12 +572,9 @@ TEST_CASE("A disconnect during the connection queries keeps the status stream fr
     f.agent.connect_printer(params);
     REQUIRE(f.printer.wait_for_http_requests(1));
 
-    // disconnect_printer joins the worker running the stalled query, so it is called aside and the
+    f.agent.disconnect_printer();
-    // printer is released to let that query return.
-    auto disconnecting = std::async(std::launch::async, [&] { f.agent.disconnect_printer(); });
     f.printer.release();
     // The query has returned once the printer hangs up on it, and a stream would connect right after.
     REQUIRE(f.printer.wait_for_http_hang_ups(1));
     CHECK_FALSE(f.printer.wait_for_ready_connections(1, 500ms));
-    disconnecting.wait();
 }

tests/slic3rutils/test_plugin_capability_config.cpp

@@ -8,6 +8,7 @@
 #include <slic3r/plugin/PythonPluginInterface.hpp>
 
 #include <catch2/catch_test_macros.hpp>
+#include <catch2/catch_message.hpp>
 #include "plugin_test_utils.hpp"
 #include <pybind11/pytypes.h>
 #include <pybind11/eval.h>
@@ -17,6 +18,12 @@
 #include <pybind11/embed.h>
 #include <pybind11/pybind11.h>
 
+#include <boost/filesystem/operations.hpp>
+#include <boost/filesystem/path.hpp>
+
+#include <chrono>
+#include <fstream>
+#include <ios>
 #include <memory>
 #include <string>
 #include <pybind11/cast.h>
@@ -105,6 +112,72 @@ PluginCapabilityId capability_id(PluginCapabilityType type, const char* name, co
     return {type, name, plugin_key};
 }
 
+// restore_config_response looks the capability up in PluginManager, so the restore tests load a real
+// plugin rather than building a detached capability.
+const char* const RESTORE_PLUGIN_KEY = "Restore_Plugin";
+
+const char* const RESTORE_PLUGIN_SOURCE = R"PY(# /// script
+# requires-python = ">=3.12"
+#
+# [tool.orcaslicer.plugin]
+# name = "Restore Plugin"
+# description = "Restore defaults fixture"
+# author = "OrcaSlicer"
+# version = "1.0"
+# type = "script"
+# ///
+import orca
+
+class Target(orca.script.ScriptPluginCapabilityBase):
+    def get_name(self): return "Target"
+    def execute(self, ctx): return orca.ExecutionResult.success()
+    def get_default_config(self): return {"speed": 1}
+
+class Bystander(orca.script.ScriptPluginCapabilityBase):
+    def get_name(self): return "Bystander"
+    def execute(self, ctx): return orca.ExecutionResult.success()
+    def get_default_config(self): return {"speed": 2}
+
+# Loading seeds defaults through get_default_config and fails the plugin if it raises, so this one
+# answers the load and raises from then on.
+class Raising(orca.script.ScriptPluginCapabilityBase):
+    calls = 0
+    def get_name(self): return "Raising"
+    def execute(self, ctx): return orca.ExecutionResult.success()
+    def get_default_config(self):
+        Raising.calls += 1
+        if Raising.calls > 1:
+            raise RuntimeError("boom")
+        return {}
+
+@orca.plugin
+class RestorePackage(orca.base):
+    def register_capabilities(self):
+        orca.register_capability(Target)
+        orca.register_capability(Bystander)
+        orca.register_capability(Raising)
+)PY";
+
+// Writes the restore fixture into {data_dir}/orca_plugins and loads it, returning the load error
+// (empty on success). Call without holding the GIL: the load runs on a worker thread.
+std::string load_restore_plugin(const ScopedDataDir& data_dir_guard)
+{
+    const boost::filesystem::path plugin_dir = data_dir_guard.plugins_dir() / RESTORE_PLUGIN_KEY;
+    boost::filesystem::create_directories(plugin_dir);
+    {
+        std::ofstream out((plugin_dir / (std::string(RESTORE_PLUGIN_KEY) + ".py")).string(), std::ios::binary);
+        out << RESTORE_PLUGIN_SOURCE;
+    }
+
+    PluginManager& manager = PluginManager::instance();
+    manager.discover_plugins(/*async=*/false, /*clear=*/true);
+    manager.load_plugin(RESTORE_PLUGIN_KEY, /*skip_deps=*/true);
+    std::string error;
+    if (!manager.wait_for_plugin_load(RESTORE_PLUGIN_KEY, std::chrono::seconds(120), error) && error.empty())
+        error = "the plugin did not load";
+    return error;
+}
+
 } // namespace
 
 TEST_CASE("Capability config API is exposed on every Python capability", "[PluginConfig][Python]")
@@ -357,26 +430,27 @@ TEST_CASE("Restoring defaults overwrites only the target capability", "[PluginCo
     ScopedPluginManager plugin_system; // declared first: destroyed last
     if (!plugin_system.initialized)
         SKIP("Bundled Python interpreter unavailable: " + PythonInterpreter::instance().last_error());
-    py::gil_scoped_acquire gil; // released before plugin_system's destructor shuts Python down
 
     ScopedDataDir data_dir_guard("plugin-config-py-restore");
     host_config().load();
+    const std::string load_error = load_restore_plugin(data_dir_guard);
+    INFO("load error: " << load_error);
+    REQUIRE(load_error.empty());
 
-    const std::string defaults_body = "    def get_name(self): return 'cap'\n"
+    const PluginCapabilityId target    = capability_id(PluginCapabilityType::Script, "Target", RESTORE_PLUGIN_KEY);
-                                      "    def get_default_config(self): return {'speed': 1}\n";
+    const PluginCapabilityId bystander = capability_id(PluginCapabilityType::Script, "Bystander", RESTORE_PLUGIN_KEY);
-    py::object target   = make_capability("RestoreTargetCap", defaults_body, "plugin_a", "cap_a");
-    py::object bystander = make_capability("RestoreBystanderCap", defaults_body, "plugin_b", "cap_a");
-
     const json edited = json{{"speed", 99}};
-    REQUIRE(py_save_config(target, edited));
+    REQUIRE(host_config().store_capability_config(target, edited));
-    REQUIRE(py_save_config(bystander, edited));
+    REQUIRE(host_config().store_capability_config(bystander, edited));
 
-    // What PluginsDialog::restore_capability_config does: ask the capability, store the answer.
+    const json response = PluginConfig::restore_config_response(target);
-    auto iface = as_interface(target);
-    REQUIRE(host_config().store_capability_config(capability_id(PluginCapabilityType::Script, "cap_a", "plugin_a"), iface->get_default_config()));
 
-    CHECK(host_config().get_config(capability_id(PluginCapabilityType::Script, "cap_a", "plugin_a"))->config == json{{"speed", 1}});
+    CHECK(response["ok"] == true);
-    CHECK(host_config().get_config(capability_id(PluginCapabilityType::Script, "cap_a", "plugin_b"))->config == json{{"speed", 99}});
+    CHECK(response["config"] == json{{"speed", 1}});
+    CHECK(host_config().get_config(target)->config == json{{"speed", 1}});
+    CHECK(host_config().get_config(bystander)->config == edited);
+
+    PluginManager::instance().unload_plugin(RESTORE_PLUGIN_KEY);
 }
 
 TEST_CASE("A raising get_default_config leaves the stored config untouched", "[PluginConfig][Python]")
@@ -384,24 +458,23 @@ TEST_CASE("A raising get_default_config leaves the stored config untouched", "[P
     ScopedPluginManager plugin_system; // declared first: destroyed last
     if (!plugin_system.initialized)
         SKIP("Bundled Python interpreter unavailable: " + PythonInterpreter::instance().last_error());
-    py::gil_scoped_acquire gil; // released before plugin_system's destructor shuts Python down
 
     ScopedDataDir data_dir_guard("plugin-config-py-restore-raise");
     host_config().load();
+    const std::string load_error = load_restore_plugin(data_dir_guard);
+    INFO("load error: " << load_error);
+    REQUIRE(load_error.empty());
 
-    py::object cap = make_capability("RaisingDefaultsCap",
+    const PluginCapabilityId raising = capability_id(PluginCapabilityType::Script, "Raising", RESTORE_PLUGIN_KEY);
-                                     "    def get_name(self): return 'cap_a'\n"
+    REQUIRE(host_config().store_capability_config(raising, json{{"keep", "me"}}));
-                                     "    def get_default_config(self): raise RuntimeError('boom')\n",
-                                     "plugin_a", "cap_a");
 
-    REQUIRE(py_save_config(cap, json{{"keep", "me"}}));
+    const json response = PluginConfig::restore_config_response(raising);
 
-    auto iface = as_interface(cap);
+    CHECK(response["ok"] == false);
-    REQUIRE(iface);
+    CHECK_FALSE(response["error"].get<std::string>().empty());
-    CHECK_THROWS_AS(iface->get_default_config(), py::error_already_set);
+    CHECK(host_config().get_config(raising)->config == json{{"keep", "me"}});
 
-    // The dialog stores nothing when the hook throws: a broken plugin must not wipe user settings.
+    PluginManager::instance().unload_plugin(RESTORE_PLUGIN_KEY);
-    CHECK(host_config().get_config(capability_id(PluginCapabilityType::Script, "cap_a", "plugin_a"))->config == json{{"keep", "me"}});
 }
 
 TEST_CASE("A raising config UI hook surfaces as an exception the host can catch", "[PluginConfig][Python]")

tests/slic3rutils/test_plugin_cloud_metadata.cpp

@@ -76,12 +76,12 @@ TEST_CASE("plugin latest version uses the authoritative catalog field", "[Plugin
 {
     PluginDescriptor descriptor;
     descriptor.version        = "1.3.0";
-    descriptor.latest_version = "1.3.0";
+    descriptor.latest_version = "1.4.0";
     PluginChangelog changelog;
     changelog.version = "1.2.0";
     descriptor.changelog.push_back(changelog);
 
-    CHECK(descriptor.latest_available_version() == "1.3.0");
+    CHECK(descriptor.latest_available_version() == "1.4.0");
 }
 
 TEST_CASE("plugin latest version falls back to the descriptor version", "[PluginDescriptor]")

tests/slic3rutils/test_plugin_lifecycle.cpp

@@ -615,8 +615,22 @@ TEST_CASE("Python module release removes package submodules and owned sys.path",
 
     // Ensure the next import executes the new submodule rather than reusing a stale package child.
     write_package("'new'");
+    {
+        // The rewrite can keep the old mtime and size, so drop the bytecode wherever the
+        // interpreter caches it.
+        PythonGILState gil;
+        REQUIRE(gil);
+        PyObjectPtr util(PyImport_ImportModule("importlib.util"));
+        REQUIRE(util);
+        for (const char* file : {"__init__.py", "sub.py"}) {
+            PyObjectPtr source(PyUnicode_DecodeFSDefault((package_root / file).string().c_str()));
+            REQUIRE(source);
+            PyObjectPtr cached(PyObject_CallMethod(util.get(), "cache_from_source", "O", source.get()));
+            REQUIRE(cached);
             boost::system::error_code ec;
-    fs::remove_all(package_root / "__pycache__", ec);
+            fs::remove(fs::path(PyUnicode_AsUTF8(cached.get())), ec);
+        }
+    }
 
     paths.clear();
     modules.clear();

tests/slic3rutils/test_printer_agent.cpp

@@ -1,30 +1,18 @@
 #include <catch2/catch_all.hpp>
 
-#include <functional>
-#include <slic3r/Utils/BBLPrinterAgent.hpp>
-#include <slic3r/Utils/IPrinterAgent.hpp>
-#include <slic3r/Utils/MoonrakerPrinterAgent.hpp>
 #include <memory>
 #include <slic3r/Utils/NetworkAgentFactory.hpp>
 
 #include <catch2/catch_test_macros.hpp>
 #include <pybind11/pytypes.h>
 #include <catch2/catch_message.hpp>
-#include "catch2/matchers/catch_matchers.hpp"
-#include "catch2/matchers/catch_matchers_floating_point.hpp"
 #include "python_test_support.hpp"
 
 #include <pybind11/embed.h>
 #include <pybind11/pybind11.h>
 
-#include <atomic>
-#include <chrono>
-#include <future>
-#include <slic3r/Utils/bambu_networking.hpp>
 #include <string>
-#include <thread>
 #include <pybind11/cast.h>
-#include <utility>
 
 namespace Slic3r { class ICloudServiceAgent; }
 namespace Slic3r { class IPrinterAgent; }
@@ -32,390 +20,12 @@ namespace Slic3r { class IPrinterAgent; }
 using namespace Slic3r;
 namespace py = pybind11;
 
-namespace {
-
-// Releases a promise on scope exit, so a throwing REQUIRE cannot leave a parked detached
-// thread (and any destructor that joins it) blocked forever.
-class ScopedPromiseRelease
-{
-public:
-    explicit ScopedPromiseRelease(std::shared_ptr<std::promise<void>> p) : m_p(std::move(p)) {}
-    ~ScopedPromiseRelease()
-    {
-        if (m_p) {
-            try {
-                m_p->set_value();
-            } catch (...) {
-                // promise already satisfied
-            }
-        }
-    }
-    ScopedPromiseRelease(const ScopedPromiseRelease&) = delete;
-    ScopedPromiseRelease& operator=(const ScopedPromiseRelease&) = delete;
-
-private:
-    std::shared_ptr<std::promise<void>> m_p;
-};
-
-} // namespace
-
-class MoonrakerParserProbe : public MoonrakerPrinterAgent
-{
-public:
-    using MoonrakerPrinterAgent::parse_nozzle_diameter;
-
-    explicit MoonrakerParserProbe(std::string log_dir) : MoonrakerPrinterAgent(std::move(log_dir)) {}
-};
-
-TEST_CASE("Moonraker parses nozzle diameter from configfile settings", "[MoonrakerPrinterAgent]")
-{
-    const auto response = nlohmann::json::parse(R"({
-        "result": {
-            "status": {
-                "configfile": {
-                    "settings": {
-                        "extruder": {
-                            "nozzle_diameter": 0.6
-                        }
-                    }
-                }
-            }
-        }
-    })");
-
-    CHECK_THAT(MoonrakerParserProbe::parse_nozzle_diameter(response), Catch::Matchers::WithinAbs(0.6f, 1e-4f));
-}
-
-TEST_CASE("Moonraker parses nozzle diameter from raw config and tolerates missing data", "[MoonrakerPrinterAgent]")
-{
-    const auto raw_config_response = nlohmann::json::parse(R"({
-        "result": {
-            "status": {
-                "configfile": {
-                    "config": {
-                        "extruder": {
-                            "nozzle_diameter": "0.8"
-                        }
-                    }
-                }
-            }
-        }
-    })");
-    const auto missing_response = nlohmann::json::object();
-
-    CHECK_THAT(MoonrakerParserProbe::parse_nozzle_diameter(raw_config_response), Catch::Matchers::WithinAbs(0.8f, 1e-4f));
-    CHECK_THAT(MoonrakerParserProbe::parse_nozzle_diameter(missing_response), Catch::Matchers::WithinAbs(0.0f, 1e-6f));
-}
-
-// why: an agent without a Bambu-dialect translation must refuse these commands before any network or wx path.
-TEST_CASE("default AMS commands report not supported", "[MoonrakerPrinterAgent]")
-{
-    MoonrakerPrinterAgent agent("");
-
-    CHECK(agent.command_ams_refresh_rfid("dev", 123, 1, 0, false) == ORCA_NETWORK_ERR_CMD_NOT_SUPPORTED);
-    CHECK(agent.command_ams_calibrate("dev", 1, 2, false) == ORCA_NETWORK_ERR_CMD_NOT_SUPPORTED);
-    CHECK(agent.command_ams_select_tray("dev", "123", 3, false) == ORCA_NETWORK_ERR_CMD_NOT_SUPPORTED);
-}
-
-TEST_CASE("Moonraker light name matching", "[MoonrakerPrinterAgent]")
-{
-    CHECK(moonraker_is_light_name("caselight"));
-    CHECK(moonraker_is_light_name("LED_STRIP"));
-    CHECK_FALSE(moonraker_is_light_name("beeper"));
-    CHECK(moonraker_is_light_name("FLASHLIGHT_SWITCH"));
-    CHECK(moonraker_is_light_name("MODLELIGHT_SWITCH"));
-}
-
-TEST_CASE("Moonraker webcam selection skips disabled webcams and prefers the first enabled one",
-          "[MoonrakerPrinterAgent]")
-{
-    const auto response = nlohmann::json::parse(R"({
-        "result": { "webcams": [
-            { "name": "disabled", "enabled": false, "stream_url": "http://192.168.1.9:8080/stream" },
-            { "name": "enabled",  "enabled": true,  "stream_url": "http://192.168.1.9:8080/stream" }
-        ]}
-    })");
-
-    MoonrakerWebcamSelection selection;
-    REQUIRE(moonraker_parse_webcam_list(response, "http://192.168.1.9:7125", selection));
-    CHECK(selection.name == "enabled");
-    CHECK(selection.url == "http://192.168.1.9:8080/stream");
-    CHECK(selection.mode == CameraStreamMode::http);
-    CHECK(selection.error.empty());
-}
-
-TEST_CASE("Moonraker webcam selection resolves relative URLs, maps rtsp, and rejects other schemes",
-          "[MoonrakerPrinterAgent]")
-{
-    const auto relative = nlohmann::json::parse(R"({
-        "result": { "webcams": [ { "name": "cam", "snapshot_url": "/webcam/?action=snapshot" } ] }
-    })");
-    MoonrakerWebcamSelection rel;
-    REQUIRE(moonraker_parse_webcam_list(relative, "http://192.168.1.9:7125", rel));
-    // Relative URLs use the printer web root, without the Moonraker API port.
-    CHECK(rel.url == "http://192.168.1.9/webcam/?action=snapshot");
-    CHECK(rel.mode == CameraStreamMode::http_snapshot);
-
-    const auto rtsp = nlohmann::json::parse(R"({
-        "result": { "webcams": [ { "name": "cam", "stream_url": "rtsp://192.168.1.9:554/live" } ] }
-    })");
-    MoonrakerWebcamSelection rt;
-    REQUIRE(moonraker_parse_webcam_list(rtsp, "http://192.168.1.9:7125", rt));
-    CHECK(rt.mode == CameraStreamMode::rtsp);
-
-    const auto unsupported = nlohmann::json::parse(R"({
-        "result": { "webcams": [ { "name": "cam", "stream_url": "weird://host/x" } ] }
-    })");
-    MoonrakerWebcamSelection bad;
-    CHECK_FALSE(moonraker_parse_webcam_list(unsupported, "http://192.168.1.9:7125", bad));
-    CHECK(bad.error == "Unsupported webcam URL");
-}
-
-TEST_CASE("Moonraker webcam selection reports no webcam and malformed structure", "[MoonrakerPrinterAgent]")
-{
-    const auto empty = nlohmann::json::parse(R"({ "result": { "webcams": [] } })");
-    MoonrakerWebcamSelection none;
-    CHECK_FALSE(moonraker_parse_webcam_list(empty, "http://host:7125", none));
-    CHECK(none.error == "No enabled webcam");
-
-    const auto disabled_only = nlohmann::json::parse(R"({
-        "result": { "webcams": [ { "name": "disabled", "enabled": false, "stream_url": "http://host/stream" } ] }
-    })");
-    MoonrakerWebcamSelection off;
-    CHECK_FALSE(moonraker_parse_webcam_list(disabled_only, "http://host:7125", off));
-
-    const auto malformed = nlohmann::json::parse(R"({ "result": { "nope": 1 } })");
-    MoonrakerWebcamSelection shape;
-    CHECK_FALSE(moonraker_parse_webcam_list(malformed, "http://host:7125", shape));
-    CHECK(shape.error == "Unexpected JSON structure");
-}
-
-// ===========================================================================
-// UNIT - handle_request's not-supported default.
-// The agent is the only thing that knows what it can translate, so an untranslated
-// command has to say so instead of returning success and letting the UI believe the
-// control worked. Guards the inverse too: the pushing namespace is genuinely
-// satisfied by the websocket status stream, and it re-fires from the keepalive timer
-// roughly once a second, so it must stay a success or it would raise a dialog on a
-// timer. Only branches that touch neither the network nor wx are exercised.
-// ===========================================================================
-TEST_CASE("Moonraker reports untranslated commands as not supported", "[MoonrakerPrinterAgent]")
-{
-    MoonrakerPrinterAgent agent("");
-
-    CHECK(agent.send_message("dev", R"({"print":{"command":"ams_change_filament"}})", 0, 0) ==
-          ORCA_NETWORK_ERR_CMD_NOT_SUPPORTED);
-    CHECK(agent.send_message("dev", R"({"system":{"command":"set_door_stat"}})", 0, 0) ==
-          ORCA_NETWORK_ERR_CMD_NOT_SUPPORTED);
-    CHECK(agent.send_message("dev", R"({"xcam":{"command":"xcam_control_set"}})", 0, 0) ==
-          ORCA_NETWORK_ERR_CMD_NOT_SUPPORTED);
-
-    CHECK(agent.send_message("dev", R"({"pushing":{"command":"pushall"}})", 0, 0) == BAMBU_NETWORK_SUCCESS);
-    CHECK(agent.send_message("dev", R"({"pushing":{"command":"start"}})", 0, 0) == BAMBU_NETWORK_SUCCESS);
-
-    // why: malformed input is a different failure than an untranslated command, and the
-    // default must not swallow it into a misleading not-supported verdict.
-    CHECK(agent.send_message("dev", "{not json", 0, 0) == BAMBU_NETWORK_ERR_INVALID_RESULT);
-}
-
-// why: IPrinterAgent::fetch_filament_info is the single virtual hook derived agents override.
-// Pull-mode overrides must be synchronous (the caller reads DevFilaSystem as soon as it
-// returns), but subscription overrides may be fire-and-forget: QidiPrinterAgent/Snapmaker
-// spawn a detached thread when asked for subscription updates. QidiPrinterAgent is `final`,
-// so this probes the subscription contract with a controllable double instead.
-TEST_CASE("a fire-and-forget subscription fetch is not waited on by the caller",
-          "[MoonrakerPrinterAgent]")
-{
-    class RecordingAgent : public Slic3r::MoonrakerPrinterAgent
-    {
-    public:
-        explicit RecordingAgent(std::string log_dir) : MoonrakerPrinterAgent(std::move(log_dir)) {}
-
-        // Shared so the detached proxy fetch never touches `this`: a throwing REQUIRE
-        // then cannot leave it dereferencing a destroyed agent.
-        std::shared_ptr<std::atomic<bool>>  invoked{std::make_shared<std::atomic<bool>>(false)};
-        std::shared_ptr<std::promise<void>> release_gate{std::make_shared<std::promise<void>>()};
-        std::shared_ptr<std::promise<void>> done_promise{std::make_shared<std::promise<void>>()};
-
-        bool fetch_filament_info(std::string /*dev_id*/, FilamentSyncMode sync_mode = FilamentSyncMode::pull) override
-        {
-            // Only the subscription path is allowed to be fire-and-forget.
-            if (sync_mode != FilamentSyncMode::subscription)
-                return true;
-
-            auto invoked_p      = invoked;
-            auto release_gate_p = release_gate;
-            auto done_promise_p = done_promise;
-            std::thread([invoked_p, release_gate_p, done_promise_p]() {
-                invoked_p->store(true);
-                // Block here until the test explicitly releases us, proving the caller
-                // (fetch_filament_info) does not wait for this to run.
-                release_gate_p->get_future().wait();
-                done_promise_p->set_value();
-            }).detach();
-            return true;
-        }
-    };
-
-    auto agent = std::make_shared<RecordingAgent>(std::string{});
-    auto done_future = agent->done_promise->get_future();
-    ScopedPromiseRelease release_gate_guard{agent->release_gate};
-
-    bool immediate_result = agent->fetch_filament_info("test-dev", FilamentSyncMode::subscription);
-
-    // fetch_filament_info must return before its background work completes — prove
-    // it by confirming the background call is still blocked on the gate right now.
-    REQUIRE(immediate_result == true);
-    REQUIRE(done_future.wait_for(std::chrono::milliseconds(100)) == std::future_status::timeout);
-
-    // Now let the background call finish and confirm it actually ran (polymorphic dispatch).
-    agent->release_gate->set_value();
-    REQUIRE(done_future.wait_for(std::chrono::seconds(2)) == std::future_status::ready);
-    REQUIRE(agent->invoked->load() == true);
-}
-
-namespace {
-
-// Globals so a parked proxy fetch thread never dereferences a freed agent.
-std::atomic<int>  g_deferred_fetch_running{0};
-std::atomic<bool> g_deferred_destroy_returned{false};
-
-// Releases the given gates, then joins on scope exit: so a throwing REQUIRE cannot leave
-// the thread blocked (deadlocking the join) or let it std::terminate.
-class ScopedJoiner
-{
-public:
-    ScopedJoiner(std::thread& t, std::shared_ptr<std::promise<void>> gate1, std::shared_ptr<std::promise<void>> gate2)
-        : m_thread(t), m_gates{std::move(gate1), std::move(gate2)}
-    {}
-    ~ScopedJoiner()
-    {
-        for (auto& gate : m_gates) {
-            if (gate) {
-                try {
-                    gate->set_value();
-                } catch (...) {
-                    // promise already satisfied
-                }
-            }
-        }
-        if (m_thread.joinable()) m_thread.join();
-    }
-    ScopedJoiner(const ScopedJoiner&) = delete;
-    ScopedJoiner& operator=(const ScopedJoiner&) = delete;
-
-private:
-    std::thread&                        m_thread;
-    std::shared_ptr<std::promise<void>> m_gates[2];
-};
-
-// A fetch that parks before touching the in-flight counter, so teardown's wait can
-// observe zero first.
-class DeferredFetchAgent : public MoonrakerPrinterAgent
-{
-public:
-    explicit DeferredFetchAgent(std::string log_dir) : MoonrakerPrinterAgent(std::move(log_dir)) {}
-
-    // Shared so a parked proxy fetch can never outlive the stack that owns it.
-    std::shared_ptr<std::promise<void>> entered{std::make_shared<std::promise<void>>()};
-    std::shared_ptr<std::promise<void>> allow_fetch{std::make_shared<std::promise<void>>()};
-    std::shared_ptr<std::promise<void>> allow_finish{std::make_shared<std::promise<void>>()};
-    std::shared_ptr<std::promise<void>> running{std::make_shared<std::promise<void>>()};
-
-    // Runs the callable on the command worker, which teardown joins.
-    void post(std::function<void()> fn) { enqueue_command(std::move(fn)); }
-
-    bool fetch_filament_info(std::string /*dev_id*/, FilamentSyncMode /*sync_mode*/ = FilamentSyncMode::pull) override
-    {
-        // Resumes after ~DeferredFetchAgent destroyed these members; snapshot up front.
-        auto entered_p      = entered;
-        auto allow_fetch_p  = allow_fetch;
-        auto allow_finish_p = allow_finish;
-        auto running_p      = running;
-
-        entered_p->set_value();
-        allow_fetch_p->get_future().wait();
-
-        filament_fetch_in_flight.fetch_add(1, std::memory_order_relaxed);
-        std::thread([this, finish = std::move(allow_finish_p), running = std::move(running_p)] {
-            struct InFlightGuard
-            {
-                MoonrakerPrinterAgent& owner;
-                ~InFlightGuard() { owner.release_fetch_slot(); }
-            } guard{*this};
-
-            g_deferred_fetch_running.fetch_add(1, std::memory_order_relaxed);
-            running->set_value();
-            finish->get_future().wait();
-            g_deferred_fetch_running.fetch_sub(1, std::memory_order_relaxed);
-        }).detach();
-        return true;
-    }
-};
-
-} // namespace
-
-// REGRESSION - teardown must not return while a fetch it started is in flight.
-// The command worker parks a fetch before it reserves the in-flight slot, forcing
-// the "wait already observed zero" interleaving deterministically.
-TEST_CASE("an agent's destruction waits for a fetch started by its worker during teardown",
-          "[MoonrakerPrinterAgent][Regression]")
-{
-    g_deferred_fetch_running.store(0);
-    g_deferred_destroy_returned.store(false);
-
-    auto agent        = std::make_shared<DeferredFetchAgent>(std::string{});
-    auto entered      = agent->entered;
-    auto allow_fetch  = agent->allow_fetch;
-    auto allow_finish = agent->allow_finish;
-    auto running      = agent->running;
-
-    // Safety net for the pre-destroyer failure paths: release both gates before the
-    // agent is destroyed (declared after it, so destroyed before it).
-    ScopedPromiseRelease release_finish{allow_finish};
-    ScopedPromiseRelease release_fetch{allow_fetch};
-
-    // Park a fetch inside the command worker while the agent is still complete.
-    agent->post([ptr = agent.get()] { ptr->fetch_filament_info("dev", FilamentSyncMode::pull); });
-    REQUIRE(entered->get_future().wait_for(std::chrono::seconds(5)) == std::future_status::ready);
-
-    // Destroy on another thread so this one can drive the parked fetch.
-    std::thread destroyer([owned = std::move(agent)]() mutable {
-        owned.reset();
-        g_deferred_destroy_returned.store(true);
-    });
-    // Releases both gates before joining, so a failing REQUIRE cannot deadlock the join.
-    ScopedJoiner join_destroyer{destroyer, allow_fetch, allow_finish};
-
-    // Let the worker reserve the in-flight slot and spawn its fetch, then wait until it
-    // is genuinely parked (no polling).
-    allow_fetch->set_value();
-    REQUIRE(running->get_future().wait_for(std::chrono::seconds(5)) == std::future_status::ready);
-    REQUIRE(g_deferred_fetch_running.load() == 1);
-
-    // A correct teardown cannot return while the fetch is parked; give a buggy one time.
-    for (int i = 0; i < 200 && !g_deferred_destroy_returned.load(); ++i)
-        std::this_thread::sleep_for(std::chrono::milliseconds(10));
-
-    if (g_deferred_destroy_returned.load()) {
-        // Bug: teardown returned with a fetch still running. Don't release allow_finish.
-        CHECK(g_deferred_fetch_running.load() == 0);
-        return;
-    }
-
-    // Fixed order: destruction is still blocked on the in-flight fetch.
-    allow_finish->set_value();
-    destroyer.join();
-    CHECK(g_deferred_destroy_returned.load());
-    CHECK(g_deferred_fetch_running.load() == 0);
-}
-
 // ===========================================================================
 // UNIT - printer-agent registry duplicate handling.
 // Confirms a duplicate agent id is rejected so a plugin cannot shadow a built-in
 // or previously registered agent.
 // ===========================================================================
-TEST_CASE("printer-agent registry register / lookup / duplicate-reject", "[PrinterAgent]")
+TEST_CASE("unit: printer-agent registry register / lookup / duplicate-reject", "[registry][unit]")
 {
     // why: the registry is process-global state shared by the test binary, and
     // Catch2 may run cases in any order. Use an id that cannot collide with
@@ -459,7 +69,7 @@ TEST_CASE("printer-agent registry register / lookup / duplicate-reject", "[Print
 // fails to load the codecs needed for the filesystem encoding. The shared helper
 // points PyConfig.home at the python/ runtime staged next to the test executable.
 
-TEST_CASE("orca.printer_agent binding surface", "[integration][Python]")
+TEST_CASE("integration: orca.printer_agent binding surface", "[integration][Python]")
 {
     py::module_ orca = import_orca_module();
 
@@ -510,7 +120,7 @@ TEST_CASE("orca.printer_agent binding surface", "[integration][Python]")
 // them in the lightweight embedded-interpreter test catches binding breakage
 // before the plugin-loader test needs to run.
 // ===========================================================================
-TEST_CASE("orca plugin-registration API surface + discovery-context guards", "[integration][Python]")
+TEST_CASE("integration: orca plugin-registration API surface + discovery-context guards", "[integration][Python]")
 {
     py::module_ orca = import_orca_module();
 

tests/slic3rutils/test_qidi_printer_agent.cpp

@@ -1,134 +0,0 @@
-#include "catch2/catch_test_macros.hpp"
-#include "catch2/matchers/catch_matchers.hpp"
-#include "catch2/matchers/catch_matchers_string.hpp"
-#include <catch2/catch_all.hpp>
-
-#include <nlohmann/json.hpp>
-
-#include <slic3r/Utils/QidiPrinterAgent.hpp>
-
-#include <string>
-
-using namespace Slic3r;
-
-TEST_CASE("Qidi slot response rejects null variables without throwing", "[QidiPrinterAgent]")
-{
-    const std::string response = R"({
-        "result": {
-            "status": {
-                "save_variables": {
-                    "variables": null
-                }
-            }
-        }
-    })";
-    nlohmann::json status;
-    nlohmann::json variables;
-    std::string    error;
-    bool           parsed = true;
-
-    REQUIRE_NOTHROW(parsed = QidiPrinterAgent::parse_slot_response(response, status, variables, error));
-    CHECK_FALSE(parsed);
-    CHECK_THAT(error, Catch::Matchers::ContainsSubstring("variables"));
-    CHECK_THAT(error, Catch::Matchers::ContainsSubstring("object"));
-}
-
-TEST_CASE("Qidi slot response rejects missing and non-object fields without throwing", "[QidiPrinterAgent]")
-{
-    std::string response;
-
-    SECTION("missing result")
-    {
-        response = R"({})";
-    }
-
-    SECTION("non-object result")
-    {
-        response = R"({"result":null})";
-    }
-
-    SECTION("missing status")
-    {
-        response = R"({"result":{}})";
-    }
-
-    SECTION("non-object status")
-    {
-        response = R"({"result":{"status":null}})";
-    }
-
-    SECTION("missing save_variables")
-    {
-        response = R"({"result":{"status":{}}})";
-    }
-
-    SECTION("non-object save_variables")
-    {
-        response = R"({"result":{"status":{"save_variables":null}}})";
-    }
-
-    SECTION("missing variables")
-    {
-        response = R"({"result":{"status":{"save_variables":{}}}})";
-    }
-
-    SECTION("scalar")
-    {
-        response = R"({"result":{"status":{"save_variables":{"variables":42}}}})";
-    }
-
-    SECTION("array")
-    {
-        response = R"({"result":{"status":{"save_variables":{"variables":[]}}}})";
-    }
-
-    nlohmann::json status;
-    nlohmann::json variables;
-    std::string    error;
-    bool           parsed = true;
-
-    REQUIRE_NOTHROW(parsed = QidiPrinterAgent::parse_slot_response(response, status, variables, error));
-    CHECK_FALSE(parsed);
-}
-
-TEST_CASE("Qidi slot response exposes valid status and variables", "[QidiPrinterAgent]")
-{
-    const std::string response = R"({
-        "result": {
-            "status": {
-                "save_variables": {
-                    "variables": {
-                        "box_count": 2,
-                        "color_slot0": 3
-                    }
-                },
-                "box_stepper slot0": {
-                    "runout_button": 0
-                }
-            }
-        }
-    })";
-    nlohmann::json status;
-    nlohmann::json variables;
-    std::string    error;
-    bool           parsed = false;
-
-    REQUIRE_NOTHROW(parsed = QidiPrinterAgent::parse_slot_response(response, status, variables, error));
-    REQUIRE(parsed);
-    CHECK(status.is_object());
-    CHECK(variables.is_object());
-    CHECK(variables.at("box_count") == 2);
-    CHECK(status.contains("box_stepper slot0"));
-}
-
-TEST_CASE("Qidi slot response rejects invalid JSON", "[QidiPrinterAgent]")
-{
-    nlohmann::json status;
-    nlohmann::json variables;
-    std::string    error;
-    bool           parsed = true;
-
-    REQUIRE_NOTHROW(parsed = QidiPrinterAgent::parse_slot_response("{not json", status, variables, error));
-    CHECK_FALSE(parsed);
-    CHECK(error == "Invalid JSON response");
-}

tests/slic3rutils/test_slicing_pipeline_bindings.cpp

@@ -615,12 +615,19 @@ TEST_CASE("orca.host: SurfaceCollection.set mutates geometry; lslices via make_s
                     .attr("expolygon").attr("contour").attr("as_array")().cast<py::array>();
     CHECK(c.shape(0) == 4);
 
-    // lslices are derived: make_slices() re-derives them + refreshes the bbox cache.
+    // lslices are derived: make_slices() re-derives them from the region slices and refreshes the
+    // bbox cache.
     TestLayer layer;
+    layer.add_region(nullptr);
     py::object ly = py::cast(static_cast<Slic3r::Layer*>(&layer), py::return_value_policy::reference);
-    // (A hand-built layer has no regions, so make_slices() yields empty lslices — still null-safe.)
+    ly.attr("regions")().cast<py::list>()[0].attr("slices").attr("set")(expolys, ST.attr("stInternalSolid"));
+    REQUIRE(layer.lslices.empty());
     ly.attr("make_slices")();
-    CHECK(layer.lslices_bboxes.size() == layer.lslices.size());
+    REQUIRE(layer.lslices.size() == 1);
+    CHECK_THAT(layer.lslices.front().area(), WithinRel((double) s * (double) s, 1e-9));
+    REQUIRE(layer.lslices_bboxes.size() == 1);
+    CHECK(layer.lslices_bboxes.front().min == Point(0, 0));
+    CHECK(layer.lslices_bboxes.front().max == Point(s, s));
 }
 
 TEST_CASE("orca.host ExPolygon in-place transforms + SurfaceCollection.append (sample ops)", "[slicing_pipeline]") {