Commit Graph
42 Commits
Author SHA1 Message Date
Ioannis Giannakas 143087bb2a Revert automatic application of reduced internal bridge filtering for lightning infill (#4639) 2024-03-23 10:11:13 +08:00
Ioannis Giannakas b736a0bc38 Revised Inner Outer Inner mode for Classic mode (#4417) 2024-03-18 23:16:12 +08:00
Ioannis Giannakas 28533dd175 Inner Outer Inner mode - arachne bug fix (#4416)
* Inner Outer Inner mode - arachne bug fix

* Update PerimeterGenerator.cpp
2024-03-18 23:14:40 +08:00
Ioannis GiannakasandSoftFever 89f51031eb Pressure equalizer documentation (#4334)
* Placeholder file

* doc renaming

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* images

* images

* Spell checking

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Credits

* Credits

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Update Extrusion-rate-smoothing.md

* Add WIKI link for the Extrusion rate smoothing option

---------

Co-authored-by: SoftFever <softfeverever@gmail.com>
2024-03-09 21:43:44 +08:00
Ioannis Giannakas 083e7cd3d5 Decouple filament minimum print speed from overhang slowdown (#3859) 2024-02-11 11:56:20 +08:00
Ioannis Giannakas 8b1b3355e6 Fix crashing on AMS filament edit (#3981) 2024-02-06 00:09:47 +07:00
Ioannis Giannakas 10cba023e6 Fix issue with PA pattern test using travel acceleration and jerk for the PA patterns (#3851) 2024-01-30 12:40:07 +00:00
Ioannis Giannakas 757b4de4c6 Fix duplicate entry of Only Lift Z above and below in the extruder tab (#3788) 2024-01-22 13:03:20 +00:00
Ioannis Giannakas fe148515ce [Feature] Enabled gap fill algorithm for all solid fill types (#3412)
* ENH: Enabled gap fill algorithm for all solid fill types

* Made gap fill an option & refactored code into its own method

* Code comment updates

* Converted gap fill to enum and control filter out gap fill in the UI

* Update label for consistency

* Spelling mistake
2024-01-18 14:43:23 +00:00
Ioannis Giannakas c0c05c715b [Bug fix] Fixes "Wipe before external loop" causing blobs on single wall perimeters (#3616)
* #3603 - fix "Wipe before external loop" causing blobs on single wall perimeters

* Updated parameters to pass by const reference to avoid re-creation of object
2024-01-18 14:19:30 +00:00
Ioannis Giannakas 0b6968c36f [Feature] Introduced experimental option to fully disable solid infill against walls when ensure vertical thickness is turned off (#3235)
* ENH: Introduced experimental option to fully disable wall solid infill when ensure vertical thickness is turned off.

* Merge branch 'main' into pr-reduce-wall-solid-infill

* Merge remote-tracking branch 'upstream/main' into pr-reduce-wall-solid-infill

* Merge branch 'pr-reduce-wall-solid-infill' of https://github.com/igiannakas/OrcaSlicer into pr-reduce-wall-solid-infill

* Merge branch 'SoftFever:main' into pr-reduce-wall-solid-infill

* Merge branch 'SoftFever:main' into pr-reduce-wall-solid-infill

* Fixed bridges too short when ensure vertical thickness is off

* Merge branch 'main' into pr-reduce-wall-solid-infill

* Fixed if statement typo

* Merge remote-tracking branch 'upstream/main' into pr-reduce-wall-solid-infill

* Updated code comments and tweaked overlap parameter to generate top solid infill.

* Parameter tweaks and caption adjustment

* Code comment update

* Merge branch 'SoftFever:main' into pr-reduce-wall-solid-infill

* Merge branch 'SoftFever:main' into pr-reduce-wall-solid-infill

* Merge branch 'SoftFever:main' into pr-reduce-wall-solid-infill

* Merge branch 'main' into pr-reduce-wall-solid-infill

* Merge branch 'main' into pr-reduce-wall-solid-infill

* Merge branch 'SoftFever:main' into pr-reduce-wall-solid-infill
2024-01-18 21:57:43 +08:00
Ioannis Giannakas 698aba3570 [Bug fix] Fixes retraction on layer change being performed when retract travel threshold is set to 0 (#3614)
Fixes retraction on layer change being performed when retract travel threshold is set to 0
2024-01-15 21:22:00 +08:00
Ioannis Giannakas a996188e38 [Bug fix] Fixes lightning infill with sparse infill width set to 0 causes "divide by zero" fatal error (#3592)
* Fix issue #3567 - Lightning infill with sparse infill width set to 0 causes "divide by zero" fatal error

* Merge branch 'SoftFever:main' into Fix-#3567---Lightning-infill-with-sparse-infill-width-set-to-0-causes-divide-by-zero-fatal-error

* Merge branch 'main' into Fix-#3567---Lightning-infill-with-sparse-infill-width-set-to-0-causes-divide-by-zero-fatal-error
2024-01-14 23:38:34 +08:00
Ioannis Giannakas f7b92d9813 [Feature] Introduced option to control amount of internal bridging, fixing internal bridge missing for some sloped surfaces (#3319)
* ENH: Improve internal bridge detection for sloped surfaces

* Moved lightning detection out of the parallel threads

* Naming conventions

* Revised approach - use reduced expansion multipliers

* Further reduce filtering, flagged option as experimental

* Corrected code comment

* Updated tool tip

* Introduced filtering drop down option
2024-01-13 23:20:08 +08:00
Ioannis Giannakas 0bf78f8e9e Bug: Fix retraction issues with PA pattern calibration (#3314)
* Attempt to fix retraction issues with PA pattern calibration

* PA pattern test fix - retract and wipe on layer change

* Naming convention

* fix crash
2024-01-09 21:55:11 +08:00
Ioannis GiannakasandSoftFever 5aae123cbb Bug: Corrected monotonic lines not respecting user infill / wall overlap setting (#3388)
Bug: Correct monotonic lines not respecting user infill / wall overlap setting

Co-authored-by: SoftFever <softfeverever@gmail.com>
2024-01-06 13:44:33 +08:00
7ab2fabe6a ENH: Port of "wipe inside before extruding an external perimeter" feature from super slicer (#3287)
* Wipe Inside at Start of perimeter

Co-Authored-By: Merill <6536403+supermerill@users.noreply.github.com>

* Cleaned up code and linked it to the wipe on loop parameter

* Trigger build

* Introduced wipe before external loop parameter.

* Removed redundant functions

---------

Co-authored-by: Merill <6536403+supermerill@users.noreply.github.com>
Co-authored-by: SoftFever <softfeverever@gmail.com>
2023-12-27 11:21:33 +00:00
Ioannis Giannakas 951f9e9aef Bug fix: VFA Test fix (#3230)
VFA Test fix
2023-12-22 21:10:36 +08:00
Ioannis Giannakas ba09fa3866 Bug Fix: Fix crash when printing by object after 1.8.2 code merge. Fixed tool ordering not done based on flush volume on BBL printers (#3223)
* PR: Fix crash when printing by object after 1.8.2 code merge

* PR: Revert change in tool ordering - reorder_extruders_for_minimum_flush_volume to enable tool sequencing based on projected flush volumes

* Bumping up reordering to up to 12 different colors on same layer.

* Updated tool ordering to distinguish between bbl printers when reordering tools

* Update to code comment

* Updated population handling of is_bbl_printer variable
2023-12-22 21:09:42 +08:00
Ioannis GiannakasandSoftFever 90097a1926 ENH: PR: Alternate extra wall (#3196)
* ENH: PR: Alternate extra wall

* Updated tooltip

* Tooltip spelling correction

* Introduce dialog box to disable ensure vertical shell thickness

* Alternate Extra Wall - automatically disable for Vase mode and revert vase mode toggles

* Corrected invalid push

---------

Co-authored-by: SoftFever <softfeverever@gmail.com>
2023-12-22 08:54:03 +08:00
Ioannis Giannakas 712c28251c Updated wipe logic to respect retraction speed during wiping (#3094)
* Wipe retraction adjusted based on available wipe distance and retraction speed

* Wipe Improvements: Removed debug code, removed retract before wipe and made the respect retract speed an option.

* Wipe improvements: Spelling & grammar

* Revert "Wipe improvements: Spelling & grammar"

This reverts commit c8f8612b3f.

* Revert "Wipe Improvements: Removed debug code, removed retract before wipe and made the respect retract speed an option."

This reverts commit ba515ffb62.

* Wipe improvements: Using retraction before wipe parameter to judge when to do excess retraction

* Wipe Improvements: Floating point comparison check

* Wipe Improvements: Refactoring the code

* Wipe Improvements: Updated Wipe Distance tool tip

* Wipe Improvements: Removed redundant code

* Wipe Improvements: Use unscale_
2023-12-16 13:54:03 +00:00
Ioannis Giannakas 0a31b33b2b Fix #2662 - "Extra length on restart" setting is ignored when wipe is enabled (#3065)
Fix #2662
2023-12-13 22:16:39 +08:00
Ioannis Giannakas 9e10266646 Updated PA test to address crash when default line width was zero (#3055)
Updated PA test address "bug" #3043
2023-12-10 09:57:50 +08:00
Ioannis Giannakas 7a8e1929ee Fixed a bug that caused curled edge detection not to work as expected for left facing edges when using Arachne. Enabled fan speed control for curled overhangs (#3034)
* Update malformation distance factors (curled edge detection)

* Updated curled detection logic from latest prusa 2.7 release, including updated estimate_points_properties algorithm

Updated curled detection logic from latest prusa 2.7 release, including updated estimate_points_properties algorithm

* Curled distance expansion const introduction

* Enable overhang fan speed logic for curled edges slow downs

* Reverted erroneous change
2023-12-09 09:17:49 +00:00
1c6f2c6817 Merge upstream BBL changes up to 5th Dec (01.08.01.57) & fix issues with 1.8 BBL merge (#2994)
* FIX: mistake in filament vendor

jira:[NEW]

Signed-off-by: xun.zhang <xun.zhang@bambulab.com>
Change-Id: I3af712e417379d8b98ae18feebffe465bfa1e72d

* NEW:set customized materials for the A1 P1 series

Change-Id: I9c34f62867c074bf9ebb315013e5e40526e0eac7

* FIX: the flow rate ratio crashes after load model

for third party printer
Jira: 5244

Change-Id: Idd829c9d99eeba9d180653ac8de4e51b9a0d6370

* FIX: The maximum value is not printed in PA line mode

Jira: 5046  4951
Change-Id: Ic81f9a75ce7f088fe950fdde283ff5c942cd6e83

* ENH:add preset check for sending files

Change-Id: Ia3313d281b5ce91e277b380498014ffdac5debd3

* FIX: locale loading user preset

Change-Id: I88521e4b10cb802d9253eb79a6b78b3286f15a33
Jira: STUDIO-5436

* FIX: sync user preset notify crash on exit

Change-Id: I88f5dbcbd487293ea847ea6092efb61744399541
Jira: STUDIO-5413

* ci: update build version to 01.08.01.56

Change-Id: Id7a9718d5f920da50d52fd2ef220acf5d3270d3c

* GUI/Field: Fix crash in color picker init (#2220)

wxButton->GetBitmap() may return an invalid wxBitmap.
Guard against this.

* FIX: custom filament preset display in cali history issue

jira: new

Change-Id: I4145450a231adff542ab1a7428b3479f4074e06a

* FIX: meshboolean transform result issue

jira: STUDIO-5425

Change-Id: If66fe909ce4458c1b3192e4fd8a3d758fe7c7eaa

* FIX: fix combobox and delete btn in filament setting enabled

Jira: XXXX

Change-Id: I8b659bd77ceb97c8cea9d3e5e931f4ea50822721

* ci: update build version to 01.08.01.57

Change-Id: I7a6f5439863ca81275ae8b80f1b5cf0bb36c4c0f

* Fix crashing of flow rate calibration post BS 1.8 merge

* Revert Staggered Inner Seam logic from Prusa slicer that was overwritten by the BS1.8 update

---------

Signed-off-by: xun.zhang <xun.zhang@bambulab.com>
Co-authored-by: xun.zhang <xun.zhang@bambulab.com>
Co-authored-by: hu.wang <hu.wang@bambulab.com>
Co-authored-by: zhimin.zeng <zhimin.zeng@bambulab.com>
Co-authored-by: tao wang <tao.wang@bambulab.com>
Co-authored-by: chunmao.guo <chunmao.guo@bambulab.com>
Co-authored-by: gerrit <gerrit@bambulab.com>
Co-authored-by: mia <652892+mia-0@users.noreply.github.com>
Co-authored-by: liz.li <liz.li@bambulab.com>
Co-authored-by: maosheng.wei <maosheng.wei@bambulab.com>
2023-12-08 10:27:24 +00:00
Ioannis GiannakasandSoftFever 82cb9e3565 QOL: Dev 1.9 - Regroup Advanced Quality Options (#2962)
* Dev 1.9 - Regroup Advanced Quality Options

* Regroup Advanced Quality Options

* Regroup advanced quality options and flow rate labels

* Updates labels for consistency. Renamed Order of walls to Walls printing order. Updated walls printing order and print infill first tooltip

* Another option spelling mistake

* Another spelling mistake part 2

* Updated localisation files

* Updated de localisation file post upstream merge to resolve conflicts

* Fix merge error when transferring change to branch.

* update locale file for one more message

---------

Co-authored-by: SoftFever <softfeverever@gmail.com>
2023-12-05 21:23:31 +08:00
Ioannis Giannakas b86b077075 Dev 1.9 - Fix Spelling Mistake on Create Printer dialog box (#2961)
* Fix Spelling Mistake on Create Printer dialog box

* Dev 1.9 - Regroup Advanced Quality Options

* Revert "Dev 1.9 - Regroup Advanced Quality Options"

This reverts commit 6ffae875f0.
2023-12-03 09:38:17 +08:00
Ioannis Giannakas 643476084a Feature Merge: Fix missing options on print window (#2951)
Fix missing options on print window - Feature merge
2023-12-02 04:51:28 +00:00
Ioannis Giannakas 205bf5db3f Feature Merge: Fix for inner-outer-inner mode post BBS feature merge (#2949)
Fix for inner-outer-inner mode post BBS feature merge
2023-12-02 04:51:14 +00:00
Ioannis Giannakas ae9a2d5929 Updated internal bridging flow change and reverted bridge PR (#2943)
Updated internal bridging flow change & reverted bridge PR
2023-12-01 15:50:58 +00:00
Ioannis Giannakas 4985cc7e67 Fix purging not working for BBL printers (#2912) 2023-11-28 20:44:29 +08:00
Ioannis Giannakas d71eaf958e Fix crash when closing application (#2904)
* Update GUI_ObjectList.cpp

* Update GUI_ObjectList.cpp
2023-11-27 21:39:16 +08:00
Ioannis Giannakas ce9a8d7b20 Internal Bridge Flow rate parameter introduction (#2859)
* Internal Bridge Flow rate parameter introduction

* updated incorrect capitalisation

* Updated parameter ordering
2023-11-26 21:43:47 +08:00
Ioannis Giannakas cd475f0f94 Add option to "Reverse only internal perimeters" under the reverse on odd feature to reduce part warping (#2722) 2023-11-19 19:02:47 +08:00
Ioannis Giannakas 46b31a41bf Fix duplicate entry of Only Lift Z above and below in the extruder tab (#2561)
Update Tab.cpp
2023-11-01 11:56:14 +08:00
Ioannis Giannakas cee0cbe49a Updated tool tip and removed min print speed disabling when slowdown for layer cooling is de-selected (#2524)
* Updated tool tip and removed min print speed disabling when slowdown for layer cooling is de-selected

* Updated tool tip to make it explicit when this setting is used.
2023-10-28 21:55:48 +08:00
Ioannis Giannakas 466538e44e Inner-Outer-Inner mode - additional fix where an external perimeter is shared between multiple islands in the same ordered_extrusions perimeter list (#2276)
* Updated inner outer inner algorithm

* debug msg

* Revert "debug msg"

This reverts commit 32ce6f2096.

* Update PerimeterGenerator.cpp

* Revert "Update PerimeterGenerator.cpp"

This reverts commit 26c56912f8.
2023-10-03 23:22:33 +08:00
cf846195cc Porting of Pressure Equalizer feature from Prusa Slicer 2.6.x (#2161)
* Overhang perimeter handling

Updated code to handle overhang perimeters as an overhang and not as a bridge.

* Preparing to add curled extrusions identification

* Porting curling calculations from Prusa Slier 2.6.1

* Prototype 1 - slowdown extended to detect curled edges and further reduce speed

First prototype of the code submitted.

* Working prototype - 2

Code is now finally working - external perimeters are slowed down as needed when there is likelyhood of curling up.

ToDo:
1. Reslicing the model causes the algorithm not to run - need to find where this fails to trigger the call for this.
2. Slowdown of internal perimeters not working yet.

* Updated to use overhang wall speed instead of bridging speed for this algorithm

* Fixed bug in speed calculation and tweaked parameters for high speed printer

Fixed bug in speed calculation and tweaked parameters for high speed printer

* Attempting to fix "set started" not being set

* Parameter tweak after print tests

* Fixed estimation not running when model is re-sliced.

* Removing debug printf statements and fixed threading flag.

* Fixed threading

* Parameter tweaks following print tests

* Made this as an option in the GUI

* Reintroduced handling of bridges as per original design

* UI line toggling when option makes sense to be visible.

* Fixed bug in field visibility & made it default to off

* Code optimisation

* Initial commit of code from Prusa Slicer 2.6.1

* Ported ExtrusionRole from Prusa Slicer 2.6.1

* fix compile errors

* Update GCode.hpp

* code changes to invoke pressure equalizer

* attempting to trigger pressure equalizer

(Not compiling)

* Update Fill.cpp

* Update Fill.cpp

* Pressure equaliser layer result update

* Further commits

* Merged PR https://github.com/prusa3d/PrusaSlicer/pull/9622

* First complete working version

* Update PressureEqualizer.cpp

* Implemented parameter in GUI

* Toggle fields according to compatibility

* Updated UI toggles between extrusion rate slope and arc fitting.

* Updated tooltip

* Introduced parameter smoothing segment length

This parameter influences the number of division a line will undergo in response to the requirement to adhere to the extrusion rate flow adjustment.

* Internal parameter and tool tip tweaking

* Parameter and tool tip tweaking

* Updated parameters and tooltip following testing.

* Sync PressureEq with latest PrusaSlicer

* Revert "Sync PressureEq with latest PrusaSlicer"

This reverts commit 131fb94c6b.

---------

Co-authored-by: MGunlogson <MGunlogson@users.noreply.github.com>
Co-authored-by: Vojtech Bubnik <bubnikv@gmail.com>
2023-09-27 21:44:45 +08:00
igiannakasandSoftFever 61437b2c76 Detection of curled edges to enhance slowdown for overhangs algorithm (#2056)
* Overhang perimeter handling

Updated code to handle overhang perimeters as an overhang and not as a bridge.

* Preparing to add curled extrusions identification

* Porting curling calculations from Prusa Slier 2.6.1

* Prototype 1 - slowdown extended to detect curled edges and further reduce speed

First prototype of the code submitted.

* Working prototype - 2

Code is now finally working - external perimeters are slowed down as needed when there is likelyhood of curling up.

ToDo:
1. Reslicing the model causes the algorithm not to run - need to find where this fails to trigger the call for this.
2. Slowdown of internal perimeters not working yet.

* Updated to use overhang wall speed instead of bridging speed for this algorithm

* Fixed bug in speed calculation and tweaked parameters for high speed printer

Fixed bug in speed calculation and tweaked parameters for high speed printer

* Attempting to fix "set started" not being set

* Parameter tweak after print tests

* Fixed estimation not running when model is re-sliced.

* Removing debug printf statements and fixed threading flag.

* Fixed threading

* Parameter tweaks following print tests

* Made this as an option in the GUI

* Reintroduced handling of bridges as per original design

* UI line toggling when option makes sense to be visible.

* Fixed bug in field visibility & made it default to off

* Code optimisation

---------

Co-authored-by: SoftFever <softfeverever@gmail.com>
2023-09-16 22:24:18 +08:00
igiannakas c20b01f37a Updated inner outer inner algorithm to cater for edge case where an internal island with two perimeters on both sides of an external wall was causing a secondary island to not reorder the walls correctly (#1861)
* Updated inner outer inner algorithm to cater for edge case where an internal island with multiple internal perimeters would cause the external island to fall back to outer-> inner wall ordering.

Updated inner outer inner algorithm to cater for edge case where an internal island with multiple internal perimeters would cause the external island to fall back to outer-> inner wall ordering.

* Reworked the inner outer inner algorithm to better work with more than 3 perimeters.

* Code comment updates. Removed error check code.

* Cleaned up code and comments

Cleaned up code and comments

* Disabled inner outer inner algorithm on first layer

Disabling inner outer inner algorithm and using inner to outer wall ordering to promote bed adhesion as having isolated perimeters on the bed has resulted on occasion to warping or incomplete adherence  to the bed.

* Code optimisation
2023-09-09 10:56:03 +08:00
igiannakas 719a25a291 Fix for support generating mid air (#1762) (#1815)
Fix for support generating mid air
2023-08-18 18:55:25 +08:00
igiannakasandSoftFever 1c780496aa Optimise sandwich wall mode when perimeters are shared with multiple islands(Arachne only) (#1352)
* Update PerimeterGenerator.cpp

* PerimeterGenerator updated with improved Sandwich infill handling

Cleaned up code

* Beautified syntax

* Optimise the logic

---------

Co-authored-by: SoftFever <softfeverever@gmail.com>
2023-06-29 12:02:07 +08:00