juli/OrcaSlicer
1
1
Fork 0
mirror of https://github.com/OrcaSlicer/OrcaSlicer.git synced 2026-08-31 05:47:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Re-enable [OrcaCloudServiceAgent] headless tests now that the crash is fixed (#14236)

Browse Source 
Re-enable [OrcaCloudServiceAgent] tests now that the headless crash is fixed

The two OrcaCloudServiceAgent display-name tests were tagged [NotWorking]
in #14175 because the agent constructor dereferenced a null wxTheApp when
run headless (no wxApp is created in the unit-test binary), crashing before
any assertion ran. That null dereference was fixed in 14d2dfdd4c, which
guards wxTheApp in compute_fallback_path() and skips file persistence when
no fallback path is available.

With the fix in place both tests build and pass headless, so drop the
[NotWorking] tag and the stale explanatory comments. Verified on Linux
clang-18 (the CI compiler), headless: 20 assertions in 2 test cases pass.

Closes #14193
This commit is contained in:
raistlin7447
2026-06-16 09:14:13 -05:00
committed by GitHub
parent 14d2dfdd4c
commit e6f917d7c5
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/slic3rutils/slic3rutils_tests_main.cpp
View File

@@ -53,8 +53,7 @@ TEST_CASE("Check SSL certificates paths", "[Http][NotWorking]") {
REQUIRE(status == 200); REQUIRE(status == 200);
} }
// [NotWorking]: OrcaCloudServiceAgent ctor segfaults headless (wxStandardPaths::Get() -> null wxTheApp). TEST_CASE("Orca cloud flat session resolves display name consistently", "[OrcaCloudServiceAgent]")
TEST_CASE("Orca cloud flat session resolves display name consistently", "[OrcaCloudServiceAgent][NotWorking]")
{ {
CHECK(resolved_display_name(flat_session_json({ CHECK(resolved_display_name(flat_session_json({
{"username", "orca_username"}, {"username", "orca_username"},
@@ -82,8 +81,7 @@ TEST_CASE("Orca cloud flat session resolves display name consistently", "[OrcaCl
})) == "orca_username"); })) == "orca_username");
} }
// [NotWorking]: see flat-session test above. TEST_CASE("Orca cloud nested session resolves display name consistently", "[OrcaCloudServiceAgent]")
TEST_CASE("Orca cloud nested session resolves display name consistently", "[OrcaCloudServiceAgent][NotWorking]")
{ {
CHECK(resolved_display_name(nested_session_json({ CHECK(resolved_display_name(nested_session_json({
{"username", "orca_username"}, {"username", "orca_username"},