From e6f917d7c5be02d8d5a595bd2e83eadc26520c57 Mon Sep 17 00:00:00 2001 From: raistlin7447 Date: Tue, 16 Jun 2026 09:14:13 -0500 Subject: [PATCH] Re-enable [OrcaCloudServiceAgent] headless tests now that the crash is fixed (#14236) Re-enable [OrcaCloudServiceAgent] tests now that the headless crash is fixed The two OrcaCloudServiceAgent display-name tests were tagged [NotWorking] in #14175 because the agent constructor dereferenced a null wxTheApp when run headless (no wxApp is created in the unit-test binary), crashing before any assertion ran. That null dereference was fixed in 14d2dfdd4c, which guards wxTheApp in compute_fallback_path() and skips file persistence when no fallback path is available. With the fix in place both tests build and pass headless, so drop the [NotWorking] tag and the stale explanatory comments. Verified on Linux clang-18 (the CI compiler), headless: 20 assertions in 2 test cases pass. Closes #14193 --- tests/slic3rutils/slic3rutils_tests_main.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/slic3rutils/slic3rutils_tests_main.cpp b/tests/slic3rutils/slic3rutils_tests_main.cpp index e29b518f3d..cea6934e8e 100644 --- a/tests/slic3rutils/slic3rutils_tests_main.cpp +++ b/tests/slic3rutils/slic3rutils_tests_main.cpp @@ -53,8 +53,7 @@ TEST_CASE("Check SSL certificates paths", "[Http][NotWorking]") { REQUIRE(status == 200); } -// [NotWorking]: OrcaCloudServiceAgent ctor segfaults headless (wxStandardPaths::Get() -> null wxTheApp). -TEST_CASE("Orca cloud flat session resolves display name consistently", "[OrcaCloudServiceAgent][NotWorking]") +TEST_CASE("Orca cloud flat session resolves display name consistently", "[OrcaCloudServiceAgent]") { CHECK(resolved_display_name(flat_session_json({ {"username", "orca_username"}, @@ -82,8 +81,7 @@ TEST_CASE("Orca cloud flat session resolves display name consistently", "[OrcaCl })) == "orca_username"); } -// [NotWorking]: see flat-session test above. -TEST_CASE("Orca cloud nested session resolves display name consistently", "[OrcaCloudServiceAgent][NotWorking]") +TEST_CASE("Orca cloud nested session resolves display name consistently", "[OrcaCloudServiceAgent]") { CHECK(resolved_display_name(nested_session_json({ {"username", "orca_username"},