mirror of
https://github.com/OrcaSlicer/OrcaSlicer.git
synced 2026-09-18 14:32:36 +00:00
fix: windows unsubscribed loaded plugin not allowed (#15751)
# Description <!-- > Please provide a summary of the changes made in this PR. Include details such as: > * What issue does this PR address or fix? > * What new features or enhancements does this PR introduce? > * Are there any breaking changes or dependencies that need to be considered? --> On windows, after installing and loading a plugin, if you try to unsubscribe from a loaded plugin, and on refresh, it will be an orphaned plugin. # Screenshots/Recordings/Graphs <!-- > Please attach relevant screenshots to showcase the UI changes. > Please attach images that can help explain the changes. --> On unsubscribing from a loaded cloud plugin <img width="1418" height="862" alt="image" src="https://github.com/user-attachments/assets/9ba8353c-1645-4b21-86ff-2ed235f4d259" /> On plugin refresh <img width="1418" height="862" alt="image" src="https://github.com/user-attachments/assets/fd58c144-7970-4448-ba3b-e72e52980467" /> ## Tests <!-- > Please describe the tests that you have conducted to verify the changes made in this PR. --> <!-- > A guide for users on how to download the artifacts from this PR. --> [How to Download Pull Requests Artifacts for Testing](https://www.orcaslicer.com/wiki/how_to_download_pr_artifacts)
This commit is contained in:
@@ -2042,6 +2042,8 @@ bool PluginManager::delete_and_unsubscribe_cloud_plugin(const std::string& plugi
|
||||
return false;
|
||||
}
|
||||
|
||||
unload_plugin(plugin_key);
|
||||
|
||||
if (!m_cloud_service.request_cloud_unsubscribe(descriptor, error)) {
|
||||
set_plugin_error(plugin_key, error);
|
||||
return false;
|
||||
|
||||
Reference in New Issue
Block a user