juli/OrcaSlicer
1
1
Fork 0
mirror of https://github.com/OrcaSlicer/OrcaSlicer.git synced 2026-10-10 17:21:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Correct the variant-keying note on the wipe tower estimate

Browse Source 
filament_minimal_purge_on_wipe_tower became variant-keyed upstream, which
invalidated the comment claiming none of full_config's keys were.
WipeTower2::extract_wipe_volumes indexes it by raw filament slot. Not reachable
with shipped presets; noted rather than worked around.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Clifford Garwood
2026-10-01 21:40:39 -04:00
co-authored by Claude Opus 5
parent 6c46942c57
commit c9b2b89b2b
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/slic3r/GUI/PartPlate.cpp
+6 -1
View File
@@ -1152,7 +1152,12 @@ Polygon PartPlate::imex_wipe_tower_hull() const
Vec3d wt_pos, wt_size;
// full_config(), not the print preset: wipe_tower_x/y are project options the estimate
// dereferences unchecked. apply_extruder=false - none of its keys are variant-keyed.
// dereferences unchecked. apply_extruder=false, so the per-filament arrays arrive as the
// concatenation of each preset's declared variants rather than one entry per filament.
// That matters now: filament_minimal_purge_on_wipe_tower became variant-keyed upstream and
// WipeTower2::extract_wipe_volumes indexes it by raw filament slot, so a multi-variant
// filament preset on a single-extruder-multi-material machine would estimate the tower
// from the wrong column. No shipped preset pairs the two today.
// plate_extruder_size is a floor, not an override; the scene passes 0, and both counts
// come from the same object walk.
arrangement::ArrangePolygon ap = estimate_wipe_tower_polygon(preset_bundle->full_config(false), m_plate_index, wt_pos, wt_size, plate_extruder_size);