juli/OrcaSlicer
1
1
Fork 0
mirror of https://github.com/OrcaSlicer/OrcaSlicer.git synced 2026-06-15 16:33:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disable fff_print tests that fail only in CI (#14207)

Browse Source 
* Disable fff_print tests that fail only in CI

Skirt height is honored, Scenario: Skirt and brim generation, and
Scenario: PrintGCode basic functionality slice geometry that makes clipper's
coordinate range check throw "Coordinate outside allowed range" in the Linux
CI environment, while the same tests pass in local builds. Tag them
[NotWorking] so the Unit Tests job (ctest -LE NotWorking) excludes them until
the underlying slicing issue is fixed in a follow-up PR.

* Trigger Build all workflow on tests/** changes

The push and pull_request path filters did not include tests/**, so a
test-only change never started the build and the Unit Tests job never ran.
Add tests/** to both filters so changes to the test suite are built and
exercised by CI.
This commit is contained in:
raistlin7447
2026-06-14 19:53:45 -05:00
committed by GitHub
parent 8c0b89bc8a
commit b1e510fc99
3 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/build_all.yml vendored
View File

@@ -15,6 +15,7 @@ on:
- ".github/workflows/build_*.yml"
- 'scripts/flatpak/**'
- 'scripts/msix/**'
- 'tests/**'
pull_request:
branches:
@@ -32,6 +33,7 @@ on:
- 'build_release_macos.sh'
- 'scripts/flatpak/**'
- 'scripts/msix/**'
- 'tests/**'
schedule:

5
tests/fff_print/test_printgcode.cpp
View File

@@ -30,7 +30,10 @@ boost::regex perimeters_regex("G1 X[-0-9.]* Y[-0-9.]* E[-0-9.]* ; perimeter");
boost::regex infill_regex("G1 X[-0-9.]* Y[-0-9.]* E[-0-9.]* ; infill");
boost::regex skirt_regex("G1 X[-0-9.]* Y[-0-9.]* E[-0-9.]* ; skirt");
SCENARIO( "PrintGCode basic functionality", "[PrintGCode]") {
// [NotWorking]: slice() intermittently throws clipper's "Coordinate outside allowed
// range" in CI (Linux) while passing locally. Disabled pending a root-cause fix in a
// follow-up PR.
SCENARIO( "PrintGCode basic functionality", "[PrintGCode][NotWorking]") {
GIVEN("A default configuration and a print test object") {
WHEN("the output is executed with no support material") {
Slic3r::Print print;

8
tests/fff_print/test_skirt_brim.cpp
View File

@@ -32,7 +32,10 @@ using namespace Slic3r;
return brim_tool;
}
TEST_CASE("Skirt height is honored", "[SkirtBrim]") {
// [NotWorking]: slice() intermittently throws clipper's "Coordinate outside allowed
// range" in CI (Linux) while passing locally. Disabled pending a root-cause fix in a
// follow-up PR.
TEST_CASE("Skirt height is honored", "[SkirtBrim][NotWorking]") {
DynamicPrintConfig config = Slic3r::DynamicPrintConfig::full_print_config();
config.set_deserialize_strict({
{ "skirt_loops", 1 },
@@ -52,7 +55,8 @@ TEST_CASE("Skirt height is honored", "[SkirtBrim]") {
REQUIRE(layers_with_role(gcode, "skirt").size() == (size_t)config.opt_int("skirt_height"));
}
SCENARIO("Skirt and brim generation", "[SkirtBrim]") {
// [NotWorking]: see "Skirt height is honored" above; same CI-only clipper range throw.
SCENARIO("Skirt and brim generation", "[SkirtBrim][NotWorking]") {
GIVEN("A default configuration") {
DynamicPrintConfig config = Slic3r::DynamicPrintConfig::full_print_config();
config.set_num_extruders(4);