fix: camera signaling API

(cherry picked from commit d9f1f8b207)

src/slic3r/Utils/OrcaCloudServiceAgent.cpp

@@ -1,8 +1,8 @@
 #include "OrcaCloudServiceAgent.hpp"
 #include "CloudProvider.hpp"
 #include "Http.hpp"
-#include "bambu_networking.hpp"
-#include "ICloudServiceAgent.hpp"
+#include "ICameraSignalingChannel.hpp"
+#include "OrcaCloudSignalingChannel.hpp"
 #include "libslic3r/Utils.hpp"
 #include "slic3r/GUI/GUI_App.hpp"
 #include "libslic3r/AppConfig.hpp"
@@ -3040,6 +3040,9 @@ int OrcaCloudServiceAgent::get_camera_url(std::string dev_id, std::function<void
     return BAMBU_NETWORK_SUCCESS;
 }
 
+std::unique_ptr<ICameraSignalingChannel> OrcaCloudServiceAgent::create_camera_signaling_channel(const std::string& dev_id)
+{ return std::make_unique<OrcaCloudSignalingChannel>(this, dev_id); }
+
 int OrcaCloudServiceAgent::get_design_staffpick(int offset, int limit, std::function<void(std::string)> callback)
 {
     BOOST_LOG_TRIVIAL(debug) << "OrcaCloudServiceAgent: get_design_staffpick (stub)";

src/slic3r/Utils/OrcaCloudServiceAgent.hpp

@@ -269,7 +269,7 @@ public:
     // ICloudServiceAgent Interface Implementation - Model Mall & Publishing
     // ========================================================================
     int get_camera_url(std::string dev_id, std::function<void(std::string)> callback) override;
-    // std::unique_ptr<ICameraSignalingChannel> create_camera_signaling_channel(const std::string& dev_id) override;
+    std::unique_ptr<ICameraSignalingChannel> create_camera_signaling_channel(const std::string& dev_id) override;
     int get_design_staffpick(int offset, int limit, std::function<void(std::string)> callback) override;
     int start_publish(PublishParams params, OnUpdateStatusFn update_fn, WasCancelledFn cancel_fn, std::string* out) override;
     int get_model_publish_url(std::string* url) override;

src/slic3r/Utils/OrcaCloudSignalingChannel.cpp

@@ -18,8 +18,8 @@
 
 namespace Slic3r {
 
-OrcaCloudSignalingChannel::OrcaCloudSignalingChannel(std::shared_ptr<ICloudServiceAgent> cloud, std::string dev_id)
-    : m_cloud(std::move(cloud))
+OrcaCloudSignalingChannel::OrcaCloudSignalingChannel(OrcaCloudServiceAgent* cloud, std::string dev_id)
+    : m_cloud(cloud)
     , m_dev_id(std::move(dev_id))
 {
 }

src/slic3r/Utils/OrcaCloudSignalingChannel.hpp

@@ -2,6 +2,7 @@
 
 #include "ICameraSignalingChannel.hpp"
 #include "ICloudServiceAgent.hpp"
+#include "OrcaCloudServiceAgent.hpp"
 
 #include <boost/asio/io_context.hpp>
 #include <boost/asio/ip/tcp.hpp>
@@ -21,7 +22,7 @@ namespace Slic3r {
 
 class OrcaCloudSignalingChannel : public ICameraSignalingChannel {
 public:
-    OrcaCloudSignalingChannel(std::shared_ptr<ICloudServiceAgent> cloud, std::string dev_id);
+    OrcaCloudSignalingChannel(OrcaCloudServiceAgent* cloud, std::string dev_id);
     ~OrcaCloudSignalingChannel() override;
 
     void open() override;
@@ -51,7 +52,7 @@ private:
     static std::string encode_path_component(const std::string& value);
     static std::string host_without_scheme(std::string value);
 
-    std::shared_ptr<ICloudServiceAgent> m_cloud;
+    OrcaCloudServiceAgent* m_cloud;
     std::string m_dev_id;
     std::atomic<bool> m_stop{false};
     std::atomic<bool> m_open{false};

src/slic3r/Utils/OrcaPrinterAgent.cpp

@@ -1,5 +1,4 @@
 #include "OrcaPrinterAgent.hpp"
-#include "OrcaCloudSignalingChannel.hpp"
 #include "Http.hpp"
 #include "IPrinterAgent.hpp"
 #include "NetworkAgentFactory.hpp"
@@ -696,14 +695,6 @@ void OrcaPrinterAgent::set_cloud_agent(std::shared_ptr<ICloudServiceAgent> cloud
     BOOST_LOG_TRIVIAL(info) << "OrcaPrinterAgent::set_cloud_agent: status callback result=" << callback_result;
 }
 
-std::unique_ptr<ICameraSignalingChannel> OrcaPrinterAgent::create_camera_signaling_channel(const std::string& dev_id)
-{
-    std::lock_guard<std::mutex> lock(state_mutex);
-    if (!m_cloud_agent)
-        return nullptr;
-    return std::make_unique<OrcaCloudSignalingChannel>(m_cloud_agent, dev_id);
-}
-
 // ============================================================================
 // Communication
 // ============================================================================

src/slic3r/Utils/OrcaPrinterAgent.hpp

@@ -38,8 +38,6 @@ public:
     void set_cloud_agent(std::shared_ptr<ICloudServiceAgent> cloud) override;
     CameraStreamMode get_camera_stream_mode() const override;
     std::string get_camera_url() const override;
-    std::unique_ptr<ICameraSignalingChannel>
-    create_camera_signaling_channel(const std::string& dev_id) override;
 
     // Communication
     int send_message(std::string dev_id, std::string json_str, int qos, int flag) override;