mirror of
https://github.com/OrcaSlicer/OrcaSlicer.git
synced 2026-08-03 00:02:14 +00:00
feeea3e651
# Description Fixes user filament presets that reference an old printer preset name in `compatible_printers`, even when the current system printer preset correctly declares that old name in `renamed_from`. ## Core Issue `PresetCollection::find_preset()` was updated to resolve `renamed_from`, but this specific failure does not go through `find_preset()`. For root user filament presets with empty `inherits`, Orca infers `compatible_printers` from the filament name suffix after `@`. For example: ```json "ELEGOO PLA Base @Elegoo Neptune 4 Pro (0.4 nozzle)" ``` loads with: ```json "compatible_printers": ["Elegoo Neptune 4 Pro (0.4 nozzle)"] ``` The current system printer preset is named: ```text Elegoo Neptune 4 Pro 0.4 nozzle ``` and has: ```json "renamed_from": "Elegoo Neptune 4 Pro (0.4 nozzle)" ``` However, filament compatibility was doing a direct string comparison against the active printer name. Since that compatibility path does not call `find_preset()`, the `renamed_from` mapping was never considered. ## Fix Teach printer compatibility checks to treat `active_printer.preset.renamed_from` entries as aliases of the active printer name. This preserves existing user preset JSON and avoids rewriting `compatible_printers`, while allowing old printer suffixes to remain compatible with renamed system printer presets. ## Tests <!-- > A guide for users on how to download the artifacts from this PR. --> [How to Download Pull Requests Artifacts for Testing](https://www.orcaslicer.com/wiki/how_to_download_pr_artifacts)
33 lines
545 B
JSON
33 lines
545 B
JSON
{
|
|
"type": "filament",
|
|
"name": "Bambu ABS @0.8 nozzle",
|
|
"inherits": "Bambu ABS",
|
|
"from": "system",
|
|
"setting_id": "NKhfqNQIcfKQBYAK",
|
|
"filament_id": "GFB99",
|
|
"instantiation": "true",
|
|
"filament_flow_ratio": [
|
|
"0.95"
|
|
],
|
|
"enable_pressure_advance": [
|
|
"1"
|
|
],
|
|
"pressure_advance": [
|
|
"0.011"
|
|
],
|
|
"filament_max_volumetric_speed": [
|
|
"22"
|
|
],
|
|
"nozzle_temperature": [
|
|
"260"
|
|
],
|
|
"slow_down_min_speed": [
|
|
"10"
|
|
],
|
|
"compatible_printers": [
|
|
"Qidi X-Smart 3 0.8 nozzle",
|
|
"Qidi X-Plus 3 0.8 nozzle",
|
|
"Qidi X-Max 3 0.8 nozzle"
|
|
]
|
|
}
|