mirror of
https://github.com/OrcaSlicer/OrcaSlicer.git
synced 2026-10-04 14:20:58 +00:00
HanifKoh
84657ff11e
* Ignore Clipper, libpng, mcut and Boost.Polygon Internals in clang-tidy Each only works through a wrapper or umbrella header: libslic3r/clipper.hpp or clipper_z.hpp configure Clipper before including it, png.h pulls in libpng's config headers, and Boost.Polygon's headers only compile through polygon.hpp or voronoi.hpp. * Ignore minilzo's Config Headers in clang-tidy lzoconf.h and lzodefs.h are internal to minilzo.h, which is what the code includes. * Add Missing Includes Across the Remaining Sources and Tests Covers src/slic3r/Utils, src/slic3r/plugin, src/slic3r/Config, src/libvgcode, src/dev-utils, src/OrcaSlicer.cpp and tests/, the directories left after src/slic3r/GUI and src/libslic3r. Generated with clang-tidy misc-include-cleaner. libvgcode's own headers are included by relative path as in the rest of that library, and Catch2 and pybind11 with angle brackets as elsewhere in the repo. * Make the GUI and Test Headers Compile on Their Own Each now includes, or forward-declares, what it uses instead of relying on what its includers happened to include first. Headers that only compile on one platform, or that nothing built includes, are left alone. * Keep Windows and nanosvg Setup Ahead of the Added Includes OrcaSlicer.cpp and several tests set _WIN32_WINNT, WIN32_LEAN_AND_MEAN or NOMINMAX before including Windows.h, and the profile validator defines NANOSVG_IMPLEMENTATION before any libslic3r header. The added includes had landed above those blocks, which broke the Windows build. * Add the GUI Includes the First Pass Missed Covers headers that only became editable once they compiled on their own, and wx symbols whose suggested header changed as the clang-tidy ignore list grew after the src/slic3r/GUI pass. * Keep the Added Test Includes Below the NOMINMAX Guard test_marchingsquares.cpp and test_texture_displacement.cpp had includes inside #ifndef NOMINMAX, which the tests inherit as defined on Windows from libslic3r, so those were skipped there. .clang-tidy also ignores the MSVC STL and UCRT internals, Boost.Multiprecision's fwd.hpp and CPython's Windows include directory, as in #16068.
61 lines
2.1 KiB
C++
61 lines
2.1 KiB
C++
#include <catch2/catch_all.hpp>
|
|
#include <string>
|
|
#include "libslic3r/Point.hpp"
|
|
|
|
#include <catch2/catch_test_macros.hpp>
|
|
#include "libslic3r/Model.hpp"
|
|
#include "libslic3r/Format/STL.hpp"
|
|
|
|
using namespace Slic3r;
|
|
|
|
static inline std::string stl_path(const char* path)
|
|
{
|
|
return std::string(TEST_DATA_DIR) + "/test_stl/" + path;
|
|
}
|
|
|
|
SCENARIO("Reading an STL file", "[stl]") {
|
|
GIVEN("umlauts in the path of a binary STL file, Czech characters in the file name") {
|
|
WHEN("STL file is read") {
|
|
Slic3r::Model model;
|
|
THEN("load should succeed") {
|
|
REQUIRE(Slic3r::load_stl(stl_path("Geräte/20mmbox-čřšřěá.stl").c_str(), &model));
|
|
REQUIRE(is_approx(model.objects.front()->volumes.front()->mesh().size(), Vec3d(20, 20, 20)));
|
|
}
|
|
}
|
|
}
|
|
GIVEN("in ASCII format") {
|
|
WHEN("line endings LF") {
|
|
Slic3r::Model model;
|
|
THEN("load should succeed") {
|
|
REQUIRE(Slic3r::load_stl(stl_path("ASCII/20mmbox-LF.stl").c_str(), &model));
|
|
REQUIRE(is_approx(model.objects.front()->volumes.front()->mesh().size(), Vec3d(20, 20, 20)));
|
|
}
|
|
}
|
|
WHEN("line endings CRLF") {
|
|
Slic3r::Model model;
|
|
THEN("load should succeed") {
|
|
REQUIRE(Slic3r::load_stl(stl_path("ASCII/20mmbox-CRLF.stl").c_str(), &model));
|
|
REQUIRE(is_approx(model.objects.front()->volumes.front()->mesh().size(), Vec3d(20, 20, 20)));
|
|
}
|
|
}
|
|
#if 0
|
|
// ASCII STLs ending with just carriage returns are not supported. These were used by the old Macs, while the Unix based MacOS uses LFs as any other Unix.
|
|
WHEN("line endings CR") {
|
|
Slic3r::Model model;
|
|
THEN("load should succeed") {
|
|
REQUIRE(Slic3r::load_stl(stl_path("ASCII/20mmbox-CR.stl").c_str(), &model));
|
|
REQUIRE(is_approx(model.objects.front()->volumes.front()->mesh().size(), Vec3d(20, 20, 20)));
|
|
}
|
|
}
|
|
|
|
#endif
|
|
WHEN("nonstandard STL file (text after ending tags, invalid normals, for example infinities)") {
|
|
Slic3r::Model model;
|
|
THEN("load should succeed") {
|
|
REQUIRE(Slic3r::load_stl(stl_path("ASCII/20mmbox-nonstandard.stl").c_str(), &model));
|
|
REQUIRE(is_approx(model.objects.front()->volumes.front()->mesh().size(), Vec3d(20, 20, 20)));
|
|
}
|
|
}
|
|
}
|
|
}
|