mirror of
https://github.com/OrcaSlicer/OrcaSlicer.git
synced 2026-10-04 14:20:58 +00:00
HanifKoh
84657ff11e
* Ignore Clipper, libpng, mcut and Boost.Polygon Internals in clang-tidy Each only works through a wrapper or umbrella header: libslic3r/clipper.hpp or clipper_z.hpp configure Clipper before including it, png.h pulls in libpng's config headers, and Boost.Polygon's headers only compile through polygon.hpp or voronoi.hpp. * Ignore minilzo's Config Headers in clang-tidy lzoconf.h and lzodefs.h are internal to minilzo.h, which is what the code includes. * Add Missing Includes Across the Remaining Sources and Tests Covers src/slic3r/Utils, src/slic3r/plugin, src/slic3r/Config, src/libvgcode, src/dev-utils, src/OrcaSlicer.cpp and tests/, the directories left after src/slic3r/GUI and src/libslic3r. Generated with clang-tidy misc-include-cleaner. libvgcode's own headers are included by relative path as in the rest of that library, and Catch2 and pybind11 with angle brackets as elsewhere in the repo. * Make the GUI and Test Headers Compile on Their Own Each now includes, or forward-declares, what it uses instead of relying on what its includers happened to include first. Headers that only compile on one platform, or that nothing built includes, are left alone. * Keep Windows and nanosvg Setup Ahead of the Added Includes OrcaSlicer.cpp and several tests set _WIN32_WINNT, WIN32_LEAN_AND_MEAN or NOMINMAX before including Windows.h, and the profile validator defines NANOSVG_IMPLEMENTATION before any libslic3r header. The added includes had landed above those blocks, which broke the Windows build. * Add the GUI Includes the First Pass Missed Covers headers that only became editable once they compiled on their own, and wx symbols whose suggested header changed as the clang-tidy ignore list grew after the src/slic3r/GUI pass. * Keep the Added Test Includes Below the NOMINMAX Guard test_marchingsquares.cpp and test_texture_displacement.cpp had includes inside #ifndef NOMINMAX, which the tests inherit as defined on Windows from libslic3r, so those were skipped there. .clang-tidy also ignores the MSVC STL and UCRT internals, Boost.Multiprecision's fwd.hpp and CPython's Windows include directory, as in #16068.
50 lines
1.5 KiB
C++
50 lines
1.5 KiB
C++
#include <catch2/catch_all.hpp>
|
|
#include <vector>
|
|
#include "libslic3r/libslic3r.h"
|
|
#include <string>
|
|
#include <cstdio>
|
|
|
|
#include <catch2/catch_test_macros.hpp>
|
|
#include "libslic3r/Utils.hpp"
|
|
#define NANOSVG_IMPLEMENTATION
|
|
#include "nanosvg/nanosvg.h"
|
|
#define NANOSVGRAST_IMPLEMENTATION
|
|
#include "nanosvg/nanosvgrast.h"
|
|
namespace {
|
|
|
|
TEST_CASE("sort_remove_duplicates", "[utils]") {
|
|
std::vector<int> data_src = { 3, 0, 2, 1, 15, 3, 5, 6, 3, 1, 0 };
|
|
std::vector<int> data_dst = { 0, 1, 2, 3, 5, 6, 15 };
|
|
Slic3r::sort_remove_duplicates(data_src);
|
|
REQUIRE(data_src == data_dst);
|
|
}
|
|
|
|
TEST_CASE("string_printf", "[utils]") {
|
|
SECTION("Empty format with empty data should return empty string") {
|
|
std::string outs = Slic3r::string_printf("");
|
|
REQUIRE(outs.empty());
|
|
}
|
|
|
|
SECTION("String output length should be the same as input") {
|
|
std::string outs = Slic3r::string_printf("1234");
|
|
REQUIRE(outs.size() == 4);
|
|
}
|
|
|
|
SECTION("String format should be interpreted as with sprintf") {
|
|
std::string outs = Slic3r::string_printf("%d %f %s", 10, 11.4, " This is a string");
|
|
char buffer[1024];
|
|
|
|
sprintf(buffer, "%d %f %s", 10, 11.4, " This is a string");
|
|
|
|
REQUIRE(outs.compare(buffer) == 0);
|
|
}
|
|
|
|
SECTION("String format should survive large input data") {
|
|
std::string input(2048, 'A');
|
|
std::string outs = Slic3r::string_printf("%s", input.c_str());
|
|
REQUIRE(outs.compare(input) == 0);
|
|
}
|
|
}
|
|
|
|
}
|