mirror of
https://github.com/OrcaSlicer/OrcaSlicer.git
synced 2026-09-17 22:12:36 +00:00
Kris Austin
56f9edc572
* chore: mark every declaration that overrides a base virtual clang-cl reports 42 member functions across 28 files that override a base virtual without being marked `override`, inside classes that already mark their other overrides. That is every occurrence of -Winconsistent-missing-override in the tree, so the category drops to zero and -Werror=inconsistent-missing-override becomes available as a guard against it coming back. Behaviour is unchanged. Each keyword goes only where clang had already resolved the declaration to a base virtual, so it records what the compiler already worked out and cannot affect overload resolution or dispatch. If any of these signatures had not really overridden a base method, the build would have failed rather than warned. Where a declaration already carried `virtual` it is left alone and the keyword appended, matching the surrounding declarations. Plain `override` is used rather than the wxWidgets `wxOVERRIDE` macro, which wx/defs.h defines as `override` beneath a comment marking it obsolete, and which the rest of src/slic3r already avoids by 1742 occurrences to 113. A full clang-cl build takes -Winconsistent-missing-override from 1,146 warning lines to 0. Those 42 declarations produce that many lines because a header is re-diagnosed in every translation unit that includes it. CalibrationWizardStartPage.hpp alone accounts for 336 of them from 4 declarations. * chore: drop unused lambda captures in GUI/Widgets clang-cl reports 10 lambda captures in src/slic3r/GUI/Widgets that are never read. Removing them changes nothing at runtime. Every capture removed is `this` or a raw pointer. clang does not report a capture whose type has a non-trivial destructor, since such a capture can be held purely for its effect on an object's lifetime, so nothing that owns or extends a lifetime is touched. The std::weak_ptr captured beside the removed `this` in MultiNozzleSync.cpp stays. This clears the category in GUI/Widgets only. A full clang-cl build takes -Wunused-lambda-capture from 312 warning lines to 302, leaving 235 sites in other directories for a follow-up.
67 lines
1.5 KiB
C++
67 lines
1.5 KiB
C++
#ifndef slic3r_GUI_TabButton_hpp_
|
|
#define slic3r_GUI_TabButton_hpp_
|
|
|
|
#include "wxExtensions.hpp"
|
|
#include "Widgets/StaticBox.hpp"
|
|
|
|
class TabButton : public StaticBox
|
|
{
|
|
wxSize textSize;
|
|
wxSize minSize;
|
|
wxSize paddingSize;
|
|
ScalableBitmap icon;
|
|
ScalableBitmap newtag_img;
|
|
|
|
StateColor text_color;
|
|
StateColor border_color;
|
|
bool pressedDown = false;
|
|
bool show_new_tag = false;
|
|
|
|
public:
|
|
TabButton();
|
|
|
|
TabButton(wxWindow *parent, wxString text, ScalableBitmap &icon, long style = 0, int iconSize = 0);
|
|
|
|
bool Create(wxWindow *parent, wxString text, ScalableBitmap &icon, long style = 0, int iconSize = 0);
|
|
|
|
void SetLabel(const wxString& label) override;
|
|
|
|
void SetMinSize(const wxSize& size) override;
|
|
|
|
void SetPaddingSize(const wxSize& size);
|
|
|
|
const wxSize& GetPaddingSize();
|
|
|
|
void SetTextColor(StateColor const &color);
|
|
|
|
void SetBorderColor(StateColor const &color);
|
|
|
|
void SetBGColor(StateColor const &color);
|
|
|
|
void SetBitmap(ScalableBitmap &bitmap);
|
|
|
|
bool Enable(bool enable = true) override;
|
|
|
|
void Rescale();
|
|
|
|
void ShowNewTag(bool tag = false) {show_new_tag = tag; Refresh();};
|
|
bool GetShowNewTag() const { return show_new_tag; };
|
|
|
|
private:
|
|
void paintEvent(wxPaintEvent& evt);
|
|
|
|
void render(wxDC& dc);
|
|
|
|
void messureSize();
|
|
|
|
// some useful events
|
|
void mouseDown(wxMouseEvent& event);
|
|
void mouseReleased(wxMouseEvent& event);
|
|
|
|
void sendButtonEvent();
|
|
|
|
DECLARE_EVENT_TABLE()
|
|
};
|
|
|
|
#endif // !slic3r_GUI_Button_hpp_
|