mirror of
https://github.com/OrcaSlicer/OrcaSlicer.git
synced 2026-10-11 01:41:03 +00:00
Holding two runners from a pull request's second arch until its universal build and tests finished kept one idle through the slower arch's build. Replaying the week of 10-03 against the real queue, that idle capacity pushed the median pull request from under three hours to over sixteen. Those jobs take minutes, so they now queue like any other job, and a pull request holds a runner only for an arch that is still building. Each arch then always needs exactly one runner. Co-authored-by: raistlin7447 <kris.austin@gmail.com>
233 lines
9.5 KiB
Python
233 lines
9.5 KiB
Python
#!/usr/bin/env python3
|
|
"""Holds a pull request's macOS build until a hosted macOS runner is free for it.
|
|
|
|
Runs from a Linux job in build_check_cache.yml, once per macOS arch, in a single
|
|
repo-wide line (a concurrency group with queue: max), so only the job at the
|
|
front of the line polls. It lets its arch in when the runners every active Build
|
|
all run holds or still needs, plus one for this arch, fit in MACOS_RUNNER_LIMIT:
|
|
|
|
- A push, nightly or manual run holds RESERVE runners until its macOS work is
|
|
done. The jobs API lists only the jobs a run has reached, so what it still
|
|
needs cannot be counted and is reserved instead.
|
|
- A pull request run holds one runner for each arch let in until that arch's
|
|
app build is done, and none after. A run holding a runner while it waits for
|
|
its other arch would deadlock: the other arch can sit in the line behind a
|
|
pull request that waits for that runner.
|
|
- A run holds at least the macOS jobs it has queued or running.
|
|
|
|
A pull request's universal build and tests skip the line and are not held for
|
|
in advance. They take minutes, and holding two runners for them through the
|
|
slower arch's build left runners idle while other builds waited.
|
|
- In the minutes around the nightly's cron time, RESERVE runners are held for it
|
|
until its run appears.
|
|
|
|
A pull request labelled macos-priority when its run starts waits in a separate
|
|
line under the same rule, and the normal line counts every priority arch still
|
|
waiting as holding a runner, so the next free runners go to it.
|
|
|
|
Any API error repeated FAILURES_BEFORE_ADMIT times, and the WAIT_MINUTES limit,
|
|
let the arch in, so a fault here never blocks pull requests.
|
|
|
|
Environment: GH_TOKEN, REPO, WORKFLOW_REF, GITHUB_RUN_ID, and optionally PRIORITY,
|
|
MACOS_RUNNER_LIMIT, WAIT_MINUTES, POLL_SECONDS and GITHUB_API_URL.
|
|
"""
|
|
|
|
import datetime
|
|
import json
|
|
import os
|
|
import sys
|
|
import time
|
|
import urllib.error
|
|
import urllib.parse
|
|
import urllib.request
|
|
|
|
# A push, nightly or manual run builds arm64 and x86_64 at the same time, then
|
|
# the universal build and the macOS tests at the same time.
|
|
RESERVE = 2
|
|
|
|
# Must match the job names in build_all.yml and build_check_cache.yml.
|
|
ARCH_PREFIX = "build_macos_arch ("
|
|
GATE = "Wait for a macOS runner"
|
|
PRIORITY_GATE = GATE + " (priority)"
|
|
FINAL_JOBS = {"Build macOS Universal", "macOS arm64"}
|
|
# Must match the cron in build_all.yml.
|
|
NIGHTLY_UTC = datetime.time(2, 15)
|
|
NIGHTLY_REPO = "OrcaSlicer/OrcaSlicer"
|
|
NIGHTLY_LEAD = datetime.timedelta(minutes=10)
|
|
NIGHTLY_GRACE = datetime.timedelta(minutes=45)
|
|
|
|
ACTIVE = {"queued", "in_progress", "waiting", "pending", "requested"}
|
|
FAILURES_BEFORE_ADMIT = 3
|
|
|
|
|
|
def is_macos(job):
|
|
return any(label.startswith("macos-") for label in job.get("labels") or [])
|
|
|
|
|
|
def macos_done(jobs):
|
|
"""True once the universal build and the macOS tests have finished or been skipped.
|
|
Both start together when the arch builds finish."""
|
|
# A skipped caller job is listed under its own name, a started one as "<name> / <job>".
|
|
final = [job for job in jobs if job["name"].split(" / ")[0] in FINAL_JOBS]
|
|
return bool(final) and all(job["status"] == "completed" for job in final)
|
|
|
|
|
|
def gates(jobs, names=(GATE, PRIORITY_GATE)):
|
|
return [job for job in jobs if job["name"].split(" / ")[-1] in names]
|
|
|
|
|
|
def arch_of(job):
|
|
name = job["name"]
|
|
return name[len(ARCH_PREFIX):name.find(")")] if name.startswith(ARCH_PREFIX) else None
|
|
|
|
|
|
def admitted_arches(jobs):
|
|
return {arch_of(job) for job in gates(jobs) if job["conclusion"] == "success"}
|
|
|
|
|
|
def arch_built(jobs, arch):
|
|
"""True once the arch's app build finished, or one of its jobs failed or was cancelled."""
|
|
own = [job for job in jobs if arch_of(job) == arch]
|
|
return any(job["conclusion"] in ("failure", "cancelled") for job in own) or \
|
|
any(" / Build OrcaSlicer" in job["name"] and job["status"] == "completed" for job in own)
|
|
|
|
|
|
def priority_waiting(jobs):
|
|
"""How many of the run's arches wait in the priority line."""
|
|
return sum(1 for job in gates(jobs, (PRIORITY_GATE,)) if job["status"] != "completed")
|
|
|
|
|
|
def run_demand(run, jobs, yield_to_priority=False):
|
|
"""macOS runners a run holds or still needs. With yield_to_priority, each
|
|
priority arch still waiting counts as holding one."""
|
|
# A run with no jobs that is pending waits behind another run of its
|
|
# concurrency group, which holds the runners for both.
|
|
if not jobs and run["status"] in ("pending", "waiting"):
|
|
return 0
|
|
active = sum(1 for job in jobs if is_macos(job) and job["status"] in ACTIVE)
|
|
if macos_done(jobs):
|
|
return active
|
|
if run["event"] != "pull_request":
|
|
return max(active, RESERVE)
|
|
held = sum(1 for arch in admitted_arches(jobs) if not arch_built(jobs, arch))
|
|
if yield_to_priority:
|
|
held += priority_waiting(jobs)
|
|
return max(active, held)
|
|
|
|
|
|
def nightly_window(now):
|
|
"""The window around today's nightly cron time, as (start, end) in UTC."""
|
|
cron = datetime.datetime.combine(now.date(), NIGHTLY_UTC, tzinfo=datetime.timezone.utc)
|
|
return cron - NIGHTLY_LEAD, cron + NIGHTLY_GRACE
|
|
|
|
|
|
def parse_time(value):
|
|
return datetime.datetime.fromisoformat(value.replace("Z", "+00:00"))
|
|
|
|
|
|
class Api:
|
|
def __init__(self, token, url="https://api.github.com"):
|
|
self.token = token
|
|
self.url = url.rstrip("/")
|
|
|
|
def get(self, path, **params):
|
|
query = urllib.parse.urlencode(params)
|
|
request = urllib.request.Request(f"{self.url}/{path}?{query}", headers={
|
|
"Accept": "application/vnd.github+json",
|
|
"Authorization": f"Bearer {self.token}",
|
|
"X-GitHub-Api-Version": "2022-11-28",
|
|
})
|
|
with urllib.request.urlopen(request, timeout=30) as response:
|
|
return json.load(response)
|
|
|
|
|
|
def list_runs(api, repo, workflow, **params):
|
|
runs, page = [], 1
|
|
while True:
|
|
body = api.get(f"repos/{repo}/actions/workflows/{workflow}/runs",
|
|
per_page=100, page=page, **params)
|
|
runs += body["workflow_runs"]
|
|
if len(runs) >= body["total_count"] or not body["workflow_runs"]:
|
|
return runs
|
|
page += 1
|
|
|
|
|
|
def latest_run(api, repo, workflow, **params):
|
|
runs = api.get(f"repos/{repo}/actions/workflows/{workflow}/runs",
|
|
per_page=1, **params)["workflow_runs"]
|
|
return runs[0] if runs else None
|
|
|
|
|
|
def measure(api, repo, workflow, run_id, now, priority=False):
|
|
"""Total macOS runners held or needed, and one line per run that holds any.
|
|
The priority line does not count the priority runs waiting behind it."""
|
|
total, lines = 0, []
|
|
# A run is listed as queued whenever one of its jobs waits for a runner, and
|
|
# as pending whenever one waits in a concurrency group, so runs in any of these
|
|
# can hold runners. A run can move between the lists between the calls.
|
|
runs = {run["id"]: run for status in ("in_progress", "queued", "pending", "waiting")
|
|
for run in list_runs(api, repo, workflow, status=status)}
|
|
for run in runs.values():
|
|
jobs = api.get(f"repos/{repo}/actions/runs/{run['id']}/jobs",
|
|
filter="latest", per_page=100)["jobs"]
|
|
own = run["id"] == run_id
|
|
demand = run_demand(run, jobs, yield_to_priority=not priority and not own)
|
|
if demand:
|
|
total += demand
|
|
waiting = ", priority, waiting" if priority_waiting(jobs) and not own else ""
|
|
lines.append(f" {demand} run {run['id']} ({run['event']}, {run['head_branch']}{waiting})")
|
|
|
|
# build_all.yml runs the nightly only in the main repository.
|
|
start, end = nightly_window(now)
|
|
if repo == NIGHTLY_REPO and start <= now < end:
|
|
last = latest_run(api, repo, workflow, event="schedule")
|
|
if not last or parse_time(last["created_at"]) < start:
|
|
total += RESERVE
|
|
lines.append(f" {RESERVE} the nightly, due at {NIGHTLY_UTC:%H:%M} UTC")
|
|
return total, lines
|
|
|
|
|
|
def wait(measure_now, limit, wait_minutes, poll_seconds,
|
|
clock=time.monotonic, sleep=time.sleep, log=print):
|
|
"""Polls until this arch fits. Returns the reason it was let in."""
|
|
deadline = clock() + wait_minutes * 60
|
|
failures = 0
|
|
while True:
|
|
try:
|
|
total, lines = measure_now()
|
|
except (urllib.error.URLError, OSError, ValueError, KeyError, TypeError) as error:
|
|
failures += 1
|
|
log(f"::warning title=macOS admission::Could not read the queue ({error}).")
|
|
if failures >= FAILURES_BEFORE_ADMIT:
|
|
return "the queue could not be read"
|
|
else:
|
|
failures = 0
|
|
log(f"{total} of {limit} macOS runners held or needed:")
|
|
for line in lines:
|
|
log(line)
|
|
if total + 1 <= limit:
|
|
return "a runner is free"
|
|
if clock() + poll_seconds >= deadline:
|
|
return f"it waited {wait_minutes} minutes"
|
|
sleep(poll_seconds)
|
|
|
|
|
|
def main():
|
|
repo = os.environ["REPO"]
|
|
workflow = os.environ["WORKFLOW_REF"].split("@")[0].rsplit("/", 1)[-1]
|
|
api = Api(os.environ["GH_TOKEN"], os.environ.get("GITHUB_API_URL", "https://api.github.com"))
|
|
run_id = int(os.environ["GITHUB_RUN_ID"])
|
|
limit = int(os.environ.get("MACOS_RUNNER_LIMIT") or 5)
|
|
reason = wait(
|
|
lambda: measure(api, repo, workflow, run_id, datetime.datetime.now(datetime.timezone.utc),
|
|
priority=os.environ.get("PRIORITY") == "true"),
|
|
limit,
|
|
wait_minutes=int(os.environ.get("WAIT_MINUTES") or 240),
|
|
poll_seconds=int(os.environ.get("POLL_SECONDS") or 180),
|
|
)
|
|
print(f"Letting this macOS build in: {reason}.")
|
|
|
|
|
|
if __name__ == "__main__":
|
|
sys.exit(main())
|