mirror of
https://github.com/OrcaSlicer/OrcaSlicer.git
synced 2026-10-11 01:41:03 +00:00
Clifford GarwoodandClaude Opus 5
b6a2c76e5d
imex_wipe_tower_hull() open-coded "does this plate print a tower?" as one filament and no forcing reason. normalize_fdm_2, which is what actually clears enable_prime_tower before slicing, has a second arm the copy omitted, and reads the mixed-filament flag project-wide where the copy read the plate. Two cases went wrong in opposite directions. A ByObject plate with several objects prints no tower and the scene draws none, yet the copy validated one and could refuse the slice with "the prime tower overlaps an area reserved for IDEX/IQEX parallel printing" - with nothing on screen to move. A plate using one plain slot while some other slot in the project is a blend does print a tower, because normalize_fdm_2 keeps it for any mixed filament in the project, and the copy skipped validation entirely, so the tower could be placed in a carriage zone and sliced. prime_tower_is_printed() in libslic3r states the rule once, and both the gate and a test use it. The counts are the ones normalize_fdm_2 is handed: filament slots as authored, so a mixed slot counts once, and distinct objects rather than instances. filament_is_mixed is a project option, so it is passed in rather than read from the print preset. The test drives every combination the rule looks at and compares the verdict against normalize_fdm_2 itself, so the two cannot drift again without failing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
OrcaSlicer tests
Building, running and writing tests is documented on the wiki, under How to Test.
Two files here rather than there, because coding agents only read what is in the repository: