mirror of
https://github.com/OrcaSlicer/OrcaSlicer.git
synced 2026-09-24 09:23:27 +00:00
* fix: resolve MSVC compiler warnings and build error
C4101 - unreferenced local variables:
- STEP.cpp, FilamentGroup.cpp: remove unused catch variable 'e'
- GLGizmoMeasure.cpp: remove unused 'direction_on_model'
- PartPlate.cpp: remove unused 'origin1, origin2'
- DevStatus.cpp: suppress unused 'e' via (void)e
C4005 - macro redefinition:
- Wrap NOMINMAX defines in #ifndef guards (OrcaSlicer.cpp, Preset.cpp,
SupportTreeBuilder.cpp, OpenVDBUtils.cpp, GUI.cpp)
- Remove conflicting DESIGN_INPUT_SIZE redefine in DownloadProgressDialog.cpp
C4172 - return address of local/temporary:
- Config.cpp: return static const double instead of temporary 0
C4996 - deprecated API usage:
- ImGuiWrapper.cpp: use GetText().Length() instead of GetTextLength()
- OrcaCloudServiceAgent.cpp: replace deprecated wxPATH_NORM_ALL with
explicit flags matching old default behavior
- ASCIIFolding.cpp: replace deprecated std::wstring_convert/codecvt_utf8
with boost::locale::conv::utf_to_utf (already used in same function)
C2440 - build error from deprecated wxTipWindow constructor:
- Button.hpp/cpp: replace raw wxTipWindow* with wxTipWindow::Ref (weak
reference). Ref auto-nulls when the tip window closes, eliminating
the manual Bind(wxEVT_DESTROY) handler. delete uses operator->() to
access the raw pointer since Ref is non-owning
* fix: avoid duplicate GetText() call in ImGuiWrapper clipboard handler
Capture wxTextDataObject::GetText() result in a local variable instead
of calling it twice (for .Length() check and into_u8()). GetText()
returns wxString by value, so this avoids an extra allocation/copy.
* fix: resolve MSVC compiler warnings (code review fixes)
* fix: resolve MSVC compiler warnings (code review fixes)
34 lines
1.1 KiB
C++
34 lines
1.1 KiB
C++
#include "DevStatus.h"
|
|
#include "slic3r/GUI/DeviceManager.hpp"
|
|
#include <boost/log/trivial.hpp>
|
|
|
|
namespace Slic3r {
|
|
|
|
void DevStatus::ParseStatus(const nlohmann::json& print_jj)
|
|
{
|
|
try {
|
|
if (print_jj.contains("job")) {
|
|
const nlohmann::json& job_jj = print_jj.at("job");
|
|
if (job_jj.contains("job_state")) {
|
|
auto new_state = (DevJobState)job_jj.at("job_state").get<int>();
|
|
if (m_job_state != new_state) {
|
|
m_job_state = new_state;
|
|
BOOST_LOG_TRIVIAL(info) << __FUNCTION__ << ": job_state-> " << (int)new_state;
|
|
}
|
|
|
|
if (m_job_state == DevJobState::JobStateFinishing) {
|
|
m_job_state = DevJobState::JobStateFinish;
|
|
}
|
|
}
|
|
}
|
|
} catch (const std::exception& e) {
|
|
#if BBL_RELEASE_TO_PUBLIC
|
|
BOOST_LOG_TRIVIAL(error) << __FUNCTION__ << ": get exception";
|
|
#else
|
|
BOOST_LOG_TRIVIAL(error) << __FUNCTION__ << ": get exception=" << e.what();
|
|
#endif
|
|
(void)e; // suppress C4101 when BBL_RELEASE_TO_PUBLIC
|
|
}
|
|
}
|
|
|
|
} // namespace Slic3r
|