Kris Austin db29f570bd
build: clear 50 warnings - pessimizing moves and null checks that cannot fail ( #15408 ) ...
* build: remove std::move that blocks copy elision
std::move wrapped around a temporary, or around a local being returned,
stops the compiler constructing it in place. Each edit is the fix clang
suggests, which is to delete the std::move call and keep its argument.
Three of the 39 sites save a move, the two return std::move(local) in
Print.cpp and TreeSupport.cpp:2749. The rest are equivalent either way
and match how the codebase already writes this elsewhere.
Clears 39 -Wpessimizing-move warnings.
* build: drop null checks on references and this
A reference cannot be bound to null and this cannot be null, so the
compiler folds these conditions to true and drops the guard. Seven are
if (&bitmap && bitmap.IsOk()), where IsOk() already does the work; two
test this directly. The guarded code runs either way, so removing the
dead operand changes nothing.
Clears 11 -Wundefined-bool-conversion warnings.
2026-08-28 08:05:59 -03:00
2026-07-26 20:25:25 +08:00
2026-06-11 17:10:31 -03:00
2026-06-04 02:31:57 +08:00
2026-08-24 15:37:47 -03:00
2023-07-07 17:29:08 +08:00
2026-06-11 17:10:31 -03:00
2023-08-27 18:07:48 +08:00
2026-07-26 23:49:53 +08:00
2026-05-31 16:23:10 +08:00
2026-05-31 16:23:10 +08:00
2026-07-26 23:49:53 +08:00
2026-07-26 23:49:53 +08:00
2026-07-26 23:49:53 +08:00
2026-07-16 01:44:43 +08:00
2026-07-26 19:16:19 -03:00
2023-08-27 22:44:37 +08:00
2026-07-27 20:11:44 -03:00
2026-06-22 10:56:11 +08:00
2024-04-28 22:58:47 +08:00
2024-04-28 22:58:47 +08:00
2026-05-20 11:16:13 +00:00
2026-05-19 20:03:54 +00:00
2026-06-26 02:21:42 +08:00
2026-08-25 08:18:48 -03:00
2026-05-23 15:49:46 +00:00
2026-05-23 15:49:46 +00:00
2026-06-11 17:10:31 -03:00
2023-08-27 18:07:48 +08:00
2026-07-20 09:47:33 -03:00
2026-08-25 08:18:48 -03:00
2026-04-23 10:34:36 -03:00
2026-04-23 10:34:36 -03:00
2025-04-26 19:59:49 +08:00
2024-05-22 18:00:48 +08:00
2025-10-31 16:53:08 +08:00
2023-12-01 10:42:45 +00:00
2026-05-15 01:06:52 +08:00
2025-10-28 15:30:04 +08:00
2026-06-11 17:10:31 -03:00
2026-05-10 18:27:02 +08:00
2026-06-11 17:10:31 -03:00
2023-08-27 18:07:48 +08:00
2026-05-27 23:03:44 +08:00
2026-05-27 23:03:44 +08:00
2024-06-15 14:56:44 +08:00
2024-06-15 14:56:44 +08:00
2026-05-18 09:41:31 +02:00
2026-05-18 09:41:31 +02:00
2026-05-31 16:23:10 +08:00
2025-09-28 10:33:33 +08:00
2025-09-28 10:33:33 +08:00
2026-08-05 11:39:37 +08:00
2024-01-31 11:23:29 +00:00
2023-12-01 10:42:45 +00:00
2025-09-17 10:21:16 +08:00
2025-09-17 10:21:16 +08:00
2026-06-11 17:10:31 -03:00
2023-08-27 18:07:48 +08:00
2026-06-25 22:02:19 +08:00
2026-06-06 11:12:42 +08:00
2026-08-12 18:50:49 +08:00
2026-07-16 01:44:43 +08:00
2026-07-18 02:08:13 +08:00
2026-07-16 01:44:43 +08:00
2026-08-04 18:12:11 +08:00
2026-08-04 18:12:11 +08:00
2024-08-12 00:00:20 +08:00
2026-08-25 08:18:48 -03:00
2026-06-25 22:02:19 +08:00
2025-02-18 23:08:34 +08:00
2026-08-24 15:37:47 -03:00
2026-07-25 22:31:40 +08:00
2026-07-16 01:44:43 +08:00
2026-07-16 01:44:43 +08:00
2026-08-28 08:05:59 -03:00
2026-05-01 18:03:19 +08:00
2026-07-28 19:17:05 +08:00
2026-06-25 22:02:19 +08:00
2023-04-17 15:39:02 +08:00
2025-09-24 10:02:44 +08:00
2026-04-01 03:07:24 -05:00
2026-01-27 17:41:29 +08:00
2026-08-05 21:42:15 +08:00
2024-06-15 14:56:44 +08:00
2026-06-11 17:10:31 -03:00
2023-08-27 18:07:48 +08:00
2026-03-02 20:31:14 +08:00
2024-03-22 19:22:46 +08:00
2024-03-22 19:22:46 +08:00
2026-07-28 19:17:05 +08:00
2024-06-21 19:48:00 +08:00
2026-05-16 20:04:10 +08:00
2026-02-01 21:51:36 +08:00
2025-03-22 23:38:29 +08:00
2025-03-22 23:38:29 +08:00
2025-01-08 13:06:39 +08:00
2025-02-18 23:08:34 +08:00
2025-09-17 15:00:05 +08:00
2025-09-18 23:02:19 +08:00
Kris Austin
db29f570bd