Kris Austin
8bff9aaf32
fix(GUI): honor "Ignore" when layer height exceeds the configured maximum ( #14369 )
...
* fix(GUI): honor "Ignore" when layer height exceeds the configured maximum
Entering a layer height above the printer's max_layer_height on the Print
Settings tab fired two guards in sequence. Tab::on_value_change prompts
"...Adjust to the set range automatically?" with an Adjust/Ignore choice, and
ConfigManipulation::update_print_fff_config then showed an OK-only "Too large
layer height. Reset to X" dialog whose result was never checked, so it always
reset the value. The second guard overrode the user's "Ignore", resetting the
layer height regardless.
Changes:
- Extract the shared Adjust/Ignore dialog into
ConfigManipulation::layer_height_out_of_range_dialog, reused by the tab
(Tab::on_value_change) and the per-object/part settings panels. The dialog now
names the value it will clamp to and reads correctly for too-low as well as
too-high.
- The tab/plate path is already covered by Tab::on_value_change, so the
duplicate reset is dropped from update_print_fff_config.
- The per-object/part panels have no on_value_change hook, so add
ConfigManipulation::check_object_layer_height and call it from the object
settings update paths, gated on the edited option (changed_opt_key ==
"layer_height"). It prompts once per layer-height edit and does not re-prompt
when unrelated object settings change after the user chose "Ignore".
Fixes #14214
* refactor(GUI): unify the layer-height range check across tab and object panels
Copilot review of #14369 noted that the per-object check only guarded the
max at extruder 0 and skipped the too-low case, diverging from the tab.
Move the whole range check into ConfigManipulation::check_layer_height,
used by both Tab::on_value_change and the per-object/part panels. It takes
the widest [min, max] window across the printer's extruders, offers
Adjust/Ignore in both directions, and resets a near-zero value. The tab's
inline block collapses to one call, dropping the duplicated limit logic.
* fix(GUI): only enforce layer-height limits that are actually set
max_layer_height defaults to 0 (unset), so the unconditional range check
offered to clamp any layer height to 0 on presets that don't define it.
Guard each branch (near-zero, too-high, too-low) so an unset limit disables
that direction; the slice-time nozzle-diameter check still applies.
Also run check_layer_height before update_print_fff_config in the object
panels so a near-zero per-object value prompts the same way the tab does,
with update_print_fff_config's fallback still covering the no-minimum case.
2026-08-07 13:31:04 -03:00
..
2026-08-05 16:20:58 +08:00
2026-08-05 21:41:04 +08:00
2026-08-03 18:34:15 +08:00
2026-08-05 21:45:48 +08:00
2026-07-22 16:30:43 -03:00
2026-04-26 18:44:59 +08:00
2026-08-01 11:28:07 +08:00
2026-03-05 11:33:07 -03:00
2025-05-05 17:59:00 +08:00
2026-04-13 19:45:39 +08:00
2025-10-28 15:29:50 +08:00
2026-07-31 20:51:48 -03:00
2026-07-09 01:16:26 +08:00
2026-07-11 20:24:03 +03:00
2026-07-17 19:32:44 +08:00
2026-07-16 13:08:48 +08:00
2026-07-24 09:41:24 -03:00
2026-07-17 05:06:09 +08:00
2026-07-24 09:41:24 -03:00
2026-07-18 01:46:23 +08:00
2026-07-18 01:46:10 +08:00
2026-07-17 06:48:15 +08:00
2026-07-18 01:46:23 +08:00
2026-07-17 13:20:41 +08:00
2026-07-17 06:48:15 +08:00
2025-10-28 15:29:47 +08:00
2026-06-18 09:13:51 -03:00
2025-06-01 18:35:48 +08:00
2026-03-25 11:28:00 +08:00
2026-07-15 17:18:46 +08:00
2026-06-18 12:45:26 +08:00
2026-07-11 20:24:03 +03:00
2025-09-18 17:04:10 +08:00
2026-03-24 20:50:44 +08:00
2025-10-05 16:02:17 +08:00
2025-09-16 20:11:02 +08:00
2025-12-18 12:14:56 +00:00
2025-10-28 15:29:51 +08:00
2026-06-11 02:47:33 +08:00
2026-04-20 19:27:38 -03:00
2026-06-18 09:13:51 -03:00
2025-05-16 23:49:07 +08:00
2026-07-28 14:32:55 +08:00
2026-01-03 23:06:57 +08:00
2026-04-13 19:45:39 +08:00
2025-08-24 23:18:04 +08:00
2026-03-25 11:26:32 +08:00
2026-03-25 11:26:32 +08:00
2026-07-11 20:24:03 +03:00
2026-07-27 20:11:44 -03:00
2026-07-27 20:11:44 -03:00
2026-07-28 14:32:55 +08:00
2025-10-28 15:30:00 +08:00
2026-05-01 18:01:29 +08:00
2025-05-26 17:41:58 +08:00
2026-06-18 09:13:51 -03:00
2025-10-28 15:29:59 +08:00
2026-06-18 09:13:51 -03:00
2025-09-17 14:17:13 +08:00
2026-06-18 09:13:51 -03:00
2026-01-03 23:06:57 +08:00
2026-07-09 01:16:26 +08:00
2026-05-16 19:13:40 +08:00
2026-07-09 01:16:26 +08:00
2026-07-09 01:16:26 +08:00
2026-06-18 09:13:51 -03:00
2026-07-28 14:32:55 +08:00
2026-07-09 01:16:26 +08:00
2026-04-13 19:45:39 +08:00
2025-09-09 09:39:43 +08:00
2026-07-17 06:48:15 +08:00
2024-04-14 22:07:00 +08:00
2025-03-27 21:56:09 +08:00
2025-03-27 21:56:09 +08:00
2025-11-08 20:44:37 +08:00
2025-09-09 15:40:26 +08:00
2026-07-28 14:32:55 +08:00
2025-07-06 11:34:47 +08:00
2026-08-07 13:31:04 -03:00
2026-08-07 13:31:04 -03:00
2026-07-16 17:37:09 -03:00
2026-07-28 14:32:55 +08:00
2025-10-02 17:07:21 +08:00
2026-06-07 13:12:51 +08:00
2026-05-19 20:03:54 +00:00
2026-06-28 13:07:09 +08:00
2025-09-18 17:13:09 +08:00
2026-06-18 09:13:51 -03:00
2026-05-19 17:13:07 +08:00
2026-05-19 17:13:07 +08:00
2026-06-18 09:13:51 -03:00
2026-04-13 17:21:05 +08:00
2026-07-18 01:46:10 +08:00
2026-07-18 03:15:11 +08:00
2026-08-04 21:26:50 +08:00
2026-08-04 21:26:50 +08:00
2026-03-24 20:34:32 +08:00
2024-06-15 14:56:44 +08:00
2025-03-29 20:14:10 +08:00
2024-06-15 14:56:44 +08:00
2026-07-28 14:32:55 +08:00
2025-07-17 15:26:55 +08:00
2025-07-17 15:26:55 +08:00
2026-07-11 16:37:50 +08:00
2026-07-11 16:37:50 +08:00
2026-01-09 21:25:48 +08:00
2025-06-04 09:30:36 +08:00
2025-09-30 14:31:54 +08:00
2025-10-01 15:47:44 +08:00
2026-07-05 10:39:25 +08:00
2026-07-05 10:39:25 +08:00
2026-05-19 01:01:53 +08:00
2026-05-17 02:29:39 -05:00
2026-07-28 14:32:55 +08:00
2025-12-18 12:14:56 +00:00
2026-08-04 18:12:10 +08:00
2026-08-04 18:12:10 +08:00
2026-07-17 05:06:09 +08:00
2026-07-17 05:06:09 +08:00
2026-07-09 18:57:05 +08:00
2026-07-09 18:57:05 +08:00
2026-07-11 16:37:50 +08:00
2026-07-11 16:37:50 +08:00
2026-07-24 09:41:24 -03:00
2026-07-11 16:37:50 +08:00
2026-07-28 14:32:55 +08:00
2025-12-18 12:14:56 +00:00
2026-07-08 20:24:55 +08:00
2024-06-15 14:56:44 +08:00
2025-04-20 16:09:31 +08:00
2026-07-29 16:27:15 -03:00
2026-07-29 16:27:15 -03:00
2026-08-07 13:28:54 -03:00
2026-08-03 18:34:15 +08:00
2026-07-12 13:30:55 -03:00
2026-02-10 13:08:22 +08:00
2026-04-13 19:45:39 +08:00
2024-06-15 14:56:44 +08:00
2026-04-13 19:45:39 +08:00
2026-07-12 21:44:30 -03:00
2026-05-19 01:38:37 +08:00
2025-10-31 16:53:08 +08:00
2024-11-12 00:09:15 +08:00
2024-06-15 14:56:44 +08:00
2026-08-04 18:12:11 +08:00
2026-08-04 18:12:11 +08:00
2024-08-12 00:00:20 +08:00
2026-08-01 17:58:04 -03:00
2026-04-24 16:28:28 +08:00
2024-06-15 14:56:44 +08:00
2025-04-04 23:07:00 +08:00
2026-06-18 09:13:51 -03:00
2025-09-24 22:49:14 -04:00
2025-11-17 10:29:44 +08:00
2025-08-22 20:02:26 +08:00
2026-08-05 21:41:04 +08:00
2026-05-17 02:29:39 -05:00
2026-08-07 13:31:04 -03:00
2026-08-07 13:31:04 -03:00
2026-06-30 08:55:09 +08:00
2026-06-30 08:55:09 +08:00
2026-08-07 13:31:04 -03:00
2026-08-07 13:31:04 -03:00
2025-11-15 11:11:20 -05:00
2025-09-24 22:49:14 -04:00
2026-08-01 11:28:07 +08:00
2026-08-04 08:45:31 +08:00
2025-06-14 09:52:33 +08:00
2026-08-04 22:01:45 +08:00
2026-08-04 22:01:45 +08:00
2025-09-07 23:58:51 +08:00
2025-09-07 23:58:51 +08:00
2026-06-18 09:13:51 -03:00
2026-07-17 12:46:45 +08:00
2025-09-21 13:47:51 +08:00
2026-07-19 20:16:17 +08:00
2025-10-02 09:30:48 +08:00
2026-05-01 18:01:29 +08:00
2026-05-01 18:01:29 +08:00
2026-07-24 09:41:24 -03:00
2026-04-13 19:45:39 +08:00
2025-12-23 01:30:03 +08:00
2025-11-17 15:30:35 +00:00
2026-07-24 09:41:24 -03:00
2026-07-16 11:02:55 +08:00
2026-06-25 22:31:33 +08:00
2026-08-05 21:41:04 +08:00
2026-05-15 00:46:05 +08:00
2026-07-16 11:02:55 +08:00
2026-07-16 11:02:55 +08:00
2026-05-15 00:57:52 +08:00
2024-05-22 15:26:52 +08:00
2026-07-24 09:41:24 -03:00
2026-04-13 19:45:39 +08:00
2026-04-13 19:45:39 +08:00
2026-08-05 13:07:32 +08:00
2026-08-05 13:07:32 +08:00
2026-07-24 09:41:24 -03:00
2025-10-02 09:30:48 +08:00
2026-07-17 08:30:22 +08:00
2026-03-11 14:59:29 +08:00
2026-04-13 19:45:39 +08:00
2024-06-15 14:56:44 +08:00
2025-10-28 15:29:56 +08:00
2026-07-24 09:41:24 -03:00
2026-07-17 08:30:22 +08:00
2025-10-28 15:29:56 +08:00
2026-07-15 15:06:17 +08:00
2026-08-04 22:01:45 +08:00
2026-08-04 22:01:45 +08:00
2026-05-18 19:46:47 +08:00
2026-05-18 19:46:47 +08:00
2026-02-27 11:19:22 -03:00
2025-08-24 23:18:24 +08:00
2026-02-04 11:40:02 +00:00
2025-09-21 23:01:08 +08:00
2026-01-03 16:30:14 +08:00
2024-08-12 00:00:20 +08:00
2024-04-28 22:58:47 +08:00
2024-04-28 22:58:47 +08:00
2025-10-02 09:30:48 +08:00
2025-09-25 20:33:50 +08:00
2026-02-04 11:40:02 +00:00
2024-08-12 00:00:20 +08:00
2024-04-28 22:58:47 +08:00
2024-04-28 22:58:47 +08:00
2026-07-28 14:32:55 +08:00
2026-07-21 01:21:40 +03:00
2026-07-28 14:32:55 +08:00
2024-03-22 19:30:13 +08:00
2026-04-25 18:14:51 +08:00
2026-04-25 18:14:51 +08:00
2026-07-22 09:48:28 -03:00
2026-07-02 17:49:36 +08:00
2025-12-18 12:14:56 +00:00
2025-12-18 12:14:56 +00:00
2026-06-21 18:20:58 +08:00
2026-06-21 18:20:58 +08:00
2026-06-18 09:13:51 -03:00
2026-04-15 22:36:25 +08:00
2026-07-24 09:41:24 -03:00
2026-05-21 09:04:27 +08:00
2026-07-16 11:02:55 +08:00
2026-03-24 20:39:45 +08:00
2026-08-04 18:12:10 +08:00
2026-08-02 10:54:16 +08:00
2026-05-10 15:14:35 +08:00
2024-09-09 22:42:27 +08:00
2026-06-14 18:55:40 +08:00
2026-04-25 18:14:51 +08:00
2026-08-06 17:58:41 +08:00
2026-08-06 15:48:40 +08:00
2025-09-26 10:55:19 +08:00
2026-07-28 14:32:55 +08:00
2026-05-21 13:18:52 +03:00
2026-08-04 18:12:11 +08:00
2026-08-04 18:12:10 +08:00
2026-08-07 17:13:25 +08:00
2026-07-20 18:16:42 -03:00
2026-07-24 09:41:24 -03:00
2025-09-23 16:50:33 +08:00
2026-07-02 17:49:36 +08:00
2026-07-15 20:12:51 +08:00
2026-07-04 22:14:55 +08:00
2026-07-04 22:14:55 +08:00
2026-07-17 16:09:19 +08:00
2026-07-17 16:09:19 +08:00
2026-07-31 14:15:51 +08:00
2026-07-31 14:15:51 +08:00
2026-07-06 18:14:26 +08:00
2026-07-31 14:15:22 +08:00
2026-07-06 12:31:34 +08:00
2026-07-20 12:48:17 +08:00
2026-07-17 21:12:55 +08:00
2026-07-17 16:09:19 +08:00
2026-07-10 19:57:35 +08:00
2026-08-04 18:12:11 +08:00
2026-07-29 16:27:15 -03:00
2026-07-22 19:09:57 -03:00
2026-07-22 19:09:57 -03:00
2026-07-05 10:39:25 +08:00
2026-07-05 10:39:25 +08:00
2026-08-01 11:28:07 +08:00
2025-09-28 14:19:02 +08:00
2026-06-05 20:45:43 +08:00
2026-07-13 12:19:33 -03:00
2024-03-23 10:08:48 +08:00
2026-07-22 15:14:49 -03:00
2026-05-16 15:22:31 +08:00
2026-05-28 19:45:03 +08:00
2026-05-16 15:22:31 +08:00
2026-07-24 09:41:24 -03:00
2026-05-28 08:10:21 +00:00
2026-07-28 14:32:55 +08:00
2026-07-16 19:28:50 +08:00
2025-12-18 12:14:56 +00:00
2025-12-18 12:14:56 +00:00
2026-07-02 17:49:36 +08:00
2026-07-02 17:49:36 +08:00
2025-06-01 18:35:48 +08:00
2024-07-23 18:00:21 +08:00
2024-06-29 22:13:57 +08:00
2026-07-28 14:32:55 +08:00
2026-07-10 15:41:57 +08:00
2026-07-10 15:41:57 +08:00
2025-11-17 10:29:44 +08:00
2025-07-13 20:10:42 +08:00
2025-12-18 12:14:56 +00:00
2025-12-18 12:14:56 +00:00
2026-07-17 16:25:10 +08:00
2026-02-11 16:00:04 +08:00
2025-01-07 23:25:32 +08:00
2026-03-03 17:36:42 -03:00
2025-10-28 15:29:54 +08:00
2026-08-06 22:58:39 +08:00
2026-08-06 22:58:39 +08:00
2025-10-14 08:56:18 +08:00
2025-10-14 08:56:18 +08:00
2026-05-22 10:46:29 +08:00
2026-05-21 09:04:26 +08:00
2026-08-06 15:48:40 +08:00
2026-06-18 09:13:51 -03:00
2026-08-05 21:41:04 +08:00
2026-07-22 19:09:57 -03:00
2026-07-17 10:20:24 +08:00
2026-01-03 23:06:57 +08:00
2026-06-18 09:13:51 -03:00
2026-01-23 17:05:56 +08:00
2026-04-13 19:45:39 +08:00
2026-07-18 01:46:23 +08:00
2026-01-03 23:06:57 +08:00
2025-06-14 10:27:10 +08:00
2025-06-14 10:27:10 +08:00
2026-04-13 19:45:39 +08:00
2025-09-26 14:35:06 +08:00
2025-08-24 23:18:24 +08:00
2026-06-18 09:13:51 -03:00
2026-07-17 22:37:56 +08:00
2026-07-17 22:37:56 +08:00
2026-07-24 09:41:24 -03:00
2026-07-17 09:41:01 +08:00
2026-07-28 14:32:55 +08:00
2026-07-03 17:19:24 -03:00
2025-02-26 23:07:23 +08:00
2026-07-24 09:41:24 -03:00
2026-07-17 06:48:15 +08:00
2026-03-24 20:50:44 +08:00
2026-08-07 13:31:04 -03:00
2026-08-04 18:12:11 +08:00
2026-02-04 11:40:02 +00:00
2025-12-14 14:26:16 +01:00
2026-03-25 15:58:39 +08:00
2025-09-16 21:21:40 +08:00
2026-01-23 17:05:56 +08:00
2026-01-23 17:05:56 +08:00
2026-07-02 17:49:36 +08:00
2026-07-02 17:49:36 +08:00
2026-04-13 19:45:39 +08:00
2025-10-28 15:30:06 +08:00
2025-10-28 15:30:06 +08:00
2026-07-28 14:32:55 +08:00
2026-07-28 14:32:55 +08:00
2026-07-28 14:32:55 +08:00
2026-05-21 09:04:26 +08:00
2026-07-28 14:32:55 +08:00
2026-07-19 20:16:17 +08:00
2026-07-17 09:41:01 +08:00
2026-05-01 18:01:29 +08:00
2024-04-28 22:58:47 +08:00
2024-04-28 22:58:47 +08:00
2024-04-28 22:58:47 +08:00
2025-10-28 15:29:56 +08:00
2026-06-26 18:37:33 +08:00
2026-04-24 13:54:09 +08:00
2026-07-13 12:19:33 -03:00
2026-05-01 18:01:29 +08:00
2026-07-24 09:41:24 -03:00
2026-05-01 18:01:29 +08:00
2026-05-21 11:42:18 +08:00
2025-10-28 15:29:58 +08:00
2026-08-01 11:28:07 +08:00
2026-04-25 18:14:51 +08:00
2026-03-24 20:44:32 +08:00
2026-07-26 22:15:53 +08:00
2026-05-13 00:01:10 +08:00
2025-05-26 14:43:32 +08:00