mirror of
https://github.com/OrcaSlicer/OrcaSlicer.git
synced 2026-10-04 14:20:58 +00:00
HanifKoh
84657ff11e
* Ignore Clipper, libpng, mcut and Boost.Polygon Internals in clang-tidy Each only works through a wrapper or umbrella header: libslic3r/clipper.hpp or clipper_z.hpp configure Clipper before including it, png.h pulls in libpng's config headers, and Boost.Polygon's headers only compile through polygon.hpp or voronoi.hpp. * Ignore minilzo's Config Headers in clang-tidy lzoconf.h and lzodefs.h are internal to minilzo.h, which is what the code includes. * Add Missing Includes Across the Remaining Sources and Tests Covers src/slic3r/Utils, src/slic3r/plugin, src/slic3r/Config, src/libvgcode, src/dev-utils, src/OrcaSlicer.cpp and tests/, the directories left after src/slic3r/GUI and src/libslic3r. Generated with clang-tidy misc-include-cleaner. libvgcode's own headers are included by relative path as in the rest of that library, and Catch2 and pybind11 with angle brackets as elsewhere in the repo. * Make the GUI and Test Headers Compile on Their Own Each now includes, or forward-declares, what it uses instead of relying on what its includers happened to include first. Headers that only compile on one platform, or that nothing built includes, are left alone. * Keep Windows and nanosvg Setup Ahead of the Added Includes OrcaSlicer.cpp and several tests set _WIN32_WINNT, WIN32_LEAN_AND_MEAN or NOMINMAX before including Windows.h, and the profile validator defines NANOSVG_IMPLEMENTATION before any libslic3r header. The added includes had landed above those blocks, which broke the Windows build. * Add the GUI Includes the First Pass Missed Covers headers that only became editable once they compiled on their own, and wx symbols whose suggested header changed as the clang-tidy ignore list grew after the src/slic3r/GUI pass. * Keep the Added Test Includes Below the NOMINMAX Guard test_marchingsquares.cpp and test_texture_displacement.cpp had includes inside #ifndef NOMINMAX, which the tests inherit as defined on Windows from libslic3r, so those were skipped there. .clang-tidy also ignores the MSVC STL and UCRT internals, Boost.Multiprecision's fwd.hpp and CPython's Windows include directory, as in #16068.
66 lines
3.1 KiB
C++
66 lines
3.1 KiB
C++
#include <catch2/catch_all.hpp>
|
|
|
|
#include <catch2/catch_test_macros.hpp>
|
|
#include "libslic3r/Model.hpp"
|
|
#include "libslic3r/TriangleMesh.hpp"
|
|
#include <pybind11/gil.h>
|
|
#include <pybind11/pytypes.h>
|
|
#include <pybind11/cast.h>
|
|
#include "python_test_support.hpp"
|
|
|
|
#include <pybind11/embed.h>
|
|
#include <array>
|
|
|
|
namespace py = pybind11;
|
|
using namespace Slic3r;
|
|
|
|
TEST_CASE("Python exposes every seam mode and distinguishes strong weak and ordinary volumes", "[PreciseSeamPlugin][Python]")
|
|
{
|
|
struct Mode {
|
|
const char *name;
|
|
ModelVolumeType type;
|
|
bool strong;
|
|
bool weak;
|
|
};
|
|
// Explicit expectations protect enum registration and both predicate groups independently.
|
|
const std::array<Mode, 11> modes = {{
|
|
{"PreciseSeamCenter", ModelVolumeType::PRECISE_SEAM_CENTER, true, false},
|
|
{"PreciseSeamLeft", ModelVolumeType::PRECISE_SEAM_LEFT, true, false},
|
|
{"PreciseSeamRight", ModelVolumeType::PRECISE_SEAM_RIGHT, true, false},
|
|
{"PreciseSeamEnforced", ModelVolumeType::PRECISE_SEAM_ENFORCED, false, true},
|
|
{"PreciseSeamBlocked", ModelVolumeType::PRECISE_SEAM_BLOCKED, false, true},
|
|
{"PreciseSeamNeutral", ModelVolumeType::PRECISE_SEAM_NEUTRAL, false, true},
|
|
{"ModelPart", ModelVolumeType::MODEL_PART, false, false},
|
|
{"NegativeVolume", ModelVolumeType::NEGATIVE_VOLUME, false, false},
|
|
{"ParameterModifier", ModelVolumeType::PARAMETER_MODIFIER, false, false},
|
|
{"SupportEnforcer", ModelVolumeType::SUPPORT_ENFORCER, false, false},
|
|
{"SupportBlocker", ModelVolumeType::SUPPORT_BLOCKER, false, false}
|
|
}};
|
|
|
|
// Bootstrap holds the GIL on first initialization; acquire explicitly for an already-running interpreter too.
|
|
ensure_python_initialized();
|
|
py::gil_scoped_acquire gil;
|
|
py::object host = import_orca_module().attr("host");
|
|
REQUIRE(py::hasattr(host, "ModelVolumeType"));
|
|
py::object enumeration = host.attr("ModelVolumeType");
|
|
for (const Mode &mode : modes) {
|
|
DYNAMIC_SECTION(mode.name) {
|
|
REQUIRE(py::hasattr(enumeration, mode.name));
|
|
CHECK(enumeration.attr(mode.name).cast<ModelVolumeType>() == mode.type);
|
|
Model model;
|
|
auto *volume = model.add_object()->add_volume(make_cube(1, 1, 1));
|
|
volume->set_type(mode.type);
|
|
// Borrow the volume: the Python reference is destroyed before its owning Model.
|
|
py::object py_volume = py::cast(volume, py::return_value_policy::reference);
|
|
REQUIRE(py::hasattr(py_volume, "is_precise_seam"));
|
|
REQUIRE(py::hasattr(py_volume, "is_precise_seam_strong"));
|
|
REQUIRE(py::hasattr(py_volume, "is_precise_seam_weak"));
|
|
CHECK(py_volume.attr("type")().cast<ModelVolumeType>() == mode.type);
|
|
const bool precise = mode.strong || mode.weak;
|
|
CHECK(py_volume.attr("is_precise_seam")().cast<bool>() == precise);
|
|
CHECK(py_volume.attr("is_precise_seam_strong")().cast<bool>() == mode.strong);
|
|
CHECK(py_volume.attr("is_precise_seam_weak")().cast<bool>() == mode.weak);
|
|
}
|
|
}
|
|
}
|