mirror of
https://github.com/OrcaSlicer/OrcaSlicer.git
synced 2026-10-04 14:20:58 +00:00
HanifKoh
84657ff11e
* Ignore Clipper, libpng, mcut and Boost.Polygon Internals in clang-tidy Each only works through a wrapper or umbrella header: libslic3r/clipper.hpp or clipper_z.hpp configure Clipper before including it, png.h pulls in libpng's config headers, and Boost.Polygon's headers only compile through polygon.hpp or voronoi.hpp. * Ignore minilzo's Config Headers in clang-tidy lzoconf.h and lzodefs.h are internal to minilzo.h, which is what the code includes. * Add Missing Includes Across the Remaining Sources and Tests Covers src/slic3r/Utils, src/slic3r/plugin, src/slic3r/Config, src/libvgcode, src/dev-utils, src/OrcaSlicer.cpp and tests/, the directories left after src/slic3r/GUI and src/libslic3r. Generated with clang-tidy misc-include-cleaner. libvgcode's own headers are included by relative path as in the rest of that library, and Catch2 and pybind11 with angle brackets as elsewhere in the repo. * Make the GUI and Test Headers Compile on Their Own Each now includes, or forward-declares, what it uses instead of relying on what its includers happened to include first. Headers that only compile on one platform, or that nothing built includes, are left alone. * Keep Windows and nanosvg Setup Ahead of the Added Includes OrcaSlicer.cpp and several tests set _WIN32_WINNT, WIN32_LEAN_AND_MEAN or NOMINMAX before including Windows.h, and the profile validator defines NANOSVG_IMPLEMENTATION before any libslic3r header. The added includes had landed above those blocks, which broke the Windows build. * Add the GUI Includes the First Pass Missed Covers headers that only became editable once they compiled on their own, and wx symbols whose suggested header changed as the clang-tidy ignore list grew after the src/slic3r/GUI pass. * Keep the Added Test Includes Below the NOMINMAX Guard test_marchingsquares.cpp and test_texture_displacement.cpp had includes inside #ifndef NOMINMAX, which the tests inherit as defined on Windows from libslic3r, so those were skipped there. .clang-tidy also ignores the MSVC STL and UCRT internals, Boost.Multiprecision's fwd.hpp and CPython's Windows include directory, as in #16068.
102 lines
3.8 KiB
C++
102 lines
3.8 KiB
C++
#include <catch2/catch_all.hpp>
|
|
|
|
#include <catch2/catch_test_macros.hpp>
|
|
#include "slic3r/Utils/bambu_networking.hpp"
|
|
|
|
using namespace Slic3r;
|
|
|
|
TEST_CASE("extract_base_version", "[BambuNetworking]") {
|
|
SECTION("version without suffix returns unchanged") {
|
|
REQUIRE(extract_base_version("02.03.00.62") == "02.03.00.62");
|
|
REQUIRE(extract_base_version("01.00.00.00") == "01.00.00.00");
|
|
}
|
|
|
|
SECTION("version with suffix returns base only") {
|
|
REQUIRE(extract_base_version("02.03.00.62-mod") == "02.03.00.62");
|
|
REQUIRE(extract_base_version("02.03.00.62-patched") == "02.03.00.62");
|
|
REQUIRE(extract_base_version("02.03.00.62-test-build") == "02.03.00.62");
|
|
}
|
|
|
|
SECTION("empty string returns empty") {
|
|
REQUIRE(extract_base_version("") == "");
|
|
}
|
|
|
|
SECTION("suffix only returns empty") {
|
|
REQUIRE(extract_base_version("-mod") == "");
|
|
}
|
|
}
|
|
|
|
TEST_CASE("extract_suffix", "[BambuNetworking]") {
|
|
SECTION("version without suffix returns empty") {
|
|
REQUIRE(extract_suffix("02.03.00.62") == "");
|
|
REQUIRE(extract_suffix("01.00.00.00") == "");
|
|
}
|
|
|
|
SECTION("version with suffix returns suffix without dash") {
|
|
REQUIRE(extract_suffix("02.03.00.62-mod") == "mod");
|
|
REQUIRE(extract_suffix("02.03.00.62-patched") == "patched");
|
|
}
|
|
|
|
SECTION("version with multiple dashes returns everything after first dash") {
|
|
REQUIRE(extract_suffix("02.03.00.62-test-build") == "test-build");
|
|
}
|
|
|
|
SECTION("empty string returns empty") {
|
|
REQUIRE(extract_suffix("") == "");
|
|
}
|
|
|
|
SECTION("suffix only returns suffix without leading dash") {
|
|
REQUIRE(extract_suffix("-mod") == "mod");
|
|
}
|
|
}
|
|
|
|
TEST_CASE("NetworkLibraryVersionInfo::from_static", "[BambuNetworking]") {
|
|
SECTION("converts static version info correctly") {
|
|
NetworkLibraryVersion static_ver{"02.03.00.62", "02.03.00.62", nullptr, true, nullptr};
|
|
auto info = NetworkLibraryVersionInfo::from_static(static_ver);
|
|
|
|
REQUIRE(info.version == "02.03.00.62");
|
|
REQUIRE(info.base_version == "02.03.00.62");
|
|
REQUIRE(info.suffix == "");
|
|
REQUIRE(info.display_name == "02.03.00.62");
|
|
REQUIRE(info.url_override == "");
|
|
// from_static no longer propagates the static is_latest flag; it is a placeholder
|
|
// that get_all_available_versions() assigns once the list is sorted newest-first.
|
|
REQUIRE(info.is_latest == false);
|
|
REQUIRE(info.warning == "");
|
|
REQUIRE(info.is_discovered == false);
|
|
}
|
|
|
|
SECTION("handles version with warning") {
|
|
NetworkLibraryVersion static_ver{"02.00.02.50", "02.00.02.50", nullptr, false, "This is a warning"};
|
|
auto info = NetworkLibraryVersionInfo::from_static(static_ver);
|
|
|
|
REQUIRE(info.version == "02.00.02.50");
|
|
REQUIRE(info.is_latest == false);
|
|
REQUIRE(info.warning == "This is a warning");
|
|
REQUIRE(info.is_discovered == false);
|
|
}
|
|
|
|
SECTION("handles version with url override") {
|
|
NetworkLibraryVersion static_ver{"02.01.01.52", "02.01.01.52", "https://custom.url/plugin.zip", false, nullptr};
|
|
auto info = NetworkLibraryVersionInfo::from_static(static_ver);
|
|
|
|
REQUIRE(info.url_override == "https://custom.url/plugin.zip");
|
|
}
|
|
}
|
|
|
|
TEST_CASE("NetworkLibraryVersionInfo::from_discovered", "[BambuNetworking]") {
|
|
SECTION("creates discovered version info correctly") {
|
|
auto info = NetworkLibraryVersionInfo::from_discovered("02.03.00.62-mod", "02.03.00.62", "mod");
|
|
|
|
REQUIRE(info.version == "02.03.00.62-mod");
|
|
REQUIRE(info.base_version == "02.03.00.62");
|
|
REQUIRE(info.suffix == "mod");
|
|
REQUIRE(info.display_name == "02.03.00.62-mod");
|
|
REQUIRE(info.url_override == "");
|
|
REQUIRE(info.is_latest == false);
|
|
REQUIRE(info.warning == "");
|
|
REQUIRE(info.is_discovered == true);
|
|
}
|
|
}
|