mirror of
https://github.com/OrcaSlicer/OrcaSlicer.git
synced 2026-10-04 06:11:02 +00:00
HanifKoh
84657ff11e
* Ignore Clipper, libpng, mcut and Boost.Polygon Internals in clang-tidy Each only works through a wrapper or umbrella header: libslic3r/clipper.hpp or clipper_z.hpp configure Clipper before including it, png.h pulls in libpng's config headers, and Boost.Polygon's headers only compile through polygon.hpp or voronoi.hpp. * Ignore minilzo's Config Headers in clang-tidy lzoconf.h and lzodefs.h are internal to minilzo.h, which is what the code includes. * Add Missing Includes Across the Remaining Sources and Tests Covers src/slic3r/Utils, src/slic3r/plugin, src/slic3r/Config, src/libvgcode, src/dev-utils, src/OrcaSlicer.cpp and tests/, the directories left after src/slic3r/GUI and src/libslic3r. Generated with clang-tidy misc-include-cleaner. libvgcode's own headers are included by relative path as in the rest of that library, and Catch2 and pybind11 with angle brackets as elsewhere in the repo. * Make the GUI and Test Headers Compile on Their Own Each now includes, or forward-declares, what it uses instead of relying on what its includers happened to include first. Headers that only compile on one platform, or that nothing built includes, are left alone. * Keep Windows and nanosvg Setup Ahead of the Added Includes OrcaSlicer.cpp and several tests set _WIN32_WINNT, WIN32_LEAN_AND_MEAN or NOMINMAX before including Windows.h, and the profile validator defines NANOSVG_IMPLEMENTATION before any libslic3r header. The added includes had landed above those blocks, which broke the Windows build. * Add the GUI Includes the First Pass Missed Covers headers that only became editable once they compiled on their own, and wx symbols whose suggested header changed as the clang-tidy ignore list grew after the src/slic3r/GUI pass. * Keep the Added Test Includes Below the NOMINMAX Guard test_marchingsquares.cpp and test_texture_displacement.cpp had includes inside #ifndef NOMINMAX, which the tests inherit as defined on Windows from libslic3r, so those were skipped there. .clang-tidy also ignores the MSVC STL and UCRT internals, Boost.Multiprecision's fwd.hpp and CPython's Windows include directory, as in #16068.
46 lines
1.7 KiB
C++
46 lines
1.7 KiB
C++
#include <catch2/catch_all.hpp>
|
|
#include "libslic3r/TriangleMesh.hpp"
|
|
#include "libslic3r/Polygon.hpp"
|
|
#include "libslic3r/BoundingBox.hpp"
|
|
#include "libslic3r/Point.hpp"
|
|
|
|
#include <catch2/catch_test_macros.hpp>
|
|
#include "libslic3r/Model.hpp"
|
|
|
|
using namespace Slic3r;
|
|
|
|
// convex_hull_2d does not clip geometry below the bed, so these cases avoid
|
|
// sinking transforms.
|
|
TEST_CASE("A part's 2D convex hull is its footprint projected onto the bed", "[Model]")
|
|
{
|
|
Model model;
|
|
ModelObject* object = model.add_object();
|
|
// Keep the cube's raw coordinates ([0,20] on every axis): the default
|
|
// add_volume re-centers the geometry, which would move the footprint.
|
|
object->add_volume(make_cube(20, 20, 20), ModelVolumeType::MODEL_PART, false);
|
|
|
|
SECTION("identity transform yields the 20 mm square") {
|
|
const Polygon hull = object->convex_hull_2d(Geometry::Transformation{}.get_matrix());
|
|
const BoundingBox bb = hull.bounding_box();
|
|
CHECK(hull.size() == 4);
|
|
CHECK(bb.min.x() == scaled(0.));
|
|
CHECK(bb.min.y() == scaled(0.));
|
|
CHECK(bb.max.x() == scaled(20.));
|
|
CHECK(bb.max.y() == scaled(20.));
|
|
}
|
|
|
|
SECTION("scaling and offset move and grow the footprint") {
|
|
Geometry::Transformation t;
|
|
t.set_scaling_factor({2, 2, 2}); // cube now spans [0,40]
|
|
t.set_offset({10, 5, 0}); // then shift +10 in X, +5 in Y
|
|
|
|
const Polygon hull = object->convex_hull_2d(t.get_matrix());
|
|
const BoundingBox bb = hull.bounding_box();
|
|
CHECK(hull.size() == 4);
|
|
CHECK(bb.min.x() == scaled(10.));
|
|
CHECK(bb.min.y() == scaled(5.));
|
|
CHECK(bb.max.x() == scaled(50.));
|
|
CHECK(bb.max.y() == scaled(45.));
|
|
}
|
|
}
|