mirror of
https://github.com/OrcaSlicer/OrcaSlicer.git
synced 2026-10-04 06:11:02 +00:00
HanifKoh
84657ff11e
* Ignore Clipper, libpng, mcut and Boost.Polygon Internals in clang-tidy Each only works through a wrapper or umbrella header: libslic3r/clipper.hpp or clipper_z.hpp configure Clipper before including it, png.h pulls in libpng's config headers, and Boost.Polygon's headers only compile through polygon.hpp or voronoi.hpp. * Ignore minilzo's Config Headers in clang-tidy lzoconf.h and lzodefs.h are internal to minilzo.h, which is what the code includes. * Add Missing Includes Across the Remaining Sources and Tests Covers src/slic3r/Utils, src/slic3r/plugin, src/slic3r/Config, src/libvgcode, src/dev-utils, src/OrcaSlicer.cpp and tests/, the directories left after src/slic3r/GUI and src/libslic3r. Generated with clang-tidy misc-include-cleaner. libvgcode's own headers are included by relative path as in the rest of that library, and Catch2 and pybind11 with angle brackets as elsewhere in the repo. * Make the GUI and Test Headers Compile on Their Own Each now includes, or forward-declares, what it uses instead of relying on what its includers happened to include first. Headers that only compile on one platform, or that nothing built includes, are left alone. * Keep Windows and nanosvg Setup Ahead of the Added Includes OrcaSlicer.cpp and several tests set _WIN32_WINNT, WIN32_LEAN_AND_MEAN or NOMINMAX before including Windows.h, and the profile validator defines NANOSVG_IMPLEMENTATION before any libslic3r header. The added includes had landed above those blocks, which broke the Windows build. * Add the GUI Includes the First Pass Missed Covers headers that only became editable once they compiled on their own, and wx symbols whose suggested header changed as the clang-tidy ignore list grew after the src/slic3r/GUI pass. * Keep the Added Test Includes Below the NOMINMAX Guard test_marchingsquares.cpp and test_texture_displacement.cpp had includes inside #ifndef NOMINMAX, which the tests inherit as defined on Windows from libslic3r, so those were skipped there. .clang-tidy also ignores the MSVC STL and UCRT internals, Boost.Multiprecision's fwd.hpp and CPython's Windows include directory, as in #16068.
71 lines
2.5 KiB
C++
71 lines
2.5 KiB
C++
#include <catch2/catch_all.hpp>
|
|
|
|
#include <algorithm>
|
|
#include <vector>
|
|
#include <cstddef>
|
|
|
|
#include <catch2/catch_test_macros.hpp>
|
|
#include <catch2/catch_message.hpp>
|
|
#include "libslic3r/MinimumSpanningTree.hpp"
|
|
#include "libslic3r/Point.hpp"
|
|
|
|
using namespace Slic3r;
|
|
|
|
// A 5x5 lattice: at every step of Prim's algorithm several candidates sit at the same
|
|
// distance from the tree, so the tie-break decides the tree's shape.
|
|
static std::vector<Point> lattice()
|
|
{
|
|
std::vector<Point> vertices;
|
|
for (int y = 0; y < 5; ++y)
|
|
for (int x = 0; x < 5; ++x)
|
|
vertices.emplace_back(Point::new_scale(x, y));
|
|
return vertices;
|
|
}
|
|
|
|
static std::vector<Point> sorted_neighbours(const MinimumSpanningTree &mst, const Point &vertex)
|
|
{
|
|
std::vector<Point> neighbours = mst.adjacent_nodes(vertex);
|
|
std::sort(neighbours.begin(), neighbours.end());
|
|
return neighbours;
|
|
}
|
|
|
|
TEST_CASE("Minimum spanning tree connects every vertex", "[MinimumSpanningTree]")
|
|
{
|
|
const std::vector<Point> vertices = lattice();
|
|
const MinimumSpanningTree mst(vertices);
|
|
|
|
REQUIRE(mst.vertices().size() == vertices.size());
|
|
size_t adjacency_entries = 0;
|
|
for (const Point &vertex : vertices) {
|
|
const std::vector<Point> neighbours = mst.adjacent_nodes(vertex);
|
|
REQUIRE(! neighbours.empty());
|
|
adjacency_entries += neighbours.size();
|
|
}
|
|
// A tree on n vertices has n - 1 edges, each listed from both ends.
|
|
REQUIRE(adjacency_entries == 2 * (vertices.size() - 1));
|
|
}
|
|
|
|
TEST_CASE("Minimum spanning tree does not depend on the order of the non-root vertices", "[MinimumSpanningTree][Regression]")
|
|
{
|
|
const std::vector<Point> vertices = lattice();
|
|
const MinimumSpanningTree reference(vertices);
|
|
|
|
// The root stays first: Prim's tree legitimately depends on where it starts.
|
|
// Every other order of the remaining vertices must give the same tree.
|
|
std::vector<std::vector<Point>> orders;
|
|
orders.emplace_back(vertices);
|
|
std::reverse(orders.back().begin() + 1, orders.back().end());
|
|
for (size_t shift = 1; shift + 1 < vertices.size(); ++shift) {
|
|
orders.emplace_back(vertices);
|
|
std::rotate(orders.back().begin() + 1, orders.back().begin() + 1 + shift, orders.back().end());
|
|
}
|
|
|
|
for (const std::vector<Point> &order : orders) {
|
|
const MinimumSpanningTree mst(order);
|
|
for (const Point &vertex : vertices) {
|
|
INFO("vertex " << vertex.x() << "," << vertex.y());
|
|
REQUIRE(sorted_neighbours(mst, vertex) == sorted_neighbours(reference, vertex));
|
|
}
|
|
}
|
|
}
|