mirror of
https://github.com/OrcaSlicer/OrcaSlicer.git
synced 2026-10-04 14:20:58 +00:00
HanifKoh
84657ff11e
* Ignore Clipper, libpng, mcut and Boost.Polygon Internals in clang-tidy Each only works through a wrapper or umbrella header: libslic3r/clipper.hpp or clipper_z.hpp configure Clipper before including it, png.h pulls in libpng's config headers, and Boost.Polygon's headers only compile through polygon.hpp or voronoi.hpp. * Ignore minilzo's Config Headers in clang-tidy lzoconf.h and lzodefs.h are internal to minilzo.h, which is what the code includes. * Add Missing Includes Across the Remaining Sources and Tests Covers src/slic3r/Utils, src/slic3r/plugin, src/slic3r/Config, src/libvgcode, src/dev-utils, src/OrcaSlicer.cpp and tests/, the directories left after src/slic3r/GUI and src/libslic3r. Generated with clang-tidy misc-include-cleaner. libvgcode's own headers are included by relative path as in the rest of that library, and Catch2 and pybind11 with angle brackets as elsewhere in the repo. * Make the GUI and Test Headers Compile on Their Own Each now includes, or forward-declares, what it uses instead of relying on what its includers happened to include first. Headers that only compile on one platform, or that nothing built includes, are left alone. * Keep Windows and nanosvg Setup Ahead of the Added Includes OrcaSlicer.cpp and several tests set _WIN32_WINNT, WIN32_LEAN_AND_MEAN or NOMINMAX before including Windows.h, and the profile validator defines NANOSVG_IMPLEMENTATION before any libslic3r header. The added includes had landed above those blocks, which broke the Windows build. * Add the GUI Includes the First Pass Missed Covers headers that only became editable once they compiled on their own, and wx symbols whose suggested header changed as the clang-tidy ignore list grew after the src/slic3r/GUI pass. * Keep the Added Test Includes Below the NOMINMAX Guard test_marchingsquares.cpp and test_texture_displacement.cpp had includes inside #ifndef NOMINMAX, which the tests inherit as defined on Windows from libslic3r, so those were skipped there. .clang-tidy also ignores the MSVC STL and UCRT internals, Boost.Multiprecision's fwd.hpp and CPython's Windows include directory, as in #16068.
85 lines
2.9 KiB
C++
85 lines
2.9 KiB
C++
#include <catch2/catch_all.hpp>
|
|
|
|
#include <catch2/catch_test_macros.hpp>
|
|
#include "libslic3r/AppConfig.hpp"
|
|
|
|
using namespace Slic3r;
|
|
|
|
TEST_CASE("AppConfig network version helpers", "[AppConfig]") {
|
|
AppConfig config;
|
|
|
|
SECTION("skipped versions starts empty") {
|
|
auto skipped = config.get_skipped_network_versions();
|
|
REQUIRE(skipped.empty());
|
|
}
|
|
|
|
SECTION("add and check skipped version") {
|
|
config.add_skipped_network_version("02.01.01.52");
|
|
REQUIRE(config.is_network_version_skipped("02.01.01.52"));
|
|
REQUIRE_FALSE(config.is_network_version_skipped("02.03.00.62"));
|
|
}
|
|
|
|
SECTION("multiple skipped versions") {
|
|
config.add_skipped_network_version("02.01.01.52");
|
|
config.add_skipped_network_version("02.00.02.50");
|
|
|
|
auto skipped = config.get_skipped_network_versions();
|
|
REQUIRE(skipped.size() == 2);
|
|
REQUIRE(config.is_network_version_skipped("02.01.01.52"));
|
|
REQUIRE(config.is_network_version_skipped("02.00.02.50"));
|
|
}
|
|
|
|
SECTION("clear skipped versions") {
|
|
config.add_skipped_network_version("02.01.01.52");
|
|
config.clear_skipped_network_versions();
|
|
REQUIRE_FALSE(config.is_network_version_skipped("02.01.01.52"));
|
|
}
|
|
|
|
SECTION("duplicate add is idempotent") {
|
|
config.add_skipped_network_version("02.01.01.52");
|
|
config.add_skipped_network_version("02.01.01.52");
|
|
|
|
auto skipped = config.get_skipped_network_versions();
|
|
REQUIRE(skipped.size() == 1);
|
|
REQUIRE(config.is_network_version_skipped("02.01.01.52"));
|
|
}
|
|
}
|
|
|
|
TEST_CASE("AppConfig Speed Dial recent count defaults, clamps and parses", "[AppConfig]") {
|
|
AppConfig config;
|
|
|
|
SECTION("unset falls back to the default") {
|
|
REQUIRE(config.get_speed_dial_recent_count() == SPEED_DIAL_RECENT_COUNT_DEFAULT);
|
|
}
|
|
|
|
SECTION("zero disables recents") {
|
|
config.set(SETTING_SPEED_DIAL_RECENT_COUNT, "0");
|
|
REQUIRE(config.get_speed_dial_recent_count() == 0);
|
|
}
|
|
|
|
SECTION("a value in range is returned as-is") {
|
|
config.set(SETTING_SPEED_DIAL_RECENT_COUNT, "7");
|
|
REQUIRE(config.get_speed_dial_recent_count() == 7);
|
|
}
|
|
|
|
SECTION("the maximum is kept") {
|
|
config.set(SETTING_SPEED_DIAL_RECENT_COUNT, "10");
|
|
REQUIRE(config.get_speed_dial_recent_count() == SPEED_DIAL_RECENT_COUNT_MAX);
|
|
}
|
|
|
|
SECTION("values above the maximum clamp down") {
|
|
config.set(SETTING_SPEED_DIAL_RECENT_COUNT, "42");
|
|
REQUIRE(config.get_speed_dial_recent_count() == SPEED_DIAL_RECENT_COUNT_MAX);
|
|
}
|
|
|
|
SECTION("negative values clamp up to 0") {
|
|
config.set(SETTING_SPEED_DIAL_RECENT_COUNT, "-3");
|
|
REQUIRE(config.get_speed_dial_recent_count() == 0);
|
|
}
|
|
|
|
SECTION("garbage falls back to the default") {
|
|
config.set(SETTING_SPEED_DIAL_RECENT_COUNT, "abc");
|
|
REQUIRE(config.get_speed_dial_recent_count() == SPEED_DIAL_RECENT_COUNT_DEFAULT);
|
|
}
|
|
}
|