mirror of
https://github.com/OrcaSlicer/OrcaSlicer.git
synced 2026-08-01 15:22:21 +00:00
feeea3e651
# Description Fixes user filament presets that reference an old printer preset name in `compatible_printers`, even when the current system printer preset correctly declares that old name in `renamed_from`. ## Core Issue `PresetCollection::find_preset()` was updated to resolve `renamed_from`, but this specific failure does not go through `find_preset()`. For root user filament presets with empty `inherits`, Orca infers `compatible_printers` from the filament name suffix after `@`. For example: ```json "ELEGOO PLA Base @Elegoo Neptune 4 Pro (0.4 nozzle)" ``` loads with: ```json "compatible_printers": ["Elegoo Neptune 4 Pro (0.4 nozzle)"] ``` The current system printer preset is named: ```text Elegoo Neptune 4 Pro 0.4 nozzle ``` and has: ```json "renamed_from": "Elegoo Neptune 4 Pro (0.4 nozzle)" ``` However, filament compatibility was doing a direct string comparison against the active printer name. Since that compatibility path does not call `find_preset()`, the `renamed_from` mapping was never considered. ## Fix Teach printer compatibility checks to treat `active_printer.preset.renamed_from` entries as aliases of the active printer name. This preserves existing user preset JSON and avoids rewriting `compatible_printers`, while allowing old printer suffixes to remain compatible with renamed system printer presets. ## Tests <!-- > A guide for users on how to download the artifacts from this PR. --> [How to Download Pull Requests Artifacts for Testing](https://www.orcaslicer.com/wiki/how_to_download_pr_artifacts)
82 lines
1.2 KiB
JSON
82 lines
1.2 KiB
JSON
{
|
|
"type": "filament",
|
|
"name": "Generic PLA+@Q2C-Series",
|
|
"inherits": "fdm_filament_q_common",
|
|
"from": "system",
|
|
"filament_id": "GFL99",
|
|
"instantiation": "false",
|
|
"additional_cooling_fan_speed": [
|
|
"100"
|
|
],
|
|
"filament_adhesiveness_category": [
|
|
"100"
|
|
],
|
|
"filament_density": [
|
|
"1.2"
|
|
],
|
|
"filament_max_volumetric_speed": [
|
|
"12"
|
|
],
|
|
"filament_type": [
|
|
"PLA"
|
|
],
|
|
"filament_vendor": [
|
|
"Generic"
|
|
],
|
|
"nozzle_temperature_initial_layer": [
|
|
"230"
|
|
],
|
|
"nozzle_temperature_range_high": [
|
|
"240"
|
|
],
|
|
"nozzle_temperature_range_low": [
|
|
"190"
|
|
],
|
|
"nozzle_temperature": [
|
|
"230"
|
|
],
|
|
"overhang_fan_threshold": [
|
|
"50%"
|
|
],
|
|
"supertack_plate_temp_initial_layer": [
|
|
"45"
|
|
],
|
|
"supertack_plate_temp": [
|
|
"45"
|
|
],
|
|
"temperature_vitrification": [
|
|
"45"
|
|
],
|
|
"compatible_printers": [],
|
|
"cool_plate_temp": [
|
|
"45"
|
|
],
|
|
"eng_plate_temp": [
|
|
"60"
|
|
],
|
|
"hot_plate_temp": [
|
|
"60"
|
|
],
|
|
"textured_plate_temp": [
|
|
"60"
|
|
],
|
|
"textured_cool_plate_temp": [
|
|
"45"
|
|
],
|
|
"cool_plate_temp_initial_layer": [
|
|
"45"
|
|
],
|
|
"eng_plate_temp_initial_layer": [
|
|
"60"
|
|
],
|
|
"hot_plate_temp_initial_layer": [
|
|
"60"
|
|
],
|
|
"textured_plate_temp_initial_layer": [
|
|
"60"
|
|
],
|
|
"textured_cool_plate_temp_initial_layer": [
|
|
"45"
|
|
]
|
|
}
|