Files
OrcaSlicer/deps_src/libigl/igl/fit_cubic_bezier.cpp
Donovan Baarda dc5897d7b5 Update eigen to v5.0.1 and libigl to v2.6.0. (#11311)
* Update eigen from v3.3.7 to v5.0.1.

This updates eigen from v3.3.7 released on  December 11, 2018-12-11 to v5.0.1
released on 2025-11-11. There have be a large number of bug-fixes,
optimizations, and improvements between these releases. See the details at;

https://gitlab.com/libeigen/eigen/-/releases

It retains the previous custom minimal `CMakeLists.txt`, and adds a
README-OrcaSlicer.md that explains what version and parts of the upstream
eigen release have been included, and where the full release can be found.

* Update libigl from v2.0.0 (or older) to v2.6.0.

This updates libigl from what was probably v2.0.0 released on 2018-10-16 to
v2.6.0 released on 2025-05-15. It's possible the old version was even older
than that but there is no version indicators in the code and I ran out of
patience identifying missing changes and only went back as far as v2.0.0.

There have been a large number of bug-fixes, optimizations, and improvements
between these versions. See the following for details;

https://github.com/libigl/libigl/releases

I retained the minimal custom `CMakeLists.txt`, added `README.md` from the
libigl distribution which identifies the version, and added a
README-OrcaSlicer.md that details the version and parts that have been
included.

* Update libslic3r for libigl v2.6.0 changes.

This updates libslic3r for all changes moving to eigen v5.0.1 and libigl
v2.6.0. Despite the large number of updates to both dependencies, no changes
were required for the eigen update, and only one change was required for the
libigl update.

For libigl, `igl::Hit` was changed to a template taking the Scalar type to
use. Previously it was hard-coded to `float`, so to minimize possible impact
I've updated all places it is used from `igl::Hit` to `igl::Hit<float>`.

* Add compiler option `-DNOMINMAX` for libigl with MSVC.

MSVC by default defines `min(()` and `max()` macros that break
`std::numeric_limits<>::max()`. The upstream cmake that we don't include
adds `-DNOMINMAX` for the libigl module when compiling with MSVC, so we need
to add the same thing here.

* Fix src/libslic3r/TriangleMeshDeal.cpp for the unmodified upstream libigl.

This fixes `TriangleMeshDeal.cpp` to work with the unmodified upstream
libigl v2.6.0. loop.{h,cpp} implementation.

This file and feature was added in PR "BBS Port: Mesh Subdivision" (#12150)
which included changes to `loop.{h,cpp}` in the old version of libigl. This PR
avoids modifying the included dependencies, and uses the updated upstream
versions of those files without any modifications, which requires fixing
TriangleMeshDeal.cpp to work with them.

In particular, the modifications made to `loop.{h,cpp}` included changing the
return type from void to bool, adding additional validation checking of the
input meshes, and returning false if they failed validation. These added
checks looked unnecessary and would only have caught problems if the input
mesh was very corrupt.

To make `TriangleMeshDeal.cpp` work without this built-in checking
functionality, I removed checking/handling of any `false` return value.

There was also a hell of a lot of redundant copying and casting back and forth
between float and double, so I cleaned that up. The input and output meshs use
floats for the vertexes, and there would be no accuracy benefits from casting
to and from doubles for the simple weighted average operations done by
igl::loop(). So this just uses `Eigen:Map` to use the original input mesh
vertex data directly without requiring any copy or casting.

* Move eigen from included `deps_src` to externaly fetched `deps`.

This copys what PrusaSlicer did and moved it from an included dependency under
`deps_src` to an externaly fetched dependency under `deps`. This requires
updating some `CMakeList.txt` configs and removing the old and obsolete
`cmake/modules/FindEigen3.cmake`. The details of when this was done in
PrusaSlicer and the followup fixes are at;

* 21116995d7
* https://github.com/prusa3d/PrusaSlicer/issues/13608
* https://github.com/prusa3d/PrusaSlicer/pull/13609
* e3c277b9ee

For some reason I don't fully understand this also required fixing
`src/slic3r/GUI/GUI_App.cpp` by adding `#include <boost/nowide/cstdio.hpp>` to
fix an `error: ‘remove’ is not a member of ‘boost::nowide'`. The main thing I
don't understand is how it worked before. Note that this include is in the
PrusaSlicer version of this file, but it also significantly deviates from what
is currently in OrcaSlicer in many other ways.

* Whups... I missed adding the deps/Eigen/Eigen.cmake file...

* Tidy some whitespace indenting in CMakeLists.txt.

* Ugh... tabs indenting needing fixes.

* Change the include order of deps/Eigen.

It turns out that although Boost includes some references to Eigen, Eigen also
includes some references to Boost for supporting some of it's additional
numeric types.

I don't think it matters much since we are not using these features, but I
think technically its more correct to say Eigen depends on Boost than the
other way around, so I've re-ordered them.

* Add source for Eigen 5.0.1 download to flatpak yml config.

* Add explicit `DEPENDS dep_Boost to deps/Eigen.

I missed this before. This ensures we don't rely on include orders to make
sure Boost is installed before we configure Eigen.

* Add `DEPENDS dep_Boost dep_GMP dep_MPFR` to deps/Eigen.

It turns out Eigen can also use GMP and MPFR for multi-precision and
multi-precision-rounded numeric types if they are available.

Again, I don't think we are using these so it doesn't really matter, but it is
technically correct and ensures they are there if we ever do need them.

* Fix deps DEPENDENCY ordering for GMP, MPFR, Eigen, and CGAL.

I think this is finally correct. Apparently CGAL also optionally depends on
Eigen, so the correct dependency order from lowest to highest is GMP, MPFR, Eigen, and CGAL.

---------

Co-authored-by: Donovan Baarda <dbaarda@google.com>
Co-authored-by: Noisyfox <timemanager.rick@gmail.com>
2026-05-12 15:09:13 +08:00

309 lines
9.5 KiB
C++

// This file is part of libigl, a simple c++ geometry processing library.
//
// Copyright (C) 2020 Alec Jacobson <alecjacobson@gmail.com>
//
// This Source Code Form is subject to the terms of the Mozilla Public License
// v. 2.0. If a copy of the MPL was not distributed with this file, You can
// obtain one at http://mozilla.org/MPL/2.0/.
#include "fit_cubic_bezier.h"
#include "bezier.h"
#include "EPS.h"
// Adapted from main.c accompanying
// An Algorithm for Automatically Fitting Digitized Curves
// by Philip J. Schneider
// from "Graphics Gems", Academic Press, 1990
IGL_INLINE void igl::fit_cubic_bezier(
const Eigen::MatrixXd & d,
const double error,
std::vector<Eigen::MatrixXd> & cubics)
{
const int nPts = d.rows();
// Don't attempt to fit curve to single point
if(nPts==1) { return; }
// Avoid using zero tangent
const static auto tangent = [](
const Eigen::MatrixXd & d,
const int i,const int dir)->Eigen::RowVectorXd
{
int j = i;
const int nPts = d.rows();
Eigen::RowVectorXd t;
while(true)
{
// look at next point
j += dir;
if(j < 0 || j>=nPts)
{
// All points are coincident?
// give up and use zero tangent...
return Eigen::RowVectorXd::Zero(1,d.cols());
}
t = d.row(j)-d.row(i);
if(t.squaredNorm() > igl::DOUBLE_EPS)
{
break;
}
}
return t.normalized();
};
Eigen::RowVectorXd tHat1 = tangent(d,0,+1);
Eigen::RowVectorXd tHat2 = tangent(d,nPts-1,-1);
// If first and last points are identically equal, then consider closed
const bool closed = (d.row(0) - d.row(d.rows()-1)).squaredNorm() == 0;
// If closed loop make tangents match
if(closed)
{
tHat1 = (tHat1 - tHat2).eval().normalized();
tHat2 = -tHat1;
}
cubics.clear();
fit_cubic_bezier_substring(d,0,nPts-1,tHat1,tHat2,error,closed,cubics);
};
IGL_INLINE void igl::fit_cubic_bezier_substring(
const Eigen::MatrixXd & d,
const int first,
const int last,
const Eigen::RowVectorXd & tHat1,
const Eigen::RowVectorXd & tHat2,
const double error,
const bool force_split,
std::vector<Eigen::MatrixXd> & cubics)
{
// Helper functions
// Evaluate a Bezier curve at a particular parameter value
const static auto bezier_eval = [](const Eigen::MatrixXd & V, const double t)
{ Eigen::RowVectorXd P; bezier(V,t,P); return P; };
//
// Use Newton-Raphson iteration to find better root.
const static auto NewtonRaphsonRootFind = [](
const Eigen::MatrixXd & Q,
const Eigen::RowVectorXd & P,
const double u)->double
{
/* Compute Q(u) */
Eigen::RowVectorXd Q_u = bezier_eval(Q, u);
Eigen::MatrixXd Q1(3,Q.cols());
Eigen::MatrixXd Q2(2,Q.cols());
/* Generate control vertices for Q' */
for (int i = 0; i <= 2; i++)
{
Q1.row(i) = (Q.row(i+1) - Q.row(i)) * 3.0;
}
/* Generate control vertices for Q'' */
for (int i = 0; i <= 1; i++)
{
Q2.row(i) = (Q1.row(i+1) - Q1.row(i)) * 2.0;
}
/* Compute Q'(u) and Q''(u) */
const Eigen::RowVectorXd Q1_u = bezier_eval(Q1, u);
const Eigen::RowVectorXd Q2_u = bezier_eval(Q2, u);
/* Compute f(u)/f'(u) */
const double numerator = ((Q_u-P).array() * Q1_u.array()).array().sum();
const double denominator =
Q1_u.squaredNorm() + ((Q_u-P).array() * Q2_u.array()).array().sum();
/* u = u - f(u)/f'(u) */
return u - (numerator/denominator);
};
const static auto ComputeMaxError = [](
const Eigen::MatrixXd & d,
const int first,
const int last,
const Eigen::MatrixXd & bezCurve,
const Eigen::VectorXd & u,
int & splitPoint)->double
{
Eigen::VectorXd E(last - (first+1));
splitPoint = (last-first + 1)/2;
double maxDist = 0.0;
for (int i = first + 1; i < last; i++)
{
Eigen::RowVectorXd P = bezier_eval(bezCurve, u(i-first));
const double dist = (P-d.row(i)).squaredNorm();
E(i-(first+1)) = dist;
if (dist >= maxDist)
{
maxDist = dist;
// Worst offender
splitPoint = i;
}
}
//const double half_total = E.array().sum()/2;
//double run = 0;
//for (int i = first + 1; i < last; i++)
//{
// run += E(i-(first+1));
// if(run>half_total)
// {
// // When accumulated ½ the error --> more symmetric, but requires more
// // curves
// splitPoint = i;
// break;
// }
//}
return maxDist;
};
const static auto Straight = [](
const Eigen::MatrixXd & d,
const int first,
const int last,
const Eigen::RowVectorXd & tHat1,
const Eigen::RowVectorXd & tHat2,
Eigen::MatrixXd & bezCurve)
{
bezCurve.resize(4,d.cols());
const double dist = (d.row(last)-d.row(first)).norm()/3.0;
bezCurve.row(0) = d.row(first);
bezCurve.row(1) = d.row(first) + tHat1*dist;
bezCurve.row(2) = d.row(last) + tHat2*dist;
bezCurve.row(3) = d.row(last);
};
const static auto GenerateBezier = [](
const Eigen::MatrixXd & d,
const int first,
const int last,
const Eigen::VectorXd & uPrime,
const Eigen::RowVectorXd & tHat1,
const Eigen::RowVectorXd & tHat2,
Eigen::MatrixXd & bezCurve)
{
bezCurve.resize(4,d.cols());
const int nPts = last - first + 1;
const static auto B0 = [](const double u)->double
{ double tmp = 1.0 - u; return (tmp * tmp * tmp);};
const static auto B1 = [](const double u)->double
{ double tmp = 1.0 - u; return (3 * u * (tmp * tmp));};
const static auto B2 = [](const double u)->double
{ double tmp = 1.0 - u; return (3 * u * u * tmp); };
const static auto B3 = [](const double u)->double
{ return (u * u * u); };
/* Compute the A's */
std::vector<std::vector<Eigen::RowVectorXd> > A(nPts);
for (int i = 0; i < nPts; i++)
{
Eigen::RowVectorXd v1 = tHat1*B1(uPrime(i));
Eigen::RowVectorXd v2 = tHat2*B2(uPrime(i));
A[i] = {v1,v2};
}
/* Create the C and X matrices */
Eigen::MatrixXd C(2,2);
Eigen::VectorXd X(2);
C(0,0) = 0.0;
C(0,1) = 0.0;
C(1,0) = 0.0;
C(1,1) = 0.0;
X(0) = 0.0;
X(1) = 0.0;
for( int i = 0; i < nPts; i++)
{
C(0,0) += A[i][0].dot(A[i][0]);
C(0,1) += A[i][0].dot(A[i][1]);
C(1,0) = C(0,1);
C(1,1) += A[i][1].dot(A[i][1]);
const Eigen::RowVectorXd tmp =
d.row(first+i)-(
d.row(first)*B0(uPrime(i))+
d.row(first)*B1(uPrime(i))+
d.row(last)*B2(uPrime(i))+
d.row(last)*B3(uPrime(i)));
X(0) += A[i][0].dot(tmp);
X(1) += A[i][1].dot(tmp);
}
/* Compute the determinants of C and X */
double det_C0_C1 = C(0,0) * C(1,1) - C(1,0) * C(0,1);
const double det_C0_X = C(0,0) * X(1) - C(0,1) * X(0);
const double det_X_C1 = X(0) * C(1,1) - X(1) * C(0,1);
/* Finally, derive alpha values */
if (det_C0_C1 == 0.0)
{
det_C0_C1 = (C(0,0) * C(1,1)) * 10e-12;
}
const double alpha_l = det_X_C1 / det_C0_C1;
const double alpha_r = det_C0_X / det_C0_C1;
/* If alpha negative, use the Wu/Barsky heuristic (see text) */
/* (if alpha is 0, you get coincident control points that lead to
* divide by zero in any subsequent NewtonRaphsonRootFind() call. */
if (alpha_l < 1.0e-6 || alpha_r < 1.0e-6)
{
return Straight(d,first,last,tHat1,tHat2,bezCurve);
}
bezCurve.row(0) = d.row(first);
bezCurve.row(1) = d.row(first) + tHat1*alpha_l;
bezCurve.row(2) = d.row(last) + tHat2*alpha_r;
bezCurve.row(3) = d.row(last);
};
const int maxIterations = 4;
// This is a bad idea if error<1 ...
//const double iterationError = error * error;
const double iterationError = 100 * error;
const int nPts = last - first + 1;
/* Use heuristic if region only has two points in it */
if(nPts == 2)
{
Eigen::MatrixXd bezCurve;
Straight(d,first,last,tHat1,tHat2,bezCurve);
cubics.push_back(bezCurve);
return;
}
// ChordLengthParameterize
Eigen::VectorXd u(last-first+1);
u(0) = 0;
for (int i = first+1; i <= last; i++)
{
u(i-first) = u(i-first-1) + (d.row(i)-d.row(i-1)).norm();
}
for (int i = first + 1; i <= last; i++)
{
u(i-first) = u(i-first) / u(last-first);
}
Eigen::MatrixXd bezCurve;
GenerateBezier(d, first, last, u, tHat1, tHat2, bezCurve);
int splitPoint;
double maxError = ComputeMaxError(d, first, last, bezCurve, u, splitPoint);
if (!force_split && maxError < error)
{
cubics.push_back(bezCurve);
return;
}
/* If error not too large, try some reparameterization */
/* and iteration */
if (maxError < iterationError)
{
for (int i = 0; i < maxIterations; i++)
{
Eigen::VectorXd uPrime;
// Reparameterize
uPrime.resize(last-first+1);
for (int i = first; i <= last; i++)
{
uPrime(i-first) = NewtonRaphsonRootFind(bezCurve, d.row(i), u(i- first));
}
GenerateBezier(d, first, last, uPrime, tHat1, tHat2, bezCurve);
maxError = ComputeMaxError(d, first, last, bezCurve, uPrime, splitPoint);
if (!force_split && maxError < error) {
cubics.push_back(bezCurve);
return;
}
u = uPrime;
}
}
/* Fitting failed -- split at max error point and fit recursively */
const Eigen::RowVectorXd tHatCenter =
(d.row(splitPoint-1)-d.row(splitPoint+1)).normalized();
//foobar
fit_cubic_bezier_substring(
d,first,splitPoint,tHat1,tHatCenter,error,false,cubics);
fit_cubic_bezier_substring(
d,splitPoint,last,(-tHatCenter).eval(),tHat2,error,false,cubics);
}
#ifdef IGL_STATIC_LIBRARY
// Explicit template instantiation
#endif