mirror of
https://github.com/OrcaSlicer/OrcaSlicer.git
synced 2026-05-16 18:12:10 +00:00
* Update eigen from v3.3.7 to v5.0.1. This updates eigen from v3.3.7 released on December 11, 2018-12-11 to v5.0.1 released on 2025-11-11. There have be a large number of bug-fixes, optimizations, and improvements between these releases. See the details at; https://gitlab.com/libeigen/eigen/-/releases It retains the previous custom minimal `CMakeLists.txt`, and adds a README-OrcaSlicer.md that explains what version and parts of the upstream eigen release have been included, and where the full release can be found. * Update libigl from v2.0.0 (or older) to v2.6.0. This updates libigl from what was probably v2.0.0 released on 2018-10-16 to v2.6.0 released on 2025-05-15. It's possible the old version was even older than that but there is no version indicators in the code and I ran out of patience identifying missing changes and only went back as far as v2.0.0. There have been a large number of bug-fixes, optimizations, and improvements between these versions. See the following for details; https://github.com/libigl/libigl/releases I retained the minimal custom `CMakeLists.txt`, added `README.md` from the libigl distribution which identifies the version, and added a README-OrcaSlicer.md that details the version and parts that have been included. * Update libslic3r for libigl v2.6.0 changes. This updates libslic3r for all changes moving to eigen v5.0.1 and libigl v2.6.0. Despite the large number of updates to both dependencies, no changes were required for the eigen update, and only one change was required for the libigl update. For libigl, `igl::Hit` was changed to a template taking the Scalar type to use. Previously it was hard-coded to `float`, so to minimize possible impact I've updated all places it is used from `igl::Hit` to `igl::Hit<float>`. * Add compiler option `-DNOMINMAX` for libigl with MSVC. MSVC by default defines `min(()` and `max()` macros that break `std::numeric_limits<>::max()`. The upstream cmake that we don't include adds `-DNOMINMAX` for the libigl module when compiling with MSVC, so we need to add the same thing here. * Fix src/libslic3r/TriangleMeshDeal.cpp for the unmodified upstream libigl. This fixes `TriangleMeshDeal.cpp` to work with the unmodified upstream libigl v2.6.0. loop.{h,cpp} implementation. This file and feature was added in PR "BBS Port: Mesh Subdivision" (#12150) which included changes to `loop.{h,cpp}` in the old version of libigl. This PR avoids modifying the included dependencies, and uses the updated upstream versions of those files without any modifications, which requires fixing TriangleMeshDeal.cpp to work with them. In particular, the modifications made to `loop.{h,cpp}` included changing the return type from void to bool, adding additional validation checking of the input meshes, and returning false if they failed validation. These added checks looked unnecessary and would only have caught problems if the input mesh was very corrupt. To make `TriangleMeshDeal.cpp` work without this built-in checking functionality, I removed checking/handling of any `false` return value. There was also a hell of a lot of redundant copying and casting back and forth between float and double, so I cleaned that up. The input and output meshs use floats for the vertexes, and there would be no accuracy benefits from casting to and from doubles for the simple weighted average operations done by igl::loop(). So this just uses `Eigen:Map` to use the original input mesh vertex data directly without requiring any copy or casting. * Move eigen from included `deps_src` to externaly fetched `deps`. This copys what PrusaSlicer did and moved it from an included dependency under `deps_src` to an externaly fetched dependency under `deps`. This requires updating some `CMakeList.txt` configs and removing the old and obsolete `cmake/modules/FindEigen3.cmake`. The details of when this was done in PrusaSlicer and the followup fixes are at; *21116995d7* https://github.com/prusa3d/PrusaSlicer/issues/13608 * https://github.com/prusa3d/PrusaSlicer/pull/13609 *e3c277b9eeFor some reason I don't fully understand this also required fixing `src/slic3r/GUI/GUI_App.cpp` by adding `#include <boost/nowide/cstdio.hpp>` to fix an `error: ‘remove’ is not a member of ‘boost::nowide'`. The main thing I don't understand is how it worked before. Note that this include is in the PrusaSlicer version of this file, but it also significantly deviates from what is currently in OrcaSlicer in many other ways. * Whups... I missed adding the deps/Eigen/Eigen.cmake file... * Tidy some whitespace indenting in CMakeLists.txt. * Ugh... tabs indenting needing fixes. * Change the include order of deps/Eigen. It turns out that although Boost includes some references to Eigen, Eigen also includes some references to Boost for supporting some of it's additional numeric types. I don't think it matters much since we are not using these features, but I think technically its more correct to say Eigen depends on Boost than the other way around, so I've re-ordered them. * Add source for Eigen 5.0.1 download to flatpak yml config. * Add explicit `DEPENDS dep_Boost to deps/Eigen. I missed this before. This ensures we don't rely on include orders to make sure Boost is installed before we configure Eigen. * Add `DEPENDS dep_Boost dep_GMP dep_MPFR` to deps/Eigen. It turns out Eigen can also use GMP and MPFR for multi-precision and multi-precision-rounded numeric types if they are available. Again, I don't think we are using these so it doesn't really matter, but it is technically correct and ensures they are there if we ever do need them. * Fix deps DEPENDENCY ordering for GMP, MPFR, Eigen, and CGAL. I think this is finally correct. Apparently CGAL also optionally depends on Eigen, so the correct dependency order from lowest to highest is GMP, MPFR, Eigen, and CGAL. --------- Co-authored-by: Donovan Baarda <dbaarda@google.com> Co-authored-by: Noisyfox <timemanager.rick@gmail.com>
329 lines
13 KiB
C++
329 lines
13 KiB
C++
// This file is part of libigl, a simple c++ geometry processing library.
|
|
//
|
|
// Copyright (C) 2015 Qingnan Zhou <qnzhou@gmail.com>
|
|
//
|
|
// This Source Code Form is subject to the terms of the Mozilla Public License
|
|
// v. 2.0. If a copy of the MPL was not distributed with this file, You can
|
|
// obtain one at http://mozilla.org/MPL/2.0/.
|
|
//
|
|
#include "propagate_winding_numbers.h"
|
|
#include "../../extract_manifold_patches.h"
|
|
#include "../../extract_non_manifold_edge_curves.h"
|
|
#include "../../facet_components.h"
|
|
#include "../../unique_edge_map.h"
|
|
#include "../../piecewise_constant_winding_number.h"
|
|
#include "../../writeOBJ.h"
|
|
#include "../../writePLY.h"
|
|
#include "../../get_seconds.h"
|
|
#include "../../LinSpaced.h"
|
|
#include "outer_facet.h"
|
|
#include "assign.h"
|
|
#include "extract_cells.h"
|
|
#include "cell_adjacency.h"
|
|
|
|
#include <stdexcept>
|
|
#include <limits>
|
|
#include <vector>
|
|
#include <tuple>
|
|
#include <queue>
|
|
|
|
//#define PROPAGATE_WINDING_NUMBER_TIMING
|
|
|
|
template<
|
|
typename DerivedV,
|
|
typename DerivedF,
|
|
typename DerivedL,
|
|
typename DerivedW>
|
|
IGL_INLINE bool igl::copyleft::cgal::propagate_winding_numbers(
|
|
const Eigen::MatrixBase<DerivedV>& V,
|
|
const Eigen::MatrixBase<DerivedF>& F,
|
|
const Eigen::MatrixBase<DerivedL>& labels,
|
|
Eigen::PlainObjectBase<DerivedW>& W)
|
|
{
|
|
using Index = typename DerivedF::Scalar;
|
|
using MatrixXI = Eigen::Matrix<Index, Eigen::Dynamic, Eigen::Dynamic>;
|
|
using VectorXI = Eigen::Matrix<Index, Eigen::Dynamic, 1>;
|
|
|
|
#ifdef PROPAGATE_WINDING_NUMBER_TIMING
|
|
const auto & tictoc = []() -> double
|
|
{
|
|
static double t_start = igl::get_seconds();
|
|
double diff = igl::get_seconds()-t_start;
|
|
t_start += diff;
|
|
return diff;
|
|
};
|
|
const auto log_time = [&](const std::string& label) -> void {
|
|
std::cout << "propagate_winding_num." << label << ": "
|
|
<< tictoc() << std::endl;
|
|
};
|
|
tictoc();
|
|
#endif
|
|
|
|
MatrixXI E, uE;
|
|
VectorXI EMAP, uEC, uEE;
|
|
igl::unique_edge_map(F, E, uE, EMAP, uEC, uEE);
|
|
|
|
VectorXI P;
|
|
const size_t num_patches = igl::extract_manifold_patches(F,EMAP,uEC,uEE,P);
|
|
|
|
DerivedW per_patch_cells;
|
|
const size_t num_cells =
|
|
extract_cells(V,F,P,uE,EMAP,uEC,uEE,per_patch_cells);
|
|
#ifdef PROPAGATE_WINDING_NUMBER_TIMING
|
|
log_time("cell_extraction");
|
|
#endif
|
|
|
|
return propagate_winding_numbers(V, F,
|
|
uE, uEC, uEE,
|
|
num_patches, P,
|
|
num_cells, per_patch_cells,
|
|
labels, W);
|
|
}
|
|
|
|
|
|
template<
|
|
typename DerivedV,
|
|
typename DerivedF,
|
|
typename DeriveduE,
|
|
typename DeriveduEC,
|
|
typename DeriveduEE,
|
|
typename DerivedP,
|
|
typename DerivedC,
|
|
typename DerivedL,
|
|
typename DerivedW>
|
|
IGL_INLINE bool igl::copyleft::cgal::propagate_winding_numbers(
|
|
const Eigen::MatrixBase<DerivedV>& V,
|
|
const Eigen::MatrixBase<DerivedF>& F,
|
|
const Eigen::MatrixBase<DeriveduE>& uE,
|
|
const Eigen::MatrixBase<DeriveduEC>& uEC,
|
|
const Eigen::MatrixBase<DeriveduEE>& uEE,
|
|
const size_t num_patches,
|
|
const Eigen::MatrixBase<DerivedP>& P,
|
|
const size_t num_cells,
|
|
const Eigen::MatrixBase<DerivedC>& C,
|
|
const Eigen::MatrixBase<DerivedL>& labels,
|
|
Eigen::PlainObjectBase<DerivedW>& W)
|
|
{
|
|
using Index = typename DerivedF::Scalar;
|
|
using MatrixXI = Eigen::Matrix<Index, Eigen::Dynamic, Eigen::Dynamic>;
|
|
using VectorXI = Eigen::Matrix<Index, Eigen::Dynamic, 1>;
|
|
#ifdef PROPAGATE_WINDING_NUMBER_TIMING
|
|
const auto & tictoc = []() -> double
|
|
{
|
|
static double t_start = igl::get_seconds();
|
|
double diff = igl::get_seconds()-t_start;
|
|
t_start += diff;
|
|
return diff;
|
|
};
|
|
const auto log_time = [&](const std::string& label) -> void {
|
|
std::cout << "propagate_winding_num." << label << ": "
|
|
<< tictoc() << std::endl;
|
|
};
|
|
tictoc();
|
|
#endif
|
|
|
|
bool valid = true;
|
|
// https://github.com/libigl/libigl/issues/674
|
|
if (!igl::piecewise_constant_winding_number(F, uE, uEC, uEE))
|
|
{
|
|
assert(false && "Input mesh is not PWN");
|
|
valid = false;
|
|
}
|
|
|
|
const size_t num_faces = F.rows();
|
|
typedef std::tuple<typename DerivedC::Scalar, bool, size_t> CellConnection;
|
|
std::vector<std::set<CellConnection> > cell_adj;
|
|
igl::copyleft::cgal::cell_adjacency(C, num_cells, cell_adj);
|
|
#ifdef PROPAGATE_WINDING_NUMBER_TIMING
|
|
log_time("cell_connectivity");
|
|
#endif
|
|
|
|
#ifdef IGL_COPYLEFT_CGAL_PROPAGATE_WINDING_NUMBERS_DEBUG
|
|
auto save_cell = [&](const std::string& filename, size_t cell_id) -> void{
|
|
std::vector<size_t> faces;
|
|
for (size_t i=0; i<num_patches; i++) {
|
|
if ((C.row(i).array() == cell_id).any()) {
|
|
for (size_t j=0; j<num_faces; j++) {
|
|
if ((size_t)P[j] == i) {
|
|
faces.push_back(j);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
MatrixXI cell_faces(faces.size(), 3);
|
|
for (size_t i=0; i<faces.size(); i++) {
|
|
cell_faces.row(i) = F.row(faces[i]);
|
|
}
|
|
Eigen::MatrixXd vertices;
|
|
assign(V,vertices);
|
|
writePLY(filename, vertices, cell_faces);
|
|
};
|
|
#endif
|
|
|
|
#ifdef IGL_COPYLEFT_CGAL_PROPAGATE_WINDING_NUMBERS_DEBUG
|
|
{
|
|
// Check for odd cycle.
|
|
VectorXI cell_labels(num_cells);
|
|
cell_labels.setZero();
|
|
VectorXI parents(num_cells);
|
|
parents.setConstant(-1);
|
|
auto trace_parents = [&](size_t idx) -> std::list<size_t> {
|
|
std::list<size_t> path;
|
|
path.push_back(idx);
|
|
while ((size_t)parents[path.back()] != path.back()) {
|
|
path.push_back(parents[path.back()]);
|
|
}
|
|
return path;
|
|
};
|
|
for (size_t i=0; i<num_cells; i++) {
|
|
if (cell_labels[i] == 0) {
|
|
cell_labels[i] = 1;
|
|
std::queue<size_t> Q;
|
|
Q.push(i);
|
|
parents[i] = i;
|
|
while (!Q.empty()) {
|
|
size_t curr_idx = Q.front();
|
|
Q.pop();
|
|
int curr_label = cell_labels[curr_idx];
|
|
for (const auto& neighbor : cell_adj[curr_idx]) {
|
|
if (cell_labels[std::get<0>(neighbor)] == 0)
|
|
{
|
|
cell_labels[std::get<0>(neighbor)] = curr_label * -1;
|
|
Q.push(std::get<0>(neighbor));
|
|
parents[std::get<0>(neighbor)] = curr_idx;
|
|
} else
|
|
{
|
|
if (cell_labels[std::get<0>(neighbor)] != curr_label * -1)
|
|
{
|
|
std::cerr << "Odd cell cycle detected!" << std::endl;
|
|
auto path = trace_parents(curr_idx);
|
|
path.reverse();
|
|
auto path2 = trace_parents(std::get<0>(neighbor));
|
|
path.insert(path.end(), path2.begin(), path2.end());
|
|
for (auto cell_id : path)
|
|
{
|
|
std::cout << cell_id << " ";
|
|
std::stringstream filename;
|
|
filename << "cell_" << cell_id << ".ply";
|
|
save_cell(filename.str(), cell_id);
|
|
}
|
|
std::cout << std::endl;
|
|
valid = false;
|
|
}
|
|
// Do not fail when odd cycle is detected because the resulting
|
|
// integer winding number field, although inconsistent, may still
|
|
// be used if the problem region is local and embedded within a
|
|
// valid volume.
|
|
//assert(cell_labels[std::get<0>(neighbor)] == curr_label * -1);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
#ifdef PROPAGATE_WINDING_NUMBER_TIMING
|
|
log_time("odd_cycle_check");
|
|
#endif
|
|
}
|
|
#endif
|
|
|
|
Eigen::Index outer_facet;
|
|
bool flipped;
|
|
VectorXI I = igl::LinSpaced<VectorXI>(num_faces, 0, num_faces-1);
|
|
igl::copyleft::cgal::outer_facet(V, F, I, outer_facet, flipped);
|
|
#ifdef PROPAGATE_WINDING_NUMBER_TIMING
|
|
log_time("outer_facet");
|
|
#endif
|
|
|
|
const size_t outer_patch = P[outer_facet];
|
|
const size_t infinity_cell = C(outer_patch, flipped?1:0);
|
|
|
|
VectorXI patch_labels(num_patches);
|
|
const int INVALID = std::numeric_limits<int>::max();
|
|
patch_labels.setConstant(INVALID);
|
|
for (size_t i=0; i<num_faces; i++) {
|
|
if (patch_labels[P[i]] == INVALID) {
|
|
patch_labels[P[i]] = labels[i];
|
|
} else {
|
|
assert(patch_labels[P[i]] == labels[i]);
|
|
}
|
|
}
|
|
assert((patch_labels.array() != INVALID).all());
|
|
const size_t num_labels = patch_labels.maxCoeff()+1;
|
|
|
|
MatrixXI per_cell_W(num_cells, num_labels);
|
|
per_cell_W.setConstant(INVALID);
|
|
per_cell_W.row(infinity_cell).setZero();
|
|
std::queue<size_t> Q;
|
|
Q.push(infinity_cell);
|
|
while (!Q.empty()) {
|
|
size_t curr_cell = Q.front();
|
|
Q.pop();
|
|
for (const auto& neighbor : cell_adj[curr_cell]) {
|
|
size_t neighbor_cell, patch_idx;
|
|
bool direction;
|
|
std::tie(neighbor_cell, direction, patch_idx) = neighbor;
|
|
if ((per_cell_W.row(neighbor_cell).array() == INVALID).any()) {
|
|
per_cell_W.row(neighbor_cell) = per_cell_W.row(curr_cell);
|
|
for (size_t i=0; i<num_labels; i++) {
|
|
int inc = (patch_labels[patch_idx] == (int)i) ?
|
|
(direction ? -1:1) :0;
|
|
per_cell_W(neighbor_cell, i) =
|
|
per_cell_W(curr_cell, i) + inc;
|
|
}
|
|
Q.push(neighbor_cell);
|
|
} else {
|
|
#ifdef IGL_COPYLEFT_CGAL_PROPAGATE_WINDING_NUMBERS_DEBUG
|
|
// Checking for winding number consistency.
|
|
// This check would inevitably fail for meshes that contain open
|
|
// boundary or non-orientable. However, the inconsistent winding number
|
|
// field would still be useful in some cases such as when problem region
|
|
// is local and embedded within the volume. This, unfortunately, is the
|
|
// best we can do because the problem of computing integer winding
|
|
// number is ill-defined for open and non-orientable surfaces.
|
|
//
|
|
// Commented this out because it wasn't actually calling the asserts...
|
|
//for (size_t i=0; i<num_labels; i++) {
|
|
// if ((int)i == patch_labels[patch_idx]) {
|
|
// int inc = direction ? -1:1;
|
|
// //assert(per_cell_W(neighbor_cell, i) ==
|
|
// // per_cell_W(curr_cell, i) + inc);
|
|
// } else {
|
|
// //assert(per_cell_W(neighbor_cell, i) ==
|
|
// // per_cell_W(curr_cell, i));
|
|
// }
|
|
//}
|
|
#endif
|
|
}
|
|
}
|
|
}
|
|
#ifdef PROPAGATE_WINDING_NUMBER_TIMING
|
|
log_time("propagate_winding_number");
|
|
#endif
|
|
|
|
W.resize(num_faces, num_labels*2);
|
|
for (size_t i=0; i<num_faces; i++)
|
|
{
|
|
const size_t patch = P[i];
|
|
const size_t positive_cell = C(patch, 0);
|
|
const size_t negative_cell = C(patch, 1);
|
|
for (size_t j=0; j<num_labels; j++) {
|
|
W(i,j*2 ) = per_cell_W(positive_cell, j);
|
|
W(i,j*2+1) = per_cell_W(negative_cell, j);
|
|
}
|
|
}
|
|
#ifdef PROPAGATE_WINDING_NUMBER_TIMING
|
|
log_time("store_result");
|
|
#endif
|
|
return valid;
|
|
}
|
|
|
|
|
|
#ifdef IGL_STATIC_LIBRARY
|
|
// Explicit template instantiation
|
|
template bool igl::copyleft::cgal::propagate_winding_numbers<Eigen::Matrix<CGAL::Epeck::FT, -1, -1, 1, -1, -1>, Eigen::Matrix<int, -1, -1, 0, -1, -1>, Eigen::Matrix<int, -1, -1, 0, -1, -1>, Eigen::Matrix<int, -1, 1, 0, -1, 1>, Eigen::Matrix<int, -1, 1, 0, -1, 1>, Eigen::Matrix<int, -1, 1, 0, -1, 1>, Eigen::Matrix<int, -1, -1, 0, -1, -1>, Eigen::Matrix<int, -1, 1, 0, -1, 1>, Eigen::Matrix<int, -1, -1, 0, -1, -1> >(Eigen::MatrixBase<Eigen::Matrix<CGAL::Epeck::FT, -1, -1, 1, -1, -1> > const&, Eigen::MatrixBase<Eigen::Matrix<int, -1, -1, 0, -1, -1> > const&, Eigen::MatrixBase<Eigen::Matrix<int, -1, -1, 0, -1, -1> > const&, Eigen::MatrixBase<Eigen::Matrix<int, -1, 1, 0, -1, 1> > const&, Eigen::MatrixBase<Eigen::Matrix<int, -1, 1, 0, -1, 1> > const&, size_t, Eigen::MatrixBase<Eigen::Matrix<int, -1, 1, 0, -1, 1> > const&, size_t, Eigen::MatrixBase<Eigen::Matrix<int, -1, -1, 0, -1, -1> > const&, Eigen::MatrixBase<Eigen::Matrix<int, -1, 1, 0, -1, 1> > const&, Eigen::PlainObjectBase<Eigen::Matrix<int, -1, -1, 0, -1, -1> >&);
|
|
template bool igl::copyleft::cgal::propagate_winding_numbers<Eigen::Matrix<CGAL::Epeck::FT, -1, -1, 0, -1, -1>, Eigen::Matrix<int, -1, -1, 0, -1, -1>, Eigen::Matrix<int, -1, -1, 0, -1, -1>, Eigen::Matrix<int, -1, 1, 0, -1, 1>, Eigen::Matrix<int, -1, 1, 0, -1, 1>, Eigen::Matrix<int, -1, 1, 0, -1, 1>, Eigen::Matrix<int, -1, -1, 0, -1, -1>, Eigen::Matrix<int, -1, 1, 0, -1, 1>, Eigen::Matrix<int, -1, -1, 0, -1, -1> >(Eigen::MatrixBase<Eigen::Matrix<CGAL::Epeck::FT, -1, -1, 0, -1, -1> > const&, Eigen::MatrixBase<Eigen::Matrix<int, -1, -1, 0, -1, -1> > const&, Eigen::MatrixBase<Eigen::Matrix<int, -1, -1, 0, -1, -1> > const&, Eigen::MatrixBase<Eigen::Matrix<int, -1, 1, 0, -1, 1> > const&, Eigen::MatrixBase<Eigen::Matrix<int, -1, 1, 0, -1, 1> > const&, size_t, Eigen::MatrixBase<Eigen::Matrix<int, -1, 1, 0, -1, 1> > const&, size_t, Eigen::MatrixBase<Eigen::Matrix<int, -1, -1, 0, -1, -1> > const&, Eigen::MatrixBase<Eigen::Matrix<int, -1, 1, 0, -1, 1> > const&, Eigen::PlainObjectBase<Eigen::Matrix<int, -1, -1, 0, -1, -1> >&);
|
|
template bool igl::copyleft::cgal::propagate_winding_numbers<Eigen::Matrix<CGAL::Epeck::FT, -1, -1, 0, -1, -1>, Eigen::Matrix<int, -1, -1, 0, -1, -1>, Eigen::Matrix<int, -1, 1, 0, -1, 1>, Eigen::Matrix<int, -1, -1, 0, -1, -1> >(Eigen::MatrixBase<Eigen::Matrix<CGAL::Epeck::FT, -1, -1, 0, -1, -1> > const&, Eigen::MatrixBase<Eigen::Matrix<int, -1, -1, 0, -1, -1> > const&, Eigen::MatrixBase<Eigen::Matrix<int, -1, 1, 0, -1, 1> > const&, Eigen::PlainObjectBase<Eigen::Matrix<int, -1, -1, 0, -1, -1> >&);
|
|
#ifdef WIN32
|
|
#endif
|
|
#endif
|