mirror of
https://github.com/OrcaSlicer/OrcaSlicer.git
synced 2026-05-17 10:32:20 +00:00
* Update eigen from v3.3.7 to v5.0.1. This updates eigen from v3.3.7 released on December 11, 2018-12-11 to v5.0.1 released on 2025-11-11. There have be a large number of bug-fixes, optimizations, and improvements between these releases. See the details at; https://gitlab.com/libeigen/eigen/-/releases It retains the previous custom minimal `CMakeLists.txt`, and adds a README-OrcaSlicer.md that explains what version and parts of the upstream eigen release have been included, and where the full release can be found. * Update libigl from v2.0.0 (or older) to v2.6.0. This updates libigl from what was probably v2.0.0 released on 2018-10-16 to v2.6.0 released on 2025-05-15. It's possible the old version was even older than that but there is no version indicators in the code and I ran out of patience identifying missing changes and only went back as far as v2.0.0. There have been a large number of bug-fixes, optimizations, and improvements between these versions. See the following for details; https://github.com/libigl/libigl/releases I retained the minimal custom `CMakeLists.txt`, added `README.md` from the libigl distribution which identifies the version, and added a README-OrcaSlicer.md that details the version and parts that have been included. * Update libslic3r for libigl v2.6.0 changes. This updates libslic3r for all changes moving to eigen v5.0.1 and libigl v2.6.0. Despite the large number of updates to both dependencies, no changes were required for the eigen update, and only one change was required for the libigl update. For libigl, `igl::Hit` was changed to a template taking the Scalar type to use. Previously it was hard-coded to `float`, so to minimize possible impact I've updated all places it is used from `igl::Hit` to `igl::Hit<float>`. * Add compiler option `-DNOMINMAX` for libigl with MSVC. MSVC by default defines `min(()` and `max()` macros that break `std::numeric_limits<>::max()`. The upstream cmake that we don't include adds `-DNOMINMAX` for the libigl module when compiling with MSVC, so we need to add the same thing here. * Fix src/libslic3r/TriangleMeshDeal.cpp for the unmodified upstream libigl. This fixes `TriangleMeshDeal.cpp` to work with the unmodified upstream libigl v2.6.0. loop.{h,cpp} implementation. This file and feature was added in PR "BBS Port: Mesh Subdivision" (#12150) which included changes to `loop.{h,cpp}` in the old version of libigl. This PR avoids modifying the included dependencies, and uses the updated upstream versions of those files without any modifications, which requires fixing TriangleMeshDeal.cpp to work with them. In particular, the modifications made to `loop.{h,cpp}` included changing the return type from void to bool, adding additional validation checking of the input meshes, and returning false if they failed validation. These added checks looked unnecessary and would only have caught problems if the input mesh was very corrupt. To make `TriangleMeshDeal.cpp` work without this built-in checking functionality, I removed checking/handling of any `false` return value. There was also a hell of a lot of redundant copying and casting back and forth between float and double, so I cleaned that up. The input and output meshs use floats for the vertexes, and there would be no accuracy benefits from casting to and from doubles for the simple weighted average operations done by igl::loop(). So this just uses `Eigen:Map` to use the original input mesh vertex data directly without requiring any copy or casting. * Move eigen from included `deps_src` to externaly fetched `deps`. This copys what PrusaSlicer did and moved it from an included dependency under `deps_src` to an externaly fetched dependency under `deps`. This requires updating some `CMakeList.txt` configs and removing the old and obsolete `cmake/modules/FindEigen3.cmake`. The details of when this was done in PrusaSlicer and the followup fixes are at; *21116995d7* https://github.com/prusa3d/PrusaSlicer/issues/13608 * https://github.com/prusa3d/PrusaSlicer/pull/13609 *e3c277b9eeFor some reason I don't fully understand this also required fixing `src/slic3r/GUI/GUI_App.cpp` by adding `#include <boost/nowide/cstdio.hpp>` to fix an `error: ‘remove’ is not a member of ‘boost::nowide'`. The main thing I don't understand is how it worked before. Note that this include is in the PrusaSlicer version of this file, but it also significantly deviates from what is currently in OrcaSlicer in many other ways. * Whups... I missed adding the deps/Eigen/Eigen.cmake file... * Tidy some whitespace indenting in CMakeLists.txt. * Ugh... tabs indenting needing fixes. * Change the include order of deps/Eigen. It turns out that although Boost includes some references to Eigen, Eigen also includes some references to Boost for supporting some of it's additional numeric types. I don't think it matters much since we are not using these features, but I think technically its more correct to say Eigen depends on Boost than the other way around, so I've re-ordered them. * Add source for Eigen 5.0.1 download to flatpak yml config. * Add explicit `DEPENDS dep_Boost to deps/Eigen. I missed this before. This ensures we don't rely on include orders to make sure Boost is installed before we configure Eigen. * Add `DEPENDS dep_Boost dep_GMP dep_MPFR` to deps/Eigen. It turns out Eigen can also use GMP and MPFR for multi-precision and multi-precision-rounded numeric types if they are available. Again, I don't think we are using these so it doesn't really matter, but it is technically correct and ensures they are there if we ever do need them. * Fix deps DEPENDENCY ordering for GMP, MPFR, Eigen, and CGAL. I think this is finally correct. Apparently CGAL also optionally depends on Eigen, so the correct dependency order from lowest to highest is GMP, MPFR, Eigen, and CGAL. --------- Co-authored-by: Donovan Baarda <dbaarda@google.com> Co-authored-by: Noisyfox <timemanager.rick@gmail.com>
188 lines
6.5 KiB
C++
188 lines
6.5 KiB
C++
// This file is part of libigl, a simple c++ geometry processing library.
|
|
//
|
|
// Copyright (C) 2015 Alec Jacobson <alecjacobson@gmail.com>
|
|
//
|
|
// This Source Code Form is subject to the terms of the Mozilla Public License
|
|
// v. 2.0. If a copy of the MPL was not distributed with this file, You can
|
|
// obtain one at http://mozilla.org/MPL/2.0/.
|
|
#ifndef IGL_COPYLEFT_CGAL_CSG_TREE_H
|
|
#define IGL_COPYLEFT_CGAL_CSG_TREE_H
|
|
|
|
#include "../../MeshBooleanType.h"
|
|
#include "string_to_mesh_boolean_type.h"
|
|
#include "mesh_boolean.h"
|
|
#include <CGAL/Exact_predicates_exact_constructions_kernel.h>
|
|
#include <CGAL/number_utils.h>
|
|
|
|
namespace igl
|
|
{
|
|
namespace copyleft
|
|
{
|
|
namespace cgal
|
|
{
|
|
/// Class for defining and computing a constructive solid geometry result
|
|
/// out of a tree of boolean operations on "solid" triangle meshes.
|
|
///
|
|
class CSGTree
|
|
{
|
|
public:
|
|
typedef CGAL::Epeck::FT ExactScalar;
|
|
//typedef Eigen::PlainObjectBase<DerivedF> POBF;
|
|
typedef Eigen::MatrixXi POBF;
|
|
typedef Eigen::Matrix<ExactScalar,Eigen::Dynamic,3> MatrixX3E;
|
|
typedef Eigen::VectorXi VectorJ;
|
|
private:
|
|
/// Resulting mesh vertex positions
|
|
MatrixX3E m_V;
|
|
/// Resulting mesh face indices into V
|
|
POBF m_F;
|
|
/// Birth index of each face in resulting mesh. Birth index is the index
|
|
VectorJ m_J;
|
|
/// Number of birth faces in A + those in B. I.e. sum of original "leaf"
|
|
/// faces involved in result.
|
|
size_t m_number_of_birth_faces;
|
|
public:
|
|
CSGTree()
|
|
{
|
|
}
|
|
//typedef Eigen::MatrixXd MatrixX3E;
|
|
//typedef Eigen::MatrixXi POBF;
|
|
// http://stackoverflow.com/a/3279550/148668
|
|
CSGTree(const CSGTree & other)
|
|
:
|
|
// copy things
|
|
m_V(other.m_V),
|
|
// This is an issue if m_F is templated
|
|
// https://forum.kde.org/viewtopic.php?f=74&t=128414
|
|
m_F(other.m_F),
|
|
m_J(other.m_J),
|
|
m_number_of_birth_faces(other.m_number_of_birth_faces)
|
|
{
|
|
}
|
|
// copy-swap idiom
|
|
friend void swap(CSGTree& first, CSGTree& second)
|
|
{
|
|
using std::swap;
|
|
// swap things
|
|
swap(first.m_V,second.m_V);
|
|
// This is an issue if m_F is templated, similar to
|
|
// https://forum.kde.org/viewtopic.php?f=74&t=128414
|
|
swap(first.m_F,second.m_F);
|
|
swap(first.m_J,second.m_J);
|
|
swap(first.m_number_of_birth_faces,second.m_number_of_birth_faces);
|
|
}
|
|
// Pass-by-value (aka copy)
|
|
CSGTree& operator=(CSGTree other)
|
|
{
|
|
swap(*this,other);
|
|
return *this;
|
|
}
|
|
CSGTree(CSGTree&& other):
|
|
// initialize via default constructor
|
|
CSGTree()
|
|
{
|
|
swap(*this,other);
|
|
}
|
|
/// Construct and compute a boolean operation on existing CSGTree nodes.
|
|
///
|
|
/// @param[in] A Solid result of previous CSG operation (or identity, see below)
|
|
/// @param[in] B Solid result of previous CSG operation (or identity, see below)
|
|
/// @param[in] type type of mesh boolean to compute
|
|
CSGTree(
|
|
const CSGTree & A,
|
|
const CSGTree & B,
|
|
const MeshBooleanType & type)
|
|
{
|
|
// conduct boolean operation
|
|
mesh_boolean(A.V(),A.F(),B.V(),B.F(),type,m_V,m_F,m_J);
|
|
// reindex m_J
|
|
std::for_each(m_J.data(),m_J.data()+m_J.size(),
|
|
[&](typename VectorJ::Scalar & j) -> void
|
|
{
|
|
if(j < A.F().rows())
|
|
{
|
|
j = A.J()(j);
|
|
}else
|
|
{
|
|
assert(j<(A.F().rows()+B.F().rows()));
|
|
j = A.number_of_birth_faces()+(B.J()(j-A.F().rows()));
|
|
}
|
|
});
|
|
m_number_of_birth_faces =
|
|
A.number_of_birth_faces() + B.number_of_birth_faces();
|
|
}
|
|
/// \overload
|
|
CSGTree(
|
|
const CSGTree & A,
|
|
const CSGTree & B,
|
|
const std::string & s):
|
|
CSGTree(A,B,string_to_mesh_boolean_type(s))
|
|
{
|
|
// do nothing (all done in constructor).
|
|
}
|
|
/// "Leaf" node with identity operation on assumed "solid" mesh (V,F)
|
|
///
|
|
/// @param[in] V #V by 3 list of mesh vertices (in any precision, will be
|
|
/// converted to exact)
|
|
/// @param[in] F #F by 3 list of mesh face indices into V
|
|
template <typename DerivedV>
|
|
CSGTree(const Eigen::MatrixBase<DerivedV> & V, const POBF & F)//:
|
|
// Possible Eigen bug:
|
|
// https://forum.kde.org/viewtopic.php?f=74&t=128414
|
|
//m_V(V.template cast<ExactScalar>()),m_F(F)
|
|
{
|
|
m_V = V.template cast<ExactScalar>();
|
|
m_F = F;
|
|
// number of faces
|
|
m_number_of_birth_faces = m_F.rows();
|
|
// identity birth index
|
|
m_J = VectorJ::LinSpaced(
|
|
m_number_of_birth_faces,0,m_number_of_birth_faces-1);
|
|
}
|
|
// Returns reference to resulting mesh vertices m_V in exact scalar
|
|
// representation
|
|
const MatrixX3E & V() const
|
|
{
|
|
return m_V;
|
|
}
|
|
// Returns mesh vertices in the desired output type, casting when
|
|
// appropriate to floating precision.
|
|
template <typename DerivedV>
|
|
DerivedV cast_V() const
|
|
{
|
|
DerivedV dV;
|
|
dV.resize(m_V.rows(),m_V.cols());
|
|
for(int i = 0;i<m_V.rows();i++)
|
|
{
|
|
for(int j = 0;j<m_V.cols();j++)
|
|
{
|
|
dV(i,j) = CGAL::to_double(m_V(i,j));
|
|
}
|
|
}
|
|
return dV;
|
|
}
|
|
// Returns reference to resulting mesh faces m_F
|
|
const POBF & F() const
|
|
{
|
|
return m_F;
|
|
}
|
|
// Returns reference to "birth parents" indices into [F1;F2;...;Fn]
|
|
// where F1, ... , Fn are the face lists of the leaf ("original") input
|
|
// meshes.
|
|
const VectorJ & J() const
|
|
{
|
|
return m_J;
|
|
}
|
|
// The number of leaf faces = #F1 + #F2 + ... + #Fn
|
|
const size_t & number_of_birth_faces() const
|
|
{
|
|
return m_number_of_birth_faces;
|
|
}
|
|
};
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
#endif
|