3 Commits

Include renames

Author	SHA1	Message	Date
Tommaso Bianchi	fac3cf44df	Infer parallel, perpendicular, equal radius and tangent while drawing ... Port of snaporca 2d36d28770. Parity OK: 17 files identical, 8 diverging at their expected counts. infer_axis_constraint returned only Horizontal or Vertical. On the CAD-1000-hours corpus the top two transitions are sketch_dim -> sketch_draw (5896) and back (5756): the signature of geometry that does not self-constrain as it is drawn. Every rule requires the relation to be ALREADY TRUE within tolerance, so nothing the user drew is moved; parallel/perpendicular and tangent additionally require a shared endpoint. TWO LIMITS THE CORPUS RUNG FORCED, neither visible to the unit tests: 1. At most ONE constraint per rule per new entity, not one per PAIR, and no one-at-a-time fallback for the relations batch. EqualRadius has no locality restriction, so 200 equal holes produced ~20000 candidates; the rejected batch then cost a solve per constraint and pinned the app at 95% of a core with the MCP socket unresponsive. 2. Relations only for gesture-sized batches. "A scripted add is not a drawn gesture" is already this file's rule at its bulk call site (snaporca-8xg1), and EqualRadius also couples geometrically distant entities, merging independent connected components and defeating the partitioning that makes large sketches solvable (snaporca-yww4). With the cap alone geometry stayed correct (32/32 sheets clean) but seven of the largest timed out, including MPD681 -- the sheet that call site's own comment names. Also fixes the tolerance leak behind 2: the bulk path asks for exact inference with ang_tol_rad = 0 but len_tol_frac kept its 0.01 default. ALSO independent of this feature: run-kernel-tests.sh defaulted to TAGS=[CadDocument] while four CAD test files carry their own tags and nothing selected them (2624 assertions / 206 cases reported, 7648 / 264 actual). All 58 dark cases were passing; the coverage was never exercised. VERIFICATION LIMIT, as with the previous three commits: this fork's kernel suite still cannot run (find_package(assimp) at configure time, snaporca-w80c). Shared sources are byte-identical to snaporca's, where kernel is 7651 assertions / 265 cases and ALL LADDERS HELD 7/7.	2026-08-31 03:43:08 +02:00
Tommaso Bianchi	a1f2a2687a	Equal radius and Collinear, and one Equal button that knows what it picked ... Port of snaporca 9ec6405e2d. Parity OK: 17 files identical, 8 diverging at their expected counts (DesignPanel.cpp 32, test_slvs_constraints.cpp 3). Measured on the CAD-1000-hours corpus: 51.5% of observed CAD time is 2D sketch work, and dimensioning/constraining alone is 31.9% -- the largest single class. Two constraints every industrial sketcher has were missing here. EqualRadius fixes a dead end rather than adding a feature. Picking two circles and pressing Equal emitted EqualLength, which maps to SLVS_C_EQUAL_LENGTH_LINES and constrains nothing on a curve: a silent no-op with no error. Equal is now one button with two meanings, as in Onshape and SolidWorks. Collinear emits PARALLEL plus PT_LINE_DISTANCE=0 rather than PT_ON_LINE, whose internal valP param this libslvs port leaves at 0, drifting an already-collinear pair. Both types are appended at the END of SketchConstraintType: cereal serializes it positionally, so inserting elsewhere reinterprets every saved recipe. VERIFICATION LIMIT, stated rather than implied: this fork's kernel suite could NOT be run. scripts/CAD/run-kernel-tests.sh fails at CMake configure time on find_package(assimp), before any source compiles -- a pre-existing deps gap (snaporca-w80c), not this change. The shared sources are byte-identical to snaporca's, where the full gate passed: kernel 2588/195 and ALL LADDERS HELD across all seven rungs. Also fixes two defects in this fork's scripts/CAD/run-all-checks.sh: - `cd $(dirname $0)/..` landed in scripts/ instead of the repo root, so every rung looked for itself under scripts/scripts/. Broken since the script moved into scripts/CAD/; the three sibling scripts were fixed then and this was missed, so the gate has not run since. - C defaulted to snaporca-gui, the OTHER fork's rig container, so this fork's gate would drive snaporca's app and report green about the wrong binary. run-kernel-tests.sh:31 documents the identical defect being fixed once already for the build volume; this is the third instance.	2026-08-31 01:09:43 +02:00
Tommaso Bianchi	13d5eac891	Move the Design-tab scripts into scripts/CAD/ and name them by role ... Requested by SoftFever on PR #15238: ten of these had accumulated loose in scripts/ next to ~20 unrelated upstream ones, with names that only meant something to whoever wrote them. They now sit in scripts/CAD/, mirroring the src/libslic3r/CAD/ and src/slic3r/GUI/CAD/ split, and the verb in the name is the role: build- produces a binary, start- brings something up, run- runs a suite, check- asserts one thing against a live app. kernel-test.sh -> CAD/run-kernel-tests.sh ladder-all.sh -> CAD/run-all-checks.sh sketch-ladder.py -> CAD/check-sketch-engine.py ladder-corpus.py -> CAD/check-sketch-engine-corpus.py gui-ladder.py -> CAD/check-gui-sketching.py offer-ladder.py -> CAD/check-gui-context-menu.py mcp-sketch-smoke.py -> CAD/check-mcp-sketch.py rig-build.sh -> CAD/build-gui.sh docker-iter-build.sh -> CAD/build-gui-incremental.sh gui-session.sh -> CAD/start-headless-gui.sh "Ladder" was the worst of them: it named the shape of the test (rungs of increasing difficulty) rather than what the test proves, so nothing in the directory listing told you which one needed a GPU and which was pure kernel. Every reference rewritten -- the docs, the cross-calls between the scripts, Dockerfile.deps, and the container-side /OrcaSlicer/scripts paths. The three shell scripts resolve REPO relative to themselves and now sit one level deeper, so that walk went from /.. to /../.. . The copies these push into a container's /tmp were renamed to match, or the container would have kept the old names alive. Two runtime paths deliberately NOT renamed. /tmp/orca-rig-build.lock is a cross-fork contract -- both forks take the same lock so two concurrent builds serialise instead of OOMing the box, and renaming it on one side silently removes that guard. /tmp/gui-session.log is a runtime artefact, not a script. Added scripts/CAD/README.md: what each script proves, what it needs, and the two constraints that have each cost a session (never build inside the GUI container; a window manager is required or synthetic keys are ignored). On CI, which was the other half of the request: the kernel suite is already there and always has been. The cases are registered in tests/libslic3r/CMakeLists.txt under if (SLIC3R_CAD), which defaults ON and no workflow turns off, so they build into libslic3r_tests and run under ctest on every platform via unit_tests.yml -- like any other unit test, needing no new job. They have simply never been seen to run, because the workflows on this PR are still awaiting maintainer approval. run-kernel-tests.sh is the local loop over the same cases, and it is the only script here CI could run: the other six need an OpenGL canvas and synthetic input. Verified: scripts/CAD/run-kernel-tests.sh from its new location, all tests passed, 2562 assertions in 190 test cases.	2026-08-28 19:34:03 +02:00