6 Commits

Include renames

Author	SHA1	Message	Date
harrierpigeonandClaude Fable 5.1	cfad587c2d	Belt: follow-ups from a second review pass ... Guard the layer count and the per-object layer collection against an object that is left without a layer to print on a belt (the counting loop stepped before begin() and front() was taken of an empty vector). Check the belt temperature tower's embossed model before the current project is replaced, not after. Only invalidate the support step of objects that own a belt brim when an object is added or removed. The empty-layers test now counts an extrusion only where material is laid down along a move. The BeltBrim.cpp SEQUENCING note says exactly which layers are read, and the machine-frame scale is 1/|sin|. Remove more code that nothing calls: the kinematics inverse (to_logical, apply_axis_remap_inverse, to_build_volume and the state kept for them), the world_coordinates(), is_active() and belt_brim_areas_by_layer() accessors, the PrintConfig overload of physical_tilt() and the DynamicPrintConfig overload of compute_belt_height_and_floor(). Comments in GCode.hpp, BeltSliceStrategy.hpp/.cpp and PrintObjectSlice.cpp that described the retired pre-slice remap and plane-evaluator still did; the purge-tower width tooltip named the wrong switch. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>	2026-10-07 19:08:59 -05:00
harrierpigeonandClaude Fable 5.1	dda58b07cd	Belt printer: supports reach the belt under a leading overhang ... The slicing frame of a belt object started at its lowest vertex, but the belt under the leading end of an overhang lies below that, by the overhang's length times the tilt's shear. Every support generator works in layers at z >= 0, so none of them could reach it: normal supports stopped at the object's own lowest layer, and the two tree generators each carried a stack of hacks to extend themselves below it (a post-hoc copy of the lowest base area in TreeSupport, "virtual belt raft layers" in TreeSupport3D/TreeModelVolumes), sized from the pre-rotation bbox and capped at global z = 0, which is only right for the trailing half of the belt. Start the frame at the lowest belt-floor point under the footprint instead, less a 10 mm margin along the belt for the base of a support column (BeltSliceStrategy::apply_preslice_transforms and BeltTransformPipeline::compute_belt_height_and_floor agree on it). The layers between it and the first vertex come out empty, which belt slicing already tolerates, and the generators need no extension at all: - normal supports: the generator anchors its layer grid at the frame origin, so run it in the object frame and shift the global belt Z offset onto the result afterwards, as organic supports already did. With the offset on the object layers a top contact at negative z turned the intermediate-layer count negative and the generator allocated layers until the kernel killed it (any overhang in the leading half of the belt). Drop the first-layer flange expansion on a belt: the first support layer is the leading tip of the support, not a flange, and inflating it put lines in the air ahead of the belt. - classic tree: a node now keeps dropping until its whole circle is in the belt, so the branch tapers to a tip on the belt instead of stopping, a radius above it, when its centre crosses. - organic: the belt is no longer a support blocker. A blocker is a collision, and a branch descending onto one slides off it, down the tilted belt and ahead of the part; the belt is where branches end, which the per-layer m_belt_floor clipping already does. The belt brim is generated after the parallel support step instead of inside it: belt_brim_obstacles() reads every object's layers and support layers, which another object's support step rebuilds (and, now, shifts) at the same time. This is the race behind the Windows arm64 segfault in "Belt brim of each object precedes its perimeters on its own filament". Also: the belt tilt axis moves to Developer mode as its own row (a shared line is shown by its first option's mode), first_layer_plane band thickness, belt_support_floor_mode, belt_preslice_global and gcode_back_transform are retired and presumed on, the gravity arrow is a plain line along the up direction, and the "Show raw G-code (belt only)" preview toggle is gone. Regression test: "Belt supports reach the belt under a leading overhang" slices a cube with a fin whose underside is parallel to the layers, 20 mm ahead of the cube and up to 41 mm of slicing Z above the belt, for normal, organic and classic tree supports, and checks that the lowest support layer sits on the belt beneath its own lines. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>	2026-10-06 22:14:25 -05:00
harrierpigeonandClaude Fable 5.1	8039d4d2ac	Belt printer: retire the redundant and unused options ... Removed, with the keys added to handle_legacy()'s ignore list so saved profiles and 3MFs keep loading: - belt_slice_rotation_global and preslice_remap_global. Both were only consulted when belt_preslice_global ("Global mesh transforms") was off, which no profile does; belt_preslice_global is now the single global mode and is presumed on everywhere the old flags were ORed in (PrintObjectSlice, BeltBackTransform, BeltGCode, Print::process, PrintApply). The Belt tilt row is axis + angle only. - preslice_remap_x/y/z. No profile used the pre-slice axis remap; the belt tilt axis plus the G-code axis remap cover the machines that exist, and its implementation only agreed with itself for a plain swap (matrix columns vs remap_bbox rows). BeltTransformPipeline::build_preslice_remap, remap_bbox and has_preslice_remap are gone, the forward transform is the rotation, and the G-code header no longer carries the remap. - belt_support_z_offset_mode. Saved and invalidated steps, but no support generator read it. - first_layer_plane and first_layer_plane_offset, with FirstLayerPlane.cpp. On every shipped configuration the band is measured from the belt surface (GCode::belt_height_above_floor) and the evaluator was only reached for an explicit XY/YZ/XZ choice or a non-zero offset, which nobody set. first_layer_plane_thickness stays as the band unit, relabelled "First layer band thickness". UI: the Machine frame transforms group is five single-option rows (G-code remap X / Y / Z, Decouple machine-frame tilt, Machine-frame tilt angle; the angle row is shown only when decoupled) instead of two multi-column lines, and the remap fields carry full labels. Also carries the phong.fs struct fix from #16226 so the worktree build links its shaders. libslic3r_tests and fff_print_tests pass; clang-tidy diff check clean; orca_profile_tool.py check clean. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>	2026-10-06 18:14:34 -05:00
harrierpigeonandClaude Opus 5	e695da66df	GCodeWriter: extract MachineKinematics, delete BeltGCodeWriter ... BeltGCodeWriter subclassed GCodeWriter and overrode seven methods, five of them by copying the base body and changing the transform. The base writer already carried an axis remap and already branched at each of its seven coordinate-emission decisions; the subclass did the same branching with a different transform, and the two copies had begun to drift. Replace the inheritance with a strategy object owned by GCodeWriter: CartesianKinematics to_machine = the existing apply_axis_remap; today's base behaviour, moved rather than changed. BeltKinematics to_machine = MachineFrameTransform o axis_remap o BeltBackTransform, plus a world_coordinates variant for the PA calibration generators. New: src/libslic3r/GCode/MachineKinematics.{hpp,cpp}, GCode/BeltKinematics.{hpp,cpp} Deleted: src/libslic3r/BeltGCodeWriter.{hpp,cpp} (341 lines) Points worth a reviewer's attention: * The predicate is must_emit_all_axes(), not couples_axes(). The base returns true for any non-identity remap, including pure permutations that do not physically couple axes, so the question is "must every axis word be emitted", not a statement about kinematics. * Every per-site word-omission branch is preserved. The base deliberately emits X/Y only, or Z only, or drops Z when its quantised value is unchanged. The strategy changes which transform applies, never whether words are omitted. * set_kinematics() replays the configured remap and build volume onto a newly installed strategy, because BeltGCode::init_belt_writer runs before GCode.cpp calls set_axis_remap/set_build_volume_max. * uses_pointwise_travel_speed() preserves a pre-existing divergence rather than introducing one: the base travel_to_xyz emits the raw configured travel speed in its final branch, ignoring the first-layer value computed at the top, whereas the belt path used the first-layer-aware value throughout. Both are kept. Unifying them changes feedrates and belongs in its own change. * The [BELT-DEBUG] block is deleted; it rate-limited itself with a function-local static thread_local in the hot emission path, and this is the commit that would otherwise have moved it into shared code. This commit is intended to preserve existing export output. That is reviewed by construction -- each emission site keeps its own omission branch and each policy divergence is preserved -- and is NOT verified against a G-code diff corpus. Building that corpus is the outstanding work here. Two API-equivalence exceptions, neither reachable by any caller today: * Belt kinematics with no plane pointer installed, m_is_first_layer true, initial and normal travel speeds differing, travel_to_xyz() reaching its final branch: the old belt writer selected the initial-layer speed, the new writer selects the normal travel speed. The pending-lift and XY-only branches keep their previous selection. * Belt kinematics installed without set_force_normal_lift(true) and a non-normal lift requested: the old belt writer forced a normal lift, the new writer can take the slope branch. The PA-pattern generator reaches the writer through explicit travel_to_z() / travel_to_xy(), not travel_to_xyz() or the lazy/eager lift paths, and normal belt export installs both the plane and the forced-normal-lift policy, so neither exception changes output produced today. They are recorded because a future caller could reach them. tests/fff_print/test_gcodewriter.cpp was also not compiling before this branch: it called writer.to_machine_coords(), a method that existed only on BeltGCodeWriter. It never surfaced because the build targets OrcaSlicer, not all, and BUILD_TESTS defaults to OFF, so that translation unit was outside every compile path. Fixed here; the existing 30-degree coordinate assertions are kept verbatim as the best available regression net. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011jgzj1sf53KMLPweZ8yeUQ	2026-09-08 23:57:55 -05:00
harrierpigeon	44eebdb8ad	Part 3.2: decouple axis remapping, enable viewing settings in Developer mode or when Belt mode is active	2026-03-30 13:25:40 -05:00
harrierpigeon	b297f68921	Part 2.7: Add G-code back-transform and tree support belt floor clipping ... - Add BeltBackTransform class that inverts the shear/scale matrix and applies it in GCodeWriter::to_machine_coords() so G-code outputs in the machine's physical coordinate space, gated by new belt_gcode_back_transform config option - Extend belt floor clipping to all three tree support pipelines (Prusa-style, Orca organic, TreeModelVolumes) with per-layer polygon clipping, anti-overhang integration, and belt raft extension layers - Fix tree drop_nodes() belt termination, organic support global Z offset, collision calculation index bug, and first-layer brim/empty layer checks for belt printers two-shot - first build built but didn't plumb to UI. Woah. add pre-slice axis remap, because Y needs to be Z going to change tactic and move based on bbox min switch to per axis snapping per axis swap snap now per object build plate tilt wasn't invalidating slicer settings support upper bound now correct, need to get lower bound corrected axis swapped support termination corrected Z Shear works with and without pre-slice remap now	2026-03-30 13:25:40 -05:00