1 Commits

Include renames

Author	SHA1	Message	Date
Kris Austin	9409598c2a	ci: run the unit-test suite under the flatpak build's bounds-checked STL (#14709) ... * ci(flatpak): run the unit suite in a separate job, mirroring the other arches Alternative to the in-job step: split build and test like the Linux/Windows/ macOS legs. The flatpak build now builds the test binaries in-sandbox (the action's run-tests fires the module's build-only test-commands), prunes the kept build tree to the test binaries + CTest metadata + data, and uploads it with /app as a test asset (size reported to the run summary). A new unit_tests_flatpak matrix job downloads that asset on a native runner, restores the module-build symlink, and runs the suite via flatpak-builder --run (which bind-mounts /run/build so TEST_DATA_DIR resolves) against the GNOME SDK's bounds-checked STL. Results feed publish_test_results. Costs a per-arch asset upload/download + a runtime install on the test runner; the trade-off vs the in-job step is a genuine separate graph box. * ci(flatpak): run tests via `flatpak build` to avoid rofiles-fuse `flatpak-builder --run` sets up a rofiles-fuse overlay that this CI container rejects (Failure spawning rofiles-fuse, exit_status: 256), even in a fresh job with a machine-id and the runtime installed, and --disable-rofiles-fuse is not accepted in --run mode. `flatpak build` enters the sandbox via bwrap directly, so it sidesteps rofiles-fuse; bind-mounting the build tree at /run/build gives the same path the compiled-in TEST_DATA_DIR expects. * ci(flatpak): slim the test asset (strip binaries, drop source tree) The first cut shipped ~1 GB: the test exes carried debug info (the SDK builds with -g and only the app gets stripped) and the packaged module dir included the whole copied source tree the tests never read at runtime. Strip the test binaries and keep only build_flatpak/tests, tests/ (TEST_DATA_DIR) and scripts/. The irreducible remainder is /app, which the exes link against. * ci(flatpak): extract the test run into a reusable unit_tests_flatpak workflow Move the flatpak test job out of build_all.yml into a reusable unit_tests_flatpak.yml, called once per arch (Flatpak x86_64 / aarch64) the same way the other arches call unit_tests.yml. build_all.yml keeps only the build + asset packaging; the reusable workflow downloads the asset, runs the suite via `flatpak build`, and uploads results as test-results-<artifact> for publish_test_results. Drops the now-unused manifest checkout (flatpak build does not need it). * ci(flatpak): trim comments to the non-obvious No behavior change. * ci(flatpak): drop redundant caller comment * ci(flatpak): drop redundant trim comment * ci(flatpak): drop size-report scaffolding and redundant if-guards * ci(flatpak): force the app module to rebuild so the test asset always exists flatpak-builder caches modules by content hash and skips a hit, producing no build tree and no test asset, so a re-run of the same commit would leave the separate test job with nothing to download. Inject a per-run cache-buster into the OrcaSlicer module's build-options (part of its cache key) so it always rebuilds, mirroring how the other arches cache only deps and always rebuild the app and tests. The deps modules stay cached. * ci(flatpak): trim cache-buster comment, fix stale step name * fix: guard H2C per-filament array reads against short config arrays The H2C tool-ordering, wipe-tower, and g-code export paths index per-filament config arrays by filament/tool id. A config with fewer entries than the filament count (partial or legacy projects, minimal test configs) makes these reads run past the end of the vector: silent under a normal STL, but UB that aborts under the flatpak build's bounds-checked STL (_GLIBCXX_ASSERTIONS). Route the reads through the existing clamping accessors (get_at, get_filament_category, is_in_same_extruder) and add a small clamp helper for filament_change_length. The guards are no-ops when the arrays are sized to the filament count, so correctly specified configs are unaffected. * ci(flatpak): build filament_group_tests too The suite landed on main after this branch was cut and arrived via a later merge, so it was missing from the target list and ctest failed the leg with filament_group_tests_NOT_BUILT. Not tests/all, which build_linux.sh uses: that is a Ninja subdirectory target and this build configures with the default Makefile generator, where it does not exist. * ci(flatpak): give the embedded-interpreter tests a valid Python home python_test_support.hpp sets PyConfig.home to <testdir>/python when that path resolves. WIN32/APPLE populate it with a copied bundled runtime; the flatpak leg had no such branch, so home resolved to a directory with no stdlib and all 21 embedded plugin tests failed at "failed to get the Python codec of the filesystem encoding". Symlink <testdir>/python to the bundled /app/libpython that already ships in the flatpak (the test exe links libpython3.12.so from there via rpath), so the interpreter initializes without duplicating the runtime. * ci(flatpak): sync the ToolOrdering guard mirror with #14789 Match #14709's build_filament_group_context guard to the version on #14789 (size filament_info to filament_nums, truncate filament_ids) so the folded guard is a byte-identical mirror that drops cleanly when #14789 merges, instead of leaving a stale hunk that conflicts on rebase. * fix: guard WipeTower per-filament array reads against short config arrays The BambuStudio WipeTower sync reintroduced raw per-filament array indexing that reads out of bounds when a config leaves an array shorter than the filament count: m_physical_extruder_map in format_line_M104/M109 (indexed even when empty), and m_filament_categories in get_wall_skip_points and get_wall_filament_for_all_layer. Silent on a normal STL, a hard abort under the bounds-checked STL the Flatpak build uses. Bounds-check the physical extruder map before indexing (omitting the T token, as the existing -1 path already does), and route the two raw m_filament_categories reads through the clamping get_filament_category() accessor the surrounding code already uses. No change for correctly-sized configs. * fix: default-initialize WallToolPathsParams fields min_length_factor and is_top_or_bottom_layer had no default initializers, and the FillConcentric/FillConcentricInternal callers never set them, so WallToolPaths::removeSmallLines() thresholded on stack garbage. Which short extrusion lines it dropped then depended on memory layout, so concentric solid-infill output was nondeterministic between runs and across machines. Give every member a default, matching the adjacent FillParams. The perimeter path was already fine because it builds the struct via make_paths_params(). * fix: bounds-check the toolchange flush-volume and HRC per-filament lookups GCode::set_extruder's toolchange flush-volume lookup and GCodeProcessor::update_slice_warnings's HRC check index per-filament and per-extruder arrays (flush_volumes_matrix, the filament map, the nozzle list) by filament/extruder id. When a config leaves one of those arrays shorter than the filament count (partial or legacy multi-extruder projects, minimal configs), the reads run off the end: silent on a normal STL, a hard abort under _GLIBCXX_ASSERTIONS. Route both reads through bounds checks: the flush lookup falls back to no flush, matching the existing unknown-old-filament branch beside it, and the HRC check skips an unmapped filament, mirroring the required_nozzle_HRC guard on the line above. When the arrays are sized to the filament count the values are unchanged, so correctly-specified configs are unaffected. * ci: retrigger checks * ci: name the flatpak rebuild token after the cache it defeats Since #15650 the Flatpak job also has a compiler cache, so a bare "cache-buster" no longer says which cache is meant. Call it flatpak_builder_cache_buster, and name the build-dir trim step after the flatpak-builder cache save it keeps lean. * ci: ship resources/profiles and resources/printers in the flatpak test asset Two slic3rutils tests added in 4aa0e1d60b read resources/printers/bambu_filament_ids.json through PROFILES_DIR/.., and the asset dropped resources/ entirely, so both failed parsing an empty stream on each Flatpak leg. Keep the two subtrees the tests reach; test_gcodewriter's shipped-profile case stops skipping on this leg too. * ci: restore the CRLF line endings of build_all.yml The last merge from upstream/main rewrote the file with LF endings, which turns the 60-line change into a whole-file diff on GitHub. Upstream has had this file as CRLF since it was created, so put it back. * ci: trigger Build all on changes to the unit-test workflows The path filters only matched build_*.yml, so an edit to unit_tests.yml or unit_tests_flatpak.yml could merge without ever running. * ci: put a timeout on the flatpak unit-test step Matches the 20 minutes of the regular unit-test workflow; without it a hung test holds the runner for the six-hour job default.	2026-09-15 12:41:46 -03:00