juli/OrcaSlicer
1
1
Fork 0
mirror of https://github.com/OrcaSlicer/OrcaSlicer.git synced 2026-09-27 02:41:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Name the missing parent when a dropped preset is resolved from the CLI

Browse Source 
When load_presets() drops a preset because its parent does not exist, the
only trace is a log line. The CLI then resolves --load-settings /
--load-filaments against the loaded bundle and reports "Preset was not found
in the loaded bundle", which points at the resolver rather than at the real
cause.

Record the presets dropped for a missing parent in the collection, keyed by
file, and have resolve_preset_config() report that parent by name when the
source file is one of them.
This commit is contained in:
Hanif Koh
2026-09-09 18:28:53 +08:00
parent fb44569b8e
commit f7812bf0f1
4 changed files with 33 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/libslic3r/test_preset_bundle_loading.cpp
+10 -2
View File
@@ -411,8 +411,8 @@ TEST_CASE("A preset whose parent exists nowhere is reported, not loaded", "[Pres
ScopedTemporaryDir temp_dir;
PresetBundle bundle;
write_sparse_preset(temp_dir.path() / PRESET_PRINT_NAME / "Orphan.json", "Orphan", "No Such Parent",
{{"layer_height", "0.15"}});
const fs::path orphan_file = temp_dir.path() / PRESET_PRINT_NAME / "Orphan.json";
write_sparse_preset(orphan_file, "Orphan", "No Such Parent", {{"layer_height", "0.15"}});
PresetsConfigSubstitutions substitutions;
bundle.prints.load_presets(temp_dir.path().string(), PRESET_PRINT_NAME, substitutions,
@@ -420,6 +420,14 @@ TEST_CASE("A preset whose parent exists nowhere is reported, not loaded", "[Pres
CHECK(bundle.prints.find_preset("Orphan") == nullptr);
CHECK(bundle.has_errors());
CHECK(bundle.prints.unresolved_parent(orphan_file) == "No Such Parent");
// Resolving the dropped file names the missing parent instead of reporting the file as unknown.
DynamicPrintConfig config;
std::string error;
CHECK_FALSE(bundle.resolve_preset_config(config, Preset::TYPE_PRINT, orphan_file.string(),
ForwardCompatibilitySubstitutionRule::Disable, error, false));
CHECK(error == "Preset was not loaded because its parent preset \"No Such Parent\" was not found");
}
TEST_CASE("Presets inheriting each other in a cycle are reported, not loaded", "[Preset][Inherits][Regression]")