From f599ff0ff7b70c2fc03cb3120a291e9d02d50ffa Mon Sep 17 00:00:00 2001 From: Tommaso Bianchi Date: Sun, 26 Jul 2026 09:08:33 +0200 Subject: [PATCH] kernel-test.sh: one quarantined case now, not two Follow-through from eeca6794e7. The header claimed two pre-existing failures are excluded and named both; the internal-thread case now runs like any other, so only the solver SIGABRT is left. A comment that lists a test which is no longer excluded sends the next reader looking for something that is not there. Co-Authored-By: Claude Opus 5 (1M context) --- scripts/kernel-test.sh | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/scripts/kernel-test.sh b/scripts/kernel-test.sh index 031c11342d..256de380c1 100755 --- a/scripts/kernel-test.sh +++ b/scripts/kernel-test.sh @@ -31,12 +31,14 @@ IMAGE="${IMAGE:-orcacad-deps}" # this fork at it makes the two silently trade build artefacts. docker-iter-build.sh had the # identical defect and was fixed to orcacad_buildcache; this script was missed. VOL="${BUILD_VOL:-orcacad_kerneltest}" -# Two pre-existing failures are excluded by default (see [known-broken] in -# test_caddocument.cpp): one of them SIGABRTs inside the vendored solver and takes the +# ONE pre-existing failure is excluded by default (see [known-broken] in +# test_caddocument.cpp): it SIGABRTs inside the vendored solver and takes the # whole process down, so without this exclusion a green run is simply unreachable and the -# suite stops after ~12 of 32 cases. Both are also tagged [NotWorking], the ctest label -# the mainline fork's CI excludes, so they no longer redden its Unit Tests job on every -# commit; they stay tracked as snaporca-tkz and snaporca-kzy rather than as CI noise. +# suite stops after ~12 of 32 cases. It is also tagged [NotWorking], the ctest label the +# mainline fork's CI excludes, so it no longer reddens the Unit Tests job on every commit; +# it stays tracked as snaporca-tkz rather than as CI noise. The internal-thread case that +# used to sit alongside it is gone from this exclusion: its geometry was correct and the +# test's reference was wrong (snaporca-kzy), so it now runs like any other. TAGS="${TAGS:-[CadDocument]~[known-broken]}" HOST=""