juli/OrcaSlicer
1
1
Fork 0
mirror of https://github.com/OrcaSlicer/OrcaSlicer.git synced 2026-09-18 14:32:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tag the two known-broken tests [NotWorking] so CI stops being red on every commit

Browse Source 
This fork's Unit Tests job failed on every single commit, because CI runs the
whole ctest suite including the two cases tagged [known-broken] that
scripts/kernel-test.sh has always excluded locally. A job that is red
unconditionally is worse than no job: it trains everyone to ignore it, so the
next genuine regression arrives invisible.

No workflow change was needed. scripts/run_unit_tests.sh already passes
-LE NotWorking, and tests/CMakeLists.txt registers Catch2 tags as ctest labels
via catch_discover_tests(ADD_TAGS_AS_LABELS) — so the exclusion upstream
already ships works as soon as the cases carry the tag. Verified against the
built test tree: 337 tests unfiltered, 335 with -LE NotWorking, i.e. exactly
these two dropped and nothing else.

The second cause recorded in the issue, the test-reporter step failing with
"Resource not accessible by integration: 403" on a fork, is already fixed
upstream: the Publish Test Results step now carries continue-on-error: true.

The comment these cases carried claimed CI kept the bugs visible by reporting
them forever. That is now false and was never a good mechanism anyway, so
visibility moves to the tracker: snaporca-tkz for the solver SIGABRT, and
snaporca-kzy, filed now, for the thread groove volume. Neither is fixed;
neither is forgotten.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Tommaso Bianchi
2026-07-26 08:13:08 +02:00
co-authored by Claude Opus 5
parent b25335e1b3
commit f13f2876f6
2 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/kernel-test.sh
+3 -1
View File
@@ -34,7 +34,9 @@ VOL="${BUILD_VOL:-orcacad_kerneltest}"
# Two pre-existing failures are excluded by default (see [known-broken] in
# test_caddocument.cpp): one of them SIGABRTs inside the vendored solver and takes the
# whole process down, so without this exclusion a green run is simply unreachable and the
# suite stops after ~12 of 32 cases. CI runs everything and still reports both.
# suite stops after ~12 of 32 cases. Both are also tagged [NotWorking], the ctest label
# the mainline fork's CI excludes, so they no longer redden its Unit Tests job on every
# commit; they stay tracked as snaporca-tkz and snaporca-kzy rather than as CI noise.
TAGS="${TAGS:-[CadDocument]~[known-broken]}"
HOST=""