mirror of
https://github.com/OrcaSlicer/OrcaSlicer.git
synced 2026-10-10 17:21:10 +00:00
Stop Exporting Names Through Usings in GUI and Voronoi Headers (#16223)
Each of these headers put a using or namespace alias at global or namespace scope, which every includer inherited: - BBLTopbar.hpp: "using namespace Slic3r::GUI;" at global scope, reached through MainFrame.hpp. Seven source files used GUI names unqualified outside the namespace because of it, one of them as "::RadioBox". - IMSlider.hpp and TickCode.hpp: "using namespace CustomGCode;" inside Slic3r. - ProjectTask.hpp, Jobs/PrintJob.hpp and ConfigWizard_private.hpp: "namespace fs = boost::filesystem;". PresetBundle.cpp and GUI_App.cpp had no alias of their own. - VoronoiUtils.hpp: "using VD = Slic3r::Geometry::VoronoiDiagram;" at global scope. The headers now spell the names out. Source files that used them get the qualifier, or a using of their own where there are many uses.
This commit is contained in:
@@ -115,7 +115,7 @@ static void set_auth(Http& http, const std::string& access_token) { http.header(
|
||||
|
||||
static bool should_open_in_external_browser()
|
||||
{
|
||||
const auto& app = wxGetApp();
|
||||
const auto& app = GUI::wxGetApp();
|
||||
|
||||
if (app.preset_bundle->use_bbl_device_tab()) {
|
||||
// When using bbl device tab, we always need to open external browser
|
||||
|
||||
Reference in New Issue
Block a user