Sync cad-mainline with upstream main and carry the value-field + rename work on top

src/libslic3r/AppConfig.cpp

@@ -325,7 +325,7 @@ void AppConfig::set_defaults()
     // Design tab: draw a mate connector as a face rather than as the abstract disc + roll
     // quadrant. Defaults ON — face orientation is hardwired perception, so the roll and the
     // verse read without being learned, which no abstract glyph achieves. Turning it off
-    // restores the conventional CAD representation for users who expect it (snaporca-x0kd).
+    // restores the conventional CAD representation for users who expect it (x0kd).
     if (get("design_connector_face_glyph").empty())
         set_bool("design_connector_face_glyph", true);
 #endif

src/libslic3r/CAD/CadDocument.cpp

@@ -2142,7 +2142,7 @@ TopoDS_Wire CadDocument::build_sketch_wire(const CadFeature& sketch, bool closed
         // legacy tail of this function ends in a default rectangle built from width/height,
         // which for an entity sketch are whatever they happened to be initialised to — so a
         // sketch entities_to_wire cannot handle (a circle coexisting with a line, two circles:
-        // snaporca-88v) used to extrude into a box the user never drew, silently. Failing here
+        // 88v) used to extrude into a box the user never drew, silently. Failing here
         // costs the caller an error message; falling through cost them wrong geometry that
         // looked deliberate. The legacy profile/shape paths below are still reached by sketches
         // that legitimately carry no entities at all.
@@ -2751,7 +2751,7 @@ void CadDocument::apply_feature(TopoDS_Shape& result, bool& have_body,
         // Neutral plane = horizontal plane through the body's bbox bottom, pull direction +Z.
         // The face pivots about the line where it meets the neutral plane and tilts by the angle.
         // ponytail: neutral plane / pull direction fixed to world up; pick-based neutral plane
-        // deferred (same as the datum-plane pick types, snaporca-dgv).
+        // deferred (same as the datum-plane pick types, dgv).
         Bnd_Box bb; BRepBndLib::Add(result, bb);
         Standard_Real xmin, ymin, zmin, xmax, ymax, zmax;
         bb.Get(xmin, ymin, zmin, xmax, ymax, zmax);
@@ -3537,7 +3537,7 @@ void CadDocument::apply_mate(std::vector<CadBody>& bodies, const CadFeature& f)
 }
 
 // Volume of a shape, 0 for anything that isn't a solid we can measure. Used to catch a
-// subtraction that removed nothing (snaporca-daf).
+// subtraction that removed nothing (daf).
 static double solid_volume(const TopoDS_Shape& s)
 {
     if (s.IsNull()) return 0.0;
@@ -3591,7 +3591,7 @@ void CadDocument::route_feature(std::vector<CadBody>& bodies, const CadFeature&
         // an agent especially — then has no signal at all that the hole it asked for was never
         // drilled: same body, same volume, ok:true. Measure the volume across the op and refuse
         // the no-op. Only for removals: every other feature type may legitimately leave the volume
-        // alone (a Transform certainly does). snaporca-daf.
+        // alone (a Transform certainly does). daf.
         const bool removes = f.type == CadFeatureType::Hole
                           || f.type == CadFeatureType::Thread
                           || ((f.type == CadFeatureType::Extrude || f.type == CadFeatureType::Revolve
@@ -3625,7 +3625,7 @@ bool CadDocument::recompute()
     // made a sketch-only design unsaveable AND unopenable: DesignPanel::recompute_guarded syncs
     // the 3MF recipe only "on success", so nothing was written, and deserialize_recipe ends with
     // `return recompute()`, so a project that did carry a recipe was refused on load with
-    // "Could not restore the CAD model" while its features sat correctly in the list. snaporca-mtav.
+    // "Could not restore the CAD model" while its features sat correctly in the list. mtav.
     bool any_solid_feature = false;
     try {
         // Parametric pass: evaluate document variables, then each feature's expression bindings,

src/libslic3r/CAD/SketchSolver.cpp

@@ -403,7 +403,7 @@ static SketchSolveResult solve_system(std::vector<SketchEntity>& entities,
     // from the corpse. The fillet degrade ladder hit this on every corner — rung 1 (a
     // tangent on each leg) is legitimately over-constrained against the legs' own H/V, and
     // its wreckage then failed rungs 2 and 3, which solve cleanly on their own. The arc
-    // ended up with no constraints at all and the solver snapped the corner shut. snaporca-pl5.
+    // ended up with no constraints at all and the solver snapped the corner shut. pl5.
     if (!out.ok) return out;
     for (size_t i = 0; i < entities.size(); ++i) {
         SketchEntity& e = entities[i];