mirror of
https://github.com/OrcaSlicer/OrcaSlicer.git
synced 2026-09-11 02:57:39 +00:00
Update sublayer option check. Add validation warning for gradient mixed filament without sublayer mixing
This commit is contained in:
@@ -1328,6 +1328,19 @@ StringObjectException Print::validate(std::vector<StringObjectException> *warnin
|
||||
if (extruders.empty())
|
||||
return { L("No extrusions under current settings.") };
|
||||
|
||||
// Orca: a gradient mixed filament only renders its gradient with "Mixed color sublayer" on;
|
||||
// without it ToolOrdering::resolve_mixed_filaments prints one whole component per layer and
|
||||
// the gradient is dropped silently. extruders() already covers painting, height ranges,
|
||||
// per-feature filament ids and supports, and still lists mixed slots under their own id here.
|
||||
if (!m_config.enable_mixed_color_sublayer.value) {
|
||||
const auto &is_mixed = m_config.filament_is_mixed.values;
|
||||
const auto &gradient = m_config.filament_mixed_gradient.values;
|
||||
if (std::any_of(extruders.begin(), extruders.end(), [&](unsigned int e) {
|
||||
return e < is_mixed.size() && is_mixed[e] && e < gradient.size() && gradient[e]; }))
|
||||
warn(L("A gradient mixed filament is used, but 'Mixed color sublayer' is disabled. The gradient will not be printed."),
|
||||
"enable_mixed_color_sublayer");
|
||||
}
|
||||
|
||||
if (nozzles < 2 && extruders.size() > 1) {
|
||||
auto ret = check_multi_filament_valid(*this);
|
||||
if (!ret.string.empty())
|
||||
|
||||
@@ -23,8 +23,6 @@
|
||||
#include "GradientCurveEditor.hpp"
|
||||
#include "FilamentBitmapUtils.hpp"
|
||||
#include "wxExtensions.hpp"
|
||||
#include "Tab.hpp"
|
||||
#include "libslic3r/Preset.hpp"
|
||||
#include "Widgets/Button.hpp"
|
||||
#include "Widgets/CheckBox.hpp"
|
||||
#include "Widgets/ComboBox.hpp"
|
||||
@@ -1492,28 +1490,6 @@ void MixedFilamentDialog::on_ratio_changed(int new_ratio_a)
|
||||
|
||||
void MixedFilamentDialog::on_gradient_toggled()
|
||||
{
|
||||
// Orca: a gradient is only sliced when the print profile's "enable_mixed_color_sublayer"
|
||||
// option is on; without it ToolOrdering picks a single component per whole layer. Offer to
|
||||
// turn the option on instead of silently ignoring the gradient the user just enabled.
|
||||
bool checked = m_chk_gradient->GetValue();
|
||||
|
||||
if (checked) {
|
||||
auto& print_config = wxGetApp().preset_bundle->prints.get_edited_preset().config;
|
||||
if (!print_config.opt_bool("enable_mixed_color_sublayer")) {
|
||||
wxMessageDialog dlg(this,
|
||||
_L("Gradient effect requires 'Mixed color sublayer' to be enabled. Enable it now?"),
|
||||
_L("Mixed Color Sublayer"),
|
||||
wxYES_NO | wxICON_QUESTION);
|
||||
if (dlg.ShowModal() == wxID_YES) {
|
||||
DynamicPrintConfig new_conf;
|
||||
new_conf.set_key_value("enable_mixed_color_sublayer", new ConfigOptionBool(true));
|
||||
wxGetApp().get_tab(Preset::TYPE_PRINT)->load_config(new_conf);
|
||||
} else {
|
||||
m_chk_gradient->SetValue(false);
|
||||
return;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
m_result.gradient_enabled = m_chk_gradient->GetValue();
|
||||
|
||||
|
||||
Reference in New Issue
Block a user