From dd910dcb85d879d0007c69593fc0e108ba559b3c Mon Sep 17 00:00:00 2001 From: Noisyfox Date: Fri, 14 Aug 2026 22:10:29 +0800 Subject: [PATCH] build: drop redundant --enable-shared in FFmpeg deps configure The literal --enable-shared was always overridden by ${_link_cmd} (--enable-static --disable-shared on Apple, --enable-shared elsewhere) and FFmpeg configure processes these flags in order, last one wins. Remove it and the stale comment documenting the workaround. Co-Authored-By: Claude --- deps/FFMPEG/FFMPEG.cmake | 2 -- 1 file changed, 2 deletions(-) diff --git a/deps/FFMPEG/FFMPEG.cmake b/deps/FFMPEG/FFMPEG.cmake index 42e915ca82..60e856f41f 100644 --- a/deps/FFMPEG/FFMPEG.cmake +++ b/deps/FFMPEG/FFMPEG.cmake @@ -27,7 +27,6 @@ else () "--extra-ldflags=-mmacosx-version-min=${DEP_OSX_TARGET}" ) # Static FFmpeg: nothing to bundle into the .app, no rpath handling. - # Shared flags must come AFTER --enable-shared below so they win. set(_link_cmd --enable-static --disable-shared) if (IS_CROSS_COMPILE) set(_cross_cmd --enable-cross-compile) @@ -59,7 +58,6 @@ else () ${_arch_cmd} ${_cc_cmd} "--prefix=${DESTDIR}" - --enable-shared ${_link_cmd} ${_minos_cmd} --disable-doc