From c62385214f0b6e5c375a1d653c53f151dcb3cd2c Mon Sep 17 00:00:00 2001 From: Clifford Garwood Date: Thu, 17 Sep 2026 23:23:32 -0400 Subject: [PATCH] Drop two dead lambda captures that only a dev build compiles CameraPopup and StatusPanel each bind a toggle handler that captures this and never uses it, inside an #if !BBL_RELEASE_TO_PUBLIC block. CMakeLists defines that as $, so the block compiles in every configuration except Release - and Release is the only one CI builds. Under -Werror the two captures therefore fail RelWithDebInfo, which is what a development build uses, while CI never sees them. Co-Authored-By: Claude Opus 5 (1M context) --- src/slic3r/GUI/CameraPopup.cpp | 2 +- src/slic3r/GUI/StatusPanel.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/slic3r/GUI/CameraPopup.cpp b/src/slic3r/GUI/CameraPopup.cpp index cc7e00eec6..c4e3c5486c 100644 --- a/src/slic3r/GUI/CameraPopup.cpp +++ b/src/slic3r/GUI/CameraPopup.cpp @@ -82,7 +82,7 @@ CameraPopup::CameraPopup(wxWindow *parent) top_sizer->Add(m_text_liveview_retry, 0, wxALIGN_CENTER_VERTICAL | wxALIGN_LEFT | wxALL, FromDIP(5)); top_sizer->Add(m_switch_liveview_retry, 0, wxALIGN_CENTER_VERTICAL | wxALIGN_RIGHT | wxALL, FromDIP(5)); - m_switch_liveview_retry->Bind(wxEVT_TOGGLEBUTTON, [this](wxCommandEvent &e) { + m_switch_liveview_retry->Bind(wxEVT_TOGGLEBUTTON, [](wxCommandEvent &e) { wxGetApp().app_config->set("liveview", "auto_retry", e.IsChecked()); e.Skip(); }); diff --git a/src/slic3r/GUI/StatusPanel.cpp b/src/slic3r/GUI/StatusPanel.cpp index f7bd41fe84..fb0029edc3 100644 --- a/src/slic3r/GUI/StatusPanel.cpp +++ b/src/slic3r/GUI/StatusPanel.cpp @@ -1462,7 +1462,7 @@ wxBoxSizer *StatusBasePanel::create_monitoring_page() #if !BBL_RELEASE_TO_PUBLIC m_staticText_timelapse->Show(); m_bmToggleBtn_timelapse->Show(); - m_bmToggleBtn_timelapse->Bind(wxEVT_TOGGLEBUTTON, [this](wxCommandEvent &e) { + m_bmToggleBtn_timelapse->Bind(wxEVT_TOGGLEBUTTON, [](wxCommandEvent &e) { if (e.IsChecked()) wxGetApp().getAgent()->start_subscribe("tunnel"); else