juli/OrcaSlicer
1
1
Fork 0
mirror of https://github.com/OrcaSlicer/OrcaSlicer.git synced 2026-09-13 12:07:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix: clear stale paths when merging perimeter regions (#15662)

Browse Source
This commit is contained in:
Kiss Lorand
2026-09-12 20:31:28 +03:00
committed by GitHub
parent db9163ec34
commit c5965fa4d9
1 changed files with 15 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/libslic3r/Layer.cpp
View File

@@ -187,6 +187,12 @@ void Layer::make_perimeters()
{ {
BOOST_LOG_TRIVIAL(trace) << "Generating perimeters for layer " << this->id(); BOOST_LOG_TRIVIAL(trace) << "Generating perimeters for layer " << this->id();
const auto clear_generated_extrusions = [](LayerRegion *layer_region) {
layer_region->perimeters.clear();
layer_region->fills.clear();
layer_region->thin_fills.clear();
};
// keep track of regions whose perimeters we have already generated // keep track of regions whose perimeters we have already generated
std::vector<unsigned char> done(m_regions.size(), false); std::vector<unsigned char> done(m_regions.size(), false);
@@ -218,9 +224,7 @@ void Layer::make_perimeters()
continue; continue;
if (is_perimeter_compatible(*m_object->print(), this_region, other_region)) if (is_perimeter_compatible(*m_object->print(), this_region, other_region))
{ {
other_layerm->perimeters.clear(); clear_generated_extrusions(other_layerm);
other_layerm->fills.clear();
other_layerm->thin_fills.clear();
layerms.push_back(other_layerm); layerms.push_back(other_layerm);
done[it - m_regions.begin()] = true; done[it - m_regions.begin()] = true;
} }
@@ -231,6 +235,10 @@ void Layer::make_perimeters()
(*layerm)->make_perimeters((*layerm)->slices, {*layerm}, &(*layerm)->fill_surfaces, &(*layerm)->fill_no_overlap_expolygons); (*layerm)->make_perimeters((*layerm)->slices, {*layerm}, &(*layerm)->fill_surfaces, &(*layerm)->fill_no_overlap_expolygons);
(*layerm)->fill_expolygons = to_expolygons((*layerm)->fill_surfaces.surfaces); (*layerm)->fill_expolygons = to_expolygons((*layerm)->fill_surfaces.surfaces);
} else { } else {
// Orca: Unlike the compatible regions above, the initiating region has not
// been cleared yet and may contain paths from a previous incompatible run.
clear_generated_extrusions(*layerm);
SurfaceCollection new_slices; SurfaceCollection new_slices;
// Use the region with highest infill rate, as the make_perimeters() function below decides on the gap fill based on the infill existence. // Use the region with highest infill rate, as the make_perimeters() function below decides on the gap fill based on the infill existence.
LayerRegion *layerm_config = layerms.front(); LayerRegion *layerm_config = layerms.front();