juli/OrcaSlicer
1
1
Fork 0
mirror of https://github.com/OrcaSlicer/OrcaSlicer.git synced 2026-05-19 19:33:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes 999 CMake Warnings (#10729)

Browse Source 
* fixes: 999 CMake Warnings at src/dev-utils/CMakeLists.txt:39 (add_custom_command)

* cmake clenup: adds PUBLIC/PRIVATE to libslic3r; attempt to reduce warnigns from eigen
This commit is contained in:
Dipl.-Ing. Raoul Rubien, BSc
2025-09-19 17:52:41 +02:00
committed by GitHub
parent 75ed995b00
commit c228ab2da1
2 changed files with 34 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/dev-utils/CMakeLists.txt
View File

@@ -36,7 +36,7 @@ function(encoding_check TARGET)
# Add checking of each source file as a subcommand of encoding-check-${TARGET} # Add checking of each source file as a subcommand of encoding-check-${TARGET}
foreach(file ${T_SOURCES}) foreach(file ${T_SOURCES})
add_custom_command(TARGET encoding-check-${TARGET} add_custom_command(TARGET encoding-check-${TARGET} PRE_BUILD
COMMAND $<TARGET_FILE:encoding-check> ${TARGET} ${file} COMMAND $<TARGET_FILE:encoding-check> ${TARGET} ${file}
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
) )

64
src/libslic3r/CMakeLists.txt
View File

@@ -552,57 +552,59 @@ set(OCCT_LIBS
find_package(libnoise REQUIRED) find_package(libnoise REQUIRED)
target_link_libraries(libslic3r target_link_libraries(libslic3r
libnest2d PUBLIC
admesh admesh
cereal::cereal libigl
eigen libnest2d
libigl miniz
miniz opencv_world
boost_libs PRIVATE
clipper ${CMAKE_DL_LIBS}
${EXPAT_LIBRARIES} ${EXPAT_LIBRARIES}
glu-libtess ${OCCT_LIBS}
qhull boost_libs
semver cereal::cereal
TBB::tbb clipper
TBB::tbbmalloc eigen
libslic3r_cgal glu-libtess
${CMAKE_DL_LIBS} JPEG::JPEG
PNG::PNG libslic3r_cgal
ZLIB::ZLIB mcut
${OCCT_LIBS} noise::noise
mcut PNG::PNG
JPEG::JPEG qhull
qoi qoi
opencv_world semver
noise::noise TBB::tbb
TBB::tbbmalloc
ZLIB::ZLIB
) )
if(NOT WIN32) if(NOT WIN32)
# Link freetype for OCCT dependency (CAD operations need font rendering) # Link freetype for OCCT dependency (CAD operations need font rendering)
target_link_libraries(libslic3r ${FREETYPE_LIBRARIES}) target_link_libraries(libslic3r PRIVATE ${FREETYPE_LIBRARIES})
target_link_libraries(libslic3r OpenSSL::Crypto) target_link_libraries(libslic3r PRIVATE OpenSSL::Crypto)
if (NOT APPLE) if (NOT APPLE)
target_link_libraries(libslic3r fontconfig) target_link_libraries(libslic3r PRIVATE fontconfig)
endif() endif()
endif() endif()
if (APPLE) if (APPLE)
find_library(FOUNDATION Foundation REQUIRED) find_library(FOUNDATION Foundation REQUIRED)
find_library(MODELIO ModelIO REQUIRED) find_library(MODELIO ModelIO REQUIRED)
target_link_libraries(libslic3r ${FOUNDATION} ${MODELIO}) target_link_libraries(libslic3r PRIVATE ${FOUNDATION} ${MODELIO})
endif () endif ()
if (TARGET OpenVDB::openvdb) if (TARGET OpenVDB::openvdb)
target_link_libraries(libslic3r OpenVDB::openvdb) target_link_libraries(libslic3r PRIVATE OpenVDB::openvdb)
endif() endif()
if(WIN32) if(WIN32)
target_link_libraries(libslic3r Psapi.lib) target_link_libraries(libslic3r PRIVATE Psapi.lib)
endif() endif()
if(SLIC3R_PROFILE) if(SLIC3R_PROFILE)
target_link_libraries(libslic3r Shiny) target_link_libraries(libslic3r PRIVATE Shiny)
endif() endif()
if (SLIC3R_PCH AND NOT SLIC3R_SYNTAXONLY) if (SLIC3R_PCH AND NOT SLIC3R_SYNTAXONLY)