Run every profile maintenance job from one tool (#15726)

* Run every profile maintenance job from one tool

orca_id_tool.py becomes orca_profile_tool.py, and orca_extra_profile_check.py
and orca_filament_lib.py fold into it as subcommands: check, generate-id, fix,
trim, update-index and update-snapshot. The three scripts already overlapped --
the checker imported half of its rules from the id tool, which in turn kept a
copy-pasted set of output helpers to avoid the resulting import cycle -- while
disagreeing on how a vendor is enumerated, how a JSON file is read and what the
exit code means. One file settles all three.

check, normalize, trim and update-index reproduce their predecessors exactly; normalize and
update-index were diffed byte-for-byte against the old scripts over a copy of
the whole tree. Deliberate changes: the compatible-printers check no longer
switches itself off when --check-materials is passed, an error exits 1 rather
than -1, update-index honours --profile-type and reports a profile it cannot
place instead of dropping it from the index, fix and update-index gained
--dry-run, trim keeps an unindexed file some surviving profile still inherits
from, and vendors are enumerated as directories with an index -- which is why
blacklist.json, a data file that an unscoped index rebuild once wrote four empty
list sections into, loses them here and will not collect them again. The dead
rename_filament_system() helper is gone.

The suite under scripts/tests now covers the maintenance commands too, and CI
runs it; nothing there ran in CI before. No shipped profile data changes apart
from those four keys.

* update vendor index files with "python3 ./scripts/orca_profile_tool.py update-index" and "python3 ./scripts/orca_profile_tool.py normalize"

.github/workflows/check_profiles.yml

@@ -9,8 +9,9 @@ on:
     - release/*
     paths:
     - 'resources/profiles/**'
-    # The extra JSON check also validates resources/printers/bambu_filament_ids.json,
-    # and lives in scripts/, so a PR touching only those must still run this workflow.
+    # orca_profile_tool.py also validates resources/printers/bambu_filament_ids.json, and
+    # both it and its tests live in scripts/, so a PR touching only those must still run
+    # this workflow.
     - 'resources/printers/**'
     - 'scripts/**'
     - ".github/workflows/check_profiles.yml"
@@ -36,12 +37,23 @@ jobs:
       - name: Checkout repository
         uses: actions/checkout@v7
 
-      - name: Run extra JSON check
-        id: extra_json_check
+      # Deliberately not continue-on-error, unlike every check below: if the tool itself is
+      # broken, nothing it then reports about the profiles is worth reading.
+      - name: Run the profile tool's own unit tests
+        run: python3 -m unittest discover -s scripts/tests -t scripts
+
+      # What the validator below cannot see. It loads the tree the way the slicer does, so
+      # it never notices a profile no <vendor>.json indexes, a preset name two files claim,
+      # an id that is not the mint of its own triple, or a file that normalize and
+      # update-index would still rewrite.
+      # The step id is the handle the PR comment and the failure gate below use; renaming it
+      # silently disables them.
+      - name: Check profiles (orca_profile_tool.py)
+        id: profile_tool
         continue-on-error: true
         run: |
           set +e
-          python3 ./scripts/orca_extra_profile_check.py 2>&1 | tee ${{ runner.temp }}/extra_json_check.log
+          python3 ./scripts/orca_profile_tool.py check 2>&1 | tee ${{ runner.temp }}/profile_tool.log
           exit ${PIPESTATUS[0]}
 
       # download
@@ -186,7 +198,7 @@ jobs:
           echo "${{ github.event.pull_request.number }}" > ${{ runner.temp }}/profile-check-results/pr_number.txt
 
       - name: Prepare comment artifact
-        if: ${{ always() && github.event_name == 'pull_request' && (steps.extra_json_check.outcome == 'failure' || steps.validate_system.outcome == 'failure' || steps.validate_slice.outcome == 'failure' || steps.validate_filament_subtypes.outcome == 'failure' || steps.validate_custom.outcome == 'failure') }}
+        if: ${{ always() && github.event_name == 'pull_request' && (steps.profile_tool.outcome == 'failure' || steps.validate_system.outcome == 'failure' || steps.validate_slice.outcome == 'failure' || steps.validate_filament_subtypes.outcome == 'failure' || steps.validate_custom.outcome == 'failure') }}
         run: |
           {
             # Marker matched by check_profiles_comment.yml to delete prior comments.
@@ -194,11 +206,11 @@ jobs:
             echo "## :x: Profile Validation Errors"
             echo ""
 
-            if [ "${{ steps.extra_json_check.outcome }}" = "failure" ]; then
-              echo "### Extra JSON Check Failed"
+            if [ "${{ steps.profile_tool.outcome }}" = "failure" ]; then
+              echo "### Profile Check Failed (orca_profile_tool.py)"
               echo ""
               echo '```'
-              head -c 30000 ${{ runner.temp }}/extra_json_check.log || echo "No output captured"
+              head -c 30000 ${{ runner.temp }}/profile_tool.log || echo "No output captured"
               echo '```'
               echo ""
             fi
@@ -240,7 +252,7 @@ jobs:
             fi
 
             echo "---"
-            echo "*Please fix the above errors and push a new commit.*"
+            echo '*Fix the errors above and push a new commit. To reproduce this run locally: `scripts/check_profile.sh`, or `scripts\check_profile.bat` on Windows.*'
           } > ${{ runner.temp }}/profile-check-results/pr_comment.md
 
       - name: Upload comment artifact
@@ -252,7 +264,8 @@ jobs:
           retention-days: 1
 
       - name: Fail if any check failed
-        if: ${{ always() && (steps.extra_json_check.outcome == 'failure' || steps.validate_system.outcome == 'failure' || steps.validate_slice.outcome == 'failure' || steps.validate_filament_subtypes.outcome == 'failure' || steps.validate_custom.outcome == 'failure') }}
+        if: ${{ always() && (steps.profile_tool.outcome == 'failure' || steps.validate_system.outcome == 'failure' || steps.validate_slice.outcome == 'failure' || steps.validate_filament_subtypes.outcome == 'failure' || steps.validate_custom.outcome == 'failure') }}
         run: |
-          echo "One or more profile checks failed. See above for details."
+          echo "One or more profile checks failed; see the step logs above."
+          echo 'Reproduce the whole run locally with scripts/check_profile.sh (scripts\check_profile.bat on Windows).'
           exit 1