From adb0ca3dc316e216d7eb5dbb60a009c78fd5f95d Mon Sep 17 00:00:00 2001 From: Gabriel Date: Wed, 24 Jun 2026 00:36:59 -0300 Subject: [PATCH] fix: use Ninja-compatible build target in build_release_vs.bat ALL_BUILD is a Visual Studio generator target. Ninja uses `all`. When building with -x (Ninja generator), the script fails with "ninja: error: unknown target 'ALL_BUILD'". Use the correct target name for each generator. --- build_release_vs.bat | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build_release_vs.bat b/build_release_vs.bat index 3f1a2e0af4..cc3744ae97 100644 --- a/build_release_vs.bat +++ b/build_release_vs.bat @@ -133,7 +133,7 @@ echo on set CMAKE_POLICY_VERSION_MINIMUM=3.5 if "%USE_NINJA%"=="1" ( cmake .. -G %CMAKE_GENERATOR% -DORCA_TOOLS=ON %SIG_FLAG% -DCMAKE_BUILD_TYPE=%build_type% - cmake --build . --config %build_type% --target ALL_BUILD + cmake --build . --config %build_type% --target all ) else ( cmake .. -G %CMAKE_GENERATOR% -A x64 -DORCA_TOOLS=ON %SIG_FLAG% -DCMAKE_BUILD_TYPE=%build_type% cmake --build . --config %build_type% --target ALL_BUILD -- -m