From ad737d1080cb6057d03a44a12169ffd51009e51b Mon Sep 17 00:00:00 2001 From: SoftFever Date: Sat, 30 May 2026 09:57:41 +0800 Subject: [PATCH] ci(windows): reset exit code after accepting untrusted test-cert root The verify script accepted both signed binaries and printed "verification passed", but the step still failed: signtool exits 1 on the untrusted test root, and GitHub's pwsh wrapper exits with that lingering $LASTEXITCODE. Add an explicit `exit 0` on the success path so the step passes. --- scripts/verify-authenticode.ps1 | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/scripts/verify-authenticode.ps1 b/scripts/verify-authenticode.ps1 index 676ef5d579..69394d8205 100644 --- a/scripts/verify-authenticode.ps1 +++ b/scripts/verify-authenticode.ps1 @@ -102,3 +102,8 @@ foreach ($relativePath in $Files) { } Write-Host "Authenticode verification passed." + +# signtool exits non-zero for the untrusted test-cert root even when we accept +# it above, leaving $LASTEXITCODE = 1. The GitHub Actions pwsh wrapper exits +# with that lingering code, so reset it to report success explicitly. +exit 0