juli/OrcaSlicer
1
1
Fork 0
mirror of https://github.com/OrcaSlicer/OrcaSlicer.git synced 2026-05-17 10:32:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix crash in printer config when switching tabs (#6537)

Browse Source 
* Fix ASAN with MSVC

* Make ASAN happy

* Avoid deleting activated tab button by not calling `DeleteAllItems` (#SoftFever/OrcaSlicer#6486)
This commit is contained in:
Noisyfox
2024-08-23 22:55:10 +08:00
committed by GitHub
parent d1b9ef427e
commit a68fc86c4e
4 changed files with 33 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/slic3r/GUI/Widgets/TabCtrl.cpp
View File

@@ -117,7 +117,23 @@ int TabCtrl::AppendItem(const wxString &item,
bool TabCtrl::DeleteItem(int item)
{
return false;
if (item < 0 || item >= btns.size()) {
return false;
}
Button* btn = btns[item];
btn->Destroy();
btns.erase(btns.begin() + item);
sizer->Remove(item * 2);
if (btns.size() > 1)
sizer->GetItem(sizer->GetItemCount() - 1)->SetMinSize({0, 0});
relayout();
if (sel >= item) {
sel--;
sendTabCtrlEvent();
}
return true;
}
void TabCtrl::DeleteAllItems()