juli/OrcaSlicer
1
1
Fork 0
mirror of https://github.com/OrcaSlicer/OrcaSlicer.git synced 2026-05-17 10:32:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix: Crash when changing type of SVG / TEXT volume to Support Blocker / Enforcer (#13120)

Browse Source 
init
This commit is contained in:
yw4z
2026-04-26 15:29:56 +03:00
committed by GitHub
parent 087eeaf3df
commit a2a62c30f7
1 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/slic3r/GUI/GUI_Factories.cpp
View File

@@ -777,17 +777,37 @@ wxMenuItem* MenuFactory::append_menu_item_change_type(wxMenu* menu)
// Update checkmark dynamically when menu is shown - check all selected volumes // Update checkmark dynamically when menu is shown - check all selected volumes
m_parent->Bind(wxEVT_UPDATE_UI, [type = info.type](wxUpdateUIEvent& evt) { m_parent->Bind(wxEVT_UPDATE_UI, [type = info.type](wxUpdateUIEvent& evt) {
auto model = obj_list()->GetModel();
auto objs = obj_list()->objects();
bool has_type = false; bool has_type = false;
wxDataViewItemArray sels; wxDataViewItemArray sels;
obj_list()->GetSelections(sels); obj_list()->GetSelections(sels);
for (auto item : sels) { for (auto item : sels) {
ModelVolumeType vol_type = obj_list()->GetModel()->GetVolumeType(item); ModelVolumeType vol_type = model->GetVolumeType(item);
if (vol_type == type) { if (vol_type == type) {
has_type = true; has_type = true;
break; break;
} }
} }
evt.Check(has_type); evt.Check(has_type);
// ORCA Fix crash caused by SVG/TEXT volumes cant be Support Enforcer/Blocker type
for (auto item : sels) {
if (model->GetItemType(item) == itVolume){
auto vol_idx = model->GetVolumeIdByItem(item);
auto obj_idx = model->GetObjectIdByItem(item);
if (vol_idx < 0 || obj_idx < 0)
continue;
auto vol = (*objs)[obj_idx]->volumes[vol_idx];
// disable Support Enforcer/Blocker if selection contains svg or text
if (vol != nullptr && (vol->is_svg() || vol->is_text()) && (type == ModelVolumeType::SUPPORT_BLOCKER || type == ModelVolumeType::SUPPORT_ENFORCER)){
evt.Enable(false);
break;
}
}
}
}, item->GetId()); }, item->GetId());
} }