juli/OrcaSlicer
1
1
Fork 0
mirror of https://github.com/OrcaSlicer/OrcaSlicer.git synced 2026-07-27 12:52:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix crash when deleting filaments after a profile switch (#14055)

Browse Source
This commit is contained in:
Ioannis Giannakas
2026-06-05 14:27:20 +03:00
committed by GitHub
parent 081577fcfa
commit 9c6a3b1054
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/slic3r/GUI/PartPlate.cpp
View File

@@ -3762,7 +3762,11 @@ void PartPlate::on_filament_deleted(int filament_count, int filament_id)
{ {
if (m_config.has("filament_map")) { if (m_config.has("filament_map")) {
std::vector<int>& filament_maps = m_config.option<ConfigOptionInts>("filament_map")->values; std::vector<int>& filament_maps = m_config.option<ConfigOptionInts>("filament_map")->values;
filament_maps.erase(filament_maps.begin() + filament_id); // Guard against an out-of-range index: the per-plate filament_map can be out of sync
// with the global filament count, and erasing at/past end() triggers an out-of-bounds
// memmove (crash on macOS, see PartPlate::on_filament_deleted in crash reports).
if (filament_id >= 0 && filament_id < (int) filament_maps.size())
filament_maps.erase(filament_maps.begin() + filament_id);
} }
update_first_layer_print_sequence_when_delete_filament(filament_id); update_first_layer_print_sequence_when_delete_filament(filament_id);
} }