mirror of
https://github.com/OrcaSlicer/OrcaSlicer.git
synced 2026-09-14 12:37:46 +00:00
ci: dedupe profile-validation PR comments, clean up on success
This commit is contained in:
14
.github/workflows/check_profiles.yml
vendored
14
.github/workflows/check_profiles.yml
vendored
@@ -101,12 +101,18 @@ jobs:
|
|||||||
./OrcaSlicer_profile_validator -p ${{ github.workspace }}/resources/profiles -l 2 2>&1 | tee ${{ runner.temp }}/validate_custom.log
|
./OrcaSlicer_profile_validator -p ${{ github.workspace }}/resources/profiles -l 2 2>&1 | tee ${{ runner.temp }}/validate_custom.log
|
||||||
exit ${PIPESTATUS[0]}
|
exit ${PIPESTATUS[0]}
|
||||||
|
|
||||||
|
- name: Prepare PR number for comment workflow
|
||||||
|
if: ${{ always() && github.event_name == 'pull_request' }}
|
||||||
|
run: |
|
||||||
|
mkdir -p ${{ runner.temp }}/profile-check-results
|
||||||
|
echo "${{ github.event.pull_request.number }}" > ${{ runner.temp }}/profile-check-results/pr_number.txt
|
||||||
|
|
||||||
- name: Prepare comment artifact
|
- name: Prepare comment artifact
|
||||||
if: ${{ always() && github.event_name == 'pull_request' && (steps.extra_json_check.outcome == 'failure' || steps.indentation_check.outcome == 'failure' || steps.validate_system.outcome == 'failure' || steps.validate_custom.outcome == 'failure') }}
|
if: ${{ always() && github.event_name == 'pull_request' && (steps.extra_json_check.outcome == 'failure' || steps.indentation_check.outcome == 'failure' || steps.validate_system.outcome == 'failure' || steps.validate_custom.outcome == 'failure') }}
|
||||||
run: |
|
run: |
|
||||||
mkdir -p ${{ runner.temp }}/profile-check-results
|
|
||||||
|
|
||||||
{
|
{
|
||||||
|
# Marker matched by check_profiles_comment.yml to delete prior comments.
|
||||||
|
echo "<!-- profile-validation-comment -->"
|
||||||
echo "## :x: Profile Validation Errors"
|
echo "## :x: Profile Validation Errors"
|
||||||
echo ""
|
echo ""
|
||||||
|
|
||||||
@@ -150,10 +156,8 @@ jobs:
|
|||||||
echo "*Please fix the above errors and push a new commit.*"
|
echo "*Please fix the above errors and push a new commit.*"
|
||||||
} > ${{ runner.temp }}/profile-check-results/pr_comment.md
|
} > ${{ runner.temp }}/profile-check-results/pr_comment.md
|
||||||
|
|
||||||
echo "${{ github.event.pull_request.number }}" > ${{ runner.temp }}/profile-check-results/pr_number.txt
|
|
||||||
|
|
||||||
- name: Upload comment artifact
|
- name: Upload comment artifact
|
||||||
if: ${{ always() && github.event_name == 'pull_request' && (steps.extra_json_check.outcome == 'failure' || steps.indentation_check.outcome == 'failure' || steps.validate_system.outcome == 'failure' || steps.validate_custom.outcome == 'failure') }}
|
if: ${{ always() && github.event_name == 'pull_request' }}
|
||||||
uses: actions/upload-artifact@v7
|
uses: actions/upload-artifact@v7
|
||||||
with:
|
with:
|
||||||
name: profile-check-results
|
name: profile-check-results
|
||||||
|
|||||||
30
.github/workflows/check_profiles_comment.yml
vendored
30
.github/workflows/check_profiles_comment.yml
vendored
@@ -10,12 +10,19 @@ on:
|
|||||||
|
|
||||||
permissions:
|
permissions:
|
||||||
pull-requests: write
|
pull-requests: write
|
||||||
|
# Needed to delete outdated bot comments via the issues/comments endpoint.
|
||||||
|
issues: write
|
||||||
|
|
||||||
|
# Serialize handlers per source branch so parallel runs don't race delete-and-post.
|
||||||
|
concurrency:
|
||||||
|
group: ${{ github.workflow }}-${{ github.event.workflow_run.head_repository.full_name }}-${{ github.event.workflow_run.head_branch }}
|
||||||
|
cancel-in-progress: false
|
||||||
|
|
||||||
jobs:
|
jobs:
|
||||||
post_comment:
|
post_comment:
|
||||||
name: Post PR comment
|
name: Post PR comment
|
||||||
runs-on: ubuntu-24.04
|
runs-on: ubuntu-24.04
|
||||||
if: ${{ github.event.workflow_run.event == 'pull_request' && github.event.workflow_run.conclusion == 'failure' }}
|
if: ${{ github.event.workflow_run.event == 'pull_request' && (github.event.workflow_run.conclusion == 'success' || github.event.workflow_run.conclusion == 'failure') }}
|
||||||
steps:
|
steps:
|
||||||
- name: Download artifact
|
- name: Download artifact
|
||||||
id: download
|
id: download
|
||||||
@@ -26,14 +33,14 @@ jobs:
|
|||||||
run-id: ${{ github.event.workflow_run.id }}
|
run-id: ${{ github.event.workflow_run.id }}
|
||||||
github-token: ${{ github.token }}
|
github-token: ${{ github.token }}
|
||||||
|
|
||||||
- name: Post comment on PR
|
- name: Update PR comment
|
||||||
if: ${{ steps.download.outcome == 'success' }}
|
if: ${{ steps.download.outcome == 'success' }}
|
||||||
env:
|
env:
|
||||||
GH_TOKEN: ${{ github.token }}
|
GH_TOKEN: ${{ github.token }}
|
||||||
GH_REPO: ${{ github.repository }}
|
GH_REPO: ${{ github.repository }}
|
||||||
run: |
|
run: |
|
||||||
if [ ! -f pr_number.txt ] || [ ! -f pr_comment.md ]; then
|
if [ ! -f pr_number.txt ]; then
|
||||||
echo "No comment artifact found, skipping."
|
echo "No pr_number.txt in artifact, skipping."
|
||||||
exit 0
|
exit 0
|
||||||
fi
|
fi
|
||||||
|
|
||||||
@@ -43,4 +50,17 @@ jobs:
|
|||||||
exit 1
|
exit 1
|
||||||
fi
|
fi
|
||||||
|
|
||||||
gh pr comment "$PR_NUMBER" --body-file pr_comment.md
|
# Delete prior comments matching the marker (from check_profiles.yml) or the legacy heading.
|
||||||
|
OLD_IDS=$(gh api --paginate "repos/${GH_REPO}/issues/${PR_NUMBER}/comments" \
|
||||||
|
--jq '.[] | select(.user.login == "github-actions[bot]") | select((.body | startswith("<!-- profile-validation-comment -->")) or (.body | startswith("## :x: Profile Validation Errors"))) | .id')
|
||||||
|
for comment_id in $OLD_IDS; do
|
||||||
|
echo "Deleting outdated profile-validation comment ${comment_id}"
|
||||||
|
gh api -X DELETE "repos/${GH_REPO}/issues/comments/${comment_id}" || true
|
||||||
|
done
|
||||||
|
|
||||||
|
# Post a new comment only when validation failed (pr_comment.md present).
|
||||||
|
if [ -f pr_comment.md ]; then
|
||||||
|
gh pr comment "$PR_NUMBER" --body-file pr_comment.md
|
||||||
|
else
|
||||||
|
echo "Validation succeeded; cleaned up prior comments without posting."
|
||||||
|
fi
|
||||||
|
|||||||
Reference in New Issue
Block a user