mirror of
https://github.com/OrcaSlicer/OrcaSlicer.git
synced 2026-10-05 23:01:17 +00:00
Add Missing Includes Across the Remaining Sources and Tests (#16071)
* Ignore Clipper, libpng, mcut and Boost.Polygon Internals in clang-tidy Each only works through a wrapper or umbrella header: libslic3r/clipper.hpp or clipper_z.hpp configure Clipper before including it, png.h pulls in libpng's config headers, and Boost.Polygon's headers only compile through polygon.hpp or voronoi.hpp. * Ignore minilzo's Config Headers in clang-tidy lzoconf.h and lzodefs.h are internal to minilzo.h, which is what the code includes. * Add Missing Includes Across the Remaining Sources and Tests Covers src/slic3r/Utils, src/slic3r/plugin, src/slic3r/Config, src/libvgcode, src/dev-utils, src/OrcaSlicer.cpp and tests/, the directories left after src/slic3r/GUI and src/libslic3r. Generated with clang-tidy misc-include-cleaner. libvgcode's own headers are included by relative path as in the rest of that library, and Catch2 and pybind11 with angle brackets as elsewhere in the repo. * Make the GUI and Test Headers Compile on Their Own Each now includes, or forward-declares, what it uses instead of relying on what its includers happened to include first. Headers that only compile on one platform, or that nothing built includes, are left alone. * Keep Windows and nanosvg Setup Ahead of the Added Includes OrcaSlicer.cpp and several tests set _WIN32_WINNT, WIN32_LEAN_AND_MEAN or NOMINMAX before including Windows.h, and the profile validator defines NANOSVG_IMPLEMENTATION before any libslic3r header. The added includes had landed above those blocks, which broke the Windows build. * Add the GUI Includes the First Pass Missed Covers headers that only became editable once they compiled on their own, and wx symbols whose suggested header changed as the clang-tidy ignore list grew after the src/slic3r/GUI pass. * Keep the Added Test Includes Below the NOMINMAX Guard test_marchingsquares.cpp and test_texture_displacement.cpp had includes inside #ifndef NOMINMAX, which the tests inherit as defined on Windows from libslic3r, so those were skipped there. .clang-tidy also ignores the MSVC STL and UCRT internals, Boost.Multiprecision's fwd.hpp and CPython's Windows include directory, as in #16068.
This commit is contained in:
@@ -6,6 +6,8 @@
|
||||
#define VGCODE_COLORPRINT_HPP
|
||||
|
||||
#include "../include/Types.hpp"
|
||||
#include <cstdint>
|
||||
#include <array>
|
||||
|
||||
namespace libvgcode {
|
||||
|
||||
|
||||
@@ -7,7 +7,10 @@
|
||||
|
||||
#include "../include/Types.hpp"
|
||||
|
||||
#include <array>
|
||||
#include <cfloat>
|
||||
#include <vector>
|
||||
#include <cstddef>
|
||||
|
||||
namespace libvgcode {
|
||||
|
||||
|
||||
@@ -6,6 +6,8 @@
|
||||
#define VGCODE_GCODEINPUTDATA_HPP
|
||||
|
||||
#include "PathVertex.hpp"
|
||||
#include <vector>
|
||||
#include "Types.hpp"
|
||||
|
||||
namespace libvgcode {
|
||||
|
||||
|
||||
@@ -7,7 +7,9 @@
|
||||
|
||||
#include "Types.hpp"
|
||||
|
||||
#include <array>
|
||||
#include <cfloat>
|
||||
#include <cstdint>
|
||||
|
||||
namespace libvgcode {
|
||||
|
||||
|
||||
@@ -5,6 +5,7 @@
|
||||
#ifndef VGCODE_TYPES_HPP
|
||||
#define VGCODE_TYPES_HPP
|
||||
|
||||
#include <cstddef>
|
||||
#define VGCODE_ENABLE_COG_AND_TOOL_MARKERS 0
|
||||
|
||||
#include <array>
|
||||
|
||||
@@ -7,7 +7,10 @@
|
||||
|
||||
#include "Types.hpp"
|
||||
|
||||
#include <cstddef>
|
||||
#include <cstdint>
|
||||
#include <string>
|
||||
#include <vector>
|
||||
|
||||
namespace libvgcode {
|
||||
|
||||
|
||||
@@ -6,6 +6,9 @@
|
||||
#define VGCODE_BITSET_HPP
|
||||
|
||||
#include <atomic>
|
||||
#include <cstddef>
|
||||
#include <type_traits>
|
||||
#include <utility>
|
||||
#include <vector>
|
||||
|
||||
namespace libvgcode {
|
||||
|
||||
@@ -7,8 +7,13 @@
|
||||
#include "Utils.hpp"
|
||||
|
||||
#include <algorithm>
|
||||
#include <array>
|
||||
#include <assert.h>
|
||||
#include <cfloat>
|
||||
#include <cmath>
|
||||
#include "../include/Types.hpp"
|
||||
#include <cstddef>
|
||||
#include <vector>
|
||||
|
||||
namespace libvgcode {
|
||||
|
||||
|
||||
@@ -3,6 +3,11 @@
|
||||
///|/ libvgcode is released under the terms of the AGPLv3 or higher
|
||||
///|/
|
||||
#include "ExtrusionRoles.hpp"
|
||||
#include "../include/Types.hpp"
|
||||
#include <array>
|
||||
#include <utility>
|
||||
#include <cstddef>
|
||||
#include <vector>
|
||||
|
||||
namespace libvgcode {
|
||||
|
||||
|
||||
@@ -7,7 +7,10 @@
|
||||
|
||||
#include "../include/Types.hpp"
|
||||
|
||||
#include <array>
|
||||
#include <cstddef>
|
||||
#include <map>
|
||||
#include <vector>
|
||||
|
||||
namespace libvgcode {
|
||||
|
||||
|
||||
@@ -9,6 +9,11 @@
|
||||
|
||||
#include <assert.h>
|
||||
#include <algorithm>
|
||||
#include "../include/Types.hpp"
|
||||
#include <cstdint>
|
||||
#include <cstddef>
|
||||
#include <vector>
|
||||
#include <iterator>
|
||||
|
||||
namespace libvgcode {
|
||||
|
||||
|
||||
@@ -6,6 +6,11 @@
|
||||
#define VGCODE_LAYERS_HPP
|
||||
|
||||
#include "Range.hpp"
|
||||
#include <cstdint>
|
||||
#include <cstddef>
|
||||
#include "../include/Types.hpp"
|
||||
#include <array>
|
||||
#include <vector>
|
||||
|
||||
namespace libvgcode {
|
||||
|
||||
|
||||
@@ -10,6 +10,7 @@
|
||||
#include <cctype>
|
||||
#include <stdio.h>
|
||||
#include <cstring>
|
||||
#include <string>
|
||||
|
||||
namespace libvgcode {
|
||||
|
||||
|
||||
@@ -6,6 +6,9 @@
|
||||
#include "OpenGLUtils.hpp"
|
||||
#include "Utils.hpp"
|
||||
|
||||
#include <cstdint>
|
||||
#include "../include/Types.hpp"
|
||||
#include <cstddef>
|
||||
#include <vector>
|
||||
#include <algorithm>
|
||||
#include <cmath>
|
||||
|
||||
@@ -3,6 +3,7 @@
|
||||
///|/ libvgcode is released under the terms of the AGPLv3 or higher
|
||||
///|/
|
||||
#include "../include/PathVertex.hpp"
|
||||
#include "../include/Types.hpp"
|
||||
|
||||
namespace libvgcode {
|
||||
|
||||
|
||||
@@ -5,6 +5,7 @@
|
||||
#include "Range.hpp"
|
||||
|
||||
#include <algorithm>
|
||||
#include "../include/Types.hpp"
|
||||
|
||||
namespace libvgcode {
|
||||
|
||||
|
||||
@@ -5,6 +5,7 @@
|
||||
#include "SegmentTemplate.hpp"
|
||||
#include "OpenGLUtils.hpp"
|
||||
|
||||
#include <cstddef>
|
||||
#include <cstdint>
|
||||
#include <array>
|
||||
|
||||
|
||||
@@ -7,6 +7,8 @@
|
||||
|
||||
#include "../include/Types.hpp"
|
||||
|
||||
#include <array>
|
||||
#include <cstddef>
|
||||
#include <map>
|
||||
|
||||
namespace libvgcode {
|
||||
|
||||
@@ -7,6 +7,7 @@
|
||||
#include "Utils.hpp"
|
||||
|
||||
#include <cmath>
|
||||
#include "../include/Types.hpp"
|
||||
|
||||
#if VGCODE_ENABLE_COG_AND_TOOL_MARKERS
|
||||
|
||||
|
||||
@@ -5,6 +5,7 @@
|
||||
#include "../include/Types.hpp"
|
||||
|
||||
#include <algorithm>
|
||||
#include <cstdint>
|
||||
|
||||
namespace libvgcode {
|
||||
|
||||
|
||||
@@ -6,6 +6,9 @@
|
||||
|
||||
#include <assert.h>
|
||||
#include <cmath>
|
||||
#include "../include/Types.hpp"
|
||||
#include <vector>
|
||||
#include <cstdint>
|
||||
|
||||
namespace libvgcode {
|
||||
|
||||
|
||||
@@ -6,6 +6,8 @@
|
||||
#define VGCODE_UTILS_HPP
|
||||
|
||||
#include "../include/Types.hpp"
|
||||
#include <vector>
|
||||
#include <cstdint>
|
||||
|
||||
#ifdef _WIN32
|
||||
#define STDVEC_MEMSIZE(NAME, TYPE) NAME.capacity() * ((sizeof(TYPE) + __alignof(TYPE) - 1) / __alignof(TYPE)) * __alignof(TYPE)
|
||||
|
||||
@@ -3,6 +3,7 @@
|
||||
///|/ libvgcode is released under the terms of the AGPLv3 or higher
|
||||
///|/
|
||||
#include "ViewRange.hpp"
|
||||
#include "../include/Types.hpp"
|
||||
|
||||
namespace libvgcode {
|
||||
|
||||
|
||||
@@ -6,6 +6,7 @@
|
||||
#define VGCODE_VIEWRANGE_HPP
|
||||
|
||||
#include "Range.hpp"
|
||||
#include "../include/Types.hpp"
|
||||
|
||||
namespace libvgcode {
|
||||
|
||||
|
||||
@@ -4,6 +4,12 @@
|
||||
///|/
|
||||
#include "../include/Viewer.hpp"
|
||||
#include "ViewerImpl.hpp"
|
||||
#include <string>
|
||||
#include <utility>
|
||||
#include "../include/Types.hpp"
|
||||
#include <cstddef>
|
||||
#include <vector>
|
||||
#include <cstdint>
|
||||
|
||||
namespace libvgcode {
|
||||
|
||||
|
||||
@@ -9,14 +9,26 @@
|
||||
#include "OpenGLUtils.hpp"
|
||||
#include "Utils.hpp"
|
||||
|
||||
#include <cstdint>
|
||||
#include "../include/Types.hpp"
|
||||
#include <array>
|
||||
#include "../include/PathVertex.hpp"
|
||||
#include "Bitset.hpp"
|
||||
#include "../include/ColorPrint.hpp"
|
||||
#include <cfloat>
|
||||
#include <iterator>
|
||||
#include <map>
|
||||
#include <assert.h>
|
||||
#include <optional>
|
||||
#include <stdexcept>
|
||||
#include <cstdio>
|
||||
#include <string>
|
||||
#include <algorithm>
|
||||
#include <cmath>
|
||||
#include <numeric>
|
||||
#include <type_traits>
|
||||
#include <vector>
|
||||
#include <utility>
|
||||
|
||||
namespace libvgcode {
|
||||
|
||||
|
||||
@@ -8,6 +8,12 @@
|
||||
#include "Settings.hpp"
|
||||
#include "SegmentTemplate.hpp"
|
||||
#include "OptionTemplate.hpp"
|
||||
#include "../include/Types.hpp"
|
||||
#include <vector>
|
||||
#include <cstddef>
|
||||
#include <cstdint>
|
||||
#include <map>
|
||||
#include <array>
|
||||
#if VGCODE_ENABLE_COG_AND_TOOL_MARKERS
|
||||
#include "CogMarker.hpp"
|
||||
#include "ToolMarker.hpp"
|
||||
|
||||
Reference in New Issue
Block a user