Shellcheck everything (#10730)

* Shellcheck all shell scripts

* Implement Shellcheck's recommendations

* Shellcheck the distribution-specific files

* Include the distro scripts to trigger action

* Fix array usage (hopefully)

* Use single-quote string

TIL: single quote string in yaml treats everything as literal, but
double quote allows backslash escaping.

* Make all cmake commands use set+-x dance and fix macos getopts line

Make Claude happy

getopts has colon after a command which takes an argument

---------

Co-authored-by: SoftFever <softfeverever@gmail.com>

scripts/pack_profiles.sh

@@ -59,14 +59,14 @@ for VENDOR in "$@"; do
 done
 
 # Create zip file
-cd "$TEMP_DIR"
+pushd "$TEMP_DIR" || exit 1
 zip -r "$OUTPUT_FILE" profiles/
 
 # Move zip file to original directory
 mv "$OUTPUT_FILE" "$ORIGINAL_DIR/"
 
 # Return to original directory
-cd "$ORIGINAL_DIR"
+popd || exit 1
 
 # Clean up
 rm -rf "$TEMP_DIR"
@@ -78,4 +78,4 @@ if [ -f "$OUTPUT_FILE" ]; then
 else
     echo "Error: Failed to create zip file"
     exit 1
-fi 
+fi