Shellcheck everything (#10730)

* Shellcheck all shell scripts

* Implement Shellcheck's recommendations

* Shellcheck the distribution-specific files

* Include the distro scripts to trigger action

* Fix array usage (hopefully)

* Use single-quote string

TIL: single quote string in yaml treats everything as literal, but
double quote allows backslash escaping.

* Make all cmake commands use set+-x dance and fix macos getopts line

Make Claude happy

getopts has colon after a command which takes an argument

---------

Co-authored-by: SoftFever <softfeverever@gmail.com>
This commit is contained in:
coryrc
2025-09-19 21:12:31 -04:00
committed by GitHub
parent fa6a73ec5e
commit 7aa3ce8a4d
11 changed files with 90 additions and 65 deletions

View File

@@ -1,6 +1,6 @@
#!/bin/bash
SCRIPT_DIR=$(cd -P -- "$(dirname -- "$0")" && printf '%s\n' "$(pwd -P)")
PROJECT_ROOT=$(dirname "$SCRIPT_DIR")
PROJECT_ROOT="$(dirname "$SCRIPT_DIR")"
set -x
# Wishlist hint: For developers, creating a Docker Compose
@@ -9,9 +9,9 @@ set -x
# the simplicity of a single Docker image and a one-time compilation
# seems better.
docker build -t orcaslicer \
--build-arg USER=$USER \
--build-arg UID=$(id -u) \
--build-arg GID=$(id -g) \
--build-arg NCORES=$NCORES \
--build-arg USER="$USER" \
--build-arg UID="$(id -u)" \
--build-arg GID="$(id -g)" \
--build-arg NCORES="$NCORES" \
-f "$SCRIPT_DIR/Dockerfile" \
$PROJECT_ROOT
"$PROJECT_ROOT"